use auto-build for cdr modules
[asterisk/asterisk.git] / channels / chan_features.c
old mode 100755 (executable)
new mode 100644 (file)
index 3126688..f8047d3
 /*
- * Asterisk -- A telephony toolkit for Linux.
+ * Asterisk -- An open source telephony toolkit.
  *
- * feature Proxy Channel
- * 
- * Copyright (C) 1999, Mark Spencer
+ * Copyright (C) 1999 - 2005, Digium, Inc.
+ *
+ * Mark Spencer <markster@digium.com>
  *
- * Mark Spencer <markster@linux-support.net>
+ * See http://www.asterisk.org for more information about
+ * the Asterisk project. Please do not directly contact
+ * any of the maintainers of this project for assistance;
+ * the project provides a web site, mailing lists and IRC
+ * channels for your use.
  *
  * This program is free software, distributed under the terms of
- * the GNU General Public License
+ * the GNU General Public License Version 2. See the LICENSE file
+ * at the top of the source tree.
+ */
+
+/*! \file
+ *
+ * \brief feature Proxy Channel
+ *
+ * \author Mark Spencer <markster@digium.com>
+ *
+ * \note *** Experimental code ****
+ * 
+ * \ingroup channel_drivers
  */
 
 #include <stdio.h>
 #include <string.h>
-#include <asterisk/lock.h>
-#include <asterisk/channel.h>
-#include <asterisk/channel_pvt.h>
-#include <asterisk/config.h>
-#include <asterisk/logger.h>
-#include <asterisk/module.h>
-#include <asterisk/pbx.h>
-#include <asterisk/options.h>
-#include <asterisk/lock.h>
-#include <asterisk/sched.h>
-#include <asterisk/io.h>
-#include <asterisk/rtp.h>
-#include <asterisk/acl.h>
-#include <asterisk/callerid.h>
-#include <asterisk/file.h>
-#include <asterisk/cli.h>
-#include <asterisk/app.h>
-#include <asterisk/musiconhold.h>
-#include <asterisk/manager.h>
+#include <unistd.h>
 #include <sys/socket.h>
 #include <errno.h>
-#include <unistd.h>
 #include <stdlib.h>
 #include <fcntl.h>
 #include <netdb.h>
+#include <netinet/in.h>
 #include <arpa/inet.h>
 #include <sys/signal.h>
 
-
-static char *desc = "Feature Proxy Channel";
-static char *type = "Feature";
-static char *tdesc = "Feature Proxy Channel Driver";
-
-static int capability = -1;
+#include "asterisk.h"
+
+ASTERISK_FILE_VERSION(__FILE__, "$Revision$")
+
+#include "asterisk/lock.h"
+#include "asterisk/channel.h"
+#include "asterisk/config.h"
+#include "asterisk/logger.h"
+#include "asterisk/module.h"
+#include "asterisk/pbx.h"
+#include "asterisk/options.h"
+#include "asterisk/lock.h"
+#include "asterisk/sched.h"
+#include "asterisk/io.h"
+#include "asterisk/rtp.h"
+#include "asterisk/acl.h"
+#include "asterisk/callerid.h"
+#include "asterisk/file.h"
+#include "asterisk/cli.h"
+#include "asterisk/app.h"
+#include "asterisk/musiconhold.h"
+#include "asterisk/manager.h"
+#include "asterisk/stringfields.h"
+
+static const char desc[] = "Feature Proxy Channel";
+static const char tdesc[] = "Feature Proxy Channel Driver";
 
 static int usecnt =0;
 AST_MUTEX_DEFINE_STATIC(usecnt_lock);
 
 #define IS_OUTBOUND(a,b) (a == b->chan ? 1 : 0)
 
-/* Protect the interface list (of feature_pvt's) */
-AST_MUTEX_DEFINE_STATIC(featurelock);
-
 struct feature_sub {
        struct ast_channel *owner;
        int inthreeway;
        int pfd;
+       int timingfdbackup;
+       int alertpipebackup[2];
 };
 
-static struct feature_pvt {
-       ast_mutex_t lock;                               /* Channel private lock */
-       char tech[AST_MAX_EXTENSION];   /* Technology to abstract */
-       char dest[AST_MAX_EXTENSION];   /* Destination to abstract */
+struct feature_pvt {
+       ast_mutex_t lock;                       /* Channel private lock */
+       char tech[AST_MAX_EXTENSION];           /* Technology to abstract */
+       char dest[AST_MAX_EXTENSION];           /* Destination to abstract */
        struct ast_channel *subchan;
        struct feature_sub subs[3];             /* Subs */
-       struct ast_channel *owner;                      /* Current Master Channel */
-       struct feature_pvt *next;                               /* Next entity */
-} *features = NULL;
+       struct ast_channel *owner;              /* Current Master Channel */
+       AST_LIST_ENTRY(feature_pvt) list;       /* Next entity */
+};
+
+static AST_LIST_HEAD_STATIC(features, feature_pvt);
 
-#define SUB_REAL               0                       /* Active call */
+#define SUB_REAL       0                       /* Active call */
 #define SUB_CALLWAIT   1                       /* Call-Waiting call on hold */
 #define SUB_THREEWAY   2                       /* Three-way call */
 
+static struct ast_channel *features_request(const char *type, int format, void *data, int *cause);
+static int features_digit(struct ast_channel *ast, char digit);
+static int features_call(struct ast_channel *ast, char *dest, int timeout);
+static int features_hangup(struct ast_channel *ast);
+static int features_answer(struct ast_channel *ast);
+static struct ast_frame *features_read(struct ast_channel *ast);
+static int features_write(struct ast_channel *ast, struct ast_frame *f);
+static int features_indicate(struct ast_channel *ast, int condition);
+static int features_fixup(struct ast_channel *oldchan, struct ast_channel *newchan);
+
+static const struct ast_channel_tech features_tech = {
+       .type = "Feature",
+       .description = tdesc,
+       .capabilities = -1,
+       .requester = features_request,
+       .send_digit = features_digit,
+       .call = features_call,
+       .hangup = features_hangup,
+       .answer = features_answer,
+       .read = features_read,
+       .write = features_write,
+       .exception = features_read,
+       .indicate = features_indicate,
+       .fixup = features_fixup,
+};
+
 static inline void init_sub(struct feature_sub *sub)
 {
        sub->inthreeway = 0;
        sub->pfd = -1;
+       sub->timingfdbackup = -1;
+       sub->alertpipebackup[0] = sub->alertpipebackup[1] = -1;
 }
 
 static inline int indexof(struct feature_pvt *p, struct ast_channel *owner, int nullok)
@@ -89,13 +136,14 @@ static inline int indexof(struct feature_pvt *p, struct ast_channel *owner, int
                ast_log(LOG_WARNING, "indexof called on NULL owner??\n");
                return -1;
        }
-       for (x=0;x<3;x++) {
+       for (x=0; x<3; x++) {
                if (owner == p->subs[x].owner)
                        return x;
        }
        return -1;
 }
 
+#if 0
 static void wakeup_sub(struct feature_pvt *p, int a)
 {
        struct ast_frame null = { AST_FRAME_NULL, };
@@ -114,10 +162,49 @@ static void wakeup_sub(struct feature_pvt *p, int a)
                        break;
        }
 }
+#endif
 
-static void swap_subs(struct feature_pvt *p, int a, int b)
+static void restore_channel(struct feature_pvt *p, int index)
+{
+       /* Restore timing/alertpipe */
+       p->subs[index].owner->timingfd = p->subs[index].timingfdbackup;
+       p->subs[index].owner->alertpipe[0] = p->subs[index].alertpipebackup[0];
+       p->subs[index].owner->alertpipe[1] = p->subs[index].alertpipebackup[1];
+       p->subs[index].owner->fds[AST_ALERT_FD] = p->subs[index].alertpipebackup[0];
+       p->subs[index].owner->fds[AST_TIMING_FD] = p->subs[index].timingfdbackup;
+}
+
+static void update_features(struct feature_pvt *p, int index)
 {
        int x;
+       if (p->subs[index].owner) {
+               for (x=0; x<AST_MAX_FDS; x++) {
+                       if (index) 
+                               p->subs[index].owner->fds[x] = -1;
+                       else
+                               p->subs[index].owner->fds[x] = p->subchan->fds[x];
+               }
+               if (!index) {
+                       /* Copy timings from master channel */
+                       p->subs[index].owner->timingfd = p->subchan->timingfd;
+                       p->subs[index].owner->alertpipe[0] = p->subchan->alertpipe[0];
+                       p->subs[index].owner->alertpipe[1] = p->subchan->alertpipe[1];
+                       if (p->subs[index].owner->nativeformats != p->subchan->readformat) {
+                               p->subs[index].owner->nativeformats = p->subchan->readformat;
+                               if (p->subs[index].owner->readformat)
+                                       ast_set_read_format(p->subs[index].owner, p->subs[index].owner->readformat);
+                               if (p->subs[index].owner->writeformat)
+                                       ast_set_write_format(p->subs[index].owner, p->subs[index].owner->writeformat);
+                       }
+               } else{
+                       restore_channel(p, index);
+               }
+       }
+}
+
+#if 0
+static void swap_subs(struct feature_pvt *p, int a, int b)
+{
        int tinthreeway;
        struct ast_channel *towner;
 
@@ -131,31 +218,19 @@ static void swap_subs(struct feature_pvt *p, int a, int b)
 
        p->subs[b].owner = towner;
        p->subs[b].inthreeway = tinthreeway;
-
-       if (p->subs[a].owner) {
-               for (x=0;x<AST_MAX_FDS;x++) {
-                       if (a) 
-                               p->subs[a].owner->fds[x] = -1;
-                       else
-                               p->subs[a].owner->fds[x] = p->subchan->fds[x];
-               }
-       }
-       if (p->subs[b].owner) {
-               for (x=0;x<AST_MAX_FDS;x++)
-                       if (b)
-                               p->subs[b].owner->fds[x] = -1;
-                       else
-                               p->subs[b].owner->fds[x] = p->subchan->fds[x];
-       }
+       update_features(p,a);
+       update_features(p,b);
        wakeup_sub(p, a);
        wakeup_sub(p, b);
 }
+#endif
 
 static int features_answer(struct ast_channel *ast)
 {
-       struct feature_pvt *p = ast->pvt->pvt;
+       struct feature_pvt *p = ast->tech_pvt;
        int res = -1;
        int x;
+
        ast_mutex_lock(&p->lock);
        x = indexof(p, ast, 0);
        if (!x && p->subchan)
@@ -166,25 +241,27 @@ static int features_answer(struct ast_channel *ast)
 
 static struct ast_frame  *features_read(struct ast_channel *ast)
 {
-       static struct ast_frame null_frame = { AST_FRAME_NULL, };
-       struct feature_pvt *p = ast->pvt->pvt;
+       struct feature_pvt *p = ast->tech_pvt;
        struct ast_frame *f;
        int x;
        
-       f = &null_frame;
+       f = &ast_null_frame;
        ast_mutex_lock(&p->lock);
        x = indexof(p, ast, 0);
-       if (!x && p->subchan)
+       if (!x && p->subchan) {
+               update_features(p, x);
                f = ast_read(p->subchan);
+       }
        ast_mutex_unlock(&p->lock);
        return f;
 }
 
 static int features_write(struct ast_channel *ast, struct ast_frame *f)
 {
-       struct feature_pvt *p = ast->pvt->pvt;
+       struct feature_pvt *p = ast->tech_pvt;
        int res = -1;
        int x;
+
        ast_mutex_lock(&p->lock);
        x = indexof(p, ast, 0);
        if (!x && p->subchan)
@@ -195,12 +272,13 @@ static int features_write(struct ast_channel *ast, struct ast_frame *f)
 
 static int features_fixup(struct ast_channel *oldchan, struct ast_channel *newchan)
 {
-       struct feature_pvt *p = newchan->pvt->pvt;
+       struct feature_pvt *p = newchan->tech_pvt;
        int x;
+
        ast_mutex_lock(&p->lock);
        if (p->owner == oldchan)
                p->owner = newchan;
-       for (x=0;x<3;x++) {
+       for (x = 0; x < 3; x++) {
                if (p->subs[x].owner == oldchan)
                        p->subs[x].owner = newchan;
        }
@@ -210,9 +288,10 @@ static int features_fixup(struct ast_channel *oldchan, struct ast_channel *newch
 
 static int features_indicate(struct ast_channel *ast, int condition)
 {
-       struct feature_pvt *p = ast->pvt->pvt;
+       struct feature_pvt *p = ast->tech_pvt;
        int res = -1;
        int x;
+
        /* Queue up a frame representing the indication as a control frame */
        ast_mutex_lock(&p->lock);
        x = indexof(p, ast, 0);
@@ -224,9 +303,10 @@ static int features_indicate(struct ast_channel *ast, int condition)
 
 static int features_digit(struct ast_channel *ast, char digit)
 {
-       struct feature_pvt *p = ast->pvt->pvt;
+       struct feature_pvt *p = ast->tech_pvt;
        int res = -1;
        int x;
+
        /* Queue up a frame representing the indication as a control frame */
        ast_mutex_lock(&p->lock);
        x = indexof(p, ast, 0);
@@ -238,74 +318,69 @@ static int features_digit(struct ast_channel *ast, char digit)
 
 static int features_call(struct ast_channel *ast, char *dest, int timeout)
 {
-       struct feature_pvt *p = ast->pvt->pvt;
+       struct feature_pvt *p = ast->tech_pvt;
        int res = -1;
        int x;
+       char *dest2;
                
-       ast_mutex_lock(&p->lock);
-       x = indexof(p, ast, 0);
-       if (!x && p->subchan) {
-               if (p->owner->cid.cid_num)
-                       p->subchan->cid.cid_num = strdup(p->owner->cid.cid_num);
-               else 
-                       p->subchan->cid.cid_num = NULL;
-       
-               if (p->owner->cid.cid_name)
-                       p->subchan->cid.cid_name = strdup(p->owner->cid.cid_name);
-               else 
-                       p->subchan->cid.cid_name = NULL;
-       
-               if (p->owner->cid.cid_rdnis)
-                       p->subchan->cid.cid_rdnis = strdup(p->owner->cid.cid_rdnis);
-               else
-                       p->subchan->cid.cid_rdnis = NULL;
-       
-               if (p->owner->cid.cid_ani)
-                       p->subchan->cid.cid_ani = strdup(p->owner->cid.cid_ani);
-               else
-                       p->subchan->cid.cid_ani = NULL;
-       
-               strncpy(p->subchan->language, p->owner->language, sizeof(p->subchan->language) - 1);
-               strncpy(p->subchan->accountcode, p->owner->accountcode, sizeof(p->subchan->accountcode) - 1);
-               p->subchan->cdrflags = p->owner->cdrflags;
-       } else
-               ast_log(LOG_NOTICE, "Uhm yah, not quite there with the call waiting...\n");
-       ast_mutex_unlock(&p->lock);
+       dest2 = strchr(dest, '/');
+       if (dest2) {
+               ast_mutex_lock(&p->lock);
+               x = indexof(p, ast, 0);
+               if (!x && p->subchan) {
+                       if (p->owner->cid.cid_num)
+                               p->subchan->cid.cid_num = strdup(p->owner->cid.cid_num);
+                       else 
+                               p->subchan->cid.cid_num = NULL;
+               
+                       if (p->owner->cid.cid_name)
+                               p->subchan->cid.cid_name = strdup(p->owner->cid.cid_name);
+                       else 
+                               p->subchan->cid.cid_name = NULL;
+               
+                       if (p->owner->cid.cid_rdnis)
+                               p->subchan->cid.cid_rdnis = strdup(p->owner->cid.cid_rdnis);
+                       else
+                               p->subchan->cid.cid_rdnis = NULL;
+               
+                       if (p->owner->cid.cid_ani)
+                               p->subchan->cid.cid_ani = strdup(p->owner->cid.cid_ani);
+                       else
+                               p->subchan->cid.cid_ani = NULL;
+               
+                       p->subchan->cid.cid_pres = p->owner->cid.cid_pres;
+                       ast_string_field_set(p->subchan, language, p->owner->language);
+                       ast_string_field_set(p->subchan, accountcode, p->owner->accountcode);
+                       p->subchan->cdrflags = p->owner->cdrflags;
+                       res = ast_call(p->subchan, dest2, timeout);
+                       update_features(p, x);
+               } else
+                       ast_log(LOG_NOTICE, "Uhm yah, not quite there with the call waiting...\n");
+               ast_mutex_unlock(&p->lock);
+       }
        return res;
 }
 
 static int features_hangup(struct ast_channel *ast)
 {
-       struct feature_pvt *p = ast->pvt->pvt;
-       struct feature_pvt *cur, *prev=NULL;
+       struct feature_pvt *p = ast->tech_pvt;
        int x;
 
        ast_mutex_lock(&p->lock);
        x = indexof(p, ast, 0);
        if (x > -1) {
+               restore_channel(p, x);
                p->subs[x].owner = NULL;
                /* XXX Re-arrange, unconference, etc XXX */
        }
-       ast->pvt->pvt = NULL;
-       
+       ast->tech_pvt = NULL;
        
        if (!p->subs[SUB_REAL].owner && !p->subs[SUB_CALLWAIT].owner && !p->subs[SUB_THREEWAY].owner) {
                ast_mutex_unlock(&p->lock);
                /* Remove from list */
-               ast_mutex_lock(&featurelock);
-               cur = features;
-               while(cur) {
-                       if (cur == p) {
-                               if (prev)
-                                       prev->next = cur->next;
-                               else
-                                       features = cur->next;
-                               break;
-                       }
-                       prev = cur;
-                       cur = cur->next;
-               }
-               ast_mutex_unlock(&featurelock);
+               AST_LIST_LOCK(&features);
+               AST_LIST_REMOVE(&features, p, list);
+               AST_LIST_UNLOCK(&features);
                ast_mutex_lock(&p->lock);
                /* And destroy */
                if (p->subchan)
@@ -341,14 +416,12 @@ static struct feature_pvt *features_alloc(char *data, int format)
                        data);
                return NULL;
        }
-       ast_mutex_lock(&featurelock);
-       tmp = features;
-       while(tmp) {
+       AST_LIST_LOCK(&features);
+       AST_LIST_TRAVERSE(&features, tmp, list) {
                if (!strcasecmp(tmp->tech, tech) && !strcmp(tmp->dest, dest))
                        break;
-               tmp = tmp->next;
        }
-       ast_mutex_unlock(&featurelock);
+       AST_LIST_UNLOCK(&features);
        if (!tmp) {
                chan = ast_request(tech, format, dest, &status);
                if (!chan) {
@@ -364,10 +437,9 @@ static struct feature_pvt *features_alloc(char *data, int format)
                        strncpy(tmp->tech, tech, sizeof(tmp->tech) - 1);
                        strncpy(tmp->dest, dest, sizeof(tmp->dest) - 1);
                        tmp->subchan = chan;
-                       ast_mutex_lock(&featurelock);
-                       tmp->next = features;
-                       features = tmp;
-                       ast_mutex_unlock(&featurelock);
+                       AST_LIST_LOCK(&features);
+                       AST_LIST_INSERT_HEAD(&features, tmp, list);
+                       AST_LIST_UNLOCK(&features);
                }
        }
        return tmp;
@@ -381,46 +453,41 @@ static struct ast_channel *features_new(struct feature_pvt *p, int state, int in
                ast_log(LOG_WARNING, "Called upon channel with no subchan:(\n");
                return NULL;
        }
-       if (!p->subs[index].owner) {
+       if (p->subs[index].owner) {
                ast_log(LOG_WARNING, "Called to put index %d already there!\n", index);
                return NULL;
        }
-       tmp = ast_channel_alloc(1);
-       if (!tmp)
+       tmp = ast_channel_alloc(0);
+       if (!tmp) {
+               ast_log(LOG_WARNING, "Unable to allocate channel structure\n");
                return NULL;
-       if (tmp) {
-               for (x=1;x<4;x++) {
-                       snprintf(tmp->name, sizeof(tmp->name), "Feature/%s/%s-%d", p->tech, p->dest, x);
-                       for (y=0;y<3;y++) {
-                               if (p->subs[x].owner && !strcasecmp(p->subs[x].owner->name, tmp->name))
-                                       break;
-                       }
-                       if (y < 3)
+       }
+       tmp->tech = &features_tech;
+       for (x=1;x<4;x++) {
+               ast_string_field_build(tmp, name, "Feature/%s/%s-%d", p->tech, p->dest, x);
+               for (y=0;y<3;y++) {
+                       if (y == index)
+                               continue;
+                       if (p->subs[y].owner && !strcasecmp(p->subs[y].owner->name, tmp->name))
                                break;
                }
-               tmp->type = type;
-               ast_setstate(tmp, state);
-               tmp->writeformat = p->subchan->writeformat;;
-               tmp->pvt->rawwriteformat = p->subchan->pvt->rawwriteformat;
-               tmp->readformat = p->subchan->readformat;
-               tmp->pvt->rawreadformat = p->subchan->pvt->rawreadformat;
-               tmp->pvt->pvt = p;
-               tmp->pvt->send_digit = features_digit;
-               tmp->pvt->call = features_call;
-               tmp->pvt->hangup = features_hangup;
-               tmp->pvt->answer = features_answer;
-               tmp->pvt->read = features_read;
-               tmp->pvt->write = features_write;
-               tmp->pvt->exception = features_read;
-               tmp->pvt->indicate = features_indicate;
-               tmp->pvt->fixup = features_fixup;
-               p->subs[index].owner = tmp;
-               ast_mutex_lock(&usecnt_lock);
-               usecnt++;
-               ast_mutex_unlock(&usecnt_lock);
-               ast_update_use_count();
-       } else
-               ast_log(LOG_WARNING, "Unable to allocate channel structure\n");
+               if (y >= 3)
+                       break;
+       }
+       ast_setstate(tmp, state);
+       tmp->writeformat = p->subchan->writeformat;
+       tmp->rawwriteformat = p->subchan->rawwriteformat;
+       tmp->readformat = p->subchan->readformat;
+       tmp->rawreadformat = p->subchan->rawreadformat;
+       tmp->nativeformats = p->subchan->readformat;
+       tmp->tech_pvt = p;
+       p->subs[index].owner = tmp;
+       if (!p->owner)
+               p->owner = tmp;
+       ast_mutex_lock(&usecnt_lock);
+       usecnt++;
+       ast_mutex_unlock(&usecnt_lock);
+       ast_update_use_count();
        return tmp;
 }
 
@@ -429,9 +496,12 @@ static struct ast_channel *features_request(const char *type, int format, void *
 {
        struct feature_pvt *p;
        struct ast_channel *chan = NULL;
+
        p = features_alloc(data, format);
        if (p && !p->subs[SUB_REAL].owner)
                chan = features_new(p, AST_STATE_DOWN, SUB_REAL);
+       if (chan)
+               update_features(p,SUB_REAL);
        return chan;
 }
 
@@ -441,17 +511,19 @@ static int features_show(int fd, int argc, char **argv)
 
        if (argc != 3)
                return RESULT_SHOWUSAGE;
-       ast_mutex_lock(&featurelock);
-       p = features;
-       while(p) {
+
+       if (AST_LIST_EMPTY(&features)) {
+               ast_cli(fd, "No feature channels in use\n");
+               return RESULT_SUCCESS;
+       }
+
+       AST_LIST_LOCK(&features);
+       AST_LIST_TRAVERSE(&features, p, list) {
                ast_mutex_lock(&p->lock);
                ast_cli(fd, "%s -- %s/%s\n", p->owner ? p->owner->name : "<unowned>", p->tech, p->dest);
                ast_mutex_unlock(&p->lock);
-               p = p->next;
        }
-       if (!features)
-               ast_cli(fd, "No feature channels in use\n");
-       ast_mutex_unlock(&featurelock);
+       AST_LIST_UNLOCK(&features);
        return RESULT_SUCCESS;
 }
 
@@ -466,8 +538,8 @@ static struct ast_cli_entry cli_show_features = {
 int load_module()
 {
        /* Make sure we can register our sip channel type */
-       if (ast_channel_register(type, tdesc, capability, features_request)) {
-               ast_log(LOG_ERROR, "Unable to register channel class %s\n", type);
+       if (ast_channel_register(&features_tech)) {
+               ast_log(LOG_ERROR, "Unable to register channel class 'Feature'\n");
                return -1;
        }
        ast_cli_register(&cli_show_features);
@@ -482,33 +554,29 @@ int reload()
 int unload_module()
 {
        struct feature_pvt *p;
+       
        /* First, take us out of the channel loop */
        ast_cli_unregister(&cli_show_features);
-       ast_channel_unregister(type);
-       if (!ast_mutex_lock(&featurelock)) {
-               /* Hangup all interfaces if they have an owner */
-               p = features;
-               while(p) {
-                       if (p->owner)
-                               ast_softhangup(p->owner, AST_SOFTHANGUP_APPUNLOAD);
-                       p = p->next;
-               }
-               features = NULL;
-               ast_mutex_unlock(&featurelock);
-       } else {
-               ast_log(LOG_WARNING, "Unable to lock the monitor\n");
+       ast_channel_unregister(&features_tech);
+       
+       if (!AST_LIST_LOCK(&features))
                return -1;
-       }               
+       /* Hangup all interfaces if they have an owner */
+       AST_LIST_TRAVERSE_SAFE_BEGIN(&features, p, list) {
+               if (p->owner)
+                       ast_softhangup(p->owner, AST_SOFTHANGUP_APPUNLOAD);
+               AST_LIST_REMOVE_CURRENT(&features, list);
+               free(p);
+       }
+       AST_LIST_TRAVERSE_SAFE_END
+       AST_LIST_UNLOCK(&features);
+       
        return 0;
 }
 
 int usecount()
 {
-       int res;
-       ast_mutex_lock(&usecnt_lock);
-       res = usecnt;
-       ast_mutex_unlock(&usecnt_lock);
-       return res;
+       return usecnt;
 }
 
 char *key()
@@ -518,6 +586,6 @@ char *key()
 
 char *description()
 {
-       return desc;
+       return (char *) desc;
 }