res_pjsip_registrar.c: Update remove_existing AOR contact handling.
[asterisk/asterisk.git] / res / res_pjsip_registrar.c
index a39dac6..3290601 100644 (file)
                <syntax />
                <description>
                        <para>
-                       In response <literal>InboundRegistrationDetail</literal> events showing configuration and status
-                       information are raised for each inbound registration object.  As well as <literal>AuthDetail</literal>
-                       events for each associated auth object.  Once all events are completed an
-                       <literal>InboundRegistrationDetailComplete</literal> is issued.
-                        </para>
+                       In response, <literal>InboundRegistrationDetail</literal> events showing configuration
+                       and status information are raised for all contacts, static or dynamic.  Once all events
+                       are completed an <literal>InboundRegistrationDetailComplete</literal> is issued.
+                       </para>
+                       <warning><para>
+                               This command just dumps all coonfigured AORs with contacts, even if the contact
+                               is a permanent one.  To really get just inbound registrations, use
+                               <literal>PJSIPShowRegistrationInboundContactStatuses</literal>.
+                       </para>
+                       </warning>
+               </description>
+               <see-also>
+                       <ref type="manager" module="res_pjsip_registrar">PJSIPShowRegistrationInboundContactStatuses</ref>
+               </see-also>
+       </manager>
+       <manager name="PJSIPShowRegistrationInboundContactStatuses" language="en_US">
+               <synopsis>
+                       Lists ContactStatuses for PJSIP inbound registrations.
+               </synopsis>
+               <syntax />
+               <description>
+                       <para>
+                       In response, <literal>ContactStatusDetail</literal> events showing status information
+                       are raised for each inbound registration (dynamic contact) object.  Once all events
+                       are completed a <literal>ContactStatusDetailComplete</literal> event is issued.
+                       </para>
                </description>
        </manager>
  ***/
@@ -102,13 +123,14 @@ static int registrar_find_contact(void *obj, void *arg, int flags)
        const struct registrar_contact_details *details = arg;
        pjsip_uri *contact_uri = pjsip_parse_uri(details->pool, (char*)contact->uri, strlen(contact->uri), 0);
 
-       return (pjsip_uri_cmp(PJSIP_URI_IN_CONTACT_HDR, details->uri, contact_uri) == PJ_SUCCESS) ? CMP_MATCH | CMP_STOP : 0;
+       return (pjsip_uri_cmp(PJSIP_URI_IN_CONTACT_HDR, details->uri, contact_uri) == PJ_SUCCESS) ? CMP_MATCH : 0;
 }
 
 /*! \brief Internal function which validates provided Contact headers to confirm that they are acceptable, and returns number of contacts */
 static int registrar_validate_contacts(const pjsip_rx_data *rdata, struct ao2_container *contacts, struct ast_sip_aor *aor, int *added, int *updated, int *deleted)
 {
-       pjsip_contact_hdr *previous = NULL, *contact = (pjsip_contact_hdr *)&rdata->msg_info.msg->hdr;
+       pjsip_contact_hdr *previous = NULL;
+       pjsip_contact_hdr *contact = (pjsip_contact_hdr *)&rdata->msg_info.msg->hdr;
        struct registrar_contact_details details = {
                .pool = pjsip_endpt_create_pool(ast_sip_get_pjsip_endpoint(), "Contact Comparison", 256, 256),
        };
@@ -119,15 +141,18 @@ static int registrar_validate_contacts(const pjsip_rx_data *rdata, struct ao2_co
 
        while ((contact = (pjsip_contact_hdr *) pjsip_msg_find_hdr(rdata->msg_info.msg, PJSIP_H_CONTACT, contact->next))) {
                int expiration = registrar_get_expiration(aor, contact, rdata);
-               RAII_VAR(struct ast_sip_contact *, existing, NULL, ao2_cleanup);
+               struct ast_sip_contact *existing;
                char contact_uri[pjsip_max_url_size];
 
                if (contact->star) {
                        /* The expiration MUST be 0 when a '*' contact is used and there must be no other contact */
-                       if ((expiration != 0) || previous) {
+                       if (expiration != 0 || previous) {
                                pjsip_endpt_release_pool(ast_sip_get_pjsip_endpoint(), details.pool);
                                return -1;
                        }
+                       /* Count all contacts to delete */
+                       *deleted = ao2_container_count(contacts);
+                       previous = contact;
                        continue;
                } else if (previous && previous->star) {
                        /* If there is a previous contact and it is a '*' this is a deal breaker */
@@ -156,14 +181,16 @@ static int registrar_validate_contacts(const pjsip_rx_data *rdata, struct ao2_co
                }
 
                /* Determine if this is an add, update, or delete for policy enforcement purposes */
-               if (!(existing = ao2_callback(contacts, 0, registrar_find_contact, &details))) {
+               existing = ao2_callback(contacts, 0, registrar_find_contact, &details);
+               ao2_cleanup(existing);
+               if (!existing) {
                        if (expiration) {
-                               (*added)++;
+                               ++*added;
                        }
                } else if (expiration) {
-                       (*updated)++;
+                       ++*updated;
                } else {
-                       (*deleted)++;
+                       ++*deleted;
                }
        }
 
@@ -198,7 +225,7 @@ static int registrar_delete_contact(void *obj, void *arg, int flags)
                                contact->user_agent);
        }
 
-       return 0;
+       return CMP_MATCH;
 }
 
 /*! \brief Internal function which adds a contact to a response */
@@ -289,6 +316,137 @@ static int registrar_validate_path(pjsip_rx_data *rdata, struct ast_sip_aor *aor
        return -1;
 }
 
+/*! Transport monitor for incoming REGISTER contacts */
+struct contact_transport_monitor {
+       /*!
+        * \brief Sorcery contact name to remove on transport shutdown
+        * \note Stored after aor_name in space reserved when struct allocated.
+        */
+       char *contact_name;
+       /*! AOR name the contact is associated */
+       char aor_name[0];
+};
+
+static void register_contact_transport_shutdown_cb(void *data)
+{
+       struct contact_transport_monitor *monitor = data;
+       struct ast_sip_contact *contact;
+       struct ast_sip_aor *aor;
+
+       aor = ast_sip_location_retrieve_aor(monitor->aor_name);
+       if (!aor) {
+               return;
+       }
+
+       ao2_lock(aor);
+       contact = ast_sip_location_retrieve_contact(monitor->contact_name);
+       if (contact) {
+               ast_sip_location_delete_contact(contact);
+               ast_verb(3, "Removed contact '%s' from AOR '%s' due to transport shutdown\n",
+                       contact->uri, monitor->aor_name);
+               ast_test_suite_event_notify("AOR_CONTACT_REMOVED",
+                       "Contact: %s\r\n"
+                       "AOR: %s\r\n"
+                       "UserAgent: %s",
+                       contact->uri,
+                       monitor->aor_name,
+                       contact->user_agent);
+               ao2_ref(contact, -1);
+       }
+       ao2_unlock(aor);
+       ao2_ref(aor, -1);
+}
+
+AST_VECTOR(excess_contact_vector, struct ast_sip_contact *);
+
+static int vec_contact_cmp(struct ast_sip_contact *left, struct ast_sip_contact *right)
+{
+       struct ast_sip_contact *left_contact = left;
+       struct ast_sip_contact *right_contact = right;
+
+       /* Sort from soonest to expire to last to expire */
+       return ast_tvcmp(left_contact->expiration_time, right_contact->expiration_time);
+}
+
+static int vec_contact_add(void *obj, void *arg, int flags)
+{
+       struct ast_sip_contact *contact = obj;
+       struct excess_contact_vector *contact_vec = arg;
+
+       /*
+        * Performance wise, an insertion sort is fine because we
+        * shouldn't need to remove more than a handful of contacts.
+        * I expect we'll typically be removing only one contact.
+        */
+       AST_VECTOR_ADD_SORTED(contact_vec, contact, vec_contact_cmp);
+       if (AST_VECTOR_SIZE(contact_vec) == AST_VECTOR_MAX_SIZE(contact_vec)) {
+               /*
+                * We added a contact over the number we need to remove.
+                * Remove the longest to expire contact from the vector
+                * which is the last element in the vector.  It may be
+                * the one we just added or the one we just added pushed
+                * out an earlier contact from removal consideration.
+                */
+               --AST_VECTOR_SIZE(contact_vec);
+       }
+       return 0;
+}
+
+/*!
+ * \internal
+ * \brief Remove excess existing contacts that expire the soonest.
+ * \since 13.18.0
+ *
+ * \param contacts Container of unmodified contacts that could remove.
+ * \param to_remove Maximum number of contacts to remove.
+ *
+ * \return Nothing
+ */
+static void remove_excess_contacts(struct ao2_container *contacts, unsigned int to_remove)
+{
+       struct excess_contact_vector contact_vec;
+
+       /*
+        * Create a sorted vector to hold the to_remove soonest to
+        * expire contacts.  The vector has an extra space to
+        * temporarily hold the longest to expire contact that we
+        * won't remove.
+        */
+       if (AST_VECTOR_INIT(&contact_vec, to_remove + 1)) {
+               return;
+       }
+       ao2_callback(contacts, OBJ_NODATA | OBJ_MULTIPLE, vec_contact_add, &contact_vec);
+
+       /*
+        * The vector should always be populated with the number
+        * of contacts we need to remove.  Just in case, we will
+        * remove all contacts in the vector even if the contacts
+        * container had fewer contacts than there should be.
+        */
+       ast_assert(AST_VECTOR_SIZE(&contact_vec) == to_remove);
+       to_remove = AST_VECTOR_SIZE(&contact_vec);
+
+       /* Remove the excess contacts that expire the soonest */
+       while (to_remove--) {
+               struct ast_sip_contact *contact;
+
+               contact = AST_VECTOR_GET(&contact_vec, to_remove);
+
+               ast_sip_location_delete_contact(contact);
+               ast_verb(3, "Removed contact '%s' from AOR '%s' due to remove_existing\n",
+                       contact->uri, contact->aor);
+               ast_test_suite_event_notify("AOR_CONTACT_REMOVED",
+                       "Contact: %s\r\n"
+                       "AOR: %s\r\n"
+                       "UserAgent: %s",
+                       contact->uri,
+                       contact->aor,
+                       contact->user_agent);
+       }
+
+       AST_VECTOR_FREE(&contact_vec);
+}
+
 static int register_aor_core(pjsip_rx_data *rdata,
        struct ast_sip_endpoint *endpoint,
        struct ast_sip_aor *aor,
@@ -297,7 +455,10 @@ static int register_aor_core(pjsip_rx_data *rdata,
 {
        static const pj_str_t USER_AGENT = { "User-Agent", 10 };
 
-       int added = 0, updated = 0, deleted = 0;
+       int added = 0;
+       int updated = 0;
+       int deleted = 0;
+       int contact_count;
        pjsip_contact_hdr *contact_hdr = NULL;
        struct registrar_contact_details details = { 0, };
        pjsip_tx_data *tdata;
@@ -334,7 +495,14 @@ static int register_aor_core(pjsip_rx_data *rdata,
                return PJ_TRUE;
        }
 
-       if ((MAX(added - deleted, 0) + (!aor->remove_existing ? ao2_container_count(contacts) : 0)) > aor->max_contacts) {
+       if (aor->remove_existing) {
+               /* Cumulative number of contacts affected by this registration */
+               contact_count = MAX(updated + added - deleted,  0);
+       } else {
+               /* Total contacts after this registration */
+               contact_count = ao2_container_count(contacts) + added - deleted;
+       }
+       if (contact_count > aor->max_contacts) {
                /* Enforce the maximum number of contacts */
                pjsip_endpt_respond_stateless(ast_sip_get_pjsip_endpoint(), rdata, 403, NULL, NULL, NULL);
                ast_sip_report_failed_acl(endpoint, rdata, "registrar_attempt_exceeds_maximum_configured_contacts");
@@ -343,7 +511,9 @@ static int register_aor_core(pjsip_rx_data *rdata,
                return PJ_TRUE;
        }
 
-       if (!(details.pool = pjsip_endpt_create_pool(ast_sip_get_pjsip_endpoint(), "Contact Comparison", 256, 256))) {
+       details.pool = pjsip_endpt_create_pool(ast_sip_get_pjsip_endpoint(),
+               "Contact Comparison", 256, 256);
+       if (!details.pool) {
                pjsip_endpt_respond_stateless(ast_sip_get_pjsip_endpoint(), rdata, 500, NULL, NULL, NULL);
                return PJ_TRUE;
        }
@@ -384,7 +554,8 @@ static int register_aor_core(pjsip_rx_data *rdata,
 
                if (contact_hdr->star) {
                        /* A star means to unregister everything, so do so for the possible contacts */
-                       ao2_callback(contacts, OBJ_NODATA | OBJ_MULTIPLE, registrar_delete_contact, (void *)aor_name);
+                       ao2_callback(contacts, OBJ_NODATA | OBJ_UNLINK | OBJ_MULTIPLE,
+                               registrar_delete_contact, (void *)aor_name);
                        break;
                }
 
@@ -397,7 +568,11 @@ static int register_aor_core(pjsip_rx_data *rdata,
                details.uri = pjsip_uri_get_uri(contact_hdr->uri);
                pjsip_uri_print(PJSIP_URI_IN_CONTACT_HDR, details.uri, contact_uri, sizeof(contact_uri));
 
-               if (!(contact = ao2_callback(contacts, OBJ_UNLINK, registrar_find_contact, &details))) {
+               contact = ao2_callback(contacts, OBJ_UNLINK, registrar_find_contact, &details);
+               if (!contact) {
+                       int prune_on_boot = 0;
+                       pj_str_t host_name;
+
                        /* If they are actually trying to delete a contact that does not exist... be forgiving */
                        if (!expiration) {
                                ast_verb(3, "Attempted to remove non-existent contact '%s' from AOR '%s' by request\n",
@@ -405,14 +580,68 @@ static int register_aor_core(pjsip_rx_data *rdata,
                                continue;
                        }
 
-                       if (ast_sip_location_add_contact_nolock(aor, contact_uri, ast_tvadd(ast_tvnow(),
-                               ast_samp2tv(expiration, 1)), path_str ? ast_str_buffer(path_str) : NULL,
-                                       user_agent, via_addr, via_port, call_id, endpoint)) {
+                       /* Determine if the contact cannot survive a restart/boot. */
+                       if (details.uri->port == rdata->pkt_info.src_port
+                               && !pj_strcmp(&details.uri->host,
+                                       pj_cstr(&host_name, rdata->pkt_info.src_name))
+                               /* We have already checked if the URI scheme is sip: or sips: */
+                               && PJSIP_TRANSPORT_IS_RELIABLE(rdata->tp_info.transport)) {
+                               pj_str_t type_name;
+
+                               /* Determine the transport parameter value */
+                               if (!strcasecmp("WSS", rdata->tp_info.transport->type_name)) {
+                                       /* WSS is special, as it needs to be ws. */
+                                       pj_cstr(&type_name, "ws");
+                               } else {
+                                       pj_cstr(&type_name, rdata->tp_info.transport->type_name);
+                               }
+
+                               if (!pj_stricmp(&details.uri->transport_param, &type_name)
+                                       && (endpoint->nat.rewrite_contact
+                                               /* Websockets are always rewritten */
+                                               || !pj_stricmp(&details.uri->transport_param,
+                                                       pj_cstr(&type_name, "ws")))) {
+                                       /*
+                                        * The contact was rewritten to the reliable transport's
+                                        * source address.  Disconnecting the transport for any
+                                        * reason invalidates the contact.
+                                        */
+                                       prune_on_boot = 1;
+                               }
+                       }
+
+                       contact = ast_sip_location_create_contact(aor, contact_uri,
+                               ast_tvadd(ast_tvnow(), ast_samp2tv(expiration, 1)),
+                               path_str ? ast_str_buffer(path_str) : NULL,
+                               user_agent, via_addr, via_port, call_id, prune_on_boot, endpoint);
+                       if (!contact) {
                                ast_log(LOG_ERROR, "Unable to bind contact '%s' to AOR '%s'\n",
-                                               contact_uri, aor_name);
+                                       contact_uri, aor_name);
                                continue;
                        }
 
+                       if (prune_on_boot) {
+                               const char *contact_name;
+                               struct contact_transport_monitor *monitor;
+
+                               /*
+                                * Monitor the transport in case it gets disconnected because
+                                * the contact won't be valid anymore if that happens.
+                                */
+                               contact_name = ast_sorcery_object_get_id(contact);
+                               monitor = ao2_alloc_options(sizeof(*monitor) + 2 + strlen(aor_name)
+                                       + strlen(contact_name), NULL, AO2_ALLOC_OPT_LOCK_NOLOCK);
+                               if (monitor) {
+                                       strcpy(monitor->aor_name, aor_name);/* Safe */
+                                       monitor->contact_name = monitor->aor_name + strlen(aor_name) + 1;
+                                       strcpy(monitor->contact_name, contact_name);/* Safe */
+
+                                       ast_sip_transport_monitor_register(rdata->tp_info.transport,
+                                               register_contact_transport_shutdown_cb, monitor);
+                                       ao2_ref(monitor, -1);
+                               }
+                       }
+
                        ast_verb(3, "Added contact '%s' to AOR '%s' with expiration of %d seconds\n",
                                contact_uri, aor_name, expiration);
                        ast_test_suite_event_notify("AOR_CONTACT_ADDED",
@@ -481,15 +710,29 @@ static int register_aor_core(pjsip_rx_data *rdata,
 
        pjsip_endpt_release_pool(ast_sip_get_pjsip_endpoint(), details.pool);
 
-       /* If the AOR is configured to remove any existing contacts that have not been updated/added as a result of this REGISTER
-        * do so
+       /*
+        * If the AOR is configured to remove any contacts over max_contacts
+        * that have not been updated/added/deleted as a result of this
+        * REGISTER do so.
+        *
+        * The contacts container currently holds the existing contacts that
+        * were not affected by this REGISTER.
         */
        if (aor->remove_existing) {
-               ao2_callback(contacts, OBJ_NODATA | OBJ_MULTIPLE, registrar_delete_contact, NULL);
+               /* Total contacts after this registration */
+               contact_count = ao2_container_count(contacts) + updated + added;
+               if (contact_count > aor->max_contacts) {
+                       /* Remove excess existing contacts that expire the soonest */
+                       remove_excess_contacts(contacts, contact_count - aor->max_contacts);
+               }
        }
 
        /* Re-retrieve contacts.  Caller will clean up the original container. */
        contacts = ast_sip_location_retrieve_aor_contacts_nolock(aor);
+       if (!contacts) {
+               pjsip_endpt_respond_stateless(ast_sip_get_pjsip_endpoint(), rdata, 500, NULL, NULL, NULL);
+               return PJ_TRUE;
+       }
        response_contact = ao2_callback(contacts, 0, NULL, NULL);
 
        /* Send a response containing all of the contacts (including static) that are present on this AOR */
@@ -523,25 +766,17 @@ static int register_aor(pjsip_rx_data *rdata,
 {
        int res;
        struct ao2_container *contacts = NULL;
-       struct ast_named_lock *lock;
-
-       lock = ast_named_lock_get(AST_NAMED_LOCK_TYPE_RWLOCK, "aor", aor_name);
-       if (!lock) {
-               return PJ_TRUE;
-       }
 
-       ao2_wrlock(lock);
+       ao2_lock(aor);
        contacts = ast_sip_location_retrieve_aor_contacts_nolock(aor);
        if (!contacts) {
-               ao2_unlock(lock);
-               ast_named_lock_put(lock);
+               ao2_unlock(aor);
                return PJ_TRUE;
        }
 
        res = register_aor_core(rdata, endpoint, aor, aor_name, contacts);
        ao2_cleanup(contacts);
-       ao2_unlock(lock);
-       ast_named_lock_put(lock);
+       ao2_unlock(aor);
 
        return res;
 }
@@ -563,6 +798,7 @@ static int match_aor(const char *aor_name, const char *id)
 static char *find_aor_name(const char *username, const char *domain, const char *aors)
 {
        char *configured_aors;
+       char *aors_buf;
        char *aor_name;
        char *id_domain;
        struct ast_sip_domain_alias *alias;
@@ -570,8 +806,10 @@ static char *find_aor_name(const char *username, const char *domain, const char
        id_domain = ast_alloca(strlen(username) + strlen(domain) + 2);
        sprintf(id_domain, "%s@%s", username, domain);
 
+       aors_buf = ast_strdupa(aors);
+
        /* Look for exact match on username@domain */
-       configured_aors = ast_strdupa(aors);
+       configured_aors = aors_buf;
        while ((aor_name = ast_strip(strsep(&configured_aors, ",")))) {
                if (match_aor(aor_name, id_domain)) {
                        return ast_strdup(aor_name);
@@ -586,7 +824,7 @@ static char *find_aor_name(const char *username, const char *domain, const char
                sprintf(id_domain, "%s@%s", username, alias->domain);
                ao2_cleanup(alias);
 
-               configured_aors = ast_strdupa(aors);
+               configured_aors = strcpy(aors_buf, aors);/* Safe */
                while ((aor_name = ast_strip(strsep(&configured_aors, ",")))) {
                        if (match_aor(aor_name, id_domain_alias)) {
                                return ast_strdup(aor_name);
@@ -594,8 +832,13 @@ static char *find_aor_name(const char *username, const char *domain, const char
                }
        }
 
+       if (ast_strlen_zero(username)) {
+               /* No username, no match */
+               return NULL;
+       }
+
        /* Look for exact match on username only */
-       configured_aors = ast_strdupa(aors);
+       configured_aors = strcpy(aors_buf, aors);/* Safe */
        while ((aor_name = ast_strip(strsep(&configured_aors, ",")))) {
                if (match_aor(aor_name, username)) {
                        return ast_strdup(aor_name);
@@ -626,6 +869,12 @@ static struct ast_sip_aor *find_registrar_aor(struct pjsip_rx_data *rdata, struc
                        username = ast_alloca(uri->user.slen + 1);
                        ast_copy_pj_str(username, &uri->user, uri->user.slen + 1);
 
+                       /*
+                        * We may want to match without any user options getting
+                        * in the way.
+                        */
+                       AST_SIP_USER_OPTIONS_TRUNCATE_CHECK(username);
+
                        aor_name = find_aor_name(username, domain_name, endpoint->aors);
                        if (aor_name) {
                                ast_debug(3, "Matched aor '%s' by To username\n", aor_name);
@@ -779,6 +1028,42 @@ static int ami_show_registrations(struct mansession *s, const struct message *m)
        return 0;
 }
 
+static int ami_show_registration_contact_statuses(struct mansession *s, const struct message *m)
+{
+       int count = 0;
+       struct ast_sip_ami ami = { .s = s, .m = m, .arg = NULL, .action_id = astman_get_header(m, "ActionID"), };
+       struct ao2_container *contacts = ast_sorcery_retrieve_by_fields(
+               ast_sip_get_sorcery(), "contact", AST_RETRIEVE_FLAG_MULTIPLE | AST_RETRIEVE_FLAG_ALL, NULL);
+       struct ao2_iterator i;
+       struct ast_sip_contact *contact;
+
+       astman_send_listack(s, m, "Following are ContactStatusEvents for each Inbound "
+                           "registration", "start");
+
+       if (contacts) {
+               i = ao2_iterator_init(contacts, 0);
+               while ((contact = ao2_iterator_next(&i))) {
+                       struct ast_sip_contact_wrapper wrapper;
+
+                       wrapper.aor_id = (char *)contact->aor;
+                       wrapper.contact = contact;
+                       wrapper.contact_id = (char *)ast_sorcery_object_get_id(contact);
+
+                       ast_sip_format_contact_ami(&wrapper, &ami, 0);
+                       count++;
+
+                       ao2_ref(contact, -1);
+               }
+               ao2_iterator_destroy(&i);
+               ao2_ref(contacts, -1);
+       }
+
+       astman_send_list_complete_start(s, m, "ContactStatusDetailComplete", count);
+       astman_send_list_complete_end(s);
+       return 0;
+}
+
+#define AMI_SHOW_REGISTRATION_CONTACT_STATUSES "PJSIPShowRegistrationInboundContactStatuses"
 #define AMI_SHOW_REGISTRATIONS "PJSIPShowRegistrationsInbound"
 
 static pjsip_module registrar_module = {
@@ -811,6 +1096,8 @@ static int load_module(void)
 
        ast_manager_register_xml(AMI_SHOW_REGISTRATIONS, EVENT_FLAG_SYSTEM,
                                 ami_show_registrations);
+       ast_manager_register_xml(AMI_SHOW_REGISTRATION_CONTACT_STATUSES, EVENT_FLAG_SYSTEM,
+                                ami_show_registration_contact_statuses);
 
        return AST_MODULE_LOAD_SUCCESS;
 }
@@ -818,7 +1105,9 @@ static int load_module(void)
 static int unload_module(void)
 {
        ast_manager_unregister(AMI_SHOW_REGISTRATIONS);
+       ast_manager_unregister(AMI_SHOW_REGISTRATION_CONTACT_STATUSES);
        ast_sip_unregister_service(&registrar_module);
+       ast_sip_transport_monitor_unregister_all(register_contact_transport_shutdown_cb);
        return 0;
 }