res_http_websocket: Fix crash due to double freeing memory when receiving a payload...
authorJoshua Colp <jcolp@digium.com>
Wed, 10 Dec 2014 13:35:52 +0000 (13:35 +0000)
committerJoshua Colp <jcolp@digium.com>
Wed, 10 Dec 2014 13:35:52 +0000 (13:35 +0000)
commit03c94ef761c789b56e46b7b4576a816cb97439aa
treea44d21cad2266c2d49aaa575e39c6ac3250cabc6
parent0cba439c4d55ac94059393388da7b3ddbf206e01
res_http_websocket: Fix crash due to double freeing memory when receiving a payload length of zero.

Frames with a payload length of 0 were incorrectly handled in res_http_websocket.
Provided a frame with a payload had been received prior it was possible for a double
free to occur. The realloc operation would succeed (thus freeing the payload) but be
treated as an error. When the session was then torn down the payload would be
freed again causing a crash. The read function now takes this into account.

This change also fixes assumptions made by users of res_http_websocket. There is no
guarantee that a frame received from it will be NULL terminated.

ASTERISK-24472 #close
Reported by: Badalian Vyacheslav

Review: https://reviewboard.asterisk.org/r/4220/
Review: https://reviewboard.asterisk.org/r/4219/
........

Merged revisions 429270 from http://svn.asterisk.org/svn/asterisk/branches/11
........

Merged revisions 429272 from http://svn.asterisk.org/svn/asterisk/branches/12
........

Merged revisions 429273 from http://svn.asterisk.org/svn/asterisk/branches/13

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@429274 65c4cc65-6c06-0410-ace0-fbb531ad65f3
channels/chan_sip.c
res/res_http_websocket.c
res/res_pjsip_transport_websocket.c