Eliminate double close of file descriptor in manager.c
authorJonathan Rose <jrose@digium.com>
Mon, 5 Mar 2012 19:06:46 +0000 (19:06 +0000)
committerJonathan Rose <jrose@digium.com>
Mon, 5 Mar 2012 19:06:46 +0000 (19:06 +0000)
commit11bbc097b7d6e115ea413dd80b8deee95ee3dc63
tree2636cfba4770e5235066c0bb10ae9043b6b8e432
parent2736fe9917dfbcb3123b7c2b7e2f10ac9904a3c6
Eliminate double close of file descriptor in manager.c

The process_output function in manager.c attempted to call fclose and close immediately
afterwards. Since fclose implies close, this resulted in a potential double free on file
descriptors. This patch changes that behavior and also adds error checking to fclose and
close depending on which was deemed necessary. Also error messages. Thanks to Rosen
Iliev for pointing out the location of the problem.

(closes issue ASTERISK-18453)
Reported By: Jaco Kroon
Review: https://reviewboard.asterisk.org/r/1793/
........

Merged revisions 358214 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........

Merged revisions 358215 from http://svn.asterisk.org/svn/asterisk/branches/10

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@358216 65c4cc65-6c06-0410-ace0-fbb531ad65f3
main/manager.c