Add support for the clang compiler; update RAII_VAR to use BlocksRuntime
authorMatthew Jordan <mjordan@digium.com>
Thu, 12 Mar 2015 12:40:23 +0000 (12:40 +0000)
committerMatthew Jordan <mjordan@digium.com>
Thu, 12 Mar 2015 12:40:23 +0000 (12:40 +0000)
commit29304d10a0981fddf020b0c8655d041d3f15960f
treec19ea2bdef21a8c59eed62c1a835dade974099d9
parent4115e327acc6d97d2308fcc3bbe6676b12b5907a
Add support for the clang compiler; update RAII_VAR to use BlocksRuntime

RAII_VAR, which is used extensively in Asterisk to manage reference counted
resources, uses a GCC extension to automatically invoke a cleanup function
when a variable loses scope. While this functionality is incredibly useful
and has prevented a large number of memory leaks, it also prevents Asterisk
from being compiled with clang.

This patch updates the RAII_VAR macro such that it can be compiled with clang.
It makes use of the BlocksRuntime, which allows for a closure to be created
that performs the actual cleanup.

Note that this does not attempt to address the numerous warnings that the clang
compiler catches in Asterisk.

Much thanks for this patch goes to:
* The folks on StackOverflow who asked this question and Leushenko for
  providing the answer that formed the basis of this code:
  http://stackoverflow.com/questions/24959440/rewrite-gcc-cleanup-macro-with-nested-function-for-clang
* Diederik de Groot, who has been extremely patient in working on getting this
  patch into Asterisk.

Review: https://reviewboard.asterisk.org/r/4370/

ASTERISK-24133
ASTERISK-23666
ASTERISK-20399
ASTERISK-20850 #close
Reported by: Diederik de Groot
patches:
  RAII_CLANG.patch uploaded by Diederik de Groot (License 6600)
........

Merged revisions 432807 from http://svn.asterisk.org/svn/asterisk/branches/11
........

Merged revisions 432808 from http://svn.asterisk.org/svn/asterisk/branches/13

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@432809 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Makefile
configure
configure.ac
include/asterisk/inline_api.h
include/asterisk/utils.h
main/Makefile
makeopts.in