Protect ast_filestream object when on a channel
authorRussell Bryant <russell@russellbryant.com>
Mon, 27 Jan 2014 01:25:23 +0000 (01:25 +0000)
committerRussell Bryant <russell@russellbryant.com>
Mon, 27 Jan 2014 01:25:23 +0000 (01:25 +0000)
commit33071d636cff3085be3bcc01bbba9d38ca9acb46
tree14f4ac34e6aa413ffacd8b583a993b4911d752fe
parent45261449ecfe621e2ba5e371a7c24addfa8a9c72
Protect ast_filestream object when on a channel

The ast_filestream object gets tacked on to a channel via
chan->timingdata.  It's a reference counted object, but the reference
count isn't used when putting it on a channel.  It's theoretically
possible for another thread to interfere with the channel while it's
unlocked and cause the filestream to get destroyed.

Use the astobj2 reference count to make sure that as long as this code
path is holding on the ast_filestream and passing it into the file.c
playback code, that it knows it's valid.

Bug reported by Leif Madsen.

Review: https://reviewboard.asterisk.org/r/3135/
........

Merged revisions 406566 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........

Merged revisions 406567 from http://svn.asterisk.org/svn/asterisk/branches/11
........

Merged revisions 406574 from http://svn.asterisk.org/svn/asterisk/branches/12

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@406595 65c4cc65-6c06-0410-ace0-fbb531ad65f3
include/asterisk/channel.h
main/channel.c
main/file.c