Don't attempt to create a voice frame on a read error
authorMatthew Jordan <mjordan@digium.com>
Sun, 14 Apr 2013 02:35:04 +0000 (02:35 +0000)
committerMatthew Jordan <mjordan@digium.com>
Sun, 14 Apr 2013 02:35:04 +0000 (02:35 +0000)
commit51117442149cbe9b0f7e25487f22a970bffda682
tree3b426611a3b42e4ffb7f103957dfde6b96db1ab2
parenta7c5183d671a8a5769bb302bb71da67350771456
Don't attempt to create a voice frame on a read error

Prior to this patch, a read error in snd_pcm_readi would still be treated as a
nominal result when constructing a voice frame from the expected data. Since
the value returned is negative, as opposed to the number of samples read,
this could result in a crash. With this patch, we now return a null frame
when a read error is detected.

Note that the patch on ASTERISK-21329 was modified slightly for this commit,
in that we bail immediately on detecting the read error, rather than bypassing
the construction of the voice frame.

(closes issue ASTERISK-21329)
Reported by: Keiichiro Kawasaki
patches:
  chan_alsa.diff uploaded by kawasaki (License 6489)
........

Merged revisions 385633 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........

Merged revisions 385634 from http://svn.asterisk.org/svn/asterisk/branches/11

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@385635 65c4cc65-6c06-0410-ace0-fbb531ad65f3
channels/chan_alsa.c