chan_sip.c: Fix autokillid deadlock potential.
authorRichard Mudgett <rmudgett@digium.com>
Mon, 7 Mar 2016 19:21:44 +0000 (13:21 -0600)
committerRichard Mudgett <rmudgett@digium.com>
Wed, 16 Mar 2016 19:44:51 +0000 (14:44 -0500)
commit69810b306df0f311acf550653e5ba9e2c24e2963
tree13be4f5b34e2e42944b1b662dc5a69c2274ba22e
parent67c79c326d3c0d1945a83622e490f226bc942a6d
chan_sip.c: Fix autokillid deadlock potential.

This patch is part of a series to resolve deadlocks in chan_sip.c.

Stopping a scheduled event can result in a deadlock if the scheduled event
is running when you try to stop the event.  If you hold a lock needed by
the scheduled event while trying to stop the scheduled event then a
deadlock can happen.  The general strategy for resolving the deadlock
potential is to push the actual starting and stopping of the scheduled
events off onto the scheduler/do_monitor() thread by scheduling an
immediate one shot scheduled event.  Some restructuring may be needed
because the code may assume that the start/stop of the scheduled events is
immediate.

* Fix clearing autokillid in __sip_autodestruct() even though we could
reschedule.

ASTERISK-25023

Change-Id: I450580dbf26e2e3952ee6628c735b001565c368f
channels/chan_sip.c
channels/sip/include/dialog.h