res_pjsip_sdp_rtp: Fix issue where sending a hold SDP twice could cause an unhold.
authorJoshua Colp <jcolp@digium.com>
Wed, 30 Apr 2014 12:39:11 +0000 (12:39 +0000)
committerJoshua Colp <jcolp@digium.com>
Wed, 30 Apr 2014 12:39:11 +0000 (12:39 +0000)
commit7378d3e054136e2fb7e5a994f93621ecf51e8917
tree0c102eb6bd082e5b935e43845d778f716e578b9a
parent56ca10c7f1b7e2d3bcabe60f796e58325468d39c
res_pjsip_sdp_rtp: Fix issue where sending a hold SDP twice could cause an unhold.

This change fixes a bug where if an SDP with media address and sendonly was
received twice the underlying call would go off hold, instead of remaining on hold.
This occured because the code did not properly take into account that the SDP
may contain both a valid media address and the sendonly attribute.

The code now examines the sendonly attribute and media address first, so if the
SDP is received again no change will occur.

ASTERISK-23558 #comment Reported by: John Bigelow

Review: https://reviewboard.asterisk.org/r/3472/
........

Merged revisions 413119 from http://svn.asterisk.org/svn/asterisk/branches/12

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@413120 65c4cc65-6c06-0410-ace0-fbb531ad65f3
res/res_pjsip_sdp_rtp.c