Audit ast_pjsip_rdata_get_endpoint() usage for ref leaks.
authorRichard Mudgett <rmudgett@digium.com>
Fri, 20 Mar 2015 19:54:48 +0000 (19:54 +0000)
committerRichard Mudgett <rmudgett@digium.com>
Fri, 20 Mar 2015 19:54:48 +0000 (19:54 +0000)
commit7e097bce8687256ee400347245b7956c8e2fc452
tree81e35595ba890ac19447dd73536822918d83b4fe
parent148e8799fefb48fd324ce9b8813d1919ba72a8fd
Audit ast_pjsip_rdata_get_endpoint() usage for ref leaks.

Valgrind found some memory leaks associated with
ast_pjsip_rdata_get_endpoint().  The leaks would manifest when sending
responses to OPTIONS requests, processing MESSAGE requests, and
res_pjsip supplements implementing the incoming_request callback.

* Fix ast_pjsip_rdata_get_endpoint() endpoint ref leaks in
res/res_pjsip.c:supplement_on_rx_request(),
res/res_pjsip/pjsip_options.c:send_options_response(),
res/res_pjsip_messaging.c:rx_data_to_ast_msg(), and
res/res_pjsip_messaging.c:send_response().

* Eliminated RAII_VAR() use with ast_pjsip_rdata_get_endpoint() in
res/res_pjsip_nat.c:nat_on_rx_message().

* Fixed inconsistent but benign return value in
res/res_pjsip/pjsip_options.c:options_on_rx_request().

Review: https://reviewboard.asterisk.org/r/4511/
........

Merged revisions 433222 from http://svn.asterisk.org/svn/asterisk/branches/13

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@433223 65c4cc65-6c06-0410-ace0-fbb531ad65f3
res/res_pjsip.c
res/res_pjsip/pjsip_options.c
res/res_pjsip_messaging.c
res/res_pjsip_nat.c