Remove registertrying option in chan_sip
authorTerry Wilson <twilson@digium.com>
Wed, 2 Nov 2011 23:08:46 +0000 (23:08 +0000)
committerTerry Wilson <twilson@digium.com>
Wed, 2 Nov 2011 23:08:46 +0000 (23:08 +0000)
commit7f883ef495b57ae9182e47213d01d5e8009dbf3f
treefea1e82631edc075f9ca3e8ffb19561a37d3e18c
parentf7bdc835a423fb7e969f69983cd615b2c4ff5e0c
Remove registertrying option in chan_sip

This option is not only useless, but has been broken since inception since
the flag was never copied from the peer where it is set to the pvt where
it was checked. RFC 3261 specificially states that you should not send a
provisional response to a non-INVITE request, and if we did fix the code
so that it worked, it would cause the same kind of user enumeration
vulnerability that we've discussed with the nat= setting. This patch
removes registertrying option and any code that would have sent a 100
response to a register.

Review: https://reviewboard.asterisk.org/r/1562/
........

Merged revisions 343220 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........

Merged revisions 343221 from http://svn.asterisk.org/svn/asterisk/branches/10

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@343222 65c4cc65-6c06-0410-ace0-fbb531ad65f3
channels/chan_sip.c
channels/sip/include/sip.h
contrib/realtime/mysql/sippeers.sql