Fix printf problems with high ascii characters after r413586 (1.8).
authorWalter Doekes <walter+asterisk@wjd.nu>
Wed, 17 Dec 2014 10:23:32 +0000 (10:23 +0000)
committerWalter Doekes <walter+asterisk@wjd.nu>
Wed, 17 Dec 2014 10:23:32 +0000 (10:23 +0000)
commit8b6ecc449c780eccc630ed8f3e3ca090f5a57b64
tree43b03098bd605892070fc93a70c74cc57e70c2a4
parentc4cc668ba9682751d8617d1f49932bcacf43772f
Fix printf problems with high ascii characters after r413586 (1.8).

In r413586 (1.8) various casts were added to silence gcc 4.10 warnings.
Those fixes included things like:

    -out += sprintf(out, "%%%02X", (unsigned char) *ptr);
    +out += sprintf(out, "%%%02X", (unsigned) *ptr);

That works for low ascii characters, but for the high range that yields
e.g. FFFFFFC3 when C3 is expected.

This changeset:
- fixes those casts to use the 'hh' unsigned char modifier instead
- consistently uses %02x instead of %2.2x (or other non-standard usage)
- adds a few 'h' modifiers in various places
- fixes a 'replcaes' typo
- dev/urandon typo (in 13+ patch)

Review: https://reviewboard.asterisk.org/r/4263/

ASTERISK-24619 #close
Reported by: Stefan27 (on IRC)
........

Merged revisions 429673 from http://svn.asterisk.org/svn/asterisk/branches/11
........

Merged revisions 429674 from http://svn.asterisk.org/svn/asterisk/branches/12
........

Merged revisions 429675 from http://svn.asterisk.org/svn/asterisk/branches/13

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@429683 65c4cc65-6c06-0410-ace0-fbb531ad65f3
25 files changed:
addons/ooh323c/src/printHandler.c
apps/app_adsiprog.c
apps/app_getcpeid.c
apps/app_osplookup.c
apps/app_sms.c
channels/chan_iax2.c
channels/chan_misdn.c
channels/chan_sip.c
channels/chan_unistim.c
channels/iax2/parser.c
channels/misdn/ie.c
channels/sig_pri.c
channels/vcodecs.c
main/http.c
main/loader.c
main/manager.c
main/udptl.c
main/utils.c
main/uuid.c
pbx/dundi-parser.c
res/res_crypto.c
res/res_pktccops.c
res/res_rtp_asterisk.c
utils/astman.c
utils/smsq.c