app_confbridge: Repeatedly starting and stopping recording ref leaks the recording...
authorRichard Mudgett <rmudgett@digium.com>
Tue, 27 Jan 2015 17:48:18 +0000 (17:48 +0000)
committerRichard Mudgett <rmudgett@digium.com>
Tue, 27 Jan 2015 17:48:18 +0000 (17:48 +0000)
commit94eebd5ba541396175c195f91b50168191e6d24a
tree57af16a9b3a2aeaaf9555a7fde9b274780280f3d
parenta43d24a9d3d61274e6b7b8cf594af0d802c100b7
app_confbridge: Repeatedly starting and stopping recording ref leaks the recording channel.

Starting and stopping conference recording more than once causes the
recording channels to be leaked.  For v13 the channels also show up in the
CLI "core show channels" output.

* Reworked and simplified the recording channel code to use
ast_bridge_impart() instead of managing the recording thread in the
ConfBridge code.  The recording channel's ref handling easily falls into
place and other off nominal code paths get handled better as a result.

ASTERISK-24719 #close
Reported by: John Bigelow

Review: https://reviewboard.asterisk.org/r/4368/
Review: https://reviewboard.asterisk.org/r/4369/
........

Merged revisions 431135 from http://svn.asterisk.org/svn/asterisk/branches/11
........

Merged revisions 431160 from http://svn.asterisk.org/svn/asterisk/branches/13

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@431161 65c4cc65-6c06-0410-ace0-fbb531ad65f3
apps/app_confbridge.c
apps/confbridge/include/confbridge.h