chan_sip: Fix dialog leak resulting from missing ACK to re-INVITE.
authorWalter Doekes <walter+asterisk@wjd.nu>
Fri, 10 Oct 2014 07:34:50 +0000 (07:34 +0000)
committerWalter Doekes <walter+asterisk@wjd.nu>
Fri, 10 Oct 2014 07:34:50 +0000 (07:34 +0000)
commitd3f525fd8f81acf21dd91604d1d55517cee22ed5
tree13dc09c2221b3352d0494d05973cec4a066b4291
parentaef63118da6b95864de656c12418768de91e2903
chan_sip: Fix dialog leak resulting from missing ACK to re-INVITE.

If a device re-INVITEs at the same time as the dialog is hung up, and
if then the ACK to the re-INVITE never reaches Asterisk, chan_sip would
fail to destroy the dialog after a while.  This resulted in (most
prominently) file handle leaks.

(Patch reindented by me.)

ASTERISK-20784 #close
ASTERISK-15879 #close
Reported by: Torrey Searle, Nitesh Bansal
Patches:
  reinvite_ack_timeout.patch uploaded by Torrey Searle (License #5334)
  patch_asterisk_20784.txt uploaded by Nitesh Bansal (License #6418)

Reviewboard: https://reviewboard.asterisk.org/r/4052/
(testcase can be found at r4051)
........

Merged revisions 425068 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........

Merged revisions 425069 from http://svn.asterisk.org/svn/asterisk/branches/11
........

Merged revisions 425070 from http://svn.asterisk.org/svn/asterisk/branches/12
........

Merged revisions 425071 from http://svn.asterisk.org/svn/asterisk/branches/13

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@425072 65c4cc65-6c06-0410-ace0-fbb531ad65f3
channels/chan_sip.c