Named call pickup groups. Fixes, missing functionality, and improvements.
authorRichard Mudgett <rmudgett@digium.com>
Thu, 20 Sep 2012 17:22:41 +0000 (17:22 +0000)
committerRichard Mudgett <rmudgett@digium.com>
Thu, 20 Sep 2012 17:22:41 +0000 (17:22 +0000)
commitda5944fc56482949ba04aad6ab33275b5031f75d
tree16b3832a037e0d62af11751c418fef1afabd7fc4
parentafa6b8f320bfe73d8d6a1478c32ef7790e7c950f
Named call pickup groups. Fixes, missing functionality, and improvements.

* ASTERISK-20383
Missing named call pickup group features:

CHANNEL(callgroup) - Need CHANNEL(namedcallgroup)
CHANNEL(pickupgroup) - Need CHANNEL(namedpickupgroup)
Pickup() - Needs to also select from named pickup groups.

* ASTERISK-20384
Using the pickupexten, the pickup channel selection could fail even though
there was a call it could have picked up.  In a call pickup race when
there are multiple calls to pickup and two extensions try to pickup a
call, it is conceivable that the loser will not pick up any call even
though it could have picked up the next oldest matching call.

Regression because of the named call pickup group feature.

* See ASTERISK-20386 for the implementation improvements.  These are the
changes in channel.c and channel.h.

* Fixed some locking issues in CHANNEL().

(closes issue ASTERISK-20383)
Reported by: rmudgett
(closes issue ASTERISK-20384)
Reported by: rmudgett
(closes issue ASTERISK-20386)
Reported by: rmudgett
Tested by: rmudgett

Review: https://reviewboard.asterisk.org/r/2112/
........

Merged revisions 373220 from http://svn.asterisk.org/svn/asterisk/branches/11

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@373221 65c4cc65-6c06-0410-ace0-fbb531ad65f3
apps/app_directed_pickup.c
funcs/func_channel.c
include/asterisk/channel.h
include/asterisk/features.h
main/channel.c
main/features.c