callerid: Logic error in checksum processing
authorRuss Meyerriecks <rmeyerreicks@digium.com>
Mon, 17 Mar 2014 22:24:03 +0000 (22:24 +0000)
committerRuss Meyerriecks <rmeyerreicks@digium.com>
Mon, 17 Mar 2014 22:24:03 +0000 (22:24 +0000)
commited50ef4dc87f16ee32914f1e1d28fe74902d3a83
tree2c2634bcaeae3b8d0f95743f002bc2c1fd457a8a
parenteba91d2a98ac5a6558513549670162ab20ab6d68
callerid: Logic error in checksum processing

Callerid checksum-ing was being handled incorrectly here. When the checksum is
calculated to be 0x00, it will perform 0x100-0x00 which results in 0x100. This
value will then fail the otherwise correct callerid message.

This patch changes the logic to simply add the calculated checksum to the
transmitted 2's compliment checksum.

Review: https://reviewboard.asterisk.org/r/3356/
(closes issue ASTERISK-23488)

........
This is a merge of merged revisions 410750 410747 from http://svn.asterisk.org/svn/asterisk/branches/12
I didn't want a broken patch to be comitted to trunk so I pre-merge merged them.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@410775 65c4cc65-6c06-0410-ace0-fbb531ad65f3
main/callerid.c