Fix another crash related to cached realtime music on hold.
authorMark Michelson <mmichelson@digium.com>
Mon, 13 Apr 2009 19:31:48 +0000 (19:31 +0000)
committerMark Michelson <mmichelson@digium.com>
Mon, 13 Apr 2009 19:31:48 +0000 (19:31 +0000)
This was another off-by-one problem caused by moh_register.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188102 65c4cc65-6c06-0410-ace0-fbb531ad65f3

res/res_musiconhold.c

index 01920e0..c1ab05d 100644 (file)
@@ -1072,7 +1072,9 @@ static int moh_register(struct mohclass *moh, int reload, int unref)
                if (!mohclass->delete) {
                        ast_log(LOG_WARNING, "Music on Hold class '%s' already exists\n", moh->name);
                        mohclass = mohclass_unref(mohclass, "unreffing mohclass we just found by name");
-                       moh = mohclass_unref(moh, "unreffing potential new moh class (it is a duplicate)");
+                       if (unref) {
+                               moh = mohclass_unref(moh, "unreffing potential new moh class (it is a duplicate)");
+                       }
                        return -1;
                }
                mohclass = mohclass_unref(mohclass, "Unreffing mohclass we just found by name");