Fix a couple of bugs in test tab completion.
authorMark Michelson <mmichelson@digium.com>
Wed, 17 Feb 2010 22:44:53 +0000 (22:44 +0000)
committerMark Michelson <mmichelson@digium.com>
Wed, 17 Feb 2010 22:44:53 +0000 (22:44 +0000)
1. Add missing unlock of lists.
2. Swap order of arguments to test_cat_cmp in complete_test_name.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247381 65c4cc65-6c06-0410-ace0-fbb531ad65f3

main/test.c

index 41e00a8..082af29 100644 (file)
@@ -579,6 +579,7 @@ static char *complete_test_category(const char *line, const char *word, int pos,
                        break;
                }
        }
+       AST_LIST_UNLOCK(&tests);
        return ret;
 }
 
@@ -591,11 +592,12 @@ static char *complete_test_name(const char *line, const char *word, int pos, int
 
        AST_LIST_LOCK(&tests);
        AST_LIST_TRAVERSE(&tests, test, entry) {
-               if (!test_cat_cmp(category, test->info.category) && (!strncasecmp(word, test->info.name, wordlen) && ++which > state)) {
+               if (!test_cat_cmp(test->info.category, category) && (!strncasecmp(word, test->info.name, wordlen) && ++which > state)) {
                        ret = ast_strdup(test->info.name);
                        break;
                }
        }
+       AST_LIST_UNLOCK(&tests);
        return ret;
 }