Be sure that we cache included files for each source file which loads
authorMark Michelson <mmichelson@digium.com>
Wed, 21 May 2008 02:20:31 +0000 (02:20 +0000)
committerMark Michelson <mmichelson@digium.com>
Wed, 21 May 2008 02:20:31 +0000 (02:20 +0000)
a configuration file.  As it was, only the first did so. This led to
a problem if the included file was changed (but not the configuration
file which includes it) and the second source file attempted to reload
the configuration. It would not see that the included file had changed.

In this particular example, res_phoneprov and chan_sip both loaded
sip.conf, which included a file call sip.peers.conf. Since res_phoneprov
was the first to load sip.conf, only it cached the fact that sip.conf
included sip.peers.conf. If sip.peers.conf were changed and sip.conf were
not and a sip reload were issued (meaning that chan_sip attempts to
reload sip.conf only if it and its included files have changed) the changes
made to sip.peers.conf would not be seen and therefore no action would be
taken.

(closes issue #12693)
Reported by: marsosa

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117367 65c4cc65-6c06-0410-ace0-fbb531ad65f3

main/config.c

index 2d70718..4b035a4 100644 (file)
@@ -864,7 +864,7 @@ static void config_cache_attribute(const char *configfile, enum config_cache_att
        /* Find our cached entry for this configuration file */
        AST_LIST_LOCK(&cfmtime_head);
        AST_LIST_TRAVERSE(&cfmtime_head, cfmtime, list) {
-               if (!strcmp(cfmtime->filename, configfile))
+               if (!strcmp(cfmtime->filename, configfile) && !strcmp(cfmtime->who_asked, who_asked))
                        break;
        }
        if (!cfmtime) {