res_fax: Remove checks for unsigned values being >= 0.
authorCorey Farrell <git@cfware.com>
Sun, 19 Nov 2017 02:02:17 +0000 (21:02 -0500)
committerCorey Farrell <git@cfware.com>
Sun, 19 Nov 2017 02:02:17 +0000 (21:02 -0500)
It's impossible for gwtimeout or fdtimeout to be less than 0 because
they are unsigned int's.  Remove checks and unreachable branches.

Change-Id: Ib2286960621e6ee245e40013c84986143302bc78

res/res_fax.c

index b25b6d1..4a1c084 100644 (file)
@@ -4561,12 +4561,7 @@ static int acf_faxopt_write(struct ast_channel *chan, const char *cmd, char *dat
                                        unsigned int gwtimeout;
 
                                        if (sscanf(timeout, "%30u", &gwtimeout) == 1) {
-                                               if (gwtimeout >= 0) {
-                                                       details->gateway_timeout = gwtimeout * 1000;
-                                               } else {
-                                                       ast_log(LOG_WARNING, "%s(%s) timeout cannot be negative.  Ignoring timeout\n",
-                                                               cmd, data);
-                                               }
+                                               details->gateway_timeout = gwtimeout * 1000;
                                        } else {
                                                ast_log(LOG_WARNING, "Unsupported timeout '%s' passed to FAXOPT(%s).\n", timeout, data);
                                        }
@@ -4605,13 +4600,7 @@ static int acf_faxopt_write(struct ast_channel *chan, const char *cmd, char *dat
                        if (details->faxdetect_id < 0) {
                                if (timeout) {
                                        if (sscanf(timeout, "%30u", &fdtimeout) == 1) {
-                                               if (fdtimeout >= 0) {
-                                                       fdtimeout *= 1000;
-                                               } else {
-                                                       ast_log(LOG_WARNING, "%s(%s) timeout cannot be negative.  Ignoring timeout\n",
-                                                               cmd, data);
-                                                       fdtimeout = 0;
-                                               }
+                                               fdtimeout *= 1000;
                                        } else {
                                                ast_log(LOG_WARNING, "Unsupported timeout '%s' passed to FAXOPT(%s).\n",
                                                        timeout, data);