res_pjsip_session: Enable RFC3578 overlap dialing support.
authorRichard Begg <asterisk@meric.id.au>
Tue, 14 Mar 2017 21:45:06 +0000 (08:45 +1100)
committerJoshua Colp <jcolp@digium.com>
Wed, 22 Mar 2017 11:26:48 +0000 (11:26 +0000)
Support for RFC3578 overlap dialling (i.e. 484 Response to partially matched
destinations) as currently provided by chan_sip is missing from res_pjsip.
This patch adds a new endpoint attribute (allow_overlap) [defaults to yes]
which when set to yes enables 484 responses to partial destination
matches rather than the current 404.

ASTERISK-26864

Change-Id: Iea444da3ee7c7d4f1fde1d01d138a3d7b0fe40f6

CHANGES
configs/samples/pjsip.conf.sample
contrib/ast-db-manage/config/versions/8fce4c573e15_add_pjsip_allow_overlap.py [new file with mode: 0644]
include/asterisk/res_pjsip.h
res/res_pjsip.c
res/res_pjsip/pjsip_configuration.c
res/res_pjsip_session.c

diff --git a/CHANGES b/CHANGES
index e391d1e..244111f 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -134,6 +134,10 @@ res_pjsip
    added to both transport and subscription_persistence, an alembic upgrade
    should be run to bring the database tables up to date.
 
+ * A new option, allow_overlap, has been added to endpoints which allows
+   overlap dialing functionality to be enabled or disabled. The option defaults
+   to enabled.
+
 res_pjsip_transport_websocket
 ------------------
  * Removed non-secure websocket support.  Firefox and Chrome have not allowed
index 120a7ef..bb80768 100644 (file)
                 ; "yes")
 ;aggregate_mwi=yes      ;  (default: "yes")
 ;allow= ; Media Codec s to allow (default: "")
+;allow_overlap=yes ; Enable RFC3578 overlap dialing support. (default: "yes")
 ;aors=  ; AoR s to be used with the endpoint (default: "")
 ;auth=  ; Authentication Object s associated with the endpoint (default: "")
 ;callerid=      ; CallerID information for the endpoint (default: "")
diff --git a/contrib/ast-db-manage/config/versions/8fce4c573e15_add_pjsip_allow_overlap.py b/contrib/ast-db-manage/config/versions/8fce4c573e15_add_pjsip_allow_overlap.py
new file mode 100644 (file)
index 0000000..24057ec
--- /dev/null
@@ -0,0 +1,31 @@
+"""add pjsip allow_overlap
+
+Revision ID: 8fce4c573e15
+Revises: f638dbe2eb23
+Create Date: 2017-03-21 15:14:27.612945
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = '8fce4c573e15'
+down_revision = 'f638dbe2eb23'
+
+from alembic import op
+import sqlalchemy as sa
+from sqlalchemy.dialects.postgresql import ENUM
+
+YESNO_NAME = 'yesno_values'
+YESNO_VALUES = ['yes', 'no']
+
+def upgrade():
+    ############################# Enums ##############################
+
+    # yesno_values have already been created, so use postgres enum object
+    # type to get around "already created" issue - works okay with mysql
+    yesno_values = ENUM(*YESNO_VALUES, name=YESNO_NAME, create_type=False)
+
+    op.add_column('ps_endpoints', sa.Column('allow_overlap', yesno_values))
+
+
+def downgrade():
+    op.drop_column('ps_endpoints', 'allow_overlap')
index c6c308b..6f44852 100644 (file)
@@ -765,6 +765,8 @@ struct ast_sip_endpoint {
        unsigned int preferred_codec_only;
        /*! Do we allow an asymmetric RTP codec? */
        unsigned int asymmetric_rtp_codec;
+       /*! Do we allow overlap dialling? */
+       unsigned int allow_overlap;
 };
 
 /*! URI parameter for symmetric transport */
index 962c4be..e4bcb70 100644 (file)
                                <configOption name="allow">
                                        <synopsis>Media Codec(s) to allow</synopsis>
                                </configOption>
+                               <configOption name="allow_overlap" default="yes">
+                                       <synopsis>Enable RFC3578 overlap dialing support.</synopsis>
+                               </configOption>
                                <configOption name="aors">
                                        <synopsis>AoR(s) to be used with the endpoint</synopsis>
                                        <description><para>
                                <parameter name="SubscribeContext">
                                        <para><xi:include xpointer="xpointer(/docs/configInfo[@name='res_pjsip']/configFile[@name='pjsip.conf']/configObject[@name='endpoint']/configOption[@name='subscribe_context']/synopsis/node())"/></para>
                                </parameter>
+                               <parameter name="Allowoverlap">
+                                       <para><xi:include xpointer="xpointer(/docs/configInfo[@name='res_pjsip']/configFile[@name='pjsip.conf']/configObject[@name='endpoint']/configOption[@name='allow_overlap']/synopsis/node())"/></para>
+                               </parameter>
                        </syntax>
                </managerEventInstance>
        </managerEvent>
index c8ff427..02562e7 100644 (file)
@@ -1938,6 +1938,7 @@ int ast_res_pjsip_initialize_configuration(void)
        ast_sorcery_object_field_register(sip_sorcery, "endpoint", "preferred_codec_only", "no", OPT_BOOL_T, 1, FLDSET(struct ast_sip_endpoint, preferred_codec_only));
        ast_sorcery_object_field_register(sip_sorcery, "endpoint", "asymmetric_rtp_codec", "no", OPT_BOOL_T, 1, FLDSET(struct ast_sip_endpoint, asymmetric_rtp_codec));
        ast_sorcery_object_field_register(sip_sorcery, "endpoint", "rtcp_mux", "no", OPT_BOOL_T, 1, FLDSET(struct ast_sip_endpoint, media.rtcp_mux));
+       ast_sorcery_object_field_register(sip_sorcery, "endpoint", "allow_overlap", "yes", OPT_BOOL_T, 1, FLDSET(struct ast_sip_endpoint, allow_overlap));
 
        if (ast_sip_initialize_sorcery_transport()) {
                ast_log(LOG_ERROR, "Failed to register SIP transport support with sorcery\n");
index de073d3..5f42dab 100644 (file)
@@ -1986,10 +1986,17 @@ static enum sip_get_destination_result get_destination(struct ast_sip_session *s
 
                return SIP_GET_DEST_EXTEN_FOUND;
        }
-       /* XXX In reality, we'll likely have further options so that partial matches
-        * can be indicated here, but for getting something up and running, we're going
-        * to return a "not exists" error here.
+
+       /*
+        * Check for partial match via overlap dialling (if enabled)
         */
+       if (session->endpoint->allow_overlap && (
+               !strncmp(session->exten, pickupexten, strlen(session->exten)) ||
+               ast_canmatch_extension(NULL, session->endpoint->context, session->exten, 1, NULL))) {
+               /* Overlap partial match */
+               return SIP_GET_DEST_EXTEN_PARTIAL;
+       }
+
        return SIP_GET_DEST_EXTEN_NOT_FOUND;
 }
 
@@ -2106,8 +2113,17 @@ static int new_invite(void *data)
                        pjsip_inv_terminate(invite->session->inv_session, 416, PJ_TRUE);
                }
                goto end;
-       case SIP_GET_DEST_EXTEN_NOT_FOUND:
        case SIP_GET_DEST_EXTEN_PARTIAL:
+               ast_debug(1, "Call from '%s' (%s:%s:%d) to extension '%s' - partial match\n", ast_sorcery_object_get_id(invite->session->endpoint),
+                       invite->rdata->tp_info.transport->type_name, invite->rdata->pkt_info.src_name, invite->rdata->pkt_info.src_port, invite->session->exten);
+
+               if (pjsip_inv_initial_answer(invite->session->inv_session, invite->rdata, 484, NULL, NULL, &tdata) == PJ_SUCCESS) {
+                       ast_sip_session_send_response(invite->session, tdata);
+               } else  {
+                       pjsip_inv_terminate(invite->session->inv_session, 484, PJ_TRUE);
+               }
+               goto end;
+       case SIP_GET_DEST_EXTEN_NOT_FOUND:
        default:
                ast_log(LOG_NOTICE, "Call from '%s' (%s:%s:%d) to extension '%s' rejected because extension not found in context '%s'.\n",
                        ast_sorcery_object_get_id(invite->session->endpoint), invite->rdata->tp_info.transport->type_name, invite->rdata->pkt_info.src_name,