bridge_softmix: Removed unused parameter from check_binaural_position_change(.).
authorAlexander Traud <pabstraud@compuserve.com>
Fri, 5 Jan 2018 12:06:33 +0000 (13:06 +0100)
committerAlexander Traud <pabstraud@compuserve.com>
Sat, 6 Jan 2018 18:06:00 +0000 (19:06 +0100)
Found as a result of the function being passed an uninitalized variable by
clang.

ASTERISK-27550

Change-Id: I8af3bd84656b685a956d498459f8db3613f68954

bridges/bridge_softmix.c
bridges/bridge_softmix/bridge_softmix_binaural.c
bridges/bridge_softmix/include/bridge_softmix_internal.h

index 83b1a83..3343569 100644 (file)
@@ -1404,7 +1404,7 @@ static int softmix_mixing_loop(struct ast_bridge *bridge)
                }
 
 #ifdef BINAURAL_RENDERING
-               check_binaural_position_change(bridge, softmix_data, bridge_channel);
+               check_binaural_position_change(bridge, softmix_data);
 #endif
 
                /* Go through pulling audio from each factory that has it available */
index 128e464..2a8efd7 100644 (file)
@@ -465,9 +465,10 @@ void softmix_process_write_binaural_audio(struct softmix_channel *sc,
 }
 
 void check_binaural_position_change(struct ast_bridge *bridge,
-               struct softmix_bridge_data *softmix_data, struct ast_bridge_channel *bridge_channel)
+               struct softmix_bridge_data *softmix_data)
 {
        unsigned int pos_change;
+       struct ast_bridge_channel *bridge_channel;
 
        /*
         * We only check binaural things if binaural is activated by the config
index 01e65aa..f842acb 100644 (file)
@@ -377,10 +377,9 @@ void softmix_process_write_binaural_audio(struct softmix_channel *sc,
  *
  * \param bridge The conference bridge.
  * \param softmix_data The data used by the softmix bridge.
- * \param bridge_channel The bridge channel.
  */
 void check_binaural_position_change(struct ast_bridge *bridge,
-               struct softmix_bridge_data *softmix_data, struct ast_bridge_channel *bridge_channel);
+               struct softmix_bridge_data *softmix_data);
 
 /*!
  * \brief Processes audio data with the binaural synthesis and adds the result to the mixing array.