PJSIP: Add log messages when requests are received for non-existent endpoints
authorJonathan Rose <jrose@digium.com>
Fri, 25 Oct 2013 17:41:38 +0000 (17:41 +0000)
committerJonathan Rose <jrose@digium.com>
Fri, 25 Oct 2013 17:41:38 +0000 (17:41 +0000)
(closes issue ASTERISK-22552)
Reported by: Rusty Newton
Review: https://reviewboard.asterisk.org/r/2934/
........

Merged revisions 401938 from http://svn.asterisk.org/svn/asterisk/branches/12

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@401939 65c4cc65-6c06-0410-ace0-fbb531ad65f3

res/res_pjsip/pjsip_distributor.c
res/res_pjsip_endpoint_identifier_user.c

index d7a92ab..9fd6250 100644 (file)
@@ -232,6 +232,16 @@ struct ast_sip_endpoint *ast_sip_get_artificial_endpoint(void)
        return artificial_endpoint;
 }
 
+static void log_unidentified_request(pjsip_rx_data *rdata)
+{
+       char from_buf[PJSIP_MAX_URL_SIZE];
+       char callid_buf[PJSIP_MAX_URL_SIZE];
+       pjsip_uri_print(PJSIP_URI_IN_FROMTO_HDR, rdata->msg_info.from->uri, from_buf, PJSIP_MAX_URL_SIZE);
+       ast_copy_pj_str(callid_buf, &rdata->msg_info.cid->id, PJSIP_MAX_URL_SIZE);
+       ast_log(LOG_NOTICE, "Request from '%s' failed for '%s:%d' (callid: %s) - No matching endpoint found\n",
+               from_buf, rdata->pkt_info.src_name, rdata->pkt_info.src_port, callid_buf);
+}
+
 static pj_bool_t endpoint_lookup(pjsip_rx_data *rdata)
 {
        struct ast_sip_endpoint *endpoint;
@@ -262,6 +272,7 @@ static pj_bool_t endpoint_lookup(pjsip_rx_data *rdata)
                        ast_copy_pj_str(name, &sip_from->user, sizeof(name));
                }
 
+               log_unidentified_request(rdata);
                ast_sip_report_invalid_endpoint(name, rdata);
        }
        rdata->endpt_info.mod_data[endpoint_mod.id] = endpoint;
index 29266fe..4b10bd3 100644 (file)
@@ -102,6 +102,8 @@ done:
                        return NULL;
                }
                ast_debug(3, "Retrieved endpoint %s\n", ast_sorcery_object_get_id(endpoint));
+       } else {
+               ast_debug(3, "Could not identify endpoint by username '%s'\n", endpoint_name);
        }
        return endpoint;
 }