Fix memory stomping bug in astman.
authorDavid M. Lee <dlee@digium.com>
Thu, 27 Feb 2014 16:26:18 +0000 (16:26 +0000)
committerDavid M. Lee <dlee@digium.com>
Thu, 27 Feb 2014 16:26:18 +0000 (16:26 +0000)
This memset complained in dev mod on my Ubuntu box. The memset is both
unnecessary and dangerous. At this point, m hasn't been initialized
yet, so the memset will write off to whatever address happens to be
on the stack at the time.
........

Merged revisions 409077 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........

Merged revisions 409083 from http://svn.asterisk.org/svn/asterisk/branches/11
........

Merged revisions 409087 from http://svn.asterisk.org/svn/asterisk/branches/12

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@409091 65c4cc65-6c06-0410-ace0-fbb531ad65f3

utils/astman.c

index 6527e99..3e9ca8f 100644 (file)
@@ -737,7 +737,6 @@ static int manager_login(char *hostname)
                                        show_message("Login Failed", get_header(m, "Message"));
                                }
                        } else {
-                               memset(m, 0, sizeof(*m));
                                manager_action("Login", 
                                        "Username: %s\r\n"
                                        "Secret: %s\r\n",