Don't continue sending the file when there has been an error
authorTerry Wilson <twilson@digium.com>
Tue, 15 Jun 2010 21:42:33 +0000 (21:42 +0000)
committerTerry Wilson <twilson@digium.com>
Tue, 15 Jun 2010 21:42:33 +0000 (21:42 +0000)
If there is a problem with a firmware file, Polycom phones will close the
connection. We were continuing to send the file anyway. There should be no
reason to continue sending a file if there is an error writing it.

(closes issue #16682)
Reported by: lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@270692 65c4cc65-6c06-0410-ace0-fbb531ad65f3

main/http.c

index 89bde86..dcbfc4d 100644 (file)
@@ -415,6 +415,7 @@ void ast_http_send(struct ast_tcptls_session_instance *ser,
                        while ((len = read(fd, buf, sizeof(buf))) > 0) {
                                if (fwrite(buf, len, 1, ser->f) != 1) {
                                        ast_log(LOG_WARNING, "fwrite() failed: %s\n", strerror(errno));
+                                       break;
                                }
                        }
                }