Merged revisions 278981 via svnmerge from
authorTilghman Lesher <tilghman@meg.abyt.es>
Fri, 23 Jul 2010 16:43:34 +0000 (16:43 +0000)
committerTilghman Lesher <tilghman@meg.abyt.es>
Fri, 23 Jul 2010 16:43:34 +0000 (16:43 +0000)
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r278981 | tilghman | 2010-07-23 11:42:25 -0500 (Fri, 23 Jul 2010) | 8 lines

  Avoid race with consolethread on shutdown (on parallel processors).

  (closes issue #17080)
   Reported by: sybasesql
   Patches:
         20100721__issue17080.diff.txt uploaded by tilghman (license 14)
   Tested by: sybasesql
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@278982 65c4cc65-6c06-0410-ace0-fbb531ad65f3

main/asterisk.c

index e82223d..d8d3aeb 100644 (file)
@@ -1635,14 +1635,21 @@ static void quit_handler(int num, int niceness, int safeshutdown, int restart)
                        ast_module_shutdown();
        }
        if (ast_opt_console || (ast_opt_remote && !ast_opt_exec)) {
-               if (getenv("HOME")) 
+               if (getenv("HOME")) {
                        snprintf(filename, sizeof(filename), "%s/.asterisk_history", getenv("HOME"));
-               if (!ast_strlen_zero(filename))
+               }
+               if (!ast_strlen_zero(filename)) {
                        ast_el_write_history(filename);
-               if (el != NULL)
-                       el_end(el);
-               if (el_hist != NULL)
-                       history_end(el_hist);
+               }
+               if (consolethread == AST_PTHREADT_NULL || consolethread == pthread_self()) {
+                       /* Only end if we are the consolethread, otherwise there's a race with that thread. */
+                       if (el != NULL) {
+                               el_end(el);
+                       }
+                       if (el_hist != NULL) {
+                               history_end(el_hist);
+                       }
+               }
        }
        if (option_verbose)
                ast_verbose("Executing last minute cleanups\n");