Properly copy/remove the device state cache flag over a masquerade.
authorWalter Doekes <walter+asterisk@wjd.nu>
Fri, 18 Oct 2013 14:50:27 +0000 (14:50 +0000)
committerWalter Doekes <walter+asterisk@wjd.nu>
Fri, 18 Oct 2013 14:50:27 +0000 (14:50 +0000)
In r378303 the AST_FLAG_DISABLE_DEVSTATE_CACHE flag was added that tells
the devstate system to not cache states for non-real devices. However,
when optimizing away channels (ast_do_masquerade), that flag wasn't
copied.

In my case, using Local devices as queue members created a situation
where the endpoint was considered in use, but the state change of the
device being available again was ignored (not cached). The endpoint
channel was optimized into the (previously) Local channel, but kept
the do-not-cache flag. The end result being that the queue member
apparently stayed in use forever.

(closes issue ASTERISK-22718)
Reported by: Walter Doekes

Review: https://reviewboard.asterisk.org/r/2925/
........

Merged revisions 401178 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........

Merged revisions 401179 from http://svn.asterisk.org/svn/asterisk/branches/11
........

Merged revisions 401180 from http://svn.asterisk.org/svn/asterisk/branches/12

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@401181 65c4cc65-6c06-0410-ace0-fbb531ad65f3

main/channel.c

index e6025c0..6846b84 100644 (file)
@@ -6433,6 +6433,8 @@ void ast_do_masquerade(struct ast_channel *original)
 {
        int x;
        int origstate;
+       unsigned int orig_disablestatecache;
+       unsigned int clone_disablestatecache;
        int visible_indication;
        int clone_was_zombie = 0;/*!< TRUE if the clonechan was a zombie before the masquerade. */
        int clone_hold_state;
@@ -6615,6 +6617,20 @@ void ast_do_masquerade(struct ast_channel *original)
        ast_channel_state_set(original, ast_channel_state(clonechan));
        ast_channel_state_set(clonechan, origstate);
 
+       /* And the swap the cachable state too. Otherwise we'd start caching
+        * Local channels and ignoring real ones. */
+       orig_disablestatecache = ast_test_flag(ast_channel_flags(original), AST_FLAG_DISABLE_DEVSTATE_CACHE);
+       clone_disablestatecache = ast_test_flag(ast_channel_flags(clonechan), AST_FLAG_DISABLE_DEVSTATE_CACHE);
+       if (orig_disablestatecache != clone_disablestatecache) {
+               if (orig_disablestatecache) {
+                       ast_clear_flag(ast_channel_flags(original), AST_FLAG_DISABLE_DEVSTATE_CACHE);
+                       ast_set_flag(ast_channel_flags(clonechan), AST_FLAG_DISABLE_DEVSTATE_CACHE);
+               } else {
+                       ast_set_flag(ast_channel_flags(original), AST_FLAG_DISABLE_DEVSTATE_CACHE);
+                       ast_clear_flag(ast_channel_flags(clonechan), AST_FLAG_DISABLE_DEVSTATE_CACHE);
+               }
+       }
+
        /* Update the type. */
        t_pvt = ast_channel_monitor(original);
        ast_channel_monitor_set(original, ast_channel_monitor(clonechan));