3 years agobridge_softmix: Note why ast_stream_topology_set_stream cannot fail.
Corey Farrell [Tue, 7 Nov 2017 17:49:35 +0000 (12:49 -0500)]
bridge_softmix: Note why ast_stream_topology_set_stream cannot fail.

This appeared in my audit of ast_stream_topology_set_stream callers
not checking for errors but in this situation the call cannot fail.
Add comment so this can be ignored in the future.

Change-Id: I91d25704859efbe50b8b82cfe1cd3c40ba177c9f

3 years agoMerge "AST-2017-009: pjproject: Add validation of numeric header values"
George Joseph [Wed, 8 Nov 2017 15:52:47 +0000 (09:52 -0600)]
Merge "AST-2017-009: pjproject: Add validation of numeric header values"

3 years agoMerge "AST-2017-011 - res_pjsip_session: session leak when a call is rejected"
George Joseph [Wed, 8 Nov 2017 15:45:24 +0000 (09:45 -0600)]
Merge "AST-2017-011 - res_pjsip_session: session leak when a call is rejected"

3 years agoMerge "AST-2017-010: Fix cdr_object_update_party_b_userfield_cb() buf overrun"
George Joseph [Wed, 8 Nov 2017 14:25:54 +0000 (08:25 -0600)]
Merge "AST-2017-010: Fix cdr_object_update_party_b_userfield_cb() buf overrun"

3 years agoMerge "res_pjproject.c: Fix ast_strdup() alloc failure."
Joshua Colp [Wed, 8 Nov 2017 13:38:45 +0000 (07:38 -0600)]
Merge "res_pjproject.c: Fix ast_strdup() alloc failure."

3 years agoAST-2017-011 - res_pjsip_session: session leak when a call is rejected
Kevin Harwell [Thu, 19 Oct 2017 18:35:16 +0000 (13:35 -0500)]
AST-2017-011 - res_pjsip_session: session leak when a call is rejected

A previous commit made it so when an invite session transitioned into a
disconnected state destruction of the Asterisk pjsip session object was
postponed until either a transport error occurred or the event timer
expired. However, if a call was rejected (for instance a 488) before the
session was fully established the event timer may not have been initiated,
or it was canceled without triggering either of the session finalizing states
mentioned above.

Really the only time destruction of the session should be delayed is when a
BYE is being transacted. This is because it's possible in some cases for the
session to be disconnected, but the BYE is still transacting.

This patch makes it so the session object always gets released (no more
memory leak) when the pjsip session is in a disconnected state. Except when
the method is a BYE. Then it waits until a transport error occurs or an event

ASTERISK-27345 #close

Reported by: Corey Farrell

Change-Id: I1e724737b758c20ac76d19d3611e3d2876ae10ed

3 years agoAST-2017-010: Fix cdr_object_update_party_b_userfield_cb() buf overrun
Richard Mudgett [Tue, 3 Oct 2017 21:19:52 +0000 (16:19 -0500)]
AST-2017-010: Fix cdr_object_update_party_b_userfield_cb() buf overrun

cdr_object_update_party_b_userfield_cb() could overrun the fixed buffer if
the supplied string is too long.  The long string could be supplied by
external means using the CDR(userfield) function.

This may seem reminiscent to AST-2017-001 (ASTERISK_26897) and it is.  The
earlier patch fixed the buffer overrun for Party A's userfield while this
patch fixes the same thing for Party B's userfield.


Change-Id: I0fa767f65ecec7e676ca465306ff9e0edbf3b652

3 years agoAST-2017-009: pjproject: Add validation of numeric header values
George Joseph [Thu, 19 Oct 2017 18:53:32 +0000 (12:53 -0600)]
AST-2017-009: pjproject: Add validation of numeric header values

Parsing the numeric header fields like cseq, ttl, port, etc. all
had the potential to overflow, either causing unintended values to
be captured or, if the values were subsequently converted back to
strings, a buffer overrun.  To address this, new "strto" functions
have been created that do range checking and those functions are
used wherever possible in the parser.

 * Created pjlib/include/limits.h and pjlib/include/compat/limits.h
   to either include the system limits.h or define common numeric
   limits if there is no system limits.h.

 * Created strto*_validate functions in sip_parser that take bounds
   and on failure call the on_str_parse_error function which prints
   an error message and calls PJ_THROW.

 * Updated sip_parser to validate the numeric fields.

 * Fixed an issue in sip_transport that prevented error messages
   from being properly displayed.

 * Added "volatile" to some variables referenced in PJ_CATCH blocks
   as the optimizer was sometimes optimizing them away.

 * Fixed length calculation in sip_transaction/create_tsx_key_2543
   to account for signed ints being 11 characters, not 9.

Reported by: Youngsung Kim at LINE Corporation

Change-Id: I48de2e4ccf196990906304e8d7061f4ffdd772ff

3 years agoMerge "stream: Return error from ast_stream_topology_set_stream."
Jenkins2 [Wed, 8 Nov 2017 12:06:51 +0000 (06:06 -0600)]
Merge "stream: Return error from ast_stream_topology_set_stream."

3 years agoMerge "res_stasis: Fix multiple leaks."
Joshua Colp [Wed, 8 Nov 2017 10:58:12 +0000 (04:58 -0600)]
Merge "res_stasis: Fix multiple leaks."

3 years agoMerge "res_pjsip_outbound_registration: Fix leak on vector add failure."
Jenkins2 [Wed, 8 Nov 2017 02:39:31 +0000 (20:39 -0600)]
Merge "res_pjsip_outbound_registration: Fix leak on vector add failure."

3 years agoMerge "res_pjsip_exten_state: Check for vector append failure."
Jenkins2 [Wed, 8 Nov 2017 02:06:26 +0000 (20:06 -0600)]
Merge "res_pjsip_exten_state: Check for vector append failure."

3 years agoMerge "res_pjsip_config_wizard: Fix leaks and add check for malloc failure."
Jenkins2 [Wed, 8 Nov 2017 01:41:46 +0000 (19:41 -0600)]
Merge "res_pjsip_config_wizard: Fix leaks and add check for malloc failure."

3 years agoMerge "res_stasis_playback: Check for failure to append vector."
Jenkins2 [Wed, 8 Nov 2017 01:02:20 +0000 (19:02 -0600)]
Merge "res_stasis_playback: Check for failure to append vector."

3 years agoMerge "res_pjsip: Fix leak on error in ast_sip_auth_vector_init."
Jenkins2 [Wed, 8 Nov 2017 00:14:28 +0000 (18:14 -0600)]
Merge "res_pjsip: Fix leak on error in ast_sip_auth_vector_init."

3 years agoMerge "test_sorcery_memory_cache_thrash: Handle error from vector append."
Jenkins2 [Tue, 7 Nov 2017 23:32:48 +0000 (17:32 -0600)]
Merge "test_sorcery_memory_cache_thrash: Handle error from vector append."

3 years agoMerge "stasis: Release object if vector append fails."
Jenkins2 [Tue, 7 Nov 2017 22:40:49 +0000 (16:40 -0600)]
Merge "stasis: Release object if vector append fails."

3 years agoMerge "res_ari_events: Fix use after free / double-free of JSON message."
Jenkins2 [Tue, 7 Nov 2017 22:10:11 +0000 (16:10 -0600)]
Merge "res_ari_events: Fix use after free / double-free of JSON message."

3 years agoMerge "PBX: Handle errors from AST_VECTOR_APPEND."
Jenkins2 [Tue, 7 Nov 2017 21:27:26 +0000 (15:27 -0600)]
Merge "PBX: Handle errors from AST_VECTOR_APPEND."

3 years agoMerge "Messaging: Report error on failure to register tech or handler."
Jenkins2 [Tue, 7 Nov 2017 20:58:05 +0000 (14:58 -0600)]
Merge "Messaging: Report error on failure to register tech or handler."

3 years agoMerge "format_cap: Fix leak on AST_VECTOR_APPEND error."
Jenkins2 [Tue, 7 Nov 2017 20:20:02 +0000 (14:20 -0600)]
Merge "format_cap: Fix leak on AST_VECTOR_APPEND error."

3 years agoMerge "CLI: Remove unused internal command."
Jenkins2 [Tue, 7 Nov 2017 19:02:30 +0000 (13:02 -0600)]
Merge "CLI: Remove unused internal command."

3 years agoMerge "res_pjsip: Avoid crash when contact uri is empty string"
Jenkins2 [Tue, 7 Nov 2017 18:08:44 +0000 (12:08 -0600)]
Merge "res_pjsip:  Avoid crash when contact uri is empty string"

3 years agoMerge "res_pjsip: Ignore empty TLS configuration"
Jenkins2 [Tue, 7 Nov 2017 17:05:13 +0000 (11:05 -0600)]
Merge "res_pjsip: Ignore empty TLS configuration"

3 years agostream: Return error from ast_stream_topology_set_stream.
Corey Farrell [Mon, 6 Nov 2017 21:38:05 +0000 (16:38 -0500)]
stream: Return error from ast_stream_topology_set_stream.

ast_stream_topology_set_stream had suppressed error codes from
AST_VECTOR_APPEND.  The result of AST_VECTOR_APPEND needs to be returned
to the caller so they can take appropriate action on the stream.

Change-Id: I6c0d12755743eadba1357f6153526cc055592856

3 years agores_stasis: Fix multiple leaks.
Corey Farrell [Mon, 6 Nov 2017 23:21:53 +0000 (18:21 -0500)]
res_stasis: Fix multiple leaks.

* res/stasis/app.c JSON passed to app_send needs to be released.
* res/stasis_message.c: objects leak if vector append fails.

Change-Id: I8dd5385b9f50a5cadf2b1d16efecffd6ddb4db4a

3 years agoMerge "tcptls: Print notice when TLS is enabled but not configured."
Joshua Colp [Tue, 7 Nov 2017 16:12:41 +0000 (10:12 -0600)]
Merge "tcptls: Print notice when TLS is enabled but not configured."

3 years agoMerge "stasis: Remove silly use of RAII_VAR in stasis_forward_all."
Joshua Colp [Tue, 7 Nov 2017 15:32:45 +0000 (09:32 -0600)]
Merge "stasis: Remove silly use of RAII_VAR in stasis_forward_all."

3 years agoMerge "stasis_channels.c: Remove a very silly RAII_VAR()."
Joshua Colp [Tue, 7 Nov 2017 14:44:12 +0000 (08:44 -0600)]
Merge "stasis_channels.c: Remove a very silly RAII_VAR()."

3 years agoMerge "stasis/app.c: Optimize stasis_app_get_debug_by_name()"
Joshua Colp [Tue, 7 Nov 2017 13:57:39 +0000 (07:57 -0600)]
Merge "stasis/app.c: Optimize stasis_app_get_debug_by_name()"

3 years agoMerge "Fix ast_(v)asprintf() malloc failure usage conditions."
Joshua Colp [Tue, 7 Nov 2017 13:18:12 +0000 (07:18 -0600)]
Merge "Fix ast_(v)asprintf() malloc failure usage conditions."

3 years agores_pjproject.c: Fix ast_strdup() alloc failure.
Richard Mudgett [Tue, 7 Nov 2017 12:56:08 +0000 (06:56 -0600)]
res_pjproject.c: Fix ast_strdup() alloc failure.

Change-Id: I74688038e7afe3a279359cce53aadb28ade51ead

3 years agores_pjsip: Avoid crash when contact uri is empty string
Aaron An [Mon, 6 Nov 2017 04:06:15 +0000 (12:06 +0800)]
res_pjsip:  Avoid crash when contact uri is empty string

Asterisk will crash if contact uri is invalid, so contact_apply_handler
should check if the uri is NULL or empty.

ASTERISK-27393 #close
Reported-by: Aaron An
Tested-by: AaronAn

Change-Id: Ia0309bdc6b697c73c9c736e1caec910b77ca69f5

3 years agoMerge "RTP Engine: Deal with errors returned from AST_VECTOR_REPLACE."
Joshua Colp [Tue, 7 Nov 2017 12:36:32 +0000 (06:36 -0600)]
Merge "RTP Engine: Deal with errors returned from AST_VECTOR_REPLACE."

3 years agores_pjsip_outbound_registration: Fix leak on vector add failure.
Corey Farrell [Mon, 6 Nov 2017 23:55:00 +0000 (18:55 -0500)]
res_pjsip_outbound_registration: Fix leak on vector add failure.

Change-Id: I774b88b3c9da41edd4dc8d78f095481f52f2bd46

3 years agores_pjsip_exten_state: Check for vector append failure.
Corey Farrell [Mon, 6 Nov 2017 23:48:06 +0000 (18:48 -0500)]
res_pjsip_exten_state: Check for vector append failure.

Release reference to publisher if we fail to add it to the vector.

Change-Id: I64dff3f481b67b9884f37cadba7a5ccf23d084f3

3 years agores_pjsip_config_wizard: Fix leaks and add check for malloc failure.
Corey Farrell [Mon, 6 Nov 2017 23:44:01 +0000 (18:44 -0500)]
res_pjsip_config_wizard: Fix leaks and add check for malloc failure.

- Free host if we fail to add it to the vector.

- Check for otw allocation failure.
- Free otw if we fail to add it to the vector.

Change-Id: Ib5d3bcabbd9c24dd8a3c9cc692a794a5f60243ad

3 years agores_stasis_playback: Check for failure to append vector.
Corey Farrell [Mon, 6 Nov 2017 23:38:35 +0000 (18:38 -0500)]
res_stasis_playback: Check for failure to append vector.

Free resources and return error if we fail to append the vector in

Change-Id: I22c4a90dd859b253f2850c6511de48b25609422b

3 years agotest_sorcery_memory_cache_thrash: Handle error from vector append.
Corey Farrell [Mon, 6 Nov 2017 23:33:13 +0000 (18:33 -0500)]
test_sorcery_memory_cache_thrash: Handle error from vector append.

Cleanup resources when we fail to append the vector and report test

Change-Id: I6eb41586fd11dee8c0dfe35e91cb465a4cab7298

3 years agores_pjsip: Fix leak on error in ast_sip_auth_vector_init.
Corey Farrell [Mon, 6 Nov 2017 23:28:35 +0000 (18:28 -0500)]
res_pjsip: Fix leak on error in ast_sip_auth_vector_init.

Change-Id: Ib0fc7a18f3135ca8990c3984c9e15f6d26e556e8

3 years agores_pjproject: Handle error from adding to the buildopts vector.
Corey Farrell [Mon, 6 Nov 2017 23:17:13 +0000 (18:17 -0500)]
res_pjproject: Handle error from adding to the buildopts vector.

Change-Id: I076c7bd207c7989a23005395ce1735392657be65

3 years agores_ari_events: Fix use after free / double-free of JSON message.
Corey Farrell [Mon, 6 Nov 2017 23:11:08 +0000 (18:11 -0500)]
res_ari_events: Fix use after free / double-free of JSON message.

When stasis_app_message_handler needs to queue a message for a later
connection it needs to bump the message reference so it doesn't get
freed when the caller releases it's reference.

Change-Id: I82696df8fe723b3365c15c3f7089501da8daa892

3 years agostasis: Release object if vector append fails.
Corey Farrell [Mon, 6 Nov 2017 21:33:00 +0000 (16:33 -0500)]
stasis: Release object if vector append fails.

Change-Id: I3e5cc669169aab6175ddfaf7486edeaeb4fdcfb1

3 years agoRTP Engine: Deal with errors returned from AST_VECTOR_REPLACE.
Corey Farrell [Mon, 6 Nov 2017 21:20:06 +0000 (16:20 -0500)]
RTP Engine: Deal with errors returned from AST_VECTOR_REPLACE.

Check for errors from AST_VECTOR_REPLACE and clean memory if needed.

Change-Id: I124d15cc1d645f85a72a1279f623c1993b304b0b

3 years agoPBX: Handle errors from AST_VECTOR_APPEND.
Corey Farrell [Mon, 6 Nov 2017 21:16:35 +0000 (16:16 -0500)]
PBX: Handle errors from AST_VECTOR_APPEND.

This resolves potentials leaks on AST_VECTOR_APPEND error in:
* ast_context_add_include2
* ast_context_add_switch2
* ast_context_add_ignorepat2

Change-Id: Ib60e95c4f622fa3b832d87227c0523a695d736b6

3 years agoMessaging: Report error on failure to register tech or handler.
Corey Farrell [Mon, 6 Nov 2017 21:10:56 +0000 (16:10 -0500)]
Messaging: Report error on failure to register tech or handler.

Message tech and handler registrations use a vector which could fail to
expand.  If it does log and error and return error.

Change-Id: I593a8de81a07fb0452e9b0efd5d4018b77bca6f4

3 years agoformat_cap: Fix leak on AST_VECTOR_APPEND error.
Corey Farrell [Mon, 6 Nov 2017 21:07:01 +0000 (16:07 -0500)]
format_cap: Fix leak on AST_VECTOR_APPEND error.

format_cap_framed_init can fail on AST_VECTOR_APPEND.  This should
report failure to the caller and clean the newly allocated frame.

Change-Id: Ica0661235bf09497bf23d844ceb01f21b41a55b0

3 years agostasis: Remove silly use of RAII_VAR in stasis_forward_all.
Corey Farrell [Mon, 6 Nov 2017 20:23:46 +0000 (15:23 -0500)]
stasis: Remove silly use of RAII_VAR in stasis_forward_all.

Change-Id: I46de4c968d40144d5b049966304ff66c1469fb65

3 years agoCLI: Remove unused internal command.
Corey Farrell [Mon, 6 Nov 2017 18:51:32 +0000 (13:51 -0500)]
CLI: Remove unused internal command.

The internal CLI command "_command complete" was last used by Asterisk
0.2.0.  Since then we've been using "_command nummatches" and "_command

Change-Id: I682fe1e21a24a3bb5bd04146e639f1c5866bcfce

3 years agoMerge "dtls: Add support for ephemeral DTLS certificates."
Joshua Colp [Mon, 6 Nov 2017 18:22:38 +0000 (12:22 -0600)]
Merge "dtls: Add support for ephemeral DTLS certificates."

3 years agostasis_channels.c: Remove a very silly RAII_VAR().
Richard Mudgett [Fri, 3 Nov 2017 22:43:18 +0000 (17:43 -0500)]
stasis_channels.c: Remove a very silly RAII_VAR().

Change-Id: I28b458b3c1a442c4ef0be7b4986a95ea4149e14f

3 years agoMerge "install_prereq: Checkout of libSRTP 2.x."
Joshua Colp [Mon, 6 Nov 2017 17:57:58 +0000 (11:57 -0600)]
Merge "install_prereq: Checkout of libSRTP 2.x."

3 years agostasis/app.c: Optimize stasis_app_get_debug_by_name()
Richard Mudgett [Fri, 3 Nov 2017 21:14:15 +0000 (16:14 -0500)]
stasis/app.c: Optimize stasis_app_get_debug_by_name()

* Eliminate RAII_VAR()
* Short circuit application name lookup if global debug enabled.

Change-Id: I5f78b7bd6ca7fd2c3b07cbbe036c6a93b4681123

3 years agoFix ast_(v)asprintf() malloc failure usage conditions.
Richard Mudgett [Thu, 2 Nov 2017 23:40:20 +0000 (18:40 -0500)]
Fix ast_(v)asprintf() malloc failure usage conditions.

When (v)asprintf() fails, the state of the allocated buffer is undefined.
The library had better not leave an allocated buffer as a result or no one
will know to free it.  The most likely way it can return failure is for an
allocation failure.  If the printf conversion fails then you actually have
a threading problem which is much worse because another thread modified
the parameter values.

* Made __ast_asprintf()/__ast_vasprintf() set the returned buffer to NULL
on failure.  That is much more useful than either an uninitialized pointer
or a pointer that has already been freed.  Many uses won't have to check
for failure to ensure that the buffer won't be double freed or prevent an
attempt to free an uninitialized pointer.

* stasis.c: Fixed memory leak in multi_object_blob_to_ami() allocated by

* ari/resource_bridges.c:ari_bridges_play_helper(): Remove assignment to
the wrong thing which is now not needed even if assigning to the right

Change-Id: Ib5252fb8850ecf0f78ed0ee2ca0796bda7e91c23

3 years agoMerge "configure: Add autoconf check for libopusfile."
Joshua Colp [Mon, 6 Nov 2017 16:38:18 +0000 (10:38 -0600)]
Merge "configure: Add autoconf check for libopusfile."

3 years agoMerge "Prevent unload of modules which implement an Optional API."
Joshua Colp [Mon, 6 Nov 2017 16:11:51 +0000 (10:11 -0600)]
Merge "Prevent unload of modules which implement an Optional API."

3 years agoMerge "Add missing menuselect dependencies."
Joshua Colp [Mon, 6 Nov 2017 15:26:18 +0000 (09:26 -0600)]
Merge "Add missing menuselect dependencies."

3 years agores_pjsip: Ignore empty TLS configuration
Sean Bright [Mon, 6 Nov 2017 14:05:56 +0000 (09:05 -0500)]
res_pjsip: Ignore empty TLS configuration

When using realtime, fields that are not explicitly set by an
administrator are still presented to sorcery as empty strings. Handle
this case explicitly.

In this particular case, if any of these fields are required for TLS
support, their existence should be validated in the 'apply' handler once
we have a complete transport definition.

ASTERISK-27032 #close
Reported by: seanchann.zhou

Change-Id: Ie3b5fb421977ccdb33e415d4ec52c3fd192601b7

3 years agoMerge "Stasis/ARI: Fix off-nominal path json memory leaks."
Joshua Colp [Mon, 6 Nov 2017 14:15:02 +0000 (08:15 -0600)]
Merge "Stasis/ARI: Fix off-nominal path json memory leaks."

3 years agoMerge "AOC: Fix AOC-S json memory leak."
Joshua Colp [Mon, 6 Nov 2017 13:51:36 +0000 (07:51 -0600)]
Merge "AOC: Fix AOC-S json memory leak."

3 years agoMerge "res_stasis_mailbox.c: Fix leak of mailbox container."
Joshua Colp [Mon, 6 Nov 2017 13:17:22 +0000 (07:17 -0600)]
Merge "res_stasis_mailbox.c: Fix leak of mailbox container."

3 years agodtls: Add support for ephemeral DTLS certificates.
Sean Bright [Fri, 29 Sep 2017 14:50:17 +0000 (14:50 +0000)]
dtls: Add support for ephemeral DTLS certificates.

This mimics the behavior of Chrome and Firefox and creates an ephemeral
X.509 certificate for each DTLS session.

Currently, the only supported key type is ECDSA because of its faster
generation time, but other key types can be added in the future as


Change-Id: I5122e5f4b83c6320cc17407a187fcf491daf30b4

3 years agoMerge "Build System: Fix build failure caused by recent CLI improvements."
Joshua Colp [Mon, 6 Nov 2017 12:31:28 +0000 (06:31 -0600)]
Merge "Build System: Fix build failure caused by recent CLI improvements."

3 years agoconfigure: Add autoconf check for libopusfile.
Corey Farrell [Mon, 6 Nov 2017 09:21:12 +0000 (04:21 -0500)]
configure: Add autoconf check for libopusfile.

This check is being added to make it easier for end-users of third party
open source Opus modules.  This was removed by ASTERISK-26426 but only
the module needed to be removed.

Change-Id: I62b9cd0c4fa8a77596ab0e042948a643a1152677

3 years agotcptls: Print notice when TLS is enabled but not configured.
Alexander Traud [Mon, 6 Nov 2017 09:18:24 +0000 (10:18 +0100)]
tcptls: Print notice when TLS is enabled but not configured.

Asterisk can be compiled without a SSL/TLS library, without the Development
Headers of OpenSSL. However, if TLS (SIP) or Secure-WebSockets (WebRTC) was
enabled in a configuration file, Asterisk did not notice the user. Asterisk
failed silently, only the corresponding TCP ports were not open.

Reported-by: mossley74

Change-Id: Ib8b7539a5b2af8154c22e5f7a40fc68f95d95b93

3 years agoinstall_prereq: Checkout of libSRTP 2.x.
Alexander Traud [Sat, 4 Nov 2017 11:05:36 +0000 (12:05 +0100)]
install_prereq: Checkout of libSRTP 2.x.

Since Asterisk 13.17, libSRTP 2.x is supported. Therefore, its latest version
is installed again via the script install_prereq.


Change-Id: I13125839a79052356469e41edacbebff0a937d39

3 years agoStasis/ARI: Fix off-nominal path json memory leaks.
Richard Mudgett [Wed, 1 Nov 2017 22:47:57 +0000 (17:47 -0500)]
Stasis/ARI: Fix off-nominal path json memory leaks.

Change-Id: Id569c624c426e3b22a99936473c730592d8b83fb

3 years agoAOC: Fix AOC-S json memory leak.
Richard Mudgett [Thu, 2 Nov 2017 16:38:23 +0000 (11:38 -0500)]
AOC: Fix AOC-S json memory leak.

Change-Id: I3a1d40a41a8a7d00fa4a187de6a343a79155d3ef

3 years agores_stasis_device_state.c: Optimize stasis_app_device_states_to_json()
Richard Mudgett [Wed, 1 Nov 2017 23:04:31 +0000 (18:04 -0500)]
res_stasis_device_state.c: Optimize stasis_app_device_states_to_json()

* Eliminate RAII_VAR()
* Replace looped alloca with a char[] since that is how it is used anyway.

Change-Id: Ia27e64a884afa0f50b9ffdb1cf23da6bfa51ffdf

3 years agores_stasis_mailbox.c: Fix leak of mailbox container.
Richard Mudgett [Wed, 1 Nov 2017 23:58:08 +0000 (18:58 -0500)]
res_stasis_mailbox.c: Fix leak of mailbox container.

Change-Id: I7d33c1635713047e7d1597c9d882f7dc006d94b4

3 years agoBuild System: Fix build failure caused by recent CLI improvements.
Corey Farrell [Fri, 3 Nov 2017 15:35:34 +0000 (11:35 -0400)]
Build System: Fix build failure caused by recent CLI improvements.

We use the editline library to help with filename completion in our CLI
interface.  Some systems failed to find the header when included from
loader.c.  This is fixed by setting the proper CFLAGS for the build of


Change-Id: Ib7fd496f1d7ed48141a2eadd5dd61cab2f2308be

3 years agoMerge "res_pjsip: Add to list of valid characters for from_user."
Joshua Colp [Fri, 3 Nov 2017 14:06:47 +0000 (09:06 -0500)]
Merge "res_pjsip: Add to list of valid characters for from_user."

3 years agoMerge "Modules: Additional improvements to CLI completion."
Joshua Colp [Fri, 3 Nov 2017 12:55:27 +0000 (07:55 -0500)]
Merge "Modules: Additional improvements to CLI completion."

3 years agoMerge "res/ari/resource_bridges.h: Update from 'make ari-stubs'."
Joshua Colp [Thu, 2 Nov 2017 19:08:41 +0000 (14:08 -0500)]
Merge "res/ari/resource_bridges.h: Update from 'make ari-stubs'."

3 years agores_pjsip: Add to list of valid characters for from_user.
Ben Ford [Wed, 1 Nov 2017 16:12:45 +0000 (11:12 -0500)]
res_pjsip: Add to list of valid characters for from_user.

Fixes a regression where some characters were unable to be used in
the from_user field of an endpoint. Additionally, the backtick was
removed from the list of valid characters, since it is not valid,
and it was replaced with a single quote, which is a valid character.


Change-Id: Id80c10a644508365c87b3182e99ea49da11b0281

3 years agoMerge "core: Don't attempt to write to a stream that does not exist."
Joshua Colp [Thu, 2 Nov 2017 16:09:41 +0000 (11:09 -0500)]
Merge "core: Don't attempt to write to a stream that does not exist."

3 years agocore: Don't attempt to write to a stream that does not exist.
Joshua Colp [Thu, 2 Nov 2017 10:34:46 +0000 (07:34 -0300)]
core: Don't attempt to write to a stream that does not exist.

When a frame is provided to ast_write ensure that a multistream
capable channel has a stream for it before attempting to give it
to the channel driver. In some cases (such as a deferred SDP
negotiation) the stream may not yet exist.


Change-Id: Icf84ca982a67cdd6e9a71851eb7eb1bd0e865276

3 years agoAdd missing menuselect dependencies.
Corey Farrell [Thu, 2 Nov 2017 06:57:52 +0000 (02:57 -0400)]
Add missing menuselect dependencies.

This adds menuselect dependencies for modules that use symbols of other


Change-Id: Ia2d2849f5b87a72af7324a82edc3f283eafb5385

3 years agores/ari/resource_bridges.h: Update from 'make ari-stubs'.
Corey Farrell [Thu, 2 Nov 2017 03:57:28 +0000 (23:57 -0400)]
res/ari/resource_bridges.h: Update from 'make ari-stubs'.

A comment was updated when I ran 'make ari-stubs'.

Change-Id: Ib5154ae3ad72aff53374c28ead540fe349c42175

3 years agoPrevent unload of modules which implement an Optional API.
Corey Farrell [Thu, 2 Nov 2017 00:46:11 +0000 (20:46 -0400)]
Prevent unload of modules which implement an Optional API.

Once an Optional API module is loaded it should stay loaded.  Unloading
an optional API module runs the risk of a crash if something else is
using it.  This patch causes all optional API providers to tell the
module loader not to unload except at shutdown.


Change-Id: Ia07786fe655681aec49cc8d3d96e06483b11f5e6

3 years agoModules: Additional improvements to CLI completion.
Corey Farrell [Mon, 30 Oct 2017 22:30:18 +0000 (18:30 -0400)]
Modules: Additional improvements to CLI completion.

Replace 'needsreload' argument with a 'type' argument to specify which
type of modules you want completion.  This provides more accurate CLI
completion for load and unload commands.

* 'module unload' now excludes modules that have active references or are
  not running.
* 'module load' now excludes modules that are already running.
* 'core set debug [atleast] <level> [module]' shows running modules only.


Change-Id: Iea3e00054461484196c46f688f02635cc886bad1

3 years agopjsip_message_filter: Only do interface lookup for wildcard addresses.
Sean Bright [Wed, 1 Nov 2017 18:58:32 +0000 (14:58 -0400)]
pjsip_message_filter: Only do interface lookup for wildcard addresses.

Change-Id: Ie083987e69dc43b6861671c218cacacc11b2072f

3 years agoMerge "features: Bridge application's BRIDGERESULT not appropriately set"
Joshua Colp [Wed, 1 Nov 2017 14:22:17 +0000 (09:22 -0500)]
Merge "features: Bridge application's BRIDGERESULT not appropriately set"

3 years agoMerge "res_ari_channels: Fix reference leak in channel_state_invalid."
Joshua Colp [Wed, 1 Nov 2017 12:42:08 +0000 (07:42 -0500)]
Merge "res_ari_channels: Fix reference leak in channel_state_invalid."

3 years agofeatures: Bridge application's BRIDGERESULT not appropriately set
Kevin Harwell [Tue, 31 Oct 2017 20:08:38 +0000 (15:08 -0500)]
features: Bridge application's BRIDGERESULT not appropriately set

The dialplan application "Bridge" was not setting the BRIDGERESULT to failure
when a failure did occur. Even worse if it did fail to join the bridge it would
still report success.

This patch now sets the BRIDGERESULT variable to an appropriate value for a
given condition state. Also, removed the value INCOMPATIBLE as a valid result
type since it is no longer used.

ASTERISK-27369 #close

Change-Id: I22588e7125a765edf35cff28c98ca143e9927554

3 years agoMerge "Build System: Fix --disable-xmldoc option."
Joshua Colp [Tue, 31 Oct 2017 20:14:53 +0000 (15:14 -0500)]
Merge "Build System: Fix --disable-xmldoc option."

3 years agores_ari_channels: Fix reference leak in channel_state_invalid.
Corey Farrell [Tue, 31 Oct 2017 18:18:45 +0000 (14:18 -0400)]
res_ari_channels: Fix reference leak in channel_state_invalid.

channel_state_invalid leaked a reference to the channel snapshot any
time it was aquired.

ASTERISK-27067 #close

Change-Id: I8c653f00416b39978513c5605c4be0f03b1df29a

3 years agoMerge "core / pjsip: Add support for grouping streams together."
Joshua Colp [Tue, 31 Oct 2017 18:27:40 +0000 (13:27 -0500)]
Merge "core / pjsip: Add support for grouping streams together."

3 years agoMerge "ast_coredumper: allow setting asterisk binary explicitly"
Joshua Colp [Tue, 31 Oct 2017 11:48:16 +0000 (06:48 -0500)]
Merge "ast_coredumper: allow setting asterisk binary explicitly"

3 years agoMerge "Modules: Fix issues with CLI completion."
Joshua Colp [Mon, 30 Oct 2017 22:18:59 +0000 (17:18 -0500)]
Merge "Modules: Fix issues with CLI completion."

3 years agocore / pjsip: Add support for grouping streams together.
Joshua Colp [Wed, 25 Oct 2017 22:31:33 +0000 (22:31 +0000)]
core / pjsip: Add support for grouping streams together.

In WebRTC streams (or media tracks in their world) can be grouped
together using the mslabel. This informs the browser that each
should be synchronized with each other.

This change extends the stream API so this information can
be stored with streams. The PJSIP support has been extended
to use the mslabel to determine grouped streams and store
this association on the streams. Finally when creating the
SDP the group information is used to cause each media stream
to use the same mslabel.


Change-Id: Id6299aa031efe46254edbdc7973c534d54d641ad

3 years agoMerge "alembic: Add bundle column in ps_endpoints table"
Joshua Colp [Mon, 30 Oct 2017 16:56:56 +0000 (11:56 -0500)]
Merge "alembic: Add bundle column in ps_endpoints table"

3 years agoMerge "app_agent_spool: Fix typo in dtmf features usage desctiption"
Joshua Colp [Mon, 30 Oct 2017 16:08:52 +0000 (11:08 -0500)]
Merge "app_agent_spool: Fix typo in dtmf features usage desctiption"

3 years agoMerge "ast_coredumper: Add gzipping of binaries and display of signal info"
Joshua Colp [Mon, 30 Oct 2017 15:53:42 +0000 (10:53 -0500)]
Merge "ast_coredumper:  Add gzipping of binaries and display of signal info"

3 years agoast_coredumper: allow setting asterisk binary explicitly
Tzafrir Cohen [Mon, 30 Oct 2017 14:20:18 +0000 (16:20 +0200)]
ast_coredumper: allow setting asterisk binary explicitly

Adds an extra option, --asterisk-bin=<path> to ast_coredumper. If
provided, the binary given to gdb will be the parameter, rather than
asterisk from the PATH.

ASTERISK-27380 #close

Change-Id: I25f5b91eb75059b0fb2f142e468c26b283b0a9f3

3 years agoalembic: Add bundle column in ps_endpoints table
Florian Floimair [Wed, 25 Oct 2017 06:10:29 +0000 (08:10 +0200)]
alembic: Add bundle column in ps_endpoints table

The ps_endpoints table was missing the bundle column
introduced with the bundle feature in
commit 065c3005ad92.

ASTERISK-27374 #close

Change-Id: Ic900f4f2c20f64b99ea898d50f5c0a7117472d46

3 years agoModules: Fix issues with CLI completion.
Corey Farrell [Mon, 30 Oct 2017 05:32:32 +0000 (01:32 -0400)]
Modules: Fix issues with CLI completion.

* Stop using ast_module_helper to check if a module is loaded, use
  ast_module_check instead (app_confbridge and app_meetme).
* Stop ast_module_helper from listing reload classes when needsreload
  was not requested.


Change-Id: Iaed8c1e4fcbeb242921dbac7929a0fe75ff4b239

3 years agoapp_agent_spool: Fix typo in dtmf features usage desctiption
Igor Goncharovskiy [Sun, 29 Oct 2017 00:18:21 +0000 (06:18 +0600)]
app_agent_spool: Fix typo in dtmf features usage desctiption

Fix typo, that specify usage wrong option 'dtmf-features' for CHANNEL() function
instead of correct 'dtmf_features'

ASTERISK-27377 #close

Change-Id: I15ecc829c1035b359584673e12cdb5c9291ac930

3 years agores_pjsip_pubsub: Resolve potential crash in allocate_subscription.
Corey Farrell [Fri, 27 Oct 2017 18:41:15 +0000 (14:41 -0400)]
res_pjsip_pubsub: Resolve potential crash in allocate_subscription.

When allocate_subscription fails to initialize fields of the new sub it
calls destroy_subscription.

Change-Id: I5b79c915ec216dc00c13c1e4172137864a4bec85

3 years agoMerge "codec.c: Defensively check the returned samples."
Joshua Colp [Fri, 27 Oct 2017 14:19:11 +0000 (09:19 -0500)]
Merge "codec.c: Defensively check the returned samples."