asterisk/asterisk.git
11 years agoRegenerate configure script to include check for portaudio.
Russell Bryant [Mon, 31 Dec 2007 15:21:15 +0000 (15:21 +0000)]
Regenerate configure script to include check for portaudio.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95384 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd configure script checking for portaudio.
Russell Bryant [Mon, 31 Dec 2007 15:20:30 +0000 (15:20 +0000)]
Add configure script checking for portaudio.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95383 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMove grabbers definitions to a separate file, vgrabbers.c, so it is easier
Luigi Rizzo [Sat, 29 Dec 2007 02:02:03 +0000 (02:02 +0000)]
Move grabbers definitions to a separate file, vgrabbers.c, so it is easier
to add more entries. This required moving struct grab_desc to the common
header, and adding an entry in the Makefile.

On passing, cleanup some comments and file headers (some are still missing).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95313 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agovirtualize the interface for video grabbers, which should
Luigi Rizzo [Sat, 29 Dec 2007 01:10:14 +0000 (01:10 +0000)]
virtualize the interface for video grabbers, which should
make it easier to add support for more grabbers (V4L2,
firewire, and so on).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95288 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd a few entries up to 1408x1152 in the table of known video resolutions.
Luigi Rizzo [Fri, 28 Dec 2007 23:15:11 +0000 (23:15 +0000)]
Add a few entries up to 1408x1152 in the table of known video resolutions.
This makes it very convenient to enlarge images using the right-click
on the video window.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95264 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agochange the interface of video encapsulation routines, they only
Luigi Rizzo [Fri, 28 Dec 2007 23:04:04 +0000 (23:04 +0000)]
change the interface of video encapsulation routines, they only
need the buffer and mtu as input.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95263 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agovarious rearrangements and renaming of console_video stuff
Luigi Rizzo [Fri, 28 Dec 2007 22:37:40 +0000 (22:37 +0000)]
various rearrangements and renaming of console_video stuff

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95262 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoThe diff for this change looks really bad, but all I did here was decrease the indent...
Mark Michelson [Fri, 28 Dec 2007 18:39:29 +0000 (18:39 +0000)]
The diff for this change looks really bad, but all I did here was decrease the indentation of most
of the queue_exec function by reversing the logic of an if statement. This change makes the function
comply better with the coding guidelines. Since this change is purely a cosmetic change to the code, I am
only committing the change to trunk.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95233 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 95191 via svnmerge from
Russell Bryant [Fri, 28 Dec 2007 18:26:26 +0000 (18:26 +0000)]
Merged revisions 95191 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r95191 | russell | 2007-12-28 12:24:59 -0600 (Fri, 28 Dec 2007) | 6 lines

Remove duplicate increment of the header count in the add_header() function.

(closes issue #11648)
Reported by: makoto
Patch provided by sergee, committed patch by me, inspired by comments from putnopvut

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95192 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoSome changes to app_amd.
Mark Michelson [Fri, 28 Dec 2007 16:12:06 +0000 (16:12 +0000)]
Some changes to app_amd.

The channel name is printed in verbose messages
maximumWordLength option added.
Duration of words that do not meet the minimum word duration will be logged
The duration of pre-greeting silence will be logged
Only consider us in the greeting if we actually detected a valid word duration.

(closes issue #11650, reported and patched by davevg)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95167 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agofix a small bug in printing out geometries - wrong input.
Luigi Rizzo [Fri, 28 Dec 2007 08:57:01 +0000 (08:57 +0000)]
fix a small bug in printing out geometries - wrong input.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95139 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 95095 via svnmerge from
Mark Michelson [Fri, 28 Dec 2007 00:17:41 +0000 (00:17 +0000)]
Merged revisions 95095 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r95095 | mmichelson | 2007-12-27 18:16:15 -0600 (Thu, 27 Dec 2007) | 8 lines

I found a bug while browsing the queue code and managed to reproduce it in a small setup.

If a queue uses the ringall strategy, it was possible through unfortunate coincidence for a single member at a given penalty level to
make app_queue think that all members at that penalty level were unavailable and cause the members at the
next penalty level to be rung. With this patch, we will only move to the next penalty level if ALL the members
at a given penalty level are unreachable.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95096 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoremove more unnecessary casts for NULL.
Luigi Rizzo [Thu, 27 Dec 2007 23:32:18 +0000 (23:32 +0000)]
remove more unnecessary casts for NULL.
main/say.c is a big offender in this respect.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95073 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix -s socket option, and document it as well.
Jason Parker [Thu, 27 Dec 2007 23:28:01 +0000 (23:28 +0000)]
Fix -s socket option, and document it as well.

Closes issue #11645, patch by Laureano.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95070 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoNULL does not need to be cast to (char *)
Luigi Rizzo [Thu, 27 Dec 2007 23:13:15 +0000 (23:13 +0000)]
NULL does not need to be cast to (char *)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95069 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoremove useless casts
Luigi Rizzo [Thu, 27 Dec 2007 23:00:55 +0000 (23:00 +0000)]
remove useless casts

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95068 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 95024 via svnmerge from
Russell Bryant [Thu, 27 Dec 2007 21:41:22 +0000 (21:41 +0000)]
Merged revisions 95024 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r95024 | russell | 2007-12-27 15:40:02 -0600 (Thu, 27 Dec 2007) | 9 lines

Don't report a syntax error when an empty string is passed to ast_get_group.
Just return 0.

(closes issue #11540)
Reported by: tzafrir
Patches:
      group_empty.diff uploaded by tzafrir (license 46)
   -- slightly changed by me

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95025 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94977 via svnmerge from
Mark Michelson [Thu, 27 Dec 2007 20:11:20 +0000 (20:11 +0000)]
Merged revisions 94977 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94977 | mmichelson | 2007-12-27 14:09:06 -0600 (Thu, 27 Dec 2007) | 3 lines

Fixing a typo in a comment.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94978 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94924 via svnmerge from
Joshua Colp [Thu, 27 Dec 2007 17:34:00 +0000 (17:34 +0000)]
Merged revisions 94924 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94924 | file | 2007-12-27 13:32:15 -0400 (Thu, 27 Dec 2007) | 6 lines

Include types.h in chan_h323 as without it it can not be compiled on some operating systems like FreeBSD to name one.
(closes issue #11585)
Reported by: sobomax
Patches:
      chan_h323.c.diff uploaded by sobomax (license 359)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94934 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94905 via svnmerge from
Joshua Colp [Thu, 27 Dec 2007 17:28:52 +0000 (17:28 +0000)]
Merged revisions 94905 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94905 | file | 2007-12-27 13:27:11 -0400 (Thu, 27 Dec 2007) | 4 lines

Use ast_strlen_zero to see if our_contact is set or not on the dialog. It is possible for it to be a pointer to NULL.
(closes issue #11557)
Reported by: FuriousGeorge

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94908 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agomore localization of gui stuff
Luigi Rizzo [Thu, 27 Dec 2007 17:26:16 +0000 (17:26 +0000)]
more localization of gui stuff

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94904 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdding documentation for new manager actions and events in app_queue
Mark Michelson [Thu, 27 Dec 2007 17:18:39 +0000 (17:18 +0000)]
Adding documentation for new manager actions and events in app_queue

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94903 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoclarify the type of video support in chan_oss
Luigi Rizzo [Thu, 27 Dec 2007 16:51:08 +0000 (16:51 +0000)]
clarify the type of video support in chan_oss

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94902 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoI went looking for where we downloaded the g722 implementation and came across
Russell Bryant [Thu, 27 Dec 2007 16:11:41 +0000 (16:11 +0000)]
I went looking for where we downloaded the g722 implementation and came across
these two links.  So, I'm adding them so they are available for reference later.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94877 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 94831 via svnmerge
Russell Bryant [Thu, 27 Dec 2007 15:17:31 +0000 (15:17 +0000)]
Blocked revisions 94831 via svnmerge

........
r94831 | russell | 2007-12-27 09:16:56 -0600 (Thu, 27 Dec 2007) | 5 lines

Now that the contexts lock is a read/write lock, it should not be locked here
in ast_hint_state_changed().  This makes it get locked recursively which now
causes a deadlock.
(closes issue #11080, thanks to callguy for the access to a deadlocked machine)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94832 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94828-94829 via svnmerge from
Russell Bryant [Thu, 27 Dec 2007 14:52:07 +0000 (14:52 +0000)]
Merged revisions 94828-94829 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94828 | russell | 2007-12-27 08:33:21 -0600 (Thu, 27 Dec 2007) | 9 lines

Change ast_translator_best_choice() to only pay attention to audio formats.
This fixes a problem where Asterisk claims that a translation path can not be
found for channels involving video.

(closes issue #11638)
Reported by: cwhuang
Tested by: cwhuang
Patch suggested by cwhuang, with some additional changes by me.

........
r94829 | russell | 2007-12-27 08:44:29 -0600 (Thu, 27 Dec 2007) | 2 lines

Use the constant that I really meant to use here ...

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94830 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoThis function checks more than just contexts...
Olle Johansson [Thu, 27 Dec 2007 09:13:07 +0000 (09:13 +0000)]
This function checks more than just contexts...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94827 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years ago- Add Copyright
Olle Johansson [Thu, 27 Dec 2007 09:08:23 +0000 (09:08 +0000)]
- Add Copyright

- Doxygen fixes

Note:
- This application needs better documentation and a RESULT code in the
  dialplan.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94826 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94824 via svnmerge from
Kevin P. Fleming [Thu, 27 Dec 2007 01:03:16 +0000 (01:03 +0000)]
Merged revisions 94824 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94824 | kpfleming | 2007-12-26 18:01:47 -0700 (Wed, 26 Dec 2007) | 2 lines

make this comment explain the situation in an even more explicit fashion

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94825 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agomore steps to decouple the gui from the rest of the code.
Luigi Rizzo [Thu, 27 Dec 2007 00:48:38 +0000 (00:48 +0000)]
more steps to decouple the gui from the rest of the code.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94823 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoEnable building the code even if SDL is not present (similarly,
Luigi Rizzo [Thu, 27 Dec 2007 00:21:02 +0000 (00:21 +0000)]
Enable building the code even if SDL is not present (similarly,
SDL is also detected at runtime).
Now we should be able to stream video even without a rendering device
(useful for remote monitoring).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94822 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agomore localizations around sdl_setup
Luigi Rizzo [Wed, 26 Dec 2007 23:40:23 +0000 (23:40 +0000)]
more localizations around sdl_setup

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94821 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agouse fread instead of mmap to read in the comment area from the keypad.
Luigi Rizzo [Wed, 26 Dec 2007 23:00:29 +0000 (23:00 +0000)]
use fread instead of mmap to read in the comment area from the keypad.
fread is simpler and more portable, and there is no performance gain
in using mmap.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94820 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoupdate the region description with an empty line at the beginning.
Luigi Rizzo [Wed, 26 Dec 2007 22:52:43 +0000 (22:52 +0000)]
update the region description with an empty line at the beginning.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94819 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAllow more spans than 32. Also, rearrange compiler flags so the most often
Tilghman Lesher [Wed, 26 Dec 2007 22:38:02 +0000 (22:38 +0000)]
Allow more spans than 32.  Also, rearrange compiler flags so the most often
used flags appear closer to the top.
Reported by: tzafrir
Patch by: tzafrir,tilghman
(Closes issue #11528)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94818 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoanother bunch of gui localizations
Luigi Rizzo [Wed, 26 Dec 2007 22:29:45 +0000 (22:29 +0000)]
another bunch of gui localizations

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94817 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMake 'else' argument to ExecIf optional. Clean up the description and usage text...
Jason Parker [Wed, 26 Dec 2007 22:14:21 +0000 (22:14 +0000)]
Make 'else' argument to ExecIf optional.  Clean up the description and usage text a bit.

Closes issue #11564, patch by pnlarsson (with some extra cleanup by me).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94814 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agomore localization of sdl stuff
Luigi Rizzo [Wed, 26 Dec 2007 22:10:32 +0000 (22:10 +0000)]
more localization of sdl stuff

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94813 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agomove more gui stuff into console_gui.c
Luigi Rizzo [Wed, 26 Dec 2007 21:10:42 +0000 (21:10 +0000)]
move more gui stuff into console_gui.c

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94810 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94808 via svnmerge from
Tilghman Lesher [Wed, 26 Dec 2007 20:49:35 +0000 (20:49 +0000)]
Merged revisions 94808 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94808 | tilghman | 2007-12-26 14:43:38 -0600 (Wed, 26 Dec 2007) | 6 lines

Workaround for what is probably a glibc bug (but we'll see this crop up again
and again, if we don't add the workaround).
Reported by: rolek
Patch by: tilghman
(Closes issue #11601, closes issue #11426)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94809 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUse defined return values in load_module in more places.
Jason Parker [Wed, 26 Dec 2007 20:02:27 +0000 (20:02 +0000)]
Use defined return values in load_module in more places.

(closes issue #11096)
Patches:
      pbx_config.c.patch uploaded by moy (license 222)
      pbx_dundi.c.patch uploaded by moy (license 222)
      pbx_gtkconsole.c.patch uploaded by moy (license 222)
      pbx_loopback.c.patch uploaded by moy (license 222)
      pbx_realtime.c.patch uploaded by moy (license 222)
      pbx_spool.c.patch uploaded by moy (license 222)
      app_adsiprog.c.patch uploaded by moy (license 222)
      app_alarmreceiver.c.patch uploaded by moy (license 222)
      app_amd.c.patch uploaded by moy (license 222)
      app_authenticate.c.patch uploaded by moy (license 222)
      app_cdr.c.patch uploaded by moy (license 222)
      app_zapateller.c.patch uploaded by moy (license 222)
      app_zapbarge.c.patch uploaded by moy (license 222)
      app_zapras.c.patch uploaded by moy (license 222)
      app_zapscan.c.patch uploaded by moy (license 222)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94806 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agomore preparation for untangling of the various console_video stuff
Luigi Rizzo [Wed, 26 Dec 2007 20:01:16 +0000 (20:01 +0000)]
more preparation for untangling of the various console_video stuff

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94805 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94801 via svnmerge from
Russell Bryant [Wed, 26 Dec 2007 19:09:17 +0000 (19:09 +0000)]
Merged revisions 94801 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94801 | russell | 2007-12-26 13:04:31 -0600 (Wed, 26 Dec 2007) | 4 lines

Just in case the AST_FLAG_END_DTMF_ONLY flag was already set before starting
autoservice, remember it and ensure that the channel has the same setting when
autoservice gets stopped.  (pointed out by d1mas, patched up by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94802 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd a new dialplan function, DIALPLAN_EXISTS(), which allows you to check for
Russell Bryant [Wed, 26 Dec 2007 18:54:21 +0000 (18:54 +0000)]
Add a new dialplan function, DIALPLAN_EXISTS(), which allows you to check for
the existence of a dialplan target.

(closes issue #11579)
Reported by: irroot
Patches:
      func_dialplan2.c uploaded by irroot (license 52)
  -- Additional changes by me.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94799 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94797 via svnmerge from
Russell Bryant [Wed, 26 Dec 2007 18:47:52 +0000 (18:47 +0000)]
Merged revisions 94797 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94797 | russell | 2007-12-26 12:46:39 -0600 (Wed, 26 Dec 2007) | 4 lines

When a channel is in autoservice, mark a flag on the channel that says that
we only care about the END of a digit.  That way, no magic digit emulation stuff
will happen when all we're doing is queueing up END frames.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94798 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoLeave a note for a minor bug that was pointed out by d1mas
Russell Bryant [Wed, 26 Dec 2007 18:19:46 +0000 (18:19 +0000)]
Leave a note for a minor bug that was pointed out by d1mas

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94796 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoConvert raw bits for callprogress bitfield to use constants, for greater code clarity
Tilghman Lesher [Wed, 26 Dec 2007 18:05:28 +0000 (18:05 +0000)]
Convert raw bits for callprogress bitfield to use constants, for greater code clarity
Reported by: dimas
Patch by: dimas
(Closes issue #11280)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94795 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94793 via svnmerge from
Russell Bryant [Wed, 26 Dec 2007 17:26:04 +0000 (17:26 +0000)]
Merged revisions 94793 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94793 | russell | 2007-12-26 11:24:17 -0600 (Wed, 26 Dec 2007) | 3 lines

Don't try to send a parked call back to itself.
(closes issue #11622, reported by djrodman, patched by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94794 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94789 via svnmerge from
Russell Bryant [Wed, 26 Dec 2007 17:07:55 +0000 (17:07 +0000)]
Merged revisions 94789 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94789 | russell | 2007-12-26 11:00:03 -0600 (Wed, 26 Dec 2007) | 5 lines

List include/asterisk/version.h as a .PHONY target because we want the commands
listed for this target to be executed regardless of whether the file exists or
not.  This fixes having the version not up to date when running from svn.
(closes issue #11619, reported by plack, fixed by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94792 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94790 via svnmerge from
Russell Bryant [Wed, 26 Dec 2007 17:07:12 +0000 (17:07 +0000)]
Merged revisions 94790 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94790 | russell | 2007-12-26 11:06:26 -0600 (Wed, 26 Dec 2007) | 5 lines

Don't store DTMF BEGIN frames while a channel is in autoservice.  It's just
going to make ast_read() do a lot of extra work when the channel comes back
out of autoservice.
(closes issue #11628, patched by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94791 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix a bug in peer handling that caused multiple instances of a peer to end up
Russell Bryant [Wed, 26 Dec 2007 16:51:16 +0000 (16:51 +0000)]
Fix a bug in peer handling that caused multiple instances of a peer to end up
in the peers container after a reload.  Somehow, this bug doesn't exist in 1.4 ...
(closes issue #11626)
(reported by pnlarsson, additional info from mvanbaak, fixed by me)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94788 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoupdate svn:ignore for astcanary
Russell Bryant [Wed, 26 Dec 2007 16:31:43 +0000 (16:31 +0000)]
update svn:ignore for astcanary

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94787 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdding support for storing the queue log entries in a realtime backend.
Mark Michelson [Wed, 26 Dec 2007 15:58:17 +0000 (15:58 +0000)]
Adding support for storing the queue log entries in a realtime backend.

(closes issue #11625, reported and patched by sergee)

Thank you very much to sergee for adding this new feature!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94782 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoSplit console_video.c so that video codecs and gui functions
Luigi Rizzo [Wed, 26 Dec 2007 10:14:11 +0000 (10:14 +0000)]
Split console_video.c so that video codecs and gui functions
are in separate files (still #include'd because of tangling in the data
structures, but this is going to be cleaned up).

The video grabbing functions still need to be moved to a separate file.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94774 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd pickup by channel
Tilghman Lesher [Tue, 25 Dec 2007 04:10:57 +0000 (04:10 +0000)]
Add pickup by channel
(Closes issue #11161)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94773 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoChange the abbreviated TON from 'A' to 'V', since 'A' is a legitimate DTMF
Tilghman Lesher [Tue, 25 Dec 2007 03:34:09 +0000 (03:34 +0000)]
Change the abbreviated TON from 'A' to 'V', since 'A' is a legitimate DTMF
character.  Also, fix the documentation to match the code.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94772 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd channel thread ID to the information passed to AGI.
Tilghman Lesher [Tue, 25 Dec 2007 02:57:58 +0000 (02:57 +0000)]
Add channel thread ID to the information passed to AGI.
Reported by: dror99
Patch by: tilghman
(Closes issue #11162)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94771 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 94769 via svnmerge
Joshua Colp [Tue, 25 Dec 2007 02:28:01 +0000 (02:28 +0000)]
Blocked revisions 94769 via svnmerge

........
r94769 | file | 2007-12-24 22:27:08 -0400 (Mon, 24 Dec 2007) | 2 lines

file says... build on the builders.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94770 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94767 via svnmerge from
Tilghman Lesher [Mon, 24 Dec 2007 19:43:36 +0000 (19:43 +0000)]
Merged revisions 94767 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94767 | tilghman | 2007-12-24 13:36:59 -0600 (Mon, 24 Dec 2007) | 5 lines

Race: we need to wait to queue a NewChannel event until after the channel is
inserted into the channel list.  The reason is because some manager users
immediately queue requests from the channel when they see that event and are
confused when Asterisk reports no such channel. (Closes issue #11632)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94768 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 94765 via svnmerge
Tilghman Lesher [Mon, 24 Dec 2007 16:26:17 +0000 (16:26 +0000)]
Blocked revisions 94765 via svnmerge

........
r94765 | tilghman | 2007-12-24 10:17:01 -0600 (Mon, 24 Dec 2007) | 5 lines

More deadlock avoidance code (this time between sip_monitor and sip_hangup)
Reported by: apsaras
Patch by: tilghman
(Closes issue #11413)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94766 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94763 via svnmerge from
Tilghman Lesher [Mon, 24 Dec 2007 15:45:01 +0000 (15:45 +0000)]
Merged revisions 94763 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94763 | tilghman | 2007-12-24 09:39:56 -0600 (Mon, 24 Dec 2007) | 5 lines

Another bit of bad logic in realtime_peer
Reported by: dimas
Patch by: dimas
(Closes issue #11631)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94764 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agosupport sdl_videodriver to send output to x11/aalib/console
Luigi Rizzo [Sun, 23 Dec 2007 14:51:00 +0000 (14:51 +0000)]
support sdl_videodriver to send output to x11/aalib/console

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94741 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agomove reading info from the keypad to a separate function.
Luigi Rizzo [Sun, 23 Dec 2007 14:34:17 +0000 (14:34 +0000)]
move reading info from the keypad to a separate function.
Remove an unused keypad field and some debugging messages.
Adjust formatting on config file parsing

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94736 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agomake sure the minimum surface depth is 16bpp so we can create YUVoverlays.
Luigi Rizzo [Sun, 23 Dec 2007 12:36:32 +0000 (12:36 +0000)]
make sure the minimum surface depth is 16bpp so we can create YUVoverlays.
With this change we can do

setenv SDL_VIDEODRIVER aalib

and output to an ascii window (which is still in an X11 window).
If you also do

unsetenv DISPLAY

then the output goes into the main asterisk window, unfortunately
it interferes with the normal output so you don't see much.

In any case, i don't think we are very far away from having a working
xterm videophone!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94714 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoavoid rebuilding dependent files if the generated busy.h and ringtone.h
Luigi Rizzo [Sun, 23 Dec 2007 12:29:48 +0000 (12:29 +0000)]
avoid rebuilding dependent files if the generated busy.h and ringtone.h
do not change.

Ths masks (but does not solve) a but that i am seeing in doing a
'gmake install' without donig a 'gmake all' first.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94713 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94660 via svnmerge from
Tilghman Lesher [Sun, 23 Dec 2007 01:38:46 +0000 (01:38 +0000)]
Merged revisions 94660 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94660 | tilghman | 2007-12-22 19:21:03 -0600 (Sat, 22 Dec 2007) | 2 lines

Argh... I suppose third time's the charm.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94662 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoChange the name of config file entries for keypad regions
Luigi Rizzo [Sat, 22 Dec 2007 22:44:31 +0000 (22:44 +0000)]
Change the name of config file entries for keypad regions
from 'keypad_entry' to 'region'. Fix the example file accordingly.
Also make some fixes in the code do reset entries on reload of the keypad.

The recently committed kpad2.jpg has the correct names.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94638 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoadd a sample keypad (with annotations) for console video
Luigi Rizzo [Sat, 22 Dec 2007 22:39:55 +0000 (22:39 +0000)]
add a sample keypad (with annotations) for console video

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94637 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBuild console_video support by linking in, as opposed to including,
Luigi Rizzo [Sat, 22 Dec 2007 18:28:40 +0000 (18:28 +0000)]
Build console_video support by linking in, as opposed to including,
console_video.c

This will ease the task of splitting console_video.c into its components
(V4L and X11 grabbers, various video codecs and packetizers, SDL),
as well as ease future extensions (e.g. additional video sources,
codecs and rendering engines).

For the time being nothing changes for users: video support is off by
default, and requires -DHAVE_VIDEO_CONSOLE on the command line to be included
(if SDL and FFMPEG are available).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94615 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoSomething I've been itching to do for a while now. A minor optimization in app_voicemail.
Mark Michelson [Fri, 21 Dec 2007 21:19:19 +0000 (21:19 +0000)]
Something I've been itching to do for a while now. A minor optimization in app_voicemail.
Since the dtable in base_encode always gets populated with the same values every time and never
changes, make it static and const and only initialize it once. Also, there's no reason to
define BASEMAXINLINE twice, so remove the redundant #define.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94593 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoWe should only clear this value if we have to
Matthew Fredrickson [Fri, 21 Dec 2007 20:50:26 +0000 (20:50 +0000)]
We should only clear this value if we have to

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94551 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoCommit non TCP transport part of #11506. Includes numerous additional parameters...
Matthew Fredrickson [Fri, 21 Dec 2007 20:48:15 +0000 (20:48 +0000)]
Commit non TCP transport part of #11506.  Includes numerous additional parameters, as well as RLT support for DMS type switches

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94549 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoStore dates using local time instead of UTC
Mark Michelson [Fri, 21 Dec 2007 20:38:18 +0000 (20:38 +0000)]
Store dates using local time instead of UTC

(closes issue #11610, reported and patched by rbraun_performatique)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94548 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix a memory leak when reloading queue rules.
Mark Michelson [Fri, 21 Dec 2007 20:30:05 +0000 (20:30 +0000)]
Fix a memory leak when reloading queue rules.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94547 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoThe one documentation source I forgot to update after the merge of the queue-penalty...
Mark Michelson [Fri, 21 Dec 2007 20:28:04 +0000 (20:28 +0000)]
The one documentation source I forgot to update after the merge of the queue-penalty branch
was the CHANGES file. No longer!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94546 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoLots of coding guidelines cleanup.
Mark Michelson [Fri, 21 Dec 2007 20:24:24 +0000 (20:24 +0000)]
Lots of coding guidelines cleanup.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94545 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 94543 via svnmerge
Mark Michelson [Fri, 21 Dec 2007 20:22:52 +0000 (20:22 +0000)]
Blocked revisions 94543 via svnmerge

........
r94543 | mmichelson | 2007-12-21 14:21:59 -0600 (Fri, 21 Dec 2007) | 3 lines

Bunch of coding guidelines cleanup

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94544 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94540 via svnmerge from
Mark Michelson [Fri, 21 Dec 2007 20:18:26 +0000 (20:18 +0000)]
Merged revisions 94540 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94540 | mmichelson | 2007-12-21 14:11:34 -0600 (Fri, 21 Dec 2007) | 8 lines

Better quota support for using IMAP storage voicemail

(closes issue #11415, reported by jaroth)
(closes issue #11152, reported by selsky)

Patch provided by jaroth

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94542 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agocodecs.conf really shouldn't be mandatory.. it never had been before, so let's go...
Jason Parker [Fri, 21 Dec 2007 20:12:50 +0000 (20:12 +0000)]
codecs.conf really shouldn't be mandatory..  it never had been before, so let's go back to being optional.
A big "thank you" to pnlarsson on IRC for allowing me access to his system to debug this.

Closes issue #11584.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94541 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94538 via svnmerge from
Mark Michelson [Fri, 21 Dec 2007 20:01:10 +0000 (20:01 +0000)]
Merged revisions 94538 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94538 | mmichelson | 2007-12-21 13:59:45 -0600 (Fri, 21 Dec 2007) | 5 lines

The mail_copy c-client function does not expect a full imap mailbox string, just the name of the mailbox.

(closes issue #11419, reported and patched by jaroth, with additional patchwork from me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94539 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAST_LIST_REMOVE_CURRENT only takes one argument in trunk
Mark Michelson [Fri, 21 Dec 2007 17:40:44 +0000 (17:40 +0000)]
AST_LIST_REMOVE_CURRENT only takes one argument in trunk

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94516 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94468 via svnmerge from
Mark Michelson [Fri, 21 Dec 2007 16:52:04 +0000 (16:52 +0000)]
Merged revisions 94468 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94468 | mmichelson | 2007-12-21 10:49:35 -0600 (Fri, 21 Dec 2007) | 6 lines

Since we are freeing list elements within a list traversal, we need to use the safe
traversal and remove the item from the list before freeing it.

(closes issue 11612, reported by dtyoo)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94477 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 94466 via svnmerge
Russell Bryant [Fri, 21 Dec 2007 16:42:52 +0000 (16:42 +0000)]
Blocked revisions 94466 via svnmerge

........
r94466 | russell | 2007-12-21 10:37:47 -0600 (Fri, 21 Dec 2007) | 6 lines

Convert the contexts lock to a read/write lock to resolve a deadlock.  This
has a nice side benefit of improving performance.  :)

(closes issue #11609)
(closes issue #11080)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94467 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94464 via svnmerge from
Mark Michelson [Fri, 21 Dec 2007 16:12:14 +0000 (16:12 +0000)]
Merged revisions 94464 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94464 | mmichelson | 2007-12-21 10:11:44 -0600 (Fri, 21 Dec 2007) | 3 lines

Removing a debug message I accidentally just committed

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94465 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94420 via svnmerge from
Mark Michelson [Fri, 21 Dec 2007 16:10:21 +0000 (16:10 +0000)]
Merged revisions 94420 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94420 | mmichelson | 2007-12-21 09:45:14 -0600 (Fri, 21 Dec 2007) | 5 lines

Fixing Portuguese syntax for saying dates and times. Also some coding guidelines cleanup.

(closes issue #11599, reported and patched by caio1982, coding guidelines cleanup by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94463 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94418 via svnmerge from
Tilghman Lesher [Fri, 21 Dec 2007 15:14:52 +0000 (15:14 +0000)]
Merged revisions 94418 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94418 | tilghman | 2007-12-21 09:07:42 -0600 (Fri, 21 Dec 2007) | 2 lines

Fix for restart-as-user problem reported via the -dev list

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94419 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMoved the update of the queue_ent's rule list to just before we try to call
Mark Michelson [Fri, 21 Dec 2007 01:14:32 +0000 (01:14 +0000)]
Moved the update of the queue_ent's rule list to just before we try to call
queue members. This allows for the change in penalty levels to be executed at
the most logical time frame.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94396 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerging the queue-penalty branch. In short, this allows one to dynamically adjust
Mark Michelson [Fri, 21 Dec 2007 00:44:17 +0000 (00:44 +0000)]
Merging the queue-penalty branch. In short, this allows one to dynamically adjust
the QUEUE_MAX_PENALTY and the newly introduced QUEUE_MIN_PENALTY during a call depending
on the amount of time passed. The purpose is to allow the call to open up to more (or maybe
just different) members without the caller's losing his place in the queue. See
configs/queuerules.conf.sample for an example of how to set up queue rules and configs/queues.conf.sample
for how to associate a rule with a queue.

Along with the functional changes, new CLI and manager commands exist to show the rules defined and
there is an additional CLI command to reload the queue rules.

Future enhancements that may be made: support for realtime queue rules and support for dynamically adding
a rule through the manager or CLI. Also a manager command to reload the queue rules (I'll probably write
this myself very soon).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94370 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoThe changes to header inclusion in trunk broke compilation of app_voicemail when...
Mark Michelson [Thu, 20 Dec 2007 23:43:24 +0000 (23:43 +0000)]
The changes to header inclusion in trunk broke compilation of app_voicemail when using
IMAP storage. The reason is that c-client has its own definitions for LOG_WARNING
and LOG_DEBUG, so we need to be sure to include asterisk's definitions last so that
we use the proper values in app_voicemail.

(closes issue #11437, reported by blitzrage, patch suggested by blitzrage)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94345 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd a bit more to the description of the "mwimonitor" option.
Russell Bryant [Thu, 20 Dec 2007 22:39:39 +0000 (22:39 +0000)]
Add a bit more to the description of the "mwimonitor" option.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94320 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agocloses issue #11287; thanks to snuffy for this fix, which will surely make all solari...
Steve Murphy [Thu, 20 Dec 2007 22:28:35 +0000 (22:28 +0000)]
closes issue #11287; thanks to snuffy for this fix, which will surely make all solaris owners shout praises to his name.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94319 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94256 via svnmerge from
Russell Bryant [Thu, 20 Dec 2007 20:25:05 +0000 (20:25 +0000)]
Merged revisions 94256 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r94256 | russell | 2007-12-20 14:22:22 -0600 (Thu, 20 Dec 2007) | 13 lines

Merged revisions 94255 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r94255 | russell | 2007-12-20 14:21:41 -0600 (Thu, 20 Dec 2007) | 5 lines

Fix another potential seg fault ...

(closes issue #11606)
Reported by: dimas

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94257 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94251 via svnmerge from
Russell Bryant [Thu, 20 Dec 2007 20:16:21 +0000 (20:16 +0000)]
Merged revisions 94251 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94251 | russell | 2007-12-20 14:08:42 -0600 (Thu, 20 Dec 2007) | 10 lines

Fix a deadlock in d-channel handling in chan_zap.

This deadlock was introduced by the fix to ensure that channels are properly
locked when handling channel variables.  There were sections of this code where
the channel pvt was locked before the channel lock, when in fact it _must_ be
the other way around.

(closes issue #11582)
Reported by: bugi

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94252 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoadd some macros to simplify parsing the config file,
Luigi Rizzo [Thu, 20 Dec 2007 12:56:07 +0000 (12:56 +0000)]
add some macros to simplify parsing the config file,
see description in config.h .

They are a variant of the set of macros i used in chan_oss.c,
structured in a way to be more robust to the presence of
spurious ';' - basically, they define wrappers for 'do {'
and '} while (0)', plus some helper functions to deal with simple
cases such as ast_copy_string, ast_malloc, strtoul, ast_true ...

The prefix (CV_ as 'Config Variable') tries to be easy to remember
and has been chosen to not conflict with other existing macros in the tree.

For the time being, I have only updated the three source files in the
tree that used the old M_* macros. Hopefully, more files will be
converted.

NOTE:

    I understand that inventing my own dialect of C is generally wrong;
    however, the lack of adequate support in the language encourages
    lazy programming practices (such as ignoring errors, bounds, etc.)
    and this increases the chance of vulnerability in the code, especially
    because we are parsing user input here.
    Hopefully, these macros and the use of ast_parse_arg (in config.h)
    should encourage the programmer to write more robust code.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94191 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agomodify http://svn.digium.com/view/asterisk?view=rev&rev=93603
Luigi Rizzo [Thu, 20 Dec 2007 09:55:05 +0000 (09:55 +0000)]
modify svn.digium.com/view/asterisk?view=rev&rev=93603
so that paths and filename are writable by asterisk.c without
causing segfaults.

This involves defining the variables as const char *,
and having them point to as static, writable buffer
defined in asterisk.c

On passing, fix some errors in using these variables
in some files in utils/ , and in res/snmp/agent.c
which was redefining a variable without using paths.h

(not applicable to 1.4)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94168 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years ago1. Unify the check for a penalty < 0 into the set_member_penalty code.
Mark Michelson [Wed, 19 Dec 2007 23:17:42 +0000 (23:17 +0000)]
1. Unify the check for a penalty < 0 into the set_member_penalty code.
2. Fix an error when checking the CLI command for setting a member's penalty.
3. Fix a logging error if the incorrect parameter was the queue name or interface.

(closes issue #11544, reported and patched by Laureano)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94124 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94122 via svnmerge from
Mark Michelson [Wed, 19 Dec 2007 23:04:32 +0000 (23:04 +0000)]
Merged revisions 94122 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94122 | mmichelson | 2007-12-19 17:02:22 -0600 (Wed, 19 Dec 2007) | 6 lines

Sox versions 13.0.0 and newer do not have "soxmix" and instead use sox -m. res_monitor
needs to use this if the user does not have soxmix.

(closes issue #11589, reported by amessina, patch inspired by amessina but with a flourish from me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94123 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 94077 via svnmerge from
Russell Bryant [Wed, 19 Dec 2007 22:51:03 +0000 (22:51 +0000)]
Merged revisions 94077 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94077 | russell | 2007-12-19 16:48:48 -0600 (Wed, 19 Dec 2007) | 4 lines

Check for the existence of the soxmix application on the target platform and have
the result available in autoconfig.h.
(part of issue #11589)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94085 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd 'voicemail reload' command.
Tilghman Lesher [Wed, 19 Dec 2007 20:20:55 +0000 (20:20 +0000)]
Add 'voicemail reload' command.
Reported by: eliel
Patch by: eliel
(Closes issue #11365)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94053 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd contributed WaitUntil app.
Tilghman Lesher [Wed, 19 Dec 2007 20:06:23 +0000 (20:06 +0000)]
Add contributed WaitUntil app.
Original code by pprindeville, updated for trunk by tilghman.
(Closes issue #11487)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94052 65c4cc65-6c06-0410-ace0-fbb531ad65f3