asterisk/asterisk.git
17 months agostasis_system: Remove silly usage of RAII_VAR.
Corey Farrell [Tue, 9 Jan 2018 16:53:28 +0000 (11:53 -0500)]
stasis_system: Remove silly usage of RAII_VAR.

Change-Id: Iedbe5656cee68cd3a96a953558764aa02d4a0c3b

17 months agoMerge "res_pjsip_session: Always bundle streams if WebRTC is enabled."
Jenkins2 [Tue, 9 Jan 2018 20:23:42 +0000 (14:23 -0600)]
Merge "res_pjsip_session: Always bundle streams if WebRTC is enabled."

17 months agoMerge "Revert "codec_opus: Make libcurl a dependency in menuselect""
Jenkins2 [Tue, 9 Jan 2018 19:52:14 +0000 (13:52 -0600)]
Merge "Revert "codec_opus: Make libcurl a dependency in menuselect""

17 months agores_pjsip.c: Update the endpoint identification documentation.
Richard Mudgett [Wed, 3 Jan 2018 23:26:42 +0000 (17:26 -0600)]
res_pjsip.c: Update the endpoint identification documentation.

* Endpoint identify_by documentation.
* IP/Header endpoint identifier documentation.

Change-Id: Id92f00b495acca7be945daf749d2abd7f76a0b5a

17 months agores_pjsip_endpoint_identifier_ip.c: Remove unnecessary requirement.
Richard Mudgett [Wed, 3 Jan 2018 21:20:27 +0000 (15:20 -0600)]
res_pjsip_endpoint_identifier_ip.c: Remove unnecessary requirement.

The requirement that "ip" must be in the endpoint identify_by list to
allow the type=identify method to identify the endpoint is not necessary.
The "ip" identifier method can match one and only one endpoint.  To even
work, the "ip" identifier method configuration must explicitly specify the
identified endpoint.  Therefore, why bother configuring the type=identify
identifier in the first place?  The requirement only adds the potential
for configuration errors for no benefit.  Even worse, those configuration
errors cannot be detected when the configuration loads.  The requirement
was introduced with the ASTERISK_27206 patch.

* Remove the code change that enforces the requiremnt.  Listing the "ip"
method in the identify_by value is simply documentation.

Change-Id: Ia057f92a33fb5d9f51dc5d5692e3d5ee1a6f2c11

17 months agores_pjsip.c: Fix ident_to_str() and refactor ident_handler().
Richard Mudgett [Sat, 6 Jan 2018 01:03:16 +0000 (19:03 -0600)]
res_pjsip.c: Fix ident_to_str() and refactor ident_handler().

* Extracted sip_endpoint_identifier_type2str() and
sip_endpoint_identifier_str2type() to simplify the calling functions.

* Fixed pjsip_configuration.c:ident_to_str() building the endpoint's
identify_by value string.

Change-Id: Ide876768a8d5d828b12052e2a75008b0563fc509

17 months agores_pjsip_endpoint_identifier_ip.c: Allow multiple IdentifyDetail AMI events.
Richard Mudgett [Thu, 4 Jan 2018 23:04:39 +0000 (17:04 -0600)]
res_pjsip_endpoint_identifier_ip.c: Allow multiple IdentifyDetail AMI events.

The AMI PJSIPShowEndpoint action could only list one IdentifyDetail AMI
event per endpoint.  However, there is no reason that multiple
type=identify sections cannot identify the same endpoint.

* Reworked format_ami_endpoint_identify() to generate as many
IdentifyDetail AMI events as there are matching identifiers.

Change-Id: Ie146792aef72d78e05416ab5b27bc552a30399db

17 months agotranslate: Avoid absolute value on unsigned substraction.
Alexander Traud [Fri, 5 Jan 2018 11:51:47 +0000 (12:51 +0100)]
translate: Avoid absolute value on unsigned substraction.

ast_format_get_sample_rate(.) returns an unsigned type. The difference of a
substraction between two unsigned types does not get implicitly converted to a
signed type. Therefore, using abs(.) did not make sense.

ASTERISK-27549

Change-Id: Ib904d9ee0d46b6fdd1476fbc464fbbf813304017

17 months agoMerge "res_pjsip.c: Fix endpoint identifier registration name search."
Jenkins2 [Tue, 9 Jan 2018 14:23:57 +0000 (08:23 -0600)]
Merge "res_pjsip.c: Fix endpoint identifier registration name search."

17 months agoRevert "codec_opus: Make libcurl a dependency in menuselect"
Sean Bright [Tue, 9 Jan 2018 14:22:35 +0000 (08:22 -0600)]
Revert "codec_opus: Make libcurl a dependency in menuselect"

This reverts commit 028f4320de60a204e457ad606ab0a3318493b431.

Change-Id: Ieb91f825cb55202a937f5361c01d356e7662b70c

17 months agoMerge "res_stasis: Fix dial bridge unload."
Joshua Colp [Tue, 9 Jan 2018 13:01:45 +0000 (07:01 -0600)]
Merge "res_stasis: Fix dial bridge unload."

17 months agoMerge "BuildSystem: Really do not pass unknown-warning options to the compiler."
Jenkins2 [Tue, 9 Jan 2018 12:39:40 +0000 (06:39 -0600)]
Merge "BuildSystem: Really do not pass unknown-warning options to the compiler."

17 months agoMerge "codec_gsm: Avoid shifting a negative signed value."
Jenkins2 [Tue, 9 Jan 2018 12:22:30 +0000 (06:22 -0600)]
Merge "codec_gsm: Avoid shifting a negative signed value."

17 months agoMerge "res_pjsip_endpoint_identifier_ip.c: Fix apply identify validation."
Jenkins2 [Tue, 9 Jan 2018 11:46:34 +0000 (05:46 -0600)]
Merge "res_pjsip_endpoint_identifier_ip.c: Fix apply identify validation."

17 months agoMerge "BuildSystem: Find ptlib-config on Debian/Ubuntu."
Joshua Colp [Tue, 9 Jan 2018 11:41:24 +0000 (05:41 -0600)]
Merge "BuildSystem: Find ptlib-config on Debian/Ubuntu."

17 months agores_pjsip_session: Always bundle streams if WebRTC is enabled.
Joshua Colp [Mon, 8 Jan 2018 16:54:00 +0000 (16:54 +0000)]
res_pjsip_session: Always bundle streams if WebRTC is enabled.

Some WebRTC clients can't handle renegotiation with the addition of
streams that include an offer to bundle. They instead expect the
newly added streams to already be bundled. This change does such a thing
if WebRTC support is enabled on an endpoint.

ASTERISK-27566

Change-Id: I7fe9b7ac35a2798627d9c2c8369129f407af6461

17 months agobridge_softmix: Fix sfu_append_source_streams test.
Corey Farrell [Tue, 9 Jan 2018 02:25:23 +0000 (21:25 -0500)]
bridge_softmix: Fix sfu_append_source_streams test.

* validate_stream: zero result from ast_format_cap_identical indicates
  they are not identical, rather than non-zero indicating an error.
* validate_original_streams: use num_streams instead of
  ARRAY_LEN(params).
* Fix declaration of alice_dest_stream and bob_dest_stream.

Change-Id: I6b1dd8bed10439d3c7406f033eb1896b6c419147

17 months agoapp_confbridge: Fix NULL check in action_kick_last.
Corey Farrell [Tue, 9 Jan 2018 00:47:38 +0000 (19:47 -0500)]
app_confbridge: Fix NULL check in action_kick_last.

The check for last_user == NULL needs to happen before we dereference
the variable, previously it was possible for us to check flags of a NULL
last_user.

Change-Id: I274f737aa8af9d2d53e4a78cdd7ad57561003945

17 months agores_stasis: Reduce RAII_VAR usage.
Corey Farrell [Sat, 6 Jan 2018 08:17:15 +0000 (03:17 -0500)]
res_stasis: Reduce RAII_VAR usage.

In addition to being a micro-optimization (RAII_VAR has overhead), this
change improves output of REF_DEBUG.  Unfortunately when RAII_VAR calls
ao2_cleanup it does so from a generated _dtor_varname function.  For
example this caused _dtor_app to release a reference instead of
__stasis_app_unregister.

Change-Id: I4ce67120583a446babf9adeec678b71d37fcd9e5

17 months agoMerge "res_stasis: Fix app_is_subscribed_bridge_id."
Jenkins2 [Mon, 8 Jan 2018 17:25:45 +0000 (11:25 -0600)]
Merge "res_stasis: Fix app_is_subscribed_bridge_id."

17 months agores_pjsip: Add AMI action 'PJSIPShowAuths'
Sungtae Kim [Fri, 5 Jan 2018 00:47:11 +0000 (01:47 +0100)]
res_pjsip: Add AMI action 'PJSIPShowAuths'

Add an AMI action which provides information on all
configured Auths.

ASTERISK-27547

Change-Id: I1a88a75b38a2b1dd9d1de6c0307b20a3f584c817

17 months agoMerge "General: Avoid implicit conversion to char when changes value to negative."
Jenkins2 [Mon, 8 Jan 2018 12:51:40 +0000 (06:51 -0600)]
Merge "General: Avoid implicit conversion to char when changes value to negative."

17 months agoMerge "bridge_softmix: Removed unused parameter from check_binaural_position_change...
Jenkins2 [Mon, 8 Jan 2018 12:38:13 +0000 (06:38 -0600)]
Merge "bridge_softmix: Removed unused parameter from check_binaural_position_change(.)."

17 months agoMerge "editline: Avoid comparison between pointer and zero character constant."
Jenkins2 [Mon, 8 Jan 2018 12:13:32 +0000 (06:13 -0600)]
Merge "editline: Avoid comparison between pointer and zero character constant."

17 months agoMerge "pbx: Prevent execution of NULL pointer."
Jenkins2 [Mon, 8 Jan 2018 11:53:29 +0000 (05:53 -0600)]
Merge "pbx: Prevent execution of NULL pointer."

17 months agores_stasis: Fix dial bridge unload.
Corey Farrell [Mon, 8 Jan 2018 03:38:49 +0000 (22:38 -0500)]
res_stasis: Fix dial bridge unload.

If the dial bridge has been created it must be released by calling
ast_bridge_destroy, simply releasing the ao2 reference is not enough.

Also move stasis_app_control_shutdown earlier in unload to ensure the
bridge cannot be created or grabbed after the app_bridges container is
released.

Change-Id: I372302de94ca63876069e2585a049c5060e5e767

17 months agores_stasis: Fix app_is_subscribed_bridge_id.
Corey Farrell [Mon, 8 Jan 2018 02:21:13 +0000 (21:21 -0500)]
res_stasis: Fix app_is_subscribed_bridge_id.

Instead of searching for bridge_id provided in an argument this function
always searched for BRIDGE_ALL first.  Rewrite this function to work
like the similar functions for channel and endpoint functions.

Change-Id: Ib5caca69e11727c5c8a7284a1d00621f40f1e60a

17 months agoMerge "General: Silence modules on (un)load."
Jenkins2 [Sun, 7 Jan 2018 22:46:49 +0000 (16:46 -0600)]
Merge "General: Silence modules on (un)load."

17 months agoMerge "chan_ooh323: Limit outgoinglimit to positive values as intended."
Jenkins2 [Sun, 7 Jan 2018 02:56:24 +0000 (20:56 -0600)]
Merge "chan_ooh323: Limit outgoinglimit to positive values as intended."

17 months agoMerge "BuildSystem: Avoid obsolete warning with HELP_STRING on autoconf."
Jenkins2 [Sun, 7 Jan 2018 02:31:04 +0000 (20:31 -0600)]
Merge "BuildSystem: Avoid obsolete warning with HELP_STRING on autoconf."

17 months agoGeneral: Silence modules on (un)load.
Alexander Traud [Fri, 5 Jan 2018 13:44:55 +0000 (14:44 +0100)]
General: Silence modules on (un)load.

Some (normally optional) modules created notices, warnings, and even errors
in normal situations like (un)load. This cluttered the command-line interface
(CLI) on start and while stopping gracefully. However, when an user went for
the script './contrib/scripts/install_prereq', those modules get compiled-in
because their prerequisites were met at compile time. Furthermore, because of
ASTERISK_27475, the former talkative module 'res_curl' is built as side-effect.

ASTERISK-27553

Change-Id: I9f105f46d72553994e820679bfde3478a551b281

17 months agoBuildSystem: Really do not pass unknown-warning options to the compiler.
Alexander Traud [Sat, 6 Jan 2018 21:40:46 +0000 (22:40 +0100)]
BuildSystem: Really do not pass unknown-warning options to the compiler.

When an older GCC version is called with a too new warning option, GCC exited
with an error and Asterisk was not built. Therefore, the configure script tests
the installed compiler whether it supports that warning option. If not, Asterisk
does not pass it to the installed compiler. However, some compilers (like clang)
do not exit (error) but give just a warning in such a case. Because the compiler
did not exit, Asterisk passed the unknown-warning option.

ASTERISK-27560

Change-Id: Ia9b7747f649b27ff5e9f75c3db3fee4fe7a29621

17 months agoGeneral: Avoid implicit conversion to char when changes value to negative.
Alexander Traud [Sat, 6 Jan 2018 07:25:14 +0000 (08:25 +0100)]
General: Avoid implicit conversion to char when changes value to negative.

clang 5.0 warned about this.

ASTERISK-27557

Change-Id: I7cceaa88e147cbdf81a3a7beec5c1c20210fa41e

17 months agobridge_softmix: Removed unused parameter from check_binaural_position_change(.).
Alexander Traud [Fri, 5 Jan 2018 12:06:33 +0000 (13:06 +0100)]
bridge_softmix: Removed unused parameter from check_binaural_position_change(.).

Found as a result of the function being passed an uninitalized variable by
clang.

ASTERISK-27550

Change-Id: I8af3bd84656b685a956d498459f8db3613f68954

17 months agoeditline: Avoid comparison between pointer and zero character constant.
Alexander Traud [Sat, 6 Jan 2018 12:45:28 +0000 (13:45 +0100)]
editline: Avoid comparison between pointer and zero character constant.

gcc 7.2 warned about this.

ASTERISK-27559

Change-Id: I48960dda9cf0a11b6a9426f775e632363f8caa74

17 months agocodec_gsm: Avoid shifting a negative signed value.
Alexander Traud [Sat, 6 Jan 2018 11:01:00 +0000 (12:01 +0100)]
codec_gsm: Avoid shifting a negative signed value.

clang 5.0 warned about this.

ASTERISK-27558

Change-Id: Icc452ecb0d86bbeba78dae768cc472ec540699df

17 months agores_pjsip_endpoint_identifier_ip.c: Fix apply identify validation.
Richard Mudgett [Thu, 4 Jan 2018 18:23:15 +0000 (12:23 -0600)]
res_pjsip_endpoint_identifier_ip.c: Fix apply identify validation.

The ip_identify_apply() did not validate the configuration for simple
static configuration errors or deal well with address resolution errors.

* Added missing configuration validation checks.
* Fixed address resolution error handling.
* Demoted an error message to a warning since it does not fail applying
the identify object configuration.

Change-Id: I8b519607263fe88e8ce964f526a45359fd362b6e

17 months agores_pjsip.c: Fix endpoint identifier registration name search.
Richard Mudgett [Thu, 4 Jan 2018 23:42:59 +0000 (17:42 -0600)]
res_pjsip.c: Fix endpoint identifier registration name search.

If an endpoint identifier name in the endpoint_identifier_order list is a
prefix to the identifier we are registering, we could install it in the
wrong position of the list.

Assuming
endpoint_identifier_order=username,ip,anonymous

then registering the "ip_only" identifier would put the identifier in the
wrong position of the priority list.

* Fix incorrect strncmp() string prefix matching.

Change-Id: Ib8819ec4b811da8a27419fd93528c54d34f01484

17 months agoBuildSystem: Find ptlib-config on Debian/Ubuntu.
Alexander Traud [Fri, 5 Jan 2018 09:33:58 +0000 (10:33 +0100)]
BuildSystem: Find ptlib-config on Debian/Ubuntu.

The current configure script requires that tool when libpt-dev is installed.
libpt-dev was installed by libopenh323-dev, bacause you wanted to go for H.323
based channel drivers.

ASTERISK-25329

Change-Id: I9c6ab78b7246c21536e1d252dcbffe682f63f83d

17 months agochan_ooh323: Limit outgoinglimit to positive values as intended.
Alexander Traud [Fri, 5 Jan 2018 12:42:07 +0000 (13:42 +0100)]
chan_ooh323: Limit outgoinglimit to positive values as intended.

ASTERISK-27552

Change-Id: Ifbf9d51e7374ca2e8b27ec568f6770050fc1a854

17 months agoooh323cDriver: Fix typo in header guard.
Alexander Traud [Fri, 5 Jan 2018 12:19:36 +0000 (13:19 +0100)]
ooh323cDriver: Fix typo in header guard.

ASTERISK-27551

Change-Id: I39ff66031e3373e895e2bc47b23a5e860ea4e012

17 months agoBuildSystem: Avoid obsolete warning with HELP_STRING on autoconf.
Alexander Traud [Fri, 5 Jan 2018 09:36:49 +0000 (10:36 +0100)]
BuildSystem: Avoid obsolete warning with HELP_STRING on autoconf.

ASTERISK-26046

Change-Id: I48f05698c235f709225b92bec5aa260fb57d69d1

17 months agopbx: Prevent execution of NULL pointer.
Corey Farrell [Thu, 4 Jan 2018 21:37:52 +0000 (16:37 -0500)]
pbx: Prevent execution of NULL pointer.

pbx_extension_helper has a check for q->swo.exec == NULL but it doesn't
actually return so we would still run the function.  Fix the return.
Move the 'int res' variable into the only scope which uses it.

Also fix a copy-paste error in ast_pbx_init which could result in a
crash on allocation failure (we exit with a normal error instead).

Change-Id: I0693af921fdc7f56b6a72a21fb816ed08b960a69

17 months agoMerge "rtp_engine: Add missing unlock."
Jenkins2 [Thu, 4 Jan 2018 21:02:15 +0000 (15:02 -0600)]
Merge "rtp_engine: Add missing unlock."

17 months agoMerge "translators: Don't use ast_module_running_ref."
Joshua Colp [Thu, 4 Jan 2018 20:49:06 +0000 (14:49 -0600)]
Merge "translators: Don't use ast_module_running_ref."

17 months agoMerge "res_pjsip_history: Add missing unlock to CLI command."
Jenkins2 [Thu, 4 Jan 2018 20:24:25 +0000 (14:24 -0600)]
Merge "res_pjsip_history: Add missing unlock to CLI command."

17 months agoMerge "aco: Fix NULL dereference in error path."
Jenkins2 [Thu, 4 Jan 2018 20:00:43 +0000 (14:00 -0600)]
Merge "aco: Fix NULL dereference in error path."

17 months agoMerge "func_odbc: Add missing unlock's to acf_odbc_read."
Jenkins2 [Thu, 4 Jan 2018 19:53:20 +0000 (13:53 -0600)]
Merge "func_odbc: Add missing unlock's to acf_odbc_read."

17 months agotranslators: Don't use ast_module_running_ref.
Corey Farrell [Thu, 4 Jan 2018 16:50:13 +0000 (11:50 -0500)]
translators: Don't use ast_module_running_ref.

Translators are run during module load before the module is actually
running, so it cannot use ast_module_running_ref.

ASTERISK-20346

Change-Id: Iaa0e75da99c696e38000f1a41e340abbd7a88f56

17 months agortp_engine: Add missing unlock.
Corey Farrell [Thu, 4 Jan 2018 15:39:59 +0000 (10:39 -0500)]
rtp_engine: Add missing unlock.

Change-Id: I380c31a255e060309f4916da11176e0d00813215

17 months agores_pjsip_history: Add missing unlock to CLI command.
Corey Farrell [Thu, 4 Jan 2018 15:30:48 +0000 (10:30 -0500)]
res_pjsip_history: Add missing unlock to CLI command.

Change-Id: I872060a30543776a176a316309602d924a23eb29

17 months agoaco: Fix NULL dereference in error path.
Corey Farrell [Thu, 4 Jan 2018 15:27:19 +0000 (10:27 -0500)]
aco: Fix NULL dereference in error path.

Change-Id: Id505167cf0f9414a3c144fa2c1e181a2cf288694

17 months agoMerge "loader: Create ast_module_running_ref."
Joshua Colp [Thu, 4 Jan 2018 13:12:43 +0000 (07:12 -0600)]
Merge "loader: Create ast_module_running_ref."

17 months agoMerge "res_pjsip_session: Check if sequence header is missing"
Joshua Colp [Thu, 4 Jan 2018 13:01:04 +0000 (07:01 -0600)]
Merge "res_pjsip_session: Check if sequence header is missing"

17 months agoMerge "datastore: Add automatic module references."
Joshua Colp [Thu, 4 Jan 2018 12:53:28 +0000 (06:53 -0600)]
Merge "datastore: Add automatic module references."

17 months agofunc_odbc: Add missing unlock's to acf_odbc_read.
Corey Farrell [Thu, 4 Jan 2018 01:07:44 +0000 (20:07 -0500)]
func_odbc: Add missing unlock's to acf_odbc_read.

Change-Id: I828329ecbd252ae8f27a369a046d2b03102b07c6

17 months agoloader: Create ast_module_running_ref.
Corey Farrell [Sat, 30 Dec 2017 00:24:02 +0000 (19:24 -0500)]
loader: Create ast_module_running_ref.

This function returns NULL if the module in question is not running.  I
did not change ast_module_ref as most callers do not check the result
and they always call ast_module_unref.

Make use of this function when running registered items from:
* app_stack API's
* bridge technologies
* CLI commands
* File formats
* Manager Actions
* RTP engines
* Sorcery Wizards
* Timing Interfaces
* Translators
* AGI Commands
* Fax Technologies

ASTERISK-20346 #close

Change-Id: Ia16fd28e188b2fc0b9d18b8a5d9cacc31df73fcc

17 months agoMerge "res_pjsip: Add AMI action 'PJSIPShowAors'"
Jenkins2 [Wed, 3 Jan 2018 21:29:36 +0000 (15:29 -0600)]
Merge "res_pjsip: Add AMI action 'PJSIPShowAors'"

17 months agores_pjsip_session: Check if sequence header is missing
Kevin Harwell [Wed, 3 Jan 2018 16:41:46 +0000 (10:41 -0600)]
res_pjsip_session: Check if sequence header is missing

The pjsip_msg_find_hdr function can return NULL. This patch adds a check
when searching for the sequence header to make sure a NULL pointer is never
de-referenced.

Change-Id: I19af23aeeded65be016be92360e8cb7ffe51fad2

17 months agoMerge "core: Use macros to generate ao2_container callbacks where possible."
Jenkins2 [Wed, 3 Jan 2018 13:50:36 +0000 (07:50 -0600)]
Merge "core: Use macros to generate ao2_container callbacks where possible."

17 months agoMerge "astobj2: Create case-insensitive variants of container function macros."
Jenkins2 [Wed, 3 Jan 2018 13:32:15 +0000 (07:32 -0600)]
Merge "astobj2: Create case-insensitive variants of container function macros."

17 months agoMerge "aco: Add missing aco_option_type_string for OPT_TIMELEN_T."
Joshua Colp [Wed, 3 Jan 2018 13:09:38 +0000 (07:09 -0600)]
Merge "aco: Add missing aco_option_type_string for OPT_TIMELEN_T."

17 months agoMerge "cdr: submit: fix logic of test for batch mode"
Jenkins2 [Wed, 3 Jan 2018 12:43:47 +0000 (06:43 -0600)]
Merge "cdr: submit: fix logic of test for batch mode"

17 months agoMerge "cdr_mysql: Make sure connection charset is always set"
Joshua Colp [Tue, 2 Jan 2018 13:48:24 +0000 (07:48 -0600)]
Merge "cdr_mysql: Make sure connection charset is always set"

17 months agoMerge "stasis_channels.c: Misc cleanup."
Jenkins2 [Tue, 2 Jan 2018 13:38:44 +0000 (07:38 -0600)]
Merge "stasis_channels.c: Misc cleanup."

17 months agocdr: submit: fix logic of test for batch mode
Tzafrir Cohen [Tue, 2 Jan 2018 13:36:04 +0000 (15:36 +0200)]
cdr: submit: fix logic of test for batch mode

ASTERISK-27539 #close

Change-Id: I33cdf329d2bb4486dcae975c450f6aae94c515f7

17 months agores_pjsip: Add AMI action 'PJSIPShowAors'
Sungtae Kim [Sat, 30 Dec 2017 05:14:00 +0000 (06:14 +0100)]
res_pjsip: Add AMI action 'PJSIPShowAors'

Add an AMI action which provides information on all
configured AORs.

ASTERISK-27537

Change-Id: If8b990a00909e5b6c0f04a3b8dccd9903dc445eb

17 months agoaco: Add missing aco_option_type_string for OPT_TIMELEN_T.
Corey Farrell [Tue, 2 Jan 2018 06:26:10 +0000 (01:26 -0500)]
aco: Add missing aco_option_type_string for OPT_TIMELEN_T.

ASTERISK-27117

Change-Id: I8f6c34bb30830be9f7a40823723eb4dcaaa91c61

17 months agoice: Increase foundation buffer size
Sean Bright [Sun, 31 Dec 2017 16:26:54 +0000 (11:26 -0500)]
ice: Increase foundation buffer size

Per RFC 5245, the foundation specified with an ICE candidate can be up
to 32 characters but we are only allowing for 31.

ASTERISK-27498 #close
Reported by: Michele Prà

Change-Id: I05ce7a5952721a76a2b4c90366168022558dc7cf

17 months agoastobj2: Create case-insensitive variants of container function macros.
Corey Farrell [Sat, 30 Dec 2017 04:03:52 +0000 (23:03 -0500)]
astobj2: Create case-insensitive variants of container function macros.

* AO2_STRING_FIELD_CASE_HASH_FN
* AO2_STRING_FIELD_CASE_CMP_FN
* AO2_STRING_FIELD_CASE_SORT_FN

Change-Id: I11af8c6a0c43380a42732553f519c667abb842cf

17 months agocore: Use macros to generate ao2_container callbacks where possible.
Corey Farrell [Sat, 30 Dec 2017 04:59:00 +0000 (23:59 -0500)]
core: Use macros to generate ao2_container callbacks where possible.

This uses AO2_STRING_FIELD_HASH_FN and AO2_STRING_FIELD_CMP_FN where
possible in the Asterisk core.

This removes CMP_STOP from the result of CMP_FN callbacks for the
following structure types:
* ast_bucket_metadata
* ast_bucket_scheme
* generic_monitor_instance_list (ccss.c)
* ast_bucket_file (media_cache.c)
* named_acl

Change-Id: Ide4c1449a894bce70dea1fef664dade9b57578f1

17 months agodatastore: Add automatic module references.
Corey Farrell [Fri, 29 Dec 2017 20:50:12 +0000 (15:50 -0500)]
datastore: Add automatic module references.

Add a reference to the calling module when it is active to protect
access to datastore->info.  Remove module references done by
func_periodic_hook as the datastore now handles it.

ASTERISK-25128 #close

Change-Id: I8357a3711e77591d0d1dd8ab4211a7eedd782c89

17 months agoMerge "func_channel.c: Update MASTER_CHANNEL documentation"
Jenkins2 [Fri, 29 Dec 2017 19:40:31 +0000 (13:40 -0600)]
Merge "func_channel.c: Update MASTER_CHANNEL documentation"

17 months agostasis_channels.c: Misc cleanup.
Richard Mudgett [Thu, 28 Dec 2017 19:27:43 +0000 (13:27 -0600)]
stasis_channels.c: Misc cleanup.

* Use current OBJ_SEARCH_xxx defines instead of the deprecated versions.

* Fix hash_cb and cmp_cb container functions to correctly use the
OBJ_SEARCH_xxx values.

* Remove incorrect usage of CMP_STOP.  Most uses in the system have no
effect.  This allows the collapse of channel_role_single_cmp_cb() and
channel_role_multi_cmp_cb() into channel_role_cmp_cb().

* Remove unnecessary usage of RAII_VAR().

Change-Id: I02c405518cab22aa2a082b61e2353bf7cd629a70

17 months agoMerge "manager.c: Update AMI Status event documentation"
Jenkins2 [Thu, 28 Dec 2017 19:46:22 +0000 (13:46 -0600)]
Merge "manager.c: Update AMI Status event documentation"

17 months agoMerge "menuselect: Fix check for running configure."
Richard Mudgett [Thu, 28 Dec 2017 17:51:21 +0000 (11:51 -0600)]
Merge "menuselect: Fix check for running configure."

17 months agoMerge "astobj.h: Remove from Asterisk core."
Jenkins2 [Thu, 28 Dec 2017 17:15:11 +0000 (11:15 -0600)]
Merge "astobj.h: Remove from Asterisk core."

17 months agoMerge "cdr: Missing NULL check and unlock."
Jenkins2 [Thu, 28 Dec 2017 16:42:17 +0000 (10:42 -0600)]
Merge "cdr: Missing NULL check and unlock."

17 months agocdr_mysql: Make sure connection charset is always set
Sean Bright [Wed, 13 Dec 2017 21:43:18 +0000 (16:43 -0500)]
cdr_mysql: Make sure connection charset is always set

When the MYSQL_OPT_RECONNECT option is enabled, the MySQL client API
will transparently reconnect when it needs to. Ideally this simplifies
our code, but when this reconnection occurs all connection state is
lost. Because we are not notified that this has happened, we don't know
to set our character set again (with "SET NAMES 'xyz'").

Rather than calling SET NAMES, we instead set the MYSQL_SET_CHARSET_NAME
option which will do it for us under the hood on each connect. This
option has been present in the MySQL C API for at least 15 years, so it
should be safe for most installations.

I also snuck a few other changes into this patch:

* Default the MySQL port to MYSQL_PORT (3306) instead of 0 if it's not
  defined.

* Fix some erroneous and/or silly checks on the contents of the
  configuration ast_str values.

ASTERISK-27366 #close
Reported by: Halil İbrahim YILDIZ

Change-Id: I36bf8dc5d5f83584e803b3b1a151dea9396ab8f5

17 months agomanager.c: Update AMI Status event documentation
Richard Mudgett [Thu, 28 Dec 2017 02:48:40 +0000 (20:48 -0600)]
manager.c: Update AMI Status event documentation

The AMI Status event had linkedid listed twice and was missing the
effective connected line name and number headers.

NOTE: The linkedid and other standard channel snapshot fields in the XML
documentation are part of the <channel_snapshot/> XML template defined in
doc/appdocsxml.xslt.

Change-Id: I004c4c4f9e7b40ef55035c831702721bec82496c

17 months agobridge_native_rtp.c: Fix reentrancy framehook crash.
Richard Mudgett [Thu, 28 Dec 2017 04:36:58 +0000 (22:36 -0600)]
bridge_native_rtp.c: Fix reentrancy framehook crash.

If two channels enter different native rtp bridges at the same time it is
possible that the framehook interface data pointer can be corrupted
because the struct variable was declared static.

* Fixed the reentrancy corruption by changing the framehook interface
struct static variable to a stack local variable.

* Moved the hook.data assignment outside of the channel lock.  It did not
need the lock's protection.  It probably was giving a false sense of
security.

The testsuite
channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/bob_hangs_up
test caught this with MALLOC_DEBUG and DO_CRASH enabled.

Change-Id: If9e35b97d19209b0f984941c1d8eb5f7c55eea91

17 months agofunc_channel.c: Update MASTER_CHANNEL documentation
Richard Mudgett [Thu, 28 Dec 2017 02:22:36 +0000 (20:22 -0600)]
func_channel.c: Update MASTER_CHANNEL documentation

Be more explicit in what is meant by the master channel to eliminate
misunderstanding.

ASTERISK-23133

Change-Id: I453bcaf4b99404a5a3e345dbf093ac6c1afcfc72

17 months agomenuselect: Fix check for running configure.
Corey Farrell [Thu, 28 Dec 2017 01:27:18 +0000 (20:27 -0500)]
menuselect: Fix check for running configure.

menuselect/Makefile checks that autoconfig.h and makeopts were newer
than the '.in' files.  Unfortunately running ./configure does not touch
autoconfig.h unless the contents will change.

Instead of looking at autoconfig.h we just need to ensure that makeopts
is newer than configure.

Also make change to configure.ac so bootstrap.sh doesn't re-add the
extra trailing line-feed.

Change-Id: Ief1f831d6717007f9cebb668c14e92782cd2b794

17 months agocdr: Missing NULL check and unlock.
Corey Farrell [Fri, 22 Dec 2017 05:56:44 +0000 (00:56 -0500)]
cdr: Missing NULL check and unlock.

* handle_dial_message: Missing a check for NULL peer.
* cdr_generic_register: Missing unlock on allocation failure.

cdr_generic_register is fixed by reordering so the new structure is
allocated and initialized before locking the list.

Change-Id: I5799b99270d1a7a716a555c31ac85f4b00ce8686

17 months agoloader: Add volatile to resource_being_loaded.
Corey Farrell [Sun, 24 Dec 2017 04:51:13 +0000 (23:51 -0500)]
loader: Add volatile to resource_being_loaded.

Some compiler optimizers seem to assume that dlopen will not use
__attribute__((constructor)) functions to call back to the program.
This was causing resource_being_loaded to be optimized away completely.

ASTERISK-27531 #close
Tested By: abelbeck

Change-Id: If17a3b889e06811a0e7119f0539d052494d6ece9

17 months agoAST-2017-014: res_pjsip - Missing contact header can cause crash
Kevin Harwell [Wed, 20 Dec 2017 22:17:40 +0000 (16:17 -0600)]
AST-2017-014: res_pjsip - Missing contact header can cause crash

Those SIP messages that create dialogs require a contact header to be present.
If the contact header was missing from the message it could cause Asterisk to
crash.

This patch checks to make sure SIP messages that create a dialog contain the
contact header. If the message does not and it is required Asterisk now returns
a "400 Missing Contact header" response. Also added NULL checks when retrieving
the contact header that were missing as a "just in case".

ASTERISK-27480 #close

Change-Id: I1810db87683fc637a9e3e1384a746037fec20afe

17 months agoastobj.h: Remove from Asterisk core.
Corey Farrell [Fri, 22 Dec 2017 20:00:14 +0000 (15:00 -0500)]
astobj.h: Remove from Asterisk core.

This is the old ASTOBJ macro's which are no longer used except by the
deprecated netsock.c.  Move it to the chan_iax2 include folder so it
does not get used elsewhere.

Change-Id: I7e4ae96678b36b9f41d3cae14b167f110eb5d349

17 months agoRemove as much trailing whitespace as possible.
Sean Bright [Fri, 22 Dec 2017 14:23:22 +0000 (09:23 -0500)]
Remove as much trailing whitespace as possible.

Change-Id: I873c1c6d00f447269bd841494459efccdd2c19c0

17 months agoMerge "Fix some invalid Unicode characters"
Jenkins2 [Fri, 22 Dec 2017 13:36:07 +0000 (07:36 -0600)]
Merge "Fix some invalid Unicode characters"

17 months agoMerge "app_voicemail: Fix file copy error handling."
Jenkins2 [Fri, 22 Dec 2017 13:32:58 +0000 (07:32 -0600)]
Merge "app_voicemail: Fix file copy error handling."

17 months agoFix some invalid Unicode characters
Sean Bright [Thu, 21 Dec 2017 15:51:02 +0000 (10:51 -0500)]
Fix some invalid Unicode characters

configs/samples/minivm.conf.sample contains invalid UTF-8, but that
appears to be intentional.

Change-Id: I7b1e0d332f3380fd0425962a3c9c55f9b200c8cc

17 months agoMerge "Fix Common Typo's."
Jenkins2 [Thu, 21 Dec 2017 14:40:22 +0000 (08:40 -0600)]
Merge "Fix Common Typo's."

17 months agoMerge "docs: Remove old API changes documentation"
Joshua Colp [Thu, 21 Dec 2017 13:06:26 +0000 (07:06 -0600)]
Merge "docs: Remove old API changes documentation"

17 months agoMerge "app_festival: Fix fd leak on connection failure."
Jenkins2 [Thu, 21 Dec 2017 12:35:06 +0000 (06:35 -0600)]
Merge "app_festival: Fix fd leak on connection failure."

17 months agoMerge "bridge: Old channel video source not set to NULL after unref."
Joshua Colp [Thu, 21 Dec 2017 12:15:44 +0000 (06:15 -0600)]
Merge "bridge: Old channel video source not set to NULL after unref."

17 months agoMerge "core: Fix unused variable error in handle_show_sysinfo."
Jenkins2 [Thu, 21 Dec 2017 11:51:26 +0000 (05:51 -0600)]
Merge "core: Fix unused variable error in handle_show_sysinfo."

17 months agoapp_voicemail: Fix file copy error handling.
Corey Farrell [Thu, 21 Dec 2017 03:11:48 +0000 (22:11 -0500)]
app_voicemail: Fix file copy error handling.

Fix error where input/output file descriptors would be closed multiple
times.

Change-Id: Iba5140b60cb7de79e3d5d92be3c256947aa99da9

17 months agodocs: Remove old API changes documentation
Sean Bright [Wed, 20 Dec 2017 20:54:24 +0000 (15:54 -0500)]
docs: Remove old API changes documentation

Change-Id: I1bc7957121cc7ae27dca04acc3613f4e1858476a

17 months agoFix Common Typo's.
Corey Farrell [Wed, 20 Dec 2017 17:14:54 +0000 (12:14 -0500)]
Fix Common Typo's.

Fix instances of:
* Retreive
* Recieve
* other then
* different then
* Repeated words ("the the", "an an", "and and", etc).
* othterwise, teh

ASTERISK-24198 #close

Change-Id: I3809a9c113b92fd9d0d9f9bac98e9c66dc8b2d31

17 months agomanager.h: Bump AMI version
Richard Mudgett [Wed, 20 Dec 2017 17:30:54 +0000 (11:30 -0600)]
manager.h: Bump AMI version

Change-Id: I62e6ddeb261ef012687e1fb6734c554e2499b6bf