asterisk/asterisk.git
11 years agoAdd contributed script for separation of database access from Asterisk
Tilghman Lesher [Tue, 11 Mar 2008 20:58:42 +0000 (20:58 +0000)]
Add contributed script for separation of database access from Asterisk

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107721 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoThis patch adds support for extended help prompts in voicemail. These prompts
Russell Bryant [Tue, 11 Mar 2008 20:54:32 +0000 (20:54 +0000)]
This patch adds support for extended help prompts in voicemail.  These prompts
are in the 1.4.9 sounds release.

(closes issue #11705)
Reported by: jaroth
Patches:
      helpprompts.patch uploaded by jaroth (license 50)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107719 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 107714 via svnmerge from
Jason Parker [Tue, 11 Mar 2008 20:53:48 +0000 (20:53 +0000)]
Merged revisions 107714 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r107714 | qwell | 2008-03-11 15:49:56 -0500 (Tue, 11 Mar 2008) | 5 lines

Copy voicemail dependency logic for res_adsi to chan_gtalk and chan_jingle (for jabber).

(closes issue #12014)
Reported by: junky

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107718 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 107713 via svnmerge from
Kevin P. Fleming [Tue, 11 Mar 2008 20:50:57 +0000 (20:50 +0000)]
Merged revisions 107713 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r107713 | kpfleming | 2008-03-11 15:48:58 -0500 (Tue, 11 Mar 2008) | 2 lines

get chan_vpb to build properly in dev mode

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107715 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDial a device even if it's state is unknown.
Joshua Colp [Tue, 11 Mar 2008 20:36:14 +0000 (20:36 +0000)]
Dial a device even if it's state is unknown.
(closes issue #12184)
Reported by: bluecrow76
Patches:
      asterisk-svn-app_page.c.devicestate_unknown.diff uploaded by bluecrow76 (license 270)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107710 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 107646 via svnmerge from
Joshua Colp [Tue, 11 Mar 2008 19:23:28 +0000 (19:23 +0000)]
Merged revisions 107646 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r107646 | file | 2008-03-11 16:20:01 -0300 (Tue, 11 Mar 2008) | 4 lines

Make sure the visible indication is on the right channel so when the masquerade happens the proper indication is enacted.
(closes issue #11707)
Reported by: iam

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107659 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 107637 via svnmerge from
Joshua Colp [Tue, 11 Mar 2008 18:48:59 +0000 (18:48 +0000)]
Merged revisions 107637 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r107637 | file | 2008-03-11 15:47:33 -0300 (Tue, 11 Mar 2008) | 4 lines

Add an additional check for setting conference parameter when using the marked user options. It was possible for it to return to a no listen/no talk state if a masquerade happened.
(closes issue #12136)
Reported by: aragon

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107638 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 107582 via svnmerge
Joshua Colp [Tue, 11 Mar 2008 17:34:46 +0000 (17:34 +0000)]
Blocked revisions 107582 via svnmerge

........
r107582 | file | 2008-03-11 14:32:17 -0300 (Tue, 11 Mar 2008) | 4 lines

Fix a minor spelling error.
(closes issue #12183)
Reported by: darrylc

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107583 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoWhitespace changes only
Tilghman Lesher [Tue, 11 Mar 2008 16:28:03 +0000 (16:28 +0000)]
Whitespace changes only

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107551 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRemove some redundant logic from wait_for_answer. This also let's us get rid of one of
Mark Michelson [Tue, 11 Mar 2008 15:59:32 +0000 (15:59 +0000)]
Remove some redundant logic from wait_for_answer. This also let's us get rid of one of
those XXX comments from the code.

The redundancy occurs because the 'single' flag implies that the 'r' and 'm' flags are
not set, so there's no need to explicitly check them again.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107530 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agofix another potential bug found by gcc 4.3
Kevin P. Fleming [Tue, 11 Mar 2008 15:39:37 +0000 (15:39 +0000)]
fix another potential bug found by gcc 4.3

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107525 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoblock fix that is already here
Kevin P. Fleming [Tue, 11 Mar 2008 15:19:05 +0000 (15:19 +0000)]
block fix that is already here

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107475 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 107464 via svnmerge from
Kevin P. Fleming [Tue, 11 Mar 2008 15:13:38 +0000 (15:13 +0000)]
Merged revisions 107464 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r107464 | kpfleming | 2008-03-11 09:53:03 -0500 (Tue, 11 Mar 2008) | 2 lines

fix various other problems found by gcc 4.3

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107466 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoClarify comment about masquerading and playback of the parking slot.
Joshua Colp [Tue, 11 Mar 2008 15:05:17 +0000 (15:05 +0000)]
Clarify comment about masquerading and playback of the parking slot.
(closes issue #12180)
Reported by: davidw

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107465 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 107461 via svnmerge from
Kevin P. Fleming [Tue, 11 Mar 2008 14:37:03 +0000 (14:37 +0000)]
Merged revisions 107461 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r107461 | kpfleming | 2008-03-11 09:33:45 -0500 (Tue, 11 Mar 2008) | 2 lines

stop checking for mktime() in the configure script... we don't use it, and the test is buggy under gcc 4.3

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107462 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 107408 via svnmerge from
Kevin P. Fleming [Tue, 11 Mar 2008 14:09:49 +0000 (14:09 +0000)]
Merged revisions 107408 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r107408 | kpfleming | 2008-03-11 09:07:59 -0500 (Tue, 11 Mar 2008) | 5 lines

check for compiler support for -fno-strict-overflow before using it (tested with Debian's gcc 4.3, 4.1 and 3.4)

(closes issue #12179)
Reported by: Netview

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107409 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 107405 via svnmerge from
Kevin P. Fleming [Tue, 11 Mar 2008 13:58:37 +0000 (13:58 +0000)]
Merged revisions 107405 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r107405 | kpfleming | 2008-03-11 08:57:08 -0500 (Tue, 11 Mar 2008) | 2 lines

fix small bug in IMAP toolkit testing

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107406 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 107352 via svnmerge from
Kevin P. Fleming [Tue, 11 Mar 2008 11:36:51 +0000 (11:36 +0000)]
Merged revisions 107352 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r107352 | kpfleming | 2008-03-11 06:04:29 -0500 (Tue, 11 Mar 2008) | 11 lines

fix up various compiler warnings found with gcc-4.3:

- the output of flex includes a static function called 'input' that is not used, so for the moment we'll stop having the compiler tell us about unused variables in the flex source files (a better fix would be to improve our flex post-processing to remove the unused function)

- main/stdtime/localtime.c makes assumptions about signed integer overflow, and gcc-4.3's improved optimizer tries to take advantage of handling potential overflow conditions at compile time; for now, suppress these optimizations until we can fiure out if the code needs improvement

- main/udptl.c has some references to uninitialized variables; in one case there was no bug, but in the other it was certainly possibly for unexpected behavior to occur

- main/editline/readline.c had an unused variable

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107373 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 107290 via svnmerge from
Terry Wilson [Tue, 11 Mar 2008 01:09:46 +0000 (01:09 +0000)]
Merged revisions 107290 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r107290 | twilson | 2008-03-10 19:59:18 -0500 (Mon, 10 Mar 2008) | 2 lines

If we fail to alloc a channel, we should re-lock the pvt structure before returning.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107292 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years ago(closes issue #6019)
Tilghman Lesher [Mon, 10 Mar 2008 21:48:20 +0000 (21:48 +0000)]
(closes issue #6019)
 Reported by: ssokol
 Patches:
       20080304__bug6019.diff.txt uploaded by Corydon76 (license 14)
 Tested by: putnopvut

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107231 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 107173 via svnmerge from
Jason Parker [Mon, 10 Mar 2008 20:28:33 +0000 (20:28 +0000)]
Merged revisions 107173 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r107173 | qwell | 2008-03-10 15:27:08 -0500 (Mon, 10 Mar 2008) | 5 lines

Make sure to reenable echo can after a "failed" (canceled, etc) three-way call.

(closes issue #11335)
Reported by: rebuild

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107177 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 107161 via svnmerge from
Russell Bryant [Mon, 10 Mar 2008 20:17:37 +0000 (20:17 +0000)]
Merged revisions 107161 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r107161 | russell | 2008-03-10 15:17:11 -0500 (Mon, 10 Mar 2008) | 8 lines

Fix another bug specifically related to asynchronous call origination.  Once the
PBX is started on the channel using ast_pbx_start(), then the ownership of the
channel has been passed on to another thread.  We can no longer access it in this
code.  If the channel gets hung up very quickly, it is possible that we could
access a channel that has been free'd.

(inspired by BE-386)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107162 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 107158 via svnmerge from
Russell Bryant [Mon, 10 Mar 2008 20:05:12 +0000 (20:05 +0000)]
Merged revisions 107158 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r107158 | russell | 2008-03-10 15:04:27 -0500 (Mon, 10 Mar 2008) | 9 lines

Fix some bugs related to originating calls.  If the code failed to start a PBX
on the channel (such as if you set a call limit based on the system's load
average), then there were cases where a channel that has already been free'd
using ast_hangup() got accessed.  This caused weird memory corruption and
crashes to occur.

(fixes issue BE-386)
(much debugging credit goes to twilson, final patch written by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107159 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoIf we receive a 488 on a T38 request reinvite back to audio. As well reinvite across...
Joshua Colp [Mon, 10 Mar 2008 20:00:21 +0000 (20:00 +0000)]
If we receive a 488 on a T38 request reinvite back to audio. As well reinvite across a bridge back to audio if one side doesn't negotiate to T38.
(closes issue #8677)
Reported by: alex-911

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107157 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 107102 via svnmerge from
Russell Bryant [Mon, 10 Mar 2008 17:13:34 +0000 (17:13 +0000)]
Merged revisions 107102 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r107102 | russell | 2008-03-10 12:13:17 -0500 (Mon, 10 Mar 2008) | 2 lines

Resolve a compiler warning.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107103 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 107099 via svnmerge from
Russell Bryant [Mon, 10 Mar 2008 16:59:13 +0000 (16:59 +0000)]
Merged revisions 107099 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r107099 | russell | 2008-03-10 11:58:57 -0500 (Mon, 10 Mar 2008) | 3 lines

Fix a race condition where the generator can go away
(closes issue #12175, reported by edantie, patched by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107100 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoapp_queue has now been doxygenified thanks to snuffy! The ony thing I changed
Mark Michelson [Mon, 10 Mar 2008 15:45:13 +0000 (15:45 +0000)]
app_queue has now been doxygenified thanks to snuffy! The ony thing I changed
was the way that locks are referenced, since the old 1.2 names were still used
in the comments.

(closes issue #11997)
Reported by: snuffy
Patches:
      bug_11997_queue_doxy.diff uploaded by snuffy (license 35)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107068 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoway back in July, in r.75706, a fix was made ot the strftime usages, which was good...
Steve Murphy [Mon, 10 Mar 2008 14:55:21 +0000 (14:55 +0000)]
way back in July, in r.75706, a fix was made ot the strftime usages, which was good, but in this case, the check for a nil time was accidentally removed, and now it is restored, to keep timevals like '1969-12-31 17:00:00' from showing up in the cdrs. No idea what databases will do with this. No bugs filed as yet, but it felt like a bug.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107019 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 107016 via svnmerge from
Joshua Colp [Mon, 10 Mar 2008 14:36:16 +0000 (14:36 +0000)]
Merged revisions 107016 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r107016 | file | 2008-03-10 11:33:02 -0300 (Mon, 10 Mar 2008) | 7 lines

Move where unanswered CDRs are dropped to the CDR core, not everything uses app_dial.
(closes issue #11516)
Reported by: ys
Patches:
      branch_1.4_cdr.diff uploaded by ys (license 281)
Tested by: anest, jcapp, dartvader

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@107017 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 106945 via svnmerge from
Kevin P. Fleming [Sat, 8 Mar 2008 16:03:48 +0000 (16:03 +0000)]
Merged revisions 106945 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106945 | kpfleming | 2008-03-08 09:59:42 -0600 (Sat, 08 Mar 2008) | 2 lines

don't generate D-Channel "up" and "down" messages unless the channel state is actually changing; also, generate the "up" message when an implicit "up" occurs due to reception of a normal event when we thought the channel was "down"

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106946 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 106895 via svnmerge from
Russell Bryant [Fri, 7 Mar 2008 22:52:46 +0000 (22:52 +0000)]
Merged revisions 106895 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106895 | russell | 2008-03-07 16:51:23 -0600 (Fri, 07 Mar 2008) | 2 lines

Only start the SLA thread if SLA has actually been configured.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106896 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMake sure we don't start a call when we have already done so in response to a COT...
Matthew Fredrickson [Fri, 7 Mar 2008 22:36:49 +0000 (22:36 +0000)]
Make sure we don't start a call when we have already done so in response to a COT message

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106892 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 106842 via svnmerge from
Jason Parker [Fri, 7 Mar 2008 22:15:20 +0000 (22:15 +0000)]
Merged revisions 106842 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106842 | qwell | 2008-03-07 16:14:45 -0600 (Fri, 07 Mar 2008) | 5 lines

Fix hardcoded grep in editline, were GNU grep is required.

(closes issue #12124)
Reported by: dmartin

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106843 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 106788 via svnmerge from
Joshua Colp [Fri, 7 Mar 2008 19:33:09 +0000 (19:33 +0000)]
Merged revisions 106788 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106788 | file | 2008-03-07 15:32:00 -0400 (Fri, 07 Mar 2008) | 4 lines

Ignore source update control frame.
(closes issue #12168)
Reported by: plack

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106789 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years ago(closes issue #6002)
Steve Murphy [Fri, 7 Mar 2008 18:57:57 +0000 (18:57 +0000)]
(closes issue #6002)
Reported by: rizzo
Tested by: murf

Proposal of the changes to be made, and then an announcement of how they were accomplished:

http://lists.digium.com/pipermail/asterisk-dev/2008-February/032065.html

and:

http://lists.digium.com/pipermail/asterisk-dev/2008-March/032124.html

Here is a recap, file by file, of what I have done:

pbx/pbx_config.c
pbx/pbx_ael.c

All funcs that were passed a ptr to the context list, now will ALSO be passed a hashtab ptr to the same set.
Why? because (for the time being), the dialplan is stored in both, to facilitate a quick, low-cost move to
hash-tables to speed up dialplan processing. If it was deemed necessary to pass the context LIST, well, it
is just as necessary to have the TABLE available. This is because the list/table in question might not be
the global one, but temporary ones we would use to stage the dialplan on, and then swap into the global
position when things are ready.

We now have one external function for apps to use, "ast_context_find_or_create()" instead of the pre-existing
"find" and "create", as all existing usages used both in tandem anyway.

pbx_config, and pbx_ael, will stage the reloaded dialplan into local lists and tables, and
then call merge_contexts_and_delete, which will merge (now) existing contexts and
priorities from other registrars into this local set by copying them. Then, merge_contexts_and_delete will
lock down the contexts, swap the lists and tables, and unlock (real quick), and then
destroy the old dialplan.

chan_sip.c
chan_iax.c
chan_skinny.c

All the channel drivers that would add regcontexts now use the ast_context_find_or_create now.

chan_sip also includes a small fix to get rid of warnings about removing priorities that never got entered.

apps/app_meetme.c
apps/app_dial.c
apps/app_queue.c

All the apps that added a context/exten/priority were also modified to use ast_context_find_or_create instead.

include/asterisk/pbx.h

ast_context_create() is removed. Find_or_create_ is the new method.
ast_context_find_or_create()  interface gets the hashtab added.
ast_merge_contexts_and_delete() gets the local hashtab arg added.
ast_wrlock_contexts_version() is added so you can detect if someone else got a writelock between your readlocking and writelocking.
ast_hashtab_compare_contexts was made public for use in pbx_config/pbx_ael
ast_hashtab_hash_contexts was in like fashion make public.

include/asterisk/pval.h

ast_compile_ael2() interface changed to include the local hashtab table ptr.

main/features.c

For the sake of the parking context, we use ast_context_find_or_create().

main/pbx.c

I changed all the "tree" names to "table" instead. That's because the original
implementation was based on binary trees. (had a free library). Then I moved
to hashtabs. Now, the names move forward too.

refcount field added to contexts, so you can keep track of how many modules
wanted this context to exist.

Some log messages that are warnings were inflated from LOG_NOTICE to LOG_WARNING.

Added some calls to ast_verb(3,...) for debug messages

Lots of little mods to ast_context_remove_extension2, which is now excersized in ways
it was not previously; one definite bug fixed.

find_or_create was upgraded to handle both local lists/tables as well as the globals.

context_merge() was added to do the per-context merging of the old/present contexts/extens/prios into the new/proposed local list/tables

ast_merge_contexts_and_delete() was heavily modified.

ast_add_extension2() was also upgraded to handle changes.

the context_destroy() code was re-engineered to handle the new way of doing things,
by exten/prio instead of by context.

res/ael/pval.c
res/ael/ael.tab.c
res/ael/ael.tab.h
res/ael/ael.y
res/ael/ael_lex.c
res/ael/ael.flex
utils/ael_main.c
utils/extconf.c
utils/conf2ael.c
utils/Makefile

Had to change the interface to ast_compile_ael2(), to include the hashtab ptr.
This ended up involving several external apps.  The main gotcha was I had to
include lock.h and hashtab.h in several places.

As a side note, I tested this stuff pretty thoroughly, I replicated the problems
originally reported by Luigi, and made triply sure that reloads worked, and everything
worked thru "stop gracefully". I found a and fixed a few bugs as I was merging into
trunk, that did not appear in my tests of bug6002.

How's this for verbose commit messages?

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106757 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 106704 via svnmerge from
Russell Bryant [Fri, 7 Mar 2008 17:17:30 +0000 (17:17 +0000)]
Merged revisions 106704 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106704 | russell | 2008-03-07 11:16:58 -0600 (Fri, 07 Mar 2008) | 8 lines

Change a warning message to a debug message.  This is happening quite frequently,
and it is not worth spamming users with these messages unless we are pretty confident
that it should never happen.  As it stands today, it _will_ and _does_ happen and
until that gets cleaned up a reasonable amount on the development side, let's not
spam the logs of everyone else.

(closes issue #12154)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106707 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agofix example usage
Russell Bryant [Fri, 7 Mar 2008 16:31:48 +0000 (16:31 +0000)]
fix example usage

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106684 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 106635 via svnmerge from
Tilghman Lesher [Fri, 7 Mar 2008 16:26:07 +0000 (16:26 +0000)]
Merged revisions 106635 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106635 | tilghman | 2008-03-07 10:22:11 -0600 (Fri, 07 Mar 2008) | 3 lines

Warn the user when a temporary greeting exists
(Closes issue #11409)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106654 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 106606 via svnmerge from
Tilghman Lesher [Fri, 7 Mar 2008 15:22:34 +0000 (15:22 +0000)]
Merged revisions 106606 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106606 | tilghman | 2008-03-07 09:20:52 -0600 (Fri, 07 Mar 2008) | 3 lines

Properly initialize rtp->schedid
(Closes issue #12154)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106607 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 106552 via svnmerge from
Tilghman Lesher [Fri, 7 Mar 2008 06:54:47 +0000 (06:54 +0000)]
Merged revisions 106552 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106552 | tilghman | 2008-03-07 00:36:33 -0600 (Fri, 07 Mar 2008) | 6 lines

Safely use the strncat() function.
(closes issue #11958)
 Reported by: norman
 Patches:
       20080209__bug11958.diff.txt uploaded by Corydon76 (license 14)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106553 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agominor text changes
Russell Bryant [Fri, 7 Mar 2008 01:19:02 +0000 (01:19 +0000)]
minor text changes

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106518 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd updated SMDI documentation that I had only sitting in my email ... oops
Russell Bryant [Fri, 7 Mar 2008 01:15:36 +0000 (01:15 +0000)]
Add updated SMDI documentation that I had only sitting in my email ... oops

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106507 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerge changes from team/russell/g722-sillyness ...
Russell Bryant [Fri, 7 Mar 2008 00:24:58 +0000 (00:24 +0000)]
Merge changes from team/russell/g722-sillyness ...

Fix a number of other places where the number of samples in a G722 frame was
not properly handled because of various reasons.

main/rtp.c:
 - When a G722 frame is read from the smoother, the number of samples in the
   frame must be divided by 2 before being sent out over the network.  Even
   though G722 is 16 kHz, an error in some previous spec has made it so that
   we have to list the number of samples such as if it was 8 kHz.

main/file.c:
 - When scheduling the next time to expect a frame, take into account that the
   format of the file we're reading from may not be 8 kHz.

codecs/codec_g722.c:
 - When converting from G722 to slinear, g722_decode() expects its samples
   parameter to be in the silly (real samples / 2) format.  Make it so.
 - When converting from slinear to G722, properly set the number of samples in
   the frame to be the number of bytes of output * 2.

formats/format_pcm.c:
 - This format module handles G722, among a number of other formats.  However,
   the read() and seek() functions did not account for the fact that G722 has
   2 samples per byte.

(closes issue #12130, reported by rickross, patched by me)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106501 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix file playback in many cases.
Jason Parker [Thu, 6 Mar 2008 22:11:30 +0000 (22:11 +0000)]
Fix file playback in many cases.

(closes issue #12115)
Reported by: pj
Patches:
      v2-fileexists.patch uploaded by dimas (license 88) (with modifications by me)
Tested by: dimas, qwell, russell

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106439 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 106437 via svnmerge from
Mark Michelson [Thu, 6 Mar 2008 22:11:26 +0000 (22:11 +0000)]
Merged revisions 106437 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106437 | mmichelson | 2008-03-06 16:10:07 -0600 (Thu, 06 Mar 2008) | 8 lines

Quell an annoying message that is likely to print every single time that
ast_pbx_outgoing_app is called. The reason is that __ast_request_and_dial
allocates the cdr for the channel, so it should be expected that the channel
will have a cdr on it.

Thanks to joetester on IRC for pointing this out

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106438 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agotrivial fix for an agi error when attempting to use EAGI on a dead/hungup channel...
Donny Kavanagh [Thu, 6 Mar 2008 19:31:50 +0000 (19:31 +0000)]
trivial fix for an agi error when attempting to use EAGI on a dead/hungup channel, we now print an error that makes sense
given our removal of deadagi as an actual application.

(closes issue #12161)
Reported by: explidous
Patches:
      res_agi_12161.patch uploaded by juggie (license 24)
Tested by: juggie

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106399 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMissing braces, fix parsing
Tilghman Lesher [Thu, 6 Mar 2008 05:21:39 +0000 (05:21 +0000)]
Missing braces, fix parsing
(closes issue #12112)
 Reported by: cyrenity
 Patches:
       res_config_ldap.patch-03-03-2008 uploaded by cyrenity (license 416)
 Tested by: cyrenity, Corydon76

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106346 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 106328 via svnmerge from
Tilghman Lesher [Thu, 6 Mar 2008 04:45:16 +0000 (04:45 +0000)]
Merged revisions 106328 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106328 | tilghman | 2008-03-05 22:40:06 -0600 (Wed, 05 Mar 2008) | 2 lines

Upgrade to the next release of sounds

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106329 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd a cmenuselect/cmenuconfig, to force curses.
Jason Parker [Wed, 5 Mar 2008 23:21:52 +0000 (23:21 +0000)]
Add a cmenuselect/cmenuconfig, to force curses.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106250 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd the nmenuselect makefile targets. This is a newt menuselect interface which
Russell Bryant [Wed, 5 Mar 2008 22:50:00 +0000 (22:50 +0000)]
Add the nmenuselect makefile targets.  This is a newt menuselect interface which
was written by seanbright.  It is much sexier than my curses one.  :)

(issue #12139)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106240 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 106235 via svnmerge from
Joshua Colp [Wed, 5 Mar 2008 22:43:22 +0000 (22:43 +0000)]
Merged revisions 106235 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106235 | file | 2008-03-05 18:32:10 -0400 (Wed, 05 Mar 2008) | 4 lines

Add a control frame to indicate the source of media has changed. Depending on the underlying technology it may need to change some things.
(closes issue #12148)
Reported by: jcomellas

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106239 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 106237 via svnmerge from
Russell Bryant [Wed, 5 Mar 2008 22:40:58 +0000 (22:40 +0000)]
Merged revisions 106237 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106237 | russell | 2008-03-05 16:37:09 -0600 (Wed, 05 Mar 2008) | 3 lines

Fix a potential deadlock and a few different potential crashes.
(closes issue #12145, reported by thiagarcia, patched by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106238 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdding the Atxfer manager command. With this, you may initiate
Mark Michelson [Wed, 5 Mar 2008 22:33:05 +0000 (22:33 +0000)]
Adding the Atxfer manager command. With this, you may initiate
an attended transfer over AMI

(closes issue #10585)
Reported by: ornati
Patches:
      atxfer-trunk-r90428.diff uploaded by ornati (license 210)
  (with modifications from me)
Tested by: putnopvut

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106236 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agodocument var_metric usage to prevent bugreports that are actually configuration issues
Michiel van Baak [Wed, 5 Mar 2008 21:19:06 +0000 (21:19 +0000)]
document var_metric usage to prevent bugreports that are actually configuration issues

(closes issue #12151)
Reported by: caio1982
Patches:
      DB_metric3.diff uploaded by caio1982 (license 22)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106186 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 106178 via svnmerge
Michiel van Baak [Wed, 5 Mar 2008 21:15:57 +0000 (21:15 +0000)]
Blocked revisions 106178 via svnmerge

........
r106178 | mvanbaak | 2008-03-05 22:12:36 +0100 (Wed, 05 Mar 2008) | 5 lines

document var_metric so no bugreports will come in when it's actually a configuration issue.
(issue #12151)
Reported and patched by: caio1982
1.4 patch by me

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106179 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoShould check these values for non-NULL before scanning.
Tilghman Lesher [Wed, 5 Mar 2008 17:40:42 +0000 (17:40 +0000)]
Should check these values for non-NULL before scanning.
(Closes issue #12147)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106139 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix code up to what it was meant to be.
Joshua Colp [Wed, 5 Mar 2008 16:39:22 +0000 (16:39 +0000)]
Fix code up to what it was meant to be.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106110 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoCreate a centralized configuration option for silencethreshold
Tilghman Lesher [Wed, 5 Mar 2008 16:23:44 +0000 (16:23 +0000)]
Create a centralized configuration option for silencethreshold
(closes issue #11236)
 Reported by: philipps
 Patches:
       20080218__bug11236.diff.txt uploaded by Corydon76 (license 14)
 Tested by: philipps

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106072 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 106038 via svnmerge from
Kevin P. Fleming [Wed, 5 Mar 2008 15:40:40 +0000 (15:40 +0000)]
Merged revisions 106038 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106038 | kpfleming | 2008-03-05 09:32:35 -0600 (Wed, 05 Mar 2008) | 7 lines

when a PRI call must be moved to a different B channel at the request of the other endpoint, ensure that any DSP active on the original channel is moved to the new one

(closes issue #11917)
Reported by: mavetju
Tested by: mavetju

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106040 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 106015 via svnmerge from
Tilghman Lesher [Wed, 5 Mar 2008 15:23:32 +0000 (15:23 +0000)]
Merged revisions 106015 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106015 | tilghman | 2008-03-05 09:17:16 -0600 (Wed, 05 Mar 2008) | 7 lines

Correctly initialize retransid in SIP, and ensure that the warning when failing to delete a schedule entry can actually hit the log.
(closes issue #12140)
 Reported by: slavon
 Patches:
       sch2.patch uploaded by slavon (license 288)
(Patch slightly modified by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106036 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years ago - simplify a few statements with ARRAY_LEN()
Russell Bryant [Wed, 5 Mar 2008 04:34:29 +0000 (04:34 +0000)]
 - simplify a few statements with ARRAY_LEN()
 - constify the stregy int to string mappings array

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105984 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 105932 via svnmerge from
Russell Bryant [Wed, 5 Mar 2008 01:54:16 +0000 (01:54 +0000)]
Merged revisions 105932 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105932 | russell | 2008-03-04 19:52:18 -0600 (Tue, 04 Mar 2008) | 5 lines

Fix a bug that I just noticed in the RTP code.  The calculation for setting the
len field in an ast_frame of audio was wrong when G.722 is in use.  The len field
represents the number of ms of audio that the frame contains.  It would have
set the value to be twice what it should be.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105933 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix the SHARED() read callback to properly unlock the channel. This function
Russell Bryant [Wed, 5 Mar 2008 00:45:39 +0000 (00:45 +0000)]
Fix the SHARED() read callback to properly unlock the channel.  This function
could not have worked, as it left the channel locked in all cases.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105899 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoThere are several places in manager.c where BUFSIZ is used for a buffer
Mark Michelson [Tue, 4 Mar 2008 23:24:56 +0000 (23:24 +0000)]
There are several places in manager.c where BUFSIZ is used for a buffer
which will contain nowhere near that amount of data. This makes these buffers
more reasonably sized.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105864 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix minor misuses of snprintf
Tilghman Lesher [Tue, 4 Mar 2008 23:10:45 +0000 (23:10 +0000)]
Fix minor misuses of snprintf

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105841 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoWhitespace changes only
Tilghman Lesher [Tue, 4 Mar 2008 23:04:29 +0000 (23:04 +0000)]
Whitespace changes only

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105840 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoadd a destroy API call for a server instance
Russell Bryant [Tue, 4 Mar 2008 22:28:03 +0000 (22:28 +0000)]
add a destroy API call for a server instance

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105804 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMore public API name changes to use an appropriate ast_ prefix
Russell Bryant [Tue, 4 Mar 2008 22:23:21 +0000 (22:23 +0000)]
More public API name changes to use an appropriate ast_ prefix

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105785 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRename public object server_instance to ast_tcptls_server_instance
Russell Bryant [Tue, 4 Mar 2008 22:15:18 +0000 (22:15 +0000)]
Rename public object server_instance to ast_tcptls_server_instance

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105773 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix some bugs in the SIP tcp helper thread.
Russell Bryant [Tue, 4 Mar 2008 20:36:16 +0000 (20:36 +0000)]
Fix some bugs in the SIP tcp helper thread.
 - fix a spot where a lock wouldn't get unlocked in an error condition
 - call ast_mutex_destroy() on the lock before freeing its memory

(related to issue #11972)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105734 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoSet username to default to the category name if it isn't overridden by a usernmae...
Terry Wilson [Tue, 4 Mar 2008 20:32:55 +0000 (20:32 +0000)]
Set username to default to the category name if it isn't overridden by a usernmae= setting in users.conf

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105733 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 105676 via svnmerge from
Joshua Colp [Tue, 4 Mar 2008 18:11:38 +0000 (18:11 +0000)]
Merged revisions 105676 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105676 | file | 2008-03-04 14:10:34 -0400 (Tue, 04 Mar 2008) | 2 lines

In addition to setting the marker bit let's change our ssrc so they know for sure it is a different source.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105677 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 105674 via svnmerge from
Joshua Colp [Tue, 4 Mar 2008 18:08:42 +0000 (18:08 +0000)]
Merged revisions 105674 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105674 | file | 2008-03-04 14:05:28 -0400 (Tue, 04 Mar 2008) | 8 lines

When a new source of audio comes in (such as music on hold) make sure the marker bit gets set.
(closes issue #10355)
Reported by: wdecarne
Patches:
      10355.diff uploaded by file (license 11)
(closes issue #11491)
Reported by: kanderson

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105675 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUpdate CHANGES heading
Russell Bryant [Tue, 4 Mar 2008 16:55:17 +0000 (16:55 +0000)]
Update CHANGES heading

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105597 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoSimplify a trivial snprintf() with ast_copy_string()
Russell Bryant [Tue, 4 Mar 2008 04:57:29 +0000 (04:57 +0000)]
Simplify a trivial snprintf() with ast_copy_string()

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105595 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMake it so you don't have to cast away const in a couple places
Russell Bryant [Tue, 4 Mar 2008 04:47:32 +0000 (04:47 +0000)]
Make it so you don't have to cast away const in a couple places

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105594 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoremove unnecessary casts
Russell Bryant [Tue, 4 Mar 2008 04:44:28 +0000 (04:44 +0000)]
remove unnecessary casts

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105593 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 105591 via svnmerge
Russell Bryant [Tue, 4 Mar 2008 04:31:53 +0000 (04:31 +0000)]
Blocked revisions 105591 via svnmerge

........
r105591 | russell | 2008-03-03 22:31:29 -0600 (Mon, 03 Mar 2008) | 4 lines

Backport a minor bug fix from trunk that I found while doing random code
cleanup.  Properly break out of the loop when a context isn't found when
verify that includes are valid.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105592 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years ago - Add curly braces around the while loop
Russell Bryant [Tue, 4 Mar 2008 04:28:48 +0000 (04:28 +0000)]
 - Add curly braces around the while loop
 - Properly break out of the loop on error when an included context is not found

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105590 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUse ast_copy_string() instead of strncpy(), and use sizeof() instead of
Russell Bryant [Tue, 4 Mar 2008 04:26:39 +0000 (04:26 +0000)]
Use ast_copy_string() instead of strncpy(), and use sizeof() instead of
a magic number

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105589 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix some code that was improperly changed in revision 104866 from issue #12079.
Russell Bryant [Mon, 3 Mar 2008 18:49:34 +0000 (18:49 +0000)]
Fix some code that was improperly changed in revision 104866 from issue #12079.

(closes issue #12129, reported by elguero, patched by me)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105574 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 105572 via svnmerge from
Jason Parker [Mon, 3 Mar 2008 18:08:05 +0000 (18:08 +0000)]
Merged revisions 105572 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105572 | qwell | 2008-03-03 12:06:52 -0600 (Mon, 03 Mar 2008) | 7 lines

Fix types for astNumChannels and astConfigCallsProcessed.

(closes issue #12114)
Reported by: jeffg
Patches:
      12114.patch uploaded by jeffg (license 192)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105573 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 105570 via svnmerge from
Russell Bryant [Mon, 3 Mar 2008 17:17:27 +0000 (17:17 +0000)]
Merged revisions 105570 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105570 | russell | 2008-03-03 11:16:53 -0600 (Mon, 03 Mar 2008) | 3 lines

In the case of an ast_channel allocation failure, take the local_pvt out of the
pvt list before destroying it.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105571 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 105568 via svnmerge from
Russell Bryant [Mon, 3 Mar 2008 17:06:35 +0000 (17:06 +0000)]
Merged revisions 105568 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105568 | russell | 2008-03-03 11:05:16 -0600 (Mon, 03 Mar 2008) | 3 lines

Fix a potential memory leak of the local_pvt struct when ast_channel allocation
fails.  Also, in passing, centralize the code necessary to destroy a local_pvt.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105569 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 105565 via svnmerge from
Russell Bryant [Mon, 3 Mar 2008 16:02:19 +0000 (16:02 +0000)]
Merged revisions 105565 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105565 | russell | 2008-03-03 10:01:50 -0600 (Mon, 03 Mar 2008) | 3 lines

Update the copyright information for autoservice.  Most of the code in this file
now is stuff that I have written recently ...

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105566 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years ago3) In addition to merging the changes below, change trunk back to a regular
Russell Bryant [Mon, 3 Mar 2008 15:59:50 +0000 (15:59 +0000)]
3) In addition to merging the changes below, change trunk back to a regular
   LIST instead of an RWLIST.  The way this list works makes it such that
   a RWLIST provides no additional benefit.  Also, a mutex is needed for
   use with the thread condition.

Merged revisions 105563 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105563 | russell | 2008-03-03 09:50:43 -0600 (Mon, 03 Mar 2008) | 24 lines

Merge in some changes from team/russell/autoservice-nochans-1.4

These changes fix up some dubious code that I came across while auditing what
happens in the autoservice thread when there are no channels currently in
autoservice.

1) Change it so that autoservice thread doesn't keep looping around calling
   ast_waitfor_n() on 0 channels twice a second.  Instead, use a thread condition
   so that the thread properly goes to sleep and does not wake up until a
   channel is put into autoservice.

   This actually fixes an interesting bug, as well.  If the autoservice thread
   is already running (almost always is the case), then when the thread goes
   from having 0 channels to have 1 channel to autoservice, that channel would
   have to wait for up to 1/2 of a second to have the first frame read from it.

2) Fix up the code in ast_waitfor_nandfds() for when it gets called with no
   channels and no fds to poll() on, such as was the case with the previous code
   for the autoservice thread.  In this case, the code would call alloca(0), and
   pass the result as the first argument to poll().  In this case, the 2nd
   argument to poll() specified that there were no fds, so this invalid pointer
   shouldn't actually get dereferenced, but, this code makes it explicit and
   ensures the pointers are NULL unless we have valid data to put there.

(related to issue #12116)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105564 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 105560 via svnmerge from
Joshua Colp [Mon, 3 Mar 2008 15:30:29 +0000 (15:30 +0000)]
Merged revisions 105560 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105560 | file | 2008-03-03 11:28:59 -0400 (Mon, 03 Mar 2008) | 7 lines

It is possible for no audio to pass between the current digit and next digit so expand logic that clears emulation to AST_FRAME_NULL.
(closes issue #11911)
Reported by: edgreenberg
Patches:
      v1-11911.patch uploaded by dimas (license 88)
Tested by: tbsky

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105561 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 105557 via svnmerge from
Joshua Colp [Mon, 3 Mar 2008 15:16:57 +0000 (15:16 +0000)]
Merged revisions 105557 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105557 | file | 2008-03-03 11:15:39 -0400 (Mon, 03 Mar 2008) | 6 lines

Add a comment to describe some logic.
(closes issue #12120)
Reported by: flefoll
Patches:
      chan_sip.c.br14.patch-just-a-comment uploaded by flefoll (license 244)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105558 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd support for 16KHz signed linear.
Joshua Colp [Sat, 1 Mar 2008 03:59:41 +0000 (03:59 +0000)]
Add support for 16KHz signed linear.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105509 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDrop bad property
Tilghman Lesher [Sat, 1 Mar 2008 02:03:51 +0000 (02:03 +0000)]
Drop bad property

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105479 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAsterisk, when parking can drop rights a caller when a parking timeout occurs. Also...
Terry Wilson [Sat, 1 Mar 2008 01:30:37 +0000 (01:30 +0000)]
Asterisk, when parking can drop rights a caller when a parking timeout occurs.  Also, when doing built-in attended transfers, sometimes incorrectly passes rights from the transferrer to the transferee.  This patch tries to fixes the parking issue and lays some groundwork for later fixing the transfer issue.

(closes issue #11520)
Reported by: pliew
Tested by: otherwiseguy

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105477 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd a "devstate change" CLI command to control custom device states. Also,
Russell Bryant [Sat, 1 Mar 2008 00:53:25 +0000 (00:53 +0000)]
Add a "devstate change" CLI command to control custom device states.  Also,
do some additional code cleanup and improvement in passing.

(closes issue #12106)
Reported by: nizon
Patches:
      devstate-patch.txt uploaded by nizon (license 415)
        -- Updated to trunk, and tab completion added by me

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105461 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoConvert to use ast_str
Tilghman Lesher [Fri, 29 Feb 2008 23:53:42 +0000 (23:53 +0000)]
Convert to use ast_str

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105411 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 105409 via svnmerge from
Russell Bryant [Fri, 29 Feb 2008 23:36:46 +0000 (23:36 +0000)]
Merged revisions 105409 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105409 | russell | 2008-02-29 17:34:32 -0600 (Fri, 29 Feb 2008) | 23 lines

Fix a major bug in autoservice.  There was a race condition in the handling of
the list of channels in autoservice.  The problem was that it was possible for
a channel to get removed from autoservice and destroyed, while the autoservice
thread was still messing with the channel.  This led to memory corruption, and
caused crashes.  This explains multiple backtraces I have seen that have
references to autoservice, but do to the nature of the issue (memory corruption),
could cause crashes in a number of areas.

(fixes the crash in BE-386)
(closes issue #11694)
(closes issue #11940)

The following issues could be related.  If you are the reporter of one of these,
please update to include this fix and try again.

(potentially fixes issue #11189)
(potentially fixes issue #12107)
(potentially fixes issue #11573)
(potentially fixes issue #12008)
(potentially fixes issue #11189)
(potentially fixes issue #11993)
(potentially fixes issue #11791)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105410 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd documentation for setting username/password in SIP dial string.
Joshua Colp [Fri, 29 Feb 2008 18:34:46 +0000 (18:34 +0000)]
Add documentation for setting username/password in SIP dial string.
(closes issue #11587)
Reported by: sobomax
Patches:
      dialstring_doc.diff uploaded by sobomax (license 359)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105378 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 105326 via svnmerge from
Philippe Sultan [Fri, 29 Feb 2008 14:50:40 +0000 (14:50 +0000)]
Merged revisions 105326 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105326 | phsultan | 2008-02-29 15:47:10 +0100 (Fri, 29 Feb 2008) | 1 line

Fix a potential memory leak
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105327 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRemove unnecessary if statements before calling iks_delete (redundant check is
Philippe Sultan [Fri, 29 Feb 2008 14:15:03 +0000 (14:15 +0000)]
Remove unnecessary if statements before calling iks_delete (redundant check is
done inside iks_delete), thus making the code conform with coding guidelines.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105263 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 105261 via svnmerge from
Joshua Colp [Fri, 29 Feb 2008 13:55:22 +0000 (13:55 +0000)]
Merged revisions 105261 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105261 | file | 2008-02-29 09:48:13 -0400 (Fri, 29 Feb 2008) | 4 lines

Bump up the size of the uniqueid variable.
(closes issue #12107)
Reported by: asgaroth

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105262 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAutomatically create new buddy upon reception of a presence stanza of
Philippe Sultan [Fri, 29 Feb 2008 13:12:34 +0000 (13:12 +0000)]
Automatically create new buddy upon reception of a presence stanza of
type subscribed.

(closes issue #12066)
Reported by: ffadaie
Patches:
      branch-1.4-12066-1.diff uploaded by phsultan (license 73)
      trunk-12066-1.diff uploaded by phsultan (license 73)
Tested by: ffadaie, phsultan

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105210 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 105113 via svnmerge from
Tilghman Lesher [Fri, 29 Feb 2008 01:15:20 +0000 (01:15 +0000)]
Merged revisions 105113 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105113 | tilghman | 2008-02-28 15:56:54 -0600 (Thu, 28 Feb 2008) | 7 lines

Update init script for LSB compat
(closes issue #9843)
 Reported by: ibc
 Patches:
       rc.debian.asterisk.patch uploaded by ibc (license 211)
 Tested by: paravoid

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105176 65c4cc65-6c06-0410-ace0-fbb531ad65f3