21 months agores_stasis_mailbox.c: Fix leak of mailbox container.
Richard Mudgett [Wed, 1 Nov 2017 23:58:08 +0000 (18:58 -0500)]
res_stasis_mailbox.c: Fix leak of mailbox container.

Change-Id: I7d33c1635713047e7d1597c9d882f7dc006d94b4

21 months agoMerge "res_pjsip: Add to list of valid characters for from_user."
Joshua Colp [Fri, 3 Nov 2017 14:06:47 +0000 (09:06 -0500)]
Merge "res_pjsip: Add to list of valid characters for from_user."

21 months agoMerge "Modules: Additional improvements to CLI completion."
Joshua Colp [Fri, 3 Nov 2017 12:55:27 +0000 (07:55 -0500)]
Merge "Modules: Additional improvements to CLI completion."

21 months agoMerge "res/ari/resource_bridges.h: Update from 'make ari-stubs'."
Joshua Colp [Thu, 2 Nov 2017 19:08:41 +0000 (14:08 -0500)]
Merge "res/ari/resource_bridges.h: Update from 'make ari-stubs'."

21 months agores_pjsip: Add to list of valid characters for from_user.
Ben Ford [Wed, 1 Nov 2017 16:12:45 +0000 (11:12 -0500)]
res_pjsip: Add to list of valid characters for from_user.

Fixes a regression where some characters were unable to be used in
the from_user field of an endpoint. Additionally, the backtick was
removed from the list of valid characters, since it is not valid,
and it was replaced with a single quote, which is a valid character.


Change-Id: Id80c10a644508365c87b3182e99ea49da11b0281

21 months agoMerge "core: Don't attempt to write to a stream that does not exist."
Joshua Colp [Thu, 2 Nov 2017 16:09:41 +0000 (11:09 -0500)]
Merge "core: Don't attempt to write to a stream that does not exist."

21 months agocore: Don't attempt to write to a stream that does not exist.
Joshua Colp [Thu, 2 Nov 2017 10:34:46 +0000 (07:34 -0300)]
core: Don't attempt to write to a stream that does not exist.

When a frame is provided to ast_write ensure that a multistream
capable channel has a stream for it before attempting to give it
to the channel driver. In some cases (such as a deferred SDP
negotiation) the stream may not yet exist.


Change-Id: Icf84ca982a67cdd6e9a71851eb7eb1bd0e865276

21 months agores/ari/resource_bridges.h: Update from 'make ari-stubs'.
Corey Farrell [Thu, 2 Nov 2017 03:57:28 +0000 (23:57 -0400)]
res/ari/resource_bridges.h: Update from 'make ari-stubs'.

A comment was updated when I ran 'make ari-stubs'.

Change-Id: Ib5154ae3ad72aff53374c28ead540fe349c42175

21 months agoModules: Additional improvements to CLI completion.
Corey Farrell [Mon, 30 Oct 2017 22:30:18 +0000 (18:30 -0400)]
Modules: Additional improvements to CLI completion.

Replace 'needsreload' argument with a 'type' argument to specify which
type of modules you want completion.  This provides more accurate CLI
completion for load and unload commands.

* 'module unload' now excludes modules that have active references or are
  not running.
* 'module load' now excludes modules that are already running.
* 'core set debug [atleast] <level> [module]' shows running modules only.


Change-Id: Iea3e00054461484196c46f688f02635cc886bad1

21 months agopjsip_message_filter: Only do interface lookup for wildcard addresses.
Sean Bright [Wed, 1 Nov 2017 18:58:32 +0000 (14:58 -0400)]
pjsip_message_filter: Only do interface lookup for wildcard addresses.

Change-Id: Ie083987e69dc43b6861671c218cacacc11b2072f

21 months agoMerge "features: Bridge application's BRIDGERESULT not appropriately set"
Joshua Colp [Wed, 1 Nov 2017 14:22:17 +0000 (09:22 -0500)]
Merge "features: Bridge application's BRIDGERESULT not appropriately set"

21 months agoMerge "res_ari_channels: Fix reference leak in channel_state_invalid."
Joshua Colp [Wed, 1 Nov 2017 12:42:08 +0000 (07:42 -0500)]
Merge "res_ari_channels: Fix reference leak in channel_state_invalid."

21 months agofeatures: Bridge application's BRIDGERESULT not appropriately set
Kevin Harwell [Tue, 31 Oct 2017 20:08:38 +0000 (15:08 -0500)]
features: Bridge application's BRIDGERESULT not appropriately set

The dialplan application "Bridge" was not setting the BRIDGERESULT to failure
when a failure did occur. Even worse if it did fail to join the bridge it would
still report success.

This patch now sets the BRIDGERESULT variable to an appropriate value for a
given condition state. Also, removed the value INCOMPATIBLE as a valid result
type since it is no longer used.

ASTERISK-27369 #close

Change-Id: I22588e7125a765edf35cff28c98ca143e9927554

21 months agoMerge "Build System: Fix --disable-xmldoc option."
Joshua Colp [Tue, 31 Oct 2017 20:14:53 +0000 (15:14 -0500)]
Merge "Build System: Fix --disable-xmldoc option."

21 months agores_ari_channels: Fix reference leak in channel_state_invalid.
Corey Farrell [Tue, 31 Oct 2017 18:18:45 +0000 (14:18 -0400)]
res_ari_channels: Fix reference leak in channel_state_invalid.

channel_state_invalid leaked a reference to the channel snapshot any
time it was aquired.

ASTERISK-27067 #close

Change-Id: I8c653f00416b39978513c5605c4be0f03b1df29a

21 months agoMerge "core / pjsip: Add support for grouping streams together."
Joshua Colp [Tue, 31 Oct 2017 18:27:40 +0000 (13:27 -0500)]
Merge "core / pjsip: Add support for grouping streams together."

21 months agoMerge "ast_coredumper: allow setting asterisk binary explicitly"
Joshua Colp [Tue, 31 Oct 2017 11:48:16 +0000 (06:48 -0500)]
Merge "ast_coredumper: allow setting asterisk binary explicitly"

21 months agoMerge "Modules: Fix issues with CLI completion."
Joshua Colp [Mon, 30 Oct 2017 22:18:59 +0000 (17:18 -0500)]
Merge "Modules: Fix issues with CLI completion."

21 months agocore / pjsip: Add support for grouping streams together.
Joshua Colp [Wed, 25 Oct 2017 22:31:33 +0000 (22:31 +0000)]
core / pjsip: Add support for grouping streams together.

In WebRTC streams (or media tracks in their world) can be grouped
together using the mslabel. This informs the browser that each
should be synchronized with each other.

This change extends the stream API so this information can
be stored with streams. The PJSIP support has been extended
to use the mslabel to determine grouped streams and store
this association on the streams. Finally when creating the
SDP the group information is used to cause each media stream
to use the same mslabel.


Change-Id: Id6299aa031efe46254edbdc7973c534d54d641ad

21 months agoMerge "alembic: Add bundle column in ps_endpoints table"
Joshua Colp [Mon, 30 Oct 2017 16:56:56 +0000 (11:56 -0500)]
Merge "alembic: Add bundle column in ps_endpoints table"

21 months agoMerge "app_agent_spool: Fix typo in dtmf features usage desctiption"
Joshua Colp [Mon, 30 Oct 2017 16:08:52 +0000 (11:08 -0500)]
Merge "app_agent_spool: Fix typo in dtmf features usage desctiption"

21 months agoMerge "ast_coredumper: Add gzipping of binaries and display of signal info"
Joshua Colp [Mon, 30 Oct 2017 15:53:42 +0000 (10:53 -0500)]
Merge "ast_coredumper:  Add gzipping of binaries and display of signal info"

21 months agoast_coredumper: allow setting asterisk binary explicitly
Tzafrir Cohen [Mon, 30 Oct 2017 14:20:18 +0000 (16:20 +0200)]
ast_coredumper: allow setting asterisk binary explicitly

Adds an extra option, --asterisk-bin=<path> to ast_coredumper. If
provided, the binary given to gdb will be the parameter, rather than
asterisk from the PATH.

ASTERISK-27380 #close

Change-Id: I25f5b91eb75059b0fb2f142e468c26b283b0a9f3

21 months agoalembic: Add bundle column in ps_endpoints table
Florian Floimair [Wed, 25 Oct 2017 06:10:29 +0000 (08:10 +0200)]
alembic: Add bundle column in ps_endpoints table

The ps_endpoints table was missing the bundle column
introduced with the bundle feature in
commit 065c3005ad92.

ASTERISK-27374 #close

Change-Id: Ic900f4f2c20f64b99ea898d50f5c0a7117472d46

21 months agoModules: Fix issues with CLI completion.
Corey Farrell [Mon, 30 Oct 2017 05:32:32 +0000 (01:32 -0400)]
Modules: Fix issues with CLI completion.

* Stop using ast_module_helper to check if a module is loaded, use
  ast_module_check instead (app_confbridge and app_meetme).
* Stop ast_module_helper from listing reload classes when needsreload
  was not requested.


Change-Id: Iaed8c1e4fcbeb242921dbac7929a0fe75ff4b239

21 months agoapp_agent_spool: Fix typo in dtmf features usage desctiption
Igor Goncharovskiy [Sun, 29 Oct 2017 00:18:21 +0000 (06:18 +0600)]
app_agent_spool: Fix typo in dtmf features usage desctiption

Fix typo, that specify usage wrong option 'dtmf-features' for CHANNEL() function
instead of correct 'dtmf_features'

ASTERISK-27377 #close

Change-Id: I15ecc829c1035b359584673e12cdb5c9291ac930

21 months agores_pjsip_pubsub: Resolve potential crash in allocate_subscription.
Corey Farrell [Fri, 27 Oct 2017 18:41:15 +0000 (14:41 -0400)]
res_pjsip_pubsub: Resolve potential crash in allocate_subscription.

When allocate_subscription fails to initialize fields of the new sub it
calls destroy_subscription.

Change-Id: I5b79c915ec216dc00c13c1e4172137864a4bec85

21 months agoMerge "codec.c: Defensively check the returned samples."
Joshua Colp [Fri, 27 Oct 2017 14:19:11 +0000 (09:19 -0500)]
Merge "codec.c: Defensively check the returned samples."

21 months agoMerge "app_voicemail.c: Fix compiler warning with IMAP build."
Joshua Colp [Fri, 27 Oct 2017 13:41:09 +0000 (08:41 -0500)]
Merge "app_voicemail.c: Fix compiler warning with IMAP build."

21 months agoMerge "res_pjsip: Add 'ip' as a valid option to 'identify_by' on endpoint."
Joshua Colp [Thu, 26 Oct 2017 23:45:40 +0000 (18:45 -0500)]
Merge "res_pjsip: Add 'ip' as a valid option to 'identify_by' on endpoint."

21 months agoapp_voicemail.c: Fix compiler warning with IMAP build.
Richard Mudgett [Thu, 26 Oct 2017 17:18:00 +0000 (12:18 -0500)]
app_voicemail.c: Fix compiler warning with IMAP build.


Change-Id: Ic4468b49860bd7f67e922baf4c9e96828c184d17

21 months agocodec.c: Defensively check the returned samples.
Richard Mudgett [Wed, 25 Oct 2017 19:38:19 +0000 (14:38 -0500)]
codec.c: Defensively check the returned samples.

Earlier versions of the codec_opus samples_count callback can return
negative error values on undecodable frames.  This resulted in a divide by
zero exception.

* Added a defensive check in ast_codec_samples_count() for a "negative"
samples count return value.  Log the event and set the count to zero.


Change-Id: Icf69350307ecbbc80a3d74de46af9bd80ea17819

21 months agoMerge "Single API for ast_store_lock_info and ast_remove_lock_info."
Joshua Colp [Wed, 25 Oct 2017 23:09:16 +0000 (18:09 -0500)]
Merge "Single API for ast_store_lock_info and ast_remove_lock_info."

21 months agores_pjsip: Add 'ip' as a valid option to 'identify_by' on endpoint.
Joshua Colp [Tue, 24 Oct 2017 15:33:57 +0000 (15:33 +0000)]
res_pjsip: Add 'ip' as a valid option to 'identify_by' on endpoint.

When the identify_by option on an endpoint is set to ip it will
only be identified using the res_pjsip_endpoint_identifier_ip module.
This ensures that it is not mistakenly matched using the username of
the From header. To ensure behavior has not changed the default has
been changed to "username,ip" for the identify_by option.


Change-Id: I2170b86a7f7e221b4f00bf14aa1ef1ac5b050bbd

22 months agoast_coredumper: Add gzipping of binaries and display of signal info
George Joseph [Wed, 25 Oct 2017 17:26:06 +0000 (11:26 -0600)]
ast_coredumper:  Add gzipping of binaries and display of signal info

The --tarball-coredump option now creates a gzipped tarball of
coredumps processed, their results txt files and copies of
/etc/os-release, /usr/sbin/asterisk, /usr/lib(64)/libasterisk* and
/usr/lib(64)/asterisk as those files are needed to properly examine
the coredump.  The file will be named
/tmp/asterisk.<timestamp>.coredumps.tar.gz or
/tmp/asterisk-<uniqueid>.coredumps.tar.gz if --tarball-uniqueid was

Added dumps of *_siginfo to the top of the txt files so you can
tell what signal was invoked.

Change-Id: Ib9ee6d83592d4b1bc90cb3419a05376a88d1ded9

22 months agohttp.c: Fix http header send content.
Ben Ford [Wed, 25 Oct 2017 14:23:55 +0000 (09:23 -0500)]
http.c: Fix http header send content.

Currently ast_http_send barricades a portion of the content that
needs to be sent in order to establish a connection for things
like the ARI client. The conditional and contents have been changed
to ensure that everything that needs to be sent, will be sent.


Change-Id: I8816d2d8f80f4fefc6dcae4b5fdfc97f1e46496d

22 months agoBuild System: Fix --disable-xmldoc option.
Corey Farrell [Thu, 30 Mar 2017 14:51:14 +0000 (10:51 -0400)]
Build System: Fix --disable-xmldoc option.

The configure option to disable XML documentation does not currently
work.  This patch makes it effective, but also causes an ABI change by
removing the ast_xmldoc_* symbols.  Disabling xmldoc also prevents docs
from being automatically generated, but they can still be manually
generated with 'make doc/core-en_US.xml'.


Change-Id: Ifac562340c09f80c83e0203de098fcac93bf8c44

22 months agoMerge "Bundled pjproject: Enable pj_assert when dev-mode is enabled."
Joshua Colp [Wed, 25 Oct 2017 14:03:19 +0000 (09:03 -0500)]
Merge "Bundled pjproject: Enable pj_assert when dev-mode is enabled."

22 months agoMerge "chan_sip: Fix SUBSCRIBE with missing "Expires" header."
Joshua Colp [Wed, 25 Oct 2017 13:17:40 +0000 (08:17 -0500)]
Merge "chan_sip: Fix SUBSCRIBE with missing "Expires" header."

22 months agoMerge "hashtab: Use ast_free."
Joshua Colp [Wed, 25 Oct 2017 12:34:23 +0000 (07:34 -0500)]
Merge "hashtab: Use ast_free."

22 months agoMerge "res_pjsip_sdp_rtp: Fix setting of address type for rtp_ipv6"
Joshua Colp [Wed, 25 Oct 2017 11:39:29 +0000 (06:39 -0500)]
Merge "res_pjsip_sdp_rtp:  Fix setting of address type for rtp_ipv6"

22 months agoMerge "main/Makefile: Remove rule for non-existant testexpr2."
Joshua Colp [Wed, 25 Oct 2017 10:24:52 +0000 (05:24 -0500)]
Merge "main/Makefile: Remove rule for non-existant testexpr2."

22 months agoMerge "res_xmpp: Ensure the connection filter is available."
Joshua Colp [Tue, 24 Oct 2017 20:40:54 +0000 (15:40 -0500)]
Merge "res_xmpp: Ensure the connection filter is available."

22 months agoSingle API for ast_store_lock_info and ast_remove_lock_info.
Corey Farrell [Mon, 23 Oct 2017 05:55:18 +0000 (01:55 -0400)]
Single API for ast_store_lock_info and ast_remove_lock_info.

This makes the 'bt' parameter unconditional for ast_store_lock_info and
ast_remove_lock_info.  The 'bt' parameter is unused when HAVE_BKTR is

Change-Id: Ieced0e920928b735a39c3b5952b806c473d67453

22 months agoMerge "lpc10: Avoid compiler warning when DONT_OPTIMIZE/COMPILE_DOUBLE."
George Joseph [Tue, 24 Oct 2017 19:26:15 +0000 (14:26 -0500)]
Merge "lpc10: Avoid compiler warning when DONT_OPTIMIZE/COMPILE_DOUBLE."

22 months agoMerge "test_config: Fix failure and segfault when config_hook is run twice."
Joshua Colp [Tue, 24 Oct 2017 18:56:43 +0000 (13:56 -0500)]
Merge "test_config: Fix failure and segfault when config_hook is run twice."

22 months agochan_sip: Fix SUBSCRIBE with missing "Expires" header.
Corey Farrell [Tue, 24 Oct 2017 14:43:15 +0000 (10:43 -0400)]
chan_sip: Fix SUBSCRIBE with missing "Expires" header.

When chan_sip receives a SUBSCRIBE request with no "Expires" header it
processes the request as an unsubscribe.  This is incorrect, per RFC3264
when the "Expires" header is missing a default expiry should be used.


Change-Id: Ibf6dcd4fdd07a32c2bc38be1dd557981f08188b5

22 months agoMerge "res_pjproject.c: Upgrade bundled PJPROJECT to 2.7"
Joshua Colp [Tue, 24 Oct 2017 15:04:24 +0000 (10:04 -0500)]
Merge "res_pjproject.c: Upgrade bundled PJPROJECT to 2.7"

22 months agoMerge "chan_sip: Crypto attribute not last but first on SDP media level."
Joshua Colp [Tue, 24 Oct 2017 14:28:36 +0000 (09:28 -0500)]
Merge "chan_sip: Crypto attribute not last but first on SDP media level."

22 months agolpc10: Avoid compiler warning when DONT_OPTIMIZE/COMPILE_DOUBLE.
Alexander Traud [Tue, 24 Oct 2017 12:24:17 +0000 (14:24 +0200)]
lpc10: Avoid compiler warning when DONT_OPTIMIZE/COMPILE_DOUBLE.

Reported by: Marcello Ceschia

Change-Id: Ic27e88e0336a0d83877dc857938659dc5560b93c

22 months agohashtab: Use ast_free.
Corey Farrell [Sat, 7 Oct 2017 17:14:08 +0000 (13:14 -0400)]
hashtab: Use ast_free.

A few places in hashtab use free instead of ast_free, remove declaration
of ASTMM_LIBC from hashtab.c as it's no longer needed.

Change-Id: I2ff089bad71640c03c3ce97f1b00fc962ef79427

22 months agoBundled pjproject: Enable pj_assert when dev-mode is enabled.
Corey Farrell [Mon, 23 Oct 2017 06:02:22 +0000 (02:02 -0400)]
Bundled pjproject: Enable pj_assert when dev-mode is enabled.


Change-Id: Ib01fb6c01f9bb87129374a51cb9318c474147517

22 months agomain/Makefile: Remove rule for non-existant testexpr2.
Corey Farrell [Mon, 23 Oct 2017 18:44:36 +0000 (14:44 -0400)]
main/Makefile: Remove rule for non-existant testexpr2.

Change-Id: Ibb3e47f27a395d74d8c5263db015b05434f5969b

22 months agotest_config: Fix failure and segfault when config_hook is run twice.
Corey Farrell [Mon, 23 Oct 2017 17:42:37 +0000 (13:42 -0400)]
test_config: Fix failure and segfault when config_hook is run twice.

On second run the config_hook test was unexpectedly failing to load
test_config.conf because it was still unmodified since the last load.
This is fixed by not passing CONFIG_FLAG_FILEUNCHANGED for the initial
loads, only using it when we are tested that a reload of unmodified
files do not initiate the hook.


Change-Id: Ifd679509a23ed163e5cc647490bf7df4ae3cd856

22 months agores_pjsip_sdp_rtp: Fix setting of address type for rtp_ipv6
George Joseph [Mon, 23 Oct 2017 17:23:04 +0000 (11:23 -0600)]
res_pjsip_sdp_rtp:  Fix setting of address type for rtp_ipv6

create_outgoing_sdp_stream was setting "addr_type = STR_IP6" only
when an ipv6 media_address was specified on the endpoint.  If
rtp_ipv6 was set and ast_sip_get_host_ip_string returned an ipv6
address, we were leaving the addr_type set at the default of
STR_IP4.  This caused the address type to be set incorrectly on the
"o" and "c" SDP attributes even though the address was set
correctly.  Some clients don't like the mismatch.

 * Removed the test for endpoint/media_address and now check all
   addresses for ipv6.

Reported by: Martin Cis├írik

Change-Id: I5214fc31b728117842243807e7927a319cf77592

22 months agoMerge "bridge_softmix: Reduce topology cloning and improve renegotiation."
Joshua Colp [Mon, 23 Oct 2017 16:07:16 +0000 (11:07 -0500)]
Merge "bridge_softmix: Reduce topology cloning and improve renegotiation."

22 months agoapp_agent_pool.c: Fix online documentation typo.
Richard Mudgett [Mon, 23 Oct 2017 12:53:48 +0000 (07:53 -0500)]
app_agent_pool.c: Fix online documentation typo.

Change-Id: Ib0bc95fd0ec288c78c313823254d7a84ebfc4429

22 months agores_xmpp: Ensure the connection filter is available.
Joshua Colp [Sun, 22 Oct 2017 22:32:20 +0000 (19:32 -0300)]
res_xmpp: Ensure the connection filter is available.

Users of the API that res_xmpp provides expect that a
filter be available on the client at all times. When
OAuth authentication support was added this requirement
was not maintained.

This change merely moves the OAuth authentication to
after the filter is created, ensuring users of res_xmpp
can add things to the filter as needed.


Change-Id: I4ac474afe220e833288ff574e32e2b9a23394886

22 months agochan_sip: Crypto attribute not last but first on SDP media level.
Alexander Traud [Sat, 21 Oct 2017 08:44:21 +0000 (10:44 +0200)]
chan_sip: Crypto attribute not last but first on SDP media level.

This matches the behavior of the other SIP channel driver, chan_pjsip.


Change-Id: I8f23a51290a58b75816da2999ed1965441dfc5d6

22 months agores_pjproject.c: Upgrade bundled PJPROJECT to 2.7
Richard Mudgett [Tue, 17 Oct 2017 15:53:52 +0000 (10:53 -0500)]
res_pjproject.c: Upgrade bundled PJPROJECT to 2.7

Update patches included in bundled PJPROJECT for the new version.


Change-Id: I9ac5dbbffaadca25ad24fac8b9ab615e5ace6083

22 months agores_pjsip_pubsub: Prevent unload except during shutdown.
Corey Farrell [Wed, 18 Oct 2017 18:41:25 +0000 (14:41 -0400)]
res_pjsip_pubsub: Prevent unload except during shutdown.

Prevent unload of the module as certain pjsip initialization functions
cannot be reversed.  This required a reorder of the module_load so that
the non-reversable pjsip functions are not called until all potential
errors have been ruled out.


Change-Id: Iee900f20bdd6ee1bfe23efdec0d87765eadce8a7

22 months agoMerge "chan_sip: Fix output of 'sip set debug off'."
Joshua Colp [Thu, 19 Oct 2017 13:14:22 +0000 (08:14 -0500)]
Merge "chan_sip: Fix output of 'sip set debug off'."

22 months agoMerge "res_pjsip_refer: Prevent unload except during shutdown."
Joshua Colp [Thu, 19 Oct 2017 12:24:59 +0000 (07:24 -0500)]
Merge "res_pjsip_refer: Prevent unload except during shutdown."

22 months agoMerge "app_macro deprecation."
Joshua Colp [Thu, 19 Oct 2017 00:22:12 +0000 (19:22 -0500)]
Merge "app_macro deprecation."

22 months agores_pjsip_refer: Prevent unload except during shutdown.
Corey Farrell [Wed, 18 Oct 2017 18:37:57 +0000 (14:37 -0400)]
res_pjsip_refer: Prevent unload except during shutdown.

Prevent unload of the module as certain pjsip initialization functions
cannot be reversed.


Change-Id: I94597ec8b8491f5af9c57bf66dbc3b078fe2d49d

22 months agochan_sip: Fix output of 'sip set debug off'.
Corey Farrell [Wed, 18 Oct 2017 17:04:29 +0000 (13:04 -0400)]
chan_sip: Fix output of 'sip set debug off'.

When sip.conf contains 'sipdebug=yes' it is impossible to disable it
using CLI 'sip set debug off'.  This corrects the output of that CLI
command to instruct the user to turn sipdebug off in the configuration

ASTERISK-23462 #close

Change-Id: I1cceade9caa9578e1b060feb832e3495ef5ad318

22 months agoapp_macro deprecation.
Corey Farrell [Mon, 16 Oct 2017 15:53:07 +0000 (11:53 -0400)]
app_macro deprecation.

* Mark the module deprecated.
* Disable the module by default.
* Produce a warning the first time a macro is used.
* Note deprecation related options in app_dial and app_queue.


Change-Id: I560ea043bacdbc5534a17d97854273d52c2f1bdc

22 months agores_srtp: Add support for libsrtp2 with AES-GCM.
Alexander Traud [Wed, 18 Oct 2017 08:30:25 +0000 (10:30 +0200)]
res_srtp: Add support for libsrtp2 with AES-GCM.

Beside allowing AES-GCM again, this adds AES-192 again.


Change-Id: Ia97a435faf26300335d9552fa676b5d17e5f7233

22 months agoMerge "res_corosync: Fix linking issue with Corosync 2.x"
Jenkins2 [Tue, 17 Oct 2017 16:08:13 +0000 (11:08 -0500)]
Merge "res_corosync: Fix linking issue with Corosync 2.x"

22 months agoMerge "cdr.c: Rename the Party A CDR container."
Joshua Colp [Tue, 17 Oct 2017 16:06:16 +0000 (11:06 -0500)]
Merge "cdr.c: Rename the Party A CDR container."

22 months agoMerge "cdr.c: Add container to key off of Party B channel names."
Jenkins2 [Tue, 17 Oct 2017 15:44:34 +0000 (10:44 -0500)]
Merge "cdr.c: Add container to key off of Party B channel names."

22 months agoMerge "contrib/script/sip_to_pjsip: implement 'all' for allow/disallow"
Jenkins2 [Tue, 17 Oct 2017 14:32:00 +0000 (09:32 -0500)]
Merge "contrib/script/sip_to_pjsip: implement 'all' for allow/disallow"

22 months agoMerge "bridge_simple: Improve renegotiation success rate."
Jenkins2 [Tue, 17 Oct 2017 13:49:20 +0000 (08:49 -0500)]
Merge "bridge_simple: Improve renegotiation success rate."

22 months agoMerge "chan_dahdi: wrap include file which is not present on BSD systems in #ifdef"
Jenkins2 [Tue, 17 Oct 2017 13:21:12 +0000 (08:21 -0500)]
Merge "chan_dahdi: wrap include file which is not present on BSD systems in #ifdef"

22 months agoMerge "res_pjsip_session: Rewrite o= with external_media_address."
Jenkins2 [Tue, 17 Oct 2017 11:34:42 +0000 (06:34 -0500)]
Merge "res_pjsip_session: Rewrite o= with external_media_address."

22 months agobridge_softmix: Reduce topology cloning and improve renegotiation.
Joshua Colp [Sat, 14 Oct 2017 19:41:37 +0000 (19:41 +0000)]
bridge_softmix: Reduce topology cloning and improve renegotiation.

As channels join and leave an SFU the bridge_softmix module
needs to renegotiate to add and remove their streams from
the other participants. Previously this was done by constructing
the ideal stream topology every time but in the case of leave
this was incomplete.

This change makes it so bridge_softmix keeps an ideal stream
topology for each channel and uses it when making changes. This
ensures that when we request a renegotiation we are always
certain that we are aiming for the best stream topology
possible. In the case of a channel leaving this ensures that
we try to have an existing participant fill their place if
a participant has a fixed limit on the maximum number of video
streams they allow.


Change-Id: I58070f421ddeadd2844a33b869b052630cf2e514

22 months agocdr.c: Rename the Party A CDR container.
Richard Mudgett [Fri, 6 Oct 2017 20:55:26 +0000 (15:55 -0500)]
cdr.c: Rename the Party A CDR container.

* Rename the Party A CDR container from active_cdrs_by_channel to

* Renamed the support functions associated with active_cdrs_master


Change-Id: I6104bb3edc3a0b7243ce502e45e8832b0cff14f7

22 months agocdr.c: Add container to key off of Party B channel names.
Richard Mudgett [Mon, 2 Oct 2017 22:42:48 +0000 (17:42 -0500)]
cdr.c: Add container to key off of Party B channel names.

The CDR performance gets worse the further it gets behind in processing
stasis messages.  One of the reasons is because of a n*m loop used when
processing Party B information.

* Added a new CDR container that is keyed to Party B so we don't need such
a large loop when processing Party B information.

NOTE: To reduce the size of the patch I deferred to another patch the
renaming of the Party A active_cdrs_by_channel container to
active_cdrs_master and renaming the container's hash and cmp functions


Change-Id: I0bf66e8868f8adaa4b5dcf9e682e34951c350249

22 months agoMerge "declare optional openssl dependencies in moduleinfo"
Jenkins2 [Mon, 16 Oct 2017 14:19:56 +0000 (09:19 -0500)]
Merge "declare optional openssl dependencies in moduleinfo"

22 months agocontrib/script/sip_to_pjsip: implement 'all' for allow/disallow
Torrey Searle [Wed, 11 Oct 2017 11:04:12 +0000 (13:04 +0200)]
contrib/script/sip_to_pjsip: implement 'all' for allow/disallow

when 'all' is specified in an allow or disallow section, it should erase
all values from the inverse section in the default config. E.G.
allow=all should erase any deny values from default config &

ASTERISK-27333 #close

Change-Id: I99219478fb98f08751d769daaee0b7795118a5a6

22 months agoMerge "cdr.c: Eliminated many calls to ao2_global_obj_ref()."
Joshua Colp [Mon, 16 Oct 2017 10:45:11 +0000 (05:45 -0500)]
Merge "cdr.c: Eliminated many calls to ao2_global_obj_ref()."

22 months agoMerge "cdr.c: Defer getting ao2_global_obj_ref() until needed."
Joshua Colp [Mon, 16 Oct 2017 10:45:01 +0000 (05:45 -0500)]
Merge "cdr.c: Defer getting ao2_global_obj_ref() until needed."

22 months agoMerge "ast_bt_get_symbols: Prevent double-free."
Jenkins2 [Sun, 15 Oct 2017 19:52:57 +0000 (14:52 -0500)]
Merge "ast_bt_get_symbols: Prevent double-free."

22 months agoMerge "tcptls: NULL-check the parameter of ast_ssl_teardown before accessing it."
Joshua Colp [Sun, 15 Oct 2017 19:29:39 +0000 (14:29 -0500)]
Merge "tcptls: NULL-check the parameter of ast_ssl_teardown before accessing it."

22 months agochan_dahdi: wrap include file which is not present on BSD systems in #ifdef
Guido Falsi [Sat, 14 Oct 2017 09:11:24 +0000 (11:11 +0200)]
chan_dahdi: wrap include file which is not present on BSD systems in #ifdef

The sys/sysmacros.h include file does not exist in BSD systems and
is not required to build this module there.
Since an "#if defined(__NetBSD__) || defined(__FreeBSD__)" section
already exist I moved that include line inside it's #else branch.

ASTERISK-27343 #close

Change-Id: Ibfb64f4e9a0ce8b6eda7a7695cfe57916f175dc1

22 months agores_pjsip_session: Rewrite o= with external_media_address.
Alexander Traud [Fri, 13 Oct 2017 14:43:12 +0000 (16:43 +0200)]
res_pjsip_session: Rewrite o= with external_media_address.

PJSIP allows a domain name as external_media_address. This allows chan_pjsip to
be used behind a NAT with changing IP addresses. The IP address of that domain
is resolved to the c= line already. This change sets also the o= line to that

ASTERISK-27341 #close

Change-Id: I690163b6e762042ec38b3995aa5c9bea909d8ec4

22 months agoMerge "cdr.c: Set stringfields only if they are different."
Jenkins2 [Fri, 13 Oct 2017 22:42:49 +0000 (17:42 -0500)]
Merge "cdr.c: Set stringfields only if they are different."

22 months agobridge_simple: Improve renegotiation success rate.
Joshua Colp [Thu, 12 Oct 2017 17:03:45 +0000 (17:03 +0000)]
bridge_simple: Improve renegotiation success rate.

When making channels compatible the bridge_simple module
will renegotiate one to better match the other. Some
endpoints incorrectly terminate the call if this process

To better handle this scenario the audio streams present
on the new requested topology will include any existing
negotiated formats that happen to exist on the first
valid audio stream. This ensures formats are persent that
are known to be acceptable to the remote endpoint.


Change-Id: I8fc0cc03e8bcfd0be8302f13b9f32d8268977f43

22 months agoMerge "cdr.c: Fix setting dnid, callingsubaddr, and calledsubaddr"
Kevin Harwell [Fri, 13 Oct 2017 22:11:53 +0000 (17:11 -0500)]
Merge "cdr.c: Fix setting dnid, callingsubaddr, and calledsubaddr"

22 months agoast_bt_get_symbols: Prevent double-free.
Corey Farrell [Fri, 13 Oct 2017 13:51:09 +0000 (09:51 -0400)]
ast_bt_get_symbols: Prevent double-free.

It's possible for bfdobj to be created but syms not created.  If syms
was not allocated in the current loop iteration but was allocated in the
previous iteration it would crash.


Change-Id: I5b110c609f6dfe91339f782a99a431bca5837363

22 months agotcptls: NULL-check the parameter of ast_ssl_teardown before accessing it.
Alexander Traud [Fri, 13 Oct 2017 13:12:07 +0000 (15:12 +0200)]
tcptls: NULL-check the parameter of ast_ssl_teardown before accessing it.

This avoids a crash on stopping a chan_sip which failed to start its TLS server.

ASTERISK-27339 #close

Change-Id: I327fc70db68eaaca5b50a15c7fd687fde79263d5

22 months agocdr.c: Eliminated many calls to ao2_global_obj_ref().
Richard Mudgett [Fri, 29 Sep 2017 19:26:41 +0000 (14:26 -0500)]
cdr.c: Eliminated many calls to ao2_global_obj_ref().

The CDR performance gets worse the further it gets behind in processing
stasis messages.  One of the reasons is we were getting the global config
to determine if we needed to log a debugging message.

* Many calls to ao2_global_obj_ref() were just so we could determine if
debug mode is enabled.  Made a global flag to check instead.

* Eliminated many RAII_VAR() usages associated with the remaining
ao2_global_obj_ref() calls.

* Added missing NULL checks for the returned ao2_global_obj_ref() value.


Change-Id: Iceaad93172862f610cad0188956634187bfcc7cd

22 months agocdr.c: Defer getting ao2_global_obj_ref() until needed.
Richard Mudgett [Fri, 6 Oct 2017 18:45:30 +0000 (13:45 -0500)]
cdr.c: Defer getting ao2_global_obj_ref() until needed.

The CDR performance gets worse the further it gets behind in processing
stasis messages.  One of the reasons is we were getting the global config
even if we didn't need it.

* Most uses of the global config were only needed on off nominal code
paths so it makes sense to not get it until absolutely needed.


Change-Id: I00c63b7ec233e5bfffd5d976f05568613d3c2365

22 months agocdr.c: Set stringfields only if they are different.
Richard Mudgett [Thu, 5 Oct 2017 23:08:33 +0000 (18:08 -0500)]
cdr.c: Set stringfields only if they are different.

The CDR performance gets worse the further it gets behind in processing
stasis messages.  One of the reasons is we were repeatedly setting string
fields to potentially the same string in base_process_party_a().  Setting
a string field involves allocating room for the new string out of a memory
pool which may have to allocate even more memory.

* Check to see if the string field is already set to the desired string.


Change-Id: I3ccb7e23f1488417e08cafe477755033eed65a7c

22 months agocdr.c: Fix setting dnid, callingsubaddr, and calledsubaddr
Richard Mudgett [Thu, 5 Oct 2017 23:03:11 +0000 (18:03 -0500)]
cdr.c: Fix setting dnid, callingsubaddr, and calledsubaddr

The string comparisons for setting these CDR variables was inverted.  We
were repeatedly setting these CDR variables only if the channel snapshots
had the same value.


Change-Id: I9482073524411e7ea6c03805b16de200cb1669ea

22 months agofeatures, manager : Add CancelAtxfer AMI action
Thomas Sevestre [Fri, 25 Aug 2017 13:19:00 +0000 (13:19 +0000)]
features, manager : Add CancelAtxfer AMI action

Add action to cancel feature attended transfer with AMI interface

ASTERISK-27215 #close

Change-Id: Iab8a81362b5a1757e2608f70b014ef863200cb42

22 months agoMerge "res_pjsip_session: Prevent user=phone being added to anonimized URIs."
Jenkins2 [Thu, 12 Oct 2017 17:51:03 +0000 (12:51 -0500)]
Merge "res_pjsip_session: Prevent user=phone being added to anonimized URIs."

22 months agoMerge "sorcery: Use ao2_weakproxy to hold list of instances."
Jenkins2 [Thu, 12 Oct 2017 16:25:12 +0000 (11:25 -0500)]
Merge "sorcery: Use ao2_weakproxy to hold list of instances."

22 months agores_pjsip_session: Prevent user=phone being added to anonimized URIs.
Daniel Tryba [Fri, 6 Oct 2017 09:55:38 +0000 (11:55 +0200)]
res_pjsip_session: Prevent user=phone being added to anonimized URIs.

Move ast_sip_add_usereqphone to be called after anonymization of URIs,
to prevent the user_eq_phone adding "user=phone" to URIs containing a
username that is not a phonenumber (RFC3261 19.1.1). An extra call to
ast_sip_add_usereqphone on the saved version before anonymization is
added to add user=phone" to the PAI.

ASTERISK-27047 #close

Change-Id: Ie5644bc66341b86dc08b1f7442210de2e6acdec6

22 months agoMerge "named_locks: Use ao2_weakproxy_find."
Jenkins2 [Thu, 12 Oct 2017 15:16:45 +0000 (10:16 -0500)]
Merge "named_locks: Use ao2_weakproxy_find."