asterisk/asterisk.git
10 years agowhen --without-<foo> is passed to the configure script, explicitly inform menuselect...
Kevin P. Fleming [Mon, 3 Nov 2008 12:26:35 +0000 (12:26 +0000)]
when --without-<foo> is passed to the configure script, explicitly inform menuselect that the package was disabled by the user

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153787 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd XML documentation for:
Eliel C. Sardanons [Mon, 3 Nov 2008 01:01:25 +0000 (01:01 +0000)]
Add XML documentation for:
   - WaitForSilence()
   - WaitForNoise()
   - WaitForRing()
   - IVRDemo()
   - DBDel()
   - DBDeltree()

 (issue #13699)
 Reported by: snuffy
 Patches:
       bug13699_20081016.diff uploaded by snuffy (license 35)
        (With minor changes)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153747 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoinstead of trying to forcibly load res_agi when app_stack is loaded (even if the...
Kevin P. Fleming [Sun, 2 Nov 2008 23:34:39 +0000 (23:34 +0000)]
instead of trying to forcibly load res_agi when app_stack is loaded (even if the administrator didn't want it loaded), use GCC weak symbols to determine whether it was loaded already or not; if it was loaded, then use it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153709 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 153651 via svnmerge from
Russell Bryant [Sun, 2 Nov 2008 20:06:03 +0000 (20:06 +0000)]
Merged revisions 153651 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r153651 | russell | 2008-11-02 13:51:17 -0600 (Sun, 02 Nov 2008) | 2 lines

features.h depends on linkedlists.h, so include it

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153652 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agofix one more warning missed because i did not have new enough libpri installed
Kevin P. Fleming [Sun, 2 Nov 2008 19:39:41 +0000 (19:39 +0000)]
fix one more warning missed because i did not have new enough libpri installed

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153650 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agofix small bug introduced while cleaning up compiler warnings
Kevin P. Fleming [Sun, 2 Nov 2008 19:09:41 +0000 (19:09 +0000)]
fix small bug introduced while cleaning up compiler warnings

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153618 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agomark this revision as merged manually
Kevin P. Fleming [Sun, 2 Nov 2008 18:53:11 +0000 (18:53 +0000)]
mark this revision as merged manually

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153617 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agobring over all the fixes for the warnings found by gcc 4.3.x from the 1.4 branch...
Kevin P. Fleming [Sun, 2 Nov 2008 18:52:13 +0000 (18:52 +0000)]
bring over all the fixes for the warnings found by gcc 4.3.x from the 1.4 branch, and add the ones needed for all the new code here too

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153616 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd IAX2Provision() application XML documentation.
Eliel C. Sardanons [Sun, 2 Nov 2008 06:24:53 +0000 (06:24 +0000)]
Add IAX2Provision() application XML documentation.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153582 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agovalidate-docs is a PHONY target
Russell Bryant [Sun, 2 Nov 2008 05:56:50 +0000 (05:56 +0000)]
validate-docs is a PHONY target

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153580 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd a handy makefile target so that you can validate the documentation against the DTD
Russell Bryant [Sun, 2 Nov 2008 05:55:46 +0000 (05:55 +0000)]
Add a handy makefile target so that you can validate the documentation against the DTD
by running "make validate-docs"

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153578 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoModify the Makefile logic for extracting documentation.
Russell Bryant [Sun, 2 Nov 2008 05:47:13 +0000 (05:47 +0000)]
Modify the Makefile logic for extracting documentation.
 - Build the documentation when you run "make", as opposed to "make install"
 - Only rebuild the documentation when source code has been changed

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153577 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd Flash() application XML documentation.
Eliel C. Sardanons [Sun, 2 Nov 2008 05:10:22 +0000 (05:10 +0000)]
Add Flash() application XML documentation.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153543 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a typo in the name of the application.
Eliel C. Sardanons [Sun, 2 Nov 2008 04:57:02 +0000 (04:57 +0000)]
Fix a typo in the name of the application.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153541 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoThere is a troublesome assert() in the alsa/control.h header that causes
Sean Bright [Sun, 2 Nov 2008 04:14:20 +0000 (04:14 +0000)]
There is a troublesome assert() in the alsa/control.h header that causes
GCC 4.3.2 to complain that the passed argument will always evaluate to
true.  So to get things to compile, disable assert when building
chan_usbradio.so.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153507 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAnother little one.
Sean Bright [Sun, 2 Nov 2008 02:57:27 +0000 (02:57 +0000)]
Another little one.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153472 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agofix a typo (thanks sean)
Russell Bryant [Sun, 2 Nov 2008 02:55:25 +0000 (02:55 +0000)]
fix a typo (thanks sean)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153470 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix various spelling and grammatical issues in documentation
Russell Bryant [Sun, 2 Nov 2008 02:50:33 +0000 (02:50 +0000)]
Fix various spelling and grammatical issues in documentation

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153468 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago - Use a for loop instead of a while loop
Russell Bryant [Sun, 2 Nov 2008 02:20:10 +0000 (02:20 +0000)]
 - Use a for loop instead of a while loop
 - Get rid of an unnecessary variable

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153437 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoInstead of doing a couple of strlen() calls each iteration of the loop, only do it...
Russell Bryant [Sun, 2 Nov 2008 02:14:19 +0000 (02:14 +0000)]
Instead of doing a couple of strlen() calls each iteration of the loop, only do it once
at the beginning of the function

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153435 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDon't ignore the result of find_peer() when looking for a peer by IP in check_peer_ok().
Russell Bryant [Sat, 1 Nov 2008 23:46:12 +0000 (23:46 +0000)]
Don't ignore the result of find_peer() when looking for a peer by IP in check_peer_ok().

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153403 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerge changes from team/group/appdocsxml
Russell Bryant [Sat, 1 Nov 2008 21:10:07 +0000 (21:10 +0000)]
Merge changes from team/group/appdocsxml

This commit introduces the first phase of an effort to manage documentation of the
interfaces in Asterisk in an XML format.  Currently, a new format is available for
applications and dialplan functions.  A good number of conversions to the new format
are also included.

For more information, see the following message to asterisk-dev:

http://lists.digium.com/pipermail/asterisk-dev/2008-October/034968.html

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153365 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoEnsure that the sip_pvt properly has its refcount incremented when the scheduler...
Russell Bryant [Sat, 1 Nov 2008 20:41:38 +0000 (20:41 +0000)]
Ensure that the sip_pvt properly has its refcount incremented when the scheduler holds
a reference to it for session timer processing.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153362 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoThe default in chan_sip for notifyringing is yes, so update the sample
Sean Bright [Sat, 1 Nov 2008 01:55:04 +0000 (01:55 +0000)]
The default in chan_sip for notifyringing is yes, so update the sample
conf to reflect that.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153296 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago* Fixed timeout logic in the dialing API as setting timeouts
Mark Michelson [Fri, 31 Oct 2008 20:05:46 +0000 (20:05 +0000)]
* Fixed timeout logic in the dialing API as setting timeouts
  had no effect
* Updated dialing API documentation to indicate that timeouts
  are specified in milliseconds
* Added a new timeout argument to the Page application. If time
  expires, any endpoints which have not answered will be hung up.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153223 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRecent CDR fixes moved execution of the 'h' exten into the bridging code, so variable...
Terry Wilson [Fri, 31 Oct 2008 18:55:33 +0000 (18:55 +0000)]
Recent CDR fixes moved execution of the 'h' exten into the bridging code, so variables that were set after ast_bridge_call was called would not show up in the 'h' exten.  Added a callback function to handle setting variables, etc. from w/in the bridging code.  Calls back into a nested function within the function calling ast_bridge_call

(closes issue #13793)
Reported by: greenfieldtech

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153181 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFailover for func_odbc, allowing an INSERT query to be performed when the UPDATE...
Tilghman Lesher [Fri, 31 Oct 2008 17:18:49 +0000 (17:18 +0000)]
Failover for func_odbc, allowing an INSERT query to be performed when the UPDATE query initially
affects 0 rows.
(closes issue #13083)
 Reported by: Corydon76
 Patches:
       20081031__bug13083.diff.txt uploaded by Corydon76 (license 14)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153124 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 153114 via svnmerge from
Tilghman Lesher [Fri, 31 Oct 2008 16:35:21 +0000 (16:35 +0000)]
Merged revisions 153114 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r153114 | tilghman | 2008-10-31 11:30:32 -0500 (Fri, 31 Oct 2008) | 3 lines

  Turn off qualify on uncached realtime peers.
  (Closes issue #13383)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153122 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUse the ast_str API call to reset the string instead of manually editing its internals
Russell Bryant [Fri, 31 Oct 2008 09:31:10 +0000 (09:31 +0000)]
Use the ast_str API call to reset the string instead of manually editing its internals

(closes issue #13816)
Reported by: eliel
Patches:
      channel.c.patch uploaded by eliel (license 64)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153057 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 152992 via svnmerge from
Sean Bright [Thu, 30 Oct 2008 20:59:17 +0000 (20:59 +0000)]
Merged revisions 152992 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r152992 | seanbright | 2008-10-30 16:58:24 -0400 (Thu, 30 Oct 2008) | 2 lines

The -I argument to aclocal needs a space before the include directory name.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152993 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd a todo for a new timing API implementation that would work for Linux systems
Russell Bryant [Thu, 30 Oct 2008 20:46:17 +0000 (20:46 +0000)]
Add a todo for a new timing API implementation that would work for Linux systems
as of kernel 2.6.25 and glibc 2.8

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152990 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 152958 via svnmerge from
Tilghman Lesher [Thu, 30 Oct 2008 20:35:46 +0000 (20:35 +0000)]
Merged revisions 152958 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r152958 | tilghman | 2008-10-30 15:33:28 -0500 (Thu, 30 Oct 2008) | 3 lines

  Cannot join detached threads.  See http://www.opengroup.org/onlinepubs/000095399/functions/pthread_join.html
  (Closes issue #13400)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152969 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 152922 via svnmerge from
Tilghman Lesher [Thu, 30 Oct 2008 19:45:52 +0000 (19:45 +0000)]
Merged revisions 152922 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r152922 | tilghman | 2008-10-30 14:43:38 -0500 (Thu, 30 Oct 2008) | 6 lines

  Unlock before returning, when extension doesn't exist.
  (closes issue #13807)
   Reported by: eliel
   Patches:
         chan_local.c.patch uploaded by eliel (license 64)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152923 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix the sip_peer reference count with respect to scheduler entries for
Russell Bryant [Thu, 30 Oct 2008 19:40:15 +0000 (19:40 +0000)]
Fix the sip_peer reference count with respect to scheduler entries for
scheduling peer pokes, and scheduling peer poke expirations.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152920 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix the sip_peer reference count with respect to scheduler entries for
Russell Bryant [Thu, 30 Oct 2008 19:35:36 +0000 (19:35 +0000)]
Fix the sip_peer reference count with respect to scheduler entries for
registration expirations.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152915 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a bug in AST_SCHED_REPLACE_UNREF(). The reference count of the object
Russell Bryant [Thu, 30 Oct 2008 19:28:06 +0000 (19:28 +0000)]
Fix a bug in AST_SCHED_REPLACE_UNREF().  The reference count of the object
_must_ be increased before creating the scheduler entry.  Otherwise, you
create a race condition where the reference count may hit zero and the
object can disappear out from under you.  This could also would have
incorrectly decreased the reference count in the case that the scheduler
add failed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152887 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoI just noticed this construct and thought it was
Mark Michelson [Thu, 30 Oct 2008 19:23:16 +0000 (19:23 +0000)]
I just noticed this construct and thought it was
silly to have a bunch of case statements with duplicated
code in each case. Instead, just use the built-in fallthrough
capability of case statements and reduce the code to
a single instance

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152879 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoModify the documentation of the sip_registry struct
Russell Bryant [Thu, 30 Oct 2008 19:21:53 +0000 (19:21 +0000)]
Modify the documentation of the sip_registry struct
 - Remove a comment that says that the monitor thread is the only one that
   ever touches these objects.  This is no longer the case with TCP.  Also,
   I would eventually like to get the scheduler in its own thread, so this
   is just a poor assumption to make.
 - Note that reference counting of these objects with respect to scheduler
   entries is not complete.  There are some leaked references when deleting
   scheduler entries.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152877 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago - spaces to tabs
Russell Bryant [Thu, 30 Oct 2008 19:18:16 +0000 (19:18 +0000)]
 - spaces to tabs
 - add some braces
 - remove unnecessary cast

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152875 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 152811 via svnmerge from
Kevin P. Fleming [Thu, 30 Oct 2008 16:54:29 +0000 (16:54 +0000)]
Merged revisions 152811 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r152811 | kpfleming | 2008-10-30 11:53:48 -0500 (Thu, 30 Oct 2008) | 3 lines

  instead of comparing the string pointer to 0, let's compare the value that was actually parsed out of the string (found by sparse)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152812 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agotry to get this committed before the buildbot complains about a broken tree
Kevin P. Fleming [Thu, 30 Oct 2008 16:53:11 +0000 (16:53 +0000)]
try to get this committed before the buildbot complains about a broken tree

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152810 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agofix a few small things found by using sparse
Kevin P. Fleming [Thu, 30 Oct 2008 16:49:02 +0000 (16:49 +0000)]
fix a few small things found by using sparse

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152809 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAfter seeing another problem in #asterisk stemming from
Mark Michelson [Thu, 30 Oct 2008 16:38:19 +0000 (16:38 +0000)]
After seeing another problem in #asterisk stemming from
the low default value of featuredigittimeout, I decided it
was high time to change it. I have changed the default to
2000 ms based on a suggestion from Leif Madsen.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152807 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSet up an example stdexten that preserves the original context and extension in
Tilghman Lesher [Thu, 30 Oct 2008 04:26:34 +0000 (04:26 +0000)]
Set up an example stdexten that preserves the original context and extension in
the CDR.
(Related to issue #13799)
 Reported by: davidw

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152765 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoPay attention to the searchcontexts entry in voicemail.conf (related to AST-125)
Tilghman Lesher [Thu, 30 Oct 2008 02:08:02 +0000 (02:08 +0000)]
Pay attention to the searchcontexts entry in voicemail.conf (related to AST-125)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152727 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoTrack down and fix annoying lock errors
Tilghman Lesher [Thu, 30 Oct 2008 00:45:47 +0000 (00:45 +0000)]
Track down and fix annoying lock errors

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152689 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoIf there was no named defined in a voicemail.conf mailbox
Mark Michelson [Wed, 29 Oct 2008 20:53:53 +0000 (20:53 +0000)]
If there was no named defined in a voicemail.conf mailbox
entry, then app_directory would crash when attempting to
read that entry from the file. We now check for the NULL
or empty string properly so that there will be no crash.

(closes issue #13804)
Reported by: bluecrow76

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152646 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 152538 via svnmerge from
Steve Murphy [Wed, 29 Oct 2008 05:47:13 +0000 (05:47 +0000)]
Merged revisions 152538 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r152538 | murf | 2008-10-28 23:19:04 -0600 (Tue, 28 Oct 2008) | 14 lines

A little documentation cross-ref between features and
dial and queue... I wasted some time (stupidly) trying
to get the one-touch parking stuff working, because it
didn't occur to me that I had to also have the corresponding
options in the dial command! Duh! (In all this time, I never
set this up before!)
So, to keep some poor fool from suffering the same fate,
I made the features.conf.sample file mention the corresponding
opts in dial/queue; and the docs for dial/app specifically
mention the corresponding decls in the feature.conf file.

I hope this doesn't spoil some vast, eternal plan...

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152605 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 152539 via svnmerge from
Russell Bryant [Wed, 29 Oct 2008 05:34:26 +0000 (05:34 +0000)]
Merged revisions 152539 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r152539 | russell | 2008-10-29 00:23:51 -0500 (Wed, 29 Oct 2008) | 7 lines

Fix an incorrect usage of sizeof()

(closes issue #13795)
Reported by: andrew53
Patches:
chan_sip_sizeof.patch uploaded by andrew53 (license 519)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152569 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 152535 via svnmerge from
Steve Murphy [Wed, 29 Oct 2008 05:01:00 +0000 (05:01 +0000)]
Merged revisions 152535 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r152535 | murf | 2008-10-28 22:36:32 -0600 (Tue, 28 Oct 2008) | 46 lines

The magic trick to avoid this crash is not to
try to find the channel by name in the list,
which is slow and resource consuming, but rather
to pay attention to the result codes from the
ast_bridge_call, to which I added the
AST_PBX_NO_HANGUP_PEER_PARKED value, which
now are returned when a channel is parked.
Why? because CDR's aren't generated via parking,
so nothing is needed, but if a transfer occurred,
there are critical things I need.

If you get AST_PBX_KEEPALIVE,
then don't touch the channel pointer.

If you get AST_PBX_NO_HANGUP_PEER, or
AST_PBX_NO_HANGUP_PEER_PARKED, then don't
touch the peer pointer.

Updated the several places where the results
from a bridge were not being properly obeyed,
and fixed some code I had introduced so that
the results of the bridge were not overridden
(in trunk).

All the places that previously tested for
AST_PBX_NO_HANGUP_PEER now have to check for
both AST_PBX_NO_HANGUP_PEER and AST_PBX_NO_HANGUP_PEER_PARKED.

I tested this against the 4 common parking
scenarios:

1. A calls B; B answers; A parks B; B hangs up while A is getting the parking
slot announcement, immediately after being put on hold.

2. A calls B; B answers; A parks B; B hangs up after A has been hung up, but
before the park times out.

3. A calls B; B answers; B parks A; A hangs up while B is getting the parking slot announcement, immediately after being put on hold.

4. A calls B; B answers; B parks A; A hangs up after B has been hung up, but before the park times out.

No crash.

I also ran the scenarios above against valgrind, and accesses looked good.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152536 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 152463 via svnmerge from
Tilghman Lesher [Tue, 28 Oct 2008 22:33:40 +0000 (22:33 +0000)]
Merged revisions 152463 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r152463 | tilghman | 2008-10-28 17:32:34 -0500 (Tue, 28 Oct 2008) | 3 lines

  Quoting in the wrong direction
  (Fixes AST-107)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152467 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd more polycom firmware files to static mapping
Doug Bailey [Tue, 28 Oct 2008 22:26:35 +0000 (22:26 +0000)]
Add more polycom firmware files to static mapping

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152448 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoOnly re-add the io port if it was closed, otherwise reload causes a memory
Tilghman Lesher [Tue, 28 Oct 2008 21:38:26 +0000 (21:38 +0000)]
Only re-add the io port if it was closed, otherwise reload causes a memory
leak.
(closes issue #13785)
 Reported by: eliel
 Patches:
       chan_mgcp.c.patch uploaded by eliel (license 64)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152442 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 152368 via svnmerge from
Tilghman Lesher [Tue, 28 Oct 2008 17:07:39 +0000 (17:07 +0000)]
Merged revisions 152368 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r152368 | tilghman | 2008-10-28 12:04:56 -0500 (Tue, 28 Oct 2008) | 8 lines

  Reset all DIAL variables back to blank, in case Dial is called multiple times
  per call (which could otherwise lead to inconsistent status reports).
  (closes issue #13216)
   Reported by: ruddy
   Patches:
         20081014__bug13216.diff.txt uploaded by Corydon76 (license 14)
   Tested by: ruddy
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152369 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 152286 via svnmerge from
Jeff Peeler [Mon, 27 Oct 2008 23:31:39 +0000 (23:31 +0000)]
Merged revisions 152286 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r152286 | jpeeler | 2008-10-27 18:28:49 -0500 (Mon, 27 Oct 2008) | 2 lines

Buffer policy setting for half is not needed.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152287 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 152215 via svnmerge from
Tilghman Lesher [Mon, 27 Oct 2008 21:34:04 +0000 (21:34 +0000)]
Merged revisions 152215 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r152215 | tilghman | 2008-10-27 16:32:00 -0500 (Mon, 27 Oct 2008) | 6 lines

  Inherit ALL elements of CallerID across a local channel.
  (closes issue #13368)
   Reported by: Peter Schlaile
   Patches:
         20080826__bug13368.diff.txt uploaded by Corydon76 (license 14)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152216 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSet ARGC in subroutines with the number of arguments passed.
Tilghman Lesher [Mon, 27 Oct 2008 16:44:55 +0000 (16:44 +0000)]
Set ARGC in subroutines with the number of arguments passed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152174 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoOops, only delete the ARG variables once upon release. The following section
Tilghman Lesher [Mon, 27 Oct 2008 16:24:11 +0000 (16:24 +0000)]
Oops, only delete the ARG variables once upon release.  The following section
would have removed them again (removing variables from 2 stack frames, instead
of just one).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152134 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemove options argument parsing/syntax (it isn't used any longer)
Jason Parker [Mon, 27 Oct 2008 16:03:12 +0000 (16:03 +0000)]
Remove options argument parsing/syntax (it isn't used any longer)

(closes issue #13789)
Reported by: IgorG
Patches:
      app_transfer.c.diff uploaded by IgorG (license 20)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152132 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 152059 via svnmerge from
Sean Bright [Sun, 26 Oct 2008 20:25:08 +0000 (20:25 +0000)]
Merged revisions 152059 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r152059 | seanbright | 2008-10-26 16:23:36 -0400 (Sun, 26 Oct 2008) | 7 lines

Since passing \0 as the second argument to strchr is valid (and will
match the trailing \0 of a string) we need to check that first, otherwise
we end up with incorrect results.  Fix suggested by reporter.

(closes issue #13787)
Reported by: meitinger

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152060 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoTrying to fix the user/peer matching correctly. This will need some testing before
Olle Johansson [Sun, 26 Oct 2008 10:23:01 +0000 (10:23 +0000)]
Trying to fix the user/peer matching correctly. This will need some testing before
getting merged into 1.6.1

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152020 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMoving more variables to the sip_cfg structure, as I have some future ideas for the...
Olle Johansson [Sun, 26 Oct 2008 09:45:17 +0000 (09:45 +0000)]
Moving more variables to the sip_cfg structure, as I have some future ideas for the usage of that structure.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152019 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDoxygen changes and some formatting.
Olle Johansson [Sun, 26 Oct 2008 09:19:19 +0000 (09:19 +0000)]
Doxygen changes and some formatting.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151980 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 151905 via svnmerge from
Russell Bryant [Sat, 25 Oct 2008 11:02:11 +0000 (11:02 +0000)]
Merged revisions 151905 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r151905 | russell | 2008-10-25 05:59:02 -0500 (Sat, 25 Oct 2008) | 8 lines

Move AMI initialization to occur after loading modules.  This prevents a
deadlock when someone tries to initiate a module reload from the AMI just
as Asterisk is starting.

(closes issue #13778)
Reported by: hotsblanc
Fix suggested by hotsblanc

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151906 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoallow to compile under --enable-dev-mode (gcc didn't actually complain when I was...
Terry Wilson [Thu, 23 Oct 2008 21:27:35 +0000 (21:27 +0000)]
allow to compile under --enable-dev-mode (gcc didn't actually complain when I was using ccache...)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151830 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 151763 via svnmerge
Terry Wilson [Thu, 23 Oct 2008 16:09:25 +0000 (16:09 +0000)]
Blocked revisions 151763 via svnmerge

........
  r151763 | twilson | 2008-10-23 11:04:42 -0500 (Thu, 23 Oct 2008) | 9 lines

  Backport fix from 1.6.0 that allows you to set parkedcalltransfers=no|caller|callee|both, but default to both which would be the equivalent of the existing behaviour.

  The problem was that if someone parked a call, the callee and caller would both get assigned the builtin transfer feature, which would not only be potentially giving someone the ability to transfer themselves when they shouldn't have it, but would also dissallow reinviting the media off of the call.
  (closes issue #12854)
   Reported by: davidw
   Patches:
         parkingfix4.diff.txt uploaded by otherwiseguy
     Tested by: davidw, otherwiseguy
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151764 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoClarify documentation, following merge of realtime_update2 branch
Tilghman Lesher [Thu, 23 Oct 2008 15:54:19 +0000 (15:54 +0000)]
Clarify documentation, following merge of realtime_update2 branch

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151762 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoThanks russellb for reminding an old man....
Olle Johansson [Thu, 23 Oct 2008 15:38:26 +0000 (15:38 +0000)]
Thanks russellb for reminding an old man....

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151761 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdding a small new feature.
Olle Johansson [Thu, 23 Oct 2008 15:30:16 +0000 (15:30 +0000)]
Adding a small new feature.
Setting _SIPFROMDOMAIN in a channel will set the domain we use for the URI in the outbound call leg.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151739 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSimplify some nested functions, as suggested by Russell on -dev
Tilghman Lesher [Thu, 23 Oct 2008 15:28:43 +0000 (15:28 +0000)]
Simplify some nested functions, as suggested by Russell on -dev

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151732 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd patch to handle how IE7 issues POST requests using Window path spec including...
Doug Bailey [Thu, 23 Oct 2008 15:09:20 +0000 (15:09 +0000)]
Add patch to handle how IE7 issues POST requests using Window path spec including backslash delimiters

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151722 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdded debugging CLI functions
Tilghman Lesher [Wed, 22 Oct 2008 22:11:31 +0000 (22:11 +0000)]
Added debugging CLI functions

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151682 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago revert the changes in issue #13705 - it's being re-opened as while the results fixed...
BJ Weschke [Wed, 22 Oct 2008 20:45:03 +0000 (20:45 +0000)]
 revert the changes in issue #13705 - it's being re-opened as while the results fixed the complaint in the issue, it introduced other more undesirable issues than what was already reported

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151642 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd a contributed script for running Asterisk without installing it, first.
Tilghman Lesher [Wed, 22 Oct 2008 20:05:15 +0000 (20:05 +0000)]
Add a contributed script for running Asterisk without installing it, first.
(closes issue #11680)
 Reported by: tzafrir
 Patches:
       live_ast_6 uploaded by tzafrir (license 46)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151601 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoChange some logical ands to bitwise ands and add
Mark Michelson [Wed, 22 Oct 2008 20:05:14 +0000 (20:05 +0000)]
Change some logical ands to bitwise ands and add
messages alerting that a channel is being ignored
if the PROC_DAHDI_NOCHAN option is set in process_dahdi.

(closes issue #13759)
Reported by: smurfix
Patches:
      dahdi.patch uploaded by smurfix (license 547)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151600 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoPrint out the right var in the log message
Russell Bryant [Wed, 22 Oct 2008 17:45:05 +0000 (17:45 +0000)]
Print out the right var in the log message

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151555 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix this check to use the proper variable (the result from get_in_brackets)
Russell Bryant [Wed, 22 Oct 2008 17:44:05 +0000 (17:44 +0000)]
Fix this check to use the proper variable (the result from get_in_brackets)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151554 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoThe logic of a strncasecmp call was reversed.
Mark Michelson [Wed, 22 Oct 2008 15:08:25 +0000 (15:08 +0000)]
The logic of a strncasecmp call was reversed.

(closes issue #13706)
Reported by: andrew53
Patches:
      sip_notify_from_rfc3265.patch uploaded by andrew53 (license 519)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151512 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake the sip_standard_port function more granular by allowing separate
Mark Michelson [Tue, 21 Oct 2008 23:54:41 +0000 (23:54 +0000)]
Make the sip_standard_port function more granular by allowing separate
type and port arguments. This is necessary because when building our From
and Contact headers, we need to be absolutely sure that we are placing our
source port there and not the peer's source port.

(closes issue #12761)
Reported by: asbestoshead
Patches:
      patch-chan-sip-contact-port.txt uploaded by asbestoshead (license 455)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151464 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoGet this compiling in dev-mode
Mark Michelson [Tue, 21 Oct 2008 23:31:17 +0000 (23:31 +0000)]
Get this compiling in dev-mode

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151439 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoIf a peer uses any transport other than UDP, then MWI will
Mark Michelson [Tue, 21 Oct 2008 23:27:45 +0000 (23:27 +0000)]
If a peer uses any transport other than UDP, then MWI will
fail for that peer since sip_alloc will allocate a sip_pvt with
a default transport of UDP. This change resets the socket type
immediately after allocating the sip_pvt in sip_send_mwi_from_peer,
so that the proceeding call to create_addr_from_peer does not fail
right away. The socket data from the peer is properly copied to
the sip_pvt in create_addr_from_peer.

(closes issue #13710)
Reported by: andrew53
Patches:
      sip_notify_use_tcp.patch uploaded by andrew53 (license 519)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151428 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoWhen attempting to resolve hostnames, we need to be sure
Mark Michelson [Tue, 21 Oct 2008 23:08:56 +0000 (23:08 +0000)]
When attempting to resolve hostnames, we need to be sure
to remove any parameters from the string so that name
resolution succeeds.

(closes issue #13727)
Reported by: fnordian
Patches:
      resolvewithouturiparameter.patch uploaded by fnordian (license 110)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151420 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDefault file modes should always be full read and write, to allow the system
Tilghman Lesher [Tue, 21 Oct 2008 15:20:50 +0000 (15:20 +0000)]
Default file modes should always be full read and write, to allow the system
administrator to make the decision of what permissions will actually be given,
through the use of the process umask.
(Closes issue# 13751)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151371 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago Fix configuration parsing so type=friend still identifies "friend" as a peer even...
BJ Weschke [Tue, 21 Oct 2008 11:02:08 +0000 (11:02 +0000)]
 Fix configuration parsing so type=friend still identifies "friend" as a peer even though it is now a legacy configuration verb.

 (closes issue #13705)
 reported by: blitzrage
 patched by: bweschke

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151327 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago Do NOT attempt to do anything with the ast_config struct when it's been returned...
BJ Weschke [Mon, 20 Oct 2008 05:07:25 +0000 (05:07 +0000)]
 Do NOT attempt to do anything with the ast_config struct when it's been returned as INVALID by the config file interpreter.

 (closes issue #13741)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151246 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 151241 via svnmerge from
Kevin P. Fleming [Mon, 20 Oct 2008 05:00:56 +0000 (05:00 +0000)]
Merged revisions 151241 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r151241 | kpfleming | 2008-10-20 07:57:33 +0300 (Mon, 20 Oct 2008) | 2 lines

  rename this macro to properly reflect what it does
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151243 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 151240 via svnmerge from
Kevin P. Fleming [Mon, 20 Oct 2008 04:59:04 +0000 (04:59 +0000)]
Merged revisions 151240 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r151240 | kpfleming | 2008-10-20 07:45:56 +0300 (Mon, 20 Oct 2008) | 3 lines

  break up acinclude.m4 into individual files, which will make it easier to maintain, easier to add new macros (less patching) and will ease maintenance of these macros across Asterisk branches
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151242 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlock 151167 from coming forward into the /trunk this is a 1.4 fix only.
BJ Weschke [Sun, 19 Oct 2008 20:30:27 +0000 (20:30 +0000)]
Block 151167 from coming forward into the /trunk this is a 1.4 fix only.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151190 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago Block 151100 from coming forward into the /trunk this is a 1.4 fix only.
BJ Weschke [Sun, 19 Oct 2008 20:29:58 +0000 (20:29 +0000)]
 Block 151100 from coming forward into the /trunk this is a 1.4 fix only.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151188 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agocleaup of the TCP/TLS socket API:
Kevin P. Fleming [Sun, 19 Oct 2008 19:11:28 +0000 (19:11 +0000)]
cleaup of the TCP/TLS socket API:

1) rename 'struct server_args' to 'struct ast_tcptls_session_args', to follow coding guidelines

2) make ast_make_file_from_fd() static and rename it to something that indicates what it really is for (again coding guidelines)

3) rename address variables inside 'struct ast_tcptls_session_args' to be more descriptive (dare i say it... coding guidelines)

4) change ast_tcptls_client_start() to use the new 'remote_address' field of the session args for the destination of the connection, and use the 'local_address' field to bind() the socket to the proper source address, if one is supplied

5) in chan_sip, ensure that we pass in the PP address we are bound to when creating outbound (client) connections, so that our connections will appear from the correct address

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151101 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agodont segfault when placing a call to a line that has no registered device.
Michiel van Baak [Sun, 19 Oct 2008 13:10:50 +0000 (13:10 +0000)]
dont segfault when placing a call to a line that has no registered device.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151060 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdding changes from train and flight back home from SIPit23 in Lannion, France.
Olle Johansson [Sun, 19 Oct 2008 07:20:40 +0000 (07:20 +0000)]
Adding changes from train and flight back home from SIPit23 in Lannion, France.
- Additional comments on TCP/TLS implementation
- Some additions for new drafts/rfcs (no new functionality really, mostly documentation)
- Other random small fixes

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151019 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake sure we support nested functions and generation of trampolines
Michiel van Baak [Sat, 18 Oct 2008 10:27:22 +0000 (10:27 +0000)]
Make sure we support nested functions and generation of trampolines
under OpenBSD.

(closes issue #13724)
Reported by: mvanbaak

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150971 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agodont use deprecated commands in the init scripts.
Michiel van Baak [Sat, 18 Oct 2008 09:02:36 +0000 (09:02 +0000)]
dont use deprecated commands in the init scripts.

(closes issue #13720)
Reported by: decryptus_proformatique
Patches:
      contrib_initd_module_reload.patch uploaded by decryptus (license 555)
  With mods by me to fix stop commands as well

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150930 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago Give app_authenticate the ability to select a prompt other than the default.
BJ Weschke [Sat, 18 Oct 2008 03:35:24 +0000 (03:35 +0000)]
 Give app_authenticate the ability to select a prompt other than the default.

 (closes issue #13734)
 reported and patched by: jvandal

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150887 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago Using the GetVar handler in AMI is potentially dangerous (insta-crash [tm]) when...
BJ Weschke [Sat, 18 Oct 2008 02:18:33 +0000 (02:18 +0000)]
 Using the GetVar handler in AMI is potentially dangerous (insta-crash [tm]) when you use a dialplan function that requires a channel and then you don't provide one or provide an invalid one in the Channel: parameter. We'll handle this situation exactly the same way it was handled in pbx.c back on r61766.
We'll create a bogus channel for the function call and destroy it when we're done. If we have trouble allocating the bogus channel then we're not going to try executing the function call at all and run the risk of crashing.

(closes issue #13715)
reported by: makoto
patch by: bweschke

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150817 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago The QueueEntry event now has the uniqueid of the channel included.
BJ Weschke [Sat, 18 Oct 2008 00:25:18 +0000 (00:25 +0000)]
 The QueueEntry event now has the uniqueid of the channel included.
 (closes issue #13731)
 reported and patched by: caio1982

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150773 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUpdate configure check to check for new function in libpri (pri_progress_with_cause)
Matthew Fredrickson [Fri, 17 Oct 2008 21:48:07 +0000 (21:48 +0000)]
Update configure check to check for new function in libpri (pri_progress_with_cause)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150731 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerge codec_consistency branch. This should make sample usage much happier.
Jason Parker [Fri, 17 Oct 2008 21:35:23 +0000 (21:35 +0000)]
Merge codec_consistency branch.  This should make sample usage much happier.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150729 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix CLI command 'channel request hangup'
Michiel van Baak [Fri, 17 Oct 2008 17:31:07 +0000 (17:31 +0000)]
Fix CLI command 'channel request hangup'
Prodded on IRC by Russell and fixed by eliel

(closes issue #13730)
Reported by: eliel
Patches:
      main_cli.patch uploaded by eliel (license 64)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150664 65c4cc65-6c06-0410-ace0-fbb531ad65f3