asterisk/asterisk.git
12 years agoAdd the Ring time in the CONNECT on the queue_log and on the Manager event AgentConnect
Jason Parker [Wed, 1 Aug 2007 20:05:13 +0000 (20:05 +0000)]
Add the Ring time in the CONNECT on the queue_log and on the Manager event AgentConnect

Closes issue #10349, patch by eliel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77879 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoInstead of adding the SOLARIS check to each HAVE_SYSINFO check let's just make the...
Joshua Colp [Wed, 1 Aug 2007 19:37:59 +0000 (19:37 +0000)]
Instead of adding the SOLARIS check to each HAVE_SYSINFO check let's just make the sysinfo autoconf logic a bit pickier about what it considers a usable sysinfo.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77878 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoSolaris does not have a sysinfo like we know of on Linux.
Joshua Colp [Wed, 1 Aug 2007 19:12:36 +0000 (19:12 +0000)]
Solaris does not have a sysinfo like we know of on Linux.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77876 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoDon't look for /dev/urandom when cross compiling. Just assume it is not available.
Joshua Colp [Wed, 1 Aug 2007 18:56:31 +0000 (18:56 +0000)]
Don't look for /dev/urandom when cross compiling. Just assume it is not available.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77875 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoBlocked revisions 77871 via svnmerge
Joshua Colp [Wed, 1 Aug 2007 18:10:25 +0000 (18:10 +0000)]
Blocked revisions 77871 via svnmerge

........
r77871 | file | 2007-08-01 15:08:51 -0300 (Wed, 01 Aug 2007) | 4 lines

(closes issue #10351)
Reported by: ftarz
Some platforms don't like it when you pass NULL to vsnprintf so pass "" instead.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77872 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77869 via svnmerge from
Joshua Colp [Wed, 1 Aug 2007 18:01:33 +0000 (18:01 +0000)]
Merged revisions 77869 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77869 | file | 2007-08-01 14:56:59 -0300 (Wed, 01 Aug 2007) | 2 lines

Add some fixes for building on Solaris.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77870 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77867 via svnmerge from
Joshua Colp [Wed, 1 Aug 2007 17:53:09 +0000 (17:53 +0000)]
Merged revisions 77867 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77867 | file | 2007-08-01 14:52:11 -0300 (Wed, 01 Aug 2007) | 2 lines

Whoops, I meant R_5 not R5.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77868 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77865 via svnmerge from
Joshua Colp [Wed, 1 Aug 2007 17:47:05 +0000 (17:47 +0000)]
Merged revisions 77865 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77865 | file | 2007-08-01 14:42:52 -0300 (Wed, 01 Aug 2007) | 2 lines

And for my last trick... make sure that if gethostbyname_r is exported by a library that it is used.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77866 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77863 via svnmerge from
Joshua Colp [Wed, 1 Aug 2007 17:27:09 +0000 (17:27 +0000)]
Merged revisions 77863 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77863 | file | 2007-08-01 14:22:35 -0300 (Wed, 01 Aug 2007) | 2 lines

Extend autoconf logic to determine which version of gethostbyname_r is on the system.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77864 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoConvert code that checks the _softhangup member of ast_channel directory to use
Russell Bryant [Wed, 1 Aug 2007 15:39:54 +0000 (15:39 +0000)]
Convert code that checks the _softhangup member of ast_channel directory to use
the ast_check_hangup() funciton.  This function takes scheduled hangups into
account.
(closes issue #10230, patch by Juggie)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77858 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoConvert CLI helpers list to rwlist.
Joshua Colp [Wed, 1 Aug 2007 15:28:02 +0000 (15:28 +0000)]
Convert CLI helpers list to rwlist.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77857 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77854 via svnmerge from
Mark Michelson [Wed, 1 Aug 2007 14:09:45 +0000 (14:09 +0000)]
Merged revisions 77854 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77854 | mmichelson | 2007-08-01 09:08:57 -0500 (Wed, 01 Aug 2007) | 8 lines

Fixes an issue I introduced to queues wherein a queue with joinempty=yes would kick people out of the queue because of erroneously
thinking the 'n' option was in use.

(closes issue #10320, reported by jfitzgibbon, patched by me, tested by blitzrage and me)

Thank you blitzrage for all the testing you've done lately with queues! It's much appreciated!

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77855 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77852 via svnmerge from
Mark Michelson [Wed, 1 Aug 2007 14:02:19 +0000 (14:02 +0000)]
Merged revisions 77852 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77852 | mmichelson | 2007-08-01 08:59:59 -0500 (Wed, 01 Aug 2007) | 7 lines

If a queue uses dynamic realtime members, then the member list should be updated after each attempt to call the queue.
This fixes an issue where if a caller calls into a queue where no one is logged in, they would wait forever even if a member
logged in at some point.

(closes issue #10346, reported by and tested by blitzrage, patched by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77853 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoTwould help if we actually defined ->mod before comparing against it (reported and...
Tilghman Lesher [Wed, 1 Aug 2007 04:36:15 +0000 (04:36 +0000)]
Twould help if we actually defined ->mod before comparing against it (reported and fixed by Juggie via IRC).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77851 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77844 via svnmerge from
Steve Murphy [Tue, 31 Jul 2007 21:33:37 +0000 (21:33 +0000)]
Merged revisions 77844 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r77844 | murf | 2007-07-31 14:59:10 -0600 (Tue, 31 Jul 2007) | 9 lines

Merged revisions 77842 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r77842 | murf | 2007-07-31 13:19:35 -0600 (Tue, 31 Jul 2007) | 1 line

This probably isn't super-general, but it's a first stab at using kill -11 to generate a core file instead of gcore.
........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77847 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoAdd some documentation detailing an aspect of dialplan functions, as requested by...
Tilghman Lesher [Tue, 31 Jul 2007 18:50:06 +0000 (18:50 +0000)]
Add some documentation detailing an aspect of dialplan functions, as requested by Russell

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77838 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoAdd func_lock, which creates dialplan mutexes, and note that the Macro apps are now...
Tilghman Lesher [Tue, 31 Jul 2007 16:44:25 +0000 (16:44 +0000)]
Add func_lock, which creates dialplan mutexes, and note that the Macro apps are now deprecated.
(Closes issue #10264)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77834 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77831 via svnmerge from
Joshua Colp [Tue, 31 Jul 2007 16:21:34 +0000 (16:21 +0000)]
Merged revisions 77831 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77831 | file | 2007-07-31 13:17:09 -0300 (Tue, 31 Jul 2007) | 2 lines

Add a flag to the speech API that allows an engine to set whether it received results or not.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77833 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agothanks to Russel, for pointing out that the dialoglist_lock/unlock routines also...
Steve Murphy [Tue, 31 Jul 2007 15:59:01 +0000 (15:59 +0000)]
thanks to Russel, for pointing out that the dialoglist_lock/unlock routines also need to be macros if DETECT_DEADLOCKS is set

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77829 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77827 via svnmerge from
Kevin P. Fleming [Tue, 31 Jul 2007 15:54:29 +0000 (15:54 +0000)]
Merged revisions 77827 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77827 | kpfleming | 2007-07-31 10:53:42 -0500 (Tue, 31 Jul 2007) | 2 lines

DETECT_DEADLOCKS can't be enabled without DEBUG_THREADS or it does nothing

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77828 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77824 via svnmerge from
Mark Michelson [Tue, 31 Jul 2007 15:22:32 +0000 (15:22 +0000)]
Merged revisions 77824 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77824 | mmichelson | 2007-07-31 10:21:22 -0500 (Tue, 31 Jul 2007) | 6 lines

This patch makes Asterisk send 100 Trying provisional responses upon receipt of re-invites. This makes it so that if there are two or more Asterisk
servers between endpoints, the Asterisk servers will not keep retransmitting the re-invites.

(closes issue #10274, reported by cstadlmann, patched by me with approval from file)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77825 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agothere is no use in having functions that have no code in them, and hide the locking...
Kevin P. Fleming [Tue, 31 Jul 2007 15:01:27 +0000 (15:01 +0000)]
there is no use in having functions that have no code in them, and hide the locking info when DEBUG_THREADS is enabled... i could have fixed this to be dependent on DEBUG_THREADS, but it would be just as easy for someone to add their test/debugging code to the macros as it would have been to the functions

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77821 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agouse a different method for overriding the send_digit_begin pointer, as the old one...
Kevin P. Fleming [Tue, 31 Jul 2007 14:55:37 +0000 (14:55 +0000)]
use a different method for overriding the send_digit_begin pointer, as the old one fails to compile on my 64-bit system with gcc-4.1 and --enable-dev-mode turned on

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77820 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoumm... let's build with --enable-dev-mode, mmkay?
Kevin P. Fleming [Tue, 31 Jul 2007 14:54:46 +0000 (14:54 +0000)]
umm... let's build with --enable-dev-mode, mmkay?

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77819 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoDiscovered in experiments on core files: if you wrap the lock and unlock calls with...
Steve Murphy [Tue, 31 Jul 2007 03:32:04 +0000 (03:32 +0000)]
Discovered in experiments on core files: if you wrap the lock and unlock calls with sip_pvt_lock and sip_pvt_unlock, you lose the tracing info you would normally get via DETECT_DEADLOCKS; so I turn these two functions into macros when DETECT_DEADLOCKS is called. This way, you get meaningful stuff in the file and func slots in the lock_info struct.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77810 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMostly cleanup of documentation to substitute the pipe with the comma, but a few...
Tilghman Lesher [Tue, 31 Jul 2007 01:10:47 +0000 (01:10 +0000)]
Mostly cleanup of documentation to substitute the pipe with the comma, but a few other formatting cleanups, too.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77808 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoAdd support for call forwarding and timeouts to the dialing API.
Joshua Colp [Mon, 30 Jul 2007 20:42:28 +0000 (20:42 +0000)]
Add support for call forwarding and timeouts to the dialing API.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77801 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoChange another unnecessary use of the increment operator to explicitly set the var...
Russell Bryant [Mon, 30 Jul 2007 20:36:18 +0000 (20:36 +0000)]
Change another unnecessary use of the increment operator to explicitly set the var to 1

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77800 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoExplicitly set a variable to 1 instead of using the increment operator.
Russell Bryant [Mon, 30 Jul 2007 20:33:44 +0000 (20:33 +0000)]
Explicitly set a variable to 1 instead of using the increment operator.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77799 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77794 via svnmerge from
Russell Bryant [Mon, 30 Jul 2007 20:21:05 +0000 (20:21 +0000)]
Merged revisions 77794 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77794 | russell | 2007-07-30 15:16:43 -0500 (Mon, 30 Jul 2007) | 8 lines

Fix an issue that could potentially cause corruption of the global iax frame
queue.  In the network_thread() loop, it traverses the list using the
AST_LIST_TRAVERSE_SAFE macro.  However, to remove an element of the list within
this loop, it used AST_LIST_REMOVE, instead of AST_LIST_REMOVE_CURRENT, which I
believe could leave some of the internal variables of the SAFE macro invalid.
Mihai says that he already made this change in his local copy and it didn't help
his VNAK storm issues, but I still think it's wrong.  :)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77797 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77795 via svnmerge from
Jason Parker [Mon, 30 Jul 2007 20:19:13 +0000 (20:19 +0000)]
Merged revisions 77795 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #10083)
........
r77795 | qwell | 2007-07-30 15:17:08 -0500 (Mon, 30 Jul 2007) | 6 lines

Applications like SayAlpha() should not hang up the channel if you
 request an "unknown" character such as a comma.
Instead, skip the character and move on.

Issue 10083, initial patch by jsmith, modified by me.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77796 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoprint formats as 0x%x instead of %d in a warning message.
Luigi Rizzo [Mon, 30 Jul 2007 19:42:25 +0000 (19:42 +0000)]
print formats as 0x%x instead of %d in a warning message.
Being bitmasks, it is a lot easier to read this way.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77793 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoFix the return value of ast_agi_fdprintf() to include the result from ast_carefulwrite()
Russell Bryant [Mon, 30 Jul 2007 19:39:52 +0000 (19:39 +0000)]
Fix the return value of ast_agi_fdprintf() to include the result from ast_carefulwrite()

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77792 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoImprove ast_agi_fdprintf() by using the ast_str() API.
Russell Bryant [Mon, 30 Jul 2007 19:35:33 +0000 (19:35 +0000)]
Improve ast_agi_fdprintf() by using the ast_str() API.
 * Use a thread local ast_str for building the string that will be written out
   to the console for debug, and to the FD for the AGI itself, instead of allocating
   a buffer on the heap every time the function is called.
 * Use the information contained within the ast_str to determine how many bytes
   need to be written instead of calling strlen().

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77791 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoRemove an XXX comment noting that it would be nice for a declaration to be
Russell Bryant [Mon, 30 Jul 2007 19:31:27 +0000 (19:31 +0000)]
Remove an XXX comment noting that it would be nice for a declaration to be
inside of a function.  (Yes, it would!)  Replace it with a note that explains
why it can't be done using the way that the AST_THREADSTORAGE macro is
currently defined.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77790 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77788 via svnmerge from
Russell Bryant [Mon, 30 Jul 2007 19:18:24 +0000 (19:18 +0000)]
Merged revisions 77788 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77788 | russell | 2007-07-30 14:13:31 -0500 (Mon, 30 Jul 2007) | 10 lines

(closes issue #10279)
Reported by: seanbright
Patches:
      res_agi.carefulwrite.1.4.07252007.patch uploaded by seanbright (license 71)
      res_agi.carefulwrite.trunk.07252007.patch uploaded by seanbright (license 71)

Allow the "agi_network: yes" line to be printed out in the AGI debug output.
Also, allow partial writes to be handled when writing out this line just like
it is for all of the others.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77789 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoCleanup of res_agi, ensuring thread safety (closes issue #10288)
Tilghman Lesher [Mon, 30 Jul 2007 19:11:28 +0000 (19:11 +0000)]
Cleanup of res_agi, ensuring thread safety (closes issue #10288)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77787 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77785 via svnmerge from
Russell Bryant [Mon, 30 Jul 2007 18:56:29 +0000 (18:56 +0000)]
Merged revisions 77785 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77785 | russell | 2007-07-30 13:55:15 -0500 (Mon, 30 Jul 2007) | 3 lines

file and I both committed changes for issue #10301.  Remove a duplicated
assignment to restore the original value of the previous channel.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77786 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77783 via svnmerge from
Tilghman Lesher [Mon, 30 Jul 2007 18:45:09 +0000 (18:45 +0000)]
Merged revisions 77783 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r77783 | tilghman | 2007-07-30 13:43:55 -0500 (Mon, 30 Jul 2007) | 10 lines

Merged revisions 77782 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r77782 | tilghman | 2007-07-30 13:40:54 -0500 (Mon, 30 Jul 2007) | 2 lines

Revert change in revision 71656, even though it fixed a bug, because many people were depending upon the (broken) behavior.

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77784 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77780 via svnmerge from
Russell Bryant [Mon, 30 Jul 2007 17:31:29 +0000 (17:31 +0000)]
Merged revisions 77780 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77780 | russell | 2007-07-30 12:29:43 -0500 (Mon, 30 Jul 2007) | 16 lines

(closes issue #10301)
Reported by: fnordian
Patches:
      asterisk-1.4.9-channel.c.patch uploaded by fnordian (license 110)
      Additional changes by me

Fix some problems in channel_find_locked() which can cause an infinite loop.
The reference to the previous channel is set to NULL in some cases.  These changes
ensure that the reference to the previous channel gets restored before needing
it again.

I'm not convinced that the code that is setting it to NULL is really the right
thing to do.  However, I am making these changes to fix the obvious problem
and just leaving an XXX comment that it needs a better explanation that what
is there now.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77781 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77778 via svnmerge from
Joshua Colp [Mon, 30 Jul 2007 17:12:58 +0000 (17:12 +0000)]
Merged revisions 77778 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77778 | file | 2007-07-30 14:11:02 -0300 (Mon, 30 Jul 2007) | 4 lines

(closes issue #10327)
Reported by: kkiely
Instead of directly mucking with the extension/context/priority of the channel we are transferring when it has a PBX simply call ast_async_goto on it. This will ensure that the channel gets handled properly and sent to the right place.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77779 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMinor clean up of app_followme.
Joshua Colp [Mon, 30 Jul 2007 16:02:01 +0000 (16:02 +0000)]
Minor clean up of app_followme.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77773 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77771 via svnmerge from
Joshua Colp [Mon, 30 Jul 2007 15:49:30 +0000 (15:49 +0000)]
Merged revisions 77771 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77771 | file | 2007-07-30 12:47:52 -0300 (Mon, 30 Jul 2007) | 6 lines

(closes issue #10301)
Reported by: fnordian
Patches:
      asterisk-1.4.9-channel.c.patch uploaded by fnordian (license 110)
Restore previous behavior where if we failed to lock the channel we wanted we would return to exactly the same point as if we had just reentered the function.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77772 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoResolve some compiler warnings so that I can build under dev mode
Russell Bryant [Mon, 30 Jul 2007 15:22:20 +0000 (15:22 +0000)]
Resolve some compiler warnings so that I can build under dev mode

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77770 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77768 via svnmerge from
Joshua Colp [Mon, 30 Jul 2007 14:53:14 +0000 (14:53 +0000)]
Merged revisions 77768 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r77768 | file | 2007-07-30 11:51:44 -0300 (Mon, 30 Jul 2007) | 12 lines

Merged revisions 77767 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r77767 | file | 2007-07-30 11:50:02 -0300 (Mon, 30 Jul 2007) | 4 lines

(closes issue #10334)
Reported by: ramonpeek
Pass through the return value from macro_exec through the MacroIf application.

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77769 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agominor code rearrangements:
Luigi Rizzo [Mon, 30 Jul 2007 10:55:37 +0000 (10:55 +0000)]
minor code rearrangements:
+ place the link field at the beginning of struct sip_pvt,
  and not somewhere in the middle;

+ in __sip_reliable_xmit, remove a duplicate assignment, and
  put the statements in a more logical order (i.e. first copy
  the payload and associated info, then copy arguments from the
  caller, then finish initializing the headers...)

nothing to backport.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77766 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agorename handle_request() to handle_incoming(), as the former
Luigi Rizzo [Mon, 30 Jul 2007 08:07:00 +0000 (08:07 +0000)]
rename handle_request() to handle_incoming(), as the former
was misleading - the function deals with all incoming packets, be
them requests or responses.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77753 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomove some dialog-only flags to proper variables, namely
Luigi Rizzo [Sun, 29 Jul 2007 21:24:56 +0000 (21:24 +0000)]
move some dialog-only flags to proper variables, namely
SIP_NOVIDEO, SIP_DIALOG_ANSWEREDELSEWHERE, SIP_PAGE2_NOTEXT,
SIP_PAGE2_OUTGOING_CALL
These are seldom used so the diff is relatively small.

Note that 'OUTGOING_CALL' is dangerously similar to another
dialog flag, 'SIP_OUTGOING', so the description will need to
clarify the different meaning of the two.

Also note that the description of NOTEXT is a bit unclear - does
it mean we don't support it, or 'not requested or not supported' ?

On passing fix a comment referring to video instead of text.

Finally, mark with XXX a possibly misleading debugging message.
(maybe the latter is worth backporting).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77739 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agouse a function, cli_yesno(), to produce the output Yes or No for
Luigi Rizzo [Sun, 29 Jul 2007 20:55:20 +0000 (20:55 +0000)]
use a function, cli_yesno(), to produce the output Yes or No for
CLI lines. This helps maintaining consistency on output, slightly
improves readability, and maybe one day will make it easier to
translate the output in other languages (though i have a hard time
believing that a CLI user who needs 'yes' and 'no' to be translated
can actually figure out what he/she is doing!)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77726 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomove the two remaining peer flags to proper variables.
Luigi Rizzo [Sun, 29 Jul 2007 20:28:02 +0000 (20:28 +0000)]
move the two remaining peer flags to proper variables.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77725 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomove RT_FROMCONTACT to a proper sip_peer field.
Luigi Rizzo [Sun, 29 Jul 2007 20:13:32 +0000 (20:13 +0000)]
move RT_FROMCONTACT to a proper sip_peer field.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77712 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMove some global 'flags' to individual variables.
Luigi Rizzo [Sun, 29 Jul 2007 20:01:36 +0000 (20:01 +0000)]
Move some global 'flags' to individual variables.

Start putting these variables in a single struct (called 'sip_cfg' for the time
being, but it could as well be 'global' or some other name) so it
is easy, when reading the code, to figure out what they are for.

The downside of using struct fields instead of individual global
variables is that the compiler cannot tell if there are unused fields.
But the advantage of not cluttering the namespace and manilpulating
all these variables at once certainly overcome the disadvantagess.

Nothing to backport, again.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77711 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agominor simplification of a conditional statement
Luigi Rizzo [Sun, 29 Jul 2007 10:49:32 +0000 (10:49 +0000)]
minor simplification of a conditional statement

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77697 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agobuild the version of sip_tech with no send_digit_begin
Luigi Rizzo [Sun, 29 Jul 2007 10:13:14 +0000 (10:13 +0000)]
build the version of sip_tech with no send_digit_begin
at load time instead of duplicating the initializer.
This should remove the risk of forgetting fields in the
initializer.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77684 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoremove bit position from description of SIP_* flags.
Luigi Rizzo [Sun, 29 Jul 2007 09:27:30 +0000 (09:27 +0000)]
remove bit position from description of SIP_* flags.

use AST_FORMAT_AUDIO_MASK instead of playing with AST_FORMAT_MAX_AUDIO
to determine audio formats.
There is a dubious use of AST_FORMAT_MAX_AUDIO in sip_request_call()
which surely needs fixing, namely:

        /* mask request with some set of allowed formats.
         * XXX this needs to be fixed.
         * The original code uses AST_FORMAT_AUDIO_MASK, but it is
         * unclear what to use here. We have global_capabilities, which is
         * configured from sip.conf, and sip_tech.capabilities, which is
         * hardwired to all audio formats.
         */

The latter is possibly something to backport when fixed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77682 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoback on cleaning up the usage of flags.
Luigi Rizzo [Sun, 29 Jul 2007 08:58:10 +0000 (08:58 +0000)]
back on cleaning up the usage of flags.
Move together flags used in the same way (e.g. dialog only,
dialog-peer, ...) so it will become easier to deal with them
in a more systematic way.
This is being done in stages so it will be easier to detect
breakage, if any should occur.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77669 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomore documentation on internal representation of incoming SIP messages.
Luigi Rizzo [Sun, 29 Jul 2007 08:19:19 +0000 (08:19 +0000)]
more documentation on internal representation of incoming SIP messages.

Remove definitions for now-unused flags, and add references to print
routines for other flags.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77668 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomake register_unref() return NULL so it is easy to cleanup
Luigi Rizzo [Sun, 29 Jul 2007 00:06:35 +0000 (00:06 +0000)]
make register_unref() return NULL so it is easy to cleanup
the original pointer while calling the function.

on passing add some comments on one of the places where it
is used, and explain why it is safe there.

again, a no-op for practical purposes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77654 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoadd some documentation to auto_congest(), and some
Luigi Rizzo [Sat, 28 Jul 2007 23:43:35 +0000 (23:43 +0000)]
add some documentation to auto_congest(), and some
dialog_ref/unref (they are a no-op at the moment).
Also clean a pointer after freeing memory to avoid
dangling references, and write a for() loop in canonical form.

In practice, everything in this commit is a no-op.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77653 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomore dialog_ref()/dialog_unref() calls
Luigi Rizzo [Sat, 28 Jul 2007 17:16:24 +0000 (17:16 +0000)]
more dialog_ref()/dialog_unref() calls

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77650 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomore dialog_ref()/dialog_unref() calls
Luigi Rizzo [Sat, 28 Jul 2007 16:38:07 +0000 (16:38 +0000)]
more dialog_ref()/dialog_unref() calls

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77648 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agostart introducing hooks for reference counts on dialog descriptors.
Luigi Rizzo [Sat, 28 Jul 2007 16:25:25 +0000 (16:25 +0000)]
start introducing hooks for reference counts on dialog descriptors.
This commit is, for all practical purposes, a no-op, as it only
introduces the dialog_ref() and dialog_unref() methods, and uses them
in a few places (not all the places where they would be needed).

The goal is to start annotating the code with these calls, so the transition
to a proper container will be easier.

Nothing to backport.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77647 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoremove an unused string
Luigi Rizzo [Sat, 28 Jul 2007 09:32:10 +0000 (09:32 +0000)]
remove an unused string

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77631 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agosimplify a conditional expression using S_OR
Luigi Rizzo [Sat, 28 Jul 2007 09:29:22 +0000 (09:29 +0000)]
simplify a conditional expression using S_OR

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77630 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomake use of received= and rport= fields in sip replies.
Luigi Rizzo [Sat, 28 Jul 2007 07:44:16 +0000 (07:44 +0000)]
make use of received= and rport= fields in sip replies.

In a nutshell, these fields are used to tell a sip entity
the address and port its request came from, and are extremely
useful in the presence of NATs, especially with symmetric NATs
where STUN is totally ineffective.

This patch stores the address and port in the 'ourip' field of
the dialog descriptor, so they can be reused in subsequent transactions.
As it is, it works well for things like REGISTER requiring authentication,
because the second REGISTER request (with auth credentials) will carry
the correct address. Maybe it can also be useful, in case of an address
change, to do one or both of the following:

+ propagate the new address to the parent user/peer descriptor so that new
  dialogs will use the correct address from the beginning.
  This is trivial to implement, I am just waiting for feedback on this.

+ re-issue a request in case of an address change. This a lot less trivial,
  maybe unnecessary, and probably covered by the previous item.

I would seriously consider this patch for addition to 1.4 and 1.2.
The code is very little intrusive, and it would solve in a correct
way the nat traversal problems for which externip/externaddr/stunaddr
are only a partial and expensive workaround.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77616 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoSome ODBC drivers don't set the CHAR_OCTET_LENGTH field correctly.
Tilghman Lesher [Fri, 27 Jul 2007 23:21:23 +0000 (23:21 +0000)]
Some ODBC drivers don't set the CHAR_OCTET_LENGTH field correctly.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77603 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoTarget asterisk.pdf stopped building when the build was moved to the doc directory.
Tilghman Lesher [Fri, 27 Jul 2007 23:16:04 +0000 (23:16 +0000)]
Target asterisk.pdf stopped building when the build was moved to the doc directory.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77602 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77571 via svnmerge from
Tilghman Lesher [Fri, 27 Jul 2007 18:17:12 +0000 (18:17 +0000)]
Merged revisions 77571 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77571 | tilghman | 2007-07-27 13:15:58 -0500 (Fri, 27 Jul 2007) | 2 lines

Missing newline

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77572 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77540 via svnmerge from
Joshua Colp [Fri, 27 Jul 2007 17:05:18 +0000 (17:05 +0000)]
Merged revisions 77540 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77540 | file | 2007-07-27 14:04:08 -0300 (Fri, 27 Jul 2007) | 6 lines

(closes issue #10310)
Reported by: prashant_jois
Patches:
      cdr_pgsql.patch uploaded by prashant (license 114)
Finish the Postgresql connection after the log messages are printed so we don't access invalid memory.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77541 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoTurn 4 lines of code into 1 line that does the same thing.
Joshua Colp [Fri, 27 Jul 2007 16:31:55 +0000 (16:31 +0000)]
Turn 4 lines of code into 1 line that does the same thing.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77538 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77536 via svnmerge from
Joshua Colp [Fri, 27 Jul 2007 16:29:40 +0000 (16:29 +0000)]
Merged revisions 77536 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77536 | file | 2007-07-27 13:27:16 -0300 (Fri, 27 Jul 2007) | 6 lines

(closes issue #10323)
Reported by: julianjm
Patches:
      chan_sip_device_state_hold_fix.v1.diff.txt uploaded by julianjm (license 99)
Clear ONHOLD flag when decrementing the onHold peer count. If we did not do this the count may keep decreasing.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77537 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years ago'dialplan save' shouldn't be converting '|' back to ',' anymore.
Tilghman Lesher [Fri, 27 Jul 2007 16:20:55 +0000 (16:20 +0000)]
'dialplan save' shouldn't be converting '|' back to ',' anymore.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77534 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoThese fixes take care of two problems: a complaint in asterisk-dev that goto's aren...
Steve Murphy [Fri, 27 Jul 2007 15:46:20 +0000 (15:46 +0000)]
These fixes take care of two problems: a complaint in asterisk-dev that goto's aren't working in trunk, a side effect of the move to commas as arg seps in apps and funcs; and a problem I spotted myself with dial's 'e' option, where gotos were off by one, because I forgot to set the AUTOLOOP flag in the peer channel.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77520 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77490 via svnmerge from
Mark Michelson [Fri, 27 Jul 2007 14:31:35 +0000 (14:31 +0000)]
Merged revisions 77490 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77490 | mmichelson | 2007-07-27 09:30:43 -0500 (Fri, 27 Jul 2007) | 3 lines

"re-invite" was misspelled

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77491 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77460 via svnmerge from
Joshua Colp [Thu, 26 Jul 2007 23:20:25 +0000 (23:20 +0000)]
Merged revisions 77460 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77460 | file | 2007-07-26 20:19:04 -0300 (Thu, 26 Jul 2007) | 4 lines

(closes issue #10302)
Reported by: litnialex
If a DTMF end frame comes from a channel without a begin and it is going to a technology that only accepts end frames (aka INFO) then use the minimum DTMF duration if one is not in the frame already.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77461 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77424,77429 via svnmerge from
Kevin P. Fleming [Thu, 26 Jul 2007 22:17:25 +0000 (22:17 +0000)]
Merged revisions 77424,77429 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77424 | kpfleming | 2007-07-26 17:14:21 -0500 (Thu, 26 Jul 2007) | 2 lines

use new canonical name for download server

........
r77429 | kpfleming | 2007-07-26 17:16:42 -0500 (Thu, 26 Jul 2007) | 2 lines

change protocol for downloads as well

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77432 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77410 via svnmerge from
Russell Bryant [Thu, 26 Jul 2007 21:24:42 +0000 (21:24 +0000)]
Merged revisions 77410 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77410 | russell | 2007-07-26 16:23:23 -0500 (Thu, 26 Jul 2007) | 10 lines

AST_DEVMODE was defined in trunk, but not in 1.4.  When Asterisk is compiled
under dev mode, AST_DEVMODE will get defined in buildopts.h.  Change 1.4 to
define it in the same way that trunk does.  Also, revert the change that added
this define in the Makefile

The advantage to doing it this way is that buildopts.h gets installed when
you install Asterisk.  Then, when building any out of tree modules, or
building asterisk-addons, these modules know which options the rest of Asterisk
was built with.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77411 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77380 via svnmerge from
Mark Michelson [Thu, 26 Jul 2007 20:39:46 +0000 (20:39 +0000)]
Merged revisions 77380 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77380 | mmichelson | 2007-07-26 15:35:17 -0500 (Thu, 26 Jul 2007) | 7 lines

Fixes to get ast_backtrace working properly. The AST_DEVMODE macro was never defined so the majority of ast_backtrace never
attempted compilation. The makefile now defines AST_DEVMODE if configure was run with --enable-dev-mode. Also, changes were
made to acccomodate 64 bit systems in ast_backtrace.

Thanks to qwell, kpfleming, and Corydon76 for their roles in allowing me to get this committed

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77381 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77350 via svnmerge from
Tilghman Lesher [Thu, 26 Jul 2007 19:33:47 +0000 (19:33 +0000)]
Merged revisions 77350 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77350 | tilghman | 2007-07-26 14:32:17 -0500 (Thu, 26 Jul 2007) | 2 lines

Missed one

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77351 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77348 via svnmerge from
Tilghman Lesher [Thu, 26 Jul 2007 19:29:12 +0000 (19:29 +0000)]
Merged revisions 77348 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77348 | tilghman | 2007-07-26 14:27:18 -0500 (Thu, 26 Jul 2007) | 2 lines

Oops, that builtin define should be all-lowercase.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77349 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77318 via svnmerge from
Mark Michelson [Thu, 26 Jul 2007 18:31:28 +0000 (18:31 +0000)]
Merged revisions 77318 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77318 | mmichelson | 2007-07-26 13:30:29 -0500 (Thu, 26 Jul 2007) | 8 lines

Two consecutive calls to PQfinish could occur, meaning free gets called on the same variable twice.
This patch sets the connection to NULL after calls to PQfinish so that the problem does not occur.
Also in this patch, prashant_jois informed me that it is safe to pass a null pointer to PQfinish, so
I have removed the check for conn's existence from my_unload_module.

(closes issue 10295, reported by junky, patched by me with input from prashant_jois)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77319 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoDo a massive conversion for using the ast_verb() macro
Russell Bryant [Thu, 26 Jul 2007 15:49:18 +0000 (15:49 +0000)]
Do a massive conversion for using the ast_verb() macro
(closes issue #10277, patches by mvanbaak)

Basically, this changes ...

if (option_verbose > 2)
   ast_verbose(VERBOSE_PREFIX_3, "Something\n");

to ...

ast_verb(3, "Something\n");

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77299 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerge a big batch of documentation fixes for escaping, marking URLs, places
Russell Bryant [Thu, 26 Jul 2007 14:49:51 +0000 (14:49 +0000)]
Merge a big batch of documentation fixes for escaping, marking URLs, places
where verbatim text went off the end of the page on the PDF, and various
other improvements
(closes issue #10307, IgorG)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77284 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoRevert some changes to call abs() on the result of ast_random().
Russell Bryant [Thu, 26 Jul 2007 13:26:44 +0000 (13:26 +0000)]
Revert some changes to call abs() on the result of ast_random().
 * random() is defined to return a positive result, and now ast_random()
   will always do so as well

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77269 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoEnsure that the read from /dev/urandom returns a positive result
Russell Bryant [Thu, 26 Jul 2007 13:20:36 +0000 (13:20 +0000)]
Ensure that the read from /dev/urandom returns a positive result
(closes issue #10308, reported by yehavi, patched by me)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77268 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoThings expecting a positive result from ast_random() should not be surprised (closes...
Tilghman Lesher [Thu, 26 Jul 2007 13:19:07 +0000 (13:19 +0000)]
Things expecting a positive result from ast_random() should not be surprised (closes #10308)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77267 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoAdd a link to the list of assigned RTP payload types for convenience.
Russell Bryant [Thu, 26 Jul 2007 13:10:49 +0000 (13:10 +0000)]
Add a link to the list of assigned RTP payload types for convenience.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77266 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agodocument how the RTP marker bit is passed for video frames,
Luigi Rizzo [Thu, 26 Jul 2007 05:35:42 +0000 (05:35 +0000)]
document how the RTP marker bit is passed for video frames,
and why this does not overwrite useful information.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77248 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoadd an entry for h263plus in an empty slot of the rtp types.
Luigi Rizzo [Thu, 26 Jul 2007 04:47:54 +0000 (04:47 +0000)]
add an entry for h263plus in an empty slot of the rtp types.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77233 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoThe upgrade of application argument separators to comma has an effect on AEL; I comme...
Steve Murphy [Thu, 26 Jul 2007 01:33:55 +0000 (01:33 +0000)]
The upgrade of application argument separators to comma has an effect on AEL; I commented out the code that substitutes commas with vertbars, so we can get apps to parse their args correctly.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77218 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77191 via svnmerge from
Steve Murphy [Thu, 26 Jul 2007 01:13:07 +0000 (01:13 +0000)]
Merged revisions 77191 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77191 | murf | 2007-07-25 16:39:27 -0600 (Wed, 25 Jul 2007) | 1 line

This fix solves problem with intense squelch noise when someone joins conf in bug 9430; We repro'd the problem with meetme opts of 'CciMo'; Josh Colp supplied this patch, and I'm applying it. It looks like playing the recorded username will louse up the next thing played into the channel. Josh rearranged the code so as to start things over before playing data directly into the conference.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77217 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77176 via svnmerge from
Joshua Colp [Wed, 25 Jul 2007 22:18:56 +0000 (22:18 +0000)]
Merged revisions 77176 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77176 | file | 2007-07-25 19:16:10 -0300 (Wed, 25 Jul 2007) | 4 lines

(closes issue #10303)
Reported by: jtodd
Add SPEECH_DTMF_TERMINATOR variable so the user can specify the digit to terminate a DTMF string with. If none is specified then no terminator will be used.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77182 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agosilence a warning in ast-devmode on a potentially uninitialized var.
Luigi Rizzo [Wed, 25 Jul 2007 21:58:13 +0000 (21:58 +0000)]
silence a warning in ast-devmode on a potentially uninitialized var.
At first sight (but the function is very large so i am not 100% sure)
the code seems correct, so maybe my compiler is just not smart
enough to figure that out at the optimization level it has.

Not worthwhile merging to 1.4 i believe.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77156 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77154 via svnmerge from
Mark Michelson [Wed, 25 Jul 2007 21:53:35 +0000 (21:53 +0000)]
Merged revisions 77154 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77154 | mmichelson | 2007-07-25 16:52:47 -0500 (Wed, 25 Jul 2007) | 3 lines

chan->emulate_dtmf_duration is an unsigned int, not a signed int, so use %u instead of %d in the format string

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77155 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77071 via svnmerge from
Joshua Colp [Wed, 25 Jul 2007 17:16:11 +0000 (17:16 +0000)]
Merged revisions 77071 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77071 | file | 2007-07-25 14:14:14 -0300 (Wed, 25 Jul 2007) | 2 lines

Fix autoconf logic for finding OpenH323 when it is not in the first place searched (/usr/share/openh323).

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77072 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agochange the debug level to 3 for an exceedingly annoying message
Luigi Rizzo [Wed, 25 Jul 2007 14:13:17 +0000 (14:13 +0000)]
change the debug level to 3 for an exceedingly annoying message
(3-deep nested loop)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77054 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77022 via svnmerge from
Luigi Rizzo [Wed, 25 Jul 2007 09:45:15 +0000 (09:45 +0000)]
Merged revisions 77022 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77022 | rizzo | 2007-07-25 11:34:01 +0200 (Wed, 25 Jul 2007) | 3 lines

set the sequence number in a frame for all frame types

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77023 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoremove a couple of entries that got duplicated and snuck into the SIP section. Also...
Russell Bryant [Wed, 25 Jul 2007 01:06:02 +0000 (01:06 +0000)]
remove a couple of entries that got duplicated and snuck into the SIP section.  Also, align the NAT/STUN entry with the others.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76985 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 76983 via svnmerge from
Steve Murphy [Wed, 25 Jul 2007 00:34:42 +0000 (00:34 +0000)]
Merged revisions 76983 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r76983 | murf | 2007-07-24 18:18:32 -0600 (Tue, 24 Jul 2007) | 9 lines

Merged revisions 76978 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r76978 | murf | 2007-07-24 18:07:24 -0600 (Tue, 24 Jul 2007) | 1 line

this fixes bug 10293, where the error message because defaultzone or loadzone was not defined was confusing
........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76984 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 76937 via svnmerge from
Tilghman Lesher [Tue, 24 Jul 2007 22:13:37 +0000 (22:13 +0000)]
Merged revisions 76937 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r76937 | tilghman | 2007-07-24 17:12:43 -0500 (Tue, 24 Jul 2007) | 10 lines

Merged revisions 76934 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r76934 | tilghman | 2007-07-24 17:11:33 -0500 (Tue, 24 Jul 2007) | 2 lines

Oops, res contains the error code, not errno.  I was wondering why a mutex was reporting "No such file or directory"...

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76940 65c4cc65-6c06-0410-ace0-fbb531ad65f3