asterisk/asterisk.git
10 years agoJanitor, use ARRAY_LEN() when possible.
Eliel C. Sardanons [Fri, 5 Dec 2008 10:31:25 +0000 (10:31 +0000)]
Janitor, use ARRAY_LEN() when possible.

(closes issue #13990)
Reported by: eliel
Patches:
      array_len.diff uploaded by eliel (license 64)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161218 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoThe first file should have a blank config filename in the structure, so that
Tilghman Lesher [Fri, 5 Dec 2008 05:41:41 +0000 (05:41 +0000)]
The first file should have a blank config filename in the structure, so that
when a save occurs to a different filename, everything goes to the alternate
filename, instead of appending to the original.  This is important for the
AMI command UpdateConfig.
(closes issue #13301)
 Reported by: trevo
 Patches:
       20081113__bug13301.diff.txt uploaded by Corydon76 (license 14)
       20081113__bug13301__1.6.0.diff.txt uploaded by Corydon76 (license 14)
 Tested by: Corydon76, blitzrage

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161181 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCheck the return value of fread/fwrite so the compiler doesn't complain. Only a
Sean Bright [Fri, 5 Dec 2008 02:47:54 +0000 (02:47 +0000)]
Check the return value of fread/fwrite so the compiler doesn't complain.  Only a
problem when IMAP_STORAGE is enabled.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161147 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoIf 'faxdetect=yes' in sip.conf, switch to a 'fax' extension (if it exists) after...
Dwayne M. Hubbard [Thu, 4 Dec 2008 23:00:30 +0000 (23:00 +0000)]
If 'faxdetect=yes' in sip.conf, switch to a 'fax' extension (if it exists) after T38 is negotiated.
Terry Wilson created the original patch for this functionality, which I slightly modified and added
the faxdetect=yes|no configuration option.  This patch is only for T38 fax detection and does not
do anything for G711 over SIP fax detection.  By default, this option is disabled.

Reviewboard: http://reviewboard.digium.com/r/69/

This functionality is for issue AST-140.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161115 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix minor coding guidelines introduced with CLI permissions.
Eliel C. Sardanons [Thu, 4 Dec 2008 19:31:48 +0000 (19:31 +0000)]
Fix minor coding guidelines introduced with CLI permissions.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161077 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 161013 via svnmerge from
Jeff Peeler [Thu, 4 Dec 2008 18:32:20 +0000 (18:32 +0000)]
Merged revisions 161013 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r161013 | jpeeler | 2008-12-04 12:30:41 -0600 (Thu, 04 Dec 2008) | 9 lines

(closes issue #13835)
Reported by: matt_b
Tested by: jpeeler

This mirrors a check that was present in ast_rtp_read to also be in ast_rtp_raw_write to not schedule sending the receiver report if the remote RTCP endpoint address isn't present in the RTCP structure.

Closes AST-142.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161014 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 160943 via svnmerge from
Mark Michelson [Thu, 4 Dec 2008 16:45:06 +0000 (16:45 +0000)]
Merged revisions 160943 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r160943 | mmichelson | 2008-12-04 10:44:18 -0600 (Thu, 04 Dec 2008) | 15 lines

Fix a callerid parsing issue. If someone formatted callerid like the
following: "name <number>" (including the quotation marks), then the parts
would be parsed as

name: "name
number: number

This is because the closing quotation mark was not discovered since the number
and everything after was parsed out of the string earlier. Now, there is a check
to see if the closing quote occurs after the number, so that we can know if we
should strip off the opening quote on the name.

Closes AST-158

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160945 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd debug flag so skinny debug will show information about packets.
Michiel van Baak [Thu, 4 Dec 2008 16:37:13 +0000 (16:37 +0000)]
Add debug flag so skinny debug will show information about packets.
We dont want to scare users with this, so we added a devmode compile flag

(closes issue #13952)
Reported by: wedhorn
Patches:
      packetdebug3.diff uploaded by wedhorn (license 30)
Tested by: mvanbaak, wedhorn

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160938 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdded XML documentation for the following AGI commands:
Eliel C. Sardanons [Thu, 4 Dec 2008 13:45:32 +0000 (13:45 +0000)]
Added XML documentation for the following AGI commands:
        - get option
        - get variable
        - hangup
        - noop

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160896 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoJcolp pointed out that num will also match number
Richard Mudgett [Thu, 4 Dec 2008 01:36:39 +0000 (01:36 +0000)]
Jcolp pointed out that num will also match number

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160856 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago* Found a couple more places where num/number needed to be done
Richard Mudgett [Thu, 4 Dec 2008 01:14:22 +0000 (01:14 +0000)]
*  Found a couple more places where num/number needed to be done
so 1.4 upgraders will not have problems.
*  Added curly braces and minor tweaks.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160854 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 160770 via svnmerge from
Tilghman Lesher [Wed, 3 Dec 2008 21:58:21 +0000 (21:58 +0000)]
Merged revisions 160770 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160770 | tilghman | 2008-12-03 15:54:07 -0600 (Wed, 03 Dec 2008) | 2 lines

  Some compilers warn on null format strings; some don't (caught by buildbot)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160791 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 160764 via svnmerge
Jason Parker [Wed, 3 Dec 2008 21:38:50 +0000 (21:38 +0000)]
Blocked revisions 160764 via svnmerge

........
  r160764 | qwell | 2008-12-03 15:38:07 -0600 (Wed, 03 Dec 2008) | 7 lines

  Only show this warning when we want to show it.

  (closes issue #13982)
  Reported by: coolmig
  Patches:
        chan_agent.c.patch uploaded by coolmig (license 621)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160765 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 160703 via svnmerge from
Steve Murphy [Wed, 3 Dec 2008 21:09:15 +0000 (21:09 +0000)]
Merged revisions 160703 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r160703 | murf | 2008-12-03 13:41:42 -0700 (Wed, 03 Dec 2008) | 11 lines

(closes issue #13597)
Reported by: john8675309
Patches:
      patch.13597 uploaded by murf (license 17)
Tested by: murf, john8675309

This patch causes the setcid func to update the CDR
clid after setting the channel field.

I also notice that in trunk, the num/number of 1.4 is
left out; I decided to include the option to use
either in trunk, so as not to have 1.4 upgraders
not to have problems.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160760 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAnother place this is missing
Jason Parker [Wed, 3 Dec 2008 20:35:36 +0000 (20:35 +0000)]
Another place this is missing

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160700 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix typo when ListCategories returns none.
Jason Parker [Wed, 3 Dec 2008 20:32:20 +0000 (20:32 +0000)]
Fix typo when ListCategories returns none.

(closes issue #13994)
Reported by: mika
Patches:
      ListCategoriesActionPatch.diff uploaded by mika (license 624)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160699 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago- iax2-provision was not freeing iax_templates structure when unloading the chan_iax2...
Eliel C. Sardanons [Wed, 3 Dec 2008 19:25:30 +0000 (19:25 +0000)]
- iax2-provision was not freeing iax_templates structure when unloading the chan_iax2.so module.
- Move the code to start using the LIST macros.

Review: http://reviewboard.digium.com/r/72

(closes issue #13232)
Reported by: eliel
Patches:
      iax2-provision.patch.txt uploaded by eliel (license 64)
      (with minor changes pointed by Mark Michelson on review board)
Tested by: eliel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160663 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd some safety measures when using gosub, especially when using the options
Mark Michelson [Wed, 3 Dec 2008 18:37:46 +0000 (18:37 +0000)]
Add some safety measures when using gosub, especially when using the options
for app_dial and app_queue to run a gosub when the call is answered.

* Check for the existence of the gosub target in gosub_exec. If it is nonexistent,
  then this will cause errors when we attempt to actually run the gosub, including
  a definite memory leak and potential crashes. Return an error in this situation
* Check the return value of pbx_exec in app_dial and app_queue before attempting
  to actually run the gosub routine. If there was an error, we should not attempt
  to run the gosub.
* Change a '|' to a ',' in app_queue.
* Add some extra curly braces where they had been missing previously.

(closes issue #13548)
Reported by: fiddur

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160626 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 160570 via svnmerge
Tilghman Lesher [Wed, 3 Dec 2008 17:59:36 +0000 (17:59 +0000)]
Blocked revisions 160570 via svnmerge

........
  r160570 | tilghman | 2008-12-03 11:55:12 -0600 (Wed, 03 Dec 2008) | 5 lines

  During bridge code, the channel bridge may return a retry code, if a transfer
  was initiated but not yet completed.  If the bridge is immediately retried,
  then we may send a storm of TXREQ packets, even though the first set is sent
  reliably (retransmitted).  Fixes AST-137.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160585 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago- Add <variable /> tags when naming a channel variable.
Eliel C. Sardanons [Wed, 3 Dec 2008 17:48:47 +0000 (17:48 +0000)]
- Add <variable /> tags when naming a channel variable.
- Add <filename /> tags when naming a filename.
- Simplify the xml formatting putting some enters.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160562 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 160558 via svnmerge from
Tilghman Lesher [Wed, 3 Dec 2008 17:38:59 +0000 (17:38 +0000)]
Merged revisions 160558 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160558 | tilghman | 2008-12-03 11:34:34 -0600 (Wed, 03 Dec 2008) | 7 lines

  If an entry is added to the directory during a scan when another entry expires,
  then that new entry will not be processed promptly, but must wait for either a
  future entry to start or a current entry's retry to occur.  If no other entries
  exist in the directory (other than the new entries) when a bunch expire, then
  the new entries must wait until another new entry is added to be processed.
  This was a rather weird race condition, really.  Fixes AST-147.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160559 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoWhen investigating issue #13548, I found that gosub
Mark Michelson [Wed, 3 Dec 2008 17:07:09 +0000 (17:07 +0000)]
When investigating issue #13548, I found that gosub
handling in app_queue was just completely wrong, mostly
because the channel operations being performed were being
done on the incorrect channel.

With this set of changes, a gosub will correctly run on
the answering queue member's channel. There are still crash
issues which occur if there are dialplan syntax errors, so
I cannot yet close the referenced issue.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160555 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 160551 via svnmerge from
Tilghman Lesher [Wed, 3 Dec 2008 17:01:03 +0000 (17:01 +0000)]
Merged revisions 160551 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160551 | tilghman | 2008-12-03 10:58:34 -0600 (Wed, 03 Dec 2008) | 4 lines

  Don't start scanning the directory until all modules are loaded, because some
  required modules (channels, apps, functions) may not yet be in memory yet.
  Fixes AST-149.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160552 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 160480 via svnmerge from
Tilghman Lesher [Wed, 3 Dec 2008 14:11:53 +0000 (14:11 +0000)]
Merged revisions 160480 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160480 | tilghman | 2008-12-03 08:09:35 -0600 (Wed, 03 Dec 2008) | 7 lines

  Jon Bonilla (Manwe) pointed out on the -dev list:
  "I guess that having only ip-phones in mind is not a good approach. Since it is
  possible to have a sip proxy connected to asterisk we could receive a 407
  (unauthorized) or 483 (too many hops) as response and dialog ending would not be
  a good behavior."
  So modified.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160481 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago- Avoid setting .synopsis and .syntax if we are using XML documentation (or the
Eliel C. Sardanons [Wed, 3 Dec 2008 11:01:23 +0000 (11:01 +0000)]
- Avoid setting .synopsis and .syntax if we are using XML documentation (or the
xml documentation wont be loaded).
- Use <variable></variable> to refer to a dialplan variable.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160447 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoInfo on LOCAL_PEEK function.
Tilghman Lesher [Tue, 2 Dec 2008 18:48:51 +0000 (18:48 +0000)]
Info on LOCAL_PEEK function.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160346 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd LOCAL_PEEK function, as requested by lmadsen.
Tilghman Lesher [Tue, 2 Dec 2008 18:39:12 +0000 (18:39 +0000)]
Add LOCAL_PEEK function, as requested by lmadsen.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160344 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoremove duplicate comment that I accidentally merged
Jeff Peeler [Tue, 2 Dec 2008 18:04:51 +0000 (18:04 +0000)]
remove duplicate comment that I accidentally merged

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160333 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago(closes issue #13786)
Jeff Peeler [Tue, 2 Dec 2008 18:00:24 +0000 (18:00 +0000)]
(closes issue #13786)
Reported by: tzafrir

Readding DAHDI_CHECK_HOOKSTATE define that was removed in r134260 which fixes not being able to make outgoing calls on some FXO adapters:
http://lists.digium.com/pipermail/asterisk-users/2008-November/thread.html#221553

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160319 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 160297 via svnmerge from
Tilghman Lesher [Tue, 2 Dec 2008 17:56:24 +0000 (17:56 +0000)]
Merged revisions 160297 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160297 | tilghman | 2008-12-02 11:42:09 -0600 (Tue, 02 Dec 2008) | 10 lines

  When the text does not match exactly (e.g. RTP/SAVP), then the %n conversion
  fails, and the resulting integer is garbage.  Thus, we must initialize the
  integer and check it afterwards for success.
  (closes issue #14000)
   Reported by: folke
   Patches:
         asterisk-sipbg-sscanf-1.4.22.diff uploaded by folke (license 626)
         asterisk-sipbg-sscanf-1.6.0.1.diff uploaded by folke (license 626)
         asterisk-sipbg-sscanf-trunk-r159896.diff uploaded by folke (license 626)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160308 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 160207 via svnmerge from
Tilghman Lesher [Tue, 2 Dec 2008 00:37:21 +0000 (00:37 +0000)]
Merged revisions 160207 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160207 | tilghman | 2008-12-01 18:25:16 -0600 (Mon, 01 Dec 2008) | 3 lines

  Ensure that Asterisk builds with --enable-dev-mode, even on the latest gcc
  and glibc.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160208 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 159976 via svnmerge from
Sean Bright [Mon, 1 Dec 2008 23:37:49 +0000 (23:37 +0000)]
Merged revisions 159976 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r159976 | mvanbaak | 2008-12-01 11:08:36 -0500 (Mon, 01 Dec 2008) | 3 lines

  Get rid of the useless format string and argument in the Bogus/ manager channelname.
  Noted by kpfleming and name Bogus/manager suggested by eliel
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160172 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSilence a build warning. (chan_phone.c:810: warning: value computed is not used)
Sean Bright [Mon, 1 Dec 2008 23:18:48 +0000 (23:18 +0000)]
Silence a build warning. (chan_phone.c:810: warning: value computed is not used)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160171 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoPay attention to the return value of system(), even if we basically ignore it.
Sean Bright [Mon, 1 Dec 2008 23:08:24 +0000 (23:08 +0000)]
Pay attention to the return value of system(), even if we basically ignore it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160170 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUse AST_EXT_LIB_SETUP before using AST_EXT_LIB_CHECK or bad things happen.
Tilghman Lesher [Mon, 1 Dec 2008 21:23:37 +0000 (21:23 +0000)]
Use AST_EXT_LIB_SETUP before using AST_EXT_LIB_CHECK or bad things happen.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160097 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoIntroduce CLI permissions.
Eliel C. Sardanons [Mon, 1 Dec 2008 18:52:14 +0000 (18:52 +0000)]
Introduce CLI permissions.
Based on cli_permissions.conf configuration file, we are able to permit or deny
cli commands based on some patterns and the local user and group running rasterisk.

(Sorry if I missed some of the testers).

Reviewboard: http://reviewboard.digium.com/r/11/

(closes issue #11123)
Reported by: eliel
Tested by: eliel, IgorG, Laureano, otherwiseguy, mvanbaak

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160062 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 160003 via svnmerge from
Russell Bryant [Mon, 1 Dec 2008 17:34:31 +0000 (17:34 +0000)]
Merged revisions 160003 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r160003 | russell | 2008-12-01 11:27:30 -0600 (Mon, 01 Dec 2008) | 6 lines

Apply some logic used in iax2_indicate() to iax2_setoption(), as well, since they
both have the potential to send control frames in the middle of call setup.  We
have to wait until we have received a message back from the remote end before
we try to send any more frames.  Otherwise, the remote end will consider it
invalid, and we'll get stuck in an INVAL/VNAK storm.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160004 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 159900 via svnmerge from
Russell Bryant [Mon, 1 Dec 2008 14:56:10 +0000 (14:56 +0000)]
Merged revisions 159900 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r159900 | russell | 2008-12-01 08:52:56 -0600 (Mon, 01 Dec 2008) | 2 lines

Force a "make clean" to avoid a bizarre build issue ...

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159911 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 159897 via svnmerge from
Michiel van Baak [Mon, 1 Dec 2008 14:09:59 +0000 (14:09 +0000)]
Merged revisions 159897 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r159897 | mvanbaak | 2008-12-01 15:05:41 +0100 (Mon, 01 Dec 2008) | 4 lines

  make manager compile on OpenBSD.
  The last (10th) argument to ast_channel_alloc here should be a pointer
  and NULL is not really a pointer.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159898 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAllow the '#' sign to exist within an extension (inspired by issue #13330)
Tilghman Lesher [Sat, 29 Nov 2008 18:33:18 +0000 (18:33 +0000)]
Allow the '#' sign to exist within an extension (inspired by issue #13330)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159853 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoincorporates r159808 from branches/1.4:
Kevin P. Fleming [Sat, 29 Nov 2008 17:57:39 +0000 (17:57 +0000)]
incorporates r159808 from branches/1.4:
------------------------------------------------------------------------
r159808 | kpfleming | 2008-11-29 10:58:29 -0600 (Sat, 29 Nov 2008) | 7 lines

update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors

since this branch already had some printf format attributes, enable checking for them and tag functions that didn't have them

format attributes in a consistent way

------------------------------------------------------------------------

in addition:

move some format attributes from main/utils.c to the header files they belong in, and fix up references to the relevant functions based on new compiler warnings

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159818 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agowe can now build with -Wformat=2, which found a couple of real bugs
Kevin P. Fleming [Sat, 29 Nov 2008 15:29:33 +0000 (15:29 +0000)]
we can now build with -Wformat=2, which found a couple of real bugs

because SPRINTF() use non-literal format strings (which cannot be checked), move it into its own module so the rest of func_strings can benefit from format string checking

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159774 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake res_config_ldap compile with the official OpenLDAP 2.3.X versions.
Michiel van Baak [Fri, 28 Nov 2008 14:20:11 +0000 (14:20 +0000)]
Make res_config_ldap compile with the official OpenLDAP 2.3.X versions.
They removed the LDAP_DEPRECATED define from their source and since we are using a couple
of deprecated function calls we should define it with a CFLAG.

Tested by me on OpenBSD 4.4 and snuff-home on Linux to make sure everything keeps compiling.
It shouldn't break, we only define the LDAP_DEPRECATED with this which is what
all 2.2.X and older versions of OpenLDAP did in their own tree.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159734 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemoved duplicate code
Philippe Sultan [Thu, 27 Nov 2008 20:29:21 +0000 (20:29 +0000)]
Removed duplicate code

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159701 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake a formatting change to test a new post-commit hook for reviewboard.
Russell Bryant [Wed, 26 Nov 2008 22:11:55 +0000 (22:11 +0000)]
Make a formatting change to test a new post-commit hook for reviewboard.

http://reviewboard.digium.com/r/65/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159666 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake a formatting change to test a new post-commit hook for reviewboard.
Russell Bryant [Wed, 26 Nov 2008 22:08:33 +0000 (22:08 +0000)]
Make a formatting change to test a new post-commit hook for reviewboard.

http://reviewboard.digium.com/r/65/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159665 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake a formatting change to test a new post-commit hook for reviewboard.
Russell Bryant [Wed, 26 Nov 2008 22:01:34 +0000 (22:01 +0000)]
Make a formatting change to test a new post-commit hook for reviewboard.

http://reviewboard.digium.com/r/65/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159664 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoimprove handling of API calls provided by loaded modules through use of some GCC...
Kevin P. Fleming [Wed, 26 Nov 2008 21:20:50 +0000 (21:20 +0000)]
improve handling of API calls provided by loaded modules through use of some GCC features; this makes app_stack's usage of AGI APIs even cleaner, and will allow it to work 'as expected' either with or without res_agi being loaded

reviewed at http://reviewboard.digium.com/r/62

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159631 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoadd support for event suppression for AMI-over-HTTP
Kevin P. Fleming [Wed, 26 Nov 2008 21:09:58 +0000 (21:09 +0000)]
add support for event suppression for AMI-over-HTTP

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159629 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 159571 via svnmerge
Kevin P. Fleming [Wed, 26 Nov 2008 20:35:14 +0000 (20:35 +0000)]
Blocked revisions 159571 via svnmerge

........
  r159571 | kpfleming | 2008-11-26 14:21:04 -0600 (Wed, 26 Nov 2008) | 2 lines

  rename these files so as to avoid conflicts when users update their working copies and have unversioned files already in place
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159573 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd some necessary hangup commands in the case that forwarding
Mark Michelson [Wed, 26 Nov 2008 19:57:11 +0000 (19:57 +0000)]
Add some necessary hangup commands in the case that forwarding
a call fails

1) Hang up the original destination if the local channel cannot
   be requested.
2) Hang up the local channel (in addition to the original destination)
   if ast_call fails when calling the newly created local channel.

This prevents channels from sticking around forever in the
case of a botched call forward (e.g. to an extension which does not
exist).

(closes issue #13764)
Reported by: davidw
Patches:
      13764_v2.patch uploaded by putnopvut (license 60)
Tested by: putnopvut, davidw

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159554 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 159476 via svnmerge from
Kevin P. Fleming [Wed, 26 Nov 2008 19:08:56 +0000 (19:08 +0000)]
Merged revisions 159476 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r159476 | kpfleming | 2008-11-26 12:36:24 -0600 (Wed, 26 Nov 2008) | 7 lines

  simplify (and slightly bug-fix) the recent developer-oriented COMPILE_DOUBLE mode

  ensure that 'make clean' removes dependency files for .i files that are created in COMPILE_DOUBLE mode
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159534 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoIf the config file does not exist, then the first use crashes Asterisk.
Tilghman Lesher [Wed, 26 Nov 2008 18:33:04 +0000 (18:33 +0000)]
If the config file does not exist, then the first use crashes Asterisk.
(closes issue #13848)
 Reported by: klaus3000
 Patches:
       udptl.c.patch uploaded by eliel (license 64)
 Tested by: blitzrage

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159475 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDon't allow for configuration options to overwrite options
Mark Michelson [Wed, 26 Nov 2008 14:58:17 +0000 (14:58 +0000)]
Don't allow for configuration options to overwrite options
set via channel variables on a reload.

(closes issue #13921)
Reported by: davidw
Patches:
      13921.patch uploaded by putnopvut (license 60)
Tested by: davidw

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159437 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAlways parse arguments in park_call_exec so that app_args is valid. This prevents...
Jeff Peeler [Wed, 26 Nov 2008 03:18:01 +0000 (03:18 +0000)]
Always parse arguments in park_call_exec so that app_args is valid. This prevents a crash when executing Park from the dialplan with no arguments.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159402 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 159316 via svnmerge from
Steve Murphy [Tue, 25 Nov 2008 23:03:01 +0000 (23:03 +0000)]
Merged revisions 159316 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r159316 | murf | 2008-11-25 15:41:10 -0700 (Tue, 25 Nov 2008) | 15 lines

(closes issue #12694)
Reported by: yraber
Patches:
      12694.2nd.diff uploaded by murf (license 17)
Tested by: murf, laurav

Thanks to file (Joshua Colp) for his IAX fix.

the change to cdr.c allows no-answer to percolate
up into CDR's, and feels like the right place to
locate this fix; if BUSY is done here, no-answer
should be, too.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159360 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd an option, waitfordialtone, for UK analog lines which do not end a call
Tilghman Lesher [Tue, 25 Nov 2008 22:45:59 +0000 (22:45 +0000)]
Add an option, waitfordialtone, for UK analog lines which do not end a call
until the originating line hangs up.
(closes issue #12382)
 Reported by: one47
 Patches:
       zap-waitfordialtone-trunk.080901.patch uploaded by one47 (license 23)
       zap-waitfordialtone-bra-1.4.21.2.patch uploaded by fleed (license 463)
 Tested by: fleed

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159317 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 159269 via svnmerge from
Tilghman Lesher [Tue, 25 Nov 2008 21:57:59 +0000 (21:57 +0000)]
Merged revisions 159269 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r159269 | tilghman | 2008-11-25 15:56:48 -0600 (Tue, 25 Nov 2008) | 7 lines

  Don't try to send a response on a NULL pvt.
  (closes issue #13919)
   Reported by: barthpbx
   Patches:
         chan_iax2.c.patch uploaded by eliel (license 64)
   Tested by: barthpbx
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159276 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake the options for the general and profiles more consistent
Mark Michelson [Tue, 25 Nov 2008 21:49:42 +0000 (21:49 +0000)]
Make the options for the general and profiles more consistent
for the "pls_hold_prompt" option. This does not affect any released
version of Asterisk, so there is no need to update the CHANGES
file for this.

(closes issue #13893)
Reported by: eliel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159250 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 159246 via svnmerge from
Tilghman Lesher [Tue, 25 Nov 2008 21:42:42 +0000 (21:42 +0000)]
Merged revisions 159246 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
  r159246 | tilghman | 2008-11-25 15:40:28 -0600 (Tue, 25 Nov 2008) | 14 lines

  Merged revisions 159245 via svnmerge from
  https://origsvn.digium.com/svn/asterisk/branches/1.2

  ........
    r159245 | tilghman | 2008-11-25 15:37:06 -0600 (Tue, 25 Nov 2008) | 7 lines

    Regression fix for last security fix.  Set the iseqno correctly.
    (closes issue #13918)
     Reported by: ffloimair
     Patches:
           20081119__bug13918.diff.txt uploaded by Corydon76 (license 14)
     Tested by: ffloimair
  ........
................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159247 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDon't actually do anything with a negative priority, because we ignore it in
Tilghman Lesher [Tue, 25 Nov 2008 18:01:02 +0000 (18:01 +0000)]
Don't actually do anything with a negative priority, because we ignore it in
the result, anyway.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159189 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDon't limit the length of the hint at the final step (from ~8100 chars max
Tilghman Lesher [Tue, 25 Nov 2008 17:44:30 +0000 (17:44 +0000)]
Don't limit the length of the hint at the final step (from ~8100 chars max
(or ~500 chars max on LOW_MEMORY) to 80 chars max).  This will allow more
channels to be used in a single hint.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159162 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 159158 via svnmerge
Russell Bryant [Tue, 25 Nov 2008 17:35:33 +0000 (17:35 +0000)]
Blocked revisions 159158 via svnmerge

........
r159158 | russell | 2008-11-25 11:34:50 -0600 (Tue, 25 Nov 2008) | 2 lines

Add ao2_trylock() to go along with ao2_lock() and ao2_unlock()

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159159 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd missing variable declaration for PPC code
Terry Wilson [Tue, 25 Nov 2008 16:18:53 +0000 (16:18 +0000)]
Add missing variable declaration for PPC code

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159093 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCopyright clarification; also, have variable set to "t" or "i" on timeout or
Tilghman Lesher [Tue, 25 Nov 2008 05:19:53 +0000 (05:19 +0000)]
Copyright clarification; also, have variable set to "t" or "i" on timeout or
invalid extension, respectively.
(closes issue #13944)
 Reported by: chappell

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159054 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 159025 via svnmerge from
Tilghman Lesher [Tue, 25 Nov 2008 05:02:11 +0000 (05:02 +0000)]
Merged revisions 159025 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r159025 | tilghman | 2008-11-24 22:50:00 -0600 (Mon, 24 Nov 2008) | 3 lines

  System call ioperm is non-portable, so check for its existence in autoconf.
  (Closes issue #13863)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159050 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake chan_usbradio compile under dev mode
Terry Wilson [Tue, 25 Nov 2008 03:49:30 +0000 (03:49 +0000)]
Make chan_usbradio compile under dev mode

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158992 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoThis is basically a complete rollback of r155401, as it was determined that
Sean Bright [Tue, 25 Nov 2008 01:01:49 +0000 (01:01 +0000)]
This is basically a complete rollback of r155401, as it was determined that
it would be best to maintain API compatibility.  Instead, this commit introduces
ao2_callback_data() which is functionally identical to ao2_callback() except
that it allows you to pass arbitrary data to the callback.

Reviewed by Mark Michelson via ReviewBoard:
http://reviewboard.digium.com/r/64

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158959 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix compiling in dev mode.
Matthew Nicholson [Tue, 25 Nov 2008 00:19:55 +0000 (00:19 +0000)]
Fix compiling in dev mode.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158925 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake the Join event from app_queue use CallerIDNum insead of CallerID for
Matthew Nicholson [Tue, 25 Nov 2008 00:05:41 +0000 (00:05 +0000)]
Make the Join event from app_queue use CallerIDNum insead of CallerID for
indicating the callerid number just like the rest of asterisk.

(closes issue #13883)
Reported by: davidw

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158924 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdded EVENT_FLAG_AGI and used it for manager calls in res_agi.c
Matthew Nicholson [Mon, 24 Nov 2008 21:56:22 +0000 (21:56 +0000)]
Added EVENT_FLAG_AGI and used it for manager calls in res_agi.c

(closes issue #13873)
Reported by: fnordian
Patches:
      ami_agievent.patch uploaded by fnordian (license 110)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158876 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd a bit of documentation (thanks, I-MOD) on what the silence threshold
Tilghman Lesher [Mon, 24 Nov 2008 21:52:34 +0000 (21:52 +0000)]
Add a bit of documentation (thanks, I-MOD) on what the silence threshold
constant actually does and what values are valid for it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158857 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake ast_streamfile() check the result of ast_openstream() before doing
Matthew Nicholson [Mon, 24 Nov 2008 21:27:26 +0000 (21:27 +0000)]
Make ast_streamfile() check the result of ast_openstream() before doing
anything with it.

(closes issue #13955)
Reported by: chris-mac

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158851 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoThis patch adds a new application for sending MWI to phones via Asterisk's event...
Terry Wilson [Mon, 24 Nov 2008 18:11:08 +0000 (18:11 +0000)]
This patch adds a new application for sending MWI to phones via Asterisk's event subsystem.  Also, the minivm documentation is all converted to use xmldocs.

(closes issue #13946)
Reported by: Marquis
Patches:
      minivmmwi_plus_xmldocs.patch uploaded by Marquis (license 32)
Tested by: otherwiseguy, Marquis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158808 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoIf you enabled 'notifycid' one of the limitations is that the calling channel
Sean Bright [Sun, 23 Nov 2008 03:36:52 +0000 (03:36 +0000)]
If you enabled 'notifycid' one of the limitations is that the calling channel
is only found if it dialed the extension that was subscribed to.  You can now
specify 'ignore-context' for the 'notifycid' option in sip.conf which will, as
it's value implies, ignore the current context of the caller when doing the
lookup.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158756 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoNo need to use a separate structure for this since we can just pass
Sean Bright [Sun, 23 Nov 2008 03:30:46 +0000 (03:30 +0000)]
No need to use a separate structure for this since we can just pass
our sip_pvt pointer in directly.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158754 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agolast commit worked on OpenBSD but still generated warning on Ubuntu.
Michiel van Baak [Sat, 22 Nov 2008 17:17:33 +0000 (17:17 +0000)]
last commit worked on OpenBSD but still generated warning on Ubuntu.

Initialise a variable so --enable-dev-mode does not complain

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158723 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agodont send reorder tone after a device is hungup if a dialout is abandoned or failed.
Michiel van Baak [Sat, 22 Nov 2008 16:57:11 +0000 (16:57 +0000)]
dont send reorder tone after a device is hungup if a dialout is abandoned or failed.
Without this reorder tone will play after hangup and both wedhorn's and my wife have threatened to use an axe on our asterisk box

(closes issue #13948)
Reported by: wedhorn
Patches:
switch.diff uploaded by wedhorn (license 30)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158694 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd Media Source Update to skinny's control2str
Michiel van Baak [Sat, 22 Nov 2008 16:48:09 +0000 (16:48 +0000)]
Add Media Source Update to skinny's control2str

(issue #13948)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158690 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agofix a very occasional core dump in chan_skinny found by wedhorn.
Michiel van Baak [Sat, 22 Nov 2008 16:06:38 +0000 (16:06 +0000)]
fix a very occasional core dump in chan_skinny found by wedhorn.

(issue #13948)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158688 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agomake this compile under devmode
Michiel van Baak [Sat, 22 Nov 2008 15:58:49 +0000 (15:58 +0000)]
make this compile under devmode

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158686 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 158629 via svnmerge
Jeff Peeler [Sat, 22 Nov 2008 00:05:33 +0000 (00:05 +0000)]
Blocked revisions 158629 via svnmerge

........
r158629 | jpeeler | 2008-11-21 18:04:36 -0600 (Fri, 21 Nov 2008) | 5 lines

(closes issue #13786)
Reported by: tzafrir

When compiling against Zaptel dahdi_compat will now only define all the DAHDI defines if the Zaptel define is present. Also, there is no such thing as DAHDI_PRI.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158632 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 158603 via svnmerge from
Steve Murphy [Fri, 21 Nov 2008 23:40:46 +0000 (23:40 +0000)]
Merged revisions 158603 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r158603 | murf | 2008-11-21 16:14:50 -0700 (Fri, 21 Nov 2008) | 11 lines

In reference to the fix made for 13871, I was
merging the fix into 1.6.0 and realized I missed
the code in the h-exten block, and didn't catch it
because my test case had the h-exten commented out.

So, this corrects the code I missed, as a
preventative against another crash report.
Tested with the h-exten defined, all is well.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158606 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAllow space within an extension, when the space is within a character class.
Tilghman Lesher [Fri, 21 Nov 2008 23:33:22 +0000 (23:33 +0000)]
Allow space within an extension, when the space is within a character class.
(requested by lmadsen on -dev, patch by me)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158605 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 158600 via svnmerge from
Tilghman Lesher [Fri, 21 Nov 2008 23:14:11 +0000 (23:14 +0000)]
Merged revisions 158600 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r158600 | tilghman | 2008-11-21 17:07:46 -0600 (Fri, 21 Nov 2008) | 5 lines

  The passed extension may not be the same in the list as the current entry,
  because we strip spaces when copying the extension into the structure.
  Therefore, use the copied item to place the item into the list.
  (found by lmadsen on -dev, fixed by me)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158602 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 158539 via svnmerge from
Russell Bryant [Fri, 21 Nov 2008 22:12:37 +0000 (22:12 +0000)]
Merged revisions 158539 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r158539 | russell | 2008-11-21 16:05:55 -0600 (Fri, 21 Nov 2008) | 2 lines

When compiling with DEBUG_THREADS, report the real file/func/line for ao2_lock/ao2_unlock

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158540 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 158483 via svnmerge from
Steve Murphy [Fri, 21 Nov 2008 21:47:16 +0000 (21:47 +0000)]
Merged revisions 158483 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r158483 | murf | 2008-11-21 14:19:47 -0700 (Fri, 21 Nov 2008) | 11 lines

(closes issue #13871)
Reported by: mdu113

This one is totally my fault. The code doesn't even
create a bridge CDR if the channel CDR has POST_DISABLED.
I didn't check for that at the end of the bridge.
Fixed with a few small insertions. Tested. Looks
good. No cdr generated, no crash, no unnecc. data
objects created either.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158484 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix for #13963. Make physical channel mapping unconfigured default
Matthew Fredrickson [Fri, 21 Nov 2008 21:06:59 +0000 (21:06 +0000)]
Fix for #13963.  Make physical channel mapping unconfigured default

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158482 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoas suggested by jtodd, document the purposes of the CHANGES and UPGRADE files
Kevin P. Fleming [Fri, 21 Nov 2008 20:42:37 +0000 (20:42 +0000)]
as suggested by jtodd, document the purposes of the CHANGES and UPGRADE files

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158449 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake sure we add the Event header for CoreShowChannels.
Jason Parker [Fri, 21 Nov 2008 19:40:57 +0000 (19:40 +0000)]
Make sure we add the Event header for CoreShowChannels.

(closes issue #13334)
Reported by: srt
Patches:
      13334_missing_event_header_in_core_show_channel.diff uploaded by srt (license 378)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158414 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoReloading the config and having no changes still initialized some settings to 0....
Terry Wilson [Fri, 21 Nov 2008 17:08:16 +0000 (17:08 +0000)]
Reloading the config and having no changes still initialized some settings to 0. Initialize settings after doing all of the cfg checks.

(closes issue #13942)
Reported by: davidw
Patches:
      cdr_diff.txt uploaded by otherwiseguy (license 396)
Tested by: davidw

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158374 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd fix to prevent crash during reload if there is an outstanding MWI registration...
Doug Bailey [Fri, 21 Nov 2008 15:53:49 +0000 (15:53 +0000)]
Add fix to prevent crash during reload if there is an outstanding MWI registration message pending.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158315 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 158306 via svnmerge
Mark Michelson [Fri, 21 Nov 2008 15:25:58 +0000 (15:25 +0000)]
Blocked revisions 158306 via svnmerge

........
r158306 | mmichelson | 2008-11-21 09:24:19 -0600 (Fri, 21 Nov 2008) | 5 lines

This change had somehow gotten reverted due to a
completely unrelated commit. Thanks to Theo Belder
on the Asterisk-dev list for pointing this out.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158307 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUse a more expressive constant for a 64-bit scanned int
Mark Michelson [Fri, 21 Nov 2008 01:22:18 +0000 (01:22 +0000)]
Use a more expressive constant for a 64-bit scanned int

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158266 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUse some magic constants to get the right size
Mark Michelson [Fri, 21 Nov 2008 01:14:20 +0000 (01:14 +0000)]
Use some magic constants to get the right size
for this sscanf statement. Thanks Richard!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158265 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix the build for 32-bit systems. %lu is only 32-bits
Mark Michelson [Fri, 21 Nov 2008 00:59:23 +0000 (00:59 +0000)]
Fix the build for 32-bit systems. %lu is only 32-bits
on 32-bit systems, so we need to use %llu instead. Of course
%llu is 128-bits on 64-bit systems, so we have to cast to
unsigned long long. No harm, but it's sure annoying.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158262 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoChange the remote user agent session version variable
Mark Michelson [Thu, 20 Nov 2008 23:12:50 +0000 (23:12 +0000)]
Change the remote user agent session version variable
from an int to a uint64_t. This prevents potential comparison
problems from happening if the version string exceeds
INT_MAX. This was an apparent problem for one user who could
not properly place a call on hold since the version in the
SDP of the re-INVITE to place the call on hold greatly
exceeded INT_MAX.

This also aligns with RFC 2327 better since it recommends
using an NTP timestamp for the version (which is a
64-bit number).

(closes issue #13531)
Reported by: sgofferj
Patches:
      13531.patch uploaded by putnopvut (license 60)
Tested by: sgofferj

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158230 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix one case where the application argument was not converted from a pipe to
Sean Bright [Thu, 20 Nov 2008 19:41:23 +0000 (19:41 +0000)]
Fix one case where the application argument was not converted from a pipe to
a comma.  This was causing problems with switch statements with empty expressions.

(closes issue #13901)
Reported by: smurfix
Patches:
      20081118_bug13901.diff uploaded by seanbright (license 71)
Tested by: seanbright
Reviewed by: murf

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158188 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 158072 via svnmerge from
Mark Michelson [Thu, 20 Nov 2008 18:20:00 +0000 (18:20 +0000)]
Merged revisions 158072 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r158072 | twilson | 2008-11-20 11:48:58 -0600 (Thu, 20 Nov 2008) | 2 lines

Begin on a crusade to end trailing whitespace!

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158133 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 158071 via svnmerge from
Mark Michelson [Thu, 20 Nov 2008 17:54:31 +0000 (17:54 +0000)]
Merged revisions 158071 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r158071 | mmichelson | 2008-11-20 11:48:42 -0600 (Thu, 20 Nov 2008) | 16 lines

We don't handle 4XX responses to BYE well. According to
section 15 of RFC 3261, we should terminate a dialog if we
receive a 481 or 408 in response to our BYE. Since I am aware
of at least one phone manufacturer who may sometimes send a
404 as well, I am being liberal and saying that any 4XX response
to a BYE should result in a terminated dialog.

(closes issue #12994)
Reported by: pabelanger
Patches:
      12994.patch uploaded by putnopvut (license 60)

Closes AST-129

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158082 65c4cc65-6c06-0410-ace0-fbb531ad65f3