asterisk/asterisk.git
9 years agoFix test_time on Mac OS X (and other platforms without inotify)
Tilghman Lesher [Tue, 16 Mar 2010 19:34:01 +0000 (19:34 +0000)]
Fix test_time on Mac OS X (and other platforms without inotify)

Reviewboard: https://reviewboard.asterisk.org/r/554/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252846 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 252766 via svnmerge from
Russell Bryant [Tue, 16 Mar 2010 19:01:04 +0000 (19:01 +0000)]
Merged revisions 252766 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r252766 | russell | 2010-03-16 14:00:43 -0500 (Tue, 16 Mar 2010) | 6 lines

  Don't treat warnings as errors for muted.

  muted supports OS X, but uses functions marked as deprecated in 10.6.  However,
  the functions are still supported, so just ignore the warnings for now and
  allow the build to proceed.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252767 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 252761 via svnmerge from
Leif Madsen [Tue, 16 Mar 2010 18:48:22 +0000 (18:48 +0000)]
Merged revisions 252761 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r252761 | lmadsen | 2010-03-16 13:46:20 -0500 (Tue, 16 Mar 2010) | 7 lines

  Additional extensions.ael global variable fixes.

  Fixing up a couple more overlapping global variable namespaces shared with
  extensions.conf.sample. Also noticed a few of the lines that were commented
  out didn't have the closing semi-colon so I added that as well.

  (issue #17035)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252762 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoOSARCH is not inherited to this directory
Tilghman Lesher [Tue, 16 Mar 2010 18:40:14 +0000 (18:40 +0000)]
OSARCH is not inherited to this directory

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252760 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoDisable this test on non-Linux for now.
Russell Bryant [Tue, 16 Mar 2010 18:36:34 +0000 (18:36 +0000)]
Disable this test on non-Linux for now.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252759 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoImprove handling of values supplied to FAXOPT(ecm).
Kevin P. Fleming [Mon, 15 Mar 2010 22:48:38 +0000 (22:48 +0000)]
Improve handling of values supplied to FAXOPT(ecm).

Previously, values that began with whitespace were silently treated as 'no',
and all non-'yes' values were also treated as 'no'. Now the supplied value
is specifically checked for a 'yes' or 'no' (or equivalent) value, after skipping
leading whitespace. If the value is not valid, then a warning message is generated.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252709 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoTell the RTP engine API about the initial read and write format.
Russell Bryant [Mon, 15 Mar 2010 22:14:18 +0000 (22:14 +0000)]
Tell the RTP engine API about the initial read and write format.

Peer reviewed out-of-band by file.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252627 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoResolve a crash in SLATrunk when the specified trunk doesn't exist.
Sean Bright [Mon, 15 Mar 2010 21:55:44 +0000 (21:55 +0000)]
Resolve a crash in SLATrunk when the specified trunk doesn't exist.

Reported by philipp64 in #asterisk-dev.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252623 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 252617 via svnmerge from
Tilghman Lesher [Mon, 15 Mar 2010 21:51:55 +0000 (21:51 +0000)]
Merged revisions 252617 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r252617 | tilghman | 2010-03-15 16:43:14 -0500 (Mon, 15 Mar 2010) | 2 lines

  Uh, yeah.  Umask.  I'm stupid.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252619 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 252533 via svnmerge from
Leif Madsen [Mon, 15 Mar 2010 20:52:32 +0000 (20:52 +0000)]
Merged revisions 252533 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r252533 | lmadsen | 2010-03-15 15:48:56 -0500 (Mon, 15 Mar 2010) | 7 lines

  Update extensions.ael file to not overlap extensions.conf.
  Updated the extensions.ael file so the global variables don't overlap
  those that we have in extensions.conf (sample files). This way unexpected
  things won't happed hopefully if both pbx_ael and res_config are loaded.

  (closes issue #17035)
  Reported by: pprindeville
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252534 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMake the Makefile logic more explicit and move the Snow Leopard logic down to where...
Tilghman Lesher [Mon, 15 Mar 2010 16:27:08 +0000 (16:27 +0000)]
Make the Makefile logic more explicit and move the Snow Leopard logic down to where it's not executed on non-Darwin systems.

(closes issue #17028)
 Reported by: pabelanger
 Patches:
       issue17028_20100315.patch uploaded by seanbright (license 71)
       20100315__issue17028.diff.txt uploaded by tilghman (license 14)
 Tested by: tilghman, pabelanger

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252488 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoTHIS IS NOT PYTHON. Indentation doesn't matter, only braces do.
Tilghman Lesher [Mon, 15 Mar 2010 04:25:35 +0000 (04:25 +0000)]
THIS IS NOT PYTHON.  Indentation doesn't matter, only braces do.

(closes issue #17025)
 Reported by: smurfix
 Patches:
       sip.patch uploaded by smurfix (license 547)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252442 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRecorded merge of revisions 252366 via svnmerge from
Tilghman Lesher [Mon, 15 Mar 2010 01:39:39 +0000 (01:39 +0000)]
Recorded merge of revisions 252366 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r252366 | tilghman | 2010-03-14 20:39:00 -0500 (Sun, 14 Mar 2010) | 2 lines

  Typo
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252367 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 252361 via svnmerge from
Tilghman Lesher [Mon, 15 Mar 2010 01:37:04 +0000 (01:37 +0000)]
Merged revisions 252361 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r252361 | tilghman | 2010-03-14 20:33:50 -0500 (Sun, 14 Mar 2010) | 4 lines

  Launch Asterisk on Mac OS X with launchd.

  Reviewboard: https://reviewboard.asterisk.org/r/551/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252362 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix building CDR and CEL SQLite3 modules.
Sean Bright [Sun, 14 Mar 2010 17:43:46 +0000 (17:43 +0000)]
Fix building CDR and CEL SQLite3 modules.

They added a sqlite3_log() function which was conflicting with our function
names.

(closes issue #17017)
Reported by: alephlg

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252314 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agogenerate roundtrip delay requests and responses
Alexandr Anikin [Sun, 14 Mar 2010 14:42:59 +0000 (14:42 +0000)]
generate roundtrip delay requests and responses

added response to roundtrip delay requests from opposite side
added roundtrip delay request sending to opposite side after answer,
added options for sending request (interval between request and
count of unreplied requests before forced call hangup)

(closes issue #16976)
Reported by: vmikhelson
Patches:
      rtdr-1.6.0-2.patch uploaded by may213 (license 454)
Tested by: vmikhelson, may213

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252277 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoResolve unit test failure that occurred on Mac OSX.
Russell Bryant [Sat, 13 Mar 2010 22:21:18 +0000 (22:21 +0000)]
Resolve unit test failure that occurred on Mac OSX.

On Linux (glibc), regcomp() does not return an error for an empty string.
However, the version on OSX will return an error.  The test for channel group
matching by regex now passes on the mac, as well.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252241 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoResolve compiler warning by paying attention to system() return value.
Russell Bryant [Sat, 13 Mar 2010 22:17:05 +0000 (22:17 +0000)]
Resolve compiler warning by paying attention to system() return value.

This resolves the last compile failure on bamboo.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252229 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoTest script to verify that timezone cache is properly removed on zonefile alteration.
Tilghman Lesher [Fri, 12 Mar 2010 23:18:20 +0000 (23:18 +0000)]
Test script to verify that timezone cache is properly removed on zonefile alteration.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252133 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoOnly change the RTP ssrc when we see that it has changed
Terry Wilson [Fri, 12 Mar 2010 22:04:51 +0000 (22:04 +0000)]
Only change the RTP ssrc when we see that it has changed

This change basically reverts the change reviewed in
https://reviewboard.asterisk.org/r/374/ and instead limits the
updating of the RTP synchronization source to only those times when we
detect that the other side of the conversation has changed the ssrc.

The problem is that SRCUPDATE control frames are sent many times where
we don't want a new ssrc, including whenever Asterisk has to send DTMF
in a normal bridge. This is also not the first time that this mistake
has been made. The initial implementation of the ast_rtp_new_source
function also changed the ssrc--and then it was removed because of
this same issue. Then, we put it back in again to fix a different
issue. This patch attempts to only change the ssrc when we see that
the other side of the conversation has changed the ssrc.

It also renames some functions to make their purpose more clear.

Review: https://reviewboard.asterisk.org/r/540/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252089 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoadd missing mfcr2_skip_category setting
Moises Silva [Fri, 12 Mar 2010 21:57:40 +0000 (21:57 +0000)]
add missing mfcr2_skip_category setting

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252088 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoDon't override a user option with the global option.
Tilghman Lesher [Fri, 12 Mar 2010 19:43:23 +0000 (19:43 +0000)]
Don't override a user option with the global option.

(closes issue #16849)
 Reported by: ip-rob
 Patches:
       20100311__issue16849.diff.txt uploaded by tilghman (license 14)
 Tested by: ip-rob

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251989 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 251986 via svnmerge from
Richard Mudgett [Fri, 12 Mar 2010 19:40:16 +0000 (19:40 +0000)]
Merged revisions 251986 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r251986 | rmudgett | 2010-03-12 13:33:22 -0600 (Fri, 12 Mar 2010) | 1 line

  Make chan_dahdi wakeup_sub() prototype not conditional.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251987 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoDoxegen this chan_dahdi lock.
Richard Mudgett [Fri, 12 Mar 2010 19:05:40 +0000 (19:05 +0000)]
Doxegen this chan_dahdi lock.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251946 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBecause ExecIf needs to reprocess arguments, it's best if we don't remove quotes...
Tilghman Lesher [Thu, 11 Mar 2010 21:07:07 +0000 (21:07 +0000)]
Because ExecIf needs to reprocess arguments, it's best if we don't remove quotes during parsing.

(closes issue #16905)
 Reported by: ip-rob
 Patches:
       20100303__issue16905.diff.txt uploaded by tilghman (license 14)
 Tested by: ip-rob

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251884 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix tests on 32-bit systems.
Tilghman Lesher [Thu, 11 Mar 2010 20:29:19 +0000 (20:29 +0000)]
Fix tests on 32-bit systems.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251881 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoIf the argument to the system application is quoted, ensure we remove the quotes...
Tilghman Lesher [Thu, 11 Mar 2010 20:25:02 +0000 (20:25 +0000)]
If the argument to the system application is quoted, ensure we remove the quotes before trying to execute.

(closes issue #16842)
 Reported by: ip-rob
 Patches:
       20100310__issue16842.diff.txt uploaded by tilghman (license 14)
 Tested by: ip-rob

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251877 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMinor tweaks and comment updates to chan_dahdi.
Richard Mudgett [Thu, 11 Mar 2010 18:07:16 +0000 (18:07 +0000)]
Minor tweaks and comment updates to chan_dahdi.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251821 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd supporting code for app-directory pause option.
Alec L Davis [Thu, 11 Mar 2010 07:03:51 +0000 (07:03 +0000)]
Add supporting code for app-directory pause option.

Since 1.6.1 CLI help reports that option p(n) 'initial pause' is available.
Supporting code was never implemented.

(closes issue #16751)
Reported by: alecdavis
Patches:
      directory_pause.trunk.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

Review: https://reviewboard.asterisk.org/r/481/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251779 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd new unit test for stringfields.
Jeff Peeler [Wed, 10 Mar 2010 23:15:55 +0000 (23:15 +0000)]
Add new unit test for stringfields.

(Copied from reviewboard)
Tests the following:
1. Basic allocation and setting of string fields.
2. Shrinking a string field and re-expanding it.
3. Growing the last allocation in a string field pool.
4. Setting a string to a large value such that a new string field pool must be
allocated.
In each part, we make sure that the string field is accurate (has the correct
value in it), make sure that the 2 bytes before the string field has the correct
capacity for the field, and for tests 2-4, we make sure that the string field is
where we expect it to be in memory.

Also tested:
5. Shrinking a string field and partially re-expanding it.
6. Setting strings in such a way as to create three separate string field pools
and then removing the middle pool.

There is a bug fix in the init function, which ensures the embedded_pool is set
to NULL which is important for stack allocated structures.

Review: https://reviewboard.asterisk.org/r/185/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251736 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoHmmm, apparently needed to be fixed in trunk, too.
Tilghman Lesher [Wed, 10 Mar 2010 20:54:03 +0000 (20:54 +0000)]
Hmmm, apparently needed to be fixed in trunk, too.

(closes issue #16900)
 Reported by: bluecrow76
 Patches:
       asterisk-1.6.2.4-func_strings.diff uploaded by bluecrow76 (license 270)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251682 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBe less ambiguous in Record() app docs.
Leif Madsen [Wed, 10 Mar 2010 20:53:43 +0000 (20:53 +0000)]
Be less ambiguous in Record() app docs.
For some reason the documentation for the 'k' application in trunk
and 1.6.2 is different than 1.6.0 and 1.6.1, so I'm setting them all
to match. The wording in 1.6.2 and trunk was ambiguous, so you could
interpret the wording the mean that recording would continue upon hangup
indefinitely, or you could interpret it to mean that the recorded
data would not be discarded upon hangup. This change makes it clear
we mean the latter, and not the former.

Came from a discussion in #asterisk on IRC.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251680 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix ParkAndAnnounce not respecting parking options.
Jeff Peeler [Wed, 10 Mar 2010 20:51:23 +0000 (20:51 +0000)]
Fix ParkAndAnnounce not respecting parking options.

The patch ensures that if a peer does not exist, parking settings are read from
the channel. A unit test has been written to ensure proper operation for both
standard parking and parking using masquerades.

(closes issue #16592)
Reported by: mwyres
Patches:
      bug_16592.diff uploaded by snuffy (license 35)

Review: https://reviewboard.asterisk.org/r/539/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251679 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoIt's amazing what writing a test will find.
Tilghman Lesher [Wed, 10 Mar 2010 20:30:34 +0000 (20:30 +0000)]
It's amazing what writing a test will find.

(issue #16900)
 Reported by: bluecrow76

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251677 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix jitterbuffer logging not creating logfiles.
Jeff Peeler [Wed, 10 Mar 2010 18:25:18 +0000 (18:25 +0000)]
Fix jitterbuffer logging not creating logfiles.

Three changes made here:
1) Do not fail if a previous log does not exist (in fact, this is probably
expected).
2) Ensure that the file descriptor to write to gets assigned properly. I am at
a loss as to why assigning safe_fd outside the if fixes this, but it makes
the if statement slightly less complicated anyway.
3) Move up the failure message so that the errno of the failure is not
overwritten by fclose.

(closes issue #16917)
Reported by: Artem

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251631 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoSimplified dahdi_request() channel selection failed reason/cause code.
Richard Mudgett [Wed, 10 Mar 2010 16:55:34 +0000 (16:55 +0000)]
Simplified dahdi_request() channel selection failed reason/cause code.

Also avoid potential crash because cause could be NULL.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251585 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoReduce the amount of database access for HAVE_PRI_SERVICE_MESSAGES.
Richard Mudgett [Wed, 10 Mar 2010 03:16:50 +0000 (03:16 +0000)]
Reduce the amount of database access for HAVE_PRI_SERVICE_MESSAGES.

Rework HAVE_PRI_SERVICE_MESSAGES to not use the active values directly
from the database.  Database access is likely expensive.  Database access
now only happens on initialization, destruction, and when the B channel is
taken in or out of service.

This change is not related to call waiting but it would cause the search
for a call waiting interface to be very expensive and slow down D channel
message servicing.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251538 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBuild system modifications to ensure that Asterisk properly builds on Mac OS X 10.6.
Tilghman Lesher [Tue, 9 Mar 2010 20:30:03 +0000 (20:30 +0000)]
Build system modifications to ensure that Asterisk properly builds on Mac OS X 10.6.

(closes issue #16997)
 Reported by: jquinn
 Patches:
       20100309__issue16997__2.diff.txt uploaded by tilghman (license 14)
 Tested by: tilghman, russell

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251475 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBlocked revisions 251410 via svnmerge
Sean Bright [Tue, 9 Mar 2010 19:31:00 +0000 (19:31 +0000)]
Blocked revisions 251410 via svnmerge

........
r251410 | seanbright | 2010-03-09 14:29:39 -0500 (Tue, 09 Mar 2010) | 8 lines

Use ast_strlen_zero to avoid a crash when a Dial() string isn't passed to ParkAndAnnounce

(closes issue #16731)
Reported by: sebele67
Patches:
      issue16731_20100129.diff uploaded by seanbright (license 71)
Tested by: sebele67

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251411 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 251309 via svnmerge from
Leif Madsen [Mon, 8 Mar 2010 18:08:44 +0000 (18:08 +0000)]
Merged revisions 251309 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r251309 | lmadsen | 2010-03-08 12:07:44 -0600 (Mon, 08 Mar 2010) | 13 lines

  Fix Debian init script to not use -c.
  When using the init script as-is currently, it could cause issues on Debian
  such as high CPU usage. This fix has worked for several people so I'm
  implementing the change.

  (closes issue #16784)
  Reported by: pabelanger
  Tested by: pabelanger, mnick, davidw, mutineer612

  (closes issue #16887)
  Reported by: jlpedrosa
  Tested by: jlpedrosa, mutineer612
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251310 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRemove portions that weren't meant to be committed for the OS X compat fix
Tilghman Lesher [Mon, 8 Mar 2010 05:15:01 +0000 (05:15 +0000)]
Remove portions that weren't meant to be committed for the OS X compat fix

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251263 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoChange needed to make Mac OS X 10.6 happy
Tilghman Lesher [Mon, 8 Mar 2010 05:12:55 +0000 (05:12 +0000)]
Change needed to make Mac OS X 10.6 happy

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251262 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoClean transmit_* for start/stop media transmission
Michiel van Baak [Sun, 7 Mar 2010 14:53:06 +0000 (14:53 +0000)]
Clean transmit_* for start/stop media transmission

Small patch changing skinny_set_rtp_peer to use transmit_stopmediatransmission and to use new transmit_startmediatransmission.
Basic testing on 30VIP's by wedhorn
Basic testing on 7960 by me

(closes issue #16956)
Reported by: wedhorn
Patches:
      skinny-clean05b.diff uploaded by wedhorn (license 30)
Tested by: wedhorn,mvanbaak

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251222 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoCleanup transmit_callstate handling
Michiel van Baak [Sun, 7 Mar 2010 14:46:29 +0000 (14:46 +0000)]
Cleanup transmit_callstate handling

Broke the various functions included in transmit_callstate to their own functions. Transmit_callstate now just transmits callstate.

Generally left the functionality as it was, which highlight some minor code issues (eg multiple transmit_callstate's). I did however revise the hint code usage of the old transmit_callstate as it it not appropriate to put a device on hook based on the change of a hinted device.

(closes issue #16939)
Reported by: wedhorn
Patches:
      skinny-clean04.diff uploaded by wedhorn (license 30)
Tested by: mvanbaak,wedhorn

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251221 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agosmall log issue from bug 0016664
Alexandr Anikin [Sun, 7 Mar 2010 00:45:35 +0000 (00:45 +0000)]
small log issue from bug 0016664

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251181 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix a crash in SIP blind transfer handling found by an automated external test.
Russell Bryant [Sat, 6 Mar 2010 14:16:20 +0000 (14:16 +0000)]
Fix a crash in SIP blind transfer handling found by an automated external test.

The first real test added to the external test suite found a pretty nasty crash
that occurred in Asterisk trunk.  The crash was due to a race condition between
the REFER handling and channel destruction in the channel thread.  After the
transfer has been completed, we go back to the transferrer channel and try to
lock it so we can fire off a CEL event.  However, there was no guarantee that
the channel was still around at that point since it's racing against the channel
thread.

Since ast_channel is a reference counted object, the fix is simple.  The code
unlocks the transferrer channel before finally completing the transfer with
an async goto.  At this point the channel thread is going to start call tear
down and the channel will eventually be destroyed.  To ensure that the channel
is valid when we want to fire off the CEL event, increase the channel's
reference count.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251137 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes xml error in func_pitchshift
David Vossel [Fri, 5 Mar 2010 21:51:25 +0000 (21:51 +0000)]
fixes xml error in func_pitchshift

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251087 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoPITCH_SHIFT dialplan function
David Vossel [Fri, 5 Mar 2010 20:21:13 +0000 (20:21 +0000)]
PITCH_SHIFT dialplan function

The PITCH_SHIFT function can be used on a channel to independently
modify the pitch of both rx and tx audio streams.  Now you can
improve your conference calls by assigning a random pitch effect
to everyone entering a meetme room, or just make your day more
interesting by making your co-workers sound funny.  These are just
some of the numerious practical uses for this function. Enjoy!

https://reviewboard.asterisk.org/r/526/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251038 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRemove pbx_gtkconsole and related gtk1 checks.
Russell Bryant [Fri, 5 Mar 2010 19:32:19 +0000 (19:32 +0000)]
Remove pbx_gtkconsole and related gtk1 checks.

Review: https://reviewboard.asterisk.org/r/541/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251022 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix app_followme playing wrong sound files.
Jeff Peeler [Fri, 5 Mar 2010 19:10:47 +0000 (19:10 +0000)]
Fix app_followme playing wrong sound files.

Fixes regression introduced in 140167 that uses the wrong variable names.

(closes issue #16930)
Reported by: ianc
Patches:
      fix_reload_followme.diff uploaded by ianc (license 998)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250979 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix up some of chan_sip's usage of the RTP engine API.
Russell Bryant [Fri, 5 Mar 2010 05:03:41 +0000 (05:03 +0000)]
Fix up some of chan_sip's usage of the RTP engine API.

The get_local_address() function for an RTP instance was used when building an
SDP, but the results were not honored.  The RTP engine activate() function was
not being used once we have determined that media will now flow.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250917 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMissing quote in ODBC query.
Tilghman Lesher [Fri, 5 Mar 2010 04:37:36 +0000 (04:37 +0000)]
Missing quote in ODBC query.

(closes issue #16953)
 Reported by: elguero
 Patches:
       app_voicemail-odbc-syntax-fix.diff uploaded by elguero (license 37)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250913 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix up the ast_rtp_property enum.
Russell Bryant [Fri, 5 Mar 2010 02:07:33 +0000 (02:07 +0000)]
Fix up the ast_rtp_property enum.

The mis-placement of the latest entry meant that when it was set, it was writing
one index past the end of the properties array in the ast_rtp_instance (which
happened to be the local_address field).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250871 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 250786 via svnmerge from
Jeff Peeler [Fri, 5 Mar 2010 01:05:46 +0000 (01:05 +0000)]
Merged revisions 250786 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r250786 | jpeeler | 2010-03-04 19:02:58 -0600 (Thu, 04 Mar 2010) | 9 lines

  Fix not being able to specify a URL in MOH class directory.

  Don't attempt to chdir on a URL!

  (closes issue #16875)
  Reported by: raarts
  Patches:
        moh-http.patch uploaded by raarts (license 937)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250787 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdjust XML for func_channel to indicate that rtpdest can take a "text" argument.
Mark Michelson [Thu, 4 Mar 2010 20:12:26 +0000 (20:12 +0000)]
Adjust XML for func_channel to indicate that rtpdest can take a "text" argument.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250730 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRecorded merge of revisions 250613 via svnmerge from
Leif Madsen [Wed, 3 Mar 2010 21:28:31 +0000 (21:28 +0000)]
Recorded merge of revisions 250613 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r250613 | lmadsen | 2010-03-03 16:28:02 -0500 (Wed, 03 Mar 2010) | 11 lines

  Update existing Local channel documentation.

  A complete re-write of the Local channel documentation has been performed, with
  the existing information from localchannel.txt and localchannel.tex merged in.

  (issue #16637)
  Reported by: kobaz
  Patches:
        localchannel.tex uploaded by lmadsen (license 10)
        localchannel.txt uploaded by lmadsen (license 10)
  Tested by: lmadsen, jsmith, mmichelson
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250614 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate existing Local channel documentation.
Leif Madsen [Wed, 3 Mar 2010 21:22:55 +0000 (21:22 +0000)]
Update existing Local channel documentation.

A complete re-write of the Local channel documentation has been performed, with
the existing information from localchannel.txt and localchannel.tex merged in.

(closes issue #16637)
Reported by: kobaz
Patches:
      localchannel.tex uploaded by lmadsen (license 10)
      localchannel.txt uploaded by lmadsen (license 10)
Tested by: lmadsen, jsmith, mmichelson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250609 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRemoved cdrflags from ast_channel structure.
Richard Mudgett [Wed, 3 Mar 2010 19:38:06 +0000 (19:38 +0000)]
Removed cdrflags from ast_channel structure.

Only chan_dahdi set a value in cdrflags.  Everyone else just copied it
around the system.  Noone cared about any value it may have contained.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250565 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 250480 via svnmerge from
Jeff Peeler [Wed, 3 Mar 2010 19:06:06 +0000 (19:06 +0000)]
Merged revisions 250480 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r250480 | jpeeler | 2010-03-03 13:04:11 -0600 (Wed, 03 Mar 2010) | 15 lines

  Make sure to clear red alarm after polarity reversal.

  From the issue:
  The automatic overnight line tests (or manual ones) used on UK (BT) lines causes
  a red alarm on a dahdi / TDM400P connected channel. This is because the line
  uses voltage tests (battery loss) and polarity reversal. The polarity reversal
  causes chan_dahdi to initiate v23 CallerID processing but during this the event
  DAHDI_EVENT_NOALARM is ignored so that the alarm is never cleared.

  (closes issue #14163)
  Reported by: jedi98
  Patches:
        chan_dahdi-1.4-inalarm.diff uploaded by jedi98 (license 653)
  Tested by: mattbrown, Chainsaw, mikeeccleston
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250481 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoChanges 0ms to <1ms in cli END results during 'test execute'
David Vossel [Wed, 3 Mar 2010 19:02:13 +0000 (19:02 +0000)]
Changes 0ms to <1ms in cli END results during 'test execute'

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250478 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 250394 via svnmerge from
David Vossel [Wed, 3 Mar 2010 18:03:19 +0000 (18:03 +0000)]
Merged revisions 250394 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r250394 | dvossel | 2010-03-03 12:02:27 -0600 (Wed, 03 Mar 2010) | 16 lines

  fixes problem with duplicate TXREQ packets

  When Asterisk receives an IAX2 TXREQ packet, try_transfer()
  will call store_by_transfercallno() to link the chan_iax2_pvt
  struct into iax_transfercallno_pvts. If a duplicate TXREQ
  packet is received for the same call, the pvt struct will be
  linked into iax_transfercallno_pvts multiple times.  This patch
  fixes this.  Thanks rain for debugging this and providing a patch!

  (closes issue #16904)
  Reported by: rain
  Patches:
        iax2-double-txreq-fix.diff uploaded by rain (license 327)
  Tested by: rain, dvossel
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250395 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd new config option to control AMI alarm event reporting in chan_dahdi.
Jeff Peeler [Wed, 3 Mar 2010 17:37:30 +0000 (17:37 +0000)]
Add new config option to control AMI alarm event reporting in chan_dahdi.

New config parameter "reportalarms" added in chan_dahdi.conf which supports the
following possible values:
"channels": report each channel alarms (current behavior, default for backward compatibility)
"spans": report an "SpanAlarm" event when the span of any configured channel is alarmed
"all": report channel and span alarms (aggregated behavior)
"none": do not report any alarms

(closes issue #16709)
Reported by: nahuelgreco
Patches:
      chan_dahdi.c.reportalarms.patch uploaded by nahuelgreco (license 162)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250392 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoOne more fix to editline
Tilghman Lesher [Wed, 3 Mar 2010 16:43:10 +0000 (16:43 +0000)]
One more fix to editline

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250346 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoEliminate remaining libedit warnings (shown in bamboo)
Tilghman Lesher [Wed, 3 Mar 2010 15:54:28 +0000 (15:54 +0000)]
Eliminate remaining libedit warnings (shown in bamboo)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250303 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdated CHANGES file to mention res_fax and res_fax_spandsp.
Matthew Nicholson [Wed, 3 Mar 2010 15:39:45 +0000 (15:39 +0000)]
Updated CHANGES file to mention res_fax and res_fax_spandsp.

Also fixed MODULEINFO depends and conflicts for app_fax, res_fax, and res_fax_spandsp.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250302 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes signed to unsigned int comparision issue for FaxMaxDatagram value.
David Vossel [Wed, 3 Mar 2010 00:18:28 +0000 (00:18 +0000)]
fixes signed to unsigned int comparision issue for FaxMaxDatagram value.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250246 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes assumption that test failed if it did not pass when generating results
David Vossel [Wed, 3 Mar 2010 00:04:28 +0000 (00:04 +0000)]
fixes assumption that test failed if it did not pass when generating results

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250237 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agobase64 unit test
David Vossel [Tue, 2 Mar 2010 23:38:29 +0000 (23:38 +0000)]
base64 unit test

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250235 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerge missed files from res_fax/res_fax_spandsp merge.
Matthew Nicholson [Tue, 2 Mar 2010 23:22:11 +0000 (23:22 +0000)]
Merge missed files from res_fax/res_fax_spandsp merge.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250213 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerge res_fax and res_fax_spandsp.
Matthew Nicholson [Tue, 2 Mar 2010 23:11:06 +0000 (23:11 +0000)]
Merge res_fax and res_fax_spandsp.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250190 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoadds 'p' option to PickupChan
David Vossel [Tue, 2 Mar 2010 21:58:03 +0000 (21:58 +0000)]
adds 'p' option to PickupChan

The 'p' option allows the PickupChan app to pickup
a ringing phone by looking for the first match to a
partial channel name rather than requiring a full match.

(closes issue #16613)
Reported by: syspert
Patches:
      pickipbycallid.patch uploaded by syspert (license 938)
      pickupbycallerid_v2.patch uploaded by dvossel (license 671)
Tested by: dvossel, syspert

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250141 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate IMAP documentation.
Leif Madsen [Tue, 2 Mar 2010 21:09:27 +0000 (21:09 +0000)]
Update IMAP documentation.
Update the IMAP documentation to make it clear that storing voicemails
in the same folder as a large number of emails could potentially cause
significant slow downs when writing or retrieving voicemails.

(issue #16704)
Reported by: TimeHider
Tested by: lmadsen, TimeHider

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250051 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 250043 via svnmerge from
Leif Madsen [Tue, 2 Mar 2010 20:52:19 +0000 (20:52 +0000)]
Merged revisions 250043 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r250043 | lmadsen | 2010-03-02 15:51:35 -0500 (Tue, 02 Mar 2010) | 7 lines

  Update documentation to clarify purpose of unanswered option.

  (closes issue #16267)
  Reported by: elsto
  Patches:
        cdr.conf.sample.patch.txt uploaded by lmadsen (license 10)
  Tested by: davidw, elsto
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250045 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRecorded merge of revisions 250041 via svnmerge from
Leif Madsen [Tue, 2 Mar 2010 20:46:52 +0000 (20:46 +0000)]
Recorded merge of revisions 250041 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r250041 | lmadsen | 2010-03-02 15:45:37 -0500 (Tue, 02 Mar 2010) | 4 lines

  Update documentation to not imply we support overriding options.

  (issue #16855)
  Reported by: davidw
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250042 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate documentation to not imply we support overriding options.
Leif Madsen [Tue, 2 Mar 2010 20:36:10 +0000 (20:36 +0000)]
Update documentation to not imply we support overriding options.

(closes issue #16855)
Reported by: davidw

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250037 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix literal values wrapped in documentation.
Leif Madsen [Tue, 2 Mar 2010 19:49:48 +0000 (19:49 +0000)]
Fix literal values wrapped in documentation.

(closes issue #16145)
Reported by: tilghman

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249950 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agorevert ability to exit echo app
Alec L Davis [Tue, 2 Mar 2010 19:39:58 +0000 (19:39 +0000)]
revert ability to exit echo app

caused a regression, as only supported VOICE, not VIDEO etc.

(issue #16880)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249947 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd missing description of the PARKINGLOT variable in XML documentation.
Leif Madsen [Tue, 2 Mar 2010 19:24:43 +0000 (19:24 +0000)]
Add missing description of the PARKINGLOT variable in XML documentation.

(closes issue #16743)
Reported by: snuffy
Patches:
      parkingdoc.diff uploaded by snuffy (license 35)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249925 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoConvert some DUNDI functions to XML documentation.
Leif Madsen [Tue, 2 Mar 2010 19:21:19 +0000 (19:21 +0000)]
Convert some DUNDI functions to XML documentation.

(closes issue #16798)
Reported by: snuffy
Patches:
      xml_dundi.diff uploaded by snuffy (license 35)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249912 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes adaptive jitterbuffer configuration
David Vossel [Tue, 2 Mar 2010 19:08:38 +0000 (19:08 +0000)]
fixes adaptive jitterbuffer configuration

When configuring the adaptive jitterbuffer, the target_extra
value not only could not be set from the configuration, but was
not even being set to its proper default.  This value is required
in order for the adaptive jitterbuffer to work correctly.  To resolve
this a config option has been added to expose this value to the conf
files, and a default value is provided when no config specific value
is present.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249893 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix several XML documentation validate errors.
Leif Madsen [Tue, 2 Mar 2010 19:02:56 +0000 (19:02 +0000)]
Fix several XML documentation validate errors.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249892 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofix build by checking result of symlink in test_voicemail_vmsayname
Jeff Peeler [Tue, 2 Mar 2010 18:31:05 +0000 (18:31 +0000)]
fix build by checking result of symlink in test_voicemail_vmsayname

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249891 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd new application VMSayName for use with voicemail.
Jeff Peeler [Tue, 2 Mar 2010 18:22:05 +0000 (18:22 +0000)]
Add new application VMSayName for use with voicemail.

VMSayName that will play the recorded name of the voicemail user if it exists,
otherwise will play the mailbox number. A unit test has been written to verify
correct functionality called test_voicemail_vmsayname.

(closes issue #14973)
Reported by: ghjm

Review: https://reviewboard.asterisk.org/r/530/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249889 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes ability to exit echo app
Alec L Davis [Tue, 2 Mar 2010 07:38:56 +0000 (07:38 +0000)]
fixes ability to exit echo app

when called from a ISDN channel, null frames prevent '#' exit.
Now only echo back VOICE and DTMF frames

(issue #16880)
Reported by: alecdavis
Patches:
      echo_exit.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249801 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofix asterisk setting of pritimers from chan_dahdi.conf
Alec L Davis [Tue, 2 Mar 2010 06:56:14 +0000 (06:56 +0000)]
fix asterisk setting of pritimers from chan_dahdi.conf

regression since sig_pri split.

(issue #16909)
Reported by: alecdavis
Patches:
      pritimer.asterisk.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249759 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 249671 via svnmerge from
Sean Bright [Mon, 1 Mar 2010 19:36:30 +0000 (19:36 +0000)]
Merged revisions 249671 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r249671 | seanbright | 2010-03-01 14:35:01 -0500 (Mon, 01 Mar 2010) | 11 lines

  Fix crash in app_voicemail related to message counting.

  We were passing a 'struct inprocess **' and treating it like a 'struct inprocess *'
  causing a segfault.

  (closes issue #16921)
  Reported by: whardier
  Patches:
        20100301_issue16921.patch uploaded by seanbright (license 71)
  Tested by: whardier
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249672 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoCleanup display_*message functions.
Michiel van Baak [Mon, 1 Mar 2010 19:33:26 +0000 (19:33 +0000)]
Cleanup display_*message functions.

This patch splits transmit_displaymessage into transmit_clear_display_message and transmit_display_message which better aligns with the skinny protocol. The new transmit_display_message is not used in the current code, but will be and so it is commented.

Moved handle_datetime from this function to onhook and offhook functions (display now properly cleared at the end of a call on 30VIP).

Removed skinny debug messages from inline code as there's an ast_verb in transmit_clear_display_message. Also, removed commentary that it was a clear display as it is now apparent from the function name.

Split transmit_displaypromptmessage into display and clear.

(closes issue #16878)
Reported by: wedhorn
Patches:
skinny-clean02.diff uploaded by wedhorn (license 30)
skinny-clean03.diff uploaded by wedhorn (license 30)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249670 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofix endianes issues in chan_skinny
Michiel van Baak [Mon, 1 Mar 2010 19:27:34 +0000 (19:27 +0000)]
fix endianes issues in chan_skinny

(closes issue #16826)
Reported by: PipoCanaja
Patches:
      chan_skinny.c_bigendianPatch_20100218.diff uploaded by PipoCanaja (license 994)
Tested by: wedhorn

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249669 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoConstify a bit of app_voicemail, to make ODBC and IMAP compile once again.
Tilghman Lesher [Mon, 1 Mar 2010 18:36:06 +0000 (18:36 +0000)]
Constify a bit of app_voicemail, to make ODBC and IMAP compile once again.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249623 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 249536 via svnmerge from
Jeff Peeler [Mon, 1 Mar 2010 17:11:31 +0000 (17:11 +0000)]
Merged revisions 249536 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r249536 | jpeeler | 2010-03-01 11:02:03 -0600 (Mon, 01 Mar 2010) | 11 lines

  Modify queued frames from local channels to not set the other side to up

  In this case, attended transfers were broken due to ast_feature_request_and_dial
  detecting the channel being set to up before the answer frame could be read and
  therefore failing to mark the channel as ready. This fix is a regression fix for
  244785, which should continue to work properly as well.

  (closes issue #16816)
  Reported by: jamhed
  Tested by: jamhed, corruptor
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249538 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix unit test that Alec Davis broke.
Tilghman Lesher [Sun, 28 Feb 2010 20:50:01 +0000 (20:50 +0000)]
Fix unit test that Alec Davis broke.

(closes issue #16927)
 Reported by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249491 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agomake unit test check for NULL folder, which then defaults to INBOX
Alec L Davis [Sun, 28 Feb 2010 16:36:45 +0000 (16:36 +0000)]
make unit test check for NULL folder, which then defaults to INBOX

previous test, gave false level of assurance that code was healthy.

(issue #16927)
Reported by: alecdavis
Patches:
      based on app_voicemail_test.diff.txt uploaded by alecdavis (license 585)

Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249449 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoProperly document voicemail API documents. Also fix a crash reported via the -dev...
Tilghman Lesher [Sun, 28 Feb 2010 07:10:22 +0000 (07:10 +0000)]
Properly document voicemail API documents.  Also fix a crash reported via the -dev list.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249405 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agooverlap receiving: automatically send CALL PROCEEDING when dialplan starts
Alec L Davis [Sat, 27 Feb 2010 22:49:51 +0000 (22:49 +0000)]
overlap receiving: automatically send CALL PROCEEDING when dialplan starts

Following Q.931 5.2.4
When the user has determined that sufficient call information has been received the
user shall stop T302 and send CALL PROCEEDING to the network.

Previously timeouts were possible if the dialplan took a long time to issue any
response back to the network.

Verified that our local TELCO also does the same.

(issue #16789)
Reported by: alecdavis
Patches:
      overlap_receiving_trunk.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249320 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 249234 via svnmerge from
Kevin P. Fleming [Sat, 27 Feb 2010 14:08:35 +0000 (14:08 +0000)]
Merged revisions 249234 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r249234 | kpfleming | 2010-02-27 09:07:59 -0500 (Sat, 27 Feb 2010) | 1 line

  add a reference to the now-published IAX2 RFC
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249235 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoCleanups to fix bugs in the VM count API functions.
Tilghman Lesher [Fri, 26 Feb 2010 18:41:57 +0000 (18:41 +0000)]
Cleanups to fix bugs in the VM count API functions.

- Urgent voicemails were not attached, because the attachment code looked in the wrong folder.
- Urgent voicemails were sometimes counted twice when displaying the count of new messages.
- Backends were inconsistent as to which voicemails each API counted.
- Unit tests added to verify behavior in the future.

(closes issue #15654)
 Reported by: tomo1657
 Patches:
       20100225__issue15654.diff.txt uploaded by tilghman (license 14)
 Tested by: tilghman

(closes issue #16448)
 Reported by: hevad

Review: https://reviewboard.asterisk.org/r/525/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249187 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoadds Time field to "test show results" cli command
David Vossel [Fri, 26 Feb 2010 18:41:36 +0000 (18:41 +0000)]
adds Time field to "test show results" cli command

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249186 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoSend a manager event when the manager BridgeAction command is used.
Mark Michelson [Fri, 26 Feb 2010 17:13:36 +0000 (17:13 +0000)]
Send a manager event when the manager BridgeAction command is used.

(closes issue #16769)
Reported by: syspert
Patches:
      bridgeaction.patch uploaded by syspert (license 938)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249105 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 249100 via svnmerge from
Mark Michelson [Fri, 26 Feb 2010 17:04:58 +0000 (17:04 +0000)]
Merged revisions 249100 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r249100 | mmichelson | 2010-02-26 11:04:29 -0600 (Fri, 26 Feb 2010) | 8 lines

  For T.38 reINVITEs treat a 606 the same as a 488.

  (closes issue #16792)
  Reported by: vrban
  Patches:
        t38_606.patch uploaded by vrban (license 756)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249101 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoformatting tweaks and constification
Russell Bryant [Fri, 26 Feb 2010 08:45:11 +0000 (08:45 +0000)]
formatting tweaks and constification

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249058 65c4cc65-6c06-0410-ace0-fbb531ad65f3