asterisk/asterisk.git
10 years agoAdded routing number support.
TransNexus OSP Development [Thu, 30 Apr 2009 09:11:23 +0000 (09:11 +0000)]
Added routing number support.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@191332 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFixed not report source network ID and not export destination network ID issues.
TransNexus OSP Development [Thu, 30 Apr 2009 07:20:59 +0000 (07:20 +0000)]
Fixed not report source network ID and not export destination network ID issues.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@191300 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoChange working directory to / under certain conditions.
Tilghman Lesher [Thu, 30 Apr 2009 06:47:13 +0000 (06:47 +0000)]
Change working directory to / under certain conditions.
If backgrounding and no core will be produced, then changing the directory
won't break anything; likewise, if the CWD isn't accessible by the current
user, then a core wasn't possible anyway.
(closes issue #14831)
 Reported by: chris-mac
 Patches:
       20090428__bug14831.diff.txt uploaded by tilghman (license 14)
       20090430__bug14831.diff.txt uploaded by tilghman (license 14)
 Tested by: chris-mac

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@191283 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRecorded merge of revisions 191220 via svnmerge from
Tilghman Lesher [Wed, 29 Apr 2009 23:12:19 +0000 (23:12 +0000)]
Recorded merge of revisions 191220 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r191220 | tilghman | 2009-04-29 18:10:54 -0500 (Wed, 29 Apr 2009) | 2 lines

  Allow H.323 to compile with FDLEAK checking enabled.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@191221 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake H.323 compile with FDLEAK detection code enabled
Tilghman Lesher [Wed, 29 Apr 2009 23:06:56 +0000 (23:06 +0000)]
Make H.323 compile with FDLEAK detection code enabled

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@191219 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agofix typos
Jeff Peeler [Wed, 29 Apr 2009 22:56:55 +0000 (22:56 +0000)]
fix typos

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@191213 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoPart of the merge did not happen correctly, which resulted in a compile error
Tilghman Lesher [Wed, 29 Apr 2009 22:23:27 +0000 (22:23 +0000)]
Part of the merge did not happen correctly, which resulted in a compile error

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@191211 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSIP option to specify outbound TLS/SSL client protocol.
David Vossel [Wed, 29 Apr 2009 21:13:43 +0000 (21:13 +0000)]
SIP option to specify outbound TLS/SSL client protocol.

chan_sip allows for outbound TLS connections, but does not allow the user to specify what protocol to use (default was SSLv2, and still is if this new option is not specified).  This patch lets the user pick the SSL/TLS client method for outbound connections in sip.

(closes issue #14770)
Reported by: TheOldSaint

(closes issue #14768)
Reported by: TheOldSaint

Review: http://reviewboard.digium.com/r/240/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@191177 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoOutgoing PTP redirected calls did not wait for the COLR from the redirected-to party.
Richard Mudgett [Wed, 29 Apr 2009 21:07:06 +0000 (21:07 +0000)]
Outgoing PTP redirected calls did not wait for the COLR from the redirected-to party.

For outgoing PTP redirected calls, you now need to use the inhibit(i)
option on all of the REDIRECTING statements before dialing the redirected-to
party.  You still have to set the REDIRECTING(to-xxx,i) and the
REDIRECTING(from-xxx,i) values.  The PTP call will update the redirecting-to
presentation when it becomes available and queue the redirecting update to
the calling channel.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@191175 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerge str_substitution branch.
Tilghman Lesher [Wed, 29 Apr 2009 18:53:01 +0000 (18:53 +0000)]
Merge str_substitution branch.
This branch adds additional methods to dialplan functions, whereby the result
buffers are now dynamic buffers, which can be expanded to the size of any
result.  No longer are variable substitutions limited to 4095 bytes of data.
In addition, the common case of needing buffers much smaller than that will
enable substitution to only take up the amount of memory actually needed.
The existing variable substitution routines are still available, but users
of those API calls should transition to using the dynamic-buffer APIs.
Reviewboard: http://reviewboard.digium.com/r/174/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@191140 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemoving crufty code that is no longer necessary. Code cleanup.
David Brooks [Wed, 29 Apr 2009 18:32:58 +0000 (18:32 +0000)]
Removing crufty code that is no longer necessary. Code cleanup.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@191136 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 191096 via svnmerge
David Brooks [Wed, 29 Apr 2009 18:22:24 +0000 (18:22 +0000)]
Blocked revisions 191096 via svnmerge

........
  r191096 | dbrooks | 2009-04-29 13:07:59 -0500 (Wed, 29 Apr 2009) | 8 lines

  Patch to fix tab-completion crash on "remove extension"

  This patch simply removes some old code back before Asterisk used editline.
  This fixes the crash that occurred when tab-completing "remove extension".

  (closes issue #14689)
  Reported by: isaacgal
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@191116 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoConsistent SSL/TLS options across conf files
David Vossel [Wed, 29 Apr 2009 14:39:48 +0000 (14:39 +0000)]
Consistent SSL/TLS options across conf files

ast_tls_read_conf() is a new api call for handling SSL/TLS options across all conf files.  Before this change, SSL/TLS options were not consistent.  http.conf and manager.conf required the 'ssl' prefix while sip.conf used options with the 'tls' prefix.  While the options had different names in different conf files, they all did the exact same thing.  Now, instead of mixing 'ssl' or 'tls' prefixes to do the same thing depending on what conf file you're in, all SSL/TLS options use the 'tls' prefix.  For example.  'sslenable' in http.conf and manager.conf is now 'tlsenable' which matches what already existed in sip.conf. Since this has the potential to break backwards compatibility, previous options containing the 'ssl' prefix still work, but they are no longer documented in the sample.conf files.  The change is noted in the CHANGES file though.

Review: http://reviewboard.digium.com/r/237/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@191028 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoLog an error message if indications.conf is not found.
Russell Bryant [Wed, 29 Apr 2009 08:58:39 +0000 (08:58 +0000)]
Log an error message if indications.conf is not found.

(closes issue #14990)
Reported by: tzafrir
Patches:
      indications_err.diff uploaded by tzafrir (license 46)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190993 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix app_queue XML documentation.
Russell Bryant [Wed, 29 Apr 2009 08:56:13 +0000 (08:56 +0000)]
Fix app_queue XML documentation.

I think it would behoove us to force "make validate-docs" to be run after the
XML documentation has been generated if dev-mode is enabled.

(closes issue #14989)
Reported by: tzafrir
Patches:
      app_queue_xml.diff uploaded by tzafrir (license 46)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190991 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoResolve Solaris build issues and add some API documentation.
Russell Bryant [Wed, 29 Apr 2009 08:51:21 +0000 (08:51 +0000)]
Resolve Solaris build issues and add some API documentation.

(issue #14981)
Reported by: snuffy

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190989 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd support setting CPC from channel variable
Matthew Fredrickson [Tue, 28 Apr 2009 22:07:24 +0000 (22:07 +0000)]
Add support setting CPC from channel variable

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190947 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake sure that we do not clear the down flag on the BRI during PTMP link transients
Matthew Fredrickson [Tue, 28 Apr 2009 22:05:05 +0000 (22:05 +0000)]
Make sure that we do not clear the down flag on the BRI during PTMP link transients

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190946 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUniqueID column has a maximum size of 150
Tilghman Lesher [Tue, 28 Apr 2009 17:31:43 +0000 (17:31 +0000)]
UniqueID column has a maximum size of 150

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190904 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBuild XML documention from *only* the source files that have docs in them
Kevin P. Fleming [Tue, 28 Apr 2009 14:15:47 +0000 (14:15 +0000)]
Build XML documention from *only* the source files that have docs in them

Change the build process so that doc/core-en_US.xml is dependent solely on the source files that have documentation in them, not on all source files.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190865 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemove Makefile rules for bison and flex sources
Kevin P. Fleming [Tue, 28 Apr 2009 14:12:09 +0000 (14:12 +0000)]
Remove Makefile rules for bison and flex sources

We never, ever want these files to processed automatically, because we store the output files in Subversion and users should never need to rebuild them.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190861 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUpdated for OSP Toolkit 3.5.
TransNexus OSP Development [Tue, 28 Apr 2009 09:10:42 +0000 (09:10 +0000)]
Updated for OSP Toolkit 3.5.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190830 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a small memory leak on error in ast_channel_alloc().
Richard Mudgett [Mon, 27 Apr 2009 21:22:17 +0000 (21:22 +0000)]
Fix a small memory leak on error in ast_channel_alloc().

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190797 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake PTP DivertingLegInformation3 message behavior closer to the specifications.
Richard Mudgett [Mon, 27 Apr 2009 20:03:49 +0000 (20:03 +0000)]
Make PTP DivertingLegInformation3 message behavior closer to the specifications.

*  Wait for a DivertingLegInformation3 message after receiving a
DivertingLegInformation1 message to complete the redirecting-to information
before queuing a redirecting update to the other channel.

*  A DivertingLegInformation2 message should be responded to with a
DivertingLegInformation3 when the COLR is determined.  If the call
could or does experience another redirection, you should manually
determine the COLR to send to the switch by setting REDIRECTING(to-pres)
to the COLR and setting REDIRECTING(to-num) = ${EXTEN}.

*  A DivertingLegInformation2 message must have an original called number
if the redirection count is greater than one.  Since Asterisk does
not keep track of this information, we can only indicate that the
number is not available due to interworking.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190735 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDon't warn on pipe in the System call.
Tilghman Lesher [Mon, 27 Apr 2009 19:34:48 +0000 (19:34 +0000)]
Don't warn on pipe in the System call.
(closes issue #14979)
 Reported by: pj

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190726 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 190721 via svnmerge from
Kevin P. Fleming [Mon, 27 Apr 2009 19:30:54 +0000 (19:30 +0000)]
Merged revisions 190721 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r190721 | kpfleming | 2009-04-27 14:29:46 -0500 (Mon, 27 Apr 2009) | 7 lines

  Fix 'inconsistent line endings' when autoconf 2.63 is used

  Attempt to make configure script regeneration 'safe' using autoconf 2.63, which embeds a bare CR into the script, thus making Subversion complain about inconsistent line endings

  This commit changes the MIME type of the configure script to be 'binary' thus making Subversion no longer inspect line endings, and as a bonus 'svn diff' will no longer try to generate diff output for it, which is not generally useful anyway.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190725 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 190661-190662 via svnmerge from
Russell Bryant [Mon, 27 Apr 2009 19:08:12 +0000 (19:08 +0000)]
Merged revisions 190661-190662 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r190661 | russell | 2009-04-27 14:00:54 -0500 (Mon, 27 Apr 2009) | 9 lines

Resolve a crash in res_smdi when used with chan_dahdi.

When chan_dahdi goes to get an SMDI message, it provides no search criteria.
It just grabs the next message that arrives.  This code was written with the
SMDI dialplan functions in mind, since that is now the preferred method of
using SMDI.  However, this broke support of it being used from chan_dahdi.

(closes AST-212)

........
r190662 | russell | 2009-04-27 14:03:59 -0500 (Mon, 27 Apr 2009) | 2 lines

Fix a typo from 190661.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190663 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAllow for a position to be specified when entering a queue.
Mark Michelson [Mon, 27 Apr 2009 16:37:51 +0000 (16:37 +0000)]
Allow for a position to be specified when entering a queue.

This would allow for one to add a caller to a specific place in the
queue instead of just placing the caller in the back every time. To help
facilitate some interesting manipulations, a new channel variable called
QUEUEPOSITION has been added. When a caller is removed from a queue, his
position in that queue is stored in the QUEUEPOSITION variable. One such
strategy an administrator can employ is to allow for the removal of a caller
from one queue followed by the insertion of the same caller into a separate
queue in the same position.

Review: http://reviewboard.digium.com/r/189

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190626 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUpdate warning message to not have pipes and contain all options.
Mark Michelson [Mon, 27 Apr 2009 16:26:14 +0000 (16:26 +0000)]
Update warning message to not have pipes and contain all options.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190622 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a bug where we tried to send events out when no sessions container was present.
Joshua Colp [Mon, 27 Apr 2009 15:18:47 +0000 (15:18 +0000)]
Fix a bug where we tried to send events out when no sessions container was present.

This commit stops a warning message (user_data is NULL) from getting output when
manager events get sent before manager is initialized. This happens because manager
is initialized *after* modules are loaded and the act of loading modules triggers
manager events.

(issue #14974)
Reported by: pj

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190586 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemove nonexistent option from sip.conf.sample.
Mark Michelson [Mon, 27 Apr 2009 14:46:14 +0000 (14:46 +0000)]
Remove nonexistent option from sip.conf.sample.

The option to choose which connected line header to
use is not 'rpid_header' but 'sendrpid'

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190577 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoTLS/SSL private key option
David Vossel [Fri, 24 Apr 2009 21:22:31 +0000 (21:22 +0000)]
TLS/SSL private key option

Adds option to specify a private key .pem file when configuring TLS or SSL in AMI, HTTP, and SIP.  Before this, the certificate file was used for both the public and private key.  It is possible for this file to hold both, but most configurations allow for a separate private key file to be specified.  Clarified in .conf files how these options are to be used.  The current conf files do not explain how the private key is handled at all, so without knowledge of Asterisk's TLS implementation, it would be hard to know for sure what was going on or how to set it up.

Review: http://reviewboard.digium.com/r/234/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190545 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoThere is no need to use the struct ast_party_connected_line.source update values.
Richard Mudgett [Fri, 24 Apr 2009 17:59:01 +0000 (17:59 +0000)]
There is no need to use the struct ast_party_connected_line.source update values.

The messages sent by a technology when a connected line update is received
are best determined by the current call state of the channel.  The struct
ast_party_connected_line.source value is really only useful as a possible
tracing aid.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190517 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUpdate comment.
Richard Mudgett [Fri, 24 Apr 2009 17:33:08 +0000 (17:33 +0000)]
Update comment.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190516 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd \since tag for new API calls.
Russell Bryant [Fri, 24 Apr 2009 15:26:10 +0000 (15:26 +0000)]
Add \since tag for new API calls.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190484 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a build error.
Russell Bryant [Fri, 24 Apr 2009 15:17:38 +0000 (15:17 +0000)]
Fix a build error.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190457 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 190187 via svnmerge
Olle Johansson [Fri, 24 Apr 2009 15:16:48 +0000 (15:16 +0000)]
Blocked revisions 190187 via svnmerge

........
r190187 | oej | 2009-04-23 12:07:26 +0200 (Tor, 23 Apr 2009) | 3 lines

unistd.h is required for usleep() on Darwin. It will not hurt to include it always
on other platforms either.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190454 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoConvert the ast_channel data structure over to the astobj2 framework.
Russell Bryant [Fri, 24 Apr 2009 14:04:26 +0000 (14:04 +0000)]
Convert the ast_channel data structure over to the astobj2 framework.

There is a lot that could be said about this, but the patch is a big
improvement for performance, stability, code maintainability,
and ease of future code development.

The channel list is no longer an unsorted linked list.  The main container
for channels is an astobj2 hash table.  All of the code related to searching
for channels or iterating active channels has been rewritten.  Let n be
the number of active channels.  Iterating the channel list has gone from
O(n^2) to O(n).  Searching for a channel by name went from O(n) to O(1).
Searching for a channel by extension is still O(n), but uses a new method
for doing so, which is more efficient.

The ast_channel object is now a reference counted object.  The benefits
here are plentiful.  Some benefits directly related to issues in the
previous code include:

1) When threads other than the channel thread owning a channel wanted
   access to a channel, it had to hold the lock on it to ensure that it didn't
   go away.  This is no longer a requirement.  Holding a reference is
   sufficient.

2) There are places that now require less dealing with channel locks.

3) There are places where channel locks are held for much shorter periods
   of time.

4) There are places where dealing with more than one channel at a time becomes
   _MUCH_ easier.  ChanSpy is a great example of this.  Writing code in the
   future that deals with multiple channels will be much easier.

Some additional information regarding channel locking and reference count
handling can be found in channel.h, where a new section has been added that
discusses some of the rules associated with it.

Mark Michelson also assisted with the development of this patch.  He did the
conversion of ChanSpy and introduced a new API, ast_autochan, which makes it
much easier to deal with holding on to a channel pointer for an extended period
of time and having it get automatically updated if the channel gets masqueraded.
Mark was also a huge help in the code review process.

Thanks to David Vossel for his assistance with this branch, as well.  David
did the conversion of the DAHDIScan application by making it become a wrapper
for ChanSpy internally.

The changes come from the svn/asterisk/team/russell/ast_channel_ao2 branch.

Review: http://reviewboard.digium.com/r/203/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190423 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix nat setting on RTP instances.
Joshua Colp [Fri, 24 Apr 2009 13:49:03 +0000 (13:49 +0000)]
Fix nat setting on RTP instances.

(closes issue #14827)
Reported by: pj

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190421 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 190356 via svnmerge from
Russell Bryant [Thu, 23 Apr 2009 21:13:07 +0000 (21:13 +0000)]
Merged revisions 190356 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r190356 | russell | 2009-04-23 16:07:07 -0500 (Thu, 23 Apr 2009) | 2 lines

Remove a bogus ast_channel_unlock().

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190357 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoLabels are sometimes (most of the time?) NULL for extensions.
Tilghman Lesher [Thu, 23 Apr 2009 20:42:11 +0000 (20:42 +0000)]
Labels are sometimes (most of the time?) NULL for extensions.
(closes issue #14895)
 Reported by: chris-mac
 Patches:
       20090423__bug14895__2.diff.txt uploaded by tilghman (license 14)
 Tested by: lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190352 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSupport HTTP digest authentication for the http manager interface.
Tilghman Lesher [Thu, 23 Apr 2009 20:36:35 +0000 (20:36 +0000)]
Support HTTP digest authentication for the http manager interface.
(closes issue #10961)
 Reported by: ys
 Patches:
       digest_auth_r148468_v5.diff uploaded by ys (license 281)
       SVN branch http://svn.digium.com/svn/asterisk/team/group/manager_http_auth
 Tested by: ys, twilson, tilghman
 Review: http://reviewboard.digium.com/r/223/
 Reviewed by: tilghman,russellb,mmichelson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190349 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 190286 via svnmerge from
Joshua Colp [Thu, 23 Apr 2009 19:15:30 +0000 (19:15 +0000)]
Merged revisions 190286 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r190286 | file | 2009-04-23 16:13:18 -0300 (Thu, 23 Apr 2009) | 6 lines

  Fix a bug in chan_local glare hangup detection.

  If both sides of a Local channel were hung up at around the same time it was
  possible for one thread to destroy the local private structure and have the other thread
  immediately try to remove the already freed structure from the local channel list.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190287 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix reversed behavior of leavewhenempty option in queues.conf.
Mark Michelson [Thu, 23 Apr 2009 17:45:35 +0000 (17:45 +0000)]
Fix reversed behavior of leavewhenempty option in queues.conf.

(closes issue #14650)
Reported by: alecdavis
Patches:
      14650.patch uploaded by mmichelson (license 60)
Tested by: mmichelson, lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190250 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a double free issue with the Pickup dialplan application.
Joshua Colp [Thu, 23 Apr 2009 16:55:48 +0000 (16:55 +0000)]
Fix a double free issue with the Pickup dialplan application.

As part of the pickup process the connected line information is updated.
Part of this process does a shallow copy of the target channel's connected line
information to a local structure. Once complete the structure contents are freed.
As a result any information in the target channel's connected line information
structure is no longer valid. This change will now set the contents back to a clean
state so that the freeing of the target channel's connected line information structure
when the channel is destroyed will no longer try to double free things.

(closes issue #14839)
Reported by: lmsteffan

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190217 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix example that could fail in certain circumstances
Terry Wilson [Thu, 23 Apr 2009 00:44:18 +0000 (00:44 +0000)]
Fix example that could fail in certain circumstances

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190154 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 190092 via svnmerge from
Tilghman Lesher [Wed, 22 Apr 2009 21:38:15 +0000 (21:38 +0000)]
Merged revisions 190092 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r190092 | tilghman | 2009-04-22 16:35:03 -0500 (Wed, 22 Apr 2009) | 7 lines

  Detect availability of pthread_rwlock_timedwrlock() before using it.
  (closes issue #14930)
   Reported by: tilghman
   Patches:
         20090420__bug14930.diff.txt uploaded by tilghman (license 14)
   Tested by: mvanbaak, tilghman
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190093 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix building of chan_h323 with gcc-3.3
Jeff Peeler [Wed, 22 Apr 2009 21:15:55 +0000 (21:15 +0000)]
Fix building of chan_h323 with gcc-3.3

There seems to be a bug with old versions of g++ that doesn't allow a structure
member to use the name list. Rename list member to group_list in ast_group_info
and change the few places it is used.

(closes issue #14790)
Reported by: stuarth

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190057 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd funcs for manipulating delimited lists in the dialplan
Terry Wilson [Wed, 22 Apr 2009 20:07:41 +0000 (20:07 +0000)]
Add funcs for manipulating delimited lists in the dialplan

Adds PUSH and POP for appending to and retrieving/removing from the
end of a list and UNSHIFT and SHIFT for insert to and retrieiving/
removing from the beginning of a list.

Review: http://reviewboard.digium.com/r/230

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190000 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake chan_h323 respect packetization settings and fix small reload issue.
Jeff Peeler [Wed, 22 Apr 2009 19:23:49 +0000 (19:23 +0000)]
Make chan_h323 respect packetization settings and fix small reload issue.

Previously, packetization settings were ignored and now they are not. A new
config option 'autoframing' has been added to mirror the way chan_sip handles
it. Turning on the autoframing option (available both as a global option or per
peer) overrides the local settings with the remote packetization settings.
Testing was performed with varying packetization levels with the following
codecs: ulaw, alaw, gsm, and g729.

Also, an unrelated config reload issue has been fixed in the case of the config
file not changing.

(closes issue #12415)
Reported by: pj
Patches:
      2009012200_h323packetization.diff.txt uploaded by mvanbaak (license 7),
      modified by me

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189993 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 189991 via svnmerge
Jeff Peeler [Wed, 22 Apr 2009 19:22:11 +0000 (19:22 +0000)]
Blocked revisions 189991 via svnmerge

........
  r189991 | jpeeler | 2009-04-22 14:20:53 -0500 (Wed, 22 Apr 2009) | 15 lines

  Make chan_h323 respect packetization settings

  Previously, packetization settings were ignored and now they are not. A new
  config option 'autoframing' has been added to mirror the way chan_sip handles
  it. Turning on the autoframing option (available both as a global option or per
  peer) overrides the local settings with the remote packetization settings.
  Testing was performed with varying packetization levels with the following
  codecs: ulaw, alaw, gsm, and g729.

  (closes issue #12415)
  Reported by: pj
  Patches:
        2009012200_h323packetization.diff.txt uploaded by mvanbaak (license 7),
        modified by me
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189992 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix call parking callback. Pipes -> Commas.
Russell Bryant [Wed, 22 Apr 2009 16:56:43 +0000 (16:56 +0000)]
Fix call parking callback.  Pipes -> Commas.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189951 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDo not continue to receive DTMF, when the channel is hungup and about to be destroyed.
Tilghman Lesher [Wed, 22 Apr 2009 16:01:30 +0000 (16:01 +0000)]
Do not continue to receive DTMF, when the channel is hungup and about to be destroyed.
(closes issue #14858)
 Reported by: barryf
 Patches:
       20090421__bug14858.diff.txt uploaded by tilghman (license 14)
 Tested by: barryf

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189911 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 189849 via svnmerge from
Michiel van Baak [Wed, 22 Apr 2009 14:30:47 +0000 (14:30 +0000)]
Merged revisions 189849 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r189849 | mvanbaak | 2009-04-22 16:29:28 +0200 (Wed, 22 Apr 2009) | 12 lines

  replace sed with tr to remove \r from downloaded file

  On some systems, sed does not recognize \r in the pattern the way it
  was used here.
  Use tr instead because this works the same across systems.

  (closes issue #14936)
  Reported by: leobrown
  Patches:
        2009042201_14936.diff.txt uploaded by mvanbaak (license 7)
     Tested by: leobrown, mvanbaak
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189850 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDetect liblua on SuSE, and add libm for linking for Fedora.
Tilghman Lesher [Wed, 22 Apr 2009 06:33:08 +0000 (06:33 +0000)]
Detect liblua on SuSE, and add libm for linking for Fedora.
(Reported via the -dev list, Subject: Compiling Asterisk with LUA)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189813 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFixes segfault when switching UDP to TCP in sip.conf after reload.
David Vossel [Tue, 21 Apr 2009 20:28:37 +0000 (20:28 +0000)]
Fixes segfault when switching UDP to TCP in sip.conf after reload.

If transport in sip.conf is switched from UDP to TCP, Asterisk segfaults right after issuing a sip reload.  The problem is the socket type is changed to TCP but the fd may still be present for UDP.  Later, when the TCP session should be created or set using an existing one, it isn't because the old file descriptor is still present.  Now every time transport is changed during a sip.conf reload, the file descriptor is set to -1, signifying it must be created or found.

(closes issue #14727)
Reported by: pj
Tested by: dvossel

Review: http://reviewboard.digium.com/r/229/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189771 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdded CCBS/CCNR Party A support and enhanced COLP support.
Richard Mudgett [Tue, 21 Apr 2009 17:44:01 +0000 (17:44 +0000)]
Added CCBS/CCNR Party A support and enhanced COLP support.

This change adds the following features to chan_misdn:
* CCBS/CCNR Party A support for PTMP and PTP modes.
* Enhances COLP support for call diversion and explicit call transfer.

These enhanced features require a modified version of mISDN.

The latest modified mISDN v1.1.x based version is available at:
http://svn.digium.com/svn/thirdparty/mISDN/trunk
http://svn.digium.com/svn/thirdparty/mISDNuser/trunk

Taged versions of the modified mISDN code are available under:
http://svn.digium.com/svn/thirdparty/mISDN/tags
http://svn.digium.com/svn/thirdparty/mISDNuser/tags

Review: http://reviewboard.digium.com/r/218/

Merged from team/rmudgett/misdn_facility branch.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189735 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 189664 via svnmerge from
Doug Bailey [Tue, 21 Apr 2009 15:54:16 +0000 (15:54 +0000)]
Merged revisions 189664 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r189664 | dbailey | 2009-04-21 10:52:13 -0500 (Tue, 21 Apr 2009) | 2 lines

  Remove daemon call on systems that do not support forking.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189665 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 189601 via svnmerge from
Doug Bailey [Tue, 21 Apr 2009 14:28:04 +0000 (14:28 +0000)]
Merged revisions 189601 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r189601 | dbailey | 2009-04-21 09:00:55 -0500 (Tue, 21 Apr 2009) | 3 lines

  Add check in configure script to check for GLOB_NOMAGIC and GLOB_BRACE in glob.h
  This allows config.c to compile when linked against uclibc that does not support these parameters
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189629 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUse nanosleep instead of poll.
Tilghman Lesher [Mon, 20 Apr 2009 22:10:25 +0000 (22:10 +0000)]
Use nanosleep instead of poll.
This is not just because mmichelson suggested it, but also because Mac OS X puked on my poll().

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189539 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 189537 via svnmerge
Tilghman Lesher [Mon, 20 Apr 2009 22:03:08 +0000 (22:03 +0000)]
Blocked revisions 189537 via svnmerge

........
  r189537 | tilghman | 2009-04-20 17:02:16 -0500 (Mon, 20 Apr 2009) | 11 lines

  Add a workaround for func_odbc/ARRAY() for problems that occur with certain special characters.
  In certain cases, due to the way Set() works in 1.4, values may not get set
  properly.  This is a workaround for 1.4 only that corrects for these issues,
  without making func_odbc more difficult to use properly.
  (closes issue #14614)
   Reported by: wdoekes
   Patches:
         20090309__bug14614__2.diff.txt uploaded by tilghman (license 14)
         double_set_unescape_workaround_for_func_odbc.osso-and-tilghman-1.diff uploaded by wdoekes (license 717)
   Tested by: wdoekes, tilghman
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189538 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 189465 via svnmerge from
Terry Wilson [Mon, 20 Apr 2009 21:29:29 +0000 (21:29 +0000)]
Merged revisions 189465 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r189465 | twilson | 2009-04-20 16:10:27 -0500 (Mon, 20 Apr 2009) | 2 lines

  Update CDR appropriately when AST_CAUSE_NO_ANSWER is set
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189516 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 189463 via svnmerge from
Terry Wilson [Mon, 20 Apr 2009 21:24:34 +0000 (21:24 +0000)]
Merged revisions 189463 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r189463 | twilson | 2009-04-20 16:00:52 -0500 (Mon, 20 Apr 2009) | 2 lines

  Don't treat a NOANSWER like a CHANUNAVAIL
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189495 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 189462 via svnmerge from
Sean Bright [Mon, 20 Apr 2009 21:09:59 +0000 (21:09 +0000)]
Merged revisions 189462 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r189462 | seanbright | 2009-04-20 16:58:39 -0400 (Mon, 20 Apr 2009) | 13 lines

  Properly handle @s within hints in AEL.

  AEL was not handling the case of a device hint containing an @ symbol, which
  caused parking hints (e.g. hint(park:exten@context)) to error out the parser.
  This patch makes AEL treat the @ the same way it treats colon and ampersand
  now, meaning the characters are included in verbatim.

  (closes issue #14941)
  Reported by: bpgoldsb
  Patches:
        bug14941.patch uploaded by seanbright (license 71)
  Tested by: bpgoldsb
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189464 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 189391 via svnmerge from
Doug Bailey [Mon, 20 Apr 2009 19:28:16 +0000 (19:28 +0000)]
Merged revisions 189391 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r189391 | dbailey | 2009-04-20 14:10:56 -0500 (Mon, 20 Apr 2009) | 4 lines

  Clean up problem with manager implementation of mmap where it was not testing against MAP_FAILED response.
  Got rid of shadowed variable used in processign the mmap results.
  Change test of mmap results to compare against MAP_FAILED
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189419 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a bug with non-UDP connections that caused dialogs to not get freed.
Joshua Colp [Mon, 20 Apr 2009 17:05:15 +0000 (17:05 +0000)]
Fix a bug with non-UDP connections that caused dialogs to not get freed.

This issue crept up because of a reference count issue on non-UDP based dialogs.
The dialog reference count was increased when transmitting a packet reliably but never
decreased. This caused the dialog structure to hang around despite being unlinked from
the dialogs container.

(closes issue #14919)
Reported by: vrban

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189350 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 189277 via svnmerge from
Mark Michelson [Mon, 20 Apr 2009 14:05:27 +0000 (14:05 +0000)]
Merged revisions 189277 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r189277 | mmichelson | 2009-04-20 09:04:41 -0500 (Mon, 20 Apr 2009) | 12 lines

  Move the check for chan->fdno == -1 to after the zombie/hangup check.

  Many users were finding that their hung up channels were staying up and
  causing 100% CPU usage.

  (issue #14723)
  Reported by: seadweller
  Patches:
        14723_1-4-tip.patch uploaded by mmichelson (license 60)
  Tested by: falves11, bamby
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189278 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 189203 via svnmerge from
David Vossel [Sat, 18 Apr 2009 01:28:45 +0000 (01:28 +0000)]
Merged revisions 189203 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r189203 | dvossel | 2009-04-17 20:27:19 -0500 (Fri, 17 Apr 2009) | 12 lines

  Fixed autologoff in agents.conf not working when agent logs in via AgentLogin app

  An agent logs in by calling an extension that calls the AgentLogin app.  In agents.conf ackcall=always is set, so when they get a call they have the choice to either acknowledge it or ignore it.  autologoff=10 is set as well, so if the agent ignores the call over 10sec one may assume that the agent should be logged out (and in this case hungup on as well), but this was not happening.

  (closes issue #14091)
  Reported by: evandro
  Patches:
        autologoff.diff uploaded by dvossel (license 671)

  Review: http://reviewboard.digium.com/r/225/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189204 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 188833,189134 via svnmerge from
Richard Mudgett [Fri, 17 Apr 2009 21:48:10 +0000 (21:48 +0000)]
Merged revisions 188833,189134 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r188833 | rmudgett | 2009-04-16 16:37:58 -0500 (Thu, 16 Apr 2009) | 4 lines

  Only disable mISDN DSP if Asterisk DSP is enabled. Leave jitter setting alone.

  JIRA ABE-1835
........
  r189134 | rmudgett | 2009-04-17 16:27:55 -0500 (Fri, 17 Apr 2009) | 4 lines

  Modifed/added some debug messages.

  JIRA ABE-1835
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189137 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoPrevent a crash when SIP blonde transferring an unbridged call.
Mark Michelson [Fri, 17 Apr 2009 20:20:23 +0000 (20:20 +0000)]
Prevent a crash when SIP blonde transferring an unbridged call.

If one attempts to use the attended transfer button on a SIP phone
to transfer an unbridged call (such as a call to an IVR) but hangs
up while the target of the transfer is still ringing, we need to not
crash.

The problem was that ast_hangup was called from outside the channel
thread.

AST-211

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189097 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix copy/paste error with 'transmit silence' flag.
Sean Bright [Fri, 17 Apr 2009 19:36:38 +0000 (19:36 +0000)]
Fix copy/paste error with 'transmit silence' flag.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189077 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 189009 via svnmerge from
Matthew Nicholson [Fri, 17 Apr 2009 15:44:18 +0000 (15:44 +0000)]
Merged revisions 189009 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r189009 | mnicholson | 2009-04-17 10:43:09 -0500 (Fri, 17 Apr 2009) | 5 lines

  Make Busy() application set the CDR disposition to BUSY.

  (closes issue #14306)
  Reported by: cristiandimache
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189010 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 188946 via svnmerge from
Joshua Colp [Fri, 17 Apr 2009 14:44:56 +0000 (14:44 +0000)]
Merged revisions 188946 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r188946 | file | 2009-04-17 11:41:25 -0300 (Fri, 17 Apr 2009) | 15 lines

  Fix a bug where a value used to create the channel name was bogus.

  This commit fixes the scenario where an incoming call is authenticated
  using a peer entry. Previously the channel name was created using either
  the username setting from the sip.conf entry or the IP address that the
  call came from. Now the channel name will be created using the peer name
  itself. This commit will not change the way the channel name is generated
  for users or friends.

  (closes issue #14256)
  Reported by: Nick_Lewis
  Patches:
        chan_sip.c-chname.patch uploaded by Nick (license 657)
  Tested by: Nick_Lewis, file
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188947 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a spacing issue that I claimed I would when I committed this code.
Mark Michelson [Fri, 17 Apr 2009 14:33:50 +0000 (14:33 +0000)]
Fix a spacing issue that I claimed I would when I committed this code.

Nothing major though.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188942 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 188937 via svnmerge from
Joshua Colp [Fri, 17 Apr 2009 14:26:53 +0000 (14:26 +0000)]
Merged revisions 188937 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r188937 | file | 2009-04-17 11:25:57 -0300 (Fri, 17 Apr 2009) | 4 lines

  Fix a situation where the DAHDI channel private structure lock was not unlocked when it should have been.

  (issue AST-210)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188938 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSeveral fixes to the extenpatternmatchnew logic.
Mark Michelson [Fri, 17 Apr 2009 13:29:33 +0000 (13:29 +0000)]
Several fixes to the extenpatternmatchnew logic.

1. Differentiate between literal characters in an extension
and characters that should be treated as a pattern match. Prior to
these fixes, an extension such as NNN would be treated as a pattern,
rather than a literal string of N's.

2. Fixed the logic used when matching an extension with a bracketed
expression, such as 2[5-7]6.

3. Removed all areas of code that were executed when NOT_NOW was
#defined. The code in these areas had the potential to crash, for
one thing, and the actual intent of these blocks seemed counterproductive.

4. Fixed many many coding guidelines problems I encountered while looking
through the corresponding code.

5. Added failure cases and warning messages for when duplicate extensions
are encountered.

6. Miscellaneous fixes to incorrect or redundant statements.

(closes issue #14615)
Reported by: steinwej
Tested by: mmichelson

Review: http://reviewboard.digium.com/r/194/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188901 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 188835 via svnmerge from
Tilghman Lesher [Thu, 16 Apr 2009 21:57:37 +0000 (21:57 +0000)]
Merged revisions 188835 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r188835 | tilghman | 2009-04-16 16:41:13 -0500 (Thu, 16 Apr 2009) | 7 lines

  Only update realtime, if global option rtupdate != false
  (closes issue #14885)
   Reported by: deepesh
   Patches:
         20090413__bug14885.diff.txt uploaded by tilghman (license 14)
   Tested by: deepesh
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188836 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 188773 via svnmerge from
Tilghman Lesher [Thu, 16 Apr 2009 21:03:31 +0000 (21:03 +0000)]
Merged revisions 188773 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r188773 | tilghman | 2009-04-16 16:02:29 -0500 (Thu, 16 Apr 2009) | 4 lines

  Umask should not be exported into global namespace.
  (closes issue #14912)
   Reported by: jcapp
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188774 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSIP state notify reorganization
David Vossel [Thu, 16 Apr 2009 19:30:23 +0000 (19:30 +0000)]
SIP state notify reorganization

What I've done here is simply break up how a state NOTIFY is built.  Originally both the XML and sip header information were built within the same function.  While this does work, it does not allow for the creation of multipart/related message bodies that can contain multiple XML entries with only one sip header.  Now a separate function builds the XML for each notify.  This patch also makes maintaining and modifying state notifications in the future much less of a pain.

Review: http://reviewboard.digium.com/r/224/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188742 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a bug with the dahdi_setoption callback in chan_dahdi.
Joshua Colp [Thu, 16 Apr 2009 13:42:52 +0000 (13:42 +0000)]
Fix a bug with the dahdi_setoption callback in chan_dahdi.

This function incorrectly reported success even if the option was
unsupported. This was exposed by the options to change the underlying
channel format. The function now returns a failure if the option
is unsupported.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188705 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 188646 via svnmerge from
David Vossel [Wed, 15 Apr 2009 22:10:04 +0000 (22:10 +0000)]
Merged revisions 188646 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r188646 | dvossel | 2009-04-15 17:08:40 -0500 (Wed, 15 Apr 2009) | 12 lines

  National prefix inserted even when caller ID not available

  When the caller ID is restricted, the expected behavior is for the caller id to be blank.  In chan_dahdi, the national prefix is placed onto the callers number even if its restricted (empty) causing the caller id to be the national prefix rather than blank.

  (closes issue #13207)
  Reported by: shawkris
  Patches:
        national_prefix.diff uploaded by dvossel (license 671)

  Review: http://reviewboard.digium.com/r/220/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188647 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 188582 via svnmerge from
Mark Michelson [Wed, 15 Apr 2009 20:17:33 +0000 (20:17 +0000)]
Merged revisions 188582 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r188582 | mmichelson | 2009-04-15 15:04:20 -0500 (Wed, 15 Apr 2009) | 7 lines

  Update ast_readvideo_callback to match ast_readaudio_callback.

  This fixes potential refcount errors that may occur on ast_filestreams.

  AST-208
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188585 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake the cancellation of the dial timeout on a call forward optional.
Mark Michelson [Wed, 15 Apr 2009 15:24:50 +0000 (15:24 +0000)]
Make the cancellation of the dial timeout on a call forward optional.

This introduces the 'z' option to app_dial. With it set, a call forward
will cancel any timeout originally set for this instance of the Dial
application.

AST-207

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188544 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDon't try to do anything in pri_check_restart with service messages unless
Jeff Peeler [Wed, 15 Apr 2009 14:57:20 +0000 (14:57 +0000)]
Don't try to do anything in pri_check_restart with service messages unless
libpri supports it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188515 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a couple of queue member reference leaks.
Mark Michelson [Tue, 14 Apr 2009 23:28:13 +0000 (23:28 +0000)]
Fix a couple of queue member reference leaks.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188470 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix an incorrect clock rate when sending T140 text.
Joshua Colp [Tue, 14 Apr 2009 17:40:50 +0000 (17:40 +0000)]
Fix an incorrect clock rate when sending T140 text.

(closes issue #14029)
Reported by: epicac

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188413 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agochange some capitalization
Jeff Peeler [Tue, 14 Apr 2009 16:49:12 +0000 (16:49 +0000)]
change some capitalization

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188378 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd service maintenance message support
Jeff Peeler [Tue, 14 Apr 2009 15:54:16 +0000 (15:54 +0000)]
Add service maintenance message support

This is the companion commit to libpri r732. Service messages are now supported
for switch types 4ess/5ess. A new option service_message_support has been added
to chan_dahdi.conf and is noted in the sample config file. The service message
support is turned off by default. The current implementation relies on AstDB
to keep track of channel state, which allows the statuses to be preserved
across Asterisk restarts. Below is a description of the storage format.

The state and reason for the service state are in the form <state>:<reason>,
where:
<state> ::= { 'O' }  // 'O' – Out Of Service
<reason> ::= { '0' | '1' | '2' | '3' }, where:
'0' – No reason (backwards compatibility)
'1' – NEAR END
'2' – FAR END
'3' – both NEAR and FAR END

The new CLI commands to handle channel service state are:
pri service disable channel <chan>
pri service enable channel <chan>

Many people contributed to the development of this functionality. Because I
entered at the very end I do not know the exact history. Special thanks to
all who moved the bug forward one way or another:
cmaj, PCadach, markster, mattf, drmac, MikeJ, serge-v, murf, kanelbullar, Seb7,
tilghman, lmadsen, and especially dhubbard (he answered lots of my questions
and did a large portion of the work)

(closes issue #3450)
Reported by: cmaj

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188342 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoNew actions should go under "New Actions", not "new events"
Olle Johansson [Tue, 14 Apr 2009 14:22:39 +0000 (14:22 +0000)]
New actions should go under "New Actions", not "new events"

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188284 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMaking sure we have references to external libraries.
Olle Johansson [Tue, 14 Apr 2009 14:20:10 +0000 (14:20 +0000)]
Making sure we have references to external libraries.

Note: Update h.323 with the recent changes too

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188283 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a bug with the change I made yesterday to outbound proxy support.
Joshua Colp [Tue, 14 Apr 2009 13:14:21 +0000 (13:14 +0000)]
Fix a bug with the change I made yesterday to outbound proxy support.

Per discussion with oej on IRC we need the actual IP address, not the
outbound proxy IP address, in the sa field. This change matches the already
existing code for all other uses of the outbound proxy setting.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188247 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAs suggested by Russell, warn users when their dialplan arguments contain pipes,...
Tilghman Lesher [Tue, 14 Apr 2009 05:45:13 +0000 (05:45 +0000)]
As suggested by Russell, warn users when their dialplan arguments contain pipes, but not commas.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188210 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoApplication delimiter is ',', not '|'.
Tilghman Lesher [Tue, 14 Apr 2009 05:27:53 +0000 (05:27 +0000)]
Application delimiter is ',', not '|'.
(closes issue #14881)
 Reported by: stegro
 Patches:
       smsq.patch uploaded by stegro (license 752)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188206 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 188149 via svnmerge
Tilghman Lesher [Mon, 13 Apr 2009 23:05:53 +0000 (23:05 +0000)]
Blocked revisions 188149 via svnmerge

........
  r188149 | tilghman | 2009-04-13 18:04:15 -0500 (Mon, 13 Apr 2009) | 4 lines

  If fileconfig limit exceeds our maximum, then set the limit to the maximum.
  (Closes issue #14888)
  Reported by: falves11
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188150 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix another crash related to cached realtime music on hold.
Mark Michelson [Mon, 13 Apr 2009 19:31:48 +0000 (19:31 +0000)]
Fix another crash related to cached realtime music on hold.

This was another off-by-one problem caused by moh_register.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188102 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a bug where using an outbound proxy would cause the local address to be 127.0...
Joshua Colp [Mon, 13 Apr 2009 16:28:06 +0000 (16:28 +0000)]
Fix a bug where using an outbound proxy would cause the local address to be 127.0.0.1.

Copy the outbound proxy IP address into the SIP dialog structure as the IP address we will
be sending to. This has to be done because the logic that determines what local IP address to use
in the SIP messages is not aware of an outbound proxy being in place. It only knows what IP address
we are sending to.

(closes issue #12006)
Reported by: mnicholson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188067 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSet all queue variables on both the caller and member channels.
Mark Michelson [Mon, 13 Apr 2009 14:17:56 +0000 (14:17 +0000)]
Set all queue variables on both the caller and member channels.

This allows for the variables to be accessed if a member macro is run.
Thanks to Grigoriy Puzankin for bringing this up on the -dev list.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188032 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 187962 via svnmerge
Jeff Peeler [Fri, 10 Apr 2009 22:16:38 +0000 (22:16 +0000)]
Blocked revisions 187962 via svnmerge

........
  r187962 | jpeeler | 2009-04-10 17:16:13 -0500 (Fri, 10 Apr 2009) | 9 lines

  Fix module embedding for chan_h323.

  Include libchanh323.a in the modules.link file so that all the symbols can be
  resolved at link time.

  (closes issue #11966)
  Reported by: dome
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@187963 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix module embedding for chan_h323.
Jeff Peeler [Fri, 10 Apr 2009 20:26:46 +0000 (20:26 +0000)]
Fix module embedding for chan_h323.

Include libchanh323.a in the modules.link file so that all the symbols can be
resolved at link time.

(closes issue #11966)
Reported by: dome
Patches:
      issue_11966.patch uploaded by kpfleming (license 421)
Tested by: jpeeler

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@187906 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 187865 via svnmerge
Russell Bryant [Fri, 10 Apr 2009 19:27:23 +0000 (19:27 +0000)]
Blocked revisions 187865 via svnmerge

........
r187865 | russell | 2009-04-10 14:26:40 -0500 (Fri, 10 Apr 2009) | 4 lines

Support "signaling" in addition to "signalling".

The sample configuration file has references to both spellings.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@187866 65c4cc65-6c06-0410-ace0-fbb531ad65f3