asterisk/asterisk.git
9 years agoConvert to AST_CLI_YESNO and AST_CLI_ONOFF
Paul Belanger [Wed, 12 May 2010 01:00:55 +0000 (01:00 +0000)]
Convert to AST_CLI_YESNO and AST_CLI_ONOFF

Clean up chan_sip.c to use new AST_CLI functions

(closes issue #17287)
Reported by: pabelanger
Patches:
      issue17287.patch uploaded by pabelanger (license 224)
Tested by: russell

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@262613 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoDialing an invalid extension causes incomplete hangup sequence.
Richard Mudgett [Tue, 11 May 2010 23:18:53 +0000 (23:18 +0000)]
Dialing an invalid extension causes incomplete hangup sequence.

Revision -r1489 of the libpri 1.4 branch corrected a deviation from Q.931
Section 5.3.2.  However, this resulted in an unexpected behaviour change
to the upper layer (Asterisk).

This change uses pri_hangup_fix_enable() to follow Q.931 Section 5.3.2
call hangup better if the version of libpri supports it.

(issue #17104)
Reported by: shawkris
Tested by: rmudgett

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@262569 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMove cause 200 to cause 26, as specified in Q.850.
Tilghman Lesher [Tue, 11 May 2010 21:25:05 +0000 (21:25 +0000)]
Move cause 200 to cause 26, as specified in Q.850.

Also cleanup the formatting and add a few more that seem like good candidates.

(closes issue #16157)
 Reported by: wimpy

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@262513 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 262421 via svnmerge from
Jason Parker [Tue, 11 May 2010 19:57:24 +0000 (19:57 +0000)]
Merged revisions 262421 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r262421 | qwell | 2010-05-11 14:55:42 -0500 (Tue, 11 May 2010) | 11 lines

  Use a less silly method for modifying a flex-generated file.

  The sed syntax that was used wasn't actually valid, causing some versions to
  choke.  This is the method that is used in 1.6.x+ for similar changes.

  (closes issue #16696)
  Reported by: bklang
  Patches:
        16696-sedfix.diff uploaded by qwell (license 4)
  Tested by: qwell
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@262422 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoImprove logging by displaying line number
Paul Belanger [Tue, 11 May 2010 19:40:37 +0000 (19:40 +0000)]
Improve logging by displaying line number

(closes issue #16303)
Reported by: dant
Patches:
      issue16303.patch.v2 uploaded by pabelanger (license 224)
Tested by: dant, lmadsen, pabelanger

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@262419 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoImprove logging information for misconfigured contexts
Paul Belanger [Tue, 11 May 2010 19:26:17 +0000 (19:26 +0000)]
Improve logging information for misconfigured contexts

(closes issue #17238)
Reported by: pprindeville
Patches:
      chan_sip-bug17238.patch uploaded by pprindeville (license 347)
Tested by: pprindeville

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@262414 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 262321 via svnmerge from
Tilghman Lesher [Tue, 11 May 2010 17:23:51 +0000 (17:23 +0000)]
Merged revisions 262321 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r262321 | tilghman | 2010-05-11 12:22:07 -0500 (Tue, 11 May 2010) | 2 lines

  Fix issue #17302 a slightly different way (mad props to Qwell)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@262330 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAllow bootstrap script to work on Solaris.
Jason Parker [Tue, 11 May 2010 16:43:07 +0000 (16:43 +0000)]
Allow bootstrap script to work on Solaris.

As usual, the way they do things is different, so we need to account for that.
automake is versioned ala BSD/Linux, but autoconf is not.  We don't actually
need to specify a version there, since AC_PREREQ will cover it for us.  Things
will fail pretty loudly if AC_PREREQ isn't met.

(closes issue #16341)
Reported by: bklang
Patches:
      opensolaris_bootstrap.sh uploaded by bklang (license 919)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@262299 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes PickupChan application
David Vossel [Mon, 10 May 2010 19:06:08 +0000 (19:06 +0000)]
fixes PickupChan application

(closes issue #16863)
Reported by: schern
Patches:
      app_directed_pickup.c.patch uploaded by schern (license 995)
      for_trunk.diff uploaded by cjacobsen (license 1029)
Tested by: Graber, cjacobsen, lathama, rickead2000, dvossel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@262240 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes crash in chan_console
David Vossel [Mon, 10 May 2010 18:36:10 +0000 (18:36 +0000)]
fixes crash in chan_console

There is a race condition between console_hangup()
and start_stream().  It is possible for console_hangup()
to be called and then the stream thread to begin after the hangup.
To avoid this a check in start_stream() to make sure the pvt-owner
still exists while the pvt lock is held is made.  If the owner
is gone that means the channel hung up and start_stream should
be aborted.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@262236 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 262151 via svnmerge from
Tilghman Lesher [Mon, 10 May 2010 16:36:25 +0000 (16:36 +0000)]
Merged revisions 262151 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r262151 | tilghman | 2010-05-10 11:34:21 -0500 (Mon, 10 May 2010) | 10 lines

  Allow compilation on Mac OS X 10.4 (Tiger)

  (closes issue #17297)
   Reported by: jcovert
   Patches:
         20100506__issue17297.diff.txt uploaded by tilghman (license 14)

  (closes issue #17302)
   Reported by: jcovert
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@262152 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoCleanup a bit more by getting rid of useless version defines. Also make library detec...
Tilghman Lesher [Sun, 9 May 2010 02:14:04 +0000 (02:14 +0000)]
Cleanup a bit more by getting rid of useless version defines. Also make library detection use passed CFLAGS.

(closes issue #17309)
 Reported by: stuarth

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@262102 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUse CPPFLAGS to pass PTHREAD_CFLAGS for vpb only
Tilghman Lesher [Sat, 8 May 2010 02:40:01 +0000 (02:40 +0000)]
Use CPPFLAGS to pass PTHREAD_CFLAGS for vpb only

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@262048 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoVoicemailMain and VMauthenticate, allow escape to the 'a' extension when a single...
Alec L Davis [Fri, 7 May 2010 23:54:15 +0000 (23:54 +0000)]
VoicemailMain and VMauthenticate, allow escape to the 'a' extension when a single '*' is entered

Where a site uses VoicemailMain(mailbox) the users have to be at their own extension to clear
their voicemail, they have no way of escaping VoicemailMain to allow entry of new boxnumber.

This patch, allows a site to include to 'a' priority in the VoicemailMain context, to allow an escape.

If the 'a' priority doesn't exist in the context that VoicemailMain was called from then it acts as the old behaviour.

  Reported by: alecdavis
  Tested by: alecdavis
  Patch
 vm_a_extension.diff2.txt uploaded by alecdavis (license 585)

Review: https://reviewboard.asterisk.org/r/489/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@262005 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix build on Linux
Tilghman Lesher [Fri, 7 May 2010 22:09:09 +0000 (22:09 +0000)]
Fix build on Linux

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261964 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoDouble free crash
Tilghman Lesher [Fri, 7 May 2010 20:54:35 +0000 (20:54 +0000)]
Double free crash

(closes issue #17245)
 Reported by: thedavidfactor
 Patches:
       20100426__issue17245.diff.txt uploaded by tilghman (license 14)
 Tested by: murraytm

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261917 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUse the detected pthread building flags in every place, instead of hardcoding -lpthread.
Tilghman Lesher [Fri, 7 May 2010 20:35:17 +0000 (20:35 +0000)]
Use the detected pthread building flags in every place, instead of hardcoding -lpthread.

We nicely detect the right flags on each system for building Asterisk with
pthreads, then ignore it for every other build option that requires us to
build with pthreads.  This caused some items to return a false negative.
Also cleanup some minor naming issues that caused "library library" redundancy
in the output.

(closes issue #17303)
 Reported by: stuarth
 Patches:
       20100507__issue17303.diff.txt uploaded by tilghman (license 14)
 Tested by: stuarth

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261913 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate UPGRADE-1.6.txt stating insecure=very has been removed.
Leif Madsen [Fri, 7 May 2010 16:05:24 +0000 (16:05 +0000)]
Update UPGRADE-1.6.txt stating insecure=very has been removed.

(closes issue #17282)
Reported by: stuarth
Tested by: stuarth

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261867 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix deadlock in sig_pri when hanging up.
Jeff Peeler [Fri, 7 May 2010 15:33:52 +0000 (15:33 +0000)]
Fix deadlock in sig_pri when hanging up.

The pri_dchannel thread currently violates locking order by locking the private
and then attempting to queue a frame, which needs to lock the channel. Queueing
a frame is unneccesary though and is actually a regression since sig_pri.
All the places that currently use ast_softhangup_nolock now will just set the
softhangup value directly as before.

(closes issue #17216)
Reported by: lmsteffan
Patches:
      bug17216.patch uploaded by jpeeler (license 325)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261866 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoSome code optimizations.
Richard Mudgett [Thu, 6 May 2010 23:41:22 +0000 (23:41 +0000)]
Some code optimizations.

* Made more places use pri_queue_control() instead of pri_queue_frame()
and a local frame variable.

* Made pri_queue_frame() use sig_pri_lock_owner().  pri_queue_frame() no
longer releases the libpri access lock unless it is required.

* Made the pri_queue_frame() and pri_queue_control() parameter list
similar to sig_pri_lock_owner().

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261822 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 261735 via svnmerge from
Jeff Peeler [Thu, 6 May 2010 20:11:53 +0000 (20:11 +0000)]
Merged revisions 261735 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r261735 | jpeeler | 2010-05-06 15:10:59 -0500 (Thu, 06 May 2010) | 8 lines

  Only allow the operator key to be accepted after leaving a voicemail.

  Or rather disallow the operator key from being accepted when not offered,
  such as after finishing a recording from within the mailbox options menu.

  ABE-2121
  SWP-1267
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261736 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 261608 via svnmerge from
Jason Parker [Thu, 6 May 2010 17:06:40 +0000 (17:06 +0000)]
Merged revisions 261608 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r261608 | qwell | 2010-05-06 11:56:02 -0500 (Thu, 06 May 2010) | 4 lines

  Use the versioned MOH tarballs, now that we have them.

  This makes for more reproducibility.  Prompted by a discussion in #asterisk-dev
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261609 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoPermit more lines within a SIP body to be parsed.
Tilghman Lesher [Thu, 6 May 2010 15:39:10 +0000 (15:39 +0000)]
Permit more lines within a SIP body to be parsed.

The example given within the related issue showed 120 lines, which was mostly
a result of the body being XML.

(closes issue #17179)
 Reported by: khw

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261560 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd test case for removing random elements from a heap.
Russell Bryant [Thu, 6 May 2010 14:15:57 +0000 (14:15 +0000)]
Add test case for removing random elements from a heap.

I modified the original patch for trunk to use the unit test API.

(issue #17277)
Reported by: cappucinoking
Patches:
      test_heap.diff uploaded by cappucinoking (license 1036)
Tested by: cappucinoking, russell

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261500 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix handling of removing nodes from the middle of a heap.
Russell Bryant [Thu, 6 May 2010 13:58:07 +0000 (13:58 +0000)]
Fix handling of removing nodes from the middle of a heap.

This bug surfaced in 1.6.2 and does not affect code in any other released
version of Asterisk.  It manifested itself as SIP qualify not happening when
it should, causing peers to go unreachable.  This was debugged down to scheduler
entries sometimes not getting executed when they were supposed to, which was in
turn caused by an error in the heap code.

The problem only sometimes occurs, and it is due to the logic for removing an entry
in the heap from an arbitrary location (not just popping off the top).  The scheduler
performs this operation frequently when entries are removed before they run (when
ast_sched_del() is used).

In a normal pop off of the top of the heap, a node is taken off the bottom,
placed at the top, and then bubbled down until the max heap property is restored
(see max_heapify()).  This same logic was used for removing an arbitrary node
from the middle of the heap.  Unfortunately, that logic is full of fail.  This
patch fixes that by fully restoring the max heap property when a node is thrown
into the middle of the heap.  Instead of just pushing it down as appropriate, it
first pushes it up as high as it will go, and _then_ pushes it down.

Lastly, fix a minor problem in ast_heap_verify(), which is only used for
debugging.  If a parent and child node have the same value, that is not an
error.  The only error is if a parent's value is less than its children.

A huge thanks goes out to cappucinoking for debugging this down to the scheduler,
and then producing an ast_heap test case that demonstrated the breakage.  That
made it very easy for me to focus on the heap logic and produce a fix.  Open source
projects are awesome.

(closes issue #16936)
Reported by: ib2
Tested by: cappucinoking, crjw

(closes issue #17277)
Reported by: cappucinoking
Patches:
      heap-fix.rev2.diff uploaded by russell (license 2)
Tested by: cappucinoking, russell

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261496 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoWhen failing to configure, don't destroy 'cfg' twice
Tzafrir Cohen [Thu, 6 May 2010 07:27:31 +0000 (07:27 +0000)]
When failing to configure, don't destroy 'cfg' twice

Fixes a crash when some config section had an incorrect channel config.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261451 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAvoid a crash on SS7 channels.
Richard Mudgett [Wed, 5 May 2010 22:22:14 +0000 (22:22 +0000)]
Avoid a crash on SS7 channels.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261405 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRestore previous asterisk.conf syntax, where the directories aren't commented out.
Russell Bryant [Wed, 5 May 2010 20:48:15 +0000 (20:48 +0000)]
Restore previous asterisk.conf syntax, where the directories aren't commented out.

This fixes some breakage in the test suite, that uses the contents of asterisk.conf
to discover the install layout on the system.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261364 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes sip native transfer
David Vossel [Wed, 5 May 2010 19:13:57 +0000 (19:13 +0000)]
fixes sip native transfer

The Refer-To header field containing the Replaces header in the URI
was not being decoded properly.  This caused invalid parsing between
the caller id field and the domain resulting in a failed transfer.

(closes issue #17284)
Reported by: dvossel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261316 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 261274 via svnmerge from
Paul Belanger [Wed, 5 May 2010 18:43:03 +0000 (18:43 +0000)]
Merged revisions 261274 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r261274 | pabelanger | 2010-05-05 12:42:22 -0400 (Wed, 05 May 2010) | 12 lines

  Registration fix for SIP realtime.

  Make sure realtime fields are not empty.

  (closes issue #17266)
  Reported by: Nick_Lewis
  Patches:
        chan_sip.c-realtime.patch uploaded by Nick Lewis (license 657)
  Tested by: Nick_Lewis, sberney

  Review: https://reviewboard.asterisk.org/r/643/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261314 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoPrevent unnecessary warnings when getting rtpsource or rtpdest.
Mark Michelson [Wed, 5 May 2010 18:28:05 +0000 (18:28 +0000)]
Prevent unnecessary warnings when getting rtpsource or rtpdest.

If a recognized media type was present, but the media type was not
enabled for the channel, then a warning would be emitted. For instance,
attempting to get CHANNEL(rtpsource,video) on a call with no video would
cause a warning message to appear.

With this change, the warning will only appear if the stream argument
is not recognized as being a media type that can be specified.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261313 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years ago'queue reset stats' erroneously clears wrapuptime configuration.
Paul Belanger [Wed, 5 May 2010 15:42:07 +0000 (15:42 +0000)]
'queue reset stats' erroneously clears wrapuptime configuration.

Resets each member's lastcall to 0 now.

(closes issue #17262)
Reported by: rain
Patches:
      wrapuptime_reset_fix.diff uploaded by rain (license 327)
Tested by: rain

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261232 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoNew 'manager show settings' CLI command.
Paul Belanger [Wed, 5 May 2010 00:44:37 +0000 (00:44 +0000)]
New 'manager show settings' CLI command.

See the CHANGES file for more details.

(closes issue #16343)
Reported by: pabelanger
Patches:
      issue16343.patch.v5 uploaded by pabelanger (license 224)
Tested by: pabelanger, tilghman, lmadsen

Review: https://reviewboard.asterisk.org/r/630/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261180 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoNew static asterisk.conf.sample file.
Paul Belanger [Wed, 5 May 2010 00:22:32 +0000 (00:22 +0000)]
New static asterisk.conf.sample file.

This simply moves the functionality from the Makefile (cleaning it up) into an external
asterisk.conf.samples file.  Also updates formatting (easier to read) and grammar
changes to asterisk.conf.samples.

(closes issue #17027)
Reported by: pabelanger
Patches:
      0017027.asterisk.conf.v6.patch uploaded by pabelanger (license 224)
Tested by: qwell, lmadsen, pabelanger, chappell

Review: https://reviewboard.asterisk.org/r/616/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261124 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 261093-261094 via svnmerge from
Tilghman Lesher [Tue, 4 May 2010 23:51:52 +0000 (23:51 +0000)]
Merged revisions 261093-261094 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r261093 | tilghman | 2010-05-04 18:36:53 -0500 (Tue, 04 May 2010) | 7 lines

  Protect against overflow, when calculating how long to wait for a frame.

  (closes issue #17128)
   Reported by: under
   Patches:
         d.diff uploaded by under (license 914)
........
  r261094 | tilghman | 2010-05-04 18:47:08 -0500 (Tue, 04 May 2010) | 2 lines

  Add a tiny corner case to the previous commit
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261095 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd new possible value to autopause option to allow members to be autopaused in all...
Mark Michelson [Tue, 4 May 2010 22:46:42 +0000 (22:46 +0000)]
Add new possible value to autopause option to allow members to be autopaused in all queues.

See the CHANGES file and queues.conf.sample for more details.

(closes issue #17008)
Reported by: jlpedrosa
Patches:
      queues.autopause_en_review.diff uploaded by jlpedrosa (license 1002)

Review: https://reviewboard.asterisk.org/r/581/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261051 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoThe inalarm flag is not passed up from the sig_analog and sig_pri submodules.
Richard Mudgett [Tue, 4 May 2010 21:10:58 +0000 (21:10 +0000)]
The inalarm flag is not passed up from the sig_analog and sig_pri submodules.

The CLI "dahdi show channel" command was not correctly reporting the
InAlarm status.

The inalarm flag is now consistently passed between chan_dahdi and
submodules.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@261007 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 260923 via svnmerge from
Jeff Peeler [Tue, 4 May 2010 18:51:28 +0000 (18:51 +0000)]
Merged revisions 260923 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r260923 | jpeeler | 2010-05-04 13:46:46 -0500 (Tue, 04 May 2010) | 12 lines

  Voicemail transfer to operator should occur immediately, not after main menu.

  There were two scenarios in the advanced options that while using the
  operator=yes and review=yes options, the transfer occurred only after exiting
  the main menu (after sending a reply or leaving a message for an extension).
  Now after the audio is processed for the reply or message the transfer occurs
  immediately as expected.

  ABE-2107
  ABE-2108
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260924 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 260801 via svnmerge from
Jason Parker [Tue, 4 May 2010 15:49:57 +0000 (15:49 +0000)]
Merged revisions 260801 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r260801 | qwell | 2010-05-04 10:49:27 -0500 (Tue, 04 May 2010) | 1 line

  Fix fallout from removing  from configure script.  Pointed out by philipp64 on #asterisk-dev
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260802 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd new admin features to meetme: Roll call, eject all, mute all, record in-conf
Jeff Peeler [Mon, 3 May 2010 22:13:24 +0000 (22:13 +0000)]
Add new admin features to meetme: Roll call, eject all, mute all, record in-conf

This patch adds the following in-conference admin DTMF features:
*81 - Roll call (or simply user count if INTROUSER isn't enabled)
*82 - Eject all non-admins
*83 - Mute/unmute all non-admins
*84 - Start recording the conference on the fly

FWIW, this code uses newly recorded prompts.

(closes issue #16379)
Reported by: rfinnie
Patches:
      meetme-enhancements-232771-v1.patch uploaded by rfinnie (license 940)
      modified slightly by me

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260757 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 260661-260662 via svnmerge from
Paul Belanger [Mon, 3 May 2010 17:06:48 +0000 (17:06 +0000)]
Merged revisions 260661-260662 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r260661 | pabelanger | 2010-05-03 12:41:30 -0400 (Mon, 03 May 2010) | 10 lines

  non-root make install PREFIX=/tmp fails.
  Prepend libdir when executing mkpkgconfig allowing non-root installs to work.

  (closes issue #17268)
  Reported by: pabelanger
  Patches:
        issue17268.patch uploaded by pabelanger (license 224)
  Tested by: pabelanger
........
  r260662 | pabelanger | 2010-05-03 12:54:41 -0400 (Mon, 03 May 2010) | 3 lines

  Should have removed /usr/lib/ part. Thanks Qwell.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260663 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 260569 via svnmerge from
Leif Madsen [Mon, 3 May 2010 14:58:23 +0000 (14:58 +0000)]
Merged revisions 260569 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r260569 | lmadsen | 2010-05-03 09:57:39 -0500 (Mon, 03 May 2010) | 1 line

  Minor typo pointed out by pabelanger on IRC.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260570 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAvoid making AstData depend on libxml2 to compile.
Eliel C. Sardanons [Sun, 2 May 2010 02:52:23 +0000 (02:52 +0000)]
Avoid making AstData depend on libxml2 to compile.

We have some functions inside the AstData API to get the tree
in XML form, but it is not required at the moment to compile
asterisk and we can disable that part of the API if we don't have
libxml2 support.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260521 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 260434 via svnmerge from
Jeff Peeler [Fri, 30 Apr 2010 22:36:49 +0000 (22:36 +0000)]
Merged revisions 260434 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r260434 | jpeeler | 2010-04-30 17:22:46 -0500 (Fri, 30 Apr 2010) | 11 lines

  Ensure channel state is not incorrectly set in the case of a very early answer.

  The needringing bit was being read in dahdi_read after answering thereby
  setting the state to ringing from up. This clears needringing upon answering
  so that is no longer possible.

  (closes issue #17067)
  Reported by: tzafrir
  Patches:
        needringing.diff uploaded by tzafrir (license 46)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260437 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoSeparate the uses of NUM_DCHANS and MAX_CHANNELS into PRI, SS7, and MFCR2 users.
Richard Mudgett [Fri, 30 Apr 2010 22:24:28 +0000 (22:24 +0000)]
Separate the uses of NUM_DCHANS and MAX_CHANNELS into PRI, SS7, and MFCR2 users.

Created
SIG_PRI_MAX_CHANNELS, SIG_PRI_NUM_DCHANS
SIG_SS7_MAX_CHANNELS, SIG_SS7_NUM_DCHANS
SIG_MFCR2_MAX_CHANNELS

Also fixed the declaration of pollers[] in mfcr2_monitor().  It was
dimensioned to the number of bytes in struct dahdi_mfcr2.pvts[] and not to
the same dimension of the struct dahdi_mfcr2.pvts[].

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260435 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 260345 via svnmerge from
Mark Michelson [Fri, 30 Apr 2010 20:11:02 +0000 (20:11 +0000)]
Merged revisions 260345 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r260345 | mmichelson | 2010-04-30 15:08:15 -0500 (Fri, 30 Apr 2010) | 18 lines

  Fix potential crash from race condition due to accessing channel data without the channel locked.

  In res_musiconhold.c, there are several places where a channel's
  stream's existence is checked prior to calling ast_closestream on it. The issue
  here is that in several cases, the channel was not locked while checking the
  stream. The result was that if two threads checked the state of the channel's
  stream at approximately the same time, then there could be a situation where
  both threads attempt to call ast_closestream on the channel's stream. The result
  here is that the refcount for the stream would go below 0, resulting in a crash.

  I have added proper channel locking to res_musiconhold.c to ensure that
  we do not try to check chan->stream without the channel locked. A Digium customer
  has been using this patch for several weeks and has not had any crashes since
  applying the patch.

  ABE-2147
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260346 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix logic reversal error when queue callers join the queue.
Mark Michelson [Fri, 30 Apr 2010 19:53:36 +0000 (19:53 +0000)]
Fix logic reversal error when queue callers join the queue.

When a specific position is specified for the queue, the idea
was that the caller cannot be placed ahead of higher-priority
callers. Unfortunately, the logic was reversed so that the caller
could ONLY be placed ahead of higher priority callers.

Discovered while writing a unit test.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260344 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoDon't allow file descriptors to go above 64k, when we're closing them in a fork(2).
Tilghman Lesher [Fri, 30 Apr 2010 06:19:35 +0000 (06:19 +0000)]
Don't allow file descriptors to go above 64k, when we're closing them in a fork(2).

This saves time, when, even though the system allows the process limit to be
that high, the practical limit is much lower.  Also introduce an additional
optimization, in the form of using the CLOEXEC flag to close descriptors at
the right time.

(closes issue #17223)
 Reported by: dbackeberg
 Patches:
       20100423__issue17223.diff.txt uploaded by tilghman (license 14)
 Tested by: dbackeberg

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260292 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoLogic fixups for a sample FREENUM dialplan context.
Tilghman Lesher [Fri, 30 Apr 2010 05:23:56 +0000 (05:23 +0000)]
Logic fixups for a sample FREENUM dialplan context.

(closes issue #17263)
 Reported by: pprindeville
 Patches:
       freenum-dialplan.patch#3 uploaded by pprindeville (license 347)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260280 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 260195 via svnmerge from
Richard Mudgett [Thu, 29 Apr 2010 22:44:14 +0000 (22:44 +0000)]
Merged revisions 260195 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r260195 | rmudgett | 2010-04-29 17:11:47 -0500 (Thu, 29 Apr 2010) | 26 lines

  DTMF CallerID detection problems.

  The code handling DTMF CallerID drops digits on long CallerID numbers and
  may timeout waiting for the first ring with shorter numbers.

  The DTMF emulation mode was not turned off when processing DTMF CallerID.
  When the emulation code gets behind in processing the DTMF digits it can
  skip a digit.

  For shorter numbers, the timeout may have been too short.  I increased it
  from 2 seconds to 4 seconds.  Four seconds is a typical time between rings
  for many countries.

  (closes issue #16460)
  Reported by: sum
  Patches:
        issue16460.patch uploaded by rmudgett (license 664)
        issue16460_v1.6.2.patch uploaded by rmudgett (license 664)
  Tested by: sum, rmudgett

  Review: https://reviewboard.asterisk.org/r/634/

  JIRA SWP-562
  JIRA AST-334
  JIRA SWP-901
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260231 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoPattern match fail.
Tilghman Lesher [Thu, 29 Apr 2010 18:15:57 +0000 (18:15 +0000)]
Pattern match fail.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260148 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 260049 via svnmerge from
David Vossel [Thu, 29 Apr 2010 15:33:27 +0000 (15:33 +0000)]
Merged revisions 260049 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r260049 | dvossel | 2010-04-29 10:31:02 -0500 (Thu, 29 Apr 2010) | 14 lines

  Fixes crash in audiohook_write_list

  The middle_frame in the audiohook_write_list function was
  being freed if a audiohook manipulator returned a failure.
  This is incorrect logic.  This patch resolves this and
  adds detailed descriptions of how this function should work
  and why manipulator failures must be ignored.

  (closes issue #17052)
  Reported by: dvossel
  Tested by: dvossel

  (closes issue #16196)
  Reported by: atis

  Review: https://reviewboard.asterisk.org/r/623/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260050 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix comment.
Richard Mudgett [Thu, 29 Apr 2010 00:35:14 +0000 (00:35 +0000)]
Fix comment.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260007 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoDon't override peer context with domain context.
Mark Michelson [Wed, 28 Apr 2010 22:34:15 +0000 (22:34 +0000)]
Don't override peer context with domain context.

(closes issue #17040)
Reported by: pprindeville
Patches:
      asterisk-1.6-bugid17040.patch uploaded by pprindeville (license 347)
Tested by: pprindeville

Review: https://reviewboard.asterisk.org/r/565/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259957 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259858 via svnmerge from
David Vossel [Wed, 28 Apr 2010 21:20:03 +0000 (21:20 +0000)]
Merged revisions 259858 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259858 | dvossel | 2010-04-28 16:16:03 -0500 (Wed, 28 Apr 2010) | 33 lines

  resolves deadlocks in chan_local

  Issue_1.
  In the local_hangup() 3 locks must be held at the same time... pvt, pvt->chan,
  and pvt->owner.  Proper deadlock avoidance is done when the channel to hangup
  is the outbound chan_local channel, but when it is not the outbound channel we
  have an issue... We attempt to do deadlock avoidance only on the tech pvt, when
  both the tech pvt and the pvt->owner are locked coming into that loop.  By
  never giving up the pvt->owner channel deadlock avoidance is not entirely possible.
  This patch resolves that by doing deadlock avoidance on both the pvt->owner and the pvt
  when trying to get the pvt->chan lock.

  Issue_2.
  ast_prod() is used in ast_activate_generator() to queue a frame on the channel
  and make the channel's read function get called.  This function is used in
  ast_activate_generator() while the channel is locked, which mean's the channel
  will have a lock both from the generator code and the frame_queue code by the
  time it gets to chan_local.c's local_queue_frame code... local_queue_frame
  contains some of the same crazy deadlock avoidance that local_hangup requires,
  and this recursive lock prevents that deadlock avoidance from happening correctly.
  This patch removes ast_prod() from the channel lock so only one lock is held during
  the local_queue_frame function.

  (closes issue #17185)
  Reported by: schmoozecom
  Patches:
        issue_17185_v1.diff uploaded by dvossel (license 671)
        issue_17185_v2.diff uploaded by dvossel (license 671)
  Tested by: schmoozecom, GameGamer43

  Review: https://reviewboard.asterisk.org/r/631/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259870 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259852 via svnmerge from
Leif Madsen [Wed, 28 Apr 2010 21:08:34 +0000 (21:08 +0000)]
Merged revisions 259852 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259852 | lmadsen | 2010-04-28 16:07:48 -0500 (Wed, 28 Apr 2010) | 6 lines

  Update config.guess.

  Updating config.guess because after installing Ubuntu Server 9.10 and
  running all the update scripts, running ./configure would not continue
  because it was unable to determine what kind of system I had. After
  updating config.guess things started working again.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259853 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259847 via svnmerge from
Jason Parker [Wed, 28 Apr 2010 20:32:14 +0000 (20:32 +0000)]
Merged revisions 259847 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259847 | qwell | 2010-04-28 15:30:21 -0500 (Wed, 28 Apr 2010) | 1 line

  Add AC_CONFIG_AUX_DIR to configure script, so systems without install can use install-sh from our source dir.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259848 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259833 via svnmerge from
Jason Parker [Wed, 28 Apr 2010 20:26:35 +0000 (20:26 +0000)]
Merged revisions 259833 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259833 | qwell | 2010-04-28 15:25:36 -0500 (Wed, 28 Apr 2010) | 1 line

  Missed this when removing $ID
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259837 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259748 via svnmerge from
Jason Parker [Wed, 28 Apr 2010 19:19:54 +0000 (19:19 +0000)]
Merged revisions 259748 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259748 | qwell | 2010-04-28 14:17:38 -0500 (Wed, 28 Apr 2010) | 7 lines

  Remove usage of `id` since it isn't useful and was causing breakge.

  Solaris `id` doesn't support the -u argument.  Instead of figuring out how to
  fix this to work on Solaris, I decided to check why it was necessary and where
  else it was used.  It was only used in one place, and it hasn't been needed
  for a very long time (I question whether it was ever needed).
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259760 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259664 via svnmerge from
Jeff Peeler [Wed, 28 Apr 2010 17:18:43 +0000 (17:18 +0000)]
Merged revisions 259664 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259664 | jpeeler | 2010-04-28 12:13:29 -0500 (Wed, 28 Apr 2010) | 4 lines

  Do not play goodbye prompt after timeout of message review.

  ABE-2124
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259672 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix compile on systems without HAVE_NULLSAFE_PRINTF defined.
Jason Parker [Tue, 27 Apr 2010 22:47:36 +0000 (22:47 +0000)]
Fix compile on systems without HAVE_NULLSAFE_PRINTF defined.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259617 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBe more explicit about field naming in a test.
Jason Parker [Tue, 27 Apr 2010 22:28:16 +0000 (22:28 +0000)]
Be more explicit about field naming in a test.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259587 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259531 via svnmerge from
Richard Mudgett [Tue, 27 Apr 2010 22:18:09 +0000 (22:18 +0000)]
Merged revisions 259531 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259531 | rmudgett | 2010-04-27 16:53:07 -0500 (Tue, 27 Apr 2010) | 11 lines

  DAHDI "WARNING" message is confusing and vague

  "WARNING[28406]: chan_dahdi.c:6873 ss_thread: CallerID feed failed: Success"

  Changed the warning to "Failed to decode CallerID on channel 'name'".  The
  message before it is likely more specific about why the CallerID decode
  failed.

  SWP-501
  AST-283
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259538 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoShuffle some casts to make builds on bamboo happier.
Mark Michelson [Tue, 27 Apr 2010 22:11:58 +0000 (22:11 +0000)]
Shuffle some casts to make builds on bamboo happier.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259533 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259526 via svnmerge from
Leif Madsen [Tue, 27 Apr 2010 21:49:36 +0000 (21:49 +0000)]
Merged revisions 259526 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259526 | lmadsen | 2010-04-27 16:48:47 -0500 (Tue, 27 Apr 2010) | 15 lines

  Update sounds files.

  * Add additional sounds prompts for say_enumeration
  * Update the English conference sounds prompts so they are better
    quality and all sound more consistent
  * Clean up the core-sounds-XX.txt and extra-sounds-XX.txt files to
    include all present sound files

  Both core (en, fr, es) and extra (en, fr) sounds files have been updated.

  (closes issue #16200)
  Reported by: murf

  (closes issue #17137)
  Reported by: lmadsen
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259527 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBlock 259441 instead of recording it as merged.
Jason Parker [Tue, 27 Apr 2010 21:18:59 +0000 (21:18 +0000)]
Block 259441 instead of recording it as merged.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259451 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRecorded merge of revisions 259441 via svnmerge from
Jason Parker [Tue, 27 Apr 2010 21:17:01 +0000 (21:17 +0000)]
Recorded merge of revisions 259441 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259441 | qwell | 2010-04-27 16:15:46 -0500 (Tue, 27 Apr 2010) | 1 line

  Add gar to the check for AR for those silly OSes (Solaris) that don't have ar.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259442 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd gar to the check for AR for those silly OSes (Solaris) that don't have ar.
Jason Parker [Tue, 27 Apr 2010 21:13:01 +0000 (21:13 +0000)]
Add gar to the check for AR for those silly OSes (Solaris) that don't have ar.

autoconf2.13 couldn't handle AC_PROG_GREP, so I removed it.  This is fine,
since we don't need to use anything that the configure script doesn't.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259439 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate the Mantis Workflow document in doxygen.
Leif Madsen [Tue, 27 Apr 2010 21:10:32 +0000 (21:10 +0000)]
Update the Mantis Workflow document in doxygen.

(closes issue #17175)
Reported by: lmadsen
Patches:
      Bug_Tracker_Workflow.v2.txt uploaded by pabelanger (license 224)
Tested by: pabelanger, lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259438 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoChange cc_ref and cc_unref from macros to inline functions.
Mark Michelson [Tue, 27 Apr 2010 19:52:18 +0000 (19:52 +0000)]
Change cc_ref and cc_unref from macros to inline functions.

The hope is that Solaris won't be as whiny after this change.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259357 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259352 via svnmerge from
Jason Parker [Tue, 27 Apr 2010 19:31:55 +0000 (19:31 +0000)]
Merged revisions 259352 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259352 | qwell | 2010-04-27 14:29:26 -0500 (Tue, 27 Apr 2010) | 5 lines

  Support the silly OSes that don't have ar and strip.

  Since AC_PATH_TOOL is equiv to AC_CHECK_TOOL when path isn't specified, and
  AC_PATH_TOOLS doesn't exist, we'll just switch to AC_CHECK_TOOLS.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259353 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259270 via svnmerge from
Richard Mudgett [Tue, 27 Apr 2010 18:29:33 +0000 (18:29 +0000)]
Merged revisions 259270 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259270 | rmudgett | 2010-04-27 13:14:54 -0500 (Tue, 27 Apr 2010) | 14 lines

  hidecalleridname parameter in chan_dahdi.conf

  Issue #7321 implements a new chan_dahdi configuration option.  However, a
  change mentioned in the issue was never implemented.  This is the change
  that will allow the feature to work.

  I added a note to chan_dahdi.conf.sample about the feature.

  (closes issue #17143)
  Reported by: djensen99
  Patches:
        diff.txt uploaded by djensen99 (license NA) (One line change)
  Tested by: djensen99
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259307 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRe-fix dahdi_request() iflist locking since CCSS merged.
Richard Mudgett [Tue, 27 Apr 2010 16:52:29 +0000 (16:52 +0000)]
Re-fix dahdi_request() iflist locking since CCSS merged.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259229 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd missing file (pointed out by TheDavidFactor on #asterisk-dev) referenced by revis...
Tilghman Lesher [Tue, 27 Apr 2010 15:25:22 +0000 (15:25 +0000)]
Add missing file (pointed out by TheDavidFactor on #asterisk-dev) referenced by revision 239231.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259189 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259104 via svnmerge from
Mark Michelson [Mon, 26 Apr 2010 21:45:13 +0000 (21:45 +0000)]
Merged revisions 259104 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259104 | mmichelson | 2010-04-26 16:44:43 -0500 (Mon, 26 Apr 2010) | 3 lines

  Let compilation succeed warning-free when DONT_OPTIMIZE is turned off.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259105 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259018 via svnmerge from
Mark Michelson [Mon, 26 Apr 2010 21:13:35 +0000 (21:13 +0000)]
Merged revisions 259018 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259018 | mmichelson | 2010-04-26 16:03:08 -0500 (Mon, 26 Apr 2010) | 13 lines

  Prevent Newchannel manager events for dummy channels.

  No Newchannel manager event will be fired for channels that are
  allocated to not match a registered technology type. Thus bogus
  channels allocated solely for variable substitution or CDR
  operations do not result in a Newchannel event.

  (closes issue #16957)
  Reported by: atis

  Review: https://reviewboard.asterisk.org/r/601
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259023 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoLine 24 missed in compatibility fix in revision 233577
David Ruggles [Mon, 26 Apr 2010 19:05:47 +0000 (19:05 +0000)]
Line 24 missed in compatibility fix in revision 233577

added a "fun:" prefix line 24

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258974 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoSmall error in the T.140 RTP port verbose log.
Leif Madsen [Mon, 26 Apr 2010 15:59:34 +0000 (15:59 +0000)]
Small error in the T.140 RTP port verbose log.

(closes issue #16988)
Reported by: frawd
Patches:
      chan_sip_sdp_verbose_fix.diff uploaded by frawd (license 610)
Tested by: russell

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258934 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate res_fax and res_fax_spandsp to be compatible with Fax For Asterisk 1.2.
Matthew Nicholson [Mon, 26 Apr 2010 14:18:15 +0000 (14:18 +0000)]
Update res_fax and res_fax_spandsp to be compatible with Fax For Asterisk 1.2.

The fax session initilization code for T.38 faxes has been rewritten. T.38 session initialization was removed from generic_fax_exec, and split into two different code paths for receive and send.  Also the 'z' option (to send a T.38 reinvite if we do not receive one) was added to sendfax.

In the output of 'fax show sessions', the 'Type' column has been renamed to 'Tech' and replaced with a new 'Tech' column that will report 'G.711' or 'T.38'.

Control of ECM defaults has been added to res_fax

A 'fax show settings' CLI command has been added.

Support of the new AST_T38_REQUEST_PARMS control method request to handle channels that have already received a T.38 reinvite before the FAX application is start has been added.

Support for the 'fax show settings' command has been added to res_fax_spandsp and handling of the ECM flag has been slightly altered.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258896 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoadditional checking related to issue 17186
Alexandr Anikin [Sun, 25 Apr 2010 18:51:37 +0000 (18:51 +0000)]
additional checking related to issue 17186

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258855 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoDon't pass zero length callerid to ooh323 stack
Alexandr Anikin [Sun, 25 Apr 2010 18:34:29 +0000 (18:34 +0000)]
Don't pass zero length callerid to ooh323 stack

Don't pass zero callerid string to ooh323 stack because it can't encode this properly and
can't generate setup message.

(closes issue #17186)
Reported by: vmikhelson
Patches:
      zero_callerid_num.patch uploaded by may213 (license 454)
Tested by: may213

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258838 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 258775 via svnmerge from
Tilghman Lesher [Sun, 25 Apr 2010 18:12:14 +0000 (18:12 +0000)]
Merged revisions 258775 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r258775 | tilghman | 2010-04-25 13:09:05 -0500 (Sun, 25 Apr 2010) | 6 lines

  When StopMonitor is called, ensure that it will not be restarted by a channel event.
  (closes issue #16590)
   Reported by: kkm
   Patches:
         resmonitor-16590-trunk.239289.diff uploaded by kkm (license 888)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258776 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd another random function that does nothing to make the utils/ dir happy.
Jason Parker [Thu, 22 Apr 2010 22:19:34 +0000 (22:19 +0000)]
Add another random function that does nothing to make the utils/ dir happy.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258685 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix previous commit.
Matthew Nicholson [Thu, 22 Apr 2010 22:11:23 +0000 (22:11 +0000)]
Fix previous commit.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258675 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMake utils/ stuff *actually* compile this time.
Jason Parker [Thu, 22 Apr 2010 22:10:17 +0000 (22:10 +0000)]
Make utils/ stuff *actually* compile this time.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258674 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoLet utils/ dir compile when DEBUG_THREADS is not enabled.
Jason Parker [Thu, 22 Apr 2010 22:02:22 +0000 (22:02 +0000)]
Let utils/ dir compile when DEBUG_THREADS is not enabled.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258673 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 193391,258670 via svnmerge from
Matthew Nicholson [Thu, 22 Apr 2010 21:57:59 +0000 (21:57 +0000)]
Merged revisions 193391,258670 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r193391 | mnicholson | 2009-05-08 16:01:25 -0500 (Fri, 08 May 2009) | 8 lines

  Set the proper disposition on originated calls.

  (closes issue #14167)
  Reported by: jpt
  Patches:
        call-file-missing-cdr2.diff uploaded by mnicholson (license 96)
  Tested by: dlotina, rmartinez, mnicholson
........
  r258670 | mnicholson | 2010-04-22 16:49:07 -0500 (Thu, 22 Apr 2010) | 11 lines

  Fix broken CDR behavior.

  This change allows a CDR record previously marked with disposition ANSWERED to be set as BUSY or NO ANSWER.

  Additionally this change partially reverts r235635 and does not set the AST_CDR_FLAG_ORIGINATED flag on CDRs generated from ast_call().  To preserve proper CDR behavior, the AST_CDR_FLAG_DIALED flag is now cleared from all brige CDRs in ast_bridge_call().

  (closes issue #16797)
  Reported by: VarnishedOtter
  Tested by: mnicholson
........

(closes issue #16222)
Reported by: telles
Tested by: mnicholson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258671 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd ast_event subscription unit test and fix some ast_event API bugs.
Russell Bryant [Thu, 22 Apr 2010 21:06:53 +0000 (21:06 +0000)]
Add ast_event subscription unit test and fix some ast_event API bugs.

This patch introduces another test in test_event.c that exercises most of the
subscription related ast_event API calls.  I made some minor additions to the
existing event allocation test to increase API coverage by the test code.
Finally, I made a list in a comment of API calls not yet touched by the test
module as a to-do list for future test development.

During the development of this test code, I discovered a number of bugs in
the event API.

1) subscriptions to AST_EVENT_ALL were not handled appropriately in a couple
   of different places.  The API allows a subscription to all event types,
   but with IE parameters, just as if it was a subscription to a specific
   event type.  However, the parameters were being ignored.  This affected
   ast_event_check_subscriber() and event distribution to subscribers.

2) Some of the logic in ast_event_check_subscriber() for checking subscriptions
   against query parameters was wrong.

Review: https://reviewboard.asterisk.org/r/617/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258632 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoPass interactive = 0 and fix a compile error.
Eliel C. Sardanons [Thu, 22 Apr 2010 20:04:23 +0000 (20:04 +0000)]
Pass interactive = 0 and fix a compile error.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258595 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRemove ABI differences that occured when compiling with DEBUG_THREADS.
Jason Parker [Thu, 22 Apr 2010 19:08:01 +0000 (19:08 +0000)]
Remove ABI differences that occured when compiling with DEBUG_THREADS.

"Bad Things" would happen if Asterisk was compiled with DEBUG_THREADS, but a
loaded module was not (or vice versa).  This also immensely simplifies the
lock code, since there are no longer 2 separate versions of them.

Review: https://reviewboard.asterisk.org/r/508/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258557 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAsterisk data retrieval API.
Eliel C. Sardanons [Thu, 22 Apr 2010 18:07:02 +0000 (18:07 +0000)]
Asterisk data retrieval API.

This module implements an abstraction for retrieving and exporting
asterisk data.
Developed by:
Brett Bryant <brettbryant@gmail.com>
Eliel C. Sardanons (LU1ALY) <eliels@gmail.com>
For the Google Summer of code 2009 Project.
Documentation can be found in doxygen format and inside the
header include/asterisk/data.h

Review: https://reviewboard.asterisk.org/r/275/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258517 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd MEETMEBOOKID from r256019.
Russell Bryant [Thu, 22 Apr 2010 17:36:34 +0000 (17:36 +0000)]
Add MEETMEBOOKID from r256019.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258515 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 258432 via svnmerge from
Jeff Peeler [Wed, 21 Apr 2010 21:56:09 +0000 (21:56 +0000)]
Merged revisions 258432 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r258432 | jpeeler | 2010-04-21 16:45:36 -0500 (Wed, 21 Apr 2010) | 8 lines

  Fix looping forever when no input received in certain voicemail menu scenarios.

  Specifically, prompting for an extension (when leaving or forwarding a message)
  or when prompting for a digit (when saving a message or changing folders).

  ABE-2122
  SWP-1268
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258433 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMissed this when reverting the bad version change in asterisk.tex.
Leif Madsen [Wed, 21 Apr 2010 19:45:33 +0000 (19:45 +0000)]
Missed this when reverting the bad version change in asterisk.tex.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258387 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix change in asterisk.tex that got merged in after testing.
Leif Madsen [Wed, 21 Apr 2010 19:27:41 +0000 (19:27 +0000)]
Fix change in asterisk.tex that got merged in after testing.

(issue #17220)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258383 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd ability to generate ASCII documentation from the TeX files.
Leif Madsen [Wed, 21 Apr 2010 19:18:35 +0000 (19:18 +0000)]
Add ability to generate ASCII documentation from the TeX files.

These changes add the ability to run 'make asterisk.txt' just like the existing
'make asterisk.pdf' commands to generate a text document from the TeX files we
have in the doc/tex/ directory. I've also updated a few of the .tex files because
they weren't properly escaping certain characters so they would show up as Unicode
characters (like [U+021C]). Made changes to the configure scripts so it would
detect the catdvi program which is required to convert the .dvi file generated
by latex.

I've also added a few lines to the build_tools/prep_tarball script so that the
text documentation gets generated and added to future tarballs of Asterisk
releases.

(closes issue #17220)
Reported by: lmadsen
Patches:
      asterisk.txt.patch uploaded by lmadsen (license 10)
      asterisk.txt.patch-v4 uploaded by pabelanger (license 224)
Tested by: lmadsen, pabelanger

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258351 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd small documentation update to func_callcompletion.c.
Mark Michelson [Wed, 21 Apr 2010 19:07:25 +0000 (19:07 +0000)]
Add small documentation update to func_callcompletion.c.

This directs users to documents which can help explain the
concepts and configuration options settable with the function.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258345 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoIAXpeers output now matches SIPpeers format for manager (AMI).
Leif Madsen [Wed, 21 Apr 2010 19:02:45 +0000 (19:02 +0000)]
IAXpeers output now matches SIPpeers format for manager (AMI).

(closes issue #17100)
Reported by: secesh
Tested by: pabelanger

Review: https://reviewboard.asterisk.org/r/594/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258344 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes issue with double "sip:" in header field
David Vossel [Wed, 21 Apr 2010 18:13:36 +0000 (18:13 +0000)]
fixes issue with double "sip:" in header field

This is a clear mistake in logic.  Future discussions
about how to avoid having to handle uri's like this
should take place in the future, but this fix needs
to go in for now.

(closes issue #15847)
Reported by: ebroad
Patches:
      doublesip.patch uploaded by ebroad (license 878)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258305 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix the \brief description in the res_calendar_*.c files.
Leif Madsen [Wed, 21 Apr 2010 13:26:28 +0000 (13:26 +0000)]
Fix the \brief description in the res_calendar_*.c files.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258265 65c4cc65-6c06-0410-ace0-fbb531ad65f3