asterisk/asterisk.git
23 months agoLoader: Remove unneeded load_pri declarations.
Corey Farrell [Mon, 20 Nov 2017 18:54:38 +0000 (13:54 -0500)]
Loader: Remove unneeded load_pri declarations.

Instead of specifying AST_MODFLAG_LOAD_ORDER with load_pri
AST_MODPRI_DEFAULT just use AST_MODFLAG_DEFAULT.

Change-Id: I0123258eafce324249433a69df15a85cc16e509f

23 months agoMerge "res_snmp: Declare RONLY if net-snmp headers do not."
Joshua Colp [Mon, 20 Nov 2017 18:13:01 +0000 (12:13 -0600)]
Merge "res_snmp: Declare RONLY if net-snmp headers do not."

23 months agoMerge "iostream: Fix ast_iostream_printf declaration."
Joshua Colp [Mon, 20 Nov 2017 17:54:06 +0000 (11:54 -0600)]
Merge "iostream: Fix ast_iostream_printf declaration."

23 months agoMerge "tests: Fix warnings found on Mac."
Joshua Colp [Mon, 20 Nov 2017 17:32:51 +0000 (11:32 -0600)]
Merge "tests: Fix warnings found on Mac."

23 months agoMerge "app_minivm: Fix possible uninitialized return value."
Joshua Colp [Mon, 20 Nov 2017 16:39:16 +0000 (10:39 -0600)]
Merge "app_minivm: Fix possible uninitialized return value."

23 months agoMerge "res_pjsip: Fix warning by deferring implicit type cast."
Joshua Colp [Mon, 20 Nov 2017 15:44:12 +0000 (09:44 -0600)]
Merge "res_pjsip: Fix warning by deferring implicit type cast."

23 months agores_pjsip: Fix warning by deferring implicit type cast.
Corey Farrell [Sun, 19 Nov 2017 19:28:41 +0000 (14:28 -0500)]
res_pjsip: Fix warning by deferring implicit type cast.

Mac doesn't like the comparison of -1 to an enum, so store the result of
ast_sip_str_to_dtmf to an int so we can check for the negative return
value.  ast_sip_str_to_dtmf returns an int so this is only delaying the
implicit type cast.

Change-Id: I0c262c1719ee951aae1f437d733a301cf5f8ad29

2 years agotests: Fix warnings found on Mac.
Corey Farrell [Sun, 19 Nov 2017 03:13:32 +0000 (22:13 -0500)]
tests: Fix warnings found on Mac.

test_pbx used raise without explicitly including signal.h.  On Mac for
some reason nothing else includes it.

test_logger checked if an unsigned int was negative.  Switch the
variable to 'int' so that error check can be effective.

Change-Id: Ie1db5dd1818ac25cc2ae41b644f848b5865b1362

2 years agores_snmp: Declare RONLY if net-snmp headers do not.
Corey Farrell [Sun, 19 Nov 2017 02:25:50 +0000 (21:25 -0500)]
res_snmp: Declare RONLY if net-snmp headers do not.

Some net-snmp builds do not provide the RONLY declare, only
NETSNMP_OLDAPI_RONLY.  Map RONLY to NETSNMP_OLDAPI_RONLY to get around
this error.

Change-Id: Ida5c7ad9406515825485c4d3b4a34fd6ad0da577

2 years agoiostream: Fix ast_iostream_printf declaration.
Corey Farrell [Sun, 19 Nov 2017 01:50:48 +0000 (20:50 -0500)]
iostream: Fix ast_iostream_printf declaration.

This adds the printf attribute and changes 'fmt' from 'const void *' to
'const char *'.  This resolves a warning from some compiler for
vsnprintf needing a literal string for format.

Change-Id: I71c33a8262590042ee451e1146760c10bb22fb78

2 years agoapp_minivm: Fix possible uninitialized return value.
Corey Farrell [Sun, 19 Nov 2017 01:29:16 +0000 (20:29 -0500)]
app_minivm: Fix possible uninitialized return value.

Declare 'res' initialized to -1 to deal with earlier error paths that
could cause 'res' to be returned uninitialized.

Change-Id: I8ac2a5755bf4174d89ef893e924c940f702b104e

2 years agores_pjsip: Use reasonable buffer lengths for endpoint identification
Sean Bright [Fri, 17 Nov 2017 15:57:54 +0000 (10:57 -0500)]
res_pjsip: Use reasonable buffer lengths for endpoint identification

Domains themselves can be up to 255 characters long (per RFC 1035), so
our current buffer sizes are wholly inadequate for many use cases.

Change-Id: If3f30a68307f1365a1fe06bc4b854c62842c9292

2 years agoMerge "DEBUG_FD_LEAKS: Add missing FD creators."
Joshua Colp [Fri, 17 Nov 2017 15:26:48 +0000 (09:26 -0600)]
Merge "DEBUG_FD_LEAKS: Add missing FD creators."

2 years agoMerge "Build: Make function constructor/destructor attributes mandatory."
Joshua Colp [Fri, 17 Nov 2017 15:26:33 +0000 (09:26 -0600)]
Merge "Build: Make function constructor/destructor attributes mandatory."

2 years agoMerge "aoc: Fix memory management issues."
Jenkins2 [Fri, 17 Nov 2017 12:43:17 +0000 (06:43 -0600)]
Merge "aoc: Fix memory management issues."

2 years agoaoc: Fix memory management issues.
Corey Farrell [Fri, 17 Nov 2017 01:39:20 +0000 (20:39 -0500)]
aoc: Fix memory management issues.

aoc_publish_blob failed to check for msg allocation error and never
released msg.

Change-Id: Ib31a9ffb81056a0d496a49d7eec795005a44bcd5

2 years agores_pjsip_transport_websocket: Give transport a meaningful description
Sean Bright [Thu, 16 Nov 2017 22:18:16 +0000 (17:18 -0500)]
res_pjsip_transport_websocket: Give transport a meaningful description

We were not \0 terminating this string, so any attempt to print it would
in the best case show an empty string and in the worst case potentially
crash.

Change-Id: I63d96ef8f7516ac02a0f91e22dfa8acdc615042c

2 years agoMerge "ast_coredumper: Add ability to use directory other than /tmp"
Joshua Colp [Thu, 16 Nov 2017 21:44:23 +0000 (15:44 -0600)]
Merge "ast_coredumper:  Add ability to use directory other than /tmp"

2 years agoMerge "pjsip / hep: Provide correct local address for Websockets."
Joshua Colp [Thu, 16 Nov 2017 17:53:53 +0000 (11:53 -0600)]
Merge "pjsip / hep: Provide correct local address for Websockets."

2 years agoMerge "sorcery: Add ast_sorcery_retrieve_by_prefix()"
Jenkins2 [Thu, 16 Nov 2017 16:27:00 +0000 (10:27 -0600)]
Merge "sorcery: Add ast_sorcery_retrieve_by_prefix()"

2 years agoMerge "chan_pjsip.c: Improve answer failure log messages."
Joshua Colp [Thu, 16 Nov 2017 16:11:32 +0000 (10:11 -0600)]
Merge "chan_pjsip.c: Improve answer failure log messages."

2 years agoThis patch adds a beanstalk CEL backend.
Nir Simionovich [Thu, 19 Oct 2017 19:44:16 +0000 (15:44 -0400)]
This patch adds a beanstalk CEL backend.

Beanstalkd is a simple to use job queue. It provides a means to
create multiple job queues called "tubes". Each tube can store
multiple jobs, with varying priorities with the queue. Queue
processing is available via a simple TCP socket or via well defined
libraries, avaialble at
https://github.com/kr/beanstalkd/wiki/client-libraries

This module is based upon the beanstalk-client library, available
for download at: https://github.com/deepfryed/beanstalk-client

This module currently doesn't support user defined events.

Change-Id: Ic3a087faeeac045d69a2a018e60e29831ddb95ab

2 years agoMerge "This patch adds a beanstalk CDR backend."
Jenkins2 [Thu, 16 Nov 2017 15:36:40 +0000 (09:36 -0600)]
Merge "This patch adds a beanstalk CDR backend."

2 years agoMerge "audiohook.c: Fix freeing a frame and still using it."
Joshua Colp [Thu, 16 Nov 2017 14:27:04 +0000 (08:27 -0600)]
Merge "audiohook.c: Fix freeing a frame and still using it."

2 years agochan_pjsip.c: Improve answer failure log messages.
Richard Mudgett [Fri, 10 Nov 2017 01:58:12 +0000 (19:58 -0600)]
chan_pjsip.c: Improve answer failure log messages.

* Balanced the session->inv_session refs on answer failure.

Change-Id: I33542d639d37e692cb46550b972a5fcfc3b804b8

2 years agoaudiohook.c: Fix freeing a frame and still using it.
Richard Mudgett [Wed, 15 Nov 2017 00:00:55 +0000 (18:00 -0600)]
audiohook.c: Fix freeing a frame and still using it.

Memory corruption happened to the media frame caches when an audio hook
freed a frame when it shouldn't.  I think the freed frame was because a
jitter buffer interpolated a missing frame and the audio hook
unconditionally freed it.

* Made audiohook.c:audio_audiohook_write_list() not free an interpolated
frame if it is the same frame as what was passed into the routine.

* Made plc.c:normalise_history() use memmove() instead of memcpy() on a
memory block that could overlap.  Found by valgrind investigating this
issue.

ASTERISK-27238
ASTERISK-27412

Change-Id: I548d86894281fc4529aefeb9f161f2131ecc6fde

2 years agoapp_record: Don't set RECORD_STATUS chan var until file is closed
George Joseph [Wed, 15 Nov 2017 18:10:16 +0000 (11:10 -0700)]
app_record:  Don't set RECORD_STATUS chan var until file is closed

We've been calling pbx_builtin_setvar_helper to set the
RECORD_STATUS variable before actually closing the recorded file.
If a client is watching VarSet events and tries to do something with
the file when a RECORD_STATUS event is seen, they might attempt to
do so while the file it's still open.

We now delay calling pbx_builtin_setvar_helper until after we close
the file.

ASTERISK-27423

Change-Id: I7fe9de99953e46b4bafa2b38cf151fe8f6488254

2 years agoast_coredumper: Add ability to use directory other than /tmp
George Joseph [Tue, 7 Nov 2017 14:25:59 +0000 (07:25 -0700)]
ast_coredumper:  Add ability to use directory other than /tmp

The OUTPUTDIR environment variable can now be set either in the
environment itself or in ast_debug_tools.conf.  If set, it's used
for all work products instead of /tmp.

Also added the --tarball-config option that includes the contents
of /etc/asterisk when either --tarball-coredumps or --tarball-results
are used.

Change-Id: I66b2553319df61caea5b313d084f51978f730b4c

2 years agoMerge "bundled_pjproject: Update to 2.7.1"
Jenkins2 [Tue, 14 Nov 2017 22:03:57 +0000 (16:03 -0600)]
Merge "bundled_pjproject: Update to 2.7.1"

2 years agoMerge "bundled_pjproject: sip_parser: Fix return code in pjsip_find_msg"
Joshua Colp [Tue, 14 Nov 2017 20:49:05 +0000 (14:49 -0600)]
Merge "bundled_pjproject: sip_parser:  Fix return code in pjsip_find_msg"

2 years agopjsip / hep: Provide correct local address for Websockets.
Joshua Colp [Mon, 13 Nov 2017 13:14:23 +0000 (13:14 +0000)]
pjsip / hep: Provide correct local address for Websockets.

Previously for PJSIP the local address of WebSocket connections
was set to the remote address. For logging purposes this is
not particularly useful.

The WebSocket API has been extended to allow the local
address to be queried and this is used in PJSIP to set the
local address to the correct value.

The PJSIP HEP support has also been tweaked so that reliable
transports always use the local address on the transport
and do not try to (wrongly) guess. As they are connection
based it is impossible for the source to be anything else.

ASTERISK-26758
ASTERISK-27363

Change-Id: Icd305fd038ad755e2682ab2786e381f6bf29e8ca

2 years agoMerge "core: Fix configuration of remote console socket path."
Joshua Colp [Tue, 14 Nov 2017 16:31:40 +0000 (10:31 -0600)]
Merge "core: Fix configuration of remote console socket path."

2 years agoMerge "pjsip: Add patch to allow all transports to be destroyed."
Jenkins2 [Tue, 14 Nov 2017 15:06:33 +0000 (09:06 -0600)]
Merge "pjsip: Add patch to allow all transports to be destroyed."

2 years agoMerge "core: Use ast_alertpipe for Asterisk signal monitoring thread."
Joshua Colp [Tue, 14 Nov 2017 13:32:24 +0000 (07:32 -0600)]
Merge "core: Use ast_alertpipe for Asterisk signal monitoring thread."

2 years agoMerge "core: Add cache_media_frames debugging option."
Jenkins2 [Tue, 14 Nov 2017 12:56:54 +0000 (06:56 -0600)]
Merge "core: Add cache_media_frames debugging option."

2 years agoMerge "alertpipe: Correct documented return of ast_alertpipe_write."
Joshua Colp [Tue, 14 Nov 2017 11:46:58 +0000 (05:46 -0600)]
Merge "alertpipe: Correct documented return of ast_alertpipe_write."

2 years agoalertpipe: Correct documented return of ast_alertpipe_write.
Corey Farrell [Mon, 13 Nov 2017 23:47:46 +0000 (18:47 -0500)]
alertpipe: Correct documented return of ast_alertpipe_write.

Change-Id: I4ea49c441890a81384144479dc93ab5a3989486d

2 years agoMerge "vectors: Add new macro and a string vector definition."
Jenkins2 [Mon, 13 Nov 2017 23:26:22 +0000 (17:26 -0600)]
Merge "vectors: Add new macro and a string vector definition."

2 years agoMerge "menuselect: Delete and ignore aclocal.m4."
Joshua Colp [Mon, 13 Nov 2017 23:01:35 +0000 (17:01 -0600)]
Merge "menuselect: Delete and ignore aclocal.m4."

2 years agocore: Use ast_alertpipe for Asterisk signal monitoring thread.
Corey Farrell [Fri, 10 Nov 2017 01:47:27 +0000 (20:47 -0500)]
core: Use ast_alertpipe for Asterisk signal monitoring thread.

Reduce the signal monitoring thread file descriptor use from two to one
on systems that support eventfd.

Change-Id: Id4041a237d481ff699639e153ea6982fee14a462

2 years agocore: Fix configuration of remote console socket path.
Corey Farrell [Mon, 13 Nov 2017 22:20:27 +0000 (17:20 -0500)]
core: Fix configuration of remote console socket path.

The remote console socket path is the combination of asterisk.conf
settings astrundir from [directories] and astctl from [files].
Unconditionally combine the two strings after processing all values
to ensure we end up with the correct socket path.

ASTERISK-27415

Change-Id: Ib1e2805d55d6b0955c6430a1a2a93acbf9b091e8

2 years agobundled_pjproject: sip_parser: Fix return code in pjsip_find_msg
George Joseph [Fri, 10 Nov 2017 16:37:16 +0000 (09:37 -0700)]
bundled_pjproject: sip_parser:  Fix return code in pjsip_find_msg

The default return code for pjsip_find_msg was PJ_SUCCESS so if
a Content-Length header wasn't found at all, pjsip_find_msg was
returning PJ_SUCCESS instead of PJSIP_EMISSINGHDR.

Also added the volatile keyword to a few variables that are used
both inside and outside the PJ_TRY/PJ_CATCH block.

Partial fix for ASTERISK_27408

Change-Id: If82ba9de921e3d57df9c68cf96ee45ccc1491f7a

2 years agobundled_pjproject: Update to 2.7.1
Ben Ford [Mon, 13 Nov 2017 20:35:14 +0000 (14:35 -0600)]
bundled_pjproject: Update to 2.7.1

Update from 2.7 to 2.7.1 for bundled pjproject. Changed version
and removed patch files included in the update.

Change-Id: I55cea8e734b318c2df9daf86aa0802c559ec8357

2 years agosorcery: Add ast_sorcery_retrieve_by_prefix()
Sean Bright [Thu, 9 Nov 2017 14:21:38 +0000 (09:21 -0500)]
sorcery: Add ast_sorcery_retrieve_by_prefix()

Some consumers of the sorcery API use ast_sorcery_retrieve_by_regex
only so that they can anchor the potential match as a prefix and not
because they truly need regular expressions.

Rather than using regular expressions for simple prefix lookups, add
a new operation - ast_sorcery_retrieve_by_prefix - that does them.

Change-Id: I56f4e20ba1154bd52281f995c27a429a854f6a79

2 years agovectors: Add new macro and a string vector definition.
Corey Farrell [Tue, 7 Nov 2017 20:00:33 +0000 (15:00 -0500)]
vectors: Add new macro and a string vector definition.

* AST_VECTOR_STEAL_ELEMENTS - steal the array of elements for use
  with non-vector code.
* struct ast_vector_string - a vector of 'char *'.

Change-Id: I104d1b204be03fccf67e02a195596adcb5ab1e42

2 years agoMerge "Build System: Disable parallel make in the root Makefile."
Joshua Colp [Mon, 13 Nov 2017 13:47:38 +0000 (07:47 -0600)]
Merge "Build System: Disable parallel make in the root Makefile."

2 years agoMerge "res_pjsip_pubsub: Ensure remote URI contains URI only."
Jenkins2 [Mon, 13 Nov 2017 13:11:57 +0000 (07:11 -0600)]
Merge "res_pjsip_pubsub: Ensure remote URI contains URI only."

2 years agocore: Add cache_media_frames debugging option.
Richard Mudgett [Sat, 11 Nov 2017 19:01:47 +0000 (13:01 -0600)]
core: Add cache_media_frames debugging option.

The media frame cache gets in the way of finding use after free errors of
media frames.  Tools like valgrind and MALLOC_DEBUG don't know when a
frame is released because it gets put into the cache instead of being
freed.

* Added the "cache_media_frames" option to asterisk.conf.  Disabling the
option helps track down media frame mismanagement when using valgrind or
MALLOC_DEBUG.  The cache gets in the way of determining if the frame is
used after free and who freed it.  NOTE: This option has no effect when
Asterisk is compiled with the LOW_MEMORY compile time option enabled
because the cache code does not exist.

To disable the media frame cache simply disable the cache_media_frames
option in asterisk.conf and restart Asterisk.

Sample asterisk.conf setting:
[options]
cache_media_frames=no

ASTERISK-27413

Change-Id: I0ab2ce0f4547cccf2eb214901835c2d951b78c00

2 years agoframe.c: Make ast_frame_free()/ast_frfree() NULL tolerant
Richard Mudgett [Sat, 11 Nov 2017 15:42:01 +0000 (09:42 -0600)]
frame.c: Make ast_frame_free()/ast_frfree() NULL tolerant

Change-Id: Ic49d821ef88ada38a31bdd835b9531443c55d793

2 years agomenuselect: Delete and ignore aclocal.m4.
Corey Farrell [Sat, 11 Nov 2017 04:04:53 +0000 (23:04 -0500)]
menuselect: Delete and ignore aclocal.m4.

This file is temporary output from the bootstrap.sh command, it does not
need to be committed.

Change-Id: Ie0fd113aff6eac44924c0bd0c900833c6c86a6d9

2 years agoBuild: Make function constructor/destructor attributes mandatory.
Corey Farrell [Tue, 31 Oct 2017 03:09:17 +0000 (23:09 -0400)]
Build: Make function constructor/destructor attributes mandatory.

This change causes the configure script to fail if the C compiler does
not support both function attributes constructor and destructor.  These
were already required as modules cannot function without these attributes
and Asterisk requires modules.

This also has AST_GCC_ATTRIBUTE set a variable
ax_cv_have_func_attribute_$1.  This is the same variable name used by
autoconf-archive's AX_GCC_FUNC_ATTRIBUTE, used for the same purpose.

Change-Id: Id68e8a1447f2a6d707c54b56350e7bfdb33fb663

2 years agoMerge "core: Remove disabled code."
Joshua Colp [Fri, 10 Nov 2017 14:00:32 +0000 (08:00 -0600)]
Merge "core: Remove disabled code."

2 years agoMerge "chan_pjsip.c: Fix uninitialized cause value on failure."
Joshua Colp [Fri, 10 Nov 2017 14:00:12 +0000 (08:00 -0600)]
Merge "chan_pjsip.c: Fix uninitialized cause value on failure."

2 years agopjsip: Add patch to allow all transports to be destroyed.
Joshua Colp [Fri, 10 Nov 2017 13:06:38 +0000 (13:06 +0000)]
pjsip: Add patch to allow all transports to be destroyed.

If a transport is created with the same transport type, source
IP address, and source port as one that already exists the old
transport is moved into a linked list called "tp_list".

If this old transport is later shutdown it will not be destroyed
as the process checks whether the transport is valid or not. This
check does not look at the "tp_list" when making the determination
causing the transport to not be destroyed.

This change updates the logic to query not just the main storage
method for transports but also the "tp_list".

Upstream issue https://trac.pjsip.org/repos/ticket/2061

ASTERISK-27411

Change-Id: Ic5c2bb60226df0ef1c8851359ed8d4cd64469429

2 years agocore: Remove disabled code.
Corey Farrell [Fri, 10 Nov 2017 02:34:32 +0000 (21:34 -0500)]
core: Remove disabled code.

handle_quit has been disabled since 2003, remove it.

Change-Id: Idc3aaa6c81676160547078f9b71e8aa43de2db18

2 years agoMerge "stasis_bridges.c: Fix off-nominal json memory leaks."
Joshua Colp [Fri, 10 Nov 2017 00:05:09 +0000 (18:05 -0600)]
Merge "stasis_bridges.c: Fix off-nominal json memory leaks."

2 years agoBuild System: Disable parallel make in the root Makefile.
Corey Farrell [Thu, 9 Nov 2017 19:24:46 +0000 (14:24 -0500)]
Build System: Disable parallel make in the root Makefile.

This ensures that the root Makefile runs only a single target at a time.
SUBMAKE will still honor requested parallelism, so 'make -j8' will build
one directory at a time but allow 8 jobs at once when building a sub
directory.

This will fix some display glitches related to rebuild of XML
documentation.  It will also prevent some edge case errors where
bundled pjproject needs to be rebuild before other parts of Asterisk.

Change-Id: I4f2ec6fbbec1ada0ccb1109a28ea303524239b1e

2 years agoMerge "res_pjsip_registrar.c: Fix AOR and pjproject group deadlock."
Kevin Harwell [Thu, 9 Nov 2017 17:48:34 +0000 (11:48 -0600)]
Merge "res_pjsip_registrar.c: Fix AOR and pjproject group deadlock."

2 years agochan_pjsip.c: Fix uninitialized cause value on failure.
Richard Mudgett [Thu, 30 Mar 2017 01:46:56 +0000 (20:46 -0500)]
chan_pjsip.c: Fix uninitialized cause value on failure.

Change-Id: I3f9dd3c31bd582e54a30381500077de2319d8cc3

2 years agoMerge "res_pjsip_pubsub: Fix multiple leaks on failure to append vectors."
Joshua Colp [Thu, 9 Nov 2017 09:44:56 +0000 (03:44 -0600)]
Merge "res_pjsip_pubsub: Fix multiple leaks on failure to append vectors."

2 years agoMerge "res_pjsip_history: Fix multiple leaks on vector append failure."
Joshua Colp [Thu, 9 Nov 2017 09:44:37 +0000 (03:44 -0600)]
Merge "res_pjsip_history: Fix multiple leaks on vector append failure."

2 years agoMerge "res_pjsip_session: Fix multiple leaks."
Joshua Colp [Thu, 9 Nov 2017 09:43:58 +0000 (03:43 -0600)]
Merge "res_pjsip_session: Fix multiple leaks."

2 years agoMerge "main/sdp_state: Check for errors from ast_stream_topology_set_stream."
Joshua Colp [Thu, 9 Nov 2017 09:43:35 +0000 (03:43 -0600)]
Merge "main/sdp_state: Check for errors from ast_stream_topology_set_stream."

2 years agoMerge "bridge_softmix: Note why ast_stream_topology_set_stream cannot fail."
Joshua Colp [Thu, 9 Nov 2017 09:42:51 +0000 (03:42 -0600)]
Merge "bridge_softmix: Note why ast_stream_topology_set_stream cannot fail."

2 years agoMerge "res_pjsip_session: Check for errors from ast_stream_topology_set_stream."
Joshua Colp [Thu, 9 Nov 2017 09:42:34 +0000 (03:42 -0600)]
Merge "res_pjsip_session: Check for errors from ast_stream_topology_set_stream."

2 years agoMerge "res_pjsip_t38: Better error checking for t38_create_media_state."
Joshua Colp [Wed, 8 Nov 2017 19:11:27 +0000 (13:11 -0600)]
Merge "res_pjsip_t38: Better error checking for t38_create_media_state."

2 years agoDEBUG_FD_LEAKS: Add missing FD creators.
Corey Farrell [Wed, 8 Nov 2017 07:40:22 +0000 (02:40 -0500)]
DEBUG_FD_LEAKS: Add missing FD creators.

This adds FD tracking for the following functions:
* eventfd
* timerfd_create
* socketpair
* accept

ASTERISK-27404

Change-Id: Id6848fe904ade2d34eb39d2a20bd6b223e1111fc

2 years agobridge_softmix: Note why ast_stream_topology_set_stream cannot fail.
Corey Farrell [Tue, 7 Nov 2017 17:49:35 +0000 (12:49 -0500)]
bridge_softmix: Note why ast_stream_topology_set_stream cannot fail.

This appeared in my audit of ast_stream_topology_set_stream callers
not checking for errors but in this situation the call cannot fail.
Add comment so this can be ignored in the future.

Change-Id: I91d25704859efbe50b8b82cfe1cd3c40ba177c9f

2 years agoMerge "AST-2017-009: pjproject: Add validation of numeric header values"
George Joseph [Wed, 8 Nov 2017 15:52:47 +0000 (09:52 -0600)]
Merge "AST-2017-009: pjproject: Add validation of numeric header values"

2 years agoMerge "AST-2017-011 - res_pjsip_session: session leak when a call is rejected"
George Joseph [Wed, 8 Nov 2017 15:45:24 +0000 (09:45 -0600)]
Merge "AST-2017-011 - res_pjsip_session: session leak when a call is rejected"

2 years agoMerge "AST-2017-010: Fix cdr_object_update_party_b_userfield_cb() buf overrun"
George Joseph [Wed, 8 Nov 2017 14:25:54 +0000 (08:25 -0600)]
Merge "AST-2017-010: Fix cdr_object_update_party_b_userfield_cb() buf overrun"

2 years agoMerge "res_pjproject.c: Fix ast_strdup() alloc failure."
Joshua Colp [Wed, 8 Nov 2017 13:38:45 +0000 (07:38 -0600)]
Merge "res_pjproject.c: Fix ast_strdup() alloc failure."

2 years agoAST-2017-011 - res_pjsip_session: session leak when a call is rejected
Kevin Harwell [Thu, 19 Oct 2017 18:35:16 +0000 (13:35 -0500)]
AST-2017-011 - res_pjsip_session: session leak when a call is rejected

A previous commit made it so when an invite session transitioned into a
disconnected state destruction of the Asterisk pjsip session object was
postponed until either a transport error occurred or the event timer
expired. However, if a call was rejected (for instance a 488) before the
session was fully established the event timer may not have been initiated,
or it was canceled without triggering either of the session finalizing states
mentioned above.

Really the only time destruction of the session should be delayed is when a
BYE is being transacted. This is because it's possible in some cases for the
session to be disconnected, but the BYE is still transacting.

This patch makes it so the session object always gets released (no more
memory leak) when the pjsip session is in a disconnected state. Except when
the method is a BYE. Then it waits until a transport error occurs or an event
timeout.

ASTERISK-27345 #close

Reported by: Corey Farrell

Change-Id: I1e724737b758c20ac76d19d3611e3d2876ae10ed

2 years agoAST-2017-010: Fix cdr_object_update_party_b_userfield_cb() buf overrun
Richard Mudgett [Tue, 3 Oct 2017 21:19:52 +0000 (16:19 -0500)]
AST-2017-010: Fix cdr_object_update_party_b_userfield_cb() buf overrun

cdr_object_update_party_b_userfield_cb() could overrun the fixed buffer if
the supplied string is too long.  The long string could be supplied by
external means using the CDR(userfield) function.

This may seem reminiscent to AST-2017-001 (ASTERISK_26897) and it is.  The
earlier patch fixed the buffer overrun for Party A's userfield while this
patch fixes the same thing for Party B's userfield.

ASTERISK-27337

Change-Id: I0fa767f65ecec7e676ca465306ff9e0edbf3b652

2 years agoAST-2017-009: pjproject: Add validation of numeric header values
George Joseph [Thu, 19 Oct 2017 18:53:32 +0000 (12:53 -0600)]
AST-2017-009: pjproject: Add validation of numeric header values

Parsing the numeric header fields like cseq, ttl, port, etc. all
had the potential to overflow, either causing unintended values to
be captured or, if the values were subsequently converted back to
strings, a buffer overrun.  To address this, new "strto" functions
have been created that do range checking and those functions are
used wherever possible in the parser.

 * Created pjlib/include/limits.h and pjlib/include/compat/limits.h
   to either include the system limits.h or define common numeric
   limits if there is no system limits.h.

 * Created strto*_validate functions in sip_parser that take bounds
   and on failure call the on_str_parse_error function which prints
   an error message and calls PJ_THROW.

 * Updated sip_parser to validate the numeric fields.

 * Fixed an issue in sip_transport that prevented error messages
   from being properly displayed.

 * Added "volatile" to some variables referenced in PJ_CATCH blocks
   as the optimizer was sometimes optimizing them away.

 * Fixed length calculation in sip_transaction/create_tsx_key_2543
   to account for signed ints being 11 characters, not 9.

ASTERISK-27319
Reported by: Youngsung Kim at LINE Corporation

Change-Id: I48de2e4ccf196990906304e8d7061f4ffdd772ff

2 years agoMerge "stream: Return error from ast_stream_topology_set_stream."
Jenkins2 [Wed, 8 Nov 2017 12:06:51 +0000 (06:06 -0600)]
Merge "stream: Return error from ast_stream_topology_set_stream."

2 years agoMerge "res_stasis: Fix multiple leaks."
Joshua Colp [Wed, 8 Nov 2017 10:58:12 +0000 (04:58 -0600)]
Merge "res_stasis: Fix multiple leaks."

2 years agores_pjsip_pubsub: Fix multiple leaks on failure to append vectors.
Corey Farrell [Mon, 6 Nov 2017 23:58:40 +0000 (18:58 -0500)]
res_pjsip_pubsub: Fix multiple leaks on failure to append vectors.

Change-Id: I68ece0073ea79667ca41eb10405f516f1d30d482

2 years agores_pjsip_history: Fix multiple leaks on vector append failure.
Corey Farrell [Tue, 7 Nov 2017 00:12:13 +0000 (19:12 -0500)]
res_pjsip_history: Fix multiple leaks on vector append failure.

Change-Id: I41e8d5183ace284095cc721f3b1fb32ade3f940f

2 years agores_pjsip_session: Fix multiple leaks.
Corey Farrell [Tue, 7 Nov 2017 00:01:38 +0000 (19:01 -0500)]
res_pjsip_session: Fix multiple leaks.

* Pre-initialize cloned media state vectors to final size to ensure
  vector errors cannot happen later in the clone initialization.
* Release session_media on vector replace failure in
  ast_sip_session_media_state_add.
* Release clone and media_state in ast_sip_session_refresh if we fail to
  append to the stream topology, return an error.

Change-Id: Ib5ffc9b198683fa7e9bf166d74d30c1334c23acb

2 years agoMerge "res_pjsip_outbound_registration: Fix leak on vector add failure."
Jenkins2 [Wed, 8 Nov 2017 02:39:31 +0000 (20:39 -0600)]
Merge "res_pjsip_outbound_registration: Fix leak on vector add failure."

2 years agoMerge "res_pjsip_exten_state: Check for vector append failure."
Jenkins2 [Wed, 8 Nov 2017 02:06:26 +0000 (20:06 -0600)]
Merge "res_pjsip_exten_state: Check for vector append failure."

2 years agoMerge "res_pjsip_config_wizard: Fix leaks and add check for malloc failure."
Jenkins2 [Wed, 8 Nov 2017 01:41:46 +0000 (19:41 -0600)]
Merge "res_pjsip_config_wizard: Fix leaks and add check for malloc failure."

2 years agoMerge "res_stasis_playback: Check for failure to append vector."
Jenkins2 [Wed, 8 Nov 2017 01:02:20 +0000 (19:02 -0600)]
Merge "res_stasis_playback: Check for failure to append vector."

2 years agoMerge "res_pjsip: Fix leak on error in ast_sip_auth_vector_init."
Jenkins2 [Wed, 8 Nov 2017 00:14:28 +0000 (18:14 -0600)]
Merge "res_pjsip: Fix leak on error in ast_sip_auth_vector_init."

2 years agoMerge "test_sorcery_memory_cache_thrash: Handle error from vector append."
Jenkins2 [Tue, 7 Nov 2017 23:32:48 +0000 (17:32 -0600)]
Merge "test_sorcery_memory_cache_thrash: Handle error from vector append."

2 years agoMerge "stasis: Release object if vector append fails."
Jenkins2 [Tue, 7 Nov 2017 22:40:49 +0000 (16:40 -0600)]
Merge "stasis: Release object if vector append fails."

2 years agoMerge "res_ari_events: Fix use after free / double-free of JSON message."
Jenkins2 [Tue, 7 Nov 2017 22:10:11 +0000 (16:10 -0600)]
Merge "res_ari_events: Fix use after free / double-free of JSON message."

2 years agoMerge "PBX: Handle errors from AST_VECTOR_APPEND."
Jenkins2 [Tue, 7 Nov 2017 21:27:26 +0000 (15:27 -0600)]
Merge "PBX: Handle errors from AST_VECTOR_APPEND."

2 years agoMerge "Messaging: Report error on failure to register tech or handler."
Jenkins2 [Tue, 7 Nov 2017 20:58:05 +0000 (14:58 -0600)]
Merge "Messaging: Report error on failure to register tech or handler."

2 years agoMerge "format_cap: Fix leak on AST_VECTOR_APPEND error."
Jenkins2 [Tue, 7 Nov 2017 20:20:02 +0000 (14:20 -0600)]
Merge "format_cap: Fix leak on AST_VECTOR_APPEND error."

2 years agoMerge "CLI: Remove unused internal command."
Jenkins2 [Tue, 7 Nov 2017 19:02:30 +0000 (13:02 -0600)]
Merge "CLI: Remove unused internal command."

2 years agoMerge "res_pjsip: Avoid crash when contact uri is empty string"
Jenkins2 [Tue, 7 Nov 2017 18:08:44 +0000 (12:08 -0600)]
Merge "res_pjsip:  Avoid crash when contact uri is empty string"

2 years agomain/sdp_state: Check for errors from ast_stream_topology_set_stream.
Corey Farrell [Tue, 7 Nov 2017 18:03:34 +0000 (13:03 -0500)]
main/sdp_state: Check for errors from ast_stream_topology_set_stream.

Change-Id: I84a83ae69daba5d185cc1d939b133a4c23565497

2 years agores_pjsip_registrar.c: Fix AOR and pjproject group deadlock.
Richard Mudgett [Mon, 6 Nov 2017 22:37:49 +0000 (16:37 -0600)]
res_pjsip_registrar.c: Fix AOR and pjproject group deadlock.

One of the patches for ASTERISK_27147 introduced a deadlock regression.
When the connection oriented transport shut down, the code attempted to
remove the associated contact.  However, that same transport had just
requested a registration that we hadn't responded to yet.  Depending
upon timing we could deadlock.

* Made send the REGISTER response after we completed processing the
request contacts and released the AOR lock to avoid the deadlock.

ASTERISK-27391

Change-Id: I89a90f87cb7a02facbafb44c75d8845f93417364

2 years agores_pjsip_session: Check for errors from ast_stream_topology_set_stream.
Corey Farrell [Tue, 7 Nov 2017 17:40:08 +0000 (12:40 -0500)]
res_pjsip_session: Check for errors from ast_stream_topology_set_stream.

Free memory and return error if ast_stream_topology_set_stream fails.

Change-Id: I9f4dbf44bed627243d2f1dd8aea2eab6c38a028d

2 years agores_pjsip_t38: Better error checking for t38_create_media_state.
Corey Farrell [Tue, 7 Nov 2017 17:34:19 +0000 (12:34 -0500)]
res_pjsip_t38: Better error checking for t38_create_media_state.

Change-Id: I81b2587427c6982aa3e2a3f9ad69cce8d316eb10

2 years agoMerge "res_pjsip: Ignore empty TLS configuration"
Jenkins2 [Tue, 7 Nov 2017 17:05:13 +0000 (11:05 -0600)]
Merge "res_pjsip: Ignore empty TLS configuration"

2 years agostream: Return error from ast_stream_topology_set_stream.
Corey Farrell [Mon, 6 Nov 2017 21:38:05 +0000 (16:38 -0500)]
stream: Return error from ast_stream_topology_set_stream.

ast_stream_topology_set_stream had suppressed error codes from
AST_VECTOR_APPEND.  The result of AST_VECTOR_APPEND needs to be returned
to the caller so they can take appropriate action on the stream.

Change-Id: I6c0d12755743eadba1357f6153526cc055592856

2 years agores_stasis: Fix multiple leaks.
Corey Farrell [Mon, 6 Nov 2017 23:21:53 +0000 (18:21 -0500)]
res_stasis: Fix multiple leaks.

* res/stasis/app.c JSON passed to app_send needs to be released.
* res/stasis_message.c: objects leak if vector append fails.

Change-Id: I8dd5385b9f50a5cadf2b1d16efecffd6ddb4db4a