asterisk/asterisk.git
9 years agoMerged revisions 260661-260662 via svnmerge from
Paul Belanger [Mon, 3 May 2010 17:06:48 +0000 (17:06 +0000)]
Merged revisions 260661-260662 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r260661 | pabelanger | 2010-05-03 12:41:30 -0400 (Mon, 03 May 2010) | 10 lines

  non-root make install PREFIX=/tmp fails.
  Prepend libdir when executing mkpkgconfig allowing non-root installs to work.

  (closes issue #17268)
  Reported by: pabelanger
  Patches:
        issue17268.patch uploaded by pabelanger (license 224)
  Tested by: pabelanger
........
  r260662 | pabelanger | 2010-05-03 12:54:41 -0400 (Mon, 03 May 2010) | 3 lines

  Should have removed /usr/lib/ part. Thanks Qwell.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260663 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 260569 via svnmerge from
Leif Madsen [Mon, 3 May 2010 14:58:23 +0000 (14:58 +0000)]
Merged revisions 260569 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r260569 | lmadsen | 2010-05-03 09:57:39 -0500 (Mon, 03 May 2010) | 1 line

  Minor typo pointed out by pabelanger on IRC.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260570 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAvoid making AstData depend on libxml2 to compile.
Eliel C. Sardanons [Sun, 2 May 2010 02:52:23 +0000 (02:52 +0000)]
Avoid making AstData depend on libxml2 to compile.

We have some functions inside the AstData API to get the tree
in XML form, but it is not required at the moment to compile
asterisk and we can disable that part of the API if we don't have
libxml2 support.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260521 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 260434 via svnmerge from
Jeff Peeler [Fri, 30 Apr 2010 22:36:49 +0000 (22:36 +0000)]
Merged revisions 260434 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r260434 | jpeeler | 2010-04-30 17:22:46 -0500 (Fri, 30 Apr 2010) | 11 lines

  Ensure channel state is not incorrectly set in the case of a very early answer.

  The needringing bit was being read in dahdi_read after answering thereby
  setting the state to ringing from up. This clears needringing upon answering
  so that is no longer possible.

  (closes issue #17067)
  Reported by: tzafrir
  Patches:
        needringing.diff uploaded by tzafrir (license 46)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260437 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoSeparate the uses of NUM_DCHANS and MAX_CHANNELS into PRI, SS7, and MFCR2 users.
Richard Mudgett [Fri, 30 Apr 2010 22:24:28 +0000 (22:24 +0000)]
Separate the uses of NUM_DCHANS and MAX_CHANNELS into PRI, SS7, and MFCR2 users.

Created
SIG_PRI_MAX_CHANNELS, SIG_PRI_NUM_DCHANS
SIG_SS7_MAX_CHANNELS, SIG_SS7_NUM_DCHANS
SIG_MFCR2_MAX_CHANNELS

Also fixed the declaration of pollers[] in mfcr2_monitor().  It was
dimensioned to the number of bytes in struct dahdi_mfcr2.pvts[] and not to
the same dimension of the struct dahdi_mfcr2.pvts[].

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260435 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 260345 via svnmerge from
Mark Michelson [Fri, 30 Apr 2010 20:11:02 +0000 (20:11 +0000)]
Merged revisions 260345 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r260345 | mmichelson | 2010-04-30 15:08:15 -0500 (Fri, 30 Apr 2010) | 18 lines

  Fix potential crash from race condition due to accessing channel data without the channel locked.

  In res_musiconhold.c, there are several places where a channel's
  stream's existence is checked prior to calling ast_closestream on it. The issue
  here is that in several cases, the channel was not locked while checking the
  stream. The result was that if two threads checked the state of the channel's
  stream at approximately the same time, then there could be a situation where
  both threads attempt to call ast_closestream on the channel's stream. The result
  here is that the refcount for the stream would go below 0, resulting in a crash.

  I have added proper channel locking to res_musiconhold.c to ensure that
  we do not try to check chan->stream without the channel locked. A Digium customer
  has been using this patch for several weeks and has not had any crashes since
  applying the patch.

  ABE-2147
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260346 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix logic reversal error when queue callers join the queue.
Mark Michelson [Fri, 30 Apr 2010 19:53:36 +0000 (19:53 +0000)]
Fix logic reversal error when queue callers join the queue.

When a specific position is specified for the queue, the idea
was that the caller cannot be placed ahead of higher-priority
callers. Unfortunately, the logic was reversed so that the caller
could ONLY be placed ahead of higher priority callers.

Discovered while writing a unit test.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260344 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoDon't allow file descriptors to go above 64k, when we're closing them in a fork(2).
Tilghman Lesher [Fri, 30 Apr 2010 06:19:35 +0000 (06:19 +0000)]
Don't allow file descriptors to go above 64k, when we're closing them in a fork(2).

This saves time, when, even though the system allows the process limit to be
that high, the practical limit is much lower.  Also introduce an additional
optimization, in the form of using the CLOEXEC flag to close descriptors at
the right time.

(closes issue #17223)
 Reported by: dbackeberg
 Patches:
       20100423__issue17223.diff.txt uploaded by tilghman (license 14)
 Tested by: dbackeberg

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260292 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoLogic fixups for a sample FREENUM dialplan context.
Tilghman Lesher [Fri, 30 Apr 2010 05:23:56 +0000 (05:23 +0000)]
Logic fixups for a sample FREENUM dialplan context.

(closes issue #17263)
 Reported by: pprindeville
 Patches:
       freenum-dialplan.patch#3 uploaded by pprindeville (license 347)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260280 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 260195 via svnmerge from
Richard Mudgett [Thu, 29 Apr 2010 22:44:14 +0000 (22:44 +0000)]
Merged revisions 260195 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r260195 | rmudgett | 2010-04-29 17:11:47 -0500 (Thu, 29 Apr 2010) | 26 lines

  DTMF CallerID detection problems.

  The code handling DTMF CallerID drops digits on long CallerID numbers and
  may timeout waiting for the first ring with shorter numbers.

  The DTMF emulation mode was not turned off when processing DTMF CallerID.
  When the emulation code gets behind in processing the DTMF digits it can
  skip a digit.

  For shorter numbers, the timeout may have been too short.  I increased it
  from 2 seconds to 4 seconds.  Four seconds is a typical time between rings
  for many countries.

  (closes issue #16460)
  Reported by: sum
  Patches:
        issue16460.patch uploaded by rmudgett (license 664)
        issue16460_v1.6.2.patch uploaded by rmudgett (license 664)
  Tested by: sum, rmudgett

  Review: https://reviewboard.asterisk.org/r/634/

  JIRA SWP-562
  JIRA AST-334
  JIRA SWP-901
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260231 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoPattern match fail.
Tilghman Lesher [Thu, 29 Apr 2010 18:15:57 +0000 (18:15 +0000)]
Pattern match fail.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260148 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 260049 via svnmerge from
David Vossel [Thu, 29 Apr 2010 15:33:27 +0000 (15:33 +0000)]
Merged revisions 260049 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r260049 | dvossel | 2010-04-29 10:31:02 -0500 (Thu, 29 Apr 2010) | 14 lines

  Fixes crash in audiohook_write_list

  The middle_frame in the audiohook_write_list function was
  being freed if a audiohook manipulator returned a failure.
  This is incorrect logic.  This patch resolves this and
  adds detailed descriptions of how this function should work
  and why manipulator failures must be ignored.

  (closes issue #17052)
  Reported by: dvossel
  Tested by: dvossel

  (closes issue #16196)
  Reported by: atis

  Review: https://reviewboard.asterisk.org/r/623/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260050 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix comment.
Richard Mudgett [Thu, 29 Apr 2010 00:35:14 +0000 (00:35 +0000)]
Fix comment.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@260007 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoDon't override peer context with domain context.
Mark Michelson [Wed, 28 Apr 2010 22:34:15 +0000 (22:34 +0000)]
Don't override peer context with domain context.

(closes issue #17040)
Reported by: pprindeville
Patches:
      asterisk-1.6-bugid17040.patch uploaded by pprindeville (license 347)
Tested by: pprindeville

Review: https://reviewboard.asterisk.org/r/565/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259957 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259858 via svnmerge from
David Vossel [Wed, 28 Apr 2010 21:20:03 +0000 (21:20 +0000)]
Merged revisions 259858 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259858 | dvossel | 2010-04-28 16:16:03 -0500 (Wed, 28 Apr 2010) | 33 lines

  resolves deadlocks in chan_local

  Issue_1.
  In the local_hangup() 3 locks must be held at the same time... pvt, pvt->chan,
  and pvt->owner.  Proper deadlock avoidance is done when the channel to hangup
  is the outbound chan_local channel, but when it is not the outbound channel we
  have an issue... We attempt to do deadlock avoidance only on the tech pvt, when
  both the tech pvt and the pvt->owner are locked coming into that loop.  By
  never giving up the pvt->owner channel deadlock avoidance is not entirely possible.
  This patch resolves that by doing deadlock avoidance on both the pvt->owner and the pvt
  when trying to get the pvt->chan lock.

  Issue_2.
  ast_prod() is used in ast_activate_generator() to queue a frame on the channel
  and make the channel's read function get called.  This function is used in
  ast_activate_generator() while the channel is locked, which mean's the channel
  will have a lock both from the generator code and the frame_queue code by the
  time it gets to chan_local.c's local_queue_frame code... local_queue_frame
  contains some of the same crazy deadlock avoidance that local_hangup requires,
  and this recursive lock prevents that deadlock avoidance from happening correctly.
  This patch removes ast_prod() from the channel lock so only one lock is held during
  the local_queue_frame function.

  (closes issue #17185)
  Reported by: schmoozecom
  Patches:
        issue_17185_v1.diff uploaded by dvossel (license 671)
        issue_17185_v2.diff uploaded by dvossel (license 671)
  Tested by: schmoozecom, GameGamer43

  Review: https://reviewboard.asterisk.org/r/631/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259870 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259852 via svnmerge from
Leif Madsen [Wed, 28 Apr 2010 21:08:34 +0000 (21:08 +0000)]
Merged revisions 259852 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259852 | lmadsen | 2010-04-28 16:07:48 -0500 (Wed, 28 Apr 2010) | 6 lines

  Update config.guess.

  Updating config.guess because after installing Ubuntu Server 9.10 and
  running all the update scripts, running ./configure would not continue
  because it was unable to determine what kind of system I had. After
  updating config.guess things started working again.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259853 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259847 via svnmerge from
Jason Parker [Wed, 28 Apr 2010 20:32:14 +0000 (20:32 +0000)]
Merged revisions 259847 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259847 | qwell | 2010-04-28 15:30:21 -0500 (Wed, 28 Apr 2010) | 1 line

  Add AC_CONFIG_AUX_DIR to configure script, so systems without install can use install-sh from our source dir.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259848 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259833 via svnmerge from
Jason Parker [Wed, 28 Apr 2010 20:26:35 +0000 (20:26 +0000)]
Merged revisions 259833 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259833 | qwell | 2010-04-28 15:25:36 -0500 (Wed, 28 Apr 2010) | 1 line

  Missed this when removing $ID
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259837 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259748 via svnmerge from
Jason Parker [Wed, 28 Apr 2010 19:19:54 +0000 (19:19 +0000)]
Merged revisions 259748 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259748 | qwell | 2010-04-28 14:17:38 -0500 (Wed, 28 Apr 2010) | 7 lines

  Remove usage of `id` since it isn't useful and was causing breakge.

  Solaris `id` doesn't support the -u argument.  Instead of figuring out how to
  fix this to work on Solaris, I decided to check why it was necessary and where
  else it was used.  It was only used in one place, and it hasn't been needed
  for a very long time (I question whether it was ever needed).
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259760 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259664 via svnmerge from
Jeff Peeler [Wed, 28 Apr 2010 17:18:43 +0000 (17:18 +0000)]
Merged revisions 259664 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259664 | jpeeler | 2010-04-28 12:13:29 -0500 (Wed, 28 Apr 2010) | 4 lines

  Do not play goodbye prompt after timeout of message review.

  ABE-2124
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259672 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix compile on systems without HAVE_NULLSAFE_PRINTF defined.
Jason Parker [Tue, 27 Apr 2010 22:47:36 +0000 (22:47 +0000)]
Fix compile on systems without HAVE_NULLSAFE_PRINTF defined.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259617 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBe more explicit about field naming in a test.
Jason Parker [Tue, 27 Apr 2010 22:28:16 +0000 (22:28 +0000)]
Be more explicit about field naming in a test.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259587 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259531 via svnmerge from
Richard Mudgett [Tue, 27 Apr 2010 22:18:09 +0000 (22:18 +0000)]
Merged revisions 259531 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259531 | rmudgett | 2010-04-27 16:53:07 -0500 (Tue, 27 Apr 2010) | 11 lines

  DAHDI "WARNING" message is confusing and vague

  "WARNING[28406]: chan_dahdi.c:6873 ss_thread: CallerID feed failed: Success"

  Changed the warning to "Failed to decode CallerID on channel 'name'".  The
  message before it is likely more specific about why the CallerID decode
  failed.

  SWP-501
  AST-283
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259538 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoShuffle some casts to make builds on bamboo happier.
Mark Michelson [Tue, 27 Apr 2010 22:11:58 +0000 (22:11 +0000)]
Shuffle some casts to make builds on bamboo happier.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259533 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259526 via svnmerge from
Leif Madsen [Tue, 27 Apr 2010 21:49:36 +0000 (21:49 +0000)]
Merged revisions 259526 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259526 | lmadsen | 2010-04-27 16:48:47 -0500 (Tue, 27 Apr 2010) | 15 lines

  Update sounds files.

  * Add additional sounds prompts for say_enumeration
  * Update the English conference sounds prompts so they are better
    quality and all sound more consistent
  * Clean up the core-sounds-XX.txt and extra-sounds-XX.txt files to
    include all present sound files

  Both core (en, fr, es) and extra (en, fr) sounds files have been updated.

  (closes issue #16200)
  Reported by: murf

  (closes issue #17137)
  Reported by: lmadsen
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259527 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBlock 259441 instead of recording it as merged.
Jason Parker [Tue, 27 Apr 2010 21:18:59 +0000 (21:18 +0000)]
Block 259441 instead of recording it as merged.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259451 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRecorded merge of revisions 259441 via svnmerge from
Jason Parker [Tue, 27 Apr 2010 21:17:01 +0000 (21:17 +0000)]
Recorded merge of revisions 259441 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259441 | qwell | 2010-04-27 16:15:46 -0500 (Tue, 27 Apr 2010) | 1 line

  Add gar to the check for AR for those silly OSes (Solaris) that don't have ar.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259442 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd gar to the check for AR for those silly OSes (Solaris) that don't have ar.
Jason Parker [Tue, 27 Apr 2010 21:13:01 +0000 (21:13 +0000)]
Add gar to the check for AR for those silly OSes (Solaris) that don't have ar.

autoconf2.13 couldn't handle AC_PROG_GREP, so I removed it.  This is fine,
since we don't need to use anything that the configure script doesn't.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259439 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate the Mantis Workflow document in doxygen.
Leif Madsen [Tue, 27 Apr 2010 21:10:32 +0000 (21:10 +0000)]
Update the Mantis Workflow document in doxygen.

(closes issue #17175)
Reported by: lmadsen
Patches:
      Bug_Tracker_Workflow.v2.txt uploaded by pabelanger (license 224)
Tested by: pabelanger, lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259438 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoChange cc_ref and cc_unref from macros to inline functions.
Mark Michelson [Tue, 27 Apr 2010 19:52:18 +0000 (19:52 +0000)]
Change cc_ref and cc_unref from macros to inline functions.

The hope is that Solaris won't be as whiny after this change.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259357 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259352 via svnmerge from
Jason Parker [Tue, 27 Apr 2010 19:31:55 +0000 (19:31 +0000)]
Merged revisions 259352 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259352 | qwell | 2010-04-27 14:29:26 -0500 (Tue, 27 Apr 2010) | 5 lines

  Support the silly OSes that don't have ar and strip.

  Since AC_PATH_TOOL is equiv to AC_CHECK_TOOL when path isn't specified, and
  AC_PATH_TOOLS doesn't exist, we'll just switch to AC_CHECK_TOOLS.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259353 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259270 via svnmerge from
Richard Mudgett [Tue, 27 Apr 2010 18:29:33 +0000 (18:29 +0000)]
Merged revisions 259270 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259270 | rmudgett | 2010-04-27 13:14:54 -0500 (Tue, 27 Apr 2010) | 14 lines

  hidecalleridname parameter in chan_dahdi.conf

  Issue #7321 implements a new chan_dahdi configuration option.  However, a
  change mentioned in the issue was never implemented.  This is the change
  that will allow the feature to work.

  I added a note to chan_dahdi.conf.sample about the feature.

  (closes issue #17143)
  Reported by: djensen99
  Patches:
        diff.txt uploaded by djensen99 (license NA) (One line change)
  Tested by: djensen99
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259307 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRe-fix dahdi_request() iflist locking since CCSS merged.
Richard Mudgett [Tue, 27 Apr 2010 16:52:29 +0000 (16:52 +0000)]
Re-fix dahdi_request() iflist locking since CCSS merged.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259229 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd missing file (pointed out by TheDavidFactor on #asterisk-dev) referenced by revis...
Tilghman Lesher [Tue, 27 Apr 2010 15:25:22 +0000 (15:25 +0000)]
Add missing file (pointed out by TheDavidFactor on #asterisk-dev) referenced by revision 239231.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259189 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259104 via svnmerge from
Mark Michelson [Mon, 26 Apr 2010 21:45:13 +0000 (21:45 +0000)]
Merged revisions 259104 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259104 | mmichelson | 2010-04-26 16:44:43 -0500 (Mon, 26 Apr 2010) | 3 lines

  Let compilation succeed warning-free when DONT_OPTIMIZE is turned off.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259105 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 259018 via svnmerge from
Mark Michelson [Mon, 26 Apr 2010 21:13:35 +0000 (21:13 +0000)]
Merged revisions 259018 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r259018 | mmichelson | 2010-04-26 16:03:08 -0500 (Mon, 26 Apr 2010) | 13 lines

  Prevent Newchannel manager events for dummy channels.

  No Newchannel manager event will be fired for channels that are
  allocated to not match a registered technology type. Thus bogus
  channels allocated solely for variable substitution or CDR
  operations do not result in a Newchannel event.

  (closes issue #16957)
  Reported by: atis

  Review: https://reviewboard.asterisk.org/r/601
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@259023 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoLine 24 missed in compatibility fix in revision 233577
David Ruggles [Mon, 26 Apr 2010 19:05:47 +0000 (19:05 +0000)]
Line 24 missed in compatibility fix in revision 233577

added a "fun:" prefix line 24

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258974 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoSmall error in the T.140 RTP port verbose log.
Leif Madsen [Mon, 26 Apr 2010 15:59:34 +0000 (15:59 +0000)]
Small error in the T.140 RTP port verbose log.

(closes issue #16988)
Reported by: frawd
Patches:
      chan_sip_sdp_verbose_fix.diff uploaded by frawd (license 610)
Tested by: russell

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258934 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate res_fax and res_fax_spandsp to be compatible with Fax For Asterisk 1.2.
Matthew Nicholson [Mon, 26 Apr 2010 14:18:15 +0000 (14:18 +0000)]
Update res_fax and res_fax_spandsp to be compatible with Fax For Asterisk 1.2.

The fax session initilization code for T.38 faxes has been rewritten. T.38 session initialization was removed from generic_fax_exec, and split into two different code paths for receive and send.  Also the 'z' option (to send a T.38 reinvite if we do not receive one) was added to sendfax.

In the output of 'fax show sessions', the 'Type' column has been renamed to 'Tech' and replaced with a new 'Tech' column that will report 'G.711' or 'T.38'.

Control of ECM defaults has been added to res_fax

A 'fax show settings' CLI command has been added.

Support of the new AST_T38_REQUEST_PARMS control method request to handle channels that have already received a T.38 reinvite before the FAX application is start has been added.

Support for the 'fax show settings' command has been added to res_fax_spandsp and handling of the ECM flag has been slightly altered.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258896 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoadditional checking related to issue 17186
Alexandr Anikin [Sun, 25 Apr 2010 18:51:37 +0000 (18:51 +0000)]
additional checking related to issue 17186

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258855 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoDon't pass zero length callerid to ooh323 stack
Alexandr Anikin [Sun, 25 Apr 2010 18:34:29 +0000 (18:34 +0000)]
Don't pass zero length callerid to ooh323 stack

Don't pass zero callerid string to ooh323 stack because it can't encode this properly and
can't generate setup message.

(closes issue #17186)
Reported by: vmikhelson
Patches:
      zero_callerid_num.patch uploaded by may213 (license 454)
Tested by: may213

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258838 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 258775 via svnmerge from
Tilghman Lesher [Sun, 25 Apr 2010 18:12:14 +0000 (18:12 +0000)]
Merged revisions 258775 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r258775 | tilghman | 2010-04-25 13:09:05 -0500 (Sun, 25 Apr 2010) | 6 lines

  When StopMonitor is called, ensure that it will not be restarted by a channel event.
  (closes issue #16590)
   Reported by: kkm
   Patches:
         resmonitor-16590-trunk.239289.diff uploaded by kkm (license 888)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258776 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd another random function that does nothing to make the utils/ dir happy.
Jason Parker [Thu, 22 Apr 2010 22:19:34 +0000 (22:19 +0000)]
Add another random function that does nothing to make the utils/ dir happy.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258685 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix previous commit.
Matthew Nicholson [Thu, 22 Apr 2010 22:11:23 +0000 (22:11 +0000)]
Fix previous commit.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258675 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMake utils/ stuff *actually* compile this time.
Jason Parker [Thu, 22 Apr 2010 22:10:17 +0000 (22:10 +0000)]
Make utils/ stuff *actually* compile this time.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258674 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoLet utils/ dir compile when DEBUG_THREADS is not enabled.
Jason Parker [Thu, 22 Apr 2010 22:02:22 +0000 (22:02 +0000)]
Let utils/ dir compile when DEBUG_THREADS is not enabled.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258673 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 193391,258670 via svnmerge from
Matthew Nicholson [Thu, 22 Apr 2010 21:57:59 +0000 (21:57 +0000)]
Merged revisions 193391,258670 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r193391 | mnicholson | 2009-05-08 16:01:25 -0500 (Fri, 08 May 2009) | 8 lines

  Set the proper disposition on originated calls.

  (closes issue #14167)
  Reported by: jpt
  Patches:
        call-file-missing-cdr2.diff uploaded by mnicholson (license 96)
  Tested by: dlotina, rmartinez, mnicholson
........
  r258670 | mnicholson | 2010-04-22 16:49:07 -0500 (Thu, 22 Apr 2010) | 11 lines

  Fix broken CDR behavior.

  This change allows a CDR record previously marked with disposition ANSWERED to be set as BUSY or NO ANSWER.

  Additionally this change partially reverts r235635 and does not set the AST_CDR_FLAG_ORIGINATED flag on CDRs generated from ast_call().  To preserve proper CDR behavior, the AST_CDR_FLAG_DIALED flag is now cleared from all brige CDRs in ast_bridge_call().

  (closes issue #16797)
  Reported by: VarnishedOtter
  Tested by: mnicholson
........

(closes issue #16222)
Reported by: telles
Tested by: mnicholson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258671 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd ast_event subscription unit test and fix some ast_event API bugs.
Russell Bryant [Thu, 22 Apr 2010 21:06:53 +0000 (21:06 +0000)]
Add ast_event subscription unit test and fix some ast_event API bugs.

This patch introduces another test in test_event.c that exercises most of the
subscription related ast_event API calls.  I made some minor additions to the
existing event allocation test to increase API coverage by the test code.
Finally, I made a list in a comment of API calls not yet touched by the test
module as a to-do list for future test development.

During the development of this test code, I discovered a number of bugs in
the event API.

1) subscriptions to AST_EVENT_ALL were not handled appropriately in a couple
   of different places.  The API allows a subscription to all event types,
   but with IE parameters, just as if it was a subscription to a specific
   event type.  However, the parameters were being ignored.  This affected
   ast_event_check_subscriber() and event distribution to subscribers.

2) Some of the logic in ast_event_check_subscriber() for checking subscriptions
   against query parameters was wrong.

Review: https://reviewboard.asterisk.org/r/617/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258632 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoPass interactive = 0 and fix a compile error.
Eliel C. Sardanons [Thu, 22 Apr 2010 20:04:23 +0000 (20:04 +0000)]
Pass interactive = 0 and fix a compile error.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258595 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRemove ABI differences that occured when compiling with DEBUG_THREADS.
Jason Parker [Thu, 22 Apr 2010 19:08:01 +0000 (19:08 +0000)]
Remove ABI differences that occured when compiling with DEBUG_THREADS.

"Bad Things" would happen if Asterisk was compiled with DEBUG_THREADS, but a
loaded module was not (or vice versa).  This also immensely simplifies the
lock code, since there are no longer 2 separate versions of them.

Review: https://reviewboard.asterisk.org/r/508/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258557 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAsterisk data retrieval API.
Eliel C. Sardanons [Thu, 22 Apr 2010 18:07:02 +0000 (18:07 +0000)]
Asterisk data retrieval API.

This module implements an abstraction for retrieving and exporting
asterisk data.
Developed by:
Brett Bryant <brettbryant@gmail.com>
Eliel C. Sardanons (LU1ALY) <eliels@gmail.com>
For the Google Summer of code 2009 Project.
Documentation can be found in doxygen format and inside the
header include/asterisk/data.h

Review: https://reviewboard.asterisk.org/r/275/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258517 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd MEETMEBOOKID from r256019.
Russell Bryant [Thu, 22 Apr 2010 17:36:34 +0000 (17:36 +0000)]
Add MEETMEBOOKID from r256019.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258515 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 258432 via svnmerge from
Jeff Peeler [Wed, 21 Apr 2010 21:56:09 +0000 (21:56 +0000)]
Merged revisions 258432 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r258432 | jpeeler | 2010-04-21 16:45:36 -0500 (Wed, 21 Apr 2010) | 8 lines

  Fix looping forever when no input received in certain voicemail menu scenarios.

  Specifically, prompting for an extension (when leaving or forwarding a message)
  or when prompting for a digit (when saving a message or changing folders).

  ABE-2122
  SWP-1268
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258433 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMissed this when reverting the bad version change in asterisk.tex.
Leif Madsen [Wed, 21 Apr 2010 19:45:33 +0000 (19:45 +0000)]
Missed this when reverting the bad version change in asterisk.tex.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258387 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix change in asterisk.tex that got merged in after testing.
Leif Madsen [Wed, 21 Apr 2010 19:27:41 +0000 (19:27 +0000)]
Fix change in asterisk.tex that got merged in after testing.

(issue #17220)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258383 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd ability to generate ASCII documentation from the TeX files.
Leif Madsen [Wed, 21 Apr 2010 19:18:35 +0000 (19:18 +0000)]
Add ability to generate ASCII documentation from the TeX files.

These changes add the ability to run 'make asterisk.txt' just like the existing
'make asterisk.pdf' commands to generate a text document from the TeX files we
have in the doc/tex/ directory. I've also updated a few of the .tex files because
they weren't properly escaping certain characters so they would show up as Unicode
characters (like [U+021C]). Made changes to the configure scripts so it would
detect the catdvi program which is required to convert the .dvi file generated
by latex.

I've also added a few lines to the build_tools/prep_tarball script so that the
text documentation gets generated and added to future tarballs of Asterisk
releases.

(closes issue #17220)
Reported by: lmadsen
Patches:
      asterisk.txt.patch uploaded by lmadsen (license 10)
      asterisk.txt.patch-v4 uploaded by pabelanger (license 224)
Tested by: lmadsen, pabelanger

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258351 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd small documentation update to func_callcompletion.c.
Mark Michelson [Wed, 21 Apr 2010 19:07:25 +0000 (19:07 +0000)]
Add small documentation update to func_callcompletion.c.

This directs users to documents which can help explain the
concepts and configuration options settable with the function.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258345 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoIAXpeers output now matches SIPpeers format for manager (AMI).
Leif Madsen [Wed, 21 Apr 2010 19:02:45 +0000 (19:02 +0000)]
IAXpeers output now matches SIPpeers format for manager (AMI).

(closes issue #17100)
Reported by: secesh
Tested by: pabelanger

Review: https://reviewboard.asterisk.org/r/594/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258344 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes issue with double "sip:" in header field
David Vossel [Wed, 21 Apr 2010 18:13:36 +0000 (18:13 +0000)]
fixes issue with double "sip:" in header field

This is a clear mistake in logic.  Future discussions
about how to avoid having to handle uri's like this
should take place in the future, but this fix needs
to go in for now.

(closes issue #15847)
Reported by: ebroad
Patches:
      doublesip.patch uploaded by ebroad (license 878)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258305 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix the \brief description in the res_calendar_*.c files.
Leif Madsen [Wed, 21 Apr 2010 13:26:28 +0000 (13:26 +0000)]
Fix the \brief description in the res_calendar_*.c files.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258265 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofix whitespace issue
Julian Lyndon-Smith [Wed, 21 Apr 2010 13:24:28 +0000 (13:24 +0000)]
fix whitespace issue

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258256 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdded NEW ACTIONS entry for new MixMonitorMute AMI command.
Julian Lyndon-Smith [Wed, 21 Apr 2010 13:08:44 +0000 (13:08 +0000)]
Added NEW ACTIONS entry for new MixMonitorMute AMI command.
Added State and Direction variables for new MixMonitorMute AMI command.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258228 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdded CHANGES entry for new MixMonitorMute AMI command.
Julian Lyndon-Smith [Wed, 21 Apr 2010 12:48:32 +0000 (12:48 +0000)]
Added CHANGES entry for new MixMonitorMute AMI command.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258227 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdded MixMonitorMute manager command
Julian Lyndon-Smith [Wed, 21 Apr 2010 11:27:27 +0000 (11:27 +0000)]
Added MixMonitorMute manager command

Added a new manager command to mute/unmute MixMonitor audio on a channel.
Added a new feature to audiohooks so that you can mute either read / write
(or both) types of frames - this allows for MixMonitor to mute either side
of the conversation without affecting the conversation itself.

(closes issue #16740)
Reported by: jmls

Review: https://reviewboard.asterisk.org/r/487/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258190 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd 'soft hangup' alias per Steve Johnson on asterisk-users.
Leif Madsen [Tue, 20 Apr 2010 19:02:49 +0000 (19:02 +0000)]
Add 'soft hangup' alias per Steve Johnson on asterisk-users.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258149 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd example dialplan for dialing ISN numbers (http://www.freenum.org).
Leif Madsen [Tue, 20 Apr 2010 18:38:39 +0000 (18:38 +0000)]
Add example dialplan for dialing ISN numbers (freenum.org).
Minor tweaks and documentation added by me.

(closes issue #17058)
Reported by: pprindeville
Patches:
      freenum.patch#5 uploaded by pprindeville (license 347)
Tested by: lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258147 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd missing 'useragent' field to sip-friends.sql file.
Leif Madsen [Tue, 20 Apr 2010 18:01:28 +0000 (18:01 +0000)]
Add missing 'useragent' field to sip-friends.sql file.

(closes issue #17171)
Reported by: thehar
Patches:
      sip-friends.patch uploaded by thehar (license 831)
Tested by: pabelanger, thehar

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258106 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 258029 via svnmerge from
Jeff Peeler [Tue, 20 Apr 2010 17:06:19 +0000 (17:06 +0000)]
Merged revisions 258029 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r258029 | jpeeler | 2010-04-20 11:16:33 -0500 (Tue, 20 Apr 2010) | 11 lines

  Play correct prompt when voicemail store failure occurs after attempted forward.

  If a user's mailbox was full and a message was attempted to be forwarded to
  said box, warnings on the console would indicate failure. However, the played
  prompt was that of success (vm-msgsaved). Now storage failure is taken into
  account and the correct prompt (vm-mailboxfull) is played when appropriate.

  ABE-2123
  SWP-1262
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258065 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate supported file extensions in doxygen.
Leif Madsen [Tue, 20 Apr 2010 12:38:47 +0000 (12:38 +0000)]
Update supported file extensions in doxygen.

Updated the doxygen \arg line after looking at the file for some other Asterisk documentation
and noticing they weren't up to date. Thanks to seanbright for looking at the code for me :)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257988 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoChange log message to match severity.
Jason Parker [Mon, 19 Apr 2010 21:57:56 +0000 (21:57 +0000)]
Change log message to match severity.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257949 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoDon't consider a missing indications.conf to be a critical error.
Jason Parker [Mon, 19 Apr 2010 21:49:30 +0000 (21:49 +0000)]
Don't consider a missing indications.conf to be a critical error.

There were many changes in revision 176627 which would avoid the error that a
missing config would have caused.  Other than this, there are no other config
files (including asterisk.conf, surprisingly) that are required.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257947 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBad merge fix
Tilghman Lesher [Mon, 19 Apr 2010 19:23:41 +0000 (19:23 +0000)]
Bad merge fix

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257883 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBlocked revisions 257856 via svnmerge
Jeff Peeler [Mon, 19 Apr 2010 19:10:18 +0000 (19:10 +0000)]
Blocked revisions 257856 via svnmerge

........
  r257856 | jpeeler | 2010-04-19 14:09:46 -0500 (Mon, 19 Apr 2010) | 1 line

  make app_voicemail compile with IMAP_STORAGE
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257857 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoCommit compromise I suggested on review 608.
Mark Michelson [Mon, 19 Apr 2010 18:42:31 +0000 (18:42 +0000)]
Commit compromise I suggested on review 608.

This allows for multiple SRV queries to be done
from the dialplan for the same service on a single call while
still allowing one to bypass the call to SRVQUERY if they so
please.

Taking action since no comments had been left for a while.
This can easily be reverted if needed. External tests
still pass.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257851 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix incomplete CDR merge from r195881
Terry Wilson [Mon, 19 Apr 2010 17:57:41 +0000 (17:57 +0000)]
Fix incomplete CDR merge from r195881

Because res/res_features.c was removed and main/cdr.c added, these changes
didn't make it to trunk and the 1.6.x branches

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257810 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRemoving unused configuration parameters
Tilghman Lesher [Sun, 18 Apr 2010 17:25:53 +0000 (17:25 +0000)]
Removing unused configuration parameters

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257768 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 257686 via svnmerge from
Dwayne M. Hubbard [Fri, 16 Apr 2010 21:22:30 +0000 (21:22 +0000)]
Merged revisions 257686 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r257686 | dhubbard | 2010-04-16 16:15:43 -0500 (Fri, 16 Apr 2010) | 21 lines

  Make the mixmonitor thread process audio frames faster

  Mantis issue 17078 reports MixMonitor recordings have shorter durations than
  the call duration.  This was because the mixmonitor thread was not processing
  frames from the audiohook fast enough.  The mixmonitor thread would slowly fall
  behind the most recent audio frame and when the channel hangs up, the mixmonitor
  thread would exit without processing the same number of frames as the channel;
  leaving the mixmonitor recording shorter than actual call duration.

  This revision fixes this issue by moving the ast_audiohook_trigger_wait() and
  the subsequent audiohook.status check into the block where the
  ast_audiohook_read_frame() function returns NULL.

  (closes issue #17078)
  Reported by: geoff2010
  Patches:
        dw-M17078.patch uploaded by dhubbard (license 733)
  Tested by: dhubbard, geoff2010

  Review: https://reviewboard.asterisk.org/r/611/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257713 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMake sure to fail a monitor if we receive a negative response for a CC SUBSCRIBE.
Mark Michelson [Fri, 16 Apr 2010 19:50:43 +0000 (19:50 +0000)]
Make sure to fail a monitor if we receive a negative response for a CC SUBSCRIBE.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257646 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoEnable PRI SERVICE message support in chan_dahdi for the 'national' switchtype
Dwayne M. Hubbard [Fri, 16 Apr 2010 19:25:30 +0000 (19:25 +0000)]
Enable PRI SERVICE message support in chan_dahdi for the 'national' switchtype

Revision 1072 of libpri added SERVICE message support for the 'national'
switchtype. The attached patch enables the use of 'pri service' CLI commands
on dahdi channels that are configured for the 'national' switchtype.

(closes issue #17142)
Reported by: dhubbard
Patches:
      dw-ni2.patch uploaded by dhubbard (license 733)
Tested by: elguero, dhubbard

Review: https://reviewboard.asterisk.org/r/612/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257642 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 257544 via svnmerge from
Tilghman Lesher [Thu, 15 Apr 2010 21:26:19 +0000 (21:26 +0000)]
Merged revisions 257544 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r257544 | tilghman | 2010-04-15 16:23:24 -0500 (Thu, 15 Apr 2010) | 6 lines

  Allow application options with arguments to contain parentheses, through a variety of escaping techniques.

  Fixes SWP-1194 (ABE-2143).

  Review: https://reviewboard.asterisk.org/r/604/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257560 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 257467 via svnmerge from
Tilghman Lesher [Thu, 15 Apr 2010 20:30:15 +0000 (20:30 +0000)]
Merged revisions 257467 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r257467 | tilghman | 2010-04-15 15:24:50 -0500 (Thu, 15 Apr 2010) | 13 lines

  Don't recreate peer, when responding to a repeated deregistration attempt.

  When a reply to a deregistration is lost in transmit, the client retries the
  deregistration.  Previously, this would cause a realtime/autocreate peer to be
  loaded back into memory, after it had already been correctly purged.  Instead,
  we just want to resend the reply without loading the peer.

  (closes issue #16908)
   Reported by: kkm
   Patches:
         20100412__issue16908.diff.txt uploaded by tilghman (license 14)
   Tested by: kkm
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257493 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 257426 via svnmerge from
Leif Madsen [Thu, 15 Apr 2010 19:41:05 +0000 (19:41 +0000)]
Merged revisions 257426 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r257426 | lmadsen | 2010-04-15 14:40:33 -0500 (Thu, 15 Apr 2010) | 13 lines

  Update backtrace.txt documentation.

  Update the backtrace.txt documentation so it conforms to the same layout as
  other documents we've been working on recently. Additionally, add a bunch of
  new information about gathering backtraces for crashes and deadlocks, along
  with ways of verifying your file before uploading it. Create a couple of one
  line commands for people to generate the files we need.

  (closes issue #17190)
  Reported by: lmadsen
  Patches:
        backtrace.txt.patch-2 uploaded by lmadsen (license 10)
  Tested by: lmadsen, pabelanger
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257427 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 257342 via svnmerge from
Leif Madsen [Thu, 15 Apr 2010 13:44:38 +0000 (13:44 +0000)]
Merged revisions 257342 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r257342 | lmadsen | 2010-04-15 08:41:45 -0500 (Thu, 15 Apr 2010) | 1 line

  Update address of the bug tracker.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257343 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBlocked revisions 257266 via svnmerge
Tilghman Lesher [Wed, 14 Apr 2010 23:08:52 +0000 (23:08 +0000)]
Blocked revisions 257266 via svnmerge

........
  r257266 | tilghman | 2010-04-14 18:08:11 -0500 (Wed, 14 Apr 2010) | 10 lines

  When forwarding a message, ensure that prepending works correctly.

  This is a regression in 1.4, only.

  (closes issue #17103)
   Reported by: mglazer
   Patches:
         20100408__issue17103.diff.txt uploaded by tilghman (license 14)
   Tested by: tilghman
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257267 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoYet another issue where the conversion of the application delimiter to comma caused...
Tilghman Lesher [Wed, 14 Apr 2010 22:57:35 +0000 (22:57 +0000)]
Yet another issue where the conversion of the application delimiter to comma caused an issue.

Application arguments within the feature map could possibly contain a comma,
which conflicts with the syntax of the features.conf configuration file.  This
patch allows the argument to be wrapped in parentheses or quoted, to allow the
application arguments to be interpreted as a single configuration parameter.

(closes issue #16646)
 Reported by: pinga-fogo
 Patches:
       20100414__issue16646.diff.txt uploaded by tilghman (license 14)
 Tested by: tilghman

Review: https://reviewboard.asterisk.org/r/547/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257262 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAlso unref the pvt when we delete the provisional keepalive job.
Tilghman Lesher [Tue, 13 Apr 2010 19:17:48 +0000 (19:17 +0000)]
Also unref the pvt when we delete the provisional keepalive job.

(closes issue #16774)
 Reported by: kowalma
 Patches:
       20100315__issue16774.diff.txt uploaded by tilghman (license 14)
 Tested by: falves11, jamicque

Review: https://reviewboard.asterisk.org/r/591/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257191 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 257070 via svnmerge from
Matthew Nicholson [Tue, 13 Apr 2010 18:10:30 +0000 (18:10 +0000)]
Merged revisions 257070 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r257070 | mnicholson | 2010-04-13 11:46:30 -0500 (Tue, 13 Apr 2010) | 9 lines

  Add an option to restore past broken behavor of the Events manager action

  Before r238915, certain values for the EventMask parameter of the Events action would result in no response being returned.  This patch adds an option to restore that broken behavior.  Also while fixing this bug I discovered that passing an empty EventMasks parameter would also result in no response being returned, this has been fixed as well while being preserved when the broken behavior is requested.

  (closes issue #17023)
  Reported by: nblasgen

  Review: https://reviewboard.asterisk.org/r/602/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257146 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoEnsure that we can have commas within cdr values.
Tilghman Lesher [Tue, 13 Apr 2010 16:33:21 +0000 (16:33 +0000)]
Ensure that we can have commas within cdr values.

(closes issue #17001)
 Reported by: snuffy
 Patches:
       20100412__issue17001.diff.txt uploaded by tilghman (license 14)
 Tested by: snuffy

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257065 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate sample dialstrings in sip.conf.sample file.
Mark Michelson [Tue, 13 Apr 2010 16:18:16 +0000 (16:18 +0000)]
Update sample dialstrings in sip.conf.sample file.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257032 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAddress Russell's comments on func_srv from reviewboard.
Mark Michelson [Tue, 13 Apr 2010 16:15:36 +0000 (16:15 +0000)]
Address Russell's comments on func_srv from reviewboard.

* Change copyright date
* Place channel in autoservice when doing SRV lookup
* Get rid of trailing whitespace
* Change logic in load_module function

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@257025 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix issue where recall would not happen when it should.
Mark Michelson [Mon, 12 Apr 2010 22:27:07 +0000 (22:27 +0000)]
Fix issue where recall would not happen when it should.

Specifically, the situation would happen when multiple
callers would request CC for a single generically-monitored
device. If the monitored device became available but the
caller did not answer the recall, then there was nothing
that would poke the CC core to let it know that it should
attempt to recall someone else instead.

After careful consideration, I came to the conclusion that
the only area of Asterisk that needed to be touched was the
generic CC monitor. All other types of CC would require something
outside of Asterisk to invoke a recall for a separate device.

This was accomplished by changing the generic monitor destructor
to poke other generic monitor instances if the device is currently
available and the specific instance was currently not suspended.

In order to not accidentally trigger recalls at bad times, the
fit_for_recall flag was also added to the generic_monitor_instance_list
struct. This gets set as soon as a monitored device becomes available.
It gets cleared if a CCNR request triggers the creation of a new
generic monitor instance. By doing this, we don't accidentally try
to recall a device when the monitored device was being monitored
for CCNR and never actually became available for recall in the first
place.

This error was discovered by Steve Pitts during in-house testing
at Digium.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@256985 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 256900 via svnmerge from
Leif Madsen [Mon, 12 Apr 2010 17:29:53 +0000 (17:29 +0000)]
Merged revisions 256900 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r256900 | lmadsen | 2010-04-12 12:29:26 -0500 (Mon, 12 Apr 2010) | 15 lines

  Add How-To document on collecting debugging info for issues.asterisk.org

  Paul Belanger has been helping a lot with bug tracking recently and created
  this document that we can now point to when additional debugging information
  is required. This document will help those filing issues to know how to get
  the information required when filing their issues. This will make things
  easier on the developers.

  Initial text and changes by pabelanger. Tweaks and editing by myself.

  (closes issue #17159)
  Reported by: pabelanger
  Patches:
        HOWTO_collect_debug_information.txt.patch uploaded by lmadsen (license 10)
  Tested by: tzafrir, pabelanger, lmadsen
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@256901 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRemove silly debug message that is not useful.
Leif Madsen [Mon, 12 Apr 2010 16:16:43 +0000 (16:16 +0000)]
Remove silly debug message that is not useful.

(issue #17159)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@256860 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agogives channel reference before unlocking it and using setvar helper.
David Vossel [Mon, 12 Apr 2010 14:47:16 +0000 (14:47 +0000)]
gives channel reference before unlocking it and using setvar helper.

To guarantee the channel is valid when calling setvar on the MASTER_CHANNEL
dialplan function, a channel reference must be taken before unlocking. Thanks
to russell for pointing out the error.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@256823 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoCLI command logger set level auto complete.
Leif Madsen [Mon, 12 Apr 2010 14:39:37 +0000 (14:39 +0000)]
CLI command logger set level auto complete.

A simple patch to enable auto tab complete.

(closes issue #17152)
Reported by: pabelanger
Patches:
      0017152.patch uploaded by pabelanger (license 224)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@256821 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agotest_substitution expects func_curl to be present to work.
Russell Bryant [Mon, 12 Apr 2010 02:19:02 +0000 (02:19 +0000)]
test_substitution expects func_curl to be present to work.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@256783 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd ASTERISK_FILE_VERSION() macro
Russell Bryant [Sun, 11 Apr 2010 22:04:01 +0000 (22:04 +0000)]
Add ASTERISK_FILE_VERSION() macro

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@256745 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofix hyphen vs. minus in man pages
Tzafrir Cohen [Sat, 10 Apr 2010 08:33:57 +0000 (08:33 +0000)]
fix hyphen vs. minus in man pages

In troff '-' is used for a hyphen. A minus is denoted by '\-' . This is
normally also used for a dash.

This patch converts all '-'-s that are minuses or dashes to '\-'.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@256704 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRemove status_response callbacks where they are not needed.
Mark Michelson [Fri, 9 Apr 2010 22:20:22 +0000 (22:20 +0000)]
Remove status_response callbacks where they are not needed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@256661 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoPrevent crash when originating a call to a local channel.
Mark Michelson [Fri, 9 Apr 2010 21:41:30 +0000 (21:41 +0000)]
Prevent crash when originating a call to a local channel.

Call completion code tries to grab the call completion parameters
from the requesting channel during local_request. When originating
a call to a local channel, however, this channel is NULL. This
was causing an issue for me when trying to run a test script.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@256646 65c4cc65-6c06-0410-ace0-fbb531ad65f3