asterisk/asterisk.git
13 years agochan_iax2 has an extremely large function, socket_process(), to handle incoming
Russell Bryant [Sat, 9 Dec 2006 07:10:55 +0000 (07:10 +0000)]
chan_iax2 has an extremely large function, socket_process(), to handle incoming
frames.  The function, before this commit, was roughly 1400 lines long.  So, I
am working on breaking this up into functions so that the code is easier to
follow and debug.  Also, I will be committing these changes in chunks as I do
them to ease tracking down any potentially introduced problems.

Break out roughly 150 lines from socket_process() and introduce a new function,
socket_process_meta() which handles the parsing of an incoming meta frame.
Also, restructure some of this code a bit to reduce the deep nesting that was
in this code.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48360 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years ago- Fix a few spelling mistakes
Russell Bryant [Sat, 9 Dec 2006 05:04:38 +0000 (05:04 +0000)]
- Fix a few spelling mistakes
- Use sizeof() to pass an array size to a function
- Use a single bit for a variable in the chan_iax2_pvt stuct since that is all
  it needs.
- Add some comments about the iaxs, iaxl, and lastused arrays.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48359 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48357 via svnmerge from
Russell Bryant [Thu, 7 Dec 2006 18:21:21 +0000 (18:21 +0000)]
Merged revisions 48357 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48357 | russell | 2006-12-07 13:17:28 -0500 (Thu, 07 Dec 2006) | 11 lines

Merged revisions 48356 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48356 | russell | 2006-12-07 13:14:13 -0500 (Thu, 07 Dec 2006) | 3 lines

Ensure that the file position is not incremented beyond the total number of
files available for playback.  (issue #8539, ulogic)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48358 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years ago- Generalize the function ssl_setup() so that the certificate info
Luigi Rizzo [Thu, 7 Dec 2006 16:42:29 +0000 (16:42 +0000)]
- Generalize the function ssl_setup() so that the certificate info
  are passed as an argument.

- Update the code in main/http.c to use the new interface
  (the diff is large but mostly mechanical, due to the name change of
  several variables);

- And since now it is trivial, implement "AMI over TLS", and document
  the possible options in manager.conf

- And since the test client (openssl s_client -connect host:port )
  does not generate \r\n as a line terminator, make get_input()
  also accept just a \n as a line terminator (Mac users: do you
  also need the \r-only version ?)

The option parsing in manager.conf is not very efficient, and needs
to be cleaned up and made similar to what we have in http.conf

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48351 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 47986,47995,47997,48001,48003-48004,48008-48014,48016,48018-48019...
Steve Murphy [Thu, 7 Dec 2006 16:03:56 +0000 (16:03 +0000)]
Merged revisions 47986,47995,47997,48001,48003-48004,48008-48014,48016,48018-48019 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r47986 | oej | 2006-11-24 07:00:19 -0700 (Fri, 24 Nov 2006) | 6 lines

Doxygen update
- Document cause codes
- Document a bit more on channel variables - global, predefined and local
- Fix some doxygen in channel.h. Adding one comment for two definitions does not
  work. They won't be copied to each.

................
r47995 | murf | 2006-11-24 10:40:49 -0700 (Fri, 24 Nov 2006) | 1 line

This fix inspired by a patch supplied in bug 8189, which points out problems with the PLC code
................
r47997 | murf | 2006-11-24 11:17:25 -0700 (Fri, 24 Nov 2006) | 1 line

removed the svnmerge-integrated property from trunk; it's confusing svnmerge in newly created branches
................
r48001 | rizzo | 2006-11-25 02:02:42 -0700 (Sat, 25 Nov 2006) | 5 lines

set pointers to NULL after freeing memory to avoid multiple free()

probably 1.4/1.2 issue as well if someone can look into that.

................
r48003 | oej | 2006-11-25 02:45:57 -0700 (Sat, 25 Nov 2006) | 9 lines

- Adding comment on suspicious memory allocation. Seems like it's never freed, but I don't
  have a clear understanding of the frame allocation/deallocation, so I just mark this
  for investigation. (Reported by Ed Guy). We're trying to see if a free() hurts...

- Doxygen comments on p2p rtp bridge stuff.  I am a bit worried about shortcutting
  rtcp this way, but will need feedback from rtcp gurus. This should work for
  video calls too, and possibly UDPTL.

................
r48004 | oej | 2006-11-25 02:48:30 -0700 (Sat, 25 Nov 2006) | 2 lines

Changing ERROR to lesser level. Imported from 1.2/1.4

................
r48008 | rizzo | 2006-11-25 10:37:04 -0700 (Sat, 25 Nov 2006) | 7 lines

generalize a bit the functions used to create an tcp socket
and then run a service on it.
The code in manager.c does essentially the same things,
so we will be able to reuse the code in here (probably
moving it to netsock.c or another appropriate library file).

................
r48009 | mattf | 2006-11-25 13:30:04 -0700 (Sat, 25 Nov 2006) | 1 line

Updates to show linkset command
................
r48010 | mattf | 2006-11-25 13:54:38 -0700 (Sat, 25 Nov 2006) | 2 lines

Add ss7 show linkset command

................
r48011 | mattf | 2006-11-25 14:32:33 -0700 (Sat, 25 Nov 2006) | 1 line

Make sure we don't send a group reset on a group larger than 32 CICs
................
r48012 | mattf | 2006-11-25 14:35:23 -0700 (Sat, 25 Nov 2006) | 1 line

bug fix
................
r48013 | mattf | 2006-11-25 14:46:58 -0700 (Sat, 25 Nov 2006) | 1 line

Make compiler happier
................
r48014 | mattf | 2006-11-25 14:50:42 -0700 (Sat, 25 Nov 2006) | 1 line

Little fix so we use the right message
................
r48016 | murf | 2006-11-25 17:15:42 -0700 (Sat, 25 Nov 2006) | 9 lines

Merged revisions 48015 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48015 | murf | 2006-11-25 17:01:34 -0700 (Sat, 25 Nov 2006) | 1 line

A little bit of func_cdr documentation upgrade-- no bug# involved, although 8221 may have inspired it.
........

................
r48018 | murf | 2006-11-25 17:31:13 -0700 (Sat, 25 Nov 2006) | 9 lines

Merged revisions 48017 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48017 | murf | 2006-11-25 17:26:16 -0700 (Sat, 25 Nov 2006) | 1 line

might as well also document the raw values of the flag vars
........

................
r48019 | russell | 2006-11-25 23:55:33 -0700 (Sat, 25 Nov 2006) | 6 lines

- Add some comments on thread storage with a brief explanation of what it is
  as well as what the motivation is for using it.
- Add a comment by the declaration of ast_inet_ntoa() noting that this function
  is not reentrant, and the result of a previous call to the function is no
  longer valid after calling it again.

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48350 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove duplicated code to start the server threads, use
Luigi Rizzo [Wed, 6 Dec 2006 20:46:01 +0000 (20:46 +0000)]
remove duplicated code to start the server threads, use
the infrastructure exposed in http.c earlier today.

As a bonus, now we can restart the session on a different
port just reloading the module.

On passing, fix a bug in the handling of 'enabled' in the configuration
file - previously, a missing "enabled=" line in manager.conf meant
"whatever the state was before" instead of a specific value.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48338 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoPart of the transformations necessary to add TLS support,
Luigi Rizzo [Wed, 6 Dec 2006 18:45:19 +0000 (18:45 +0000)]
Part of the transformations necessary to add TLS support,
as described in
http://lists.digium.com/pipermail/asterisk-dev/2006-December/025213.html

In detail, this commit does the following:

b) change the function get_input() to use fread() instead of read()
   to collect the data. One can still do the ast_wait_for_input() on
   the original descriptor returned by accept().

c) change the function send_string() to work on the FILE *.
   As a side effect, this change now really guarantees that
   we don't spend more than "writetimeout" milliseconds on
   each line sent.

d) modify the function action_command() so that it creates a
   temporary file descriptor to be passed to ast_cli_command(),
   and then read back the data from the temp file and write it
   to the output with send_string(). The code is similar to
   what is done in generic_http_callback() to support AMI-over-HTTP.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48332 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoHandle multiple 487's correctly
Olle Johansson [Wed, 6 Dec 2006 16:54:27 +0000 (16:54 +0000)]
Handle multiple 487's correctly

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48327 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48323 via svnmerge from
Russell Bryant [Wed, 6 Dec 2006 16:19:01 +0000 (16:19 +0000)]
Merged revisions 48323 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48323 | russell | 2006-12-06 11:15:45 -0500 (Wed, 06 Dec 2006) | 11 lines

Merged revisions 48322 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48322 | russell | 2006-12-06 11:05:54 -0500 (Wed, 06 Dec 2006) | 3 lines

Fix the name of the rtignoreregexpire option in the sample configuration file.
(issue #8526, arkadia)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48325 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMake externally visible some generic code useful to create
Luigi Rizzo [Wed, 6 Dec 2006 16:17:57 +0000 (16:17 +0000)]
Make externally visible some generic code useful to create
and implement services over tcp and/or tcp-tls.

This commit is nothing more than moving structure definitions
(and documentation) from main/http.c to include/asterisk/http.h
(temporary location until we find a better place), and removing the
'static' qualifier from server_root() and server_start().

The name change (adding the ast_ prefix as a minimum, and then
possibly a more meaningful name) is postponed to future commits.

Does not apply to other versions of asterisk.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48324 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDon't send Contact in SIP Messages (imported from 1.2/1.4).
Olle Johansson [Wed, 6 Dec 2006 12:34:58 +0000 (12:34 +0000)]
Don't send Contact in SIP Messages (imported from 1.2/1.4).
Reported by Gunnar at Omnitor.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48318 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoResolve some pointer signedness compiler warnings in app_osplookup, and
Russell Bryant [Wed, 6 Dec 2006 07:39:39 +0000 (07:39 +0000)]
Resolve some pointer signedness compiler warnings in app_osplookup, and
constify a bunch of usage strings for CLI commands.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48307 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoConstify a bunch of usage strings for CLI commands.
Russell Bryant [Wed, 6 Dec 2006 07:35:31 +0000 (07:35 +0000)]
Constify a bunch of usage strings for CLI commands.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48306 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoConstify a bunch of usage strings for CLI commands.
Russell Bryant [Wed, 6 Dec 2006 07:31:28 +0000 (07:31 +0000)]
Constify a bunch of usage strings for CLI commands.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48305 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoStaticize one, and Constify a bunch of usage strings for CLI commands.
Russell Bryant [Wed, 6 Dec 2006 07:28:56 +0000 (07:28 +0000)]
Staticize one, and Constify a bunch of usage strings for CLI commands.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48303 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoConstify a bunch of the usage strings for CLI commands.
Russell Bryant [Wed, 6 Dec 2006 07:23:32 +0000 (07:23 +0000)]
Constify a bunch of the usage strings for CLI commands.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48302 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoInstead of creating an unused instance of an unnamed enum, give it a name.
Russell Bryant [Wed, 6 Dec 2006 07:16:09 +0000 (07:16 +0000)]
Instead of creating an unused instance of an unnamed enum, give it a name.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48300 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMake the "usage" member of the ast_cli_entry struct const to resolve a compiler
Russell Bryant [Wed, 6 Dec 2006 07:15:16 +0000 (07:15 +0000)]
Make the "usage" member of the ast_cli_entry struct const to resolve a compiler
warning.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48299 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 48281 via svnmerge
Jason Parker [Tue, 5 Dec 2006 20:52:37 +0000 (20:52 +0000)]
Blocked revisions 48281 via svnmerge

........
r48281 | file | 2006-12-05 14:45:28 -0600 (Tue, 05 Dec 2006) | 2 lines

Regenerate configure from Qwell's last commit.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48283 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoRegenerate configure for Qwell's last commit.
Joshua Colp [Tue, 5 Dec 2006 20:46:26 +0000 (20:46 +0000)]
Regenerate configure for Qwell's last commit.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48282 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48279 via svnmerge from
Jason Parker [Tue, 5 Dec 2006 20:44:12 +0000 (20:44 +0000)]
Merged revisions 48279 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48279 | qwell | 2006-12-05 14:42:52 -0600 (Tue, 05 Dec 2006) | 4 lines

Fix curl version number testing to be much more friendly to non-bash shells.

Issue 8508, patch by me.  This *SHOULD* be POSIX compliant now..

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48280 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDoxygen updates
Olle Johansson [Tue, 5 Dec 2006 20:39:13 +0000 (20:39 +0000)]
Doxygen updates

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48277 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoExpand on r48273 (from issue 8506), to translate more of the fskmodem stuff to English.
Jason Parker [Tue, 5 Dec 2006 20:15:37 +0000 (20:15 +0000)]
Expand on r48273 (from issue 8506), to translate more of the fskmodem stuff to English.

r48273 dealt with the comments and such, this deals with the code itself.
(This couldn't have been easily done if it weren't for 48273 - thanks again for that merbanan)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48276 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoIssue #8506 - translate spanish comments in fskmodem to english (according to bug...
Olle Johansson [Tue, 5 Dec 2006 19:41:26 +0000 (19:41 +0000)]
Issue #8506 - translate spanish comments in fskmodem to english (according to bug guidelines)
Thanks merbanan!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48273 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocking invitestate patch that is already merged to svn trunk.
Olle Johansson [Tue, 5 Dec 2006 17:34:55 +0000 (17:34 +0000)]
Blocking invitestate patch that is already merged to svn trunk.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48271 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdding docs on t.38
Olle Johansson [Tue, 5 Dec 2006 16:48:15 +0000 (16:48 +0000)]
Adding docs on t.38

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48269 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years ago1. Change to remove the compiling warning: "app_osplookup.c:2169: warning: initializa...
TransNexus OSP Development [Tue, 5 Dec 2006 14:33:21 +0000 (14:33 +0000)]
1. Change to remove the compiling warning: "app_osplookup.c:2169: warning: initialization discards qualifiers from pointer target type"

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48266 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoWell, yes...
Olle Johansson [Tue, 5 Dec 2006 11:09:23 +0000 (11:09 +0000)]
Well, yes...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48259 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoReserving flags for coming code (currently in the "videocaps" branch)
Olle Johansson [Tue, 5 Dec 2006 10:52:53 +0000 (10:52 +0000)]
Reserving flags for coming code (currently in the "videocaps" branch)
implementing T.140 support in RTP.

T.140/RFC 4351 is TDD over IP - text telephony for hearing impaired.
It defines a realtime text chat, much like the old "talk" application
in Unix.

T.140 is character by character in real time. It's not
the same as our current MESSAGE format - that is more like IM, but
can be gatewayed to MESSAGE with a text "codec" if needed.

More patches will follow, as soon as we've separated this code from
the video capabilities functions in the videocaps branch.

Code by John Martin, Aupix (disclaimer on file)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48258 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48254 via svnmerge from
Tilghman Lesher [Tue, 5 Dec 2006 01:46:14 +0000 (01:46 +0000)]
Merged revisions 48254 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48254 | tilghman | 2006-12-04 19:41:02 -0600 (Mon, 04 Dec 2006) | 2 lines

Oops, forgot to release the odbc handle

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48255 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48252 via svnmerge from
Tilghman Lesher [Tue, 5 Dec 2006 01:39:53 +0000 (01:39 +0000)]
Merged revisions 48252 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48252 | tilghman | 2006-12-04 19:34:34 -0600 (Mon, 04 Dec 2006) | 14 lines

Merged revisions 48251 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48251 | tilghman | 2006-12-04 19:26:08 -0600 (Mon, 04 Dec 2006) | 6 lines

If the recording in the database is too large, it will fail to retrieve with
an mmap error.  Not too sure why this doesn't happen when we put it in the
database, also, but since that doesn't seem to be broken, I'm not going to fix
it (at least until someone reports it).  Solution is to ask for the file in
smaller chunks.  (Bug 8385)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48253 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48248 via svnmerge from
Jason Parker [Mon, 4 Dec 2006 21:49:38 +0000 (21:49 +0000)]
Merged revisions 48248 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48248 | qwell | 2006-12-04 15:48:41 -0600 (Mon, 04 Dec 2006) | 2 lines

Fix an issue which didn't allow unavail/greet/busy/etc messages from being saved into ODBC (and probably IMAP).

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48249 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 48234 via svnmerge
Joshua Colp [Mon, 4 Dec 2006 18:18:07 +0000 (18:18 +0000)]
Blocked revisions 48234 via svnmerge

................
r48234 | file | 2006-12-04 13:16:31 -0500 (Mon, 04 Dec 2006) | 9 lines

Blocked revisions 48233 via svnmerge

........
r48233 | file | 2006-12-04 13:14:46 -0500 (Mon, 04 Dec 2006) | 2 lines

If the generic bridge tells us not to retry, and we have a frame to spit out then break the bridge. Props to markit in #asterisk-bugs for bringing this up.

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48235 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48230 via svnmerge from
Jason Parker [Mon, 4 Dec 2006 17:55:38 +0000 (17:55 +0000)]
Merged revisions 48230 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48230 | qwell | 2006-12-04 11:54:46 -0600 (Mon, 04 Dec 2006) | 4 lines

Add documentation to voicemail.conf.sample for ODBC storage.

Issue 8499 - patch by blitzrage.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48231 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48228 via svnmerge from
Jason Parker [Mon, 4 Dec 2006 17:44:12 +0000 (17:44 +0000)]
Merged revisions 48228 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48228 | qwell | 2006-12-04 11:43:24 -0600 (Mon, 04 Dec 2006) | 4 lines

Attempt to document some of the dependencies that are needed for net-snmp

Issue 8499 - initial patch by blitzrage.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48229 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48223 via svnmerge from
Russell Bryant [Sun, 3 Dec 2006 06:35:46 +0000 (06:35 +0000)]
Merged revisions 48223 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48223 | russell | 2006-12-03 01:34:14 -0500 (Sun, 03 Dec 2006) | 3 lines

When "fetch" is in use, instead of "wget", --continue is not a valid option.
(issue #8451)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48224 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoCleaning up handle_response a bit. (Imported from 1.4)
Olle Johansson [Sat, 2 Dec 2006 22:03:14 +0000 (22:03 +0000)]
Cleaning up handle_response a bit. (Imported from 1.4)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48220 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoRemoving two .h files means we need to update cleancount to force
Olle Johansson [Sat, 2 Dec 2006 20:50:54 +0000 (20:50 +0000)]
Removing two .h files means we need to update cleancount to force
make depend again (or ?)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48217 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoSend CANCEL to call with early media (PROGRESS INBAND).
Olle Johansson [Sat, 2 Dec 2006 20:30:58 +0000 (20:30 +0000)]
Send CANCEL to call with early media (PROGRESS INBAND).
This is imported from branch "invitestate" and "invitestate-1.4"

***
***
*** IF YOU HAVE ISSUES WITH BYEs/CANCELs - PLEASE UPDATE AND TEST AGAIN!
***  Thank you!
***
***

/Olle

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48216 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoInvitestate updates
Olle Johansson [Sat, 2 Dec 2006 19:11:02 +0000 (19:11 +0000)]
Invitestate updates

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48213 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoOops.
Olle Johansson [Sat, 2 Dec 2006 17:40:58 +0000 (17:40 +0000)]
Oops.
Something is wrong in the agi directory. Asking for autoconfig.h.
I have it disabled locally, but no reason to commit that change.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48208 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDoxygenification
Olle Johansson [Sat, 2 Dec 2006 14:07:20 +0000 (14:07 +0000)]
Doxygenification

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48206 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years ago- Code formatting
Olle Johansson [Sat, 2 Dec 2006 13:40:13 +0000 (13:40 +0000)]
- Code formatting
- remove coef_in.h and coef_out.h that was only included as data definitions in fskmodem.c

If you understand spanish, please help us translate the comments in fskmodem.c. Thanks!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48205 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years ago- Disable RTP timeouts during T.38 transmission
Olle Johansson [Sat, 2 Dec 2006 12:05:40 +0000 (12:05 +0000)]
- Disable RTP timeouts during T.38 transmission
- Encapsulate RTP timers to the RTP structure, so we have one set for video and one for audio
- Document RTP keepalive configuration option
- Cleanup and document the monitor support function to hangup on RTP timeouts
- Add RTP keepalive to SIP show settings

Imported from 1.4 with modifications for trunk.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48200 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 48195 via svnmerge
Russell Bryant [Sat, 2 Dec 2006 03:53:02 +0000 (03:53 +0000)]
Blocked revisions 48195 via svnmerge

........
r48195 | russell | 2006-12-01 22:50:58 -0500 (Fri, 01 Dec 2006) | 3 lines

Backport the comment containing the warning regarding the limitations on the
usage of this function.  It is thread safe, but not technically reentrant.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48196 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48193 via svnmerge from
Kevin P. Fleming [Fri, 1 Dec 2006 23:39:59 +0000 (23:39 +0000)]
Merged revisions 48193 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48193 | kpfleming | 2006-12-01 17:37:28 -0600 (Fri, 01 Dec 2006) | 10 lines

Merged revisions 48192 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48192 | kpfleming | 2006-12-01 17:30:59 -0600 (Fri, 01 Dec 2006) | 2 lines

if Dial() is going to send music-on-hold to the calling party, it has to send PROGRESS first to ensure that the reverse audio path has been setup first (BE-106)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48194 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48190 via svnmerge from
Russell Bryant [Fri, 1 Dec 2006 23:20:17 +0000 (23:20 +0000)]
Merged revisions 48190 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48190 | russell | 2006-12-01 18:16:28 -0500 (Fri, 01 Dec 2006) | 12 lines

FreeBSD 6.1 does not include wget by default.  However, it has fetch which will
work just fine for our purposes of downloading the sounds packages.  So, check
for both wget and fetch and the configure script and use what was found to
download them.  If neither one was found, and sound packages are selected that
must be downloaded, the install process will print out an informative error
message indicating the situation.

Also, fix a couple places where "make" was hard coded into some output messages
by replacing them with the $(MAKE) variable.

(issue #8451, initial patch by pabelanger, with additional modifications by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48191 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFormatting fix
Olle Johansson [Fri, 1 Dec 2006 20:49:06 +0000 (20:49 +0000)]
Formatting fix

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48188 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48186 via svnmerge from
Jason Parker [Fri, 1 Dec 2006 20:26:44 +0000 (20:26 +0000)]
Merged revisions 48186 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48186 | qwell | 2006-12-01 14:25:51 -0600 (Fri, 01 Dec 2006) | 10 lines

Merged revisions 48183 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48183 | qwell | 2006-12-01 14:19:10 -0600 (Fri, 01 Dec 2006) | 2 lines

Fix a small typo - issue 8848, reported by pabelanger

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48187 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48179 via svnmerge from
Tilghman Lesher [Fri, 1 Dec 2006 19:41:02 +0000 (19:41 +0000)]
Merged revisions 48179 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48179 | tilghman | 2006-12-01 13:38:59 -0600 (Fri, 01 Dec 2006) | 2 lines

Double-unlock error (reported by blitzrage on IRC)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48180 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years ago- Remove T.38 early media, since T.38 requires two way communication (imported from...
Olle Johansson [Fri, 1 Dec 2006 18:16:16 +0000 (18:16 +0000)]
- Remove T.38 early media, since T.38 requires two way communication (imported from 1.4)
- Small fixes to limitonpeer

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48178 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoTiny doxygen improvement
Olle Johansson [Fri, 1 Dec 2006 17:33:56 +0000 (17:33 +0000)]
Tiny doxygen improvement

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48175 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48168 via svnmerge from
Joshua Colp [Thu, 30 Nov 2006 21:22:01 +0000 (21:22 +0000)]
Merged revisions 48168 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48168 | file | 2006-11-30 16:18:24 -0500 (Thu, 30 Nov 2006) | 2 lines

Do not do a partial bridge for Google Talk since we need to handle STUN. (issue #8448 reported by phsultan)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48169 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoIssue #8319 (imported from 1.2, 1.4) - Increment nonce-count properly (noriyuki)
Olle Johansson [Thu, 30 Nov 2006 20:55:43 +0000 (20:55 +0000)]
Issue #8319 (imported from 1.2, 1.4) - Increment nonce-count properly (noriyuki)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48167 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDocumentation updates
Olle Johansson [Thu, 30 Nov 2006 20:34:23 +0000 (20:34 +0000)]
Documentation updates

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48164 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 48162 via svnmerge
Joshua Colp [Thu, 30 Nov 2006 20:29:11 +0000 (20:29 +0000)]
Blocked revisions 48162 via svnmerge

................
r48162 | file | 2006-11-30 15:28:19 -0500 (Thu, 30 Nov 2006) | 9 lines

Blocked revisions 48161 via svnmerge

........
r48161 | file | 2006-11-30 15:27:29 -0500 (Thu, 30 Nov 2006) | 2 lines

Don't write AST_FRAME_NULL or AST_FRAME_IAX frames out to the channel driver. (issue #8390 reported by hselasky)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48163 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48158 via svnmerge from
Joshua Colp [Thu, 30 Nov 2006 20:09:46 +0000 (20:09 +0000)]
Merged revisions 48158 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48158 | file | 2006-11-30 15:07:55 -0500 (Thu, 30 Nov 2006) | 10 lines

Merged revisions 48157 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48157 | file | 2006-11-30 15:06:43 -0500 (Thu, 30 Nov 2006) | 2 lines

Only print out debug message if bridged channel is not NULL. (issue #8412 reported by jubilex)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48160 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48155 via svnmerge from
Joshua Colp [Thu, 30 Nov 2006 19:06:22 +0000 (19:06 +0000)]
Merged revisions 48155 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48155 | file | 2006-11-30 14:05:14 -0500 (Thu, 30 Nov 2006) | 10 lines

Merged revisions 48154 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48154 | file | 2006-11-30 14:04:11 -0500 (Thu, 30 Nov 2006) | 2 lines

Do not listen for DTMF on the bridge that comes into existence when ParkedCall is executed. This means native bridging can now occur for this. (issue #8406 reported by kebl0155)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48156 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48152 via svnmerge from
Joshua Colp [Thu, 30 Nov 2006 18:49:59 +0000 (18:49 +0000)]
Merged revisions 48152 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48152 | file | 2006-11-30 13:47:40 -0500 (Thu, 30 Nov 2006) | 10 lines

Merged revisions 48151 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48151 | file | 2006-11-30 13:42:45 -0500 (Thu, 30 Nov 2006) | 2 lines

Print certain CDR messages out at the NOTICE level versus WARNING since they can occur when used with the CDR applications and are perfectly fine. (issue #8367 reported by dartvader)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48153 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoSmall update
Olle Johansson [Thu, 30 Nov 2006 18:25:51 +0000 (18:25 +0000)]
Small update

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48150 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDoxygen updates
Olle Johansson [Thu, 30 Nov 2006 18:22:10 +0000 (18:22 +0000)]
Doxygen updates

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48149 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 48147 via svnmerge
Joshua Colp [Thu, 30 Nov 2006 18:20:57 +0000 (18:20 +0000)]
Blocked revisions 48147 via svnmerge

................
r48147 | file | 2006-11-30 13:19:55 -0500 (Thu, 30 Nov 2006) | 9 lines

Blocked revisions 48146 via svnmerge

........
r48146 | file | 2006-11-30 13:17:54 -0500 (Thu, 30 Nov 2006) | 2 lines

Remember the pointer to the allocated block of memory so that we can free it and not cause a memory leak. (issue #8449 reported by arkadia)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48148 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48143 via svnmerge from
Joshua Colp [Thu, 30 Nov 2006 17:58:53 +0000 (17:58 +0000)]
Merged revisions 48143 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48143 | file | 2006-11-30 12:57:35 -0500 (Thu, 30 Nov 2006) | 10 lines

Merged revisions 48142 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48142 | file | 2006-11-30 12:55:23 -0500 (Thu, 30 Nov 2006) | 2 lines

Document 'port' for SIP peers, came up because of the current mailing list thread. (issue #8450 reported by blitzrage)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48144 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdding some generic docs on extension and device states - watchers and providers
Olle Johansson [Thu, 30 Nov 2006 17:15:54 +0000 (17:15 +0000)]
Adding some generic docs on extension and device states - watchers and providers

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48139 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd information on status events
Olle Johansson [Thu, 30 Nov 2006 14:32:52 +0000 (14:32 +0000)]
Add information on status events

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48136 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerging patch from 1.2/1.4. I think this was originally spotted by
Olle Johansson [Thu, 30 Nov 2006 09:23:25 +0000 (09:23 +0000)]
Merging patch from 1.2/1.4. I think this was originally spotted by
Luigi, but hit me in the back today.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48130 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoI am pretty sure that oej only meant to change the variable name in the source, not...
Joshua Colp [Thu, 30 Nov 2006 03:29:42 +0000 (03:29 +0000)]
I am pretty sure that oej only meant to change the variable name in the source, not the configuration option name so let's turn it back to srvlookup instead of global_srvlookup. (issue #8442 reported by jtodd)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48123 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48115 via svnmerge from
Joshua Colp [Wed, 29 Nov 2006 21:07:14 +0000 (21:07 +0000)]
Merged revisions 48115 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48115 | file | 2006-11-29 16:05:17 -0500 (Wed, 29 Nov 2006) | 2 lines

Use MAILTMPLEN instead of sizeof in mm_login. (issue #8420 reported by slimey)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48116 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoClarify some settings for status reports in subscriptions, queues and manager
Olle Johansson [Wed, 29 Nov 2006 20:57:48 +0000 (20:57 +0000)]
Clarify some settings for status reports in subscriptions, queues and manager

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48114 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoExplain RTP timeouts
Olle Johansson [Wed, 29 Nov 2006 19:47:45 +0000 (19:47 +0000)]
Explain RTP timeouts

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48112 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoChange logging for p2p rtp bridge mode
Olle Johansson [Wed, 29 Nov 2006 19:44:06 +0000 (19:44 +0000)]
Change logging for p2p rtp bridge mode

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48111 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years ago- Fix a few spelling mistakes.
Russell Bryant [Wed, 29 Nov 2006 17:59:13 +0000 (17:59 +0000)]
- Fix a few spelling mistakes.
- Add some more documentation for the ast_dynamic_str_............() function
  to document the behavior of the function in the case of a partial write.
  Also, document the return value and note that the function should never need
  to be called directly.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48110 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoGo ahead and make this write unconditional. Making it conditional is more work
Russell Bryant [Wed, 29 Nov 2006 17:37:31 +0000 (17:37 +0000)]
Go ahead and make this write unconditional.  Making it conditional is more work
in both the append and non-append modes.  Also, always truncating the partial
write makes the behavior of the function more consistent, where in any type of
write, no partial result is left in the buffer.

Thanks for the feedback, luigi

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48109 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48107 via svnmerge from
Joshua Colp [Wed, 29 Nov 2006 16:53:27 +0000 (16:53 +0000)]
Merged revisions 48107 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48107 | file | 2006-11-29 11:50:33 -0500 (Wed, 29 Nov 2006) | 10 lines

Merged revisions 48106 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48106 | file | 2006-11-29 11:47:10 -0500 (Wed, 29 Nov 2006) | 2 lines

If the frame was duplicated before writing out then we need to free it. (issue #8429 reported by edguy3)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48108 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoRemove an XXX command suggesting that this truncation should not be conditional,
Russell Bryant [Wed, 29 Nov 2006 05:08:19 +0000 (05:08 +0000)]
Remove an XXX command suggesting that this truncation should not be conditional,
and also add a more verbose comment explaining why it is only needed in the
case of appending to the string for any curious readers that come along in the
future.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48103 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48101 via svnmerge from
Joshua Colp [Wed, 29 Nov 2006 04:28:21 +0000 (04:28 +0000)]
Merged revisions 48101 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48101 | file | 2006-11-28 23:26:53 -0500 (Tue, 28 Nov 2006) | 2 lines

Don't crash if the mailstream was not created.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48102 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoUse the proper version of extra sounds. (issue #8441 reported by jtodd)
Joshua Colp [Wed, 29 Nov 2006 03:12:16 +0000 (03:12 +0000)]
Use the proper version of extra sounds. (issue #8441 reported by jtodd)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48100 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd a comment to note near some code that performs a very expensive operation
Russell Bryant [Tue, 28 Nov 2006 23:13:37 +0000 (23:13 +0000)]
Add a comment to note near some code that performs a very expensive operation
that occurs for every incoming media frame.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48099 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoresolve a couple of compiler warnings
Russell Bryant [Tue, 28 Nov 2006 23:04:36 +0000 (23:04 +0000)]
resolve a couple of compiler warnings

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48098 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48095 via svnmerge from
Jason Parker [Tue, 28 Nov 2006 18:28:07 +0000 (18:28 +0000)]
Merged revisions 48095 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48095 | qwell | 2006-11-28 12:26:53 -0600 (Tue, 28 Nov 2006) | 2 lines

Export several more variables in top level Makefile.  Inspired by issue 8438.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48096 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agodon't use outputstr in the struct mansession, it's just
Luigi Rizzo [Tue, 28 Nov 2006 17:08:19 +0000 (17:08 +0000)]
don't use outputstr in the struct mansession, it's just
an extra allocation on a path where we have way too many already.

Unfortunately the AMI-over-HTTP requires multiple copies,
because we need to generate a header, then the raw output to
an intermediate buffer, then convert it to html/xml, and
finally copy everything into a malloc'ed buffer because
that's what the generic_http_callback interface expects.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48090 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48088 via svnmerge from
Joshua Colp [Tue, 28 Nov 2006 16:59:20 +0000 (16:59 +0000)]
Merged revisions 48088 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48088 | file | 2006-11-28 11:57:16 -0500 (Tue, 28 Nov 2006) | 10 lines

Merged revisions 48087 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48087 | file | 2006-11-28 11:56:01 -0500 (Tue, 28 Nov 2006) | 2 lines

According to the research I have done we never needed to include compiler.h in the first place so let's not! (issue #8430 reported by edguy3)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48089 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoinitialize the dynamic string in a sane way.
Luigi Rizzo [Tue, 28 Nov 2006 15:53:12 +0000 (15:53 +0000)]
initialize the dynamic string in a sane way.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48086 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agosome simplifications to
Luigi Rizzo [Tue, 28 Nov 2006 14:07:09 +0000 (14:07 +0000)]
some simplifications to
ast_dynamic_str_thread_build_va_couldnt_we_choose_a_shorter_name()

I am unsure whether the truncation of the string in case of a failed
attempt should be done unconditionally. See the XXX mark.

Russel, ideas ?

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48084 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agodo not return 500 Internal error if the AMI command provides
Luigi Rizzo [Tue, 28 Nov 2006 13:08:56 +0000 (13:08 +0000)]
do not return 500 Internal error if the AMI command provides
no output.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48083 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomosty comment and documentation cleanup on waitevent.
Luigi Rizzo [Tue, 28 Nov 2006 12:05:25 +0000 (12:05 +0000)]
mosty comment and documentation cleanup on waitevent.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48082 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMove the code to purge stale sessions to a function,
Luigi Rizzo [Tue, 28 Nov 2006 11:20:39 +0000 (11:20 +0000)]
Move the code to purge stale sessions to a function,
to simplify the body of the main loop of the accepting thread.
Rename purge_unused() to purge_events() so one knows what the
function does.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48081 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoVarious simplifications of the code:
Luigi Rizzo [Tue, 28 Nov 2006 10:23:25 +0000 (10:23 +0000)]
Various simplifications of the code:
+ use a wrapper around ast_carefulwrite(), used in two places,
  to make life easier when we decide to use a different interface
  to the socket.

+ put an ast_verbose() message on astman_append on a case that
  should never happen now that we use a temporary file for
  AMI-over-HTTP sessions

+ document and slightly simplify process_events() by removing
  unnecessary parentheses.

+ in get_input(), use ast_wait_for_input() instead of poll().

  We may want to move to a completely non-blocking

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48080 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMore informative message on invalid commands.
Luigi Rizzo [Tue, 28 Nov 2006 09:43:44 +0000 (09:43 +0000)]
More informative message on invalid commands.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48079 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoanother normalization of AMI vs HTTP identification.
Luigi Rizzo [Tue, 28 Nov 2006 09:39:16 +0000 (09:39 +0000)]
another normalization of AMI vs HTTP identification.
Should really define a macro IS_AMI(s) so it is clear what
we want to do.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48078 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoalways use managerid to determine whether this is an AMI or HTTP session,
Luigi Rizzo [Tue, 28 Nov 2006 09:27:37 +0000 (09:27 +0000)]
always use managerid to determine whether this is an AMI or HTTP session,
and document it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48077 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoIn the previous commit i forgot to set the poll_timeout to -1,
Luigi Rizzo [Tue, 28 Nov 2006 00:02:42 +0000 (00:02 +0000)]
In the previous commit i forgot to set the poll_timeout to -1,
causing the http threads to do busy waiting around the socket...

Fix the mistake, sorry for the inconvenience!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48074 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agodocument the support for running a server on TCP/TLS and
Luigi Rizzo [Mon, 27 Nov 2006 21:25:55 +0000 (21:25 +0000)]
document the support for running a server on TCP/TLS and
opening an SSL socket.

We are almost ready to make this code available to other modules.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48073 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoadd a new http.conf option, sslbindaddr.
Luigi Rizzo [Mon, 27 Nov 2006 20:21:40 +0000 (20:21 +0000)]
add a new http.conf option, sslbindaddr.
Because https is more secure than http, it usually
makes sense to keep this service more open than the
one on the unencrypted port.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48071 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoin the helper thread, separate the FILE * creation from the actual
Luigi Rizzo [Mon, 27 Nov 2006 19:19:48 +0000 (19:19 +0000)]
in the helper thread, separate the FILE * creation from the actual
function doing work on the socket. This is another generalization
to provide a generic mechanism to open TCP/TLS socket with a thread
managing the accpet and children threads managing the individual
sessions.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48067 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agostaticize a global variable and remove an unused field structure.
Luigi Rizzo [Mon, 27 Nov 2006 18:51:10 +0000 (18:51 +0000)]
staticize a global variable and remove an unused field structure.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48062 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48054 via svnmerge from
Joshua Colp [Mon, 27 Nov 2006 18:10:59 +0000 (18:10 +0000)]
Merged revisions 48054 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48054 | file | 2006-11-27 13:06:50 -0500 (Mon, 27 Nov 2006) | 10 lines

Merged revisions 48053 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48053 | file | 2006-11-27 13:03:57 -0500 (Mon, 27 Nov 2006) | 2 lines

Use the proper function to get the new message count instead of always using the filesystem. (issue #8421 reported by slimey)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48056 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 48049 via svnmerge from
Tilghman Lesher [Mon, 27 Nov 2006 17:31:56 +0000 (17:31 +0000)]
Merged revisions 48049 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48049 | tilghman | 2006-11-27 11:20:37 -0600 (Mon, 27 Nov 2006) | 10 lines

Merged revisions 48045 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48045 | tilghman | 2006-11-27 11:15:54 -0600 (Mon, 27 Nov 2006) | 2 lines

Random MOH wasn't really random (bug 8381)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48050 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 48046 via svnmerge
Russell Bryant [Mon, 27 Nov 2006 17:19:47 +0000 (17:19 +0000)]
Blocked revisions 48046 via svnmerge

........
r48046 | russell | 2006-11-27 12:17:40 -0500 (Mon, 27 Nov 2006) | 2 lines

Remove a couple of unused variables (issue #8380, casper)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48048 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMore fixes for referencing a structure after it has been freed. (issue #8425 reported...
Joshua Colp [Mon, 27 Nov 2006 15:48:57 +0000 (15:48 +0000)]
More fixes for referencing a structure after it has been freed. (issue #8425 reported by arkadia)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48040 65c4cc65-6c06-0410-ace0-fbb531ad65f3