asterisk/asterisk.git
12 years agoMerged revisions 77783 via svnmerge from
Tilghman Lesher [Mon, 30 Jul 2007 18:45:09 +0000 (18:45 +0000)]
Merged revisions 77783 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r77783 | tilghman | 2007-07-30 13:43:55 -0500 (Mon, 30 Jul 2007) | 10 lines

Merged revisions 77782 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r77782 | tilghman | 2007-07-30 13:40:54 -0500 (Mon, 30 Jul 2007) | 2 lines

Revert change in revision 71656, even though it fixed a bug, because many people were depending upon the (broken) behavior.

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77784 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77780 via svnmerge from
Russell Bryant [Mon, 30 Jul 2007 17:31:29 +0000 (17:31 +0000)]
Merged revisions 77780 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77780 | russell | 2007-07-30 12:29:43 -0500 (Mon, 30 Jul 2007) | 16 lines

(closes issue #10301)
Reported by: fnordian
Patches:
      asterisk-1.4.9-channel.c.patch uploaded by fnordian (license 110)
      Additional changes by me

Fix some problems in channel_find_locked() which can cause an infinite loop.
The reference to the previous channel is set to NULL in some cases.  These changes
ensure that the reference to the previous channel gets restored before needing
it again.

I'm not convinced that the code that is setting it to NULL is really the right
thing to do.  However, I am making these changes to fix the obvious problem
and just leaving an XXX comment that it needs a better explanation that what
is there now.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77781 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77778 via svnmerge from
Joshua Colp [Mon, 30 Jul 2007 17:12:58 +0000 (17:12 +0000)]
Merged revisions 77778 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77778 | file | 2007-07-30 14:11:02 -0300 (Mon, 30 Jul 2007) | 4 lines

(closes issue #10327)
Reported by: kkiely
Instead of directly mucking with the extension/context/priority of the channel we are transferring when it has a PBX simply call ast_async_goto on it. This will ensure that the channel gets handled properly and sent to the right place.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77779 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMinor clean up of app_followme.
Joshua Colp [Mon, 30 Jul 2007 16:02:01 +0000 (16:02 +0000)]
Minor clean up of app_followme.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77773 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77771 via svnmerge from
Joshua Colp [Mon, 30 Jul 2007 15:49:30 +0000 (15:49 +0000)]
Merged revisions 77771 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77771 | file | 2007-07-30 12:47:52 -0300 (Mon, 30 Jul 2007) | 6 lines

(closes issue #10301)
Reported by: fnordian
Patches:
      asterisk-1.4.9-channel.c.patch uploaded by fnordian (license 110)
Restore previous behavior where if we failed to lock the channel we wanted we would return to exactly the same point as if we had just reentered the function.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77772 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoResolve some compiler warnings so that I can build under dev mode
Russell Bryant [Mon, 30 Jul 2007 15:22:20 +0000 (15:22 +0000)]
Resolve some compiler warnings so that I can build under dev mode

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77770 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77768 via svnmerge from
Joshua Colp [Mon, 30 Jul 2007 14:53:14 +0000 (14:53 +0000)]
Merged revisions 77768 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r77768 | file | 2007-07-30 11:51:44 -0300 (Mon, 30 Jul 2007) | 12 lines

Merged revisions 77767 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r77767 | file | 2007-07-30 11:50:02 -0300 (Mon, 30 Jul 2007) | 4 lines

(closes issue #10334)
Reported by: ramonpeek
Pass through the return value from macro_exec through the MacroIf application.

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77769 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agominor code rearrangements:
Luigi Rizzo [Mon, 30 Jul 2007 10:55:37 +0000 (10:55 +0000)]
minor code rearrangements:
+ place the link field at the beginning of struct sip_pvt,
  and not somewhere in the middle;

+ in __sip_reliable_xmit, remove a duplicate assignment, and
  put the statements in a more logical order (i.e. first copy
  the payload and associated info, then copy arguments from the
  caller, then finish initializing the headers...)

nothing to backport.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77766 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agorename handle_request() to handle_incoming(), as the former
Luigi Rizzo [Mon, 30 Jul 2007 08:07:00 +0000 (08:07 +0000)]
rename handle_request() to handle_incoming(), as the former
was misleading - the function deals with all incoming packets, be
them requests or responses.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77753 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomove some dialog-only flags to proper variables, namely
Luigi Rizzo [Sun, 29 Jul 2007 21:24:56 +0000 (21:24 +0000)]
move some dialog-only flags to proper variables, namely
SIP_NOVIDEO, SIP_DIALOG_ANSWEREDELSEWHERE, SIP_PAGE2_NOTEXT,
SIP_PAGE2_OUTGOING_CALL
These are seldom used so the diff is relatively small.

Note that 'OUTGOING_CALL' is dangerously similar to another
dialog flag, 'SIP_OUTGOING', so the description will need to
clarify the different meaning of the two.

Also note that the description of NOTEXT is a bit unclear - does
it mean we don't support it, or 'not requested or not supported' ?

On passing fix a comment referring to video instead of text.

Finally, mark with XXX a possibly misleading debugging message.
(maybe the latter is worth backporting).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77739 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agouse a function, cli_yesno(), to produce the output Yes or No for
Luigi Rizzo [Sun, 29 Jul 2007 20:55:20 +0000 (20:55 +0000)]
use a function, cli_yesno(), to produce the output Yes or No for
CLI lines. This helps maintaining consistency on output, slightly
improves readability, and maybe one day will make it easier to
translate the output in other languages (though i have a hard time
believing that a CLI user who needs 'yes' and 'no' to be translated
can actually figure out what he/she is doing!)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77726 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomove the two remaining peer flags to proper variables.
Luigi Rizzo [Sun, 29 Jul 2007 20:28:02 +0000 (20:28 +0000)]
move the two remaining peer flags to proper variables.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77725 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomove RT_FROMCONTACT to a proper sip_peer field.
Luigi Rizzo [Sun, 29 Jul 2007 20:13:32 +0000 (20:13 +0000)]
move RT_FROMCONTACT to a proper sip_peer field.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77712 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMove some global 'flags' to individual variables.
Luigi Rizzo [Sun, 29 Jul 2007 20:01:36 +0000 (20:01 +0000)]
Move some global 'flags' to individual variables.

Start putting these variables in a single struct (called 'sip_cfg' for the time
being, but it could as well be 'global' or some other name) so it
is easy, when reading the code, to figure out what they are for.

The downside of using struct fields instead of individual global
variables is that the compiler cannot tell if there are unused fields.
But the advantage of not cluttering the namespace and manilpulating
all these variables at once certainly overcome the disadvantagess.

Nothing to backport, again.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77711 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agominor simplification of a conditional statement
Luigi Rizzo [Sun, 29 Jul 2007 10:49:32 +0000 (10:49 +0000)]
minor simplification of a conditional statement

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77697 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agobuild the version of sip_tech with no send_digit_begin
Luigi Rizzo [Sun, 29 Jul 2007 10:13:14 +0000 (10:13 +0000)]
build the version of sip_tech with no send_digit_begin
at load time instead of duplicating the initializer.
This should remove the risk of forgetting fields in the
initializer.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77684 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoremove bit position from description of SIP_* flags.
Luigi Rizzo [Sun, 29 Jul 2007 09:27:30 +0000 (09:27 +0000)]
remove bit position from description of SIP_* flags.

use AST_FORMAT_AUDIO_MASK instead of playing with AST_FORMAT_MAX_AUDIO
to determine audio formats.
There is a dubious use of AST_FORMAT_MAX_AUDIO in sip_request_call()
which surely needs fixing, namely:

        /* mask request with some set of allowed formats.
         * XXX this needs to be fixed.
         * The original code uses AST_FORMAT_AUDIO_MASK, but it is
         * unclear what to use here. We have global_capabilities, which is
         * configured from sip.conf, and sip_tech.capabilities, which is
         * hardwired to all audio formats.
         */

The latter is possibly something to backport when fixed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77682 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoback on cleaning up the usage of flags.
Luigi Rizzo [Sun, 29 Jul 2007 08:58:10 +0000 (08:58 +0000)]
back on cleaning up the usage of flags.
Move together flags used in the same way (e.g. dialog only,
dialog-peer, ...) so it will become easier to deal with them
in a more systematic way.
This is being done in stages so it will be easier to detect
breakage, if any should occur.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77669 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomore documentation on internal representation of incoming SIP messages.
Luigi Rizzo [Sun, 29 Jul 2007 08:19:19 +0000 (08:19 +0000)]
more documentation on internal representation of incoming SIP messages.

Remove definitions for now-unused flags, and add references to print
routines for other flags.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77668 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomake register_unref() return NULL so it is easy to cleanup
Luigi Rizzo [Sun, 29 Jul 2007 00:06:35 +0000 (00:06 +0000)]
make register_unref() return NULL so it is easy to cleanup
the original pointer while calling the function.

on passing add some comments on one of the places where it
is used, and explain why it is safe there.

again, a no-op for practical purposes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77654 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoadd some documentation to auto_congest(), and some
Luigi Rizzo [Sat, 28 Jul 2007 23:43:35 +0000 (23:43 +0000)]
add some documentation to auto_congest(), and some
dialog_ref/unref (they are a no-op at the moment).
Also clean a pointer after freeing memory to avoid
dangling references, and write a for() loop in canonical form.

In practice, everything in this commit is a no-op.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77653 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomore dialog_ref()/dialog_unref() calls
Luigi Rizzo [Sat, 28 Jul 2007 17:16:24 +0000 (17:16 +0000)]
more dialog_ref()/dialog_unref() calls

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77650 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomore dialog_ref()/dialog_unref() calls
Luigi Rizzo [Sat, 28 Jul 2007 16:38:07 +0000 (16:38 +0000)]
more dialog_ref()/dialog_unref() calls

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77648 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agostart introducing hooks for reference counts on dialog descriptors.
Luigi Rizzo [Sat, 28 Jul 2007 16:25:25 +0000 (16:25 +0000)]
start introducing hooks for reference counts on dialog descriptors.
This commit is, for all practical purposes, a no-op, as it only
introduces the dialog_ref() and dialog_unref() methods, and uses them
in a few places (not all the places where they would be needed).

The goal is to start annotating the code with these calls, so the transition
to a proper container will be easier.

Nothing to backport.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77647 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoremove an unused string
Luigi Rizzo [Sat, 28 Jul 2007 09:32:10 +0000 (09:32 +0000)]
remove an unused string

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77631 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agosimplify a conditional expression using S_OR
Luigi Rizzo [Sat, 28 Jul 2007 09:29:22 +0000 (09:29 +0000)]
simplify a conditional expression using S_OR

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77630 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomake use of received= and rport= fields in sip replies.
Luigi Rizzo [Sat, 28 Jul 2007 07:44:16 +0000 (07:44 +0000)]
make use of received= and rport= fields in sip replies.

In a nutshell, these fields are used to tell a sip entity
the address and port its request came from, and are extremely
useful in the presence of NATs, especially with symmetric NATs
where STUN is totally ineffective.

This patch stores the address and port in the 'ourip' field of
the dialog descriptor, so they can be reused in subsequent transactions.
As it is, it works well for things like REGISTER requiring authentication,
because the second REGISTER request (with auth credentials) will carry
the correct address. Maybe it can also be useful, in case of an address
change, to do one or both of the following:

+ propagate the new address to the parent user/peer descriptor so that new
  dialogs will use the correct address from the beginning.
  This is trivial to implement, I am just waiting for feedback on this.

+ re-issue a request in case of an address change. This a lot less trivial,
  maybe unnecessary, and probably covered by the previous item.

I would seriously consider this patch for addition to 1.4 and 1.2.
The code is very little intrusive, and it would solve in a correct
way the nat traversal problems for which externip/externaddr/stunaddr
are only a partial and expensive workaround.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77616 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoSome ODBC drivers don't set the CHAR_OCTET_LENGTH field correctly.
Tilghman Lesher [Fri, 27 Jul 2007 23:21:23 +0000 (23:21 +0000)]
Some ODBC drivers don't set the CHAR_OCTET_LENGTH field correctly.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77603 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoTarget asterisk.pdf stopped building when the build was moved to the doc directory.
Tilghman Lesher [Fri, 27 Jul 2007 23:16:04 +0000 (23:16 +0000)]
Target asterisk.pdf stopped building when the build was moved to the doc directory.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77602 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77571 via svnmerge from
Tilghman Lesher [Fri, 27 Jul 2007 18:17:12 +0000 (18:17 +0000)]
Merged revisions 77571 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77571 | tilghman | 2007-07-27 13:15:58 -0500 (Fri, 27 Jul 2007) | 2 lines

Missing newline

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77572 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77540 via svnmerge from
Joshua Colp [Fri, 27 Jul 2007 17:05:18 +0000 (17:05 +0000)]
Merged revisions 77540 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77540 | file | 2007-07-27 14:04:08 -0300 (Fri, 27 Jul 2007) | 6 lines

(closes issue #10310)
Reported by: prashant_jois
Patches:
      cdr_pgsql.patch uploaded by prashant (license 114)
Finish the Postgresql connection after the log messages are printed so we don't access invalid memory.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77541 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoTurn 4 lines of code into 1 line that does the same thing.
Joshua Colp [Fri, 27 Jul 2007 16:31:55 +0000 (16:31 +0000)]
Turn 4 lines of code into 1 line that does the same thing.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77538 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77536 via svnmerge from
Joshua Colp [Fri, 27 Jul 2007 16:29:40 +0000 (16:29 +0000)]
Merged revisions 77536 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77536 | file | 2007-07-27 13:27:16 -0300 (Fri, 27 Jul 2007) | 6 lines

(closes issue #10323)
Reported by: julianjm
Patches:
      chan_sip_device_state_hold_fix.v1.diff.txt uploaded by julianjm (license 99)
Clear ONHOLD flag when decrementing the onHold peer count. If we did not do this the count may keep decreasing.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77537 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years ago'dialplan save' shouldn't be converting '|' back to ',' anymore.
Tilghman Lesher [Fri, 27 Jul 2007 16:20:55 +0000 (16:20 +0000)]
'dialplan save' shouldn't be converting '|' back to ',' anymore.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77534 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoThese fixes take care of two problems: a complaint in asterisk-dev that goto's aren...
Steve Murphy [Fri, 27 Jul 2007 15:46:20 +0000 (15:46 +0000)]
These fixes take care of two problems: a complaint in asterisk-dev that goto's aren't working in trunk, a side effect of the move to commas as arg seps in apps and funcs; and a problem I spotted myself with dial's 'e' option, where gotos were off by one, because I forgot to set the AUTOLOOP flag in the peer channel.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77520 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77490 via svnmerge from
Mark Michelson [Fri, 27 Jul 2007 14:31:35 +0000 (14:31 +0000)]
Merged revisions 77490 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77490 | mmichelson | 2007-07-27 09:30:43 -0500 (Fri, 27 Jul 2007) | 3 lines

"re-invite" was misspelled

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77491 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77460 via svnmerge from
Joshua Colp [Thu, 26 Jul 2007 23:20:25 +0000 (23:20 +0000)]
Merged revisions 77460 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77460 | file | 2007-07-26 20:19:04 -0300 (Thu, 26 Jul 2007) | 4 lines

(closes issue #10302)
Reported by: litnialex
If a DTMF end frame comes from a channel without a begin and it is going to a technology that only accepts end frames (aka INFO) then use the minimum DTMF duration if one is not in the frame already.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77461 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77424,77429 via svnmerge from
Kevin P. Fleming [Thu, 26 Jul 2007 22:17:25 +0000 (22:17 +0000)]
Merged revisions 77424,77429 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77424 | kpfleming | 2007-07-26 17:14:21 -0500 (Thu, 26 Jul 2007) | 2 lines

use new canonical name for download server

........
r77429 | kpfleming | 2007-07-26 17:16:42 -0500 (Thu, 26 Jul 2007) | 2 lines

change protocol for downloads as well

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77432 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77410 via svnmerge from
Russell Bryant [Thu, 26 Jul 2007 21:24:42 +0000 (21:24 +0000)]
Merged revisions 77410 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77410 | russell | 2007-07-26 16:23:23 -0500 (Thu, 26 Jul 2007) | 10 lines

AST_DEVMODE was defined in trunk, but not in 1.4.  When Asterisk is compiled
under dev mode, AST_DEVMODE will get defined in buildopts.h.  Change 1.4 to
define it in the same way that trunk does.  Also, revert the change that added
this define in the Makefile

The advantage to doing it this way is that buildopts.h gets installed when
you install Asterisk.  Then, when building any out of tree modules, or
building asterisk-addons, these modules know which options the rest of Asterisk
was built with.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77411 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77380 via svnmerge from
Mark Michelson [Thu, 26 Jul 2007 20:39:46 +0000 (20:39 +0000)]
Merged revisions 77380 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77380 | mmichelson | 2007-07-26 15:35:17 -0500 (Thu, 26 Jul 2007) | 7 lines

Fixes to get ast_backtrace working properly. The AST_DEVMODE macro was never defined so the majority of ast_backtrace never
attempted compilation. The makefile now defines AST_DEVMODE if configure was run with --enable-dev-mode. Also, changes were
made to acccomodate 64 bit systems in ast_backtrace.

Thanks to qwell, kpfleming, and Corydon76 for their roles in allowing me to get this committed

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77381 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77350 via svnmerge from
Tilghman Lesher [Thu, 26 Jul 2007 19:33:47 +0000 (19:33 +0000)]
Merged revisions 77350 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77350 | tilghman | 2007-07-26 14:32:17 -0500 (Thu, 26 Jul 2007) | 2 lines

Missed one

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77351 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77348 via svnmerge from
Tilghman Lesher [Thu, 26 Jul 2007 19:29:12 +0000 (19:29 +0000)]
Merged revisions 77348 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77348 | tilghman | 2007-07-26 14:27:18 -0500 (Thu, 26 Jul 2007) | 2 lines

Oops, that builtin define should be all-lowercase.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77349 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77318 via svnmerge from
Mark Michelson [Thu, 26 Jul 2007 18:31:28 +0000 (18:31 +0000)]
Merged revisions 77318 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77318 | mmichelson | 2007-07-26 13:30:29 -0500 (Thu, 26 Jul 2007) | 8 lines

Two consecutive calls to PQfinish could occur, meaning free gets called on the same variable twice.
This patch sets the connection to NULL after calls to PQfinish so that the problem does not occur.
Also in this patch, prashant_jois informed me that it is safe to pass a null pointer to PQfinish, so
I have removed the check for conn's existence from my_unload_module.

(closes issue 10295, reported by junky, patched by me with input from prashant_jois)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77319 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoDo a massive conversion for using the ast_verb() macro
Russell Bryant [Thu, 26 Jul 2007 15:49:18 +0000 (15:49 +0000)]
Do a massive conversion for using the ast_verb() macro
(closes issue #10277, patches by mvanbaak)

Basically, this changes ...

if (option_verbose > 2)
   ast_verbose(VERBOSE_PREFIX_3, "Something\n");

to ...

ast_verb(3, "Something\n");

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77299 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerge a big batch of documentation fixes for escaping, marking URLs, places
Russell Bryant [Thu, 26 Jul 2007 14:49:51 +0000 (14:49 +0000)]
Merge a big batch of documentation fixes for escaping, marking URLs, places
where verbatim text went off the end of the page on the PDF, and various
other improvements
(closes issue #10307, IgorG)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77284 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoRevert some changes to call abs() on the result of ast_random().
Russell Bryant [Thu, 26 Jul 2007 13:26:44 +0000 (13:26 +0000)]
Revert some changes to call abs() on the result of ast_random().
 * random() is defined to return a positive result, and now ast_random()
   will always do so as well

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77269 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoEnsure that the read from /dev/urandom returns a positive result
Russell Bryant [Thu, 26 Jul 2007 13:20:36 +0000 (13:20 +0000)]
Ensure that the read from /dev/urandom returns a positive result
(closes issue #10308, reported by yehavi, patched by me)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77268 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoThings expecting a positive result from ast_random() should not be surprised (closes...
Tilghman Lesher [Thu, 26 Jul 2007 13:19:07 +0000 (13:19 +0000)]
Things expecting a positive result from ast_random() should not be surprised (closes #10308)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77267 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoAdd a link to the list of assigned RTP payload types for convenience.
Russell Bryant [Thu, 26 Jul 2007 13:10:49 +0000 (13:10 +0000)]
Add a link to the list of assigned RTP payload types for convenience.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77266 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agodocument how the RTP marker bit is passed for video frames,
Luigi Rizzo [Thu, 26 Jul 2007 05:35:42 +0000 (05:35 +0000)]
document how the RTP marker bit is passed for video frames,
and why this does not overwrite useful information.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77248 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoadd an entry for h263plus in an empty slot of the rtp types.
Luigi Rizzo [Thu, 26 Jul 2007 04:47:54 +0000 (04:47 +0000)]
add an entry for h263plus in an empty slot of the rtp types.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77233 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoThe upgrade of application argument separators to comma has an effect on AEL; I comme...
Steve Murphy [Thu, 26 Jul 2007 01:33:55 +0000 (01:33 +0000)]
The upgrade of application argument separators to comma has an effect on AEL; I commented out the code that substitutes commas with vertbars, so we can get apps to parse their args correctly.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77218 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77191 via svnmerge from
Steve Murphy [Thu, 26 Jul 2007 01:13:07 +0000 (01:13 +0000)]
Merged revisions 77191 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77191 | murf | 2007-07-25 16:39:27 -0600 (Wed, 25 Jul 2007) | 1 line

This fix solves problem with intense squelch noise when someone joins conf in bug 9430; We repro'd the problem with meetme opts of 'CciMo'; Josh Colp supplied this patch, and I'm applying it. It looks like playing the recorded username will louse up the next thing played into the channel. Josh rearranged the code so as to start things over before playing data directly into the conference.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77217 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77176 via svnmerge from
Joshua Colp [Wed, 25 Jul 2007 22:18:56 +0000 (22:18 +0000)]
Merged revisions 77176 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77176 | file | 2007-07-25 19:16:10 -0300 (Wed, 25 Jul 2007) | 4 lines

(closes issue #10303)
Reported by: jtodd
Add SPEECH_DTMF_TERMINATOR variable so the user can specify the digit to terminate a DTMF string with. If none is specified then no terminator will be used.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77182 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agosilence a warning in ast-devmode on a potentially uninitialized var.
Luigi Rizzo [Wed, 25 Jul 2007 21:58:13 +0000 (21:58 +0000)]
silence a warning in ast-devmode on a potentially uninitialized var.
At first sight (but the function is very large so i am not 100% sure)
the code seems correct, so maybe my compiler is just not smart
enough to figure that out at the optimization level it has.

Not worthwhile merging to 1.4 i believe.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77156 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77154 via svnmerge from
Mark Michelson [Wed, 25 Jul 2007 21:53:35 +0000 (21:53 +0000)]
Merged revisions 77154 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77154 | mmichelson | 2007-07-25 16:52:47 -0500 (Wed, 25 Jul 2007) | 3 lines

chan->emulate_dtmf_duration is an unsigned int, not a signed int, so use %u instead of %d in the format string

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77155 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77071 via svnmerge from
Joshua Colp [Wed, 25 Jul 2007 17:16:11 +0000 (17:16 +0000)]
Merged revisions 77071 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77071 | file | 2007-07-25 14:14:14 -0300 (Wed, 25 Jul 2007) | 2 lines

Fix autoconf logic for finding OpenH323 when it is not in the first place searched (/usr/share/openh323).

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77072 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agochange the debug level to 3 for an exceedingly annoying message
Luigi Rizzo [Wed, 25 Jul 2007 14:13:17 +0000 (14:13 +0000)]
change the debug level to 3 for an exceedingly annoying message
(3-deep nested loop)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77054 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 77022 via svnmerge from
Luigi Rizzo [Wed, 25 Jul 2007 09:45:15 +0000 (09:45 +0000)]
Merged revisions 77022 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77022 | rizzo | 2007-07-25 11:34:01 +0200 (Wed, 25 Jul 2007) | 3 lines

set the sequence number in a frame for all frame types

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77023 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoremove a couple of entries that got duplicated and snuck into the SIP section. Also...
Russell Bryant [Wed, 25 Jul 2007 01:06:02 +0000 (01:06 +0000)]
remove a couple of entries that got duplicated and snuck into the SIP section.  Also, align the NAT/STUN entry with the others.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76985 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 76983 via svnmerge from
Steve Murphy [Wed, 25 Jul 2007 00:34:42 +0000 (00:34 +0000)]
Merged revisions 76983 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r76983 | murf | 2007-07-24 18:18:32 -0600 (Tue, 24 Jul 2007) | 9 lines

Merged revisions 76978 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r76978 | murf | 2007-07-24 18:07:24 -0600 (Tue, 24 Jul 2007) | 1 line

this fixes bug 10293, where the error message because defaultzone or loadzone was not defined was confusing
........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76984 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 76937 via svnmerge from
Tilghman Lesher [Tue, 24 Jul 2007 22:13:37 +0000 (22:13 +0000)]
Merged revisions 76937 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r76937 | tilghman | 2007-07-24 17:12:43 -0500 (Tue, 24 Jul 2007) | 10 lines

Merged revisions 76934 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r76934 | tilghman | 2007-07-24 17:11:33 -0500 (Tue, 24 Jul 2007) | 2 lines

Oops, res contains the error code, not errno.  I was wondering why a mutex was reporting "No such file or directory"...

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76940 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoAdd the flag to trigger an intentional crash on mutex errors
Tilghman Lesher [Tue, 24 Jul 2007 21:37:11 +0000 (21:37 +0000)]
Add the flag to trigger an intentional crash on mutex errors

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76925 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoBlocked revisions 76891 via svnmerge
Tilghman Lesher [Tue, 24 Jul 2007 20:45:32 +0000 (20:45 +0000)]
Blocked revisions 76891 via svnmerge

........
r76891 | tilghman | 2007-07-24 15:42:05 -0500 (Tue, 24 Jul 2007) | 2 lines

Found another place where we should be using the umask (thanks jcmoore)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76892 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoFix escaping and some of the formattting (closes issue #10285)
Tilghman Lesher [Tue, 24 Jul 2007 18:19:18 +0000 (18:19 +0000)]
Fix escaping and some of the formattting (closes issue #10285)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76874 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoRevert trivial whitespace change (for testing)
Jason Parker [Tue, 24 Jul 2007 17:43:36 +0000 (17:43 +0000)]
Revert trivial whitespace change (for testing)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76852 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoTrivial whitespace change to test comitting...
Jason Parker [Tue, 24 Jul 2007 17:23:16 +0000 (17:23 +0000)]
Trivial whitespace change to test comitting...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76841 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 76803 via svnmerge from
Tilghman Lesher [Tue, 24 Jul 2007 17:05:10 +0000 (17:05 +0000)]
Merged revisions 76803 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76803 | qwell | 2007-07-24 11:32:20 -0500 (Tue, 24 Jul 2007) | 3 lines

Don't create the Asterisk channel until we are starting the PBX on it.
(ASA-2007-018)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76807 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 76801 via svnmerge from
Mark Michelson [Tue, 24 Jul 2007 16:42:36 +0000 (16:42 +0000)]
Merged revisions 76801 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76801 | mmichelson | 2007-07-24 11:26:58 -0500 (Tue, 24 Jul 2007) | 13 lines

Added a membercount variable to call_queue struct which keeps track of the number of logged in members in a particular queue.
This makes it so that the 'n' option for Queue() can act properly depending on which strategy is used. If the strategy is
roundrobin, rrmemory, or ringall, we want to ring each phone once before moving on in the dialplan. However, if any other strategy is
used, we will only ring one phone since it cannot be guaranteed that a different phone will ring on subsequent attempts to ring a phone.

As a side effect of this, the QUEUE_MEMBER_COUNT dialplan function now just reads the membercount variable instead of traversing through
the member list to figure out how many members there are.

Special thanks to blitzrage for helping to test this out.

(closes issue #10127, reported by bcnit, patched by me, tested by blitzrage)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76804 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoDon't download/install the sound packages if already installed.
Joshua Colp [Tue, 24 Jul 2007 16:09:20 +0000 (16:09 +0000)]
Don't download/install the sound packages if already installed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76791 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoThe chan_skinny Dial() syntax was funky. You had to do Dial(Skinny/line@device)
Jason Parker [Tue, 24 Jul 2007 15:35:58 +0000 (15:35 +0000)]
The chan_skinny Dial() syntax was funky.  You had to do Dial(Skinny/line@device)
This allows you to just Dial(Skinny/line), as long as line isn't ambiguous.

Note that this does not remove or deprecate the "old" syntax, as it's still
 quite useful - even moreso if shared lines get implemented.

Initial patch by me, with some changes and suggestions from wedhorn.
(closes issue #10263)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76785 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agotwo small fixes when using stun (reported by Marta Carbone):
Luigi Rizzo [Tue, 24 Jul 2007 14:49:49 +0000 (14:49 +0000)]
two small fixes when using stun (reported by Marta Carbone):
+ externexpire was not initialized properly;
+ stunaddr was not handled properly on a sip reload

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76770 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoadd documentation on nat/stun support in chan_sip
Luigi Rizzo [Tue, 24 Jul 2007 07:51:14 +0000 (07:51 +0000)]
add documentation on nat/stun support in chan_sip

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76755 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMove manager users list over to an rwlist.
Joshua Colp [Tue, 24 Jul 2007 02:59:49 +0000 (02:59 +0000)]
Move manager users list over to an rwlist.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76712 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoYou need to put static in front of a static RWLIST declaration to make it really...
Joshua Colp [Mon, 23 Jul 2007 23:14:20 +0000 (23:14 +0000)]
You need to put static in front of a static RWLIST declaration to make it really static... and don't call AST_RWLIST_HEAD_DESTROY on a statically declared list.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76711 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoDon't bother calling AST_RWLIST_EMPTY on a list before AST_RWLIST_TRAVERSE, it's...
Joshua Colp [Mon, 23 Jul 2007 23:05:18 +0000 (23:05 +0000)]
Don't bother calling AST_RWLIST_EMPTY on a list before AST_RWLIST_TRAVERSE, it's just a double check.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76710 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 76708 via svnmerge from
Tilghman Lesher [Mon, 23 Jul 2007 22:41:27 +0000 (22:41 +0000)]
Merged revisions 76708 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76708 | tilghman | 2007-07-23 17:38:06 -0500 (Mon, 23 Jul 2007) | 4 lines

It was our stated intention for 1.4 that files created in app_voicemail should
depend upon the umask.  Unfortunately, mkstemp() creates files with mode 0600,
regardless of the umask.  This corrects that deficiency.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76709 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoEnhance AGI with several fixes:
Tilghman Lesher [Mon, 23 Jul 2007 22:02:05 +0000 (22:02 +0000)]
Enhance AGI with several fixes:
 - Makes the structures handling external AGI commands a bit more thread-safe
 - Makes AGI transparently work with both live and hungup channels
 - DeadAGI is hence no longer necessary and is deprecated
 - CLI bug fixes
 - Commands will refuse to run if the channel is dead and the command is nonsensical
   for dead channels.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76707 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoClean up res_crypto module. It now uses an rwlist to keep the keys and it should...
Joshua Colp [Mon, 23 Jul 2007 21:42:43 +0000 (21:42 +0000)]
Clean up res_crypto module. It now uses an rwlist to keep the keys and it should also be thread safe now.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76706 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMissed one conversion to comma delimiter (thanks, Juggie) and add documentation on the
Tilghman Lesher [Mon, 23 Jul 2007 20:27:26 +0000 (20:27 +0000)]
Missed one conversion to comma delimiter (thanks, Juggie) and add documentation on the
change to the Local channel name.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76704 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerge the dialplan_aesthetics branch. Most of this patch simply converts applications
Tilghman Lesher [Mon, 23 Jul 2007 19:51:41 +0000 (19:51 +0000)]
Merge the dialplan_aesthetics branch.  Most of this patch simply converts applications
using old methods of parsing arguments to using the standard macros.  However, the big
change is that the really old way of specifying application and arguments separated by
a comma will no longer work (e.g. NoOp,foo|bar).  Instead, the way that has been
recommended since long before 1.0 will become the only method available (e.g. NoOp(foo,bar).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76703 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 76656 via svnmerge from
Jason Parker [Mon, 23 Jul 2007 19:00:19 +0000 (19:00 +0000)]
Merged revisions 76656 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76656 | qwell | 2007-07-23 13:59:28 -0500 (Mon, 23 Jul 2007) | 3 lines

Fix some incorrect softkey labels in messages.
Don't try to play dialtone in some unimplemented features.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76657 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 76654 via svnmerge from
Joshua Colp [Mon, 23 Jul 2007 18:31:06 +0000 (18:31 +0000)]
Merged revisions 76654 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r76654 | file | 2007-07-23 15:29:48 -0300 (Mon, 23 Jul 2007) | 12 lines

Merged revisions 76653 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r76653 | file | 2007-07-23 15:28:13 -0300 (Mon, 23 Jul 2007) | 4 lines

(closes issue #5866)
Reported by: tyler
Do not force channel format changes when a generator is present. The generator may have changed the formats itself and changing them back would cause issues.

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76655 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 76620 via svnmerge from
Jason Parker [Mon, 23 Jul 2007 17:58:46 +0000 (17:58 +0000)]
Merged revisions 76620 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #10276)
........
r76620 | qwell | 2007-07-23 12:57:53 -0500 (Mon, 23 Jul 2007) | 4 lines

Don't try to queue up hold/unhold frames on a non-existent channel.

Issue 10276.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76621 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 76618 via svnmerge from
Joshua Colp [Mon, 23 Jul 2007 17:49:45 +0000 (17:49 +0000)]
Merged revisions 76618 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76618 | file | 2007-07-23 14:48:51 -0300 (Mon, 23 Jul 2007) | 2 lines

Allow app_morsecode to build on PPC Linux by putting the value of the digit char in an int.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76619 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoadd two missing entries in the replica of the sip_tech that
Luigi Rizzo [Mon, 23 Jul 2007 14:45:22 +0000 (14:45 +0000)]
add two missing entries in the replica of the sip_tech that
does not use  DTMF BEGIN frames.

1.4 seems correct (it does not have the two fields).

However, as this bug shows, the current way of creating the sip_tech
replica is too error-prone, one can easily forget to update one of
the two entries.  Perhaps it would be better to create sip_tech_info
expliclty at module load, by doing

sip_tech_info = sip_tech;
sip_tech_info.send_digit_begin = NULL

(in this case, this is something applicable to 1.4 as well).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76564 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 76561 via svnmerge from
Joshua Colp [Mon, 23 Jul 2007 14:38:35 +0000 (14:38 +0000)]
Merged revisions 76561 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r76561 | file | 2007-07-23 11:34:21 -0300 (Mon, 23 Jul 2007) | 14 lines

Merged revisions 76560 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r76560 | file | 2007-07-23 11:32:07 -0300 (Mon, 23 Jul 2007) | 6 lines

(closes issue #10236)
Reported by: homesick
Patches:
      rpid_1.4_75840.patch uploaded by homesick (license 91)
Accept Remote Party ID on guest calls.

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76563 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMark str2dtmfmode() as currently unused to resolve a compiler warning and
Russell Bryant [Mon, 23 Jul 2007 14:37:26 +0000 (14:37 +0000)]
Mark str2dtmfmode() as currently unused to resolve a compiler warning and
allow building under dev mode

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76562 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years ago(closes issue #10271)
Russell Bryant [Mon, 23 Jul 2007 14:32:04 +0000 (14:32 +0000)]
(closes issue #10271)
Reported by: snuffy
Patches:
      doxygen-updates.diff uploaded by snuffy (license 35)

Another big batch of doxygen documentation updates

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76559 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agonote the debug and verbose changes in CHANGES
Russell Bryant [Mon, 23 Jul 2007 14:23:47 +0000 (14:23 +0000)]
note the debug and verbose changes in CHANGES

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76558 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years ago(closes issue #10192)
Russell Bryant [Mon, 23 Jul 2007 14:21:41 +0000 (14:21 +0000)]
(closes issue #10192)
Reported by: bbryant
Patches:
      20070720__core_debug_by_file.patch uploaded by bbryant (license 36)
  (with some modifications by me)
Tested by: russell, bbryant

This set of changes introduces the ability to set the core debug or verbose
levels on a per-file basis.  Interestingly enough, in 1.4, you have the ability
to set core debug for a single file, but that functionality was accidentally
lost in the conversion of the CLI commands to the new format.

This patch improves upon what was in 1.4 by letting you set it for more than 1
file, and by also supporting verbose.

*** Janitor Project ***

This patch also introduces a new macro, ast_verb(), which is similar
to ast_debug().  Setting the per file verbose value only works for messages that
use this macro.  Converting existing uses of ast_verbose() can be done like:

if (option_debug > 2)
   ast_verbose(VERBOSE_PREFIX_3 "Something useful\n");

...

ast_verb(3, "Something useful\n");

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76555 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agointroduce two functions, map_x_s() and map_s_x(), to map
Luigi Rizzo [Mon, 23 Jul 2007 14:18:04 +0000 (14:18 +0000)]
introduce two functions, map_x_s() and map_s_x(), to map
between integers and strings using a single translation table,
and use them in a few places instead of ad-hoc routines
that duplicate the table.

On passing, note that REFER_CONFIRMED is never used, and add a
few comments.

Nothing to backport here.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76547 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoRemove an unused function to resolve a compiler warning
Russell Bryant [Mon, 23 Jul 2007 14:02:21 +0000 (14:02 +0000)]
Remove an unused function to resolve a compiler warning

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76524 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoUse autoconf logic to determine byte swapping macro presence. This should now also...
Joshua Colp [Mon, 23 Jul 2007 13:46:57 +0000 (13:46 +0000)]
Use autoconf logic to determine byte swapping macro presence. This should now also use other macros if present.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76523 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agomove "sip prunte realtime ..." and "sip set debug ... " to NEW_CLI style.
Luigi Rizzo [Mon, 23 Jul 2007 13:29:06 +0000 (13:29 +0000)]
move "sip prunte realtime ..." and "sip set debug ... " to NEW_CLI style.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76521 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 76519 via svnmerge from
Joshua Colp [Mon, 23 Jul 2007 13:24:03 +0000 (13:24 +0000)]
Merged revisions 76519 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76519 | file | 2007-07-23 10:23:09 -0300 (Mon, 23 Jul 2007) | 6 lines

(closes issue #10268)
Reported by: mvanbaak
Patches:
      chan_skinny_openbsd.diff uploaded by mvanbaak (license 7)
Add another OS that has to use the Macros for byte ordering.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76520 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 76485 via svnmerge from
Russell Bryant [Mon, 23 Jul 2007 12:29:46 +0000 (12:29 +0000)]
Merged revisions 76485 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76485 | russell | 2007-07-23 07:25:01 -0500 (Mon, 23 Jul 2007) | 6 lines

Use a signed integer for storing the number of bytes in the packet read from
the network.  Using an unsigned value here made it impossible to handle an
error returned from recvfrom().  Furthermore, in the case that recvfrom()
did return an error, this would cause a crash due to a heap overflow.
(closes issue #10265, reported by and fix suggested by timrobbins)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76486 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoAdd some documentation on the sipregistry states and the
Luigi Rizzo [Mon, 23 Jul 2007 03:10:31 +0000 (03:10 +0000)]
Add some documentation on the sipregistry states and the
handling of the sip_register structures.
This commit only changes comments and whitespace.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76467 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoadd a bit of comments on internal functions.
Luigi Rizzo [Mon, 23 Jul 2007 02:46:10 +0000 (02:46 +0000)]
add a bit of comments on internal functions.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76458 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agorewrite "sip show {channels|subscriptions}" CLI handler
Luigi Rizzo [Sun, 22 Jul 2007 21:38:26 +0000 (21:38 +0000)]
rewrite "sip show {channels|subscriptions}" CLI handler
using the new-style cli format.
No functional changes, nothing to backport.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76408 65c4cc65-6c06-0410-ace0-fbb531ad65f3