asterisk/asterisk.git
10 years agoAdd rtsavesysname to chan_iax
David Vossel [Wed, 17 Jun 2009 21:56:42 +0000 (21:56 +0000)]
Add rtsavesysname to chan_iax

chan_sip has an option to save the sysname on rtupdate.  This patch copies that same logic to chan_iax.

(closes issue #14837)
Reported by: barthpbx
Patches:
      iax2-rtsavesysname.patch uploaded by barthpbx (license 744)
      rt_iax.diff uploaded by dvossel (license 671)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201534 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoInitialize additional variables, to prevent a possible crash.
Tilghman Lesher [Wed, 17 Jun 2009 21:31:39 +0000 (21:31 +0000)]
Initialize additional variables, to prevent a possible crash.
(closes issue #15186)
 Reported by: ajohnson
 Patches:
       20090528__issue15186.diff.txt uploaded by tilghman (license 14)
 Tested by: ajohnson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201531 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix problem with no audio due to ignoring the SDP.
Mark Michelson [Wed, 17 Jun 2009 20:10:01 +0000 (20:10 +0000)]
Fix problem with no audio due to ignoring the SDP.

A recent change to our SDP version comparison made audio not function
on some calls. This was because of a test wherein we were trying to
see if an unsigned value was less than 0. This is a dumb comparison
and arguably the compiler should have warned about it. Alas, though,
it slipped past. Now it's fixed by changing the variable to be a
signed type.

Found by several developers. Tested by mnicholson and dbrooks.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201462 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 201450 via svnmerge from
Mark Michelson [Wed, 17 Jun 2009 20:04:12 +0000 (20:04 +0000)]
Merged revisions 201450 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r201450 | mmichelson | 2009-06-17 14:59:31 -0500 (Wed, 17 Jun 2009) | 9 lines

  Change the datastore traversal in ast_do_masquerade to use a safe list traversal.

  It is possible for datastore fixup functions to remove the datastore from the list
  and free it. In particular, the queue_transfer_fixup in app_queue does this. While
  I don't yet know of this causing any crashes, it certainly could.

  Found while discussing a separate issue with Brian Degenhardt.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201458 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoast_channel_datastore_alloc is no longer used. updating datastores.txt to reflect...
David Vossel [Wed, 17 Jun 2009 20:00:51 +0000 (20:00 +0000)]
ast_channel_datastore_alloc is no longer used. updating datastores.txt to reflect that.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201453 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 201423 via svnmerge from
David Vossel [Wed, 17 Jun 2009 19:45:35 +0000 (19:45 +0000)]
Merged revisions 201423 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r201423 | dvossel | 2009-06-17 14:28:12 -0500 (Wed, 17 Jun 2009) | 19 lines

  StopMixMonitor race condition (not giving up file immediately)

  StopMixMonitor only indicates to the MixMonitor thread to stop
  writing to the file.  It does not guarantee that the recording's
  file handle is available to the dialplan immediately after execution.
  This results in a race condition.  To resolve this, the filestream
  pointer is placed in a datastore on the channel. When StopMixMonitor
  is called, the datastore is retrieved from the channel and the
  filestream is closed immediately before returning to the dialplan.
  Documentation indicating the use of StopMixMonitor to free files
  has been updated as well.

  (closes issue #15259)
  Reported by: travisghansen
  Tested by: dvossel

  Review: https://reviewboard.asterisk.org/r/283/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201445 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 201380 via svnmerge from
David Brooks [Wed, 17 Jun 2009 19:15:07 +0000 (19:15 +0000)]
Merged revisions 201380 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r201380 | dbrooks | 2009-06-17 13:45:50 -0500 (Wed, 17 Jun 2009) | 9 lines

  Checks for NULL sip_pvt pointer in chan_sip.c->acf_channel_read()

  Zombie channels could be passed, and chan_sip.c wasn't checking for it.
  Could crash Asterisk. Now checking for NULL pointer.

  (closes issue #15330)
  Reported by: okrief
  Tested by: dbrooks
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201381 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSIP registry ref count error
David Vossel [Wed, 17 Jun 2009 15:20:26 +0000 (15:20 +0000)]
SIP registry ref count error

During a sip reload, the list of sip_registry objects are
supposed to be traversed, unlinked, and destroyed, but
destruction never takes place due to a ref counting error.
This causes a memory leak when registry items are removed
from sip.conf and reloaded.  While the registries are removed
from the global list, they are not removed from the scheduler.
Because of this, SIP register attempts continue to be sent
out for the item even though it may no longer be in the .conf.

(closes issue #15295)
Reported by: amorsen

Review: https://reviewboard.asterisk.org/r/282/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201344 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoupdate chan_iax to use 64bit feature flags.
David Vossel [Wed, 17 Jun 2009 14:42:06 +0000 (14:42 +0000)]
update chan_iax to use 64bit feature flags.

(closes issue #15335)
Reported by: lmadsen

Review: https://reviewboard.asterisk.org/r/284/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201331 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 201261 via svnmerge from
Kevin P. Fleming [Wed, 17 Jun 2009 12:04:17 +0000 (12:04 +0000)]
Merged revisions 201261 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r201261 | kpfleming | 2009-06-17 07:03:25 -0500 (Wed, 17 Jun 2009) | 9 lines

  Correct AST_LIST_APPEND_LIST behavior when list to be appended is empty.

  When the list to be appended is empty, and the list to be appended to is *not*,
  AST_LIST_APPEND_LIST would actually cause the target list to become broken,
  and no longer have a pointer to its last entry. This patch fixes the problem.

  (reported by Stanislaw Pitucha on the asterisk-dev mailing list)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201262 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agofix issue with build_contact introduced by the "SIP trasnport type issues" commit
David Vossel [Tue, 16 Jun 2009 22:29:30 +0000 (22:29 +0000)]
fix issue with build_contact introduced by the "SIP trasnport type issues" commit

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201223 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUpdate my e-mail address (thanks for the props, russell :))
Sean Bright [Tue, 16 Jun 2009 22:11:07 +0000 (22:11 +0000)]
Update my e-mail address (thanks for the props, russell :))

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201190 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoEnable applications to enable/disable digit and tone detection.
Kevin P. Fleming [Tue, 16 Jun 2009 21:10:15 +0000 (21:10 +0000)]
Enable applications to enable/disable digit and tone detection.

Some applications (notably app_fax) do not need digit detection nor FAX tone
detection while they are running, and if Asterisk is using software DSPs to provide
the detection, this consumes extra CPU cycles that could be better spent on the
actual application. This patch allows applications to query and control the state
of digit and tone detection on a channel, and modifies app_fax to disable them
while the FAX operations are occurring (and re-enable digit detection afterwards).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201139 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoExplicitly test for 'static weakref' support.
Kevin P. Fleming [Tue, 16 Jun 2009 21:02:05 +0000 (21:02 +0000)]
Explicitly test for 'static weakref' support.

Since we use 'static' weakref symbols, and not all GCC versions support them,
test for that combination explicitly.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201137 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoWhen compiling in an Emacs-spawned shell, always print directory names.
Kevin P. Fleming [Tue, 16 Jun 2009 20:50:41 +0000 (20:50 +0000)]
When compiling in an Emacs-spawned shell, always print directory names.

This change ensures that Emacs can find the proper source files when parsing
compiler error messages, since it uses the 'make' output including directory
names to do it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201135 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAnother minor fix to compiler attribute checking.
Kevin P. Fleming [Tue, 16 Jun 2009 19:27:12 +0000 (19:27 +0000)]
Another minor fix to compiler attribute checking.

Defaulting to 'static' for the function scope was bad... so remove it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201090 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 200991 via svnmerge from
Kevin P. Fleming [Tue, 16 Jun 2009 18:54:30 +0000 (18:54 +0000)]
Merged revisions 200991 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r200991 | kpfleming | 2009-06-16 12:05:38 -0500 (Tue, 16 Jun 2009) | 11 lines

  Improve support for media paths that can generate multiple frames at once.

  There are various media paths in Asterisk (codec translators and UDPTL, primarily)
  that can generate more than one frame to be generated when the application calling
  them expects only a single frame. This patch addresses a number of those cases,
  at least the primary ones to solve the known problems. In addition it removes the
  broken TRACE_FRAMES support, fixes a number of bugs in various frame-related API
  functions, and cleans up various code paths affected by these changes.

  https://reviewboard.asterisk.org/r/175/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201056 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix problems with new compiler attribute checking in configure script.
Kevin P. Fleming [Tue, 16 Jun 2009 16:32:36 +0000 (16:32 +0000)]
Fix problems with new compiler attribute checking in configure script.

The last changes to ast_gcc_attribute.m4 caused some problems checking for
various attributes, because the scope of the symbol the attribute is applied
to can be important; this patch allows the scope to be specified for the check.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200985 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSIP transport type issues
David Vossel [Tue, 16 Jun 2009 16:03:30 +0000 (16:03 +0000)]
SIP transport type issues

What this patch addresses:
1. ast_sip_ouraddrfor() by default binds to the UDP address/port
reguardless if the sip->pvt is of type UDP or not.  Now when no
remapping is required, ast_sip_ouraddrfor() checks the sip_pvt's
transport type, attempting to set the address and port to the
correct TCP/TLS bindings if necessary.
2.  It is not necessary to send the port number in the Contact
header unless the port is non-standard for the transport type.
This patch fixes this and removes the todo note.
3.  In sip_alloc(), the default dialog built always uses transport
type UDP.  Now sip_alloc() looks at the sip_request (if present)
and determines what transport type to use by default.
4.  When changing the transport type of a sip_socket, the file
descriptor must be set to -1 and in some cases the tcptls_session's
ref count must be decremented and set to NULL.  I've encountered
several issues associated with this process and have created a function,
set_socket_transport(), to handle the setting of the socket type.

(closes issue #13865)
Reported by: st
Patches:
      dont_add_port_if_tls.patch uploaded by Kristijan (license 753)
      13865.patch uploaded by mmichelson (license 60)
      tls_port_v5.patch uploaded by vrban (license 756)
      transport_issues.diff uploaded by dvossel (license 671)
Tested by: mmichelson, Kristijan, vrban, jmacz, dvossel

Review: https://reviewboard.asterisk.org/r/278/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200946 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoadd FILE_STORAGE to Voicemail Build Options
Michiel van Baak [Tue, 16 Jun 2009 15:51:36 +0000 (15:51 +0000)]
add FILE_STORAGE to Voicemail Build Options

Voicemail can only use one storage module at the moment.
Because it's unclear that selecting one of the storage modules
in menuselect will disable filesystem storage we now have
a FILE_STORAGE option that conflicts with the other modules.

(closes issue #15333)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200943 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd Sean Bright to CREDITS - Thanks, Sean!
Russell Bryant [Tue, 16 Jun 2009 15:26:57 +0000 (15:26 +0000)]
Add Sean Bright to CREDITS - Thanks, Sean!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200942 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRecorded merge of revisions 200875 via svnmerge from
Eliel C. Sardanons [Tue, 16 Jun 2009 14:12:34 +0000 (14:12 +0000)]
Recorded merge of revisions 200875 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r200875 | eliel | 2009-06-16 09:25:51 -0400 (Tue, 16 Jun 2009) | 5 lines

  Show the interface name on error, if it is not found.

  If the smdiport specified is not found, show the interface name
  instead of '(null)'.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200878 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoShow the interface name on error, if it is not found.
Eliel C. Sardanons [Tue, 16 Jun 2009 12:32:00 +0000 (12:32 +0000)]
Show the interface name on error, if it is not found.

If the smdiport specified is not found, show the interface name
instead of '(null)'.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200841 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDon't claim a char * is a mansession object.
Russell Bryant [Tue, 16 Jun 2009 02:32:33 +0000 (02:32 +0000)]
Don't claim a char * is a mansession object.

Since there was only 1 bucket, and no hash function was specified, the code
actually worked perfectly fine.  However, in theory, this was invalid use of
the OBJ_POINTER flag, so remove it so the code provides a better usage example.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200805 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agokeep backwards compatible chan_dahdi with older openr2 versions by not using the...
Moises Silva [Tue, 16 Jun 2009 02:24:30 +0000 (02:24 +0000)]
keep backwards compatible chan_dahdi with older openr2 versions by not using the new skip category feature unless supported

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200799 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoEnsure that configure-script testing for compiler attributes actually works.
Kevin P. Fleming [Tue, 16 Jun 2009 01:28:08 +0000 (01:28 +0000)]
Ensure that configure-script testing for compiler attributes actually works.

The configure script tests for compiler attributes didn't actually enable
enough warnings or provide a proper test harness to determine whether the
compiler supports the attribute in question or not; this caused gcc 4.1 to
report that it supports 'weakref', but it doesn't actually support it in the
way that is needed for our optional API mechanism. The new configure script
test will properly distinguish between full support and partial support
for this attribute, among others.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200764 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd missing closure of verbatim environment.
Russell Bryant [Tue, 16 Jun 2009 01:26:20 +0000 (01:26 +0000)]
Add missing closure of verbatim environment.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200762 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDocument the new automatic 'ignoresdpversion' behavior.
Kevin P. Fleming [Tue, 16 Jun 2009 01:03:22 +0000 (01:03 +0000)]
Document the new automatic 'ignoresdpversion' behavior.

Asterisk will now automatically ignore incorrect incoming SDP version numbers
when necessary to complete a T.38 re-INVITE operation.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200726 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAccept T.38 re-INVITE responses with invalid SDP versions.
Kevin P. Fleming [Mon, 15 Jun 2009 20:42:38 +0000 (20:42 +0000)]
Accept T.38 re-INVITE responses with invalid SDP versions.

This commit changes the 'incoming SDP version' check logic a bit more; when
'ignoresdpversion' is *not* set for a peer, if we initiate a re-INVITE to
switch to T.38, we'll always accept the peer's SDP response, even if they
don't properly increment the SDP version number as they should. If this situation
occurs, a warning message will be generated suggesting that the peer's
configuration be changed to include the 'ignoresdpversion' configuration option
(although ideally they'd fix their SIP implementation to be RFC compliant).

AST-221

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200689 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoLast batch of 'static' qualifiers for module-level global variables.
Kevin P. Fleming [Mon, 15 Jun 2009 19:10:10 +0000 (19:10 +0000)]
Last batch of 'static' qualifiers for module-level global variables.

Fix up modules in the 'apps' directory, and also correct the bad example of
enum definitions in include/asterisk/app.h, which many developers followed
(thanks for reading the documentation!). In addition, add some basic usage
examples of the 'pahole' and 'pglobal' tools to the coding guidelines.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200656 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMore 'static' qualifiers on module global variables.
Kevin P. Fleming [Mon, 15 Jun 2009 17:34:30 +0000 (17:34 +0000)]
More 'static' qualifiers on module global variables.

The 'pglobal' tool is quite handy indeed :-)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200620 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoConvert a number of global module variables to 'static'.
Kevin P. Fleming [Mon, 15 Jun 2009 17:06:34 +0000 (17:06 +0000)]
Convert a number of global module variables to 'static'.

These modules all contained variables that are module-global but not system-global,
but were not marked 'static'.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200587 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSome minor structure size improvements in sip_pvt and sip_peer.
Kevin P. Fleming [Mon, 15 Jun 2009 16:38:32 +0000 (16:38 +0000)]
Some minor structure size improvements in sip_pvt and sip_peer.

Using the 'pahole' tool, it is now quite easy to see where structure fields
could be organized differently to keep the compiler from having to add
padding to satisfy alignment requirements. These changes reduced the sizes of
sip_pvt and sip_peer by a few bytes each (on 64-bit platforms), and also fixed
a spelling error in a field name.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200584 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRedesigned 'optional API' support.
Kevin P. Fleming [Mon, 15 Jun 2009 16:07:23 +0000 (16:07 +0000)]
Redesigned 'optional API' support.

This patch provides a new implementation of the optional API support defined
in asterisk/optional_api.h; this new version provides solves compatibility
issues with the use of linker version scripts for suppressing global symbols.
In addition, there is now a functional (and tested!) implementation for Mac OS/X,
so module writers no longer need to use special tests before calling optional
API functions. All future implementations must provide these same semantics,
so that module writers can rely on them.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200519 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 200513 via svnmerge from
Mark Michelson [Mon, 15 Jun 2009 15:22:11 +0000 (15:22 +0000)]
Merged revisions 200513 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r200513 | mmichelson | 2009-06-15 10:21:46 -0500 (Mon, 15 Jun 2009) | 5 lines

  Add INFO to our allowed methods so that endpoints know they may send it to us.

  AST-223
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200514 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoadded openr2 to menuselect-deps.in, recent commit in menuselect made me realize this...
Moises Silva [Sun, 14 Jun 2009 06:13:48 +0000 (06:13 +0000)]
added openr2 to menuselect-deps.in, recent commit in menuselect made me realize this was never done but was working anyways
also added support for skip category request feature of openr2 and updated chan_dahdi.conf.sample

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200477 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoInclude basic installation and usage instructions for upstart script.
Sean Bright [Fri, 12 Jun 2009 19:46:25 +0000 (19:46 +0000)]
Include basic installation and usage instructions for upstart script.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200430 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFirst shot at an upstart script for asterisk on Ubuntu.
Sean Bright [Fri, 12 Jun 2009 19:42:26 +0000 (19:42 +0000)]
First shot at an upstart script for asterisk on Ubuntu.

This works relatively well (assuming you are using /var/run/asterisk) as your
run directory and upstart 0.3.9.  Needs to be generalized and eventually added
to the 'make install' target for Ubuntu.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200428 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 200360 via svnmerge from
Mark Michelson [Fri, 12 Jun 2009 19:07:51 +0000 (19:07 +0000)]
Merged revisions 200360 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r200360 | mmichelson | 2009-06-12 14:06:41 -0500 (Fri, 12 Jun 2009) | 10 lines

  Suppress a warning message and give a better return code when generating
  inband ringing after a call is answered.

  (closes issue #15158)
  Reported by: madkins
  Patches:
        15158.patch uploaded by mmichelson (license 60)
  Tested by: madkins
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200361 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix some bad locking stemming from trying to forward a call to a non-existent
Mark Michelson [Fri, 12 Jun 2009 15:37:30 +0000 (15:37 +0000)]
Fix some bad locking stemming from trying to forward a call to a non-existent
extension from a queue.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200326 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a potential crash from trying to access a NULL channel pointer.
Mark Michelson [Fri, 12 Jun 2009 14:55:07 +0000 (14:55 +0000)]
Fix a potential crash from trying to access a NULL channel pointer.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200290 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCall chgrp instead of chown when setting run directory group ownership.
Sean Bright [Fri, 12 Jun 2009 02:20:19 +0000 (02:20 +0000)]
Call chgrp instead of chown when setting run directory group ownership.

(issue #13153)
Reported by: pabelanger

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200254 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 200185 via svnmerge
Sean Bright [Thu, 11 Jun 2009 22:21:32 +0000 (22:21 +0000)]
Blocked revisions 200185 via svnmerge

........
  r200185 | seanbright | 2009-06-11 18:20:31 -0400 (Thu, 11 Jun 2009) | 2 lines

  Backport fix for parallel build warnings from trunk r199781.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200190 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a crash due to a potentially NULL p->options.
Mark Michelson [Thu, 11 Jun 2009 21:17:14 +0000 (21:17 +0000)]
Fix a crash due to a potentially NULL p->options.

Thanks to mnicholson for pointing it out.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200146 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRelease the allocated channel decreasing the reference counter.
Eliel C. Sardanons [Thu, 11 Jun 2009 15:40:03 +0000 (15:40 +0000)]
Release the allocated channel decreasing the reference counter.

When allocating the channel use ao2_ref(-1) to release it, instead of calling
ast_free().
Also avoid freeing structures inside that channel (on error) if they will be
released by the channel destructor being called if the reference counter reachs
0.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200108 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix path for .flavor and .version
Leif Madsen [Thu, 11 Jun 2009 12:15:09 +0000 (12:15 +0000)]
Fix path for .flavor and .version

(issue #14737)
Reported by: davidw
Patches:
      flavor.patch uploaded by davidw (license 780)
Tested by: davidw

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200039 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 200037 via svnmerge
Leif Madsen [Thu, 11 Jun 2009 12:13:49 +0000 (12:13 +0000)]
Blocked revisions 200037 via svnmerge

........
  r200037 | lmadsen | 2009-06-11 08:12:06 -0400 (Thu, 11 Jun 2009) | 8 lines

  Fix path for .flavor and .version.

  (issue #14737)
  Reported by: davidw
  Patches:
        flavor.patch uploaded by davidw (license 780)
  Tested by: davidw
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200038 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemove some trailing whitespace and steal revision 200000.
Sean Bright [Wed, 10 Jun 2009 20:40:41 +0000 (20:40 +0000)]
Remove some trailing whitespace and steal revision 200000.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200000 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoOnly try to use the invite_branch on outgoing INVITEs with auth credentials.
Mark Michelson [Wed, 10 Jun 2009 20:15:48 +0000 (20:15 +0000)]
Only try to use the invite_branch on outgoing INVITEs with auth credentials.

I have added a comment to the code to help ease understanding of the logic here
as well.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199958 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFixes the argument order in definition of new_find_extension().
David Brooks [Wed, 10 Jun 2009 20:00:45 +0000 (20:00 +0000)]
Fixes the argument order in definition of new_find_extension().

In the definition of new_find_extension(), the arguments 'callerid' and
'label' were swapped. The prototype declaration and all calls to the
function are ordered 'callerid' then 'label', but the function itself
was ordered 'label' then 'callerid'.

(closes issue #15303)
Reported by: JimDickenson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199957 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUse ast_channel_unref to instead of ast_free on a newly created channel.
Mark Michelson [Wed, 10 Jun 2009 18:58:12 +0000 (18:58 +0000)]
Use ast_channel_unref to instead of ast_free on a newly created channel.

Also I removed an unnecessary free of a cid_name. This will be freed properly
in the channel destructor.

Reported by mnicholson in #asterisk-dev.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199923 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 199856 via svnmerge from
Sean Bright [Wed, 10 Jun 2009 16:10:23 +0000 (16:10 +0000)]
Merged revisions 199856 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r199856 | seanbright | 2009-06-10 12:08:35 -0400 (Wed, 10 Jun 2009) | 2 lines

  __WORDSIZE is not available on all platforms, so use sizeof(void *) instead.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199857 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCLI NOTIFY sending wrong transport type.
David Vossel [Tue, 9 Jun 2009 20:47:57 +0000 (20:47 +0000)]
CLI NOTIFY sending wrong transport type.

SIP's cli NOTIFY command only used UDP rather than copying the transport type from the peer.

(closes issue #15283)
Reported by: jthurman
Patches:
      sip-notify-tcp-svn199728.patch uploaded by jthurman (license 614)
Tested by: jthurman, dvossel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199818 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix all of the parallel build warnings issued when running make -j#.
Sean Bright [Tue, 9 Jun 2009 18:08:53 +0000 (18:08 +0000)]
Fix all of the parallel build warnings issued when running make -j#.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199781 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agomodule load priority
David Vossel [Tue, 9 Jun 2009 16:22:04 +0000 (16:22 +0000)]
module load priority

This patch adds the option to give a module a load priority. The value represents the order in which a module's load() function is initialized.  The lower the value, the higher the priority.  The value is only checked if the AST_MODFLAG_LOAD_ORDER flag is set.  If the AST_MODFLAG_LOAD_ORDER flag is not set, the value will never be read and the module will be given the lowest possible priority
on load.  Since some modules are reliant on a timing interface, the timing modules have been given a high load priorty.

(closes issue #15191)
Reported by: alecdavis
Tested by: dvossel

Review: https://reviewboard.asterisk.org/r/262/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199743 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd sigaction janitor
Tilghman Lesher [Mon, 8 Jun 2009 22:08:44 +0000 (22:08 +0000)]
Add sigaction janitor

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199696 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 199626,199628 via svnmerge from
Sean Bright [Mon, 8 Jun 2009 19:33:09 +0000 (19:33 +0000)]
Merged revisions 199626,199628 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r199626 | seanbright | 2009-06-08 15:24:32 -0400 (Mon, 08 Jun 2009) | 21 lines

  Increase the size of our thread stack on 64 bit processors.

  We were setting the stack size for each thread to 240KB regardless of
  architecture, which meant that in some scenarios we actually had less available
  stack space on 64 bit processors (pointers use 8 bytes instead of 4).  So now we
  calculate the stack size we reserve based on the platform's __WORDSIZE, which
  gives us:

       32 bit -> 240KB
       64 bit -> 496KB
      128 bit -> 1008KB (that's right, we're ready for 128 bit processors)

  Patch typed by me but written by several members of #asterisk-dev, including
  Kevin, Tilghman, and Qwell.

  (closes issue #14932)
  Reported by: jpiszcz
  Patches:
        06052009_issue14932.patch uploaded by seanbright (license 71)
  Tested by: seanbright
........
  r199628 | seanbright | 2009-06-08 15:28:33 -0400 (Mon, 08 Jun 2009) | 2 lines

  Fix a typo in the stack size calculation just introduced.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199630 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a deadlock that could occur when setting rtp stats on SIP calls.
Mark Michelson [Mon, 8 Jun 2009 17:32:04 +0000 (17:32 +0000)]
Fix a deadlock that could occur when setting rtp stats on SIP calls.

(closes issue #15143)
Reported by: cristiandimache
Patches:
      15143.patch uploaded by mmichelson (license 60)
Tested by: cristiandimache

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199588 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMove OSP* applications static documentation to XML.
Eliel C. Sardanons [Sun, 7 Jun 2009 19:15:41 +0000 (19:15 +0000)]
Move OSP* applications static documentation to XML.

Move OSP* applications static documentation to the new AstXML form.

(closes issue #15245)
Reported by: eliel
Patches:
      app_osplookup_static_conversion.txt uploaded by lmadsen (license 10)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199547 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMove application ExternalIVR static documentation to XML.
Eliel C. Sardanons [Sun, 7 Jun 2009 17:29:44 +0000 (17:29 +0000)]
Move application ExternalIVR static documentation to XML.

Move application ExternalIVR static documentation to the new AstXML form.

(issue #15245)
Reported by: eliel
Patches:
      app_externalivr.diff uploaded by eliel (license 64)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199514 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoGlobal var cleanup - constification and removing unused vars.
Russell Bryant [Sun, 7 Jun 2009 14:55:51 +0000 (14:55 +0000)]
Global var cleanup - constification and removing unused vars.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199479 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMove AGI command 'gosub' static documentation to XML.
Eliel C. Sardanons [Sat, 6 Jun 2009 23:28:38 +0000 (23:28 +0000)]
Move AGI command 'gosub' static documentation to XML.

Move AGI command 'gosub' statis documentation to the new AstXML form.

(issue #15245)
Reported by: eliel
Patches:
      app_stack_static_conversion.txt uploaded by lmadsen (license 10)
      (with minor changes by me)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199446 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMove music on hold related applications documentation to XML.
Eliel C. Sardanons [Sat, 6 Jun 2009 23:03:15 +0000 (23:03 +0000)]
Move music on hold related applications documentation to XML.

Move MusicOnHold, SetMusicOnHold, StartMusicOnHold, StopMusicOnHold static
documentation to the new AstXML form.

(issue #15245)
Reported by: eliel
Patches:
      res_musiconhold_static_conversion.txt uploaded by lmadsen (license 10)
      (with some fixes and formatting by me)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199413 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMove function PP_EACH_USER and PP_EACH_EXTENSION documentation to XML.
Eliel C. Sardanons [Sat, 6 Jun 2009 22:45:42 +0000 (22:45 +0000)]
Move function PP_EACH_USER and PP_EACH_EXTENSION documentation to XML.

Move function PP_EACH_USER and PP_EACH_EXTENSION documentation to the new
AstXML form.

(issue #15245)
Reported by: eliel
Patches:
      res_phoneprov_static_conversion.txt uploaded by lmadsen (license 10)
(with PP_EACH_USER add by me)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199411 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMove function MEETME_INFO documentation to XML.
Eliel C. Sardanons [Sat, 6 Jun 2009 22:27:48 +0000 (22:27 +0000)]
Move function MEETME_INFO documentation to XML.

Move function MEETME_INFO static documentation to the new AstXML form.

(issue #15245)
Reported by: eliel
Patches:
      app_meetme_static_conversion.txt uploaded by lmadsen (license 10)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199409 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMove function MINIVMACCOUNT and MINIVMCOUNTER static documentation to XML.
Eliel C. Sardanons [Sat, 6 Jun 2009 22:16:47 +0000 (22:16 +0000)]
Move function MINIVMACCOUNT and MINIVMCOUNTER static documentation to XML.

Move function MINIVMACCOUNT and MINIVMCOUNTER statis documentation to the new
AstXML form.

(issue #15245)
Reported by: eliel
Patches:
      app_minivm_static_conversion.txt uploaded by lmadsen (license 10)
      (with minor changes by me)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199376 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMove function SYSINFO documentation to XML.
Eliel C. Sardanons [Sat, 6 Jun 2009 21:56:58 +0000 (21:56 +0000)]
Move function SYSINFO documentation to XML.

Move function SYSINFO static documentation to the new AstXML form.

(issue #15245)
Reported by: eliel
Patches:
      func_sysinfo_static_conversion.txt uploaded by lmadsen (license 10)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199374 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agominor tweak
Russell Bryant [Sat, 6 Jun 2009 21:42:31 +0000 (21:42 +0000)]
minor tweak

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199372 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoConstify a string and strip trailing whitespace.
Russell Bryant [Sat, 6 Jun 2009 21:40:56 +0000 (21:40 +0000)]
Constify a string and strip trailing whitespace.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199370 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSwitch from "echo -n" to printf. On my mac, the -n was just getting printed out.
Russell Bryant [Sat, 6 Jun 2009 21:38:54 +0000 (21:38 +0000)]
Switch from "echo -n" to printf.  On my mac, the -n was just getting printed out.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199368 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 199297 via svnmerge from
David Vossel [Fri, 5 Jun 2009 21:21:22 +0000 (21:21 +0000)]
Merged revisions 199297 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r199297 | dvossel | 2009-06-05 16:19:56 -0500 (Fri, 05 Jun 2009) | 14 lines

  Fixes issue with hints giving unexpected results.

  Hints with two or more devices that include ONHOLD gave unexpected results.

  (closes issue #15057)
  Reported by: p_lindheimer
  Patches:
        onhold_trunk.diff uploaded by dvossel (license 671)
        pbx.c.1.4.patch uploaded by p (license 558)
        devicestate.c.trunk.patch uploaded by p (license 671)
  Tested by: p_lindheimer, dvossel

  Review: https://reviewboard.asterisk.org/r/254/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199298 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCorrect "dahdi show channels" output when specifying a group.
Mark Michelson [Fri, 5 Jun 2009 13:51:08 +0000 (13:51 +0000)]
Correct "dahdi show channels" output when specifying a group.

Since a DAHDI channel may belong to multiple groups, we need to use
a bitwise and instead of equivalence to determine whether to display
the channel information.

(closes issue #15248)
Reported by: gentian
Patches:
      15248.patch uploaded by mmichelson (license 60)
Tested by: gentian

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199227 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 199138 via svnmerge from
David Vossel [Thu, 4 Jun 2009 19:10:16 +0000 (19:10 +0000)]
Merged revisions 199138 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r199138 | dvossel | 2009-06-04 14:00:15 -0500 (Thu, 04 Jun 2009) | 3 lines

  Additional updates to AST-2009-001
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199139 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMove static docs to the new AstXML form.
Eliel C. Sardanons [Thu, 4 Jun 2009 16:29:50 +0000 (16:29 +0000)]
Move static docs to the new AstXML form.

Move SMDI_MSG and SMDI_MSG_RETRIEVE functions statis documentation
to XML.

(issue #15245)
Reported by: eliel
Patches:
      res_smdi_static_conversion.txt uploaded by lmadsen (license 10)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199091 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 199022 via svnmerge from
Sean Bright [Thu, 4 Jun 2009 14:31:24 +0000 (14:31 +0000)]
Merged revisions 199022 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r199022 | seanbright | 2009-06-04 10:14:57 -0400 (Thu, 04 Jun 2009) | 40 lines

  Safely handle AMI connections/reload requests that occur during startup.

  During asterisk startup, a lock on the list of modules is obtained by the
  primary thread while each module is initialized.  Issue 13778 pointed out a
  problem with this approach, however.  Because the AMI is loaded before other
  modules, it is possible for a module reload to be issued by a connected client
  (via Action: Command), causing a deadlock.

  The resolution for 13778 was to move initialization of the manager to happen
  after the other modules had already been lodaded.  While this fixed this
  particular issue, it caused a problem for users (like FreePBX) who call AMI
  scripts via an #exec in a configuration file (See issue 15189).

  The solution I have come up with is to defer any reload requests that come in
  until after the server is fully booted.  When a call comes in to
  ast_module_reload (from wherever) before we are fully booted, the request is
  added to a queue of pending requests.  Once we are done booting up, we then
  execute these deferred requests in turn.

  Note that I have tried to make this a bit more intelligent in that it will not
  queue up more than 1 request for the same module to be reloaded, and if a
  general reload request comes in ('module reload') the queue is flushed and we
  only issue a single deferred reload for the entire system.

  As for how this will impact existing installations - Before 13778, a reload
  issued before module initialization was completed would result in a deadlock.
  After 13778, you simply couldn't connect to the manager during startup (which
  causes problems with #exec-that-calls-AMI configuration files).  I believe this
  is a good general purpose solution that won't negatively impact existing
  installations.

  (closes issue #15189)
  (closes issue #13778)
  Reported by: p_lindheimer
  Patches:
        06032009_15189_deferred_reloads.diff uploaded by seanbright (license 71)
  Tested by: p_lindheimer, seanbright

  Review: https://reviewboard.asterisk.org/r/272/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199051 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 198957 via svnmerge
Sean Bright [Wed, 3 Jun 2009 20:49:11 +0000 (20:49 +0000)]
Blocked revisions 198957 via svnmerge

........
  r198957 | seanbright | 2009-06-03 16:39:10 -0400 (Wed, 03 Jun 2009) | 11 lines

  Fix a possible crash in pbx_spool.

  We were trying to reference members of a struct that had previously been freed.
  This patch makes sure that we free the struct after it has been removed from
  the spooler queue.

  (closes issue #15072)
  Reported by: garlew
  Patches:
        spool.diff uploaded by garlew (license 376)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198958 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoast_call_forward() todo notes and originate flag copy.
David Vossel [Wed, 3 Jun 2009 20:30:10 +0000 (20:30 +0000)]
ast_call_forward() todo notes and originate flag copy.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198954 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 198891 via svnmerge
David Vossel [Wed, 3 Jun 2009 15:51:10 +0000 (15:51 +0000)]
Blocked revisions 198891 via svnmerge

........
  r198891 | dvossel | 2009-06-03 10:49:46 -0500 (Wed, 03 Jun 2009) | 10 lines

  Generic call forward api, ast_call_forward()

  The function ast_call_forward() forwards a call to an extension specified in an ast_channel's call_forward string.  After an ast_channel is called, if the channel's call_forward string is set this function can be used to forward the call to a new channel and terminate the original one.  I have included this api call in both channel.c's ast_request_and_dial() and res_feature.c's feature_request_and_dial().  App_dial and app_queue already contain call forward logic specific for their application and options.

  (closes issue #13630)
  Reported by: festr

  Review: https://reviewboard.asterisk.org/r/271/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198892 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoGeneric call forward api, ast_call_forward()
David Vossel [Tue, 2 Jun 2009 21:17:49 +0000 (21:17 +0000)]
Generic call forward api, ast_call_forward()

The function ast_call_forward() forwards a call to an extension specified in an ast_channel's call_forward string.  After an ast_channel is called, if the channel's call_forward string is set this function can be used to forward the call to a new channel and terminate the original one.  I have included this api call in both channel.c's ast_request_and_dial() and feature.c's feature_request_and_dial().  App_dial and app_queue already contain call forward logic specific for their application and options.

(closes issue #13630)
Reported by: festr

Review: https://reviewboard.asterisk.org/r/271/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198856 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agofixes issue with channels not going down after transfer
David Vossel [Tue, 2 Jun 2009 17:55:35 +0000 (17:55 +0000)]
fixes issue with channels not going down after transfer

Iax2 currently does not support native bridging if the timeoutms value is set.  We check for that in iax2_bridge, but then set timeoutms to 0 by default.  If the timeoutms is not provided it is set to -1. By setting timeoutms to 0 it is processed causing a bridging retry loop.

(closes issue #15216)
Reported by: oxymoron
Tested by: dvossel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198824 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCorrect documentation for the register line, specifically where the domain should...
Joshua Colp [Tue, 2 Jun 2009 13:48:06 +0000 (13:48 +0000)]
Correct documentation for the register line, specifically where the domain should be specified.

(closes issue #14367)
Reported by: Nick_Lewis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198791 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a bug where we were passing in address information that should remain unmodified...
Joshua Colp [Tue, 2 Jun 2009 13:12:59 +0000 (13:12 +0000)]
Fix a bug where we were passing in address information that should remain unmodified to a function that may modify it.

(closes issue #15243)
Reported by: pj

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198762 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoTell the IAX2 parser about more control frame types.
Russell Bryant [Mon, 1 Jun 2009 21:03:18 +0000 (21:03 +0000)]
Tell the IAX2 parser about more control frame types.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198729 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd the ability to execute connected line interception macros.
Mark Michelson [Mon, 1 Jun 2009 20:57:31 +0000 (20:57 +0000)]
Add the ability to execute connected line interception macros.

When connected line updates are received or generated in the middle
of an application call, it is now possible to execute a macro to
manipulate the connected line data. This way, phone numbers may be
manipulated to be more presentable to users, names may be changed
for...whatever reason, or whatever else needs to be done may be.

Review: https://reviewboard.asterisk.org/r/256

AST-165

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198727 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd INCrement and DECrement functions
Tilghman Lesher [Mon, 1 Jun 2009 20:33:50 +0000 (20:33 +0000)]
Add INCrement and DECrement functions
(closes issue #15025)
 Reported by: greenfieldtech
 Patches:
       func_math.c.patch_v4 uploaded by greenfieldtech (license 369)
       slightly modified by me
 Tested by: greenfieldtech, lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198725 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMinor whitespace fix.
Russell Bryant [Mon, 1 Jun 2009 20:17:50 +0000 (20:17 +0000)]
Minor whitespace fix.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198670 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 198665 via svnmerge
Tilghman Lesher [Mon, 1 Jun 2009 20:09:56 +0000 (20:09 +0000)]
Blocked revisions 198665 via svnmerge

........
  r198665 | tilghman | 2009-06-01 15:07:04 -0500 (Mon, 01 Jun 2009) | 7 lines

  If using the old deprecated format, a reload would cause the class to disappear.
  (closes issue #14759)
   Reported by: lidocaineus
   Patches:
         20090518__issue14759.diff.txt uploaded by tilghman (license 14)
   Tested by: lmadsen
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198666 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMoved more static documentation to the new AstXML form.
Eliel C. Sardanons [Mon, 1 Jun 2009 19:37:30 +0000 (19:37 +0000)]
Moved more static documentation to the new AstXML form.

Moved more static docs to XML (pplications and manager actions):
Monitor, StopMonitor, ChangeMonitor, PauseMonitor, UnpauseMonitor.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198661 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd information for new meetme realtime fields
Tilghman Lesher [Mon, 1 Jun 2009 18:40:35 +0000 (18:40 +0000)]
Add information for new meetme realtime fields

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198626 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDo not add say.o in a separate line.
Eliel C. Sardanons [Mon, 1 Jun 2009 17:53:38 +0000 (17:53 +0000)]
Do not add say.o in a separate line.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198597 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMove JabberSend manager action from static docs to the AstXML form.
Eliel C. Sardanons [Mon, 1 Jun 2009 16:09:42 +0000 (16:09 +0000)]
Move JabberSend manager action from static docs to the AstXML form.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198565 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMove static documentation of E|Dead|AGI() application and manager action to XML.
Eliel C. Sardanons [Mon, 1 Jun 2009 15:38:48 +0000 (15:38 +0000)]
Move static documentation of E|Dead|AGI() application and manager action to XML.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198561 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFixed an issue in the threadstorage cli functions resulting from the constification...
David Vossel [Mon, 1 Jun 2009 15:23:21 +0000 (15:23 +0000)]
Fixed an issue in the threadstorage cli functions resulting from the constification of struct ast_cli_args in r196072.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198558 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemove extra lock from app_queue.
Mark Michelson [Mon, 1 Jun 2009 14:45:43 +0000 (14:45 +0000)]
Remove extra lock from app_queue.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198530 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemove extra lock from local_indicate in connected line case.
Mark Michelson [Mon, 1 Jun 2009 14:42:57 +0000 (14:42 +0000)]
Remove extra lock from local_indicate in connected line case.

Oh, and this fixes a deadlock I was seeing.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198529 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd missing unlock of local pvt.
Mark Michelson [Mon, 1 Jun 2009 14:19:49 +0000 (14:19 +0000)]
Add missing unlock of local pvt.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198511 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemove documentation for the 'exten' argument to the AGENT function.
Mark Michelson [Mon, 1 Jun 2009 14:02:05 +0000 (14:02 +0000)]
Remove documentation for the 'exten' argument to the AGENT function.

Since AgentCallbackLogin has been removed, this should not be documented
any more.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198500 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a bug where the Event and Content-Type headers were added twice to outgoing SIP...
Joshua Colp [Mon, 1 Jun 2009 13:31:27 +0000 (13:31 +0000)]
Fix a bug where the Event and Content-Type headers were added twice to outgoing SIP NOTIFY messages.

(closes issue #15239)
Reported by: pj

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198498 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix documentation for FIELDQTY.
Tilghman Lesher [Sun, 31 May 2009 17:52:28 +0000 (17:52 +0000)]
Fix documentation for FIELDQTY.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198470 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFilter the say.o object, it is being added later.
Eliel C. Sardanons [Sun, 31 May 2009 02:09:06 +0000 (02:09 +0000)]
Filter the say.o object, it is being added later.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@198442 65c4cc65-6c06-0410-ace0-fbb531ad65f3