asterisk/asterisk.git
11 years agoRemove spurious debug
Terry Wilson [Wed, 30 Sep 2009 18:47:53 +0000 (18:47 +0000)]
Remove spurious debug

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221300 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUse rtp properties instead of adding a callback
Terry Wilson [Wed, 30 Sep 2009 18:21:03 +0000 (18:21 +0000)]
Use rtp properties instead of adding a callback

Thanks, Josh.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221278 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 221086 via svnmerge from
Terry Wilson [Wed, 30 Sep 2009 17:52:30 +0000 (17:52 +0000)]
Merged revisions 221086 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r221086 | twilson | 2009-09-30 09:49:11 -0500 (Wed, 30 Sep 2009) | 25 lines

  Change the SSRC by default when our media stream changes

  Be default, change SSRC when doing an audio stream changes Asterisk doesn't
  honor marker bit when reinvited to already-bridged RTP streams,resulting in
  far-end stack discarding packets with "old" timestamps that areactually part of
  a new stream.  This patch sends AST_CONTROL_SRCUPDATE whenever there is a
  reinvite, unless the 'constantssrc' is set to true in sip.conf.

  The original issue reported to Digium support detailed the following situation:
  ITSP <-> Asterisk 1.4.26.2 <-> SIP-based Application Server Call comes in
  fromITSP, Asterisk dials the app server which sends a re-invite back
  toAsterisk--not to negotiate to send media directly to the ITSP, but to
  indicatethat it's changing the stream it's sending to Asterisk.  The app
  servergenerates a new SSRC, sequence numbers, timestamps, and sets the marker
  bit on the new stream.  Asterisk passes through the teimstamp of the new stream,
  butdoes not reset the SSRC, sequence numbers, or set the marker bit.

  When the timestamp on the new stream is older than the timestamp on the
  originalstream, the ITSP (which doesn't know there has been any change) discards
  the newframes because it thinks they are too old.  This patch addresses this by
  changing the SSRC on a stream update unless constantssrc=true is set in
  sip.conf.

  Review: https://reviewboard.asterisk.org/r/374/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221266 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 221200 via svnmerge from
Tilghman Lesher [Wed, 30 Sep 2009 16:56:42 +0000 (16:56 +0000)]
Merged revisions 221200 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r221200 | tilghman | 2009-09-30 11:55:21 -0500 (Wed, 30 Sep 2009) | 7 lines

  Avoid a potential NULL dereference.
  (closes issue #15865)
   Reported by: kobaz
   Patches:
         20090915__issue15865.diff.txt uploaded by tilghman (license 14)
   Tested by: kobaz
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221201 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoModify VoiceMailMain()'s a() argument to allow mailboxes to be specified by name.
Sean Bright [Wed, 30 Sep 2009 15:11:21 +0000 (15:11 +0000)]
Modify VoiceMailMain()'s a() argument to allow mailboxes to be specified by name.

(closes issue #14740)
Reported by: pj
Patches:
      issue14740_09022009.diff uploaded by seanbright (license 71)
Tested by: seanbright, lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221090 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoClarify documentation for VoiceMailMain()'s a() option.
Sean Bright [Wed, 30 Sep 2009 14:47:58 +0000 (14:47 +0000)]
Clarify documentation for VoiceMailMain()'s a() option.

We require box numbers, not names as the documentation implies.
(issue #14740)
Reported by: pj
Patches:
      __20090729-app_voicemail-documentation.patch uploaded by lmadsen (license 10)
Tested by: seanbright, lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221085 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAllow locks to be inherited through a masquerade without causing starvation.
Tilghman Lesher [Wed, 30 Sep 2009 04:32:36 +0000 (04:32 +0000)]
Allow locks to be inherited through a masquerade without causing starvation.
(closes issue #14859)
 Reported by: atis
 Patches:
       20090821__issue14859.diff.txt uploaded by tilghman (license 14)
       20090925__issue14859__1.6.1.diff.txt uploaded by tilghman (license 14)
 Tested by: atis, tilghman

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221044 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix channel reference leak.
Mark Michelson [Tue, 29 Sep 2009 21:28:04 +0000 (21:28 +0000)]
Fix channel reference leak.

ast_cel_report_event would geet a reference to the
bridged channel. However, certain return paths, such
as if CEL was not enabled, would result in a reference
leak. All return paths now properly unref the channel.

(closes issue #15991)
Reported by: mmichelson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220995 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 220907 via svnmerge
Matthew Nicholson [Tue, 29 Sep 2009 20:22:43 +0000 (20:22 +0000)]
Blocked revisions 220907 via svnmerge

........
  r220907 | mnicholson | 2009-09-29 15:14:29 -0500 (Tue, 29 Sep 2009) | 10 lines

  Avoid a deadlock in chanspy, just in case the spyee is masqueraded and chanspy_ds_chan_fixup() is called with the channel locked.

  (closes issue #15965)
  Reported by: atis
  Patches:
        chanspy-deadlock-fix1.diff uploaded by mnicholson (license 96)
  Tested by: atis
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220928 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoGet rid of annoying and cryptic debug messages.
Mark Michelson [Tue, 29 Sep 2009 20:20:48 +0000 (20:20 +0000)]
Get rid of annoying and cryptic debug messages.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220920 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 220873 via svnmerge from
Tilghman Lesher [Tue, 29 Sep 2009 19:57:37 +0000 (19:57 +0000)]
Merged revisions 220873 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r220873 | tilghman | 2009-09-29 12:59:26 -0500 (Tue, 29 Sep 2009) | 9 lines

  Reduce CPU usage related to building a peer merely for devicestates.
  This fixes a 100% CPU problem in the SIP driver, found by profiling
  the driver while the problem was occurring.
  (closes issue #14309)
   Reported by: pkempgen
   Patches:
         20090924__issue14309.diff.txt uploaded by tilghman (license 14)
   Tested by: pkempgen, vrban
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220906 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix options 'm' and 's'. They were swapped in the code. Also document the fact that...
Matthew Nicholson [Tue, 29 Sep 2009 19:49:02 +0000 (19:49 +0000)]
Fix options 'm' and 's'. They were swapped in the code.  Also document the fact that app_confbridge does not automatically answer the channel.

(closes issue #15964)
Reported by: shrift

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220904 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMake deletion of temporary greetings work properly with IMAP_STORAGE
Jeff Peeler [Tue, 29 Sep 2009 16:58:29 +0000 (16:58 +0000)]
Make deletion of temporary greetings work properly with IMAP_STORAGE

When imapgreetings was set to yes, the message was being deleted but wasn't
actually being expunged. When imapgreetings was set to no, the file based
message was not being deleted at all. All good now!

(closes issue #14949)
Reported by: noahisaac
Patches:
      vm_tempgreeting_removal.patch uploaded by noahisaac (license 748),
      modified by me

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220833 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMiscellaneous minor changes.
Richard Mudgett [Mon, 28 Sep 2009 21:02:20 +0000 (21:02 +0000)]
Miscellaneous minor changes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220792 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 220717 via svnmerge from
Sean Bright [Mon, 28 Sep 2009 19:11:20 +0000 (19:11 +0000)]
Merged revisions 220717 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r220717 | seanbright | 2009-09-28 15:09:25 -0400 (Mon, 28 Sep 2009) | 3 lines

  When selecting DONT_OPTIMIZE in menuselect, explicitly pass -O0 to the compiler
  so we override any default optimization levels for a particular install.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220721 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix building of registration entry in build_peer when using callbackextension
Jeff Peeler [Mon, 28 Sep 2009 19:10:10 +0000 (19:10 +0000)]
Fix building of registration entry in build_peer when using callbackextension

Check for remotesecret option was unintentionally always true, which therefore
caused the secret option to never be used. Thanks to dvossel for pointing out
the exact fix.

(closes issue #15943)
Reported by: tpsast

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220718 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoLocking issues dealing with service_lock.
Richard Mudgett [Mon, 28 Sep 2009 15:27:46 +0000 (15:27 +0000)]
Locking issues dealing with service_lock.

*  Removed unneeded and uninitialized service_lock.
*  Fixed potential locking imbalance in pri_dchannel():PRI_EVENT_RESTART.
*  Fixed verbose message typo in pri_dchannel():PRI_EVENT_RESTART.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220672 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoadd name argument for the CALLERID dialplan function to the xml documentation.
Michiel van Baak [Sun, 27 Sep 2009 20:40:16 +0000 (20:40 +0000)]
add name argument for the CALLERID dialplan function to the xml documentation.
Pointed out to me on IRC by snuff-home. Thanks

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220629 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAllow AES to compile, when OpenSSL is not present.
Tilghman Lesher [Sat, 26 Sep 2009 15:10:28 +0000 (15:10 +0000)]
Allow AES to compile, when OpenSSL is not present.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220586 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoReduce indentation in sig_pri_available().
Richard Mudgett [Fri, 25 Sep 2009 19:56:18 +0000 (19:56 +0000)]
Reduce indentation in sig_pri_available().

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220543 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoEliminate unnecessary include of version.h in manager.c.
Kevin P. Fleming [Fri, 25 Sep 2009 14:50:29 +0000 (14:50 +0000)]
Eliminate unnecessary include of version.h in manager.c.

Including version.h here causes this file to get recompiled after
every commit or update, which is not needed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220496 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoCorrect sense of logic test committed in revision 220494.
Kevin P. Fleming [Fri, 25 Sep 2009 14:44:40 +0000 (14:44 +0000)]
Correct sense of logic test committed in revision 220494.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220495 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDon't use hash-based lookups for ast_channel_get_by_name_prefix().
Kevin P. Fleming [Fri, 25 Sep 2009 14:38:41 +0000 (14:38 +0000)]
Don't use hash-based lookups for ast_channel_get_by_name_prefix().

ast_channel_get_full() tries to use OBJ_POINTER to optimize name-based
channel lookups, but this will not work properly when the channel's full
name was not supplied; for name-prefix searches, there is no value in
doing a hash-based lookup, and in fact doing so could result in many
channels being skipped.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220494 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd JABBER_RECEIVE as a dialplan function, implement SendText in Jingle channels
Philippe Sultan [Fri, 25 Sep 2009 10:54:42 +0000 (10:54 +0000)]
Add JABBER_RECEIVE as a dialplan function, implement SendText in Jingle channels

JABBER_RECEIVE (along with JabberSend) makes Asterisk interact with users over
XMPP to process calls.
SendText can be used instead of JabberSend in the context of XMPP based voice
channels (chan_gtalk and chan_jingle).

(closes issue #12569)
Reported by: eech55
Tested by: phsultan, asannucci, lmadsen, jtodd, maxgo

Review: https://reviewboard.asterisk.org/r/88/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220457 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoChange the default behavior of Set, AGI, and pbx_realtime to 1.6 behavior by default...
Tilghman Lesher [Thu, 24 Sep 2009 22:53:23 +0000 (22:53 +0000)]
Change the default behavior of Set, AGI, and pbx_realtime to 1.6 behavior by default (starting in 1.6.3).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220417 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agofixes tcptls_session memory leak caused by ref count error
David Vossel [Thu, 24 Sep 2009 20:37:20 +0000 (20:37 +0000)]
fixes tcptls_session memory leak caused by ref count error

(closes issue #15939)
Reported by: dvossel

Review: https://reviewboard.asterisk.org/r/375/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220365 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd bridge related dial flags to the bridge app
Jeff Peeler [Thu, 24 Sep 2009 20:29:51 +0000 (20:29 +0000)]
Add bridge related dial flags to the bridge app

Most of the functionality here is gained simply by setting the feature flag
on the bridge config. However, the dial limit functionality has been moved from
app_dial to the features code and has been made public so both app_dial and
the bridge app can use it.

(closes issue #13165)
Reported by: tim_ringenbach
Patches:
      app_bridge_options_r138998.diff uploaded by tim ringenbach (license 540),
      modified by me

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220344 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDocumentation in the commit messages is soon forgotten, please add it to the docs...
Olle Johansson [Thu, 24 Sep 2009 19:57:23 +0000 (19:57 +0000)]
Documentation in the commit messages is soon forgotten, please add it to the docs in the product.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220295 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 220288 via svnmerge from
Tilghman Lesher [Thu, 24 Sep 2009 19:41:02 +0000 (19:41 +0000)]
Merged revisions 220288 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r220288 | tilghman | 2009-09-24 14:39:41 -0500 (Thu, 24 Sep 2009) | 6 lines

  Implicitly sending a progress signal breaks some applications.
  Call Progress() in your dialplan if you explicitly want progress to be sent.
  (Reverts change 216430, closes issue #15957)
  Reported by: Pavel Troller on the Asterisk-Dev mailing list
  http://lists.digium.com/pipermail/asterisk-dev/2009-September/039897.html
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220289 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 220213 via svnmerge from
Sean Bright [Thu, 24 Sep 2009 18:19:41 +0000 (18:19 +0000)]
Merged revisions 220213 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r220213 | seanbright | 2009-09-24 14:18:18 -0400 (Thu, 24 Sep 2009) | 1 line

  Resolve parallel build warnings.

  Reported by Klaus Darilion on the asterisk-dev mailing list.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220217 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoEnsure the numeric portion of the P-Asserted-Identity header is properly escaped.
Matthew Nicholson [Thu, 24 Sep 2009 16:33:20 +0000 (16:33 +0000)]
Ensure the numeric portion of the P-Asserted-Identity header is properly escaped.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220174 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 220099 via svnmerge from
Sean Bright [Thu, 24 Sep 2009 14:44:08 +0000 (14:44 +0000)]
Merged revisions 220099 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r220099 | seanbright | 2009-09-24 10:41:57 -0400 (Thu, 24 Sep 2009) | 2 lines

  Remove the remaining bashisms in the Makefile/mkpkgconfig
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220100 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 220027 via svnmerge from
Michiel van Baak [Thu, 24 Sep 2009 08:36:18 +0000 (08:36 +0000)]
Merged revisions 220027 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r220027 | mvanbaak | 2009-09-24 10:33:50 +0200 (Thu, 24 Sep 2009) | 7 lines

  mkpkgconfig does not need bash so make it use /bin/sh
  This fixes building on all systems that don't have bash
  at /bin/bash

  Reported by _ys on #asterisk-dev
  Tested by _ys on #asterisk-dev
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220028 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix two possible crashes, one only in 1.6.1 and one in 1.6.1 forward.
Tilghman Lesher [Thu, 24 Sep 2009 07:39:44 +0000 (07:39 +0000)]
Fix two possible crashes, one only in 1.6.1 and one in 1.6.1 forward.
(closes issue #15739)
 Reported by: DLNoah, jeffg
 Patches:
       20090914__issue15739.diff.txt uploaded by tilghman (license 14)
       20090922__issue15739.diff.txt uploaded by tilghman (license 14)
 Tested by: DLNoah, jeffg

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219987 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd support for 'setvar=' for MGCP device lines, like other channel drivers provide.
Tilghman Lesher [Wed, 23 Sep 2009 23:38:19 +0000 (23:38 +0000)]
Add support for 'setvar=' for MGCP device lines, like other channel drivers provide.
(closes issue #14818)
 Reported by: alea-soluciones
 Patches:
       chan_mgcp-setvars-svn-trunk-r219899.patch uploaded by alea (license 514)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219952 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUpdate fax number to the legal fax, not the generic fax.
Tilghman Lesher [Wed, 23 Sep 2009 23:19:14 +0000 (23:19 +0000)]
Update fax number to the legal fax, not the generic fax.
(closes issue #15946)
 Reported by: jtodd
 Patches:
       leif-is-a-wuss.txt uploaded by jtodd (license 870)
 Tested by: jparker, tilghman, jtodd, russellb, mmichelson, seanbright, kpfleming, and the rest of the usual suspects

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219951 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd Mantis work flow documention.
Leif Madsen [Wed, 23 Sep 2009 17:46:46 +0000 (17:46 +0000)]
Add Mantis work flow documention.

This commit adds the doxygen changes that I've made to describe the Mantis
work flow documentation for the open source issue tracker. This should make
it easier to determine the flow of issues through the issue tracker, and what
those statuses mean.

(closes issue #15902)
Reported by: lmadsen
Patches:
      mantisworkflow.h uploaded by lmadsen (license 10)

Review: https://reviewboard.asterisk.org/r/367/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219895 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 219816 via svnmerge from
Tilghman Lesher [Tue, 22 Sep 2009 21:43:22 +0000 (21:43 +0000)]
Merged revisions 219816 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r219816 | tilghman | 2009-09-22 16:37:03 -0500 (Tue, 22 Sep 2009) | 10 lines

  When IMAP variables were changed during a reload, Voicemail did not use the new values.
  This change introduces a configuration version variable, which ensures that
  connections with the old values are not reused but are allowed to expire
  normally.
  (closes issue #15934)
   Reported by: viniciusfontes
   Patches:
         20090922__issue15934.diff.txt uploaded by tilghman (license 14)
   Tested by: viniciusfontes
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219818 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 219720 via svnmerge from
David Vossel [Mon, 21 Sep 2009 16:59:05 +0000 (16:59 +0000)]
Merged revisions 219720 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r219720 | dvossel | 2009-09-21 11:55:53 -0500 (Mon, 21 Sep 2009) | 3 lines

  Reverting merge 219520. This change was not necessary.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219721 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 219653 via svnmerge from
Tilghman Lesher [Sun, 20 Sep 2009 17:55:49 +0000 (17:55 +0000)]
Merged revisions 219653 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r219653 | tilghman | 2009-09-20 12:52:05 -0500 (Sun, 20 Sep 2009) | 8 lines

  Really stop the stream, when ast_closestream() is called.
  (closes issue #15129)
   Reported by: bmh
   Patches:
         20090918__issue15129.diff.txt uploaded by tilghman (license 14)
   Review:
         https://reviewboard.asterisk.org/r/372/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219654 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 219586 via svnmerge from
Russell Bryant [Sat, 19 Sep 2009 02:59:52 +0000 (02:59 +0000)]
Merged revisions 219586 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r219586 | russell | 2009-09-18 21:51:13 -0500 (Fri, 18 Sep 2009) | 6 lines

  Make sure the iax_pvt exists before dereferencing it.

  This fixes the latest crash posted on issue 15609.

  (issue #15609)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219587 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 219519 via svnmerge from
David Vossel [Fri, 18 Sep 2009 23:20:58 +0000 (23:20 +0000)]
Merged revisions 219519 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r219519 | dvossel | 2009-09-18 18:19:50 -0500 (Fri, 18 Sep 2009) | 9 lines

  iax2 frame double free

  The iax frame's retrans sched id was written over right
  before iax2_frame_free was called.  In iax2_frame_free that
  retrans id is used to delete the sched item.  By writing over
  the retrans field before the sched item could be deleted, it was
  possible for a retransmit to occur on a freed frame.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219520 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 219450 via svnmerge from
David Vossel [Fri, 18 Sep 2009 16:20:41 +0000 (16:20 +0000)]
Merged revisions 219450 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r219450 | dvossel | 2009-09-18 11:19:15 -0500 (Fri, 18 Sep 2009) | 14 lines

  via-header branches not updated correctly on INVITE

  INVITE requests must always contain a new unique branch id. When
  a new branch id is created for an INVITE, the dialog's invite_branch
  variable must be updated so CANCEL requests use the correct branch id.

  (closes issue #15262)
  Reported by: maniax
  Patches:
        asterisk-1.6.1.0-sip-branch.patch uploaded by tweety (license 608)
        invite_new_branch_trunk.diff uploaded by dvossel (license 671)
  Tested by: maniax, dvossel
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219451 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMissing value setting line for maxsecs/maxmessage
Tilghman Lesher [Fri, 18 Sep 2009 13:54:51 +0000 (13:54 +0000)]
Missing value setting line for maxsecs/maxmessage
(closes issue #15696)
 Reported by: fhackenberger
 Patches:
       maxsecs.patch uploaded by fhackenberger (license 592)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219412 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agofixes deadlock when performing directed pickup w Invite/replaces
David Vossel [Thu, 17 Sep 2009 22:37:28 +0000 (22:37 +0000)]
fixes deadlock when performing directed pickup w Invite/replaces

(closes issue #15340)
Reported by: lmsteffan
Patches:
      deadlock.patch uploaded by lmsteffan (license 779)
Tested by: lmsteffan

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219371 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 219320 via svnmerge from
Mark Michelson [Thu, 17 Sep 2009 22:22:01 +0000 (22:22 +0000)]
Merged revisions 219320 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r219320 | mmichelson | 2009-09-17 17:20:50 -0500 (Thu, 17 Sep 2009) | 6 lines

  Send a 100 Trying response when we detect a spiral.

  This was problematic during spiral tests at SIPit...
  along with some other things as well.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219324 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 219303 via svnmerge from
David Vossel [Thu, 17 Sep 2009 21:59:21 +0000 (21:59 +0000)]
Merged revisions 219303 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r219303 | dvossel | 2009-09-17 16:29:37 -0500 (Thu, 17 Sep 2009) | 21 lines

  INVITE w/Replaces deadlock fix

  This patch cleans up the locking logic in chan_sip.c's
  handle_invite_replaces() function as well as making use
  of ast_do_masquerade() rather than forcing the masquerade
  on an ast_read().  The code had several redundant unlocks
  that would result in 'freed more times than we've locked!'
  errors. I cleaned these up as well as moving all the unlock
  logic to the end of the function.  This patch should also
  resolve the issue people were having with the replacecall
  channel never being unlocked with one legged calls.

  (closes issue #15151)
  Reported by: irroot
  Patches:
        invite_w_replaces_1.4.diff uploaded by dvossel (license 671)
  Tested by: irroot, dvossel

  Review: https://reviewboard.asterisk.org/r/371/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219304 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoEnsure no spaces exist before "refresher=" when doing the comparison.
Joshua Colp [Thu, 17 Sep 2009 19:57:39 +0000 (19:57 +0000)]
Ensure no spaces exist before "refresher=" when doing the comparison.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219264 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoGet this compiling under dev-mode.
Sean Bright [Thu, 17 Sep 2009 16:25:38 +0000 (16:25 +0000)]
Get this compiling under dev-mode.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219230 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 219136 via svnmerge from
Matthew Nicholson [Thu, 17 Sep 2009 15:18:01 +0000 (15:18 +0000)]
Merged revisions 219136 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r219136 | mnicholson | 2009-09-17 09:58:39 -0500 (Thu, 17 Sep 2009) | 10 lines

  Prevent a potential race condition and crash when hanging up a channel by removing the channel from the channel list before begining channel tear down.

  This fix may potentially cause problems with CDR backends that access the channel a CDR is associated with via the channel list.  This fix makes the channel unavabile at the time when the CDR backend is invoked.  This has been documented in include/asterisk/cdr.h.

  (closes issue #15316)
  Reported by: vmarrone
  Tested by: mnicholson

  Review: https://reviewboard.asterisk.org/r/362/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219139 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd the 'E' option to exit ChanSpy, once the single channel it spied upon hangs up.
Tilghman Lesher [Thu, 17 Sep 2009 00:58:10 +0000 (00:58 +0000)]
Add the 'E' option to exit ChanSpy, once the single channel it spied upon hangs up.
In addition, there's a bit of cleanup to the arguments and documentation, in which
I discovered that the last feature added to this application duplicated an option
(oops!) and changed that option so that it now works.
(closes issue #14909)
 Reported by: junky
 Patches:
       __20090901-spy_hangup_trunk.diff uploaded by lmadsen (license 10)
 Tested by: amilcar, junky, flujan, lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219105 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 219023 via svnmerge from
Tilghman Lesher [Wed, 16 Sep 2009 23:42:12 +0000 (23:42 +0000)]
Merged revisions 219023 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r219023 | tilghman | 2009-09-16 18:21:53 -0500 (Wed, 16 Sep 2009) | 8 lines

  Properly deal with quotes in the arguments of '#exec' includes.
  (closes issue #15583)
   Reported by: pkempgen
   Patches:
         20090726__issue15583.diff.txt uploaded by tilghman (license 14)
         20090726__issue15583-1.4-4.diff.txt uploaded by pkempgen (license 169)
   Tested by: pkempgen
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219061 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDetect whether we actually have the long double type, before looking for those functions.
Tilghman Lesher [Wed, 16 Sep 2009 23:15:43 +0000 (23:15 +0000)]
Detect whether we actually have the long double type, before looking for those functions.
(closes issue #15017)
 Reported by: tzafrir
 Patches:
       20090916__issue15017.diff.txt uploaded by tilghman (license 14)
 Tested by: tzafrir

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219007 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRemove some unused defines from res_jabber.
Sean Bright [Wed, 16 Sep 2009 20:32:50 +0000 (20:32 +0000)]
Remove some unused defines from res_jabber.

(closes issue #15359)
Reported by: snuffy
Patches:
      bug_res_jabber_unused_defines.diff uploaded by snuffy (license 35)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218973 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoReverse order of args to fread.
Mark Michelson [Wed, 16 Sep 2009 19:25:36 +0000 (19:25 +0000)]
Reverse order of args to fread.

This way, we don't always write a null byte into
byte 1 of the buffer

(closes issue #15905)
Reported by: ebroad
Patches:
      freadfix.patch uploaded by ebroad (license 878)
Tested by: ebroad

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218933 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoOn TCP and TLS connections do not attempt to stop retransmission of the packet intern...
Joshua Colp [Wed, 16 Sep 2009 18:31:47 +0000 (18:31 +0000)]
On TCP and TLS connections do not attempt to stop retransmission of the packet internally.

This was preventing responses from being properly processed because the packet was not being found
causing handle_response to return prematurely.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218918 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 218867 via svnmerge from
David Brooks [Wed, 16 Sep 2009 18:06:42 +0000 (18:06 +0000)]
Merged revisions 218867 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218867 | dbrooks | 2009-09-16 13:00:45 -0500 (Wed, 16 Sep 2009) | 13 lines

  Fixes CID pattern matching behavior to mirror that of extension pattern matching.

  Pattern matching for extensions uses a type of scoring system, giving values for
  specificity to each character in the pattern. Unfortunately, this is done character
  by character, in order. This does lead to some less specific patterns being first
  in line for matching, but it will usually get the job done.

  This patch merely brings CID matching to the same level as extension matching.
  This patch does not attempt to tackle the problem shared by extension matching.

  (closes issue #14708)
  Reported by: klaus3000
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218868 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 218798 via svnmerge from
Russell Bryant [Wed, 16 Sep 2009 13:34:41 +0000 (13:34 +0000)]
Merged revisions 218798 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218798 | russell | 2009-09-16 08:33:43 -0500 (Wed, 16 Sep 2009) | 9 lines

  Remove the IAXy firmware from Asterisk.

  The firmware can now be found on downloads.digium.com, where the rest of our
  binary downloads live.  This was the last part of our Asterisk tarballs that
  was considered non-free by Debian.  :-)

  (closes issue #15838)
  Reported by: paravoid
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218799 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 218730 via svnmerge from
Tilghman Lesher [Tue, 15 Sep 2009 22:33:10 +0000 (22:33 +0000)]
Merged revisions 218730 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218730 | tilghman | 2009-09-15 17:27:41 -0500 (Tue, 15 Sep 2009) | 6 lines

  If the user enters the same password as before, don't signal an error when the change does nothing.
  (closes issue #15492)
   Reported by: cbbs70a
   Patches:
         20090713__issue15492.diff.txt uploaded by tilghman (license 14)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218731 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoupward bound checking for port string to int conversion
David Vossel [Tue, 15 Sep 2009 19:22:37 +0000 (19:22 +0000)]
upward bound checking for port string to int conversion

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218687 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 218623 via svnmerge
Jeff Peeler [Tue, 15 Sep 2009 16:30:43 +0000 (16:30 +0000)]
Blocked revisions 218623 via svnmerge

........
  r218623 | jpeeler | 2009-09-15 11:29:27 -0500 (Tue, 15 Sep 2009) | 3 lines

  Fix small memory leak in handle_init_event by always destroying the pthread
  attr before returning.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218629 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 218578 via svnmerge from
Matthew Nicholson [Tue, 15 Sep 2009 16:15:02 +0000 (16:15 +0000)]
Merged revisions 218578 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218578 | mnicholson | 2009-09-15 11:03:54 -0500 (Tue, 15 Sep 2009) | 8 lines

  Send request contact header field with response to registrer queries instead of the address of record.

  (closes issue #14438)
  Reported by: ravindrad
  Patches:
        regquerypatch uploaded by ravindrad (license 684)
  Tested by: ravindrad
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218586 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd some changes related to 218430.
Jeff Peeler [Tue, 15 Sep 2009 16:12:49 +0000 (16:12 +0000)]
Add some changes related to 218430.

* Remove thread_spawned in handle_init_event since it was never used
* Always check handle_init_event in case a channel is destroyed

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218583 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 218577 via svnmerge from
Tilghman Lesher [Tue, 15 Sep 2009 16:04:41 +0000 (16:04 +0000)]
Merged revisions 218577 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218577 | tilghman | 2009-09-15 11:01:17 -0500 (Tue, 15 Sep 2009) | 9 lines

  Ensure FollowMe sets language in channels it creates.
  Also, not in the original bug report, but related fields are accountcode and
  musicclass, and the inheritance of datastores.
  (closes issue #15372)
   Reported by: Romik
   Patches:
         20090828__issue15372.diff.txt uploaded by tilghman (license 14)
   Tested by: cervajs
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218579 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUse a better method of ensuring null-termination of the buffer
Mark Michelson [Tue, 15 Sep 2009 15:40:14 +0000 (15:40 +0000)]
Use a better method of ensuring null-termination of the buffer
while reading the SDP when using TCP.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218566 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoEnsure that SDP read from TCP socket is null-terminated.
Mark Michelson [Tue, 15 Sep 2009 15:05:53 +0000 (15:05 +0000)]
Ensure that SDP read from TCP socket is null-terminated.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218504 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 218497 via svnmerge from
Kevin P. Fleming [Tue, 15 Sep 2009 15:02:21 +0000 (15:02 +0000)]
Merged revisions 218497 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218497 | kpfleming | 2009-09-15 10:55:58 -0400 (Tue, 15 Sep 2009) | 1 line

  Use proper hostname for downloading sound files.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218500 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix off-by-one error when reading SDP sent over TCP.
Mark Michelson [Tue, 15 Sep 2009 14:59:50 +0000 (14:59 +0000)]
Fix off-by-one error when reading SDP sent over TCP.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218499 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix false error message on DAHDI_EVENT_REMOVED (RESULT_SUCCESS == 0)
Tzafrir Cohen [Tue, 15 Sep 2009 10:24:55 +0000 (10:24 +0000)]
Fix false error message on DAHDI_EVENT_REMOVED (RESULT_SUCCESS == 0)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218465 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 218401 via svnmerge from
Jeff Peeler [Mon, 14 Sep 2009 22:38:25 +0000 (22:38 +0000)]
Merged revisions 218401 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218401 | jpeeler | 2009-09-14 16:47:11 -0500 (Mon, 14 Sep 2009) | 11 lines

  Fix handling of DAHDI_EVENT_REMOVED event to prevent crash in do_monitor.

  After talking to rmudgett about some of his recent iflist locking changes, it
  was determined that the only place that would destroy a channel without being
  explicitly to do so was in handle_init_event. The loop to walk the interface
  list has been modified to wait to destroy the channel until the dahdi_pvt of
  the channel to be destroyed is no longer needed.

  (closes issue #15378)
  Reported by: samy
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218430 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd support for multiple interface lists.
Richard Mudgett [Mon, 14 Sep 2009 20:08:11 +0000 (20:08 +0000)]
Add support for multiple interface lists.

Also unlink the sig_pri_pri.pvts[] pointer in destroy_dahdi_pvt().

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218365 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRecorded merge of revisions 218331 via svnmerge from
Tilghman Lesher [Mon, 14 Sep 2009 19:29:48 +0000 (19:29 +0000)]
Recorded merge of revisions 218331 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218331 | tilghman | 2009-09-14 14:16:35 -0500 (Mon, 14 Sep 2009) | 4 lines

  Don't say "Please try again" if we don't give the user another chance to try again.
  (issue #15055, SWP-129)
   Reported by: jthurman
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218361 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDo not attempt to add a parking extension if an error occurred while reading the...
Joshua Colp [Mon, 14 Sep 2009 18:16:39 +0000 (18:16 +0000)]
Do not attempt to add a parking extension if an error occurred while reading the configuration.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218295 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 218223 via svnmerge from
Matthew Nicholson [Mon, 14 Sep 2009 14:57:23 +0000 (14:57 +0000)]
Merged revisions 218223 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218223 | mnicholson | 2009-09-14 09:53:57 -0500 (Mon, 14 Sep 2009) | 8 lines

  Ensure we don't pickup ourselves when doing pickup by exten.

  (closes issue #15100)
  Reported by: lmsteffan
  Patches:
        (modified) pickup.patch uploaded by lmsteffan (license 779)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218224 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agogcc 4.4: Remove a nop memset size 0 that annoys gcc
Tzafrir Cohen [Sun, 13 Sep 2009 17:34:11 +0000 (17:34 +0000)]
gcc 4.4: Remove a nop memset size 0 that annoys gcc

This memset doesn't write beyond the end of the buffer.
(tmpbuf has size of 4).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218184 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoget rid of mfcr2 monitor thread condition, is problematic
Moises Silva [Sun, 13 Sep 2009 05:51:46 +0000 (05:51 +0000)]
get rid of mfcr2 monitor thread condition, is problematic

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218150 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agouse the actual given ip address for 'rtp set debug ip <foo>' instead of the word...
Michiel van Baak [Sat, 12 Sep 2009 13:08:16 +0000 (13:08 +0000)]
use the actual given ip address for 'rtp set debug ip <foo>' instead of the word 'ip'

(closes issue #15711)
Reported by: davidw
Patches:
      2009082800-rtpdebug.diff.txt uploaded by mvanbaak (license 7)
Tested by: davidw

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218107 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoCheck the origination priority for more matches, not the current priority.
Tilghman Lesher [Fri, 11 Sep 2009 05:58:11 +0000 (05:58 +0000)]
Check the origination priority for more matches, not the current priority.
Found by Pavel Troller on the -dev list.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218050 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 217989 via svnmerge from
Tilghman Lesher [Thu, 10 Sep 2009 23:54:51 +0000 (23:54 +0000)]
Merged revisions 217989 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r217989 | tilghman | 2009-09-10 18:52:22 -0500 (Thu, 10 Sep 2009) | 3 lines

  Don't ring another channel, if there's not enough time for a queue member to answer.
  (Fixes AST-228)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217990 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoCleanup approach in 217804 and don't reach inside the sig_pvt.
Jeff Peeler [Thu, 10 Sep 2009 23:49:09 +0000 (23:49 +0000)]
Cleanup approach in 217804 and don't reach inside the sig_pvt.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217987 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAllow do not disturb to be set on analog channels via the CLI and AMI.
Jeff Peeler [Thu, 10 Sep 2009 23:29:14 +0000 (23:29 +0000)]
Allow do not disturb to be set on analog channels via the CLI and AMI.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217954 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 217917 via svnmerge
Tilghman Lesher [Thu, 10 Sep 2009 23:16:24 +0000 (23:16 +0000)]
Blocked revisions 217917 via svnmerge

........
  r217917 | tilghman | 2009-09-10 18:15:21 -0500 (Thu, 10 Sep 2009) | 2 lines

  Backport realtime fix to 1.4
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217918 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMake calltoken support work with realtime users and peers.
Tilghman Lesher [Thu, 10 Sep 2009 23:12:16 +0000 (23:12 +0000)]
Make calltoken support work with realtime users and peers.
In the course of this, I also found that the results of ast_gethostbyname
were being used incorrectly in both chan_iax2 and chan_sip, so both have
been fixed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217916 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoCleaned up chan_dahdi iflist handling and locking.
Richard Mudgett [Thu, 10 Sep 2009 22:31:12 +0000 (22:31 +0000)]
Cleaned up chan_dahdi iflist handling and locking.

*  Fixed walking the iflist so it is always done with the iflock locked.
*  Simplified iflist walking routines.
*  Created chan_dahdi iflist insertion and extraction routines.
*  Fixed duplicate_pseudo() malloc fail handling.
*  Fixed infinite loop in action_dahdishowchannels() when showing a single channel.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217912 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMiscellaneous minor changes.
Richard Mudgett [Thu, 10 Sep 2009 22:11:17 +0000 (22:11 +0000)]
Miscellaneous minor changes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217873 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 217806 via svnmerge from
David Vossel [Thu, 10 Sep 2009 21:07:47 +0000 (21:07 +0000)]
Merged revisions 217806 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r217806 | dvossel | 2009-09-10 16:06:07 -0500 (Thu, 10 Sep 2009) | 22 lines

  IAX2 encryption regression

  The IAX2 Call Token security patch inadvertently broke the use of
  encryption due to the reorganization of code in the socket_process()
  function.  When encryption is used, an incoming full frame must first
  be decrypted before the information elements can be parsed.  The
  security release mistakenly moved IE parsing before decryption in
  order to process the new Call Token IE.  To resolve this, decryption
  of full frames is once again done before looking into the frame.  This
  involves searching for an existing callno, checking the pvt to see if
  encryption is turned on, and decrypting the packet before the internal
  fields of the full frame are accessed.

  (closes issue #15834)
  Reported by: karesmakro
  Patches:
        iax2_encryption_fix_1.4.diff uploaded by dvossel (license 671)
  Tested by: dvossel, karesmakro

  Review: https://reviewboard.asterisk.org/r/355/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217807 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix crash during attended transfer over PRI.
Jeff Peeler [Thu, 10 Sep 2009 20:52:57 +0000 (20:52 +0000)]
Fix crash during attended transfer over PRI.

The owner pointers in the sig_pri_chan structure were not getting updated
in dahdi_fixup.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217804 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoStop caller id transmission when offhook event detected.
Jeff Peeler [Thu, 10 Sep 2009 20:18:30 +0000 (20:18 +0000)]
Stop caller id transmission when offhook event detected.

This fixes the problem that would occur if an analog phone was picked up while
the caller id was being sent. The caller id before sent the whole spill even
after pickup and is now corrected.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217744 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 217735 via svnmerge
Olle Johansson [Thu, 10 Sep 2009 19:55:16 +0000 (19:55 +0000)]
Blocked revisions 217735 via svnmerge

........
r217735 | oej | 2009-09-10 21:52:19 +0200 (Tor, 10 Sep 2009) | 4 lines

Reinstate muted that was removed by mistake.

muted doesn't compile any more on os/x, so I have to disable it in order to testcompile other code...

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217737 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoSets the correct musicclass after an announcement
Matthias Nick [Thu, 10 Sep 2009 19:39:41 +0000 (19:39 +0000)]
Sets the correct musicclass after an announcement

(closes issue #15279)
Reported by: mbeckwell
Patches:
      patch.txt uploaded by mnick (license )
Tested by: mnick

(closes issue #15832)
Reported by: mbeckwell
Patches:
      patch.txt uploaded by mnick (license 874)
Tested by: mnick

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217730 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 217668 via svnmerge
Olle Johansson [Thu, 10 Sep 2009 19:09:02 +0000 (19:09 +0000)]
Blocked revisions 217668 via svnmerge

........
r217668 | oej | 2009-09-10 21:07:24 +0200 (Tor, 10 Sep 2009) | 9 lines

Remove harmful code that causes endless loops.
Remove code that causes loops in registrations.

We have agreed that the patch that this code was part of was bad. I am ripping out the code that causes
the issue. putnopvut needs to check the rest of the patch, if it needs to be changed as well.

This solves the issue reported in #15540, but needs more work before we close it (as described above).

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217669 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDon't assign UINT_MAX to an INT.
Olle Johansson [Thu, 10 Sep 2009 18:29:21 +0000 (18:29 +0000)]
Don't assign UINT_MAX to an INT.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217663 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoVerify support for wide ODBC character types before using them.
Tilghman Lesher [Thu, 10 Sep 2009 18:17:14 +0000 (18:17 +0000)]
Verify support for wide ODBC character types before using them.
(closes issue #15870)
 Reported by: nic_bellamy

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217638 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoInclude ActionID in all events that are responsed to AMI Action SIPShowRegistry
Olle Johansson [Thu, 10 Sep 2009 12:06:55 +0000 (12:06 +0000)]
Include ActionID in all events that are responsed to AMI Action SIPShowRegistry

(closes issue #15868)
Reported by: nic_bellamy
Patches:
      manager_SIPshowregistry_actionid.patch uploaded by nic bellamy (license 299)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217593 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix available() for SS7, MFC/R2, and pseudo channels.
Richard Mudgett [Thu, 10 Sep 2009 00:35:30 +0000 (00:35 +0000)]
Fix available() for SS7, MFC/R2, and pseudo channels.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217560 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoast_log replaced for ast_verbose in MFCR2 event notifications
Moises Silva [Wed, 9 Sep 2009 21:48:04 +0000 (21:48 +0000)]
ast_log replaced for ast_verbose in MFCR2 event notifications

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217524 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDon't report transfer success until we actually know. 1xx messages are not final.
Olle Johansson [Wed, 9 Sep 2009 20:09:31 +0000 (20:09 +0000)]
Don't report transfer success until we actually know. 1xx messages are not final.

Related to #12713

Patch by oej

A big thank you to file for finally fixing the transfer() dialplan application.
I've been waiting for years for this. Great work!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217482 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agogcc 4.4 fix: union instead of cast
Tzafrir Cohen [Wed, 9 Sep 2009 18:52:48 +0000 (18:52 +0000)]
gcc 4.4 fix: union instead of cast

gcc 4.4 has more strict rules for aliasing. It doesn't like a
struct sockaddr_in pointer pointing to a struct sockaddr. So we make it
a union.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217445 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoProperly terminate the response to the manager Ping action.
Sean Bright [Wed, 9 Sep 2009 12:11:12 +0000 (12:11 +0000)]
Properly terminate the response to the manager Ping action.

In passing, correct the formatting of the Timestamp attribute so that there is a
space after the colon and before the value.

(closes issue #15861)
Reported by: Ivan

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217408 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoNot having any TLS session to write to is a serious XMIT_ERROR.
Olle Johansson [Wed, 9 Sep 2009 10:39:43 +0000 (10:39 +0000)]
Not having any TLS session to write to is a serious XMIT_ERROR.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217368 65c4cc65-6c06-0410-ace0-fbb531ad65f3