asterisk/asterisk.git
11 years agoAdd an appropriate goto if ast_call fails
Mark Michelson [Thu, 11 Dec 2008 20:21:44 +0000 (20:21 +0000)]
Add an appropriate goto if ast_call fails

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@163198 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix the "failed" extension for outgoing calls.
Russell Bryant [Thu, 11 Dec 2008 20:07:47 +0000 (20:07 +0000)]
Fix the "failed" extension for outgoing calls.

The conversion to use ast_check_hangup() everywhere instead of checking the softhangup
flag directly introduced this problem.  The issue is that ast_check_hangup() checked
for tech_pvt to be NULL.  Unfortunately, this will be NULL is some valid circumstances,
such as with a dummy channel.

The fix is simple.  Don't check tech_pvt.  It's pointless, because the code path that
sets this to NULL is when the channel hangup callback gets called.  This happens inside
of ast_hangup(), which is the same function responsible for freeing the channel.  Any
code calling ast_check_hangup() better not be calling it after that point, and if so,
we have a bigger problem at hand.

(closes issue #14035)
Reported by: erogoza

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@163171 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoSometimes even Linux needs -lm to link libtonezone, such as when libtonezone
Tilghman Lesher [Thu, 11 Dec 2008 20:02:35 +0000 (20:02 +0000)]
Sometimes even Linux needs -lm to link libtonezone, such as when libtonezone
is compiled statically.
(closes issue #13887)
 Reported by: tzafrir

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@163168 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoReduce indentation level of ast_feature_request_and_dial
Mark Michelson [Thu, 11 Dec 2008 19:40:18 +0000 (19:40 +0000)]
Reduce indentation level of ast_feature_request_and_dial

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@163166 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 163092 via svnmerge from
Russell Bryant [Thu, 11 Dec 2008 17:06:16 +0000 (17:06 +0000)]
Merged revisions 163092 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r163092 | russell | 2008-12-11 10:54:51 -0600 (Thu, 11 Dec 2008) | 11 lines

Fix an issue that made it so you could only have a single caller executing
a custom feature at a time.  This was especially problematic when custom
features ran for any appreciable amount of time.

The fix turned out to be quite simple.  The dynamic features are now stored
in a read/write list instead of a list using a mutex.

(closes issue #13478)
Reported by: neutrino88
Fix suggested by file

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@163094 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 163088 via svnmerge from
Tilghman Lesher [Thu, 11 Dec 2008 16:52:24 +0000 (16:52 +0000)]
Merged revisions 163088 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r163088 | tilghman | 2008-12-11 10:51:27 -0600 (Thu, 11 Dec 2008) | 6 lines

  Don't wait forever, if there's a specified recording timeout.
  (closes issue #13885)
   Reported by: bamby
   Patches:
         res_agi.c.patch uploaded by bamby (license 430)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@163089 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 163084 via svnmerge from
Mark Michelson [Thu, 11 Dec 2008 16:47:34 +0000 (16:47 +0000)]
Merged revisions 163084 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r163084 | mmichelson | 2008-12-11 10:46:22 -0600 (Thu, 11 Dec 2008) | 4 lines

Revert this cast to long. Using time_t here causes build failures on a
FreeBSD 32-bit build.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@163085 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 163080 via svnmerge from
Mark Michelson [Thu, 11 Dec 2008 16:33:16 +0000 (16:33 +0000)]
Merged revisions 163080 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r163080 | mmichelson | 2008-12-11 10:24:43 -0600 (Thu, 11 Dec 2008) | 14 lines

Fix a potential crash due to unsafe datastore handling.

This patch also contains a conversion from using long to time_t
for representing times for a queue, as well as some whitespace
fixes.

(closes issue #14060)
Reported by: nivek
Patches:
      datastore_fixup.patch.corrected uploaded by nivek (license 636)
  with slight modification from me
Tested by: nivek

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@163081 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix some of the grammar issues in doc/tex/qos.tex.
Sean Bright [Thu, 11 Dec 2008 15:40:07 +0000 (15:40 +0000)]
Fix some of the grammar issues in doc/tex/qos.tex.

(closes issue #14049)
Reported by: kshumard
Patches:
      doc.tex.qos.tex.patch uploaded by kshumard (license 92)
      (Slight modifications by seanbright)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@163037 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoWhen a device registers to use it is entirely possible that they may be in use, so...
Joshua Colp [Thu, 11 Dec 2008 15:05:49 +0000 (15:05 +0000)]
When a device registers to use it is entirely possible that they may be in use, so tell the core that we don't know the devstate and have it ask us for it.
(closes issue #13525)
Reported by: pj

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162997 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoPreviously missing line, now the substitution works correctly
Tilghman Lesher [Wed, 10 Dec 2008 23:01:14 +0000 (23:01 +0000)]
Previously missing line, now the substitution works correctly

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162930 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162926 via svnmerge from
Jeff Peeler [Wed, 10 Dec 2008 22:53:34 +0000 (22:53 +0000)]
Merged revisions 162926 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r162926 | jpeeler | 2008-12-10 16:52:51 -0600 (Wed, 10 Dec 2008) | 3 lines

Oops, inverted logic for a strcasecmp check. Pointed out by mmichelson, thanks!

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162927 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix reloads of aliased CLI commands. Due to changes done to turn it into a single...
Joshua Colp [Wed, 10 Dec 2008 22:48:58 +0000 (22:48 +0000)]
Fix reloads of aliased CLI commands. Due to changes done to turn it into a single memory allocation we can't just use the existing CLI alias structure. We have to destroy all existing ones and then create new ones.
(closes issue #14054)
Reported by: pj

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162923 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoChecking global variables here actually overwrote the previous substitution by
Tilghman Lesher [Wed, 10 Dec 2008 22:48:09 +0000 (22:48 +0000)]
Checking global variables here actually overwrote the previous substitution by
channel variables, and in any case, was redundant;
pbx_substitute_variables_helper ALREADY does substitution for global
variables.
(closes issue #13327)
 Reported by: pj

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162922 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162874 via svnmerge from
Jeff Peeler [Wed, 10 Dec 2008 22:11:46 +0000 (22:11 +0000)]
Merged revisions 162874 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r162874 | jpeeler | 2008-12-10 16:04:18 -0600 (Wed, 10 Dec 2008) | 5 lines

(closes issue #13229)
Reported by: clegall_proformatique

Ensure that moh_generate does not return prematurely before local_ast_moh_stop is called. Also, the sleep in mp3_spawn now only occurs for http locations since it seems to have been added originally only for failing media streams.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162891 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162804 via svnmerge from
Joshua Colp [Wed, 10 Dec 2008 19:02:57 +0000 (19:02 +0000)]
Merged revisions 162804 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r162804 | file | 2008-12-10 15:01:17 -0400 (Wed, 10 Dec 2008) | 6 lines

  Fix subscription based MWI up a bit. We only want to put sip: at the beginning of the URI if it is not already there and revert code to ignore destination check if subscribing for MWI.
  (closes issue #12560)
  Reported by: vsauer
  Patches:
        patch001.diff uploaded by ramonpeek (license 266)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162805 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162738 via svnmerge from
Joshua Colp [Wed, 10 Dec 2008 17:53:09 +0000 (17:53 +0000)]
Merged revisions 162738 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r162738 | file | 2008-12-10 13:50:43 -0400 (Wed, 10 Dec 2008) | 6 lines

  When a SIP peer unregisters set the expiry time back to 0 so that the 200 OK contains an expires of 0.
  (closes issue #13599)
  Reported by: hjourdain
  Patches:
        chan_sip.c.diff uploaded by hjourdain (license 583)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162739 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoadd tab completion for 'core set debug X filename.c'
Michiel van Baak [Wed, 10 Dec 2008 17:09:15 +0000 (17:09 +0000)]
add tab completion for 'core set debug X filename.c'

(closes issue #13969)
Reported by: jtodd
Patches:
      20081205__bug13969.diff.txt uploaded by Corydon76 (license 14)
Tested by: mvanbaak, eliel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162687 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 162671 via svnmerge
Steve Murphy [Wed, 10 Dec 2008 16:52:05 +0000 (16:52 +0000)]
Blocked revisions 162671 via svnmerge

........
r162671 | murf | 2008-12-10 09:45:01 -0700 (Wed, 10 Dec 2008) | 22 lines

(closes issue #14022)
Reported by: wetwired
Tested by: murf

I checked, and I added a mod to the trunk version
of Asterisk that would make it 8-bit transparent
on 27 Nov 2007, but I made no such updates to
1.4. My best guess is that 1.4 was released, and
it was not appropriate to commit an enhancement.

But I'm going to add the same fixes to 1.4 now,
for the following reasons:
1. wetwired is correct; 1.4 is **mostly** 8-bit
   transparent now. This is because the lexical
   token forming rules use . in most 'word'
   state continuances.  It's just the beginning
   of a 'word' that is picky.
2. Accepting 8-bit chars in some places and
   not others leads to bug reports like this.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162675 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 162670 via svnmerge
Mark Michelson [Wed, 10 Dec 2008 16:46:51 +0000 (16:46 +0000)]
Blocked revisions 162670 via svnmerge

........
r162670 | mmichelson | 2008-12-10 10:44:37 -0600 (Wed, 10 Dec 2008) | 14 lines

Update to stringfield handling so that side-effects on
parameters are not evaluated multiple times.

An example where this caused a problem was in chan_sip.c, with
the line

  ast_string_field_set(p, fromdomain, ++fromdomain);

This patch was originally uploaded to issue #13783 by
jamessan. While the issue was closed for other reasons, this
patch is valid and fixes a separate problem, and is thus
being committed.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162672 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162659 via svnmerge from
Mark Michelson [Wed, 10 Dec 2008 16:39:10 +0000 (16:39 +0000)]
Merged revisions 162659 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r162659 | mmichelson | 2008-12-10 10:10:25 -0600 (Wed, 10 Dec 2008) | 8 lines

Add missing documentation to misdn.txt

(closes issue #14052)
Reported by: festr
Patches:
      misdn.txt.patch uploaded by festr (license 443)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162667 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162663 via svnmerge from
Mark Michelson [Wed, 10 Dec 2008 16:34:35 +0000 (16:34 +0000)]
Merged revisions 162663 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r162663 | mmichelson | 2008-12-10 10:24:56 -0600 (Wed, 10 Dec 2008) | 11 lines

Revert fix for issue 13570. It has caused more problems than
it helped to fix.

(closes issue #13783)
Reported by: navkumar

(closes issue #14025)
Reported by: ffs

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162664 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFreeBSD also needs libgen.h
Joshua Colp [Wed, 10 Dec 2008 16:11:06 +0000 (16:11 +0000)]
FreeBSD also needs libgen.h
(closes issue #14051)
Reported by: ys
Patches:
      res_http_post.c.diff uploaded by ys (license 281)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162660 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162653 via svnmerge from
Joshua Colp [Wed, 10 Dec 2008 16:06:59 +0000 (16:06 +0000)]
Merged revisions 162653 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r162653 | file | 2008-12-10 12:05:29 -0400 (Wed, 10 Dec 2008) | 6 lines

  Increment the sequence number on the end packets for RFC2833. After reading the RFC some more and doing some testing I agree with this change.
  (closes issue #12983)
  Reported by: vt
  Patches:
        dtmf_inc_seqnum_on_end_pkts.diff uploaded by vt (license 520)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162656 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoWhen transmitting a register set the socket port to the local one for the transport...
Joshua Colp [Wed, 10 Dec 2008 15:22:26 +0000 (15:22 +0000)]
When transmitting a register set the socket port to the local one for the transport being used, not the port for the remote server.
(closes issue #13633)
Reported by: performer

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162619 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMake res_snmp.so compile on OpenBSD.
Michiel van Baak [Wed, 10 Dec 2008 11:34:09 +0000 (11:34 +0000)]
Make res_snmp.so compile on OpenBSD.

OpenBSD uses an old version of gcc which throws an error
if you use a macro that's not #defined

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162583 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFinish conversion to using ARRAY_LEN and remove it as a janitor project.
Joshua Colp [Wed, 10 Dec 2008 01:09:06 +0000 (01:09 +0000)]
Finish conversion to using ARRAY_LEN and remove it as a janitor project.
(closes issue #14032)
Reported by: bkruse
Patches:
      14032.patch uploaded by bkruse (license 132)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162542 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoit does help if the compiler attribute syntax is correct
Kevin P. Fleming [Tue, 9 Dec 2008 23:41:02 +0000 (23:41 +0000)]
it does help if the compiler attribute syntax is correct

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162488 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162463 via svnmerge from
Tilghman Lesher [Tue, 9 Dec 2008 23:10:34 +0000 (23:10 +0000)]
Merged revisions 162463 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r162463 | tilghman | 2008-12-09 17:08:53 -0600 (Tue, 09 Dec 2008) | 2 lines

  Oops, should be "tz", not "zonetag".
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162466 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd some additional Asterisk project developer documentation.
Russell Bryant [Tue, 9 Dec 2008 22:38:41 +0000 (22:38 +0000)]
Add some additional Asterisk project developer documentation.

After the nightly update of the documentation on asterisk.org, I'll post
an update to asterisk-dev with a pointer to the changes.  This covers some
release branch and commit policy information.  None of this should be a
surprise, since it's just documenting what we have already been doing.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162418 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162413 via svnmerge from
Russell Bryant [Tue, 9 Dec 2008 22:25:06 +0000 (22:25 +0000)]
Merged revisions 162413 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r162413 | russell | 2008-12-09 16:17:39 -0600 (Tue, 09 Dec 2008) | 8 lines

Remove the test_for_thread_safety() function completely.

The test is not valid.  Besides, if we actually suspected that recursive
mutexes were not working, we would get a ton of LOG_ERROR messages when
DEBUG_THREADS is turned on.

(inspired by a discussion on the asterisk-dev list)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162414 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162348 via svnmerge from
Tilghman Lesher [Tue, 9 Dec 2008 21:57:09 +0000 (21:57 +0000)]
Merged revisions 162348 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r162348 | tilghman | 2008-12-09 15:53:25 -0600 (Tue, 09 Dec 2008) | 4 lines

  We appear to have documented tz= in the [general] section of voicemail.conf,
  without actually having implemented it.  Oops.
  (Reported by Olivier on the -users list)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162355 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162341 via svnmerge from
Joshua Colp [Tue, 9 Dec 2008 21:16:37 +0000 (21:16 +0000)]
Merged revisions 162341 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r162341 | file | 2008-12-09 17:14:29 -0400 (Tue, 09 Dec 2008) | 4 lines

  Add 'down' as a valid state for directed call pickup. This creeps up when we receive session progress when dialing a device and not ringing.
  (closes issue #14005)
  Reported by: ddl
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162342 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162286 via svnmerge from
Russell Bryant [Tue, 9 Dec 2008 20:59:54 +0000 (20:59 +0000)]
Merged revisions 162286 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r162286 | russell | 2008-12-09 14:57:35 -0600 (Tue, 09 Dec 2008) | 9 lines

Fix an issue where callers on an incoming call on an SLA trunk would not hear ringback.

We need to make sure that we don't start writing audio to the trunk channel until we're
actually ready to answer it.  Otherwise, the channel driver will treat it as inband
progress, even though all they are getting is silence.

(closes issue #12471)
Reported by: mthomasslo

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162291 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162273 via svnmerge from
Joshua Colp [Tue, 9 Dec 2008 20:46:11 +0000 (20:46 +0000)]
Merged revisions 162273 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r162273 | file | 2008-12-09 16:44:32 -0400 (Tue, 09 Dec 2008) | 4 lines

  Fix double declaration of 'x' on the PPC platform.
  (closes issue #14038)
  Reported by: ffloimair
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162275 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162264 via svnmerge from
Steve Murphy [Tue, 9 Dec 2008 20:40:31 +0000 (20:40 +0000)]
Merged revisions 162264 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r162264 | murf | 2008-12-09 13:20:54 -0700 (Tue, 09 Dec 2008) | 1 line

In discussion with seanbright on #asterisk-dev,  I have added a default rule, and an option to suppress the default rule from being generated in the flex output, for the sake of those OS's where they didn't tweak flex's ECHO macro, and the compiler doesn't like it. The regressions are OK with this.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162271 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162265 via svnmerge from
Mark Michelson [Tue, 9 Dec 2008 20:30:07 +0000 (20:30 +0000)]
Merged revisions 162265 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r162265 | mmichelson | 2008-12-09 14:28:44 -0600 (Tue, 09 Dec 2008) | 6 lines

If we fail to start a thread for the pbx to run in, we need to
be sure to decrease the number of active calls on the system.

This fix may relate to ABE-1713, but it is not certain yet.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162266 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162204 via svnmerge from
Joshua Colp [Tue, 9 Dec 2008 19:48:35 +0000 (19:48 +0000)]
Merged revisions 162204 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r162204 | file | 2008-12-09 15:47:07 -0400 (Tue, 09 Dec 2008) | 7 lines

  Make sure that the timestamp for DTMF is not the same as the previous voice frame and do not send audio when transmitting DTMF as this confuses some equipment.
  (closes issue #13209)
  Reported by: ip-rob
  Patches:
        13209.diff uploaded by file (license 11)
  Tested by: ip-rob, bujones
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162205 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 162071 via svnmerge
Tilghman Lesher [Tue, 9 Dec 2008 19:26:08 +0000 (19:26 +0000)]
Blocked revisions 162071 via svnmerge

........
  r162071 | tilghman | 2008-12-09 11:07:50 -0600 (Tue, 09 Dec 2008) | 3 lines

  For some reason, after a distclean, gcc started returning
  'value computed is not used'.  Fixing (for --enable-dev-mode).
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162203 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162188 via svnmerge from
Joshua Colp [Tue, 9 Dec 2008 19:08:39 +0000 (19:08 +0000)]
Merged revisions 162188 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r162188 | file | 2008-12-09 15:06:14 -0400 (Tue, 09 Dec 2008) | 4 lines

  Take video into account when early bridging RTP.
  (closes issue #13535)
  Reported by: davidw
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162197 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162136 via svnmerge from
Steve Murphy [Tue, 9 Dec 2008 18:35:35 +0000 (18:35 +0000)]
Merged revisions 162136 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r162136 | murf | 2008-12-09 11:13:39 -0700 (Tue, 09 Dec 2008) | 1 line

Previous fix used ast_malloc and ast_copy_string and messed up the standalone stuff. Fixed.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162140 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162013 via svnmerge from
Steve Murphy [Tue, 9 Dec 2008 17:18:03 +0000 (17:18 +0000)]
Merged revisions 162013 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r162013 | murf | 2008-12-09 09:31:55 -0700 (Tue, 09 Dec 2008) | 45 lines

(closes issue #14019)
Reported by: ckjohnsonme
Patches:
      14019.diff uploaded by murf (license 17)
Tested by: ckjohnsonme, murf

This crash was the result of a few small errors that
would combine in 64-bit land to result in a crash.

32-bit land might have seen these combine to mysteriously
drop the args to an application call, in certain
circumstances.

Also, in trying to find this bug, I spotted
a situation in the flex input, where, in passing
back a 'word' to the parser, it would allocate
a buffer larger than necessary. I changed the
usage in such situations, so that strdup was
not used, but rather, an ast_malloc, followed
by ast_copy_string.

I removed a field from the pval struct, in
u2, that was never getting used, and set in
one spot in the code. I believe it was an
artifact of a previous fix to make switch
cases work invisibly with extens.

And, for goto's I removed a '!' from
before a strcmp, that has been there
since the initial merging of AEL2, that
might prevent the proper target of a
goto from being found. This was pretty
harmless on its own, as it would just
louse up a consistency check for users.

Many thanks to ckjohnsonme for providing
a simplified and complete set of information
about the bug, that helped considerably in
finding and fixing the problem.

Now, to get aelparse up and running again
in trunk, and out of its "horribly broken" state,
so I can run the regression suite!

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162079 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 162014 via svnmerge from
Russell Bryant [Tue, 9 Dec 2008 16:47:39 +0000 (16:47 +0000)]
Merged revisions 162014 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r162014 | russell | 2008-12-09 10:46:53 -0600 (Tue, 09 Dec 2008) | 5 lines

Allow DISA to handle extensions that start with #.

(closes issue #13330)
Reported by: jcovert

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@162016 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 161948 via svnmerge from
Russell Bryant [Tue, 9 Dec 2008 14:57:39 +0000 (14:57 +0000)]
Merged revisions 161948 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r161948 | russell | 2008-12-09 08:52:25 -0600 (Tue, 09 Dec 2008) | 15 lines

Fix a problem with GROUP() settings on a masquerade.

The previous code carried over group settings from the old channel to the new
one.  However, it did nothing with the group settings that were already on the
new channel.  This patch removes all group settings that already existed on the
new channel.

I have a more complicated version of this patch which addresses only the most
blatant problem with this, which is that a channel can end up with multiple
group settings in the same category.  However, I could not think of a use case
for keeping any of the group settings from the old channel, so I went this route
for now.

(closes AST-152)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161951 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAvoid allocating memory for a thread that don't need it. Also, this memory was not...
Eliel C. Sardanons [Tue, 9 Dec 2008 14:49:30 +0000 (14:49 +0000)]
Avoid allocating memory for a thread that don't need it. Also, this memory was not being freed until the
main thread ends. (That is never).

(closes issue #14040)
Reported by: eliel
Patches:
      func_odbc.c.patch uploaded by eliel (license 64)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161947 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoNote that the recently changed waittime parameter is in milliseconds.
Brandon Kruse [Mon, 8 Dec 2008 23:04:49 +0000 (23:04 +0000)]
Note that the recently changed waittime parameter is in milliseconds.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161911 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd alw as a valid file extension for alaw and ulw as a valid file extension for...
Joshua Colp [Mon, 8 Dec 2008 21:41:50 +0000 (21:41 +0000)]
Add alw as a valid file extension for alaw and ulw as a valid file extension for ulaw.
(closes issue #14001)
Reported by: henrikw
Patches:
      alw.diff uploaded by henrikw (license 627)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161869 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUpdate autosupport script with a few changes.
Joshua Colp [Mon, 8 Dec 2008 20:53:50 +0000 (20:53 +0000)]
Update autosupport script with a few changes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161830 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAllocate enough space initially for the message.
Tilghman Lesher [Mon, 8 Dec 2008 18:49:50 +0000 (18:49 +0000)]
Allocate enough space initially for the message.
(closes issue #14027)
 Reported by: junky
 Patches:
       M14027.diff uploaded by junky (license 177)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161790 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix a regression introduced when the PBX timeouts were converted to milliseconds...
Joshua Colp [Mon, 8 Dec 2008 18:47:32 +0000 (18:47 +0000)]
Fix a regression introduced when the PBX timeouts were converted to milliseconds. collect_digits now gets milliseconds fed to it, not seconds.
(closes issue #14012)
Reported by: dveiga
Patches:
      14012.patch uploaded by bkruse (license 132)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161787 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 161725 via svnmerge from
Joshua Colp [Mon, 8 Dec 2008 17:53:32 +0000 (17:53 +0000)]
Merged revisions 161725 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r161725 | file | 2008-12-08 13:52:10 -0400 (Mon, 08 Dec 2008) | 6 lines

  Make the usereqphone option work again.
  (closes issue #13474)
  Reported by: mmaguire
  Patches:
        20080912_bug13474.diff uploaded by mmaguire (license 571)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161726 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix a crash that can occur on a transfer in chan_sip when attempting to collect
Matthew Nicholson [Mon, 8 Dec 2008 17:23:41 +0000 (17:23 +0000)]
Fix a crash that can occur on a transfer in chan_sip when attempting to collect
rtp stats.

(closes issue #13956)
Reported by: chris-mac
Tested by: chris-mac

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161721 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd the ability to play a courtesy tone to the transfer target in a native SIP attend...
Terry Wilson [Mon, 8 Dec 2008 16:02:42 +0000 (16:02 +0000)]
Add the ability to play a courtesy tone to the transfer target in a native SIP attended transfer by setting the variable ATTENEDED_TRANSFER_COMPLETE_SOUND.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161679 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years ago- Fix a leak while printing an argument description.
Eliel C. Sardanons [Mon, 8 Dec 2008 04:23:50 +0000 (04:23 +0000)]
- Fix a leak while printing an argument description.
- Avoid printing the name of an argument in the [Arguments] tag if there is no description
  for that argument.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161637 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd voicemail related applications and functions XML documentation:
Eliel C. Sardanons [Mon, 8 Dec 2008 03:35:55 +0000 (03:35 +0000)]
Add voicemail related applications and functions XML documentation:
    applications:
      - VoiceMail()
      - VoiceMailMain()
      - MailboxExists()
      - VMAuthenticate()
    functions:
      - MAILBOX_EXISTS()

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161604 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoIntroduce SMS() application XML documentation.
Eliel C. Sardanons [Sun, 7 Dec 2008 22:43:46 +0000 (22:43 +0000)]
Introduce SMS() application XML documentation.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161571 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMove Speech* applications and functions documentation to XML.
Eliel C. Sardanons [Sat, 6 Dec 2008 21:18:51 +0000 (21:18 +0000)]
Move Speech* applications and functions documentation to XML.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161536 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoIf the autoloop flag is set on a channel, then we need to
Mark Michelson [Fri, 5 Dec 2008 23:24:38 +0000 (23:24 +0000)]
If the autoloop flag is set on a channel, then we need to
add 1 to the priority when checking if the extension exists. Otherwise,
gosubs will fail.

This was discovered when investigating an asterisk-users mailing list post
made by Gary Hawkins.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161493 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 161426 via svnmerge from
Sean Bright [Fri, 5 Dec 2008 21:08:43 +0000 (21:08 +0000)]
Merged revisions 161426 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
  r161426 | seanbright | 2008-12-05 16:02:20 -0500 (Fri, 05 Dec 2008) | 15 lines

  Merged revisions 161421 via svnmerge from
  https://origsvn.digium.com/svn/asterisk/branches/1.2

  ........
    r161421 | seanbright | 2008-12-05 15:50:23 -0500 (Fri, 05 Dec 2008) | 8 lines

    Fix build errors on FreeBSD (uint -> unsigned int).

    (closes issue #14006)
    Reported by: alphaque
    Patches:
          astobj2.h-patch uploaded by alphaque (license 259)
          (Slightly modified by seanbright)
  ........
................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161427 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUse ast_free() instead of free(), pointed out by eliel on IRC.
Sean Bright [Fri, 5 Dec 2008 16:04:36 +0000 (16:04 +0000)]
Use ast_free() instead of free(), pointed out by eliel on IRC.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161350 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoWhen using IMAP_STORAGE, it's important to convert bare newlines (\n) in
Sean Bright [Fri, 5 Dec 2008 15:56:15 +0000 (15:56 +0000)]
When using IMAP_STORAGE, it's important to convert bare newlines (\n) in
emailbody and pagerbody to CR-LF so that the IMAP server doesn't spit out an
error.  This was informally reported on #asterisk-dev a few weeks ago.  Reviewed
by Mark M. on IRC.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161349 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 161287 via svnmerge from
Russell Bryant [Fri, 5 Dec 2008 14:16:24 +0000 (14:16 +0000)]
Merged revisions 161287 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r161287 | russell | 2008-12-05 08:12:14 -0600 (Fri, 05 Dec 2008) | 2 lines

Fix a NULL format string warning found by buildbot.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161288 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoResolve a compiler warning from buildbot about a NULL format string.
Russell Bryant [Fri, 5 Dec 2008 13:46:01 +0000 (13:46 +0000)]
Resolve a compiler warning from buildbot about a NULL format string.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161252 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoJanitor, use ARRAY_LEN() when possible.
Eliel C. Sardanons [Fri, 5 Dec 2008 10:31:25 +0000 (10:31 +0000)]
Janitor, use ARRAY_LEN() when possible.

(closes issue #13990)
Reported by: eliel
Patches:
      array_len.diff uploaded by eliel (license 64)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161218 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoThe first file should have a blank config filename in the structure, so that
Tilghman Lesher [Fri, 5 Dec 2008 05:41:41 +0000 (05:41 +0000)]
The first file should have a blank config filename in the structure, so that
when a save occurs to a different filename, everything goes to the alternate
filename, instead of appending to the original.  This is important for the
AMI command UpdateConfig.
(closes issue #13301)
 Reported by: trevo
 Patches:
       20081113__bug13301.diff.txt uploaded by Corydon76 (license 14)
       20081113__bug13301__1.6.0.diff.txt uploaded by Corydon76 (license 14)
 Tested by: Corydon76, blitzrage

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161181 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoCheck the return value of fread/fwrite so the compiler doesn't complain. Only a
Sean Bright [Fri, 5 Dec 2008 02:47:54 +0000 (02:47 +0000)]
Check the return value of fread/fwrite so the compiler doesn't complain.  Only a
problem when IMAP_STORAGE is enabled.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161147 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoIf 'faxdetect=yes' in sip.conf, switch to a 'fax' extension (if it exists) after...
Dwayne M. Hubbard [Thu, 4 Dec 2008 23:00:30 +0000 (23:00 +0000)]
If 'faxdetect=yes' in sip.conf, switch to a 'fax' extension (if it exists) after T38 is negotiated.
Terry Wilson created the original patch for this functionality, which I slightly modified and added
the faxdetect=yes|no configuration option.  This patch is only for T38 fax detection and does not
do anything for G711 over SIP fax detection.  By default, this option is disabled.

Reviewboard: http://reviewboard.digium.com/r/69/

This functionality is for issue AST-140.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161115 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix minor coding guidelines introduced with CLI permissions.
Eliel C. Sardanons [Thu, 4 Dec 2008 19:31:48 +0000 (19:31 +0000)]
Fix minor coding guidelines introduced with CLI permissions.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161077 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 161013 via svnmerge from
Jeff Peeler [Thu, 4 Dec 2008 18:32:20 +0000 (18:32 +0000)]
Merged revisions 161013 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r161013 | jpeeler | 2008-12-04 12:30:41 -0600 (Thu, 04 Dec 2008) | 9 lines

(closes issue #13835)
Reported by: matt_b
Tested by: jpeeler

This mirrors a check that was present in ast_rtp_read to also be in ast_rtp_raw_write to not schedule sending the receiver report if the remote RTCP endpoint address isn't present in the RTCP structure.

Closes AST-142.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@161014 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 160943 via svnmerge from
Mark Michelson [Thu, 4 Dec 2008 16:45:06 +0000 (16:45 +0000)]
Merged revisions 160943 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r160943 | mmichelson | 2008-12-04 10:44:18 -0600 (Thu, 04 Dec 2008) | 15 lines

Fix a callerid parsing issue. If someone formatted callerid like the
following: "name <number>" (including the quotation marks), then the parts
would be parsed as

name: "name
number: number

This is because the closing quotation mark was not discovered since the number
and everything after was parsed out of the string earlier. Now, there is a check
to see if the closing quote occurs after the number, so that we can know if we
should strip off the opening quote on the name.

Closes AST-158

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160945 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd debug flag so skinny debug will show information about packets.
Michiel van Baak [Thu, 4 Dec 2008 16:37:13 +0000 (16:37 +0000)]
Add debug flag so skinny debug will show information about packets.
We dont want to scare users with this, so we added a devmode compile flag

(closes issue #13952)
Reported by: wedhorn
Patches:
      packetdebug3.diff uploaded by wedhorn (license 30)
Tested by: mvanbaak, wedhorn

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160938 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdded XML documentation for the following AGI commands:
Eliel C. Sardanons [Thu, 4 Dec 2008 13:45:32 +0000 (13:45 +0000)]
Added XML documentation for the following AGI commands:
        - get option
        - get variable
        - hangup
        - noop

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160896 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoJcolp pointed out that num will also match number
Richard Mudgett [Thu, 4 Dec 2008 01:36:39 +0000 (01:36 +0000)]
Jcolp pointed out that num will also match number

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160856 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years ago* Found a couple more places where num/number needed to be done
Richard Mudgett [Thu, 4 Dec 2008 01:14:22 +0000 (01:14 +0000)]
*  Found a couple more places where num/number needed to be done
so 1.4 upgraders will not have problems.
*  Added curly braces and minor tweaks.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160854 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 160770 via svnmerge from
Tilghman Lesher [Wed, 3 Dec 2008 21:58:21 +0000 (21:58 +0000)]
Merged revisions 160770 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160770 | tilghman | 2008-12-03 15:54:07 -0600 (Wed, 03 Dec 2008) | 2 lines

  Some compilers warn on null format strings; some don't (caught by buildbot)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160791 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 160764 via svnmerge
Jason Parker [Wed, 3 Dec 2008 21:38:50 +0000 (21:38 +0000)]
Blocked revisions 160764 via svnmerge

........
  r160764 | qwell | 2008-12-03 15:38:07 -0600 (Wed, 03 Dec 2008) | 7 lines

  Only show this warning when we want to show it.

  (closes issue #13982)
  Reported by: coolmig
  Patches:
        chan_agent.c.patch uploaded by coolmig (license 621)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160765 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 160703 via svnmerge from
Steve Murphy [Wed, 3 Dec 2008 21:09:15 +0000 (21:09 +0000)]
Merged revisions 160703 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r160703 | murf | 2008-12-03 13:41:42 -0700 (Wed, 03 Dec 2008) | 11 lines

(closes issue #13597)
Reported by: john8675309
Patches:
      patch.13597 uploaded by murf (license 17)
Tested by: murf, john8675309

This patch causes the setcid func to update the CDR
clid after setting the channel field.

I also notice that in trunk, the num/number of 1.4 is
left out; I decided to include the option to use
either in trunk, so as not to have 1.4 upgraders
not to have problems.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160760 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAnother place this is missing
Jason Parker [Wed, 3 Dec 2008 20:35:36 +0000 (20:35 +0000)]
Another place this is missing

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160700 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix typo when ListCategories returns none.
Jason Parker [Wed, 3 Dec 2008 20:32:20 +0000 (20:32 +0000)]
Fix typo when ListCategories returns none.

(closes issue #13994)
Reported by: mika
Patches:
      ListCategoriesActionPatch.diff uploaded by mika (license 624)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160699 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years ago- iax2-provision was not freeing iax_templates structure when unloading the chan_iax2...
Eliel C. Sardanons [Wed, 3 Dec 2008 19:25:30 +0000 (19:25 +0000)]
- iax2-provision was not freeing iax_templates structure when unloading the chan_iax2.so module.
- Move the code to start using the LIST macros.

Review: http://reviewboard.digium.com/r/72

(closes issue #13232)
Reported by: eliel
Patches:
      iax2-provision.patch.txt uploaded by eliel (license 64)
      (with minor changes pointed by Mark Michelson on review board)
Tested by: eliel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160663 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd some safety measures when using gosub, especially when using the options
Mark Michelson [Wed, 3 Dec 2008 18:37:46 +0000 (18:37 +0000)]
Add some safety measures when using gosub, especially when using the options
for app_dial and app_queue to run a gosub when the call is answered.

* Check for the existence of the gosub target in gosub_exec. If it is nonexistent,
  then this will cause errors when we attempt to actually run the gosub, including
  a definite memory leak and potential crashes. Return an error in this situation
* Check the return value of pbx_exec in app_dial and app_queue before attempting
  to actually run the gosub routine. If there was an error, we should not attempt
  to run the gosub.
* Change a '|' to a ',' in app_queue.
* Add some extra curly braces where they had been missing previously.

(closes issue #13548)
Reported by: fiddur

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160626 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 160570 via svnmerge
Tilghman Lesher [Wed, 3 Dec 2008 17:59:36 +0000 (17:59 +0000)]
Blocked revisions 160570 via svnmerge

........
  r160570 | tilghman | 2008-12-03 11:55:12 -0600 (Wed, 03 Dec 2008) | 5 lines

  During bridge code, the channel bridge may return a retry code, if a transfer
  was initiated but not yet completed.  If the bridge is immediately retried,
  then we may send a storm of TXREQ packets, even though the first set is sent
  reliably (retransmitted).  Fixes AST-137.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160585 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years ago- Add <variable /> tags when naming a channel variable.
Eliel C. Sardanons [Wed, 3 Dec 2008 17:48:47 +0000 (17:48 +0000)]
- Add <variable /> tags when naming a channel variable.
- Add <filename /> tags when naming a filename.
- Simplify the xml formatting putting some enters.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160562 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 160558 via svnmerge from
Tilghman Lesher [Wed, 3 Dec 2008 17:38:59 +0000 (17:38 +0000)]
Merged revisions 160558 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160558 | tilghman | 2008-12-03 11:34:34 -0600 (Wed, 03 Dec 2008) | 7 lines

  If an entry is added to the directory during a scan when another entry expires,
  then that new entry will not be processed promptly, but must wait for either a
  future entry to start or a current entry's retry to occur.  If no other entries
  exist in the directory (other than the new entries) when a bunch expire, then
  the new entries must wait until another new entry is added to be processed.
  This was a rather weird race condition, really.  Fixes AST-147.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160559 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoWhen investigating issue #13548, I found that gosub
Mark Michelson [Wed, 3 Dec 2008 17:07:09 +0000 (17:07 +0000)]
When investigating issue #13548, I found that gosub
handling in app_queue was just completely wrong, mostly
because the channel operations being performed were being
done on the incorrect channel.

With this set of changes, a gosub will correctly run on
the answering queue member's channel. There are still crash
issues which occur if there are dialplan syntax errors, so
I cannot yet close the referenced issue.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160555 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 160551 via svnmerge from
Tilghman Lesher [Wed, 3 Dec 2008 17:01:03 +0000 (17:01 +0000)]
Merged revisions 160551 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160551 | tilghman | 2008-12-03 10:58:34 -0600 (Wed, 03 Dec 2008) | 4 lines

  Don't start scanning the directory until all modules are loaded, because some
  required modules (channels, apps, functions) may not yet be in memory yet.
  Fixes AST-149.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160552 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 160480 via svnmerge from
Tilghman Lesher [Wed, 3 Dec 2008 14:11:53 +0000 (14:11 +0000)]
Merged revisions 160480 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160480 | tilghman | 2008-12-03 08:09:35 -0600 (Wed, 03 Dec 2008) | 7 lines

  Jon Bonilla (Manwe) pointed out on the -dev list:
  "I guess that having only ip-phones in mind is not a good approach. Since it is
  possible to have a sip proxy connected to asterisk we could receive a 407
  (unauthorized) or 483 (too many hops) as response and dialog ending would not be
  a good behavior."
  So modified.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160481 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years ago- Avoid setting .synopsis and .syntax if we are using XML documentation (or the
Eliel C. Sardanons [Wed, 3 Dec 2008 11:01:23 +0000 (11:01 +0000)]
- Avoid setting .synopsis and .syntax if we are using XML documentation (or the
xml documentation wont be loaded).
- Use <variable></variable> to refer to a dialplan variable.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160447 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoInfo on LOCAL_PEEK function.
Tilghman Lesher [Tue, 2 Dec 2008 18:48:51 +0000 (18:48 +0000)]
Info on LOCAL_PEEK function.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160346 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd LOCAL_PEEK function, as requested by lmadsen.
Tilghman Lesher [Tue, 2 Dec 2008 18:39:12 +0000 (18:39 +0000)]
Add LOCAL_PEEK function, as requested by lmadsen.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160344 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoremove duplicate comment that I accidentally merged
Jeff Peeler [Tue, 2 Dec 2008 18:04:51 +0000 (18:04 +0000)]
remove duplicate comment that I accidentally merged

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160333 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years ago(closes issue #13786)
Jeff Peeler [Tue, 2 Dec 2008 18:00:24 +0000 (18:00 +0000)]
(closes issue #13786)
Reported by: tzafrir

Readding DAHDI_CHECK_HOOKSTATE define that was removed in r134260 which fixes not being able to make outgoing calls on some FXO adapters:
http://lists.digium.com/pipermail/asterisk-users/2008-November/thread.html#221553

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160319 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 160297 via svnmerge from
Tilghman Lesher [Tue, 2 Dec 2008 17:56:24 +0000 (17:56 +0000)]
Merged revisions 160297 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160297 | tilghman | 2008-12-02 11:42:09 -0600 (Tue, 02 Dec 2008) | 10 lines

  When the text does not match exactly (e.g. RTP/SAVP), then the %n conversion
  fails, and the resulting integer is garbage.  Thus, we must initialize the
  integer and check it afterwards for success.
  (closes issue #14000)
   Reported by: folke
   Patches:
         asterisk-sipbg-sscanf-1.4.22.diff uploaded by folke (license 626)
         asterisk-sipbg-sscanf-1.6.0.1.diff uploaded by folke (license 626)
         asterisk-sipbg-sscanf-trunk-r159896.diff uploaded by folke (license 626)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160308 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 160207 via svnmerge from
Tilghman Lesher [Tue, 2 Dec 2008 00:37:21 +0000 (00:37 +0000)]
Merged revisions 160207 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160207 | tilghman | 2008-12-01 18:25:16 -0600 (Mon, 01 Dec 2008) | 3 lines

  Ensure that Asterisk builds with --enable-dev-mode, even on the latest gcc
  and glibc.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160208 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 159976 via svnmerge from
Sean Bright [Mon, 1 Dec 2008 23:37:49 +0000 (23:37 +0000)]
Merged revisions 159976 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r159976 | mvanbaak | 2008-12-01 11:08:36 -0500 (Mon, 01 Dec 2008) | 3 lines

  Get rid of the useless format string and argument in the Bogus/ manager channelname.
  Noted by kpfleming and name Bogus/manager suggested by eliel
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160172 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoSilence a build warning. (chan_phone.c:810: warning: value computed is not used)
Sean Bright [Mon, 1 Dec 2008 23:18:48 +0000 (23:18 +0000)]
Silence a build warning. (chan_phone.c:810: warning: value computed is not used)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160171 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoPay attention to the return value of system(), even if we basically ignore it.
Sean Bright [Mon, 1 Dec 2008 23:08:24 +0000 (23:08 +0000)]
Pay attention to the return value of system(), even if we basically ignore it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160170 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUse AST_EXT_LIB_SETUP before using AST_EXT_LIB_CHECK or bad things happen.
Tilghman Lesher [Mon, 1 Dec 2008 21:23:37 +0000 (21:23 +0000)]
Use AST_EXT_LIB_SETUP before using AST_EXT_LIB_CHECK or bad things happen.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160097 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoIntroduce CLI permissions.
Eliel C. Sardanons [Mon, 1 Dec 2008 18:52:14 +0000 (18:52 +0000)]
Introduce CLI permissions.
Based on cli_permissions.conf configuration file, we are able to permit or deny
cli commands based on some patterns and the local user and group running rasterisk.

(Sorry if I missed some of the testers).

Reviewboard: http://reviewboard.digium.com/r/11/

(closes issue #11123)
Reported by: eliel
Tested by: eliel, IgorG, Laureano, otherwiseguy, mvanbaak

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160062 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 160003 via svnmerge from
Russell Bryant [Mon, 1 Dec 2008 17:34:31 +0000 (17:34 +0000)]
Merged revisions 160003 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r160003 | russell | 2008-12-01 11:27:30 -0600 (Mon, 01 Dec 2008) | 6 lines

Apply some logic used in iax2_indicate() to iax2_setoption(), as well, since they
both have the potential to send control frames in the middle of call setup.  We
have to wait until we have received a message back from the remote end before
we try to send any more frames.  Otherwise, the remote end will consider it
invalid, and we'll get stuck in an INVAL/VNAK storm.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160004 65c4cc65-6c06-0410-ace0-fbb531ad65f3