2 years agopjproject_bundled: timer: Clean up usage of timer heap
George Joseph [Sun, 25 Mar 2018 18:25:30 +0000 (12:25 -0600)]
pjproject_bundled: timer: Clean up usage of timer heap

Added a new pj_timer_entry_reset function that resets a timer_entry
for re-use.

Changed direct settings of timer_entry fields to use
pj_timer_entry_init and pj_timer_entry_reset.

Fixed issues where timers were being rescheduled incorrectly.

Change-Id: I5b624bfbc5c1429117484b9b24567293002148e6

2 years agoMerge "BuildSystem: With external editline, do not require libs for internal editline."
Jenkins2 [Mon, 2 Apr 2018 13:36:01 +0000 (08:36 -0500)]
Merge "BuildSystem: With external editline, do not require libs for internal editline."

2 years agoMerge "core: Create main/options.c."
Jenkins2 [Mon, 2 Apr 2018 13:31:08 +0000 (08:31 -0500)]
Merge "core: Create main/options.c."

2 years agoMerge "pjproject_bundled: Add patch for pj_atomic crashes"
George Joseph [Mon, 2 Apr 2018 13:19:05 +0000 (08:19 -0500)]
Merge "pjproject_bundled:  Add patch for pj_atomic crashes"

2 years agoMerge "res_rtp_asterisk: Add support for raising additional RTCP messages."
Kevin Harwell [Thu, 29 Mar 2018 20:19:17 +0000 (15:19 -0500)]
Merge "res_rtp_asterisk: Add support for raising additional RTCP messages."

2 years agoMerge "main/indications: Use ast_cli_completion_add for all completions."
Kevin Harwell [Thu, 29 Mar 2018 20:06:45 +0000 (15:06 -0500)]
Merge "main/indications: Use ast_cli_completion_add for all completions."

2 years agoMerge "BuildSystem: pjsip_evsub_set_uas_timeout was not used (part 2)."
Jenkins2 [Thu, 29 Mar 2018 20:02:19 +0000 (15:02 -0500)]
Merge "BuildSystem: pjsip_evsub_set_uas_timeout was not used (part 2)."

2 years agoMerge "pjsip_transport_events.c: Fix crash using stale transport pointer."
Jenkins2 [Thu, 29 Mar 2018 19:39:26 +0000 (14:39 -0500)]
Merge "pjsip_transport_events.c: Fix crash using stale transport pointer."

2 years agoMerge "test_data_buffer.c: Add unit tests for data buffer API."
Jenkins2 [Thu, 29 Mar 2018 18:41:37 +0000 (13:41 -0500)]
Merge "test_data_buffer.c: Add unit tests for data buffer API."

2 years agoMerge "Add data buffer API to store packets."
Jenkins2 [Thu, 29 Mar 2018 18:38:02 +0000 (13:38 -0500)]
Merge "Add data buffer API to store packets."

2 years agoMerge "core: fix getopt(3) usage"
Jenkins2 [Thu, 29 Mar 2018 15:52:25 +0000 (10:52 -0500)]
Merge "core: fix getopt(3) usage"

2 years agopjsip_transport_events.c: Fix crash using stale transport pointer.
Ross Beer [Wed, 7 Mar 2018 12:15:05 +0000 (12:15 +0000)]
pjsip_transport_events.c: Fix crash using stale transport pointer.

Apparently it is possible for the transport to be destroyed without
triggering the transport callback logic.  As a result the transport gets
destroyed and we have a stale pointer in the active_transports container.

* Invoke the transport monitor callback checks when the transport is
destroyed in addition to when it is disconnected and shutdown.


Change-Id: Ia9b5469fea8f2b3f2d8476fae6b748a4d23e7261

2 years agotest_data_buffer.c: Add unit tests for data buffer API.
Ben Ford [Mon, 19 Mar 2018 14:36:44 +0000 (09:36 -0500)]
test_data_buffer.c: Add unit tests for data buffer API.

Added unit tests for the data buffer API. These tests include creating a
data buffer, putting payloads into the buffer, resizing the buffer, and
the nominal case for data buffer usage, which consists of adding
the max number of payloads to the buffer, checking to see if the correct
payloads are present, then adding more payloads and checking again to
see if the previous payloads were replaced or not.

For more information, refer to the wiki page:

Change-Id: Id5b599aa15a5e61d0ec080f97cd0c57bd07e6f8f

2 years agoAdd data buffer API to store packets.
Ben Ford [Fri, 23 Feb 2018 19:49:21 +0000 (13:49 -0600)]
Add data buffer API to store packets.

Adds a data buffer with a configurable size that can store different
kinds of packets (like RTP packets for retransmission). Given a number
it will store a data packet at that position relative to the others.
Given a number it will retrieve the given data packet if it is present.
This is purposely a storage of arbitrary things so it can be used not
just for RTP packets but also Asterisk frames in the future if needed.
The API does not internally use a lock, so it will be up to the user of
the API to properly protect the data buffer.

For more information, refer to the wiki page:

Change-Id: Iff13c5d4795d52356959fe2a57360cd57dfade07

2 years agopjproject_bundled: Add patch for pj_atomic crashes
George Joseph [Sun, 25 Mar 2018 18:12:39 +0000 (12:12 -0600)]
pjproject_bundled:  Add patch for pj_atomic crashes

There have been some crashes in the past where something attempts
to use a pj_atomic after it's already been destroyed.  This patch
tries to prevent it by making sure that pj_atomic_destroy sets
its mutex to NULL when it's done.  The pj_mutex functions already check
for a NULL mutex and just return PJ_EINVAL.

Teluu also added some checks to the win32 implementation as well.

Change-Id: Id25f70b79fdedf44ead6e6e1763a4417d3b3f825

2 years agores_rtp_asterisk: Add support for raising additional RTCP messages.
Joshua Colp [Wed, 21 Mar 2018 13:52:08 +0000 (13:52 +0000)]
res_rtp_asterisk: Add support for raising additional RTCP messages.

This change extends the existing AST_FRAME_RTCP frame type to be
able to contain additional RTCP message types, such as feedback
messages. The payload type is contained in the subclass which allows
knowing what is in the frame itself.

The RTCP feedback message type is now handled and REMB[1] messages
are raised with their containing information.

This also fixes a bug where all feedback messages were triggering
video updates instead of just FIR and FUR.

Finally RTCP frames are now passed up through the Asterisk core to
what is handling the channel, mapped appropriately in the case of
bridging, and written to an outgoing stream. Since RTCP frames are
on a per-stream basis this is only done on multistream capable



Change-Id: I680da0ad8d5059d5e9655d896fb9d92e9da8491e

2 years agoMerge "loader: Reserve space for additional pointers in ast_module_info."
Jenkins2 [Mon, 26 Mar 2018 16:44:52 +0000 (11:44 -0500)]
Merge "loader: Reserve space for additional pointers in ast_module_info."

2 years agocore: fix getopt(3) usage
Guido Falsi [Mon, 26 Mar 2018 12:42:52 +0000 (14:42 +0200)]
core: fix getopt(3) usage

Setting optind = 0 is forced to 1 in glibc implementation, but
causes option parsing to be flawed in other implementations, for
example on FreeBSD.

ASTERISK-27773 #close

Change-Id: Ia548e69f8302e9754dbbedb6bc451c0700c66f61

2 years agomain/indications: Use ast_cli_completion_add for all completions.
Corey Farrell [Sat, 17 Mar 2018 06:02:06 +0000 (02:02 -0400)]
main/indications: Use ast_cli_completion_add for all completions.

Change-Id: I371be01f178fb542a9fbe8d97e7ae21aa4d82c36

2 years agoMerge "bridge_softmix: Clear "talking" when a channel is put on hold"
Jenkins2 [Thu, 22 Mar 2018 13:47:19 +0000 (08:47 -0500)]
Merge "bridge_softmix: Clear "talking" when a channel is put on hold"

2 years agoBuildSystem: pjsip_evsub_set_uas_timeout was not used (part 2).
Alexander Traud [Thu, 22 Mar 2018 12:27:52 +0000 (13:27 +0100)]
BuildSystem: pjsip_evsub_set_uas_timeout was not used (part 2).

The previous change was not complete.


Change-Id: I11082c14c0ef9c6af8c995084a6851337ea2a90f

2 years agoMerge "Revert "BuildSystem: In NetBSD, the Python Programming Language is python...
Jenkins2 [Thu, 22 Mar 2018 10:44:30 +0000 (05:44 -0500)]
Merge "Revert "BuildSystem: In NetBSD, the Python Programming Language is python-X.Y.""

2 years agoBuildSystem: With external editline, do not require libs for internal editline.
Alexander Traud [Thu, 22 Mar 2018 10:43:18 +0000 (11:43 +0100)]
BuildSystem: With external editline, do not require libs for internal editline.


Change-Id: Ib17a7415297a210cfcdbf149e4df9b6edadbfab6

2 years agocore: Create main/options.c.
Corey Farrell [Thu, 22 Mar 2018 03:00:56 +0000 (23:00 -0400)]
core: Create main/options.c.

This creates a separate source to 'own' symbols related to options.h and
paths.h.  This significantly reduces the number of exports created by
main/asterisk.o.  This change is required to eventually be able to
link unmodified Asterisk sources to utilities and/or stand-alone tests.


Change-Id: I5cf184f4757f9363b80c9e678bdc35c477122380

2 years agoRevert "BuildSystem: In NetBSD, the Python Programming Language is python-X.Y."
George Joseph [Thu, 22 Mar 2018 00:25:58 +0000 (18:25 -0600)]
Revert "BuildSystem: In NetBSD, the Python Programming Language is python-X.Y."

Something is causing a python2/python3 mismatch on Fedora27.

PYTHONDEV_CFLAGS='-I/usr/include/python3.6m '
PYTHONDEV_INCLUDE='-I/usr/include/python3.6m '
PYTHONDEV_LIB='-lpython3.6m '
PYTHONDEV_LIBS='-lpython3.6m '

This reverts commit be0e9920b64e3b07501b299d131309b58f9b0ddf.

Change-Id: I86dd102eb3ead199fe89178cdbadb36b4e2cfd1b

2 years agoMerge "core: Stop using AST_INLINE_API for allocator functions."
Jenkins2 [Wed, 21 Mar 2018 15:46:30 +0000 (10:46 -0500)]
Merge "core: Stop using AST_INLINE_API for allocator functions."

2 years agoMerge "rtp: Add REMB RTP property and set it on PJSIP video RTP."
Jenkins2 [Wed, 21 Mar 2018 15:38:32 +0000 (10:38 -0500)]
Merge "rtp: Add REMB RTP property and set it on PJSIP video RTP."

2 years agoMerge "chan_sip: Peers with distinct source ports don't match, regardless of transport."
Jenkins2 [Wed, 21 Mar 2018 14:42:54 +0000 (09:42 -0500)]
Merge "chan_sip: Peers with distinct source ports don't match, regardless of transport."

2 years agoMerge "func_channel: Delete dead CHANNEL_TRACE code"
Jenkins2 [Wed, 21 Mar 2018 11:26:09 +0000 (06:26 -0500)]
Merge "func_channel: Delete dead CHANNEL_TRACE code"

2 years agoloader: Reserve space for additional pointers in ast_module_info.
Corey Farrell [Thu, 8 Feb 2018 19:23:35 +0000 (14:23 -0500)]
loader: Reserve space for additional pointers in ast_module_info.

This creates 4 reserved pointers in case we need additional dependency
management fields.

Change-Id: If991ec99b779df1b2dfbd38ce1a0cd79f9e01821

2 years agobridge_softmix: Clear "talking" when a channel is put on hold
Kevin Harwell [Tue, 20 Mar 2018 20:28:12 +0000 (15:28 -0500)]
bridge_softmix: Clear "talking" when a channel is put on hold

This patch clears the talking flag from the channel (if already set), and
notifies listeners when that channel is put on hold. Note however, if the
endpoint continues to send audio frames and these are received by the bridge
then that channel will be put back into a "talking" state even though they
are on hold.

ASTERISK-27755 #close

Change-Id: I930e16c4662810f9f02043d69062f88173c5e2ef

2 years agoBuildSystem: For consistency, avoid extra libs to be empty.
Alexander Traud [Tue, 20 Mar 2018 16:53:19 +0000 (17:53 +0100)]
BuildSystem: For consistency, avoid extra libs to be empty.

AST_EXT_LIB_CHECK has several optional parameters. When an optional parameter
is left empty, [] is used to indicate this. However, this is done in the script
./configure only then, when a further parameter is not empty. For example, when
no extra libraries are needed to test the checked library, parameter 5 is not
mentioned. Except parameter 6 and higher are used, then parameter 5 must be

However, this general rule was broken
* four times for parameter 5 (extra libs) and
* three times for parameter 4 (header)
as found via the Regular Expression \[\]\). In case of parameter 5, all cases
were changed, because that happened for no reason. In case of parameter 4, an
[] improves readability actually. Therefore for parameter 4, the only case which
did not do it was changed. All this aims to create more consistency: Only do
something different if there is a reason to do so.

Change-Id: I037ef170cf1ad94497151a9ea5071a31c656cafe

2 years agoMerge "core: Remove additional symbols."
Joshua Colp [Tue, 20 Mar 2018 16:44:06 +0000 (11:44 -0500)]
Merge "core: Remove additional symbols."

2 years agoMerge "core: Remove dead symbols from"
Jenkins2 [Tue, 20 Mar 2018 16:40:39 +0000 (11:40 -0500)]
Merge "core: Remove dead symbols from"

2 years agoMerge "channel.c: Allow generic plc then channel formats are equal"
Jenkins2 [Tue, 20 Mar 2018 16:16:52 +0000 (11:16 -0500)]
Merge "channel.c:  Allow generic plc then channel formats are equal"

2 years agoMerge "BuildSystem: In NetBSD, the Python Programming Language is python-X.Y."
George Joseph [Tue, 20 Mar 2018 15:37:57 +0000 (10:37 -0500)]
Merge "BuildSystem: In NetBSD, the Python Programming Language is python-X.Y."

2 years agoMerge "BuildSystem: Instead of $PJPROJECT_LIBS with s, use $PJPROJECT_LIB everywhere."
Jenkins2 [Tue, 20 Mar 2018 15:24:11 +0000 (10:24 -0500)]
Merge "BuildSystem: Instead of $PJPROJECT_LIBS with s, use $PJPROJECT_LIB everywhere."

2 years agoMerge "main/sounds: Use ast_cli_completion_add."
Jenkins2 [Tue, 20 Mar 2018 15:09:26 +0000 (10:09 -0500)]
Merge "main/sounds: Use ast_cli_completion_add."

2 years agofunc_channel: Delete dead CHANNEL_TRACE code
Ivan Poddubny [Tue, 20 Mar 2018 14:58:38 +0000 (15:58 +0100)]
func_channel: Delete dead CHANNEL_TRACE code

The functions behind the flag and the flag itself were removed
from Asterisk 12 as incompatible with the new architecture.

Change-Id: I058493ef7a53ee290fd225bbcbb07bf46b623ccf

2 years agoMerge "named_acl: Use ast_cli_completion_add."
Joshua Colp [Tue, 20 Mar 2018 14:51:41 +0000 (09:51 -0500)]
Merge "named_acl: Use ast_cli_completion_add."

2 years agoMerge "manager: Use ast_cli_completion_add for completion generators."
Joshua Colp [Tue, 20 Mar 2018 14:36:56 +0000 (09:36 -0500)]
Merge "manager: Use ast_cli_completion_add for completion generators."

2 years agoMerge "main/test: Use ast_cli_completion_add."
Joshua Colp [Tue, 20 Mar 2018 14:18:57 +0000 (09:18 -0500)]
Merge "main/test: Use ast_cli_completion_add."

2 years agoMerge "core: Minor cleanup of ast_el_read_char."
Jenkins2 [Tue, 20 Mar 2018 13:47:15 +0000 (08:47 -0500)]
Merge "core: Minor cleanup of ast_el_read_char."

2 years agoMerge "aco: Use ast_cli_completion_add for 'config show help'."
Joshua Colp [Tue, 20 Mar 2018 13:31:49 +0000 (08:31 -0500)]
Merge "aco: Use ast_cli_completion_add for 'config show help'."

2 years agoMerge "main/config: Use ast_cli_completion_add for reload completion."
Jenkins2 [Tue, 20 Mar 2018 13:20:54 +0000 (08:20 -0500)]
Merge "main/config: Use ast_cli_completion_add for reload completion."

2 years agoMerge "main/translate: Use ast_cli_completion_add."
Jenkins2 [Tue, 20 Mar 2018 12:58:00 +0000 (07:58 -0500)]
Merge "main/translate: Use ast_cli_completion_add."

2 years agoMerge "main/taskprocessor: Use ast_cli_completion_add."
Joshua Colp [Tue, 20 Mar 2018 12:38:03 +0000 (07:38 -0500)]
Merge "main/taskprocessor: Use ast_cli_completion_add."

2 years agoMerge "main/bridge: Use ast_cli_completion_add."
Jenkins2 [Tue, 20 Mar 2018 12:29:24 +0000 (07:29 -0500)]
Merge "main/bridge: Use ast_cli_completion_add."

2 years agoMerge "stringfields: Remove MALLOC_DEBUG fields from struct ast_string_field_mgr."
Jenkins2 [Tue, 20 Mar 2018 11:58:56 +0000 (06:58 -0500)]
Merge "stringfields: Remove MALLOC_DEBUG fields from struct ast_string_field_mgr."

2 years agoMerge "BuildSystem: Enable Advanced Linux Sound Architecture (ALSA) in NetBSD."
Jenkins2 [Tue, 20 Mar 2018 11:45:35 +0000 (06:45 -0500)]
Merge "BuildSystem: Enable Advanced Linux Sound Architecture (ALSA) in NetBSD."

2 years agoMerge "BuildSystem: Remove unused dependency on libltdl."
Joshua Colp [Tue, 20 Mar 2018 11:37:09 +0000 (06:37 -0500)]
Merge "BuildSystem: Remove unused dependency on libltdl."

2 years agoMerge "BuildSystem: Check for header file of OGG."
Joshua Colp [Tue, 20 Mar 2018 11:30:02 +0000 (06:30 -0500)]
Merge "BuildSystem: Check for header file of OGG."

2 years agocore: Remove additional symbols.
Corey Farrell [Sun, 18 Mar 2018 02:26:35 +0000 (22:26 -0400)]
core: Remove additional symbols.

Remove symbols that are depreacated and replaced:
* ast_channel_datastore_alloc
* ast_channel_datastore_free
* ast_channel_cmpwhentohangup
* ast_channel_setwhentohangup
* config_text_file_save
* devstate2str
* ast_device_state_changed
* ast_device_state_changed_literal
* ast_verbose_get_by_module

Remove unused symbols:
* channelreloadreason2txt (last used in Asterisk 12).

Remove unused ast_options flags:
* AST_OPT_FLAG_END_CDR_BEFORE_H_EXTEN / ast_opt_end_cdr_before_h_exten
* AST_OPT_FLAG_VERBOSE_MODULE / ast_opt_verb_module

Change-Id: I841255995d195f8efc1ed47af9c7a2f131c08645

2 years agocore: Remove dead symbols from
Corey Farrell [Sun, 18 Mar 2018 01:03:29 +0000 (21:03 -0400)]
core: Remove dead symbols from

* dahdi_chan_name
* dahdi_chan_name_len
* dahdi_chan_mode
* __manager_event
* dialed_interface_info

Added comment about __progname and environ being needed for FreeBSD to
prevent accidental removal in the future.

Change-Id: I3ae026bc541cd9cb572be2ffa95fc359547642b5

2 years agonamed_acl: Use ast_cli_completion_add.
Corey Farrell [Sat, 17 Mar 2018 06:39:41 +0000 (02:39 -0400)]
named_acl: Use ast_cli_completion_add.

Change-Id: I317a82de976bbdbfe4352c243e32a7bb8f66c377

2 years agomain/sounds: Use ast_cli_completion_add.
Corey Farrell [Sat, 17 Mar 2018 06:58:31 +0000 (02:58 -0400)]
main/sounds: Use ast_cli_completion_add.

Change-Id: I140e1137906bbfcdb61c0c6304159be459ad873e

2 years agochannel.c: Allow generic plc then channel formats are equal
George Joseph [Fri, 16 Mar 2018 15:19:11 +0000 (09:19 -0600)]
channel.c:  Allow generic plc then channel formats are equal

If the two formats on a channel are equal, we don't transcode and since
the generic plc needs slin to work, it doesn't get invoked.

* A new configuration option "genericplc_on_equal_codecs" was added
  to the "plc" section of codecs.conf to allow generic packet loss
  concealment even if no transcoding was originally needed.
  Transcoding via SLIN is forced in this case.


Change-Id: I0577026a179dea34232e63123254b4e0508378f4

2 years agomanager: Use ast_cli_completion_add for completion generators.
Corey Farrell [Sat, 17 Mar 2018 06:09:47 +0000 (02:09 -0400)]
manager: Use ast_cli_completion_add for completion generators.

Change-Id: I658141c6ec490a3e866b02d2afea757928ceaabf

2 years agomain/test: Use ast_cli_completion_add.
Corey Farrell [Sat, 17 Mar 2018 07:16:24 +0000 (03:16 -0400)]
main/test: Use ast_cli_completion_add.

Change-Id: I5133ff2ba4e030f9733fb3d050c863d72a22ae6b

2 years agoMerge "loader: Convert reload_classes to built-in modules."
Jenkins2 [Mon, 19 Mar 2018 17:53:12 +0000 (12:53 -0500)]
Merge "loader: Convert reload_classes to built-in modules."

2 years agoMerge "BuildSystem: Avoid an extra case for OpenBSD."
George Joseph [Mon, 19 Mar 2018 16:15:51 +0000 (11:15 -0500)]
Merge "BuildSystem: Avoid an extra case for OpenBSD."

2 years agoMerge "BuildSystem: When no download utility is available, display the explanation."
Jenkins2 [Mon, 19 Mar 2018 15:19:29 +0000 (10:19 -0500)]
Merge "BuildSystem: When no download utility is available, display the explanation."

2 years agoMerge "BuildSystem: Enable dladdr on non-Linux platforms like FreeBSD."
Jenkins2 [Mon, 19 Mar 2018 15:02:14 +0000 (10:02 -0500)]
Merge "BuildSystem: Enable dladdr on non-Linux platforms like FreeBSD."

2 years agoMerge "app_voicemail: Fix json blob errors"
George Joseph [Mon, 19 Mar 2018 14:50:00 +0000 (09:50 -0500)]
Merge "app_voicemail:  Fix json blob errors"

2 years agoMerge "app_dial: Enable early-media video"
George Joseph [Mon, 19 Mar 2018 14:34:16 +0000 (09:34 -0500)]
Merge "app_dial: Enable early-media video"

2 years agortp: Add REMB RTP property and set it on PJSIP video RTP.
Joshua Colp [Sun, 18 Mar 2018 15:16:40 +0000 (15:16 +0000)]
rtp: Add REMB RTP property and set it on PJSIP video RTP.

This change adds a property to RTP instances to indicate that
REMB support is enabled and that sending/receiving should be
passed through.

This also enables it on video RTP instances in PJSIP if
WebRTC support is enabled.

Finally the goog-remb extension is added to the SDP using
the rtcp-fb attribute to indicate our support for it.

Details about REMB can be found on the draft document for it:

Change-Id: I1902dda1c0882bd1a0d71b2f120684b44b97e789

2 years agoMerge "main/cdr: Use ast_cli_completion_add for CDR channel completion."
Jenkins2 [Mon, 19 Mar 2018 11:17:42 +0000 (06:17 -0500)]
Merge "main/cdr: Use ast_cli_completion_add for CDR channel completion."

2 years agomain/bridge: Use ast_cli_completion_add.
Corey Farrell [Sat, 17 Mar 2018 09:31:23 +0000 (05:31 -0400)]
main/bridge: Use ast_cli_completion_add.

Change-Id: I3775a696d6a57139fdf09651ecb786bcf1774509

2 years agocore: Minor cleanup of ast_el_read_char.
Corey Farrell [Sat, 17 Mar 2018 21:41:13 +0000 (17:41 -0400)]
core: Minor cleanup of ast_el_read_char.

* Define CHAR_T_LIBEDIT and CHAR_TO_LIBEDIT based on
  HAVE_LIBEDIT_IS_UNICODE.  This avoids needing to repeatedly use
  conditional blocks, eliminates having multiple function prototypes.
* Remove parenthesis from return values.
* Add missing code block brackets {}.
* Reduce use of 'else' conditional statements where possible.

Change-Id: I4315328ebea2f62641faf6881de2ac20a9f9d08e

2 years agoBuildSystem: Check for header file of OGG.
Alexander Traud [Sat, 17 Mar 2018 15:49:11 +0000 (16:49 +0100)]
BuildSystem: Check for header file of OGG.

Asterisk uses various symbols of the shared library libogg within the module
format_ogg_vorbis. However, the source code of that module did not include the
header file of libogg explicitly but implicitly. Because that header was not
included before Asterisk 14, the script ./configure was told not to check for

Anyway, even Asterisk 13 LTS uses symbols of libogg. Therefore, that header
should be included explicitly. Therefore, ./configure should check for that

Change-Id: I98c50d56311b68880d1084fcc62c35ab2f8692db

2 years agoBuildSystem: When no download utility is available, display the explanation.
Alexander Traud [Fri, 9 Mar 2018 12:26:40 +0000 (13:26 +0100)]
BuildSystem: When no download utility is available, display the explanation.

./configure --with-pjproject-bundled
did not display an explanation, when no download utility like wget, curl, or
fetch was installed beforehand, although an explanation existed in code. This
happened because the code expected the variable DOWNLOAD_TO_STDOUT to be empty.
However, the script ./configure set that variable always.

Change-Id: I64c99b76a03525c69471e5055bf124b36a51bbd4

2 years agoBuildSystem: Remove unused dependency on libltdl.
Alexander Traud [Sat, 17 Mar 2018 10:00:06 +0000 (11:00 +0100)]
BuildSystem: Remove unused dependency on libltdl.

Asterisk does not need the development package of libltdl, because it does not
use any symbol of -lltdl directly. Instead, it uses the runtime package via the
shared library -lodbc. On the supported platforms, that shared library declares
its dependency on -lltdl correctly, otherwise AST_EXT_LIB_CHECK would have


Change-Id: Icd315809b8e7978203431f3afb66240dd3a040ba

2 years agomain/translate: Use ast_cli_completion_add.
Corey Farrell [Sat, 17 Mar 2018 07:25:17 +0000 (03:25 -0400)]
main/translate: Use ast_cli_completion_add.

Change-Id: I0e2402660e54d91f74ab0804c62a5b1925577413

2 years agomain/taskprocessor: Use ast_cli_completion_add.
Corey Farrell [Sat, 17 Mar 2018 07:00:45 +0000 (03:00 -0400)]
main/taskprocessor: Use ast_cli_completion_add.

Change-Id: Ie5f812a988ed811fd11967151932de62bc131b48

2 years agomain/config: Use ast_cli_completion_add for reload completion.
Corey Farrell [Thu, 15 Mar 2018 20:06:26 +0000 (16:06 -0400)]
main/config: Use ast_cli_completion_add for reload completion.

Change-Id: Ia3fa4c03f2285a1ec8814bbe7f4624ead9111ad1

2 years agoaco: Use ast_cli_completion_add for 'config show help'.
Corey Farrell [Sat, 17 Mar 2018 05:51:47 +0000 (01:51 -0400)]
aco: Use ast_cli_completion_add for 'config show help'.

In addition this removes:
* RAII_VAR usage
* Duplicate check of pos
* Unneeded arguments.

Change-Id: I2da8eac2670d1d8d6474c04037129804f55ebf39

2 years agocore: Stop using AST_INLINE_API for allocator functions.
Corey Farrell [Wed, 14 Mar 2018 09:27:40 +0000 (05:27 -0400)]
core: Stop using AST_INLINE_API for allocator functions.

This replaces AST_INLINE_API allocators in utils.h with real functions
implemented in astmm.c.  Associated macro's are also moved from utils.h
to astmm.h.

Remove menuselect conflicts between MALLOC_DEBUG and DEBUG_CHAOS as they
can now be combined.

This has multiple benefits:
* Simplifies asterisk/utils.h by removing inline functions and use of
  the logger.
* Removal of these inline functions decreases size of Asterisk and
  module binaries by 1% or more.
* Puts memory management functions together with and without
  MALLOC_DEBUG enabled, simplifying management of the code.
* Enables DEBUG_CHAOS for ASTMM_REDIRECT and bundled pjproject.

Change-Id: If9df4377f74bdbb627461b27a473123e05525887

2 years agoMerge "astobj2_container: Use ast_cli_completion_add for container names."
Joshua Colp [Sat, 17 Mar 2018 00:09:48 +0000 (19:09 -0500)]
Merge "astobj2_container: Use ast_cli_completion_add for container names."

2 years agoMerge "main/ccss: Use ast_cli_completion_add for core id."
Jenkins2 [Sat, 17 Mar 2018 00:07:58 +0000 (19:07 -0500)]
Merge "main/ccss: Use ast_cli_completion_add for core id."

2 years agoapp_dial: Enable early-media video
Florian Floimair [Tue, 27 Feb 2018 09:01:38 +0000 (10:01 +0100)]
app_dial: Enable early-media video

Certain applications (e.g. door-phone) require that also video is transmitted
before a call is accepted.

Change-Id: I9842e1dc2f6e1c2c49dc33fe615255007d2f821e

2 years agoBuildSystem: In NetBSD, the Python Programming Language is python-X.Y.
Alexander Traud [Mon, 5 Mar 2018 12:50:35 +0000 (13:50 +0100)]
BuildSystem: In NetBSD, the Python Programming Language is python-X.Y.


Change-Id: If90ddf9c396c32e7402a894f42dce215c30049d1

2 years agoMerge "main/channel: Use ast_cli_completion_add for channeltypes."
Jenkins2 [Fri, 16 Mar 2018 15:51:38 +0000 (10:51 -0500)]
Merge "main/channel: Use ast_cli_completion_add for channeltypes."

2 years agoMerge "cli: Enable ast_cli_completion_add on public completion generators."
Jenkins2 [Fri, 16 Mar 2018 15:34:16 +0000 (10:34 -0500)]
Merge "cli: Enable ast_cli_completion_add on public completion generators."

2 years agoBuildSystem: Avoid an extra case for OpenBSD.
Alexander Traud [Fri, 16 Mar 2018 14:53:22 +0000 (15:53 +0100)]
BuildSystem: Avoid an extra case for OpenBSD.

Nine years ago with Mantis 13639 (now ASTERISK-12841) an extra case for OpenBSD
was introduced: Vorbis required Ogg to be specified manually, because the shared
library did not specify its required dependency on -logg itself.

Today with OpenBSD 6.2, all libvorbis*.so declare their dependencies correctly.
Therefore, an extra case is not required anymore.

Change-Id: Ifd04e0994ce9f1e4ad29c3948a0398b91d1e97bc

2 years agoBuildSystem: Enable Advanced Linux Sound Architecture (ALSA) in NetBSD.
Alexander Traud [Mon, 5 Mar 2018 16:10:45 +0000 (17:10 +0100)]
BuildSystem: Enable Advanced Linux Sound Architecture (ALSA) in NetBSD.

In the script ./configure, AST_EXT_LIB_CHECK checks for external libraries. Some
libraries do not specify all their dependencies and require additional shared
libraries. In AST_EXT_LIB_CHECK, this is the fifth parameter. However, if a
library is specified there, it must exist on the platform, because ./configure
tries to compile/link/execute a small app using those statements. For example,
the library is Linux specific and does not exist on BSD-like platforms.

Furthermore, no supported platform/version was found, which still (ever?)
requires those additional libraries. Therefore, they were simply removed.

Finally, this change adds the error code ESTRPIPE to the channel driver
chan_alsa for those platforms which lack it, again for example NetBSD.


Change-Id: I3b21f2135f6cbfac7590ccdc2df753257f426e0b

2 years agoapp_voicemail: Fix json blob errors
George Joseph [Fri, 16 Mar 2018 14:02:20 +0000 (08:02 -0600)]
app_voicemail:  Fix json blob errors

When app_voicemail calls ast_test_suite_notify with the results of
a user keypress, it formats the keypress as '%c'.  If the user hung up
or some other error occurrs, the result of the keypress is a non
printable character.  This ultimately causes json_vpack_ex to think
it's being passed a non utf-8 string and return an error.

* Keypress results passed to ast_test_suite_notify are now checked with
  isprint() and a '?' is substituted if the check fails.

Change-Id: I78ee188916bbac840f3d03f40201b692347ea865

2 years agomain/cdr: Use ast_cli_completion_add for CDR channel completion.
Corey Farrell [Thu, 15 Mar 2018 14:32:37 +0000 (10:32 -0400)]
main/cdr: Use ast_cli_completion_add for CDR channel completion.

Change-Id: Ie81830647a23aad61c1162583b6d50adbe6e7822

2 years agoinstall_prereq: Add Arch Linux.
Alexander Traud [Mon, 12 Mar 2018 15:20:54 +0000 (16:20 +0100)]
install_prereq: Add Arch Linux.


Change-Id: I7ca620e3c4dfb4b064a19382c4915aeb42a2a09f

2 years agomain/ccss: Use ast_cli_completion_add for core id.
Corey Farrell [Thu, 15 Mar 2018 13:19:58 +0000 (09:19 -0400)]
main/ccss: Use ast_cli_completion_add for core id.

Change-Id: I44b25d6d24c7d9bc1bb38a50774b38883162f98f

2 years agoastobj2_container: Use ast_cli_completion_add for container names.
Corey Farrell [Thu, 15 Mar 2018 12:29:50 +0000 (08:29 -0400)]
astobj2_container: Use ast_cli_completion_add for container names.

Change-Id: I4f0fc09e820eb8d8da2354a177dbcf503c56ddd1

2 years agomain/channel: Use ast_cli_completion_add for channeltypes.
Corey Farrell [Sat, 9 Dec 2017 10:52:54 +0000 (05:52 -0500)]
main/channel: Use ast_cli_completion_add for channeltypes.

Change-Id: Ia845fae6a84801cc7d9996767b99efb2753cbb48

2 years agoMerge "res_pjsip_rfc3326.c: Account for more than one 'Reason' header"
Jenkins2 [Thu, 15 Mar 2018 11:51:40 +0000 (06:51 -0500)]
Merge "res_pjsip_rfc3326.c: Account for more than one 'Reason' header"

2 years agoMerge "install_prereq: Add SUSE."
Jenkins2 [Thu, 15 Mar 2018 11:45:00 +0000 (06:45 -0500)]
Merge "install_prereq: Add SUSE."

2 years agocli: Enable ast_cli_completion_add on public completion generators.
Corey Farrell [Wed, 14 Mar 2018 17:38:01 +0000 (13:38 -0400)]
cli: Enable ast_cli_completion_add on public completion generators.

* ast_cli_complete
* ast_complete_channels
* ast_complete_applications

These generators will now use ast_cli_completion_add if state == -1.

Change-Id: I7ff311f0873099be0e43a3dc5415c0cd06d15756

2 years agoMerge "core: Remove incorrect usage of attribute_malloc."
Jenkins2 [Thu, 15 Mar 2018 01:56:34 +0000 (20:56 -0500)]
Merge "core: Remove incorrect usage of attribute_malloc."

2 years agores_pjsip_rfc3326.c: Account for more than one 'Reason' header
Ross Beer [Wed, 14 Mar 2018 16:17:23 +0000 (16:17 +0000)]
res_pjsip_rfc3326.c: Account for more than one 'Reason' header


Change-Id: I0aa59a54735c6d20b95c54db1bd095dbf93e7adf

2 years agoinstall_prereq: Add SUSE.
Alexander Traud [Mon, 12 Mar 2018 13:05:08 +0000 (14:05 +0100)]
install_prereq: Add SUSE.


Change-Id: I4cafc8973349d50a7cb7919ddf0bb1aaef4bfc3e

2 years agoMerge "install_prereq: Update FreeBSD libraries."
Jenkins2 [Wed, 14 Mar 2018 12:56:10 +0000 (07:56 -0500)]
Merge "install_prereq: Update FreeBSD libraries."

2 years agoMerge "core: Remove non-critical cleanup from startup aborts."
Jenkins2 [Wed, 14 Mar 2018 12:00:57 +0000 (07:00 -0500)]
Merge "core: Remove non-critical cleanup from startup aborts."

2 years agoMerge "BuildSystem: Enable IMAP storage on openSUSE and Arch Linux."
Jenkins2 [Wed, 14 Mar 2018 11:45:30 +0000 (06:45 -0500)]
Merge "BuildSystem: Enable IMAP storage on openSUSE and Arch Linux."