asterisk/asterisk.git
10 years agoEnsure that CFLAGS and/or LDFLAGS provided to configure script are preserved.
Kevin P. Fleming [Fri, 28 Aug 2009 20:01:21 +0000 (20:01 +0000)]
Ensure that CFLAGS and/or LDFLAGS provided to configure script are preserved.

Cross-compilation environments want to provide 'defaults' for compiler and
linker options, and frequently do this by specifying CFLAGS and LDFLAGS in the
environment or as command-line arguments to the configure script. This patch
modifies the configure script and Makefile to preserve these settings and
ensure they are used in the build process.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@214696 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMove discardremoteholdretrieval test so it applies only to the specific notification...
Richard Mudgett [Fri, 28 Aug 2009 19:13:53 +0000 (19:13 +0000)]
Move discardremoteholdretrieval test so it applies only to the specific notification indicator values.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@214654 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix some incorrect documentation of sched_thread functions.
Mark Michelson [Fri, 28 Aug 2009 18:41:23 +0000 (18:41 +0000)]
Fix some incorrect documentation of sched_thread functions.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@214650 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemove unnecessary define for Solaris
Tilghman Lesher [Fri, 28 Aug 2009 16:50:05 +0000 (16:50 +0000)]
Remove unnecessary define for Solaris
(closes issue #15358)
 Reported by: snuffy
 Patches:
       bug_res_moh_remove_unneeded_include.diff uploaded by snuffy (license 35)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@214611 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 214517 via svnmerge from
Tilghman Lesher [Thu, 27 Aug 2009 21:46:46 +0000 (21:46 +0000)]
Merged revisions 214517 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r214517 | tilghman | 2009-08-27 16:45:34 -0500 (Thu, 27 Aug 2009) | 7 lines

  Use autoconf to detect libcurl, as this enables cross-compilation checks, something we didn't allow before.
  (closes issue #15714)
   Reported by: pprindeville
   Patches:
         20090813__issue15714.diff.txt uploaded by tilghman (license 14)
   Tested by: pprindeville
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@214518 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoEnsure that we check for the special value CONFIG_STATUS_FILEINVALID.
Tilghman Lesher [Thu, 27 Aug 2009 21:26:37 +0000 (21:26 +0000)]
Ensure that we check for the special value CONFIG_STATUS_FILEINVALID.
(closes issue #15786)
 Reported by: a_villacis
 Patches:
       asterisk-1.6.2.0-beta4-manager-fix-crash-on-include-nonexistent-file.patch uploaded by a villacis (license 660)
       (Plus a few of my own, to catch the remaining places within manager.c where it could have been a problem)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@214514 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 214436 via svnmerge from
Tilghman Lesher [Thu, 27 Aug 2009 17:28:01 +0000 (17:28 +0000)]
Merged revisions 214436 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r214436 | tilghman | 2009-08-27 11:53:58 -0500 (Thu, 27 Aug 2009) | 2 lines

  One more build system change, to make the descriptions look better, if we have better information.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@214466 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 214357 via svnmerge from
Tilghman Lesher [Thu, 27 Aug 2009 16:12:03 +0000 (16:12 +0000)]
Merged revisions 214357 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r214357 | tilghman | 2009-08-27 11:03:50 -0500 (Thu, 27 Aug 2009) | 3 lines

  Make autoheader descriptions render correctly in our autoconfig.h file.
  (Figured out while working with issue #14906)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@214360 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd forgotten documentation for new channel variables added in 214309.
Jeff Peeler [Thu, 27 Aug 2009 15:57:47 +0000 (15:57 +0000)]
Add forgotten documentation for new channel variables added in 214309.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@214355 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd two new dialplan variables when using features
Jeff Peeler [Wed, 26 Aug 2009 23:13:19 +0000 (23:13 +0000)]
Add two new dialplan variables when using features

Added DYNAMIC_FEATURENAME which holds the last triggered dynamic feature.
Added DYNAMIC_PEERNAME which holds the unique channel name on the other side
and is set when a dynamic feature is triggered.

(closes issue #14663)
Reported by: tamiel
Patches:
      20090313_features.diff uploaded by tamiel (license 712)
Tested by: tamiel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@214309 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMinor punctuation change.
Richard Mudgett [Wed, 26 Aug 2009 21:56:27 +0000 (21:56 +0000)]
Minor punctuation change.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@214272 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoTypo fix ("SIP/2.0 XXX" is 11 chars, not 10)
Tilghman Lesher [Wed, 26 Aug 2009 16:53:03 +0000 (16:53 +0000)]
Typo fix ("SIP/2.0 XXX" is 11 chars, not 10)
(closes issue #15362)
 Reported by: klaus3000
 Patches:
       chan_sip.c_logmessagefix_patch.txt uploaded by klaus3000 (license 65)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@214199 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 214194 via svnmerge from
David Vossel [Wed, 26 Aug 2009 16:38:53 +0000 (16:38 +0000)]
Merged revisions 214194 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r214194 | dvossel | 2009-08-26 11:36:42 -0500 (Wed, 26 Aug 2009) | 19 lines

  ast_write() ignores ast_audiohook_write() results

  In ast_write(), if a channel has a list of audiohooks, those
  lists are written to and the resulting frame is what ast_write()
  should continue with.  The problem was the returned audiohook frame
  was not being handled at all, and the original frame passed
  into it did not contain the mixed audio, so essentially audio
  was being lost.  One result of this was chan_spy's whisper
  mode no longer worked.  To complicate the issue, frames
  passed into ast_write may either be a single frame, or a list
  of frames.  So, as the list of frames is processed in the
  audiohook_write, the returned frames had to be added to a new
  list.

  (closes issue #15660)
  Reported by: corruptor
  Tested by: dvossel
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@214195 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoNot all versions of gnu-linux use glibc, which contains iconv. Some (especially...
Tilghman Lesher [Tue, 25 Aug 2009 22:39:51 +0000 (22:39 +0000)]
Not all versions of gnu-linux use glibc, which contains iconv.  Some (especially embedded systems) don't have iconv at all.
(closes issue #15169)
 Reported by: pprindeville

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@214152 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 214068-214069 via svnmerge from
Tilghman Lesher [Tue, 25 Aug 2009 19:32:48 +0000 (19:32 +0000)]
Merged revisions 214068-214069 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r214068 | tilghman | 2009-08-25 14:26:50 -0500 (Tue, 25 Aug 2009) | 6 lines

  Fix pronunciation of German dates.
  (closes issue #15273)
   Reported by: Benjamin Kluck
   Patches:
         say_c.patch uploaded by Benjamin Kluck (license 803)
........
  r214069 | tilghman | 2009-08-25 14:28:42 -0500 (Tue, 25 Aug 2009) | 2 lines

  I should always compile before committing...
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@214071 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDUNDILOOKUP function in 1.6 should use comma delimiters.
Tilghman Lesher [Tue, 25 Aug 2009 06:51:12 +0000 (06:51 +0000)]
DUNDILOOKUP function in 1.6 should use comma delimiters.
(closes issue #15322)
 Reported by: chappell
 Patches:
       dundilookup-0015322.patch uploaded by chappell (license 8)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213975 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 213970 via svnmerge from
Tilghman Lesher [Tue, 25 Aug 2009 06:35:37 +0000 (06:35 +0000)]
Merged revisions 213970 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r213970 | tilghman | 2009-08-25 01:34:44 -0500 (Tue, 25 Aug 2009) | 7 lines

  Improve error message by informing user exactly which function is missing a parethesis.
  (closes issue #15242)
   Reported by: Nick_Lewis
   Patches:
         pbx.c-funcparenthesis.patch2 uploaded by dbrooks (license 790)
         pbx.c-funcparenthesis-1.4.diff uploaded by loloski (license 68)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213971 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoThe DTD should be installed in the same path as the rest of the XML documentation.
Tilghman Lesher [Tue, 25 Aug 2009 02:54:07 +0000 (02:54 +0000)]
The DTD should be installed in the same path as the rest of the XML documentation.
(closes issue #15344)
 Reported by: tzafrir
 Patches:
       makefile_appdocs_dtd.diff uploaded by tzafrir (license 46)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213904 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 213899 via svnmerge from
Tilghman Lesher [Tue, 25 Aug 2009 02:41:17 +0000 (02:41 +0000)]
Merged revisions 213899 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r213899 | tilghman | 2009-08-24 21:40:22 -0500 (Mon, 24 Aug 2009) | 4 lines

  Use the default runlevels for Debian derivatives, instead of making up our own.
  (closes issue #14730)
   Reported by: pkempgen
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213900 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix storage of greetings when using IMAP_STORAGE
Jeff Peeler [Mon, 24 Aug 2009 16:43:57 +0000 (16:43 +0000)]
Fix storage of greetings when using IMAP_STORAGE

The store macro was not getting called preventing storage of IMAP greetings
at all. This has been corrected along with fixing checking if the
imapgreetings option is turned on to store the greeting in IMAP. Lastly,
the attachment filename was incorrectly using the full path instead of just
the basename, which was causing problems with retrieval of the greeting.

(closes issue #14950)
Reported by: noahisaac

(closes issue #15729)
Reported by: lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213833 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoimprove handling of openr2_chan_disconnect_call API failure, unlikely, but happened...
Moises Silva [Mon, 24 Aug 2009 04:46:28 +0000 (04:46 +0000)]
improve handling of openr2_chan_disconnect_call API failure, unlikely, but happened on openr2 library bug

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213790 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUpdate configure script for libpri COLP feature dependency requirements.
Richard Mudgett [Fri, 21 Aug 2009 23:18:16 +0000 (23:18 +0000)]
Update configure script for libpri COLP feature dependency requirements.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213748 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoClarifying comments in sip_register, and removing a dead section
Tilghman Lesher [Fri, 21 Aug 2009 22:36:39 +0000 (22:36 +0000)]
Clarifying comments in sip_register, and removing a dead section

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213738 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRegister request line contains wrong address when user domain and register host differ
David Vossel [Fri, 21 Aug 2009 22:22:11 +0000 (22:22 +0000)]
Register request line contains wrong address when user domain and register host differ

(closes issue #15539)
Reported by: Nick_Lewis
Patches:
      chan_sip.c-registraraddr.patch uploaded by Nick (license 657)
      register_domain_fix_1.6.2 uploaded by dvossel (license 671)
Tested by: Nick_Lewis, dvossel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213716 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoEnsure that realtime mailboxes properly report status on subscription.
Kevin P. Fleming [Fri, 21 Aug 2009 21:39:51 +0000 (21:39 +0000)]
Ensure that realtime mailboxes properly report status on subscription.

This patch modifies app_voicemail's response to mailbox status subscriptions
(via the internal event system) to ensure that a subscription triggers an
explicit poll of the mailbox, so the subscriber can get an immediate cached
event with that status. Previously, the cache was only populated with the
status of non-realtime mailboxes.

(closes issue #15717)
Reported by: natmlt

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213697 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agofixes sip register parsing when user@domain is used
David Vossel [Fri, 21 Aug 2009 21:02:50 +0000 (21:02 +0000)]
fixes sip register parsing when user@domain is used

(issue #15008)
(issue #15672)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213635 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 213631 via svnmerge
Kevin P. Fleming [Fri, 21 Aug 2009 20:24:04 +0000 (20:24 +0000)]
Blocked revisions 213631 via svnmerge

........
  r213631 | kpfleming | 2009-08-21 15:23:45 -0500 (Fri, 21 Aug 2009) | 8 lines

  Ensure that T.38 INVITEs generated by Asterisk properly result in T.38 being enabled.

  (closes issue #15373)
  Reported by: dcolombo
  Patches:
        chan_sip.patch uploaded by mbrancaleoni (license 342)
  Tested by: dcolombo, mbrancaleoni
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213632 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 213559 via svnmerge from
Tilghman Lesher [Fri, 21 Aug 2009 16:53:52 +0000 (16:53 +0000)]
Merged revisions 213559 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r213559 | tilghman | 2009-08-21 11:52:53 -0500 (Fri, 21 Aug 2009) | 7 lines

  Permit DEBUG_FD_LEAKS to be used with C++ source files.
  (closes issue #15698)
   Reported by: slavon
   Patches:
         20090817__issue15698.diff.txt uploaded by tilghman (license 14)
   Tested by: slavon, tilghman
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213560 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 213493 via svnmerge from
Jason Parker [Fri, 21 Aug 2009 16:04:21 +0000 (16:04 +0000)]
Merged revisions 213493 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r213493 | qwell | 2009-08-21 11:03:21 -0500 (Fri, 21 Aug 2009) | 5 lines

  Clarify queues.conf comments to specify that variables should be set in the dialplan.

  (closes issue #15755)
  Reported by: trendboy
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213494 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoincrement the mfcr2 monitor count when clearing the call request
Moises Silva [Fri, 21 Aug 2009 04:09:26 +0000 (04:09 +0000)]
increment the mfcr2 monitor count when clearing the call request

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213454 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake LOAD_ORDER actually work
Terry Wilson [Fri, 21 Aug 2009 03:48:54 +0000 (03:48 +0000)]
Make LOAD_ORDER actually work

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213450 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd original position, when logging a caller entering a queue.
Tilghman Lesher [Thu, 20 Aug 2009 22:13:26 +0000 (22:13 +0000)]
Add original position, when logging a caller entering a queue.
(closes issue #15146)
 Reported by: arabe
 Patches:
       asterisk-trunk.patch uploaded by arabe (license 786)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213414 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix greeting retrieval from IMAP
Jeff Peeler [Thu, 20 Aug 2009 21:33:11 +0000 (21:33 +0000)]
Fix greeting retrieval from IMAP

Properly check for the current voicemail state and if it doesn't exist,
create it.

(closes issue #14597)
Reported by: wtca
Patches:
      14597_v2.patch uploaded by mmichelson (license 60)
Tested by: jpeeler

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213404 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 213339 via svnmerge
Matthew Nicholson [Thu, 20 Aug 2009 20:33:59 +0000 (20:33 +0000)]
Blocked revisions 213339 via svnmerge

........
  r213339 | mnicholson | 2009-08-20 15:33:07 -0500 (Thu, 20 Aug 2009) | 7 lines

  Fix a crash by checking the proper pointer for validity before deferencing it.

  (closes issue #15751)
  Reported by: atis
  Patches:
        ast_bridge_call_peer_cdr.patch uploaded by atis (license 242)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213340 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a crash by checking the proper pointer for validity before deferencing it.
Matthew Nicholson [Thu, 20 Aug 2009 20:29:32 +0000 (20:29 +0000)]
Fix a crash by checking the proper pointer for validity before deferencing it.

(closes issue #15751)
Reported by: atis
Patches:
      ast_bridge_call_peer_cdr.patch uploaded by atis (license 242)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213327 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 213283 via svnmerge from
Jeff Peeler [Thu, 20 Aug 2009 19:56:14 +0000 (19:56 +0000)]
Merged revisions 213283 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r213283 | jpeeler | 2009-08-20 14:53:34 -0500 (Thu, 20 Aug 2009) | 2 lines

  Make all the symbols for the C-client callbacks global
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213284 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSelect uncommented lines, not commented ones.
Tilghman Lesher [Thu, 20 Aug 2009 15:29:53 +0000 (15:29 +0000)]
Select uncommented lines, not commented ones.
(closes issue #15746)
 Reported by: makoto

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213248 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agofixed bug caused by calling ast_request without calling ast_call on an R2 channel...
Moises Silva [Thu, 20 Aug 2009 03:26:59 +0000 (03:26 +0000)]
fixed bug caused by calling ast_request without calling ast_call on an R2 channel, ie, CHANISAVAIL

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213216 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix compile when certain G711 menuselect options are enabled.
Jason Parker [Wed, 19 Aug 2009 22:38:46 +0000 (22:38 +0000)]
Fix compile when certain G711 menuselect options are enabled.

(closes issue #15697)
Reported by: slavon

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213179 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 213103 via svnmerge from
David Vossel [Wed, 19 Aug 2009 21:21:00 +0000 (21:21 +0000)]
Merged revisions 213103 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r213103 | dvossel | 2009-08-19 16:18:37 -0500 (Wed, 19 Aug 2009) | 8 lines

  Fixes memory leak caused by incorrectly freeing mixmonitor

  (closes issue #15699)
  Reported by: edantie
  Patches:
        mixmonitor.patch uploaded by edantie (license 862)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213113 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBetter parsing for the "register" line
Tilghman Lesher [Wed, 19 Aug 2009 21:05:17 +0000 (21:05 +0000)]
Better parsing for the "register" line
Allows characters that are otherwise used as delimiters to be used within
certain fields (like the secret).
(closes issue #15008, closes issue #15672)
 Reported by: tilghman
 Patches:
       20090818__issue15008.diff.txt uploaded by tilghman (license 14)
 Tested by: lmadsen, tilghman

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213098 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoIf we have realtime caching enabled, 'sip reload' must purge users/peers, even if...
Tilghman Lesher [Wed, 19 Aug 2009 20:29:41 +0000 (20:29 +0000)]
If we have realtime caching enabled, 'sip reload' must purge users/peers, even if the config files haven't changed.
(closes issue #12869)
 Reported by: bcnit
 Patches:
       20090819__issue12869__2.diff.txt uploaded by tilghman (license 14)
 Tested by: lasko

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213093 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDon't blow up on a NULL cdr.
Russell Bryant [Wed, 19 Aug 2009 15:32:18 +0000 (15:32 +0000)]
Don't blow up on a NULL cdr.

Reported in #asterisk-dev.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213046 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd COLP support to chan_dahdi/sig_pri.
Richard Mudgett [Tue, 18 Aug 2009 23:53:55 +0000 (23:53 +0000)]
Add COLP support to chan_dahdi/sig_pri.

Add Connected Line Presentation (COLP) support to chan_dahdi/libpri as an
addition to issue 8824.  This is the chan_dahdi/sig_pri portion.  COLP
support is now available for any switch for which libpri supports COLP
(currently ETSI PTP, ETSI PTMP, and Q.SIG) with this patch.

(closes issue #14068)
Tested by: rmudgett

Review: https://reviewboard.asterisk.org/r/340/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@213007 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemove some accidentally-committed properties.
Kevin P. Fleming [Tue, 18 Aug 2009 20:33:34 +0000 (20:33 +0000)]
Remove some accidentally-committed properties.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212939 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoConvert this branch to Opsound music-on-hold.
Kevin P. Fleming [Tue, 18 Aug 2009 20:29:37 +0000 (20:29 +0000)]
Convert this branch to Opsound music-on-hold.

For more details:
http://blogs.digium.com/2009/08/18/asterisk-music-on-hold-changes/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212922 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoClarify some of the error messages, to help upgraders.
Tilghman Lesher [Tue, 18 Aug 2009 19:49:52 +0000 (19:49 +0000)]
Clarify some of the error messages, to help upgraders.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212883 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake the default extconfig.conf match entries with the sample res_mysql.conf.
Tilghman Lesher [Tue, 18 Aug 2009 19:25:09 +0000 (19:25 +0000)]
Make the default extconfig.conf match entries with the sample res_mysql.conf.
This eliminates a future source of possible confusion with the configuration of
1.6.1 and higher.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212857 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSmall doxygen changes
Olle Johansson [Tue, 18 Aug 2009 18:57:28 +0000 (18:57 +0000)]
Small doxygen changes

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212844 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 212763 via svnmerge from
Sean Bright [Tue, 18 Aug 2009 16:38:36 +0000 (16:38 +0000)]
Merged revisions 212763 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r212763 | seanbright | 2009-08-18 12:36:00 -0400 (Tue, 18 Aug 2009) | 11 lines

  Delay the creation of temporary files until we have a valid manager command to handle.

  Without this patch, asterisk creates a temporary file before determining if the
  specified command is valid.  If invalid, we weren't properly cleaning up the file.

  (closes issue #15730)
  Reported by: zmehmood
  Patches:
        M15730.diff uploaded by junky (license 177)
  Tested by: zmehmood
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212764 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 212727 via svnmerge from
Richard Mudgett [Tue, 18 Aug 2009 16:29:47 +0000 (16:29 +0000)]
Merged revisions 212727 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r212727 | rmudgett | 2009-08-18 11:00:56 -0500 (Tue, 18 Aug 2009) | 1 line

  Removed some deadwood and added some doxygen comments.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212758 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRelax check for XOPEN_VERSION.
Kevin P. Fleming [Mon, 17 Aug 2009 20:40:24 +0000 (20:40 +0000)]
Relax check for XOPEN_VERSION.

It's not clear that we actually require XOPEN_VERSION to be 600 or greater
at this time, so skip the check for now.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212672 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCheck the return value of opendir(3), or we may crash.
Tilghman Lesher [Mon, 17 Aug 2009 19:57:42 +0000 (19:57 +0000)]
Check the return value of opendir(3), or we may crash.
(closes issue #15720)
 Reported by: tobias_e

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212627 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCorrect spelling of AGENTACCEPTDTMF in chan_agent.
Sean Bright [Mon, 17 Aug 2009 18:50:24 +0000 (18:50 +0000)]
Correct spelling of AGENTACCEPTDTMF in chan_agent.

(closes issue #15668)
Reported by: davidw

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212581 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCorrect the return value check for ast_safe_system.
Sean Bright [Mon, 17 Aug 2009 18:18:16 +0000 (18:18 +0000)]
Correct the return value check for ast_safe_system.

The logic here was reversed as ast_safe_system returns -1 on error and not on
success.  Fix suggested by reporter.

(closes issue #15667)
Reported by: loic

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212574 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 212498 via svnmerge from
Jeff Peeler [Mon, 17 Aug 2009 16:50:45 +0000 (16:50 +0000)]
Merged revisions 212498 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r212498 | jpeeler | 2009-08-17 11:34:56 -0500 (Mon, 17 Aug 2009) | 12 lines

  Fix segfault when reloading chan_misdn.

  If more ports were specified than configured in misdn.conf a reload would crash
  asterisk. The problem was the unconfigured port was using data from the
  previously configured port. When the data for an unconfigured port was freed a
  crash would result from the double free.

  (closes issue #12113)
  Reported by: agupta
  Patches:
        bug12113.patch uploaded by jpeeler (license 325)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212506 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDefine our desires for POSIX and X/OPEN API features properly.
Kevin P. Fleming [Mon, 17 Aug 2009 16:25:10 +0000 (16:25 +0000)]
Define our desires for POSIX and X/OPEN API features properly.

Based on a post on the gcc-help mailing list and some subsequent reading,
we can increase our portability to various platforms by directly defining
the POSIX and X/OPEN API feature sets we wish to have available. This patch
does that, and also includes a double-check to ensure that the system
we are compiling on can actually provide the requested feature sets.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212463 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 212430 via svnmerge from
Richard Mudgett [Mon, 17 Aug 2009 15:42:51 +0000 (15:42 +0000)]
Merged revisions 212430 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

Fix uninitialized variable causing random MWI indications.

(closes issue #15727)
Reported by: doda
Patches:
      dahdi_changes.patch uploaded by doda (license 853)

........
  r212430 | rmudgett | 2009-08-17 10:36:28 -0500 (Mon, 17 Aug 2009) | 1 line

  Fix uninitialized variable.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212431 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd two more API calls for getting the current glue and channel in bridging code.
Joshua Colp [Sun, 16 Aug 2009 19:27:39 +0000 (19:27 +0000)]
Add two more API calls for getting the current glue and channel in bridging code.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212390 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agocast time_t type variables to long where needed.
Michiel van Baak [Sat, 15 Aug 2009 11:36:19 +0000 (11:36 +0000)]
cast time_t type variables to long where needed.

This makes res_calendar.c compile on OpenBSD and the same
cast is used in a lot of other places where time_t type vars are used.

(closes issue #15656)
Reported by: mvanbaak
Patches:
      2009081100-rescalendarcompilefix.diff.txt uploaded by mvanbaak (license 7)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212343 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd an empty line after each option when printing the
Michiel van Baak [Sat, 15 Aug 2009 11:25:11 +0000 (11:25 +0000)]
Add an empty line after each option when printing the
documentation of a function/application.

This will make reading the docs on the CLI way more easy.

(closes issue #15694)
Reported by: mvanbaak
Patches:
      2009081100-extralinesoptionlist.diff.txt uploaded by mvanbaak (license 7)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212339 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd braces where missing and a few whitespace fixes in sig_analog
Jeff Peeler [Fri, 14 Aug 2009 23:07:51 +0000 (23:07 +0000)]
Add braces where missing and a few whitespace fixes in sig_analog

(closes issue #15678)
Reported by: alecdavis
Patches:
      sig_analog_mainly_braces.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212291 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMore code that somehow got left out of sig_analog
Jeff Peeler [Fri, 14 Aug 2009 22:39:11 +0000 (22:39 +0000)]
More code that somehow got left out of sig_analog

* confirmanswer option now respected
* check and set waiting for dialtone timer
* unneeded needcallerid flag removed from analog_subchannel
* ss_astchan does not need to be a void pointer
* swap_channels callback updated to trunk
* analog_hangup now resets channel to default law

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212287 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd SSL_VERIFYPEER, as requested on the -users list
Tilghman Lesher [Fri, 14 Aug 2009 17:36:40 +0000 (17:36 +0000)]
Add SSL_VERIFYPEER, as requested on the -users list

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212249 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSend a generic return result when we receive a CallDeflection facility message in...
Richard Mudgett [Thu, 13 Aug 2009 17:33:44 +0000 (17:33 +0000)]
Send a generic return result when we receive a CallDeflection facility message in chan_misdn.

ETSI 300-196 implies that a facility return result without arguments does
not have the operation-value.  This fact implies for ETSI that you can
only use the invoke-id to match requests with responses.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212199 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd an API call for retrieving the engine in use by an RTP instance.
Joshua Colp [Thu, 13 Aug 2009 16:44:54 +0000 (16:44 +0000)]
Add an API call for retrieving the engine in use by an RTP instance.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212161 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoEnsure that T38FaxVersion is put into outgoing SDP in the proper case.
Kevin P. Fleming [Thu, 13 Aug 2009 15:46:25 +0000 (15:46 +0000)]
Ensure that T38FaxVersion is put into outgoing SDP in the proper case.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212113 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCheck an actual populated variable when seeing if we need to do video or not.
Joshua Colp [Thu, 13 Aug 2009 13:51:04 +0000 (13:51 +0000)]
Check an actual populated variable when seeing if we need to do video or not.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212067 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFixed typo
Gavin Henry [Thu, 13 Aug 2009 11:37:12 +0000 (11:37 +0000)]
Fixed typo

(closes issue #15710)
Reported by: suretec

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212027 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 211953 via svnmerge from
Matthew Nicholson [Wed, 12 Aug 2009 23:14:36 +0000 (23:14 +0000)]
Merged revisions 211953 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r211953 | mnicholson | 2009-08-12 18:04:02 -0500 (Wed, 12 Aug 2009) | 10 lines

  This patch adds additional checking when generating queue log TRANSFER events.

  The additional checks prevent generation of false TRANSFER events in certain situations.

  (closes issue #14536)
  Reported by: aragon
  Patches:
        queue-log-xfer-fix1.diff uploaded by mnicholson (license 96)
  Tested by: aragon, mnicholson
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211957 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoThis patch adds support for choosing a realm based on the domain in the From or To...
Matthew Nicholson [Wed, 12 Aug 2009 22:18:09 +0000 (22:18 +0000)]
This patch adds support for choosing a realm based on the domain in the From or To header in the incoming request.  Eligible domains are taken from the domains list in the config file.  This functionality is enabled when domainsasrealm is enabled in the config file.

(closes issue #11361)
Reported by: arkadia
Patches:
      sip_realm_mnich_to_added_2.patch uploaded by arkadia (license 233)
Tested by: arkadia

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211947 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix chan_dahdi option ringtimeout
Jeff Peeler [Wed, 12 Aug 2009 20:47:45 +0000 (20:47 +0000)]
Fix chan_dahdi option ringtimeout

dahdi_read relies on the dahdi_pvt copy of ringt which was not getting set
in sig_analog. This patch adds a callback to do so.

(closes issue #15288)
Reported by: alecdavis
Patches:
      chan_dahdi.ringtimeout.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211908 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake asterisk handle 423 Interval Too Short messages better.
Matthew Nicholson [Wed, 12 Aug 2009 19:53:14 +0000 (19:53 +0000)]
Make asterisk handle 423 Interval Too Short messages better.

This change uses separate values for the acceptable minimum expiry provided by the 423 error and the expiry value stored in the configuration file.  Previously, the value pulled from the configuration file would be overwritten.

(closes issue #14366)
Reported by: Nick_Lewis
Patches:
      sip-expiry-fix1.diff uploaded by mnicholson (license 96)
      chan_sip.c-reqexpiry.patch uploaded by Nick (license 657)
Tested by: mnicholson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211876 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 211807 via svnmerge
Mark Michelson [Wed, 12 Aug 2009 18:47:51 +0000 (18:47 +0000)]
Blocked revisions 211807 via svnmerge

........
  r211807 | mmichelson | 2009-08-12 13:46:09 -0500 (Wed, 12 Aug 2009) | 10 lines

  Backport fix so that outbound CANCEL requests have same branch as challenged INVITEs.

  There already was code present to be sure that a CANCEL will contain the same branch-id
  as the INVITE it is cancelling. However, for INVITES which are challenged downstream,
  this mechanism did not work properly. Now this is taken care of.

  This is a backport of a fix already present in all 1.6.X branches and in trunk. It also
  fixes ABE-1907.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211809 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdded three new attributes and applied a patch to res_config_ldap.c
Gavin Henry [Wed, 12 Aug 2009 16:00:46 +0000 (16:00 +0000)]
Added three new attributes and applied a patch to res_config_ldap.c

attributetype ( AstAccountSubscribeContext
        NAME 'AstAccountSubscribeContext'
        DESC 'Asterisk subscribe context'
        EQUALITY caseIgnoreMatch
        SUBSTR caseIgnoreSubstringsMatch
        SYNTAX 1.3.6.1.4.1.1466.115.121.1.15)

attributetype ( AstAccountIpAddr
        NAME 'AstAccountIpAddr'
        DESC 'Asterisk aaccount IP address'
        EQUALITY caseIgnoreMatch
        SUBSTR caseIgnoreSubstringsMatch
        SYNTAX 1.3.6.1.4.1.1466.115.121.1.15)

attributetype ( AstAccountUserAgent
        NAME 'AstAccountUserAgent'
        DESC 'Asterisk account user context'
        EQUALITY caseIgnoreMatch
        SUBSTR caseIgnoreSubstringsMatch
        SYNTAX 1.3.6.1.4.1.1466.115.121.1.15)

and patch fix_empty_attributes_1.6.1.4_v2.patch

(closes issue #13725)
Reported by: macogeek
Patches:
      fix_empty_attributes_1.6.1.4_v2.patch uploaded by xvisor (license 863)
Tested by: suretec

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211767 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAlways specify which RTP engine is desired for a new RTP instance.
Russell Bryant [Wed, 12 Aug 2009 10:11:36 +0000 (10:11 +0000)]
Always specify which RTP engine is desired for a new RTP instance.

This fixes a crash reported in #asterisk-dev where chan_mgcp unexpectedly
allocated an RTP instance from res_rtp_multicast, since by not specifying an
engine, you get the first one in the list of engines.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211732 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoEncapsulate testing for which signaling styles are used by sig_pri.
Richard Mudgett [Mon, 10 Aug 2009 23:21:57 +0000 (23:21 +0000)]
Encapsulate testing for which signaling styles are used by sig_pri.

Created the dahdi_sig_pri_lib_handles() function and
SIG_PRI_LIB_HANDLE_CASES macro to simplify testing for which signaling
styles are handled by sig_pri.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211675 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 211583 via svnmerge from
Tilghman Lesher [Mon, 10 Aug 2009 19:49:41 +0000 (19:49 +0000)]
Merged revisions 211583 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r211583 | tilghman | 2009-08-10 14:48:48 -0500 (Mon, 10 Aug 2009) | 1 line

  Conversion specifiers, not format specifiers
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211584 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAST-2009-005
Tilghman Lesher [Mon, 10 Aug 2009 19:20:57 +0000 (19:20 +0000)]
AST-2009-005

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211539 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoadd manager events when a skinny device registers/unregisters
Michiel van Baak [Mon, 10 Aug 2009 18:01:47 +0000 (18:01 +0000)]
add manager events when a skinny device registers/unregisters
like we have in chan_sip

(closes issue #15499)
Reported by: arifzaman
Patches:
      2009072600-skinnymanagerevents.diff.txt uploaded by mvanbaak (license 7)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211475 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix PRI/BRI channels when in alarm condition to only be marked for hangup if
Jeff Peeler [Mon, 10 Aug 2009 17:17:06 +0000 (17:17 +0000)]
Fix PRI/BRI channels when in alarm condition to only be marked for hangup if
T309 is not enabled.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211435 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRestoring some code to sig_pri. Not sure if it is really needed.
Richard Mudgett [Mon, 10 Aug 2009 15:53:23 +0000 (15:53 +0000)]
Restoring some code to sig_pri.  Not sure if it is really needed.

Putting some DSP code back into sig_pri that was removed by the
chan_dahdi/sig_pri reorganization.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211392 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix up some issues with getting a channel by "name".
Russell Bryant [Mon, 10 Aug 2009 15:46:39 +0000 (15:46 +0000)]
Fix up some issues with getting a channel by "name".

Even though the get_channel_by_name() API advertised that you could search by
name or uniqueid (just as the old API did), searching by uniqueid was not
actually implemented.  This patch fixes that problem.

The ast_channel_get_full() function now makes a second search attempt by
uniqueid if the parameter was a name.  The channel comparison function also
now knows how to compare by unqieueid.

Finally, a bug was fixed in passing where OBJ_POINTER was being passed in some
scenarios where it should not have been.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211390 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix retrieval of the port used for the video stream when adding SDP to a SIP message.
Joshua Colp [Mon, 10 Aug 2009 14:07:44 +0000 (14:07 +0000)]
Fix retrieval of the port used for the video stream when adding SDP to a SIP message.

(closes issue #15121)
Reported by: jsmith

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211347 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 211274 via svnmerge from
Tilghman Lesher [Sun, 9 Aug 2009 15:42:02 +0000 (15:42 +0000)]
Merged revisions 211274 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r211274 | tilghman | 2009-08-09 10:41:01 -0500 (Sun, 09 Aug 2009) | 2 lines

  Small oops.  Clear the flags which have been checked.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211275 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCheck for NULL frame, before dereferencing pointer.
Tilghman Lesher [Sun, 9 Aug 2009 07:11:22 +0000 (07:11 +0000)]
Check for NULL frame, before dereferencing pointer.
(closes issue #15617)
 Reported by: rain

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211232 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFixed some unsafe down cast pointer operations for sig_pri.
Richard Mudgett [Fri, 7 Aug 2009 23:30:32 +0000 (23:30 +0000)]
Fixed some unsafe down cast pointer operations for sig_pri.

You cannot cast the struct dahdi_pvt.sig_pvt pointer to a specific
signaling private pointer without first checking that it is in fact
pointing to the correct signaling private structure.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211197 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix static on line when PRI does overlap dialing.
Richard Mudgett [Fri, 7 Aug 2009 23:17:41 +0000 (23:17 +0000)]
Fix static on line when PRI does overlap dialing.

The wrong encoding law was used because = was used when it should
have been ==.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211191 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRecorded merge of revisions 211112 via svnmerge from
Russell Bryant [Fri, 7 Aug 2009 20:12:21 +0000 (20:12 +0000)]
Recorded merge of revisions 211112 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r211112 | russell | 2009-08-07 15:11:31 -0500 (Fri, 07 Aug 2009) | 4 lines

  Resolve a deadlock involving app_chanspy and masquerades.

  (ABE-1936)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211113 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 211038 via svnmerge from
Tilghman Lesher [Fri, 7 Aug 2009 18:17:41 +0000 (18:17 +0000)]
Merged revisions 211038 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r211038 | tilghman | 2009-08-07 13:16:28 -0500 (Fri, 07 Aug 2009) | 14 lines

  QUEUE_MEMBER_LIST _really_ wants the interface name, not the membername.

  This is a partial revert of revision 82590, which was an attempted cleanup,
  but in reality, it broke QUEUE_MEMBER_LIST, which has always been intended
  as a method by which component interfaces could be queried from the queue.
  Membername isn't useful here, because that field cannot be used to obtain
  further information about the member.  See the documentation on
  QUEUE_MEMBER_LIST, RemoveQueueMember, QUEUE_MEMBER_PENALTY, and the various
  AMI commands which take a member argument for further justification.
  (closes issue #15664)
   Reported by: rain
   Patches:
         app_queue-queue_member_list.diff uploaded by rain (license 327)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211040 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoWorkaround broken T.38 endpoints that offer tiny MaxDatagram sizes.
Kevin P. Fleming [Fri, 7 Aug 2009 13:08:00 +0000 (13:08 +0000)]
Workaround broken T.38 endpoints that offer tiny MaxDatagram sizes.

Some T.38 endpoints treat T38FaxMaxDatagram as the maximum IFP size that should
be sent to them, rather than the maximum packet payload size. If such an
endpoint also requests UDPRedundancy as the error correction mode, we'll end
up calculating a tiny maximum IFP size, so small as to be unusable. This patch
sets a lower bound on what we'll consider the remote's maximum IFP size to be,
assuming that endpoints that do this really can accept larger packets than
they've offered to accept.

(closes issue #15649)
Reported by: dazza76

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210992 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 210913 via svnmerge from
Tilghman Lesher [Thu, 6 Aug 2009 21:46:01 +0000 (21:46 +0000)]
Merged revisions 210913 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r210913 | tilghman | 2009-08-06 16:45:01 -0500 (Thu, 06 Aug 2009) | 7 lines

  Because channel information can be accessed outside of the channel thread, we must lock the channel prior to modifying it.
  (closes issue #15397)
   Reported by: caspy
   Patches:
         20090714__issue15397.diff.txt uploaded by tilghman (license 14)
   Tested by: caspy
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210914 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAllow Gosub to recognize quote delimiters without consuming them.
Tilghman Lesher [Thu, 6 Aug 2009 21:29:26 +0000 (21:29 +0000)]
Allow Gosub to recognize quote delimiters without consuming them.
(closes issue #15557)
 Reported by: rain
 Patches:
       20090723__issue15557.diff.txt uploaded by tilghman (license 14)
 Tested by: rain

Review: https://reviewboard.asterisk.org/r/316/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210908 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMiscellaneous minor fixes to sig_analog.
Richard Mudgett [Thu, 6 Aug 2009 20:15:11 +0000 (20:15 +0000)]
Miscellaneous minor fixes to sig_analog.

*  Sanity adjustments to __analog_ss_thread for sig_analog environment.
*  Deleted some duplicated code.
*  Fixed analog_ss_thread_start passing the wrong pointer.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210869 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSanity adjustments to pri_ss_thread for sig_pri environment.
Richard Mudgett [Thu, 6 Aug 2009 19:52:11 +0000 (19:52 +0000)]
Sanity adjustments to pri_ss_thread for sig_pri environment.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210866 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAccept additional T.38 reinvites after an initial one has been handled.
Joshua Colp [Thu, 6 Aug 2009 17:47:04 +0000 (17:47 +0000)]
Accept additional T.38 reinvites after an initial one has been handled.

Discussion of this subject has yielded that it is not actually acceptable to change
T.38 parameters after the initial reinvite but declining is harsh and can cause the
fax to fail when it may be possible to allow it to continue. This patch changes things
so that additional T.38 reinvites are accepted but parameter changes ignored. This gives
the fax a fighting chance.

(closes issue #15610)
Reported by: huangtx2009

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210817 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMinor improvements to app_fax.
Kevin P. Fleming [Thu, 6 Aug 2009 16:07:15 +0000 (16:07 +0000)]
Minor improvements to app_fax.

This patch makes some small changes to handle watchdog timeouts in a better way,
and also uses a 'cleaner' method of including the spandsp header files.

(closes issue #14769)
Reported by: andrew
Patches:
      app_fax-20090406.diff uploaded by andrew (license 240)
      v1-14769.patch uploaded by dimas (license 88)
Tested by: freh, deti, caspy, dimas, sgimeno, Dovid

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210777 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix potential deadlock issue with USERUSERINFO channel variable.
Richard Mudgett [Wed, 5 Aug 2009 23:44:39 +0000 (23:44 +0000)]
Fix potential deadlock issue with USERUSERINFO channel variable.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210732 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMore changes from chan_dahdi that did not make it into sig_pri.
Richard Mudgett [Wed, 5 Aug 2009 22:46:37 +0000 (22:46 +0000)]
More changes from chan_dahdi that did not make it into sig_pri.

*  Q.SIG channel mapping option.
*  discardremoteholdretrieval option.
*  libPRI debug defines.
*  pri_set_overlapdial() now set correctly.
*  pthread creation of pri_ss_thread now matches.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210696 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 210575 via svnmerge from
Richard Mudgett [Wed, 5 Aug 2009 19:40:03 +0000 (19:40 +0000)]
Merged revisions 210575 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r210575 | rmudgett | 2009-08-05 14:18:56 -0500 (Wed, 05 Aug 2009) | 14 lines

  Dialplan starts execution before the channel setup is complete.

  *  Issue 15655: For the case where dialing is complete for an incoming
  call, dahdi_new() was asked to start the PBX and then the code set more
  channel variables.  If the dialplan hungup before these channel variables
  got set, asterisk would likely crash.
  *  Fixed potential for overlap incoming call to erroneously set channel
  variables as global dialplan variables if the ast_channel structure failed
  to get allocated.
  *  Added missing set of CALLINGSUBADDR in the dialing is complete case.

  (closes issue #15655)
  Reported by: alecdavis
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210640 65c4cc65-6c06-0410-ace0-fbb531ad65f3