asterisk/asterisk.git
10 years agoMerged revisions 219519 via svnmerge from
David Vossel [Fri, 18 Sep 2009 23:20:58 +0000 (23:20 +0000)]
Merged revisions 219519 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r219519 | dvossel | 2009-09-18 18:19:50 -0500 (Fri, 18 Sep 2009) | 9 lines

  iax2 frame double free

  The iax frame's retrans sched id was written over right
  before iax2_frame_free was called.  In iax2_frame_free that
  retrans id is used to delete the sched item.  By writing over
  the retrans field before the sched item could be deleted, it was
  possible for a retransmit to occur on a freed frame.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219520 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 219450 via svnmerge from
David Vossel [Fri, 18 Sep 2009 16:20:41 +0000 (16:20 +0000)]
Merged revisions 219450 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r219450 | dvossel | 2009-09-18 11:19:15 -0500 (Fri, 18 Sep 2009) | 14 lines

  via-header branches not updated correctly on INVITE

  INVITE requests must always contain a new unique branch id. When
  a new branch id is created for an INVITE, the dialog's invite_branch
  variable must be updated so CANCEL requests use the correct branch id.

  (closes issue #15262)
  Reported by: maniax
  Patches:
        asterisk-1.6.1.0-sip-branch.patch uploaded by tweety (license 608)
        invite_new_branch_trunk.diff uploaded by dvossel (license 671)
  Tested by: maniax, dvossel
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219451 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMissing value setting line for maxsecs/maxmessage
Tilghman Lesher [Fri, 18 Sep 2009 13:54:51 +0000 (13:54 +0000)]
Missing value setting line for maxsecs/maxmessage
(closes issue #15696)
 Reported by: fhackenberger
 Patches:
       maxsecs.patch uploaded by fhackenberger (license 592)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219412 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agofixes deadlock when performing directed pickup w Invite/replaces
David Vossel [Thu, 17 Sep 2009 22:37:28 +0000 (22:37 +0000)]
fixes deadlock when performing directed pickup w Invite/replaces

(closes issue #15340)
Reported by: lmsteffan
Patches:
      deadlock.patch uploaded by lmsteffan (license 779)
Tested by: lmsteffan

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219371 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 219320 via svnmerge from
Mark Michelson [Thu, 17 Sep 2009 22:22:01 +0000 (22:22 +0000)]
Merged revisions 219320 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r219320 | mmichelson | 2009-09-17 17:20:50 -0500 (Thu, 17 Sep 2009) | 6 lines

  Send a 100 Trying response when we detect a spiral.

  This was problematic during spiral tests at SIPit...
  along with some other things as well.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219324 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 219303 via svnmerge from
David Vossel [Thu, 17 Sep 2009 21:59:21 +0000 (21:59 +0000)]
Merged revisions 219303 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r219303 | dvossel | 2009-09-17 16:29:37 -0500 (Thu, 17 Sep 2009) | 21 lines

  INVITE w/Replaces deadlock fix

  This patch cleans up the locking logic in chan_sip.c's
  handle_invite_replaces() function as well as making use
  of ast_do_masquerade() rather than forcing the masquerade
  on an ast_read().  The code had several redundant unlocks
  that would result in 'freed more times than we've locked!'
  errors. I cleaned these up as well as moving all the unlock
  logic to the end of the function.  This patch should also
  resolve the issue people were having with the replacecall
  channel never being unlocked with one legged calls.

  (closes issue #15151)
  Reported by: irroot
  Patches:
        invite_w_replaces_1.4.diff uploaded by dvossel (license 671)
  Tested by: irroot, dvossel

  Review: https://reviewboard.asterisk.org/r/371/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219304 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoEnsure no spaces exist before "refresher=" when doing the comparison.
Joshua Colp [Thu, 17 Sep 2009 19:57:39 +0000 (19:57 +0000)]
Ensure no spaces exist before "refresher=" when doing the comparison.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219264 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoGet this compiling under dev-mode.
Sean Bright [Thu, 17 Sep 2009 16:25:38 +0000 (16:25 +0000)]
Get this compiling under dev-mode.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219230 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 219136 via svnmerge from
Matthew Nicholson [Thu, 17 Sep 2009 15:18:01 +0000 (15:18 +0000)]
Merged revisions 219136 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r219136 | mnicholson | 2009-09-17 09:58:39 -0500 (Thu, 17 Sep 2009) | 10 lines

  Prevent a potential race condition and crash when hanging up a channel by removing the channel from the channel list before begining channel tear down.

  This fix may potentially cause problems with CDR backends that access the channel a CDR is associated with via the channel list.  This fix makes the channel unavabile at the time when the CDR backend is invoked.  This has been documented in include/asterisk/cdr.h.

  (closes issue #15316)
  Reported by: vmarrone
  Tested by: mnicholson

  Review: https://reviewboard.asterisk.org/r/362/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219139 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd the 'E' option to exit ChanSpy, once the single channel it spied upon hangs up.
Tilghman Lesher [Thu, 17 Sep 2009 00:58:10 +0000 (00:58 +0000)]
Add the 'E' option to exit ChanSpy, once the single channel it spied upon hangs up.
In addition, there's a bit of cleanup to the arguments and documentation, in which
I discovered that the last feature added to this application duplicated an option
(oops!) and changed that option so that it now works.
(closes issue #14909)
 Reported by: junky
 Patches:
       __20090901-spy_hangup_trunk.diff uploaded by lmadsen (license 10)
 Tested by: amilcar, junky, flujan, lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219105 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 219023 via svnmerge from
Tilghman Lesher [Wed, 16 Sep 2009 23:42:12 +0000 (23:42 +0000)]
Merged revisions 219023 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r219023 | tilghman | 2009-09-16 18:21:53 -0500 (Wed, 16 Sep 2009) | 8 lines

  Properly deal with quotes in the arguments of '#exec' includes.
  (closes issue #15583)
   Reported by: pkempgen
   Patches:
         20090726__issue15583.diff.txt uploaded by tilghman (license 14)
         20090726__issue15583-1.4-4.diff.txt uploaded by pkempgen (license 169)
   Tested by: pkempgen
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219061 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDetect whether we actually have the long double type, before looking for those functions.
Tilghman Lesher [Wed, 16 Sep 2009 23:15:43 +0000 (23:15 +0000)]
Detect whether we actually have the long double type, before looking for those functions.
(closes issue #15017)
 Reported by: tzafrir
 Patches:
       20090916__issue15017.diff.txt uploaded by tilghman (license 14)
 Tested by: tzafrir

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@219007 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemove some unused defines from res_jabber.
Sean Bright [Wed, 16 Sep 2009 20:32:50 +0000 (20:32 +0000)]
Remove some unused defines from res_jabber.

(closes issue #15359)
Reported by: snuffy
Patches:
      bug_res_jabber_unused_defines.diff uploaded by snuffy (license 35)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218973 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoReverse order of args to fread.
Mark Michelson [Wed, 16 Sep 2009 19:25:36 +0000 (19:25 +0000)]
Reverse order of args to fread.

This way, we don't always write a null byte into
byte 1 of the buffer

(closes issue #15905)
Reported by: ebroad
Patches:
      freadfix.patch uploaded by ebroad (license 878)
Tested by: ebroad

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218933 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoOn TCP and TLS connections do not attempt to stop retransmission of the packet intern...
Joshua Colp [Wed, 16 Sep 2009 18:31:47 +0000 (18:31 +0000)]
On TCP and TLS connections do not attempt to stop retransmission of the packet internally.

This was preventing responses from being properly processed because the packet was not being found
causing handle_response to return prematurely.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218918 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 218867 via svnmerge from
David Brooks [Wed, 16 Sep 2009 18:06:42 +0000 (18:06 +0000)]
Merged revisions 218867 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218867 | dbrooks | 2009-09-16 13:00:45 -0500 (Wed, 16 Sep 2009) | 13 lines

  Fixes CID pattern matching behavior to mirror that of extension pattern matching.

  Pattern matching for extensions uses a type of scoring system, giving values for
  specificity to each character in the pattern. Unfortunately, this is done character
  by character, in order. This does lead to some less specific patterns being first
  in line for matching, but it will usually get the job done.

  This patch merely brings CID matching to the same level as extension matching.
  This patch does not attempt to tackle the problem shared by extension matching.

  (closes issue #14708)
  Reported by: klaus3000
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218868 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 218798 via svnmerge from
Russell Bryant [Wed, 16 Sep 2009 13:34:41 +0000 (13:34 +0000)]
Merged revisions 218798 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218798 | russell | 2009-09-16 08:33:43 -0500 (Wed, 16 Sep 2009) | 9 lines

  Remove the IAXy firmware from Asterisk.

  The firmware can now be found on downloads.digium.com, where the rest of our
  binary downloads live.  This was the last part of our Asterisk tarballs that
  was considered non-free by Debian.  :-)

  (closes issue #15838)
  Reported by: paravoid
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218799 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 218730 via svnmerge from
Tilghman Lesher [Tue, 15 Sep 2009 22:33:10 +0000 (22:33 +0000)]
Merged revisions 218730 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218730 | tilghman | 2009-09-15 17:27:41 -0500 (Tue, 15 Sep 2009) | 6 lines

  If the user enters the same password as before, don't signal an error when the change does nothing.
  (closes issue #15492)
   Reported by: cbbs70a
   Patches:
         20090713__issue15492.diff.txt uploaded by tilghman (license 14)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218731 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoupward bound checking for port string to int conversion
David Vossel [Tue, 15 Sep 2009 19:22:37 +0000 (19:22 +0000)]
upward bound checking for port string to int conversion

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218687 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 218623 via svnmerge
Jeff Peeler [Tue, 15 Sep 2009 16:30:43 +0000 (16:30 +0000)]
Blocked revisions 218623 via svnmerge

........
  r218623 | jpeeler | 2009-09-15 11:29:27 -0500 (Tue, 15 Sep 2009) | 3 lines

  Fix small memory leak in handle_init_event by always destroying the pthread
  attr before returning.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218629 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 218578 via svnmerge from
Matthew Nicholson [Tue, 15 Sep 2009 16:15:02 +0000 (16:15 +0000)]
Merged revisions 218578 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218578 | mnicholson | 2009-09-15 11:03:54 -0500 (Tue, 15 Sep 2009) | 8 lines

  Send request contact header field with response to registrer queries instead of the address of record.

  (closes issue #14438)
  Reported by: ravindrad
  Patches:
        regquerypatch uploaded by ravindrad (license 684)
  Tested by: ravindrad
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218586 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd some changes related to 218430.
Jeff Peeler [Tue, 15 Sep 2009 16:12:49 +0000 (16:12 +0000)]
Add some changes related to 218430.

* Remove thread_spawned in handle_init_event since it was never used
* Always check handle_init_event in case a channel is destroyed

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218583 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 218577 via svnmerge from
Tilghman Lesher [Tue, 15 Sep 2009 16:04:41 +0000 (16:04 +0000)]
Merged revisions 218577 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218577 | tilghman | 2009-09-15 11:01:17 -0500 (Tue, 15 Sep 2009) | 9 lines

  Ensure FollowMe sets language in channels it creates.
  Also, not in the original bug report, but related fields are accountcode and
  musicclass, and the inheritance of datastores.
  (closes issue #15372)
   Reported by: Romik
   Patches:
         20090828__issue15372.diff.txt uploaded by tilghman (license 14)
   Tested by: cervajs
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218579 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUse a better method of ensuring null-termination of the buffer
Mark Michelson [Tue, 15 Sep 2009 15:40:14 +0000 (15:40 +0000)]
Use a better method of ensuring null-termination of the buffer
while reading the SDP when using TCP.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218566 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoEnsure that SDP read from TCP socket is null-terminated.
Mark Michelson [Tue, 15 Sep 2009 15:05:53 +0000 (15:05 +0000)]
Ensure that SDP read from TCP socket is null-terminated.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218504 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 218497 via svnmerge from
Kevin P. Fleming [Tue, 15 Sep 2009 15:02:21 +0000 (15:02 +0000)]
Merged revisions 218497 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218497 | kpfleming | 2009-09-15 10:55:58 -0400 (Tue, 15 Sep 2009) | 1 line

  Use proper hostname for downloading sound files.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218500 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix off-by-one error when reading SDP sent over TCP.
Mark Michelson [Tue, 15 Sep 2009 14:59:50 +0000 (14:59 +0000)]
Fix off-by-one error when reading SDP sent over TCP.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218499 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix false error message on DAHDI_EVENT_REMOVED (RESULT_SUCCESS == 0)
Tzafrir Cohen [Tue, 15 Sep 2009 10:24:55 +0000 (10:24 +0000)]
Fix false error message on DAHDI_EVENT_REMOVED (RESULT_SUCCESS == 0)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218465 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 218401 via svnmerge from
Jeff Peeler [Mon, 14 Sep 2009 22:38:25 +0000 (22:38 +0000)]
Merged revisions 218401 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218401 | jpeeler | 2009-09-14 16:47:11 -0500 (Mon, 14 Sep 2009) | 11 lines

  Fix handling of DAHDI_EVENT_REMOVED event to prevent crash in do_monitor.

  After talking to rmudgett about some of his recent iflist locking changes, it
  was determined that the only place that would destroy a channel without being
  explicitly to do so was in handle_init_event. The loop to walk the interface
  list has been modified to wait to destroy the channel until the dahdi_pvt of
  the channel to be destroyed is no longer needed.

  (closes issue #15378)
  Reported by: samy
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218430 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd support for multiple interface lists.
Richard Mudgett [Mon, 14 Sep 2009 20:08:11 +0000 (20:08 +0000)]
Add support for multiple interface lists.

Also unlink the sig_pri_pri.pvts[] pointer in destroy_dahdi_pvt().

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218365 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRecorded merge of revisions 218331 via svnmerge from
Tilghman Lesher [Mon, 14 Sep 2009 19:29:48 +0000 (19:29 +0000)]
Recorded merge of revisions 218331 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218331 | tilghman | 2009-09-14 14:16:35 -0500 (Mon, 14 Sep 2009) | 4 lines

  Don't say "Please try again" if we don't give the user another chance to try again.
  (issue #15055, SWP-129)
   Reported by: jthurman
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218361 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDo not attempt to add a parking extension if an error occurred while reading the...
Joshua Colp [Mon, 14 Sep 2009 18:16:39 +0000 (18:16 +0000)]
Do not attempt to add a parking extension if an error occurred while reading the configuration.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218295 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 218223 via svnmerge from
Matthew Nicholson [Mon, 14 Sep 2009 14:57:23 +0000 (14:57 +0000)]
Merged revisions 218223 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218223 | mnicholson | 2009-09-14 09:53:57 -0500 (Mon, 14 Sep 2009) | 8 lines

  Ensure we don't pickup ourselves when doing pickup by exten.

  (closes issue #15100)
  Reported by: lmsteffan
  Patches:
        (modified) pickup.patch uploaded by lmsteffan (license 779)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218224 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agogcc 4.4: Remove a nop memset size 0 that annoys gcc
Tzafrir Cohen [Sun, 13 Sep 2009 17:34:11 +0000 (17:34 +0000)]
gcc 4.4: Remove a nop memset size 0 that annoys gcc

This memset doesn't write beyond the end of the buffer.
(tmpbuf has size of 4).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218184 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoget rid of mfcr2 monitor thread condition, is problematic
Moises Silva [Sun, 13 Sep 2009 05:51:46 +0000 (05:51 +0000)]
get rid of mfcr2 monitor thread condition, is problematic

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218150 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agouse the actual given ip address for 'rtp set debug ip <foo>' instead of the word...
Michiel van Baak [Sat, 12 Sep 2009 13:08:16 +0000 (13:08 +0000)]
use the actual given ip address for 'rtp set debug ip <foo>' instead of the word 'ip'

(closes issue #15711)
Reported by: davidw
Patches:
      2009082800-rtpdebug.diff.txt uploaded by mvanbaak (license 7)
Tested by: davidw

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218107 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCheck the origination priority for more matches, not the current priority.
Tilghman Lesher [Fri, 11 Sep 2009 05:58:11 +0000 (05:58 +0000)]
Check the origination priority for more matches, not the current priority.
Found by Pavel Troller on the -dev list.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@218050 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 217989 via svnmerge from
Tilghman Lesher [Thu, 10 Sep 2009 23:54:51 +0000 (23:54 +0000)]
Merged revisions 217989 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r217989 | tilghman | 2009-09-10 18:52:22 -0500 (Thu, 10 Sep 2009) | 3 lines

  Don't ring another channel, if there's not enough time for a queue member to answer.
  (Fixes AST-228)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217990 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCleanup approach in 217804 and don't reach inside the sig_pvt.
Jeff Peeler [Thu, 10 Sep 2009 23:49:09 +0000 (23:49 +0000)]
Cleanup approach in 217804 and don't reach inside the sig_pvt.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217987 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAllow do not disturb to be set on analog channels via the CLI and AMI.
Jeff Peeler [Thu, 10 Sep 2009 23:29:14 +0000 (23:29 +0000)]
Allow do not disturb to be set on analog channels via the CLI and AMI.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217954 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 217917 via svnmerge
Tilghman Lesher [Thu, 10 Sep 2009 23:16:24 +0000 (23:16 +0000)]
Blocked revisions 217917 via svnmerge

........
  r217917 | tilghman | 2009-09-10 18:15:21 -0500 (Thu, 10 Sep 2009) | 2 lines

  Backport realtime fix to 1.4
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217918 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake calltoken support work with realtime users and peers.
Tilghman Lesher [Thu, 10 Sep 2009 23:12:16 +0000 (23:12 +0000)]
Make calltoken support work with realtime users and peers.
In the course of this, I also found that the results of ast_gethostbyname
were being used incorrectly in both chan_iax2 and chan_sip, so both have
been fixed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217916 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCleaned up chan_dahdi iflist handling and locking.
Richard Mudgett [Thu, 10 Sep 2009 22:31:12 +0000 (22:31 +0000)]
Cleaned up chan_dahdi iflist handling and locking.

*  Fixed walking the iflist so it is always done with the iflock locked.
*  Simplified iflist walking routines.
*  Created chan_dahdi iflist insertion and extraction routines.
*  Fixed duplicate_pseudo() malloc fail handling.
*  Fixed infinite loop in action_dahdishowchannels() when showing a single channel.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217912 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMiscellaneous minor changes.
Richard Mudgett [Thu, 10 Sep 2009 22:11:17 +0000 (22:11 +0000)]
Miscellaneous minor changes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217873 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 217806 via svnmerge from
David Vossel [Thu, 10 Sep 2009 21:07:47 +0000 (21:07 +0000)]
Merged revisions 217806 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r217806 | dvossel | 2009-09-10 16:06:07 -0500 (Thu, 10 Sep 2009) | 22 lines

  IAX2 encryption regression

  The IAX2 Call Token security patch inadvertently broke the use of
  encryption due to the reorganization of code in the socket_process()
  function.  When encryption is used, an incoming full frame must first
  be decrypted before the information elements can be parsed.  The
  security release mistakenly moved IE parsing before decryption in
  order to process the new Call Token IE.  To resolve this, decryption
  of full frames is once again done before looking into the frame.  This
  involves searching for an existing callno, checking the pvt to see if
  encryption is turned on, and decrypting the packet before the internal
  fields of the full frame are accessed.

  (closes issue #15834)
  Reported by: karesmakro
  Patches:
        iax2_encryption_fix_1.4.diff uploaded by dvossel (license 671)
  Tested by: dvossel, karesmakro

  Review: https://reviewboard.asterisk.org/r/355/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217807 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix crash during attended transfer over PRI.
Jeff Peeler [Thu, 10 Sep 2009 20:52:57 +0000 (20:52 +0000)]
Fix crash during attended transfer over PRI.

The owner pointers in the sig_pri_chan structure were not getting updated
in dahdi_fixup.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217804 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoStop caller id transmission when offhook event detected.
Jeff Peeler [Thu, 10 Sep 2009 20:18:30 +0000 (20:18 +0000)]
Stop caller id transmission when offhook event detected.

This fixes the problem that would occur if an analog phone was picked up while
the caller id was being sent. The caller id before sent the whole spill even
after pickup and is now corrected.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217744 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 217735 via svnmerge
Olle Johansson [Thu, 10 Sep 2009 19:55:16 +0000 (19:55 +0000)]
Blocked revisions 217735 via svnmerge

........
r217735 | oej | 2009-09-10 21:52:19 +0200 (Tor, 10 Sep 2009) | 4 lines

Reinstate muted that was removed by mistake.

muted doesn't compile any more on os/x, so I have to disable it in order to testcompile other code...

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217737 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSets the correct musicclass after an announcement
Matthias Nick [Thu, 10 Sep 2009 19:39:41 +0000 (19:39 +0000)]
Sets the correct musicclass after an announcement

(closes issue #15279)
Reported by: mbeckwell
Patches:
      patch.txt uploaded by mnick (license )
Tested by: mnick

(closes issue #15832)
Reported by: mbeckwell
Patches:
      patch.txt uploaded by mnick (license 874)
Tested by: mnick

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217730 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 217668 via svnmerge
Olle Johansson [Thu, 10 Sep 2009 19:09:02 +0000 (19:09 +0000)]
Blocked revisions 217668 via svnmerge

........
r217668 | oej | 2009-09-10 21:07:24 +0200 (Tor, 10 Sep 2009) | 9 lines

Remove harmful code that causes endless loops.
Remove code that causes loops in registrations.

We have agreed that the patch that this code was part of was bad. I am ripping out the code that causes
the issue. putnopvut needs to check the rest of the patch, if it needs to be changed as well.

This solves the issue reported in #15540, but needs more work before we close it (as described above).

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217669 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDon't assign UINT_MAX to an INT.
Olle Johansson [Thu, 10 Sep 2009 18:29:21 +0000 (18:29 +0000)]
Don't assign UINT_MAX to an INT.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217663 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoVerify support for wide ODBC character types before using them.
Tilghman Lesher [Thu, 10 Sep 2009 18:17:14 +0000 (18:17 +0000)]
Verify support for wide ODBC character types before using them.
(closes issue #15870)
 Reported by: nic_bellamy

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217638 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoInclude ActionID in all events that are responsed to AMI Action SIPShowRegistry
Olle Johansson [Thu, 10 Sep 2009 12:06:55 +0000 (12:06 +0000)]
Include ActionID in all events that are responsed to AMI Action SIPShowRegistry

(closes issue #15868)
Reported by: nic_bellamy
Patches:
      manager_SIPshowregistry_actionid.patch uploaded by nic bellamy (license 299)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217593 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix available() for SS7, MFC/R2, and pseudo channels.
Richard Mudgett [Thu, 10 Sep 2009 00:35:30 +0000 (00:35 +0000)]
Fix available() for SS7, MFC/R2, and pseudo channels.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217560 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoast_log replaced for ast_verbose in MFCR2 event notifications
Moises Silva [Wed, 9 Sep 2009 21:48:04 +0000 (21:48 +0000)]
ast_log replaced for ast_verbose in MFCR2 event notifications

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217524 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDon't report transfer success until we actually know. 1xx messages are not final.
Olle Johansson [Wed, 9 Sep 2009 20:09:31 +0000 (20:09 +0000)]
Don't report transfer success until we actually know. 1xx messages are not final.

Related to #12713

Patch by oej

A big thank you to file for finally fixing the transfer() dialplan application.
I've been waiting for years for this. Great work!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217482 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agogcc 4.4 fix: union instead of cast
Tzafrir Cohen [Wed, 9 Sep 2009 18:52:48 +0000 (18:52 +0000)]
gcc 4.4 fix: union instead of cast

gcc 4.4 has more strict rules for aliasing. It doesn't like a
struct sockaddr_in pointer pointing to a struct sockaddr. So we make it
a union.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217445 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoProperly terminate the response to the manager Ping action.
Sean Bright [Wed, 9 Sep 2009 12:11:12 +0000 (12:11 +0000)]
Properly terminate the response to the manager Ping action.

In passing, correct the formatting of the Timestamp attribute so that there is a
space after the colon and before the value.

(closes issue #15861)
Reported by: Ivan

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217408 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoNot having any TLS session to write to is a serious XMIT_ERROR.
Olle Johansson [Wed, 9 Sep 2009 10:39:43 +0000 (10:39 +0000)]
Not having any TLS session to write to is a serious XMIT_ERROR.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217368 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFormatting and doxygen updates
Olle Johansson [Wed, 9 Sep 2009 10:38:45 +0000 (10:38 +0000)]
Formatting and doxygen updates

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217367 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix memory leak of sig_xxx private structures.
Richard Mudgett [Tue, 8 Sep 2009 23:37:57 +0000 (23:37 +0000)]
Fix memory leak of sig_xxx private structures.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217332 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMiscellaneous minor code cleanup in mkintf().
Richard Mudgett [Tue, 8 Sep 2009 23:31:27 +0000 (23:31 +0000)]
Miscellaneous minor code cleanup in mkintf().

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217331 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix compilation of app_meetme.
Sean Bright [Tue, 8 Sep 2009 22:17:08 +0000 (22:17 +0000)]
Fix compilation of app_meetme.

Reported by ebroad in #asterisk-bugs

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217286 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemove duplicate entry in the sig_pri_pri private pointer array.
Richard Mudgett [Tue, 8 Sep 2009 21:17:16 +0000 (21:17 +0000)]
Remove duplicate entry in the sig_pri_pri private pointer array.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217236 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 217156 via svnmerge from
Tilghman Lesher [Tue, 8 Sep 2009 20:28:41 +0000 (20:28 +0000)]
Merged revisions 217156 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r217156 | tilghman | 2009-09-08 15:01:45 -0500 (Tue, 08 Sep 2009) | 7 lines

  When MOH is playing on the channel, announcements sent through the conference are not heard.
  (closes issue #14588)
   Reported by: voipas
   Patches:
         20090716__issue14588__2.diff.txt uploaded by tilghman (license 14)
   Tested by: lmadsen, twisted, tilghman
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217199 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd doxygen to ast_event_subscribe for the description.
Mark Michelson [Tue, 8 Sep 2009 20:06:15 +0000 (20:06 +0000)]
Add doxygen to ast_event_subscribe for the description.

Most importantly, note that a NULL description will cause a
crash, as I just experienced that firsthand.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217158 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix audio problems with format_mp3.
Russell Bryant [Tue, 8 Sep 2009 18:06:57 +0000 (18:06 +0000)]
Fix audio problems with format_mp3.

This problem was introduced when the AST_FRIENDLY_OFFSET patch was merged.
I'm surprised that nobody noticed any trouble when testing that patch, but this
fixes the code that fills in the buffer to start filling in after the offset
portion of the buffer.

(closes issue #15850)
Reported by: 99gixxer
Patches:
      issue15850.diff1.txt uploaded by russell (license 2)
Tested by: 99gixxer

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217113 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoEnsure that the default autoconf CFLAGS are not used.
Kevin P. Fleming [Tue, 8 Sep 2009 16:37:28 +0000 (16:37 +0000)]
Ensure that the default autoconf CFLAGS are not used.

A recent change to the configure script that allows the user to specify
CFLAGS and/or LDFLAGS to the script had the unfortunate side effect of
letting autoconf's default CFLAGS (-g -O2) feed in to the rest of the build
system, thereby overriding the DONT_OPTIMIZE setting in menuselect. That
problem is now corrected.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217074 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemove what appears to be an unnecessary define.
Tilghman Lesher [Tue, 8 Sep 2009 15:30:18 +0000 (15:30 +0000)]
Remove what appears to be an unnecessary define.
(closes issue #15851)
 Reported by: tzafrir

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217033 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agolive_ast: Fix asterisk.conf instead of regenerating it
Tzafrir Cohen [Tue, 8 Sep 2009 15:23:04 +0000 (15:23 +0000)]
live_ast: Fix asterisk.conf instead of regenerating it

* Don't write asterisk.conf from scratch. Fix the existing one.
* Pass extra 'make' command-line arguments to 'install' and 'samples'.
* Fix some extra typos.

closes issue #15019 .

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@217015 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agocaller id number empty
David Vossel [Tue, 8 Sep 2009 14:26:30 +0000 (14:26 +0000)]
caller id number empty

parse_uri was not being given the correct scheme's, as
a result, uri parsing did not parse the username correctly.
One of the side effects of this is an empty caller id.

(closes issue #15839)
Reported by: ebroad
Patches:
      blank_cidv2.patch uploaded by ebroad (license 878)
      parse_uri_fix.diff uploaded by dvossel (license 671)
Tested by: ebroad, dvossel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216993 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFixing formatting
Olle Johansson [Mon, 7 Sep 2009 20:23:19 +0000 (20:23 +0000)]
Fixing formatting

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216956 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd new actions under "new actions" and not in the top of the document
Olle Johansson [Mon, 7 Sep 2009 20:19:37 +0000 (20:19 +0000)]
Add new actions under "new actions" and not in the top of the document

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216955 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMoving another function declared in the middle of forward declarations.
Olle Johansson [Mon, 7 Sep 2009 18:29:45 +0000 (18:29 +0000)]
Moving another function declared in the middle of forward declarations.

Please follow the structure of the source code, thanks. Chan_sip is messy enough as it is :-)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216917 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMove "deprecated_username" to a flag like the others - unsigned int blah:1
Olle Johansson [Mon, 7 Sep 2009 18:26:37 +0000 (18:26 +0000)]
Move "deprecated_username" to a flag like the others - unsigned int blah:1

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216912 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago- Doxygen additions
Olle Johansson [Mon, 7 Sep 2009 18:24:04 +0000 (18:24 +0000)]
- Doxygen additions
- Remove unused string in sip_registry -- "random"
- Someone added a function in the middle of all forward declarations... Weird. Moved it out of that
  section.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216905 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoClean up the "offered_media" code
Olle Johansson [Mon, 7 Sep 2009 18:00:48 +0000 (18:00 +0000)]
Clean up the "offered_media" code
- Add variable for number of known media streams instead of hardcoding in definition of sip_pvt
- Rename "text" to "codecs" - beacuse it's what it is
- Add documentation for future developers so that we make sure that we define new sdp media types
  for SRTP-variants

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216883 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAllow multiple rows to be fetched within the normal mode of operation.
Tilghman Lesher [Mon, 7 Sep 2009 17:15:37 +0000 (17:15 +0000)]
Allow multiple rows to be fetched within the normal mode of operation.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216846 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake sure we reset global_exclude_static at channel reload
Olle Johansson [Mon, 7 Sep 2009 16:35:12 +0000 (16:35 +0000)]
Make sure we reset global_exclude_static at channel reload

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216842 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMove capability into sip_cfg. While at it, make sure we reset it at channel reload.
Olle Johansson [Mon, 7 Sep 2009 16:31:36 +0000 (16:31 +0000)]
Move capability into sip_cfg. While at it, make sure we reset it at channel reload.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216841 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMove global_regcontext into the sip_cfg structure
Olle Johansson [Mon, 7 Sep 2009 16:26:04 +0000 (16:26 +0000)]
Move global_regcontext into the sip_cfg structure

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216834 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMove contact_ha to sip_cfg structure
Olle Johansson [Mon, 7 Sep 2009 16:23:39 +0000 (16:23 +0000)]
Move contact_ha to sip_cfg structure

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216826 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDoxygen updates
Olle Johansson [Mon, 7 Sep 2009 16:16:58 +0000 (16:16 +0000)]
Doxygen updates

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216806 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSince it's possible to have more than 999 calls, I'm changing the call counter roof...
Olle Johansson [Mon, 7 Sep 2009 16:08:08 +0000 (16:08 +0000)]
Since it's possible to have more than 999 calls, I'm changing the call counter roof to something higher.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216805 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoadd doxygen and remove duplicate declaration of variable
Olle Johansson [Mon, 7 Sep 2009 16:00:41 +0000 (16:00 +0000)]
add doxygen and remove duplicate declaration of variable

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216804 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAfter many years, remove VOCAL_DATA_HACK definition
Olle Johansson [Mon, 7 Sep 2009 15:48:41 +0000 (15:48 +0000)]
After many years, remove VOCAL_DATA_HACK definition

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216803 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemove unneeded header files (tested on Linux and OS/X)
Olle Johansson [Mon, 7 Sep 2009 15:47:40 +0000 (15:47 +0000)]
Remove unneeded header files (tested on Linux and OS/X)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216802 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDon't send MESSAGE with sendtext() if recepient doesn't allow MESSAGE requests
Olle Johansson [Mon, 7 Sep 2009 14:54:14 +0000 (14:54 +0000)]
Don't send MESSAGE with sendtext() if recepient doesn't allow MESSAGE requests

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216769 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd some doxygen
Olle Johansson [Mon, 7 Sep 2009 14:21:01 +0000 (14:21 +0000)]
Add some doxygen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216748 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix typo
Olle Johansson [Mon, 7 Sep 2009 14:04:40 +0000 (14:04 +0000)]
Fix typo

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216735 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoIf there is no session timer in the INVITE, set it to default value (not unset minimu...
Olle Johansson [Mon, 7 Sep 2009 13:06:19 +0000 (13:06 +0000)]
If there is no session timer in the INVITE, set it to default value (not unset minimum = -1)

Patch by oej

closes issue #15621
Reported by: fnordian
Tested by: atis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216695 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUpdate sip.conf.sample documentation, reorganize a bit
Olle Johansson [Mon, 7 Sep 2009 12:41:08 +0000 (12:41 +0000)]
Update sip.conf.sample documentation, reorganize a bit

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216694 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSimplify the code in this function
Olle Johansson [Mon, 7 Sep 2009 11:31:19 +0000 (11:31 +0000)]
Simplify the code in this function

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216652 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agosip peer matching by address only with TCP/TLS
David Vossel [Fri, 4 Sep 2009 19:32:07 +0000 (19:32 +0000)]
sip peer matching by address only with TCP/TLS

This patch removes the contact header matching logic and
adds logic to match all tcp/tls connections by ip only.
Thanks to oej for finding the issue and suggesting solutions.

Review: https://reviewboard.asterisk.org/r/354/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216594 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUse ast_free() instead of free().
Sean Bright [Fri, 4 Sep 2009 19:29:02 +0000 (19:29 +0000)]
Use ast_free() instead of free().

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216593 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix trunk breakage.
Tilghman Lesher [Fri, 4 Sep 2009 17:50:21 +0000 (17:50 +0000)]
Fix trunk breakage.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216551 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoEnable turning off the application delimiter warning with the 'dontwarn' option.
Tilghman Lesher [Fri, 4 Sep 2009 17:31:44 +0000 (17:31 +0000)]
Enable turning off the application delimiter warning with the 'dontwarn' option.
Suggested on the -dev list, and implemented in an alternate way by me.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216547 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 216435 via svnmerge from
Michiel van Baak [Fri, 4 Sep 2009 15:05:05 +0000 (15:05 +0000)]
Merged revisions 216435 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r216435 | mvanbaak | 2009-09-04 15:56:10 +0200 (Fri, 04 Sep 2009) | 2 lines

  make asterisk compile under devmode with DEBUG_THREADS enabled on OpenBSD
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216506 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 216430 via svnmerge from
Olle Johansson [Fri, 4 Sep 2009 14:02:34 +0000 (14:02 +0000)]
Merged revisions 216430 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r216430 | oej | 2009-09-04 15:45:48 +0200 (Fre, 04 Sep 2009) | 27 lines

Make apps send PROGRESS control frame for early media and fix too early media issue in SIP

The issue at hand is that some legacy (dying) PBX systems send empty media frames on PRI
links *before* any call progress. The SIP channel receives these frames and by default
signals 183 Session progress and starts sending media. This will cause phones to
play silence and ignore the later 180 ringing message. A bad user experience.

The fix is twofold:
- We discovered that asterisk apps that support early media ("noanswer") did not send
  any PROGRESS frame to indicate early media. Fixed.
- We introduce a setting in chan_sip so that users can disable any relay of media frames
  before the outbound channel actually indicates any sort of call progress.
  In 1.4, 1.6.0 and 1.6.1, this will be disabled for backward compatibility. In later versions
  of Asterisk, this will be enabled. We don't assume that it will change your Asterisk
  phone experience - only for the better.

We encourage third-party application developers to make sure that if they have applications
that wants to send early media, add a PROGRESS control frame transmission to make sure that
all channel drivers actually will start sending early media. This has not been the default
in Asterisk previous to this patch, so if you got inspiration from our code, you need to
update accordingly. Sorry for the trouble and thanks for your support.

This code has been running for a few months in a large scale installation (over 250
servers with PRI and/or BRI links to old PBX systems).
That's no proof that this is an excellent patch, but, well, it's tested :-)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216438 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agomake sure canlog is set so we can compile with DEBUG_THREADS enabled on OpenBSD
Michiel van Baak [Fri, 4 Sep 2009 14:00:38 +0000 (14:00 +0000)]
make sure canlog is set so we can compile with DEBUG_THREADS enabled on OpenBSD

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216437 65c4cc65-6c06-0410-ace0-fbb531ad65f3