asterisk/asterisk.git
10 years agoMerged revisions 212763 via svnmerge from
Sean Bright [Tue, 18 Aug 2009 16:38:36 +0000 (16:38 +0000)]
Merged revisions 212763 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r212763 | seanbright | 2009-08-18 12:36:00 -0400 (Tue, 18 Aug 2009) | 11 lines

  Delay the creation of temporary files until we have a valid manager command to handle.

  Without this patch, asterisk creates a temporary file before determining if the
  specified command is valid.  If invalid, we weren't properly cleaning up the file.

  (closes issue #15730)
  Reported by: zmehmood
  Patches:
        M15730.diff uploaded by junky (license 177)
  Tested by: zmehmood
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212764 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 212727 via svnmerge from
Richard Mudgett [Tue, 18 Aug 2009 16:29:47 +0000 (16:29 +0000)]
Merged revisions 212727 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r212727 | rmudgett | 2009-08-18 11:00:56 -0500 (Tue, 18 Aug 2009) | 1 line

  Removed some deadwood and added some doxygen comments.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212758 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRelax check for XOPEN_VERSION.
Kevin P. Fleming [Mon, 17 Aug 2009 20:40:24 +0000 (20:40 +0000)]
Relax check for XOPEN_VERSION.

It's not clear that we actually require XOPEN_VERSION to be 600 or greater
at this time, so skip the check for now.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212672 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCheck the return value of opendir(3), or we may crash.
Tilghman Lesher [Mon, 17 Aug 2009 19:57:42 +0000 (19:57 +0000)]
Check the return value of opendir(3), or we may crash.
(closes issue #15720)
 Reported by: tobias_e

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212627 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCorrect spelling of AGENTACCEPTDTMF in chan_agent.
Sean Bright [Mon, 17 Aug 2009 18:50:24 +0000 (18:50 +0000)]
Correct spelling of AGENTACCEPTDTMF in chan_agent.

(closes issue #15668)
Reported by: davidw

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212581 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCorrect the return value check for ast_safe_system.
Sean Bright [Mon, 17 Aug 2009 18:18:16 +0000 (18:18 +0000)]
Correct the return value check for ast_safe_system.

The logic here was reversed as ast_safe_system returns -1 on error and not on
success.  Fix suggested by reporter.

(closes issue #15667)
Reported by: loic

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212574 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 212498 via svnmerge from
Jeff Peeler [Mon, 17 Aug 2009 16:50:45 +0000 (16:50 +0000)]
Merged revisions 212498 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r212498 | jpeeler | 2009-08-17 11:34:56 -0500 (Mon, 17 Aug 2009) | 12 lines

  Fix segfault when reloading chan_misdn.

  If more ports were specified than configured in misdn.conf a reload would crash
  asterisk. The problem was the unconfigured port was using data from the
  previously configured port. When the data for an unconfigured port was freed a
  crash would result from the double free.

  (closes issue #12113)
  Reported by: agupta
  Patches:
        bug12113.patch uploaded by jpeeler (license 325)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212506 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDefine our desires for POSIX and X/OPEN API features properly.
Kevin P. Fleming [Mon, 17 Aug 2009 16:25:10 +0000 (16:25 +0000)]
Define our desires for POSIX and X/OPEN API features properly.

Based on a post on the gcc-help mailing list and some subsequent reading,
we can increase our portability to various platforms by directly defining
the POSIX and X/OPEN API feature sets we wish to have available. This patch
does that, and also includes a double-check to ensure that the system
we are compiling on can actually provide the requested feature sets.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212463 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 212430 via svnmerge from
Richard Mudgett [Mon, 17 Aug 2009 15:42:51 +0000 (15:42 +0000)]
Merged revisions 212430 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

Fix uninitialized variable causing random MWI indications.

(closes issue #15727)
Reported by: doda
Patches:
      dahdi_changes.patch uploaded by doda (license 853)

........
  r212430 | rmudgett | 2009-08-17 10:36:28 -0500 (Mon, 17 Aug 2009) | 1 line

  Fix uninitialized variable.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212431 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd two more API calls for getting the current glue and channel in bridging code.
Joshua Colp [Sun, 16 Aug 2009 19:27:39 +0000 (19:27 +0000)]
Add two more API calls for getting the current glue and channel in bridging code.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212390 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agocast time_t type variables to long where needed.
Michiel van Baak [Sat, 15 Aug 2009 11:36:19 +0000 (11:36 +0000)]
cast time_t type variables to long where needed.

This makes res_calendar.c compile on OpenBSD and the same
cast is used in a lot of other places where time_t type vars are used.

(closes issue #15656)
Reported by: mvanbaak
Patches:
      2009081100-rescalendarcompilefix.diff.txt uploaded by mvanbaak (license 7)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212343 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd an empty line after each option when printing the
Michiel van Baak [Sat, 15 Aug 2009 11:25:11 +0000 (11:25 +0000)]
Add an empty line after each option when printing the
documentation of a function/application.

This will make reading the docs on the CLI way more easy.

(closes issue #15694)
Reported by: mvanbaak
Patches:
      2009081100-extralinesoptionlist.diff.txt uploaded by mvanbaak (license 7)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212339 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd braces where missing and a few whitespace fixes in sig_analog
Jeff Peeler [Fri, 14 Aug 2009 23:07:51 +0000 (23:07 +0000)]
Add braces where missing and a few whitespace fixes in sig_analog

(closes issue #15678)
Reported by: alecdavis
Patches:
      sig_analog_mainly_braces.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212291 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMore code that somehow got left out of sig_analog
Jeff Peeler [Fri, 14 Aug 2009 22:39:11 +0000 (22:39 +0000)]
More code that somehow got left out of sig_analog

* confirmanswer option now respected
* check and set waiting for dialtone timer
* unneeded needcallerid flag removed from analog_subchannel
* ss_astchan does not need to be a void pointer
* swap_channels callback updated to trunk
* analog_hangup now resets channel to default law

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212287 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd SSL_VERIFYPEER, as requested on the -users list
Tilghman Lesher [Fri, 14 Aug 2009 17:36:40 +0000 (17:36 +0000)]
Add SSL_VERIFYPEER, as requested on the -users list

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212249 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSend a generic return result when we receive a CallDeflection facility message in...
Richard Mudgett [Thu, 13 Aug 2009 17:33:44 +0000 (17:33 +0000)]
Send a generic return result when we receive a CallDeflection facility message in chan_misdn.

ETSI 300-196 implies that a facility return result without arguments does
not have the operation-value.  This fact implies for ETSI that you can
only use the invoke-id to match requests with responses.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212199 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd an API call for retrieving the engine in use by an RTP instance.
Joshua Colp [Thu, 13 Aug 2009 16:44:54 +0000 (16:44 +0000)]
Add an API call for retrieving the engine in use by an RTP instance.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212161 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoEnsure that T38FaxVersion is put into outgoing SDP in the proper case.
Kevin P. Fleming [Thu, 13 Aug 2009 15:46:25 +0000 (15:46 +0000)]
Ensure that T38FaxVersion is put into outgoing SDP in the proper case.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212113 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCheck an actual populated variable when seeing if we need to do video or not.
Joshua Colp [Thu, 13 Aug 2009 13:51:04 +0000 (13:51 +0000)]
Check an actual populated variable when seeing if we need to do video or not.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212067 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFixed typo
Gavin Henry [Thu, 13 Aug 2009 11:37:12 +0000 (11:37 +0000)]
Fixed typo

(closes issue #15710)
Reported by: suretec

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@212027 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 211953 via svnmerge from
Matthew Nicholson [Wed, 12 Aug 2009 23:14:36 +0000 (23:14 +0000)]
Merged revisions 211953 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r211953 | mnicholson | 2009-08-12 18:04:02 -0500 (Wed, 12 Aug 2009) | 10 lines

  This patch adds additional checking when generating queue log TRANSFER events.

  The additional checks prevent generation of false TRANSFER events in certain situations.

  (closes issue #14536)
  Reported by: aragon
  Patches:
        queue-log-xfer-fix1.diff uploaded by mnicholson (license 96)
  Tested by: aragon, mnicholson
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211957 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoThis patch adds support for choosing a realm based on the domain in the From or To...
Matthew Nicholson [Wed, 12 Aug 2009 22:18:09 +0000 (22:18 +0000)]
This patch adds support for choosing a realm based on the domain in the From or To header in the incoming request.  Eligible domains are taken from the domains list in the config file.  This functionality is enabled when domainsasrealm is enabled in the config file.

(closes issue #11361)
Reported by: arkadia
Patches:
      sip_realm_mnich_to_added_2.patch uploaded by arkadia (license 233)
Tested by: arkadia

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211947 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix chan_dahdi option ringtimeout
Jeff Peeler [Wed, 12 Aug 2009 20:47:45 +0000 (20:47 +0000)]
Fix chan_dahdi option ringtimeout

dahdi_read relies on the dahdi_pvt copy of ringt which was not getting set
in sig_analog. This patch adds a callback to do so.

(closes issue #15288)
Reported by: alecdavis
Patches:
      chan_dahdi.ringtimeout.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211908 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake asterisk handle 423 Interval Too Short messages better.
Matthew Nicholson [Wed, 12 Aug 2009 19:53:14 +0000 (19:53 +0000)]
Make asterisk handle 423 Interval Too Short messages better.

This change uses separate values for the acceptable minimum expiry provided by the 423 error and the expiry value stored in the configuration file.  Previously, the value pulled from the configuration file would be overwritten.

(closes issue #14366)
Reported by: Nick_Lewis
Patches:
      sip-expiry-fix1.diff uploaded by mnicholson (license 96)
      chan_sip.c-reqexpiry.patch uploaded by Nick (license 657)
Tested by: mnicholson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211876 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 211807 via svnmerge
Mark Michelson [Wed, 12 Aug 2009 18:47:51 +0000 (18:47 +0000)]
Blocked revisions 211807 via svnmerge

........
  r211807 | mmichelson | 2009-08-12 13:46:09 -0500 (Wed, 12 Aug 2009) | 10 lines

  Backport fix so that outbound CANCEL requests have same branch as challenged INVITEs.

  There already was code present to be sure that a CANCEL will contain the same branch-id
  as the INVITE it is cancelling. However, for INVITES which are challenged downstream,
  this mechanism did not work properly. Now this is taken care of.

  This is a backport of a fix already present in all 1.6.X branches and in trunk. It also
  fixes ABE-1907.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211809 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdded three new attributes and applied a patch to res_config_ldap.c
Gavin Henry [Wed, 12 Aug 2009 16:00:46 +0000 (16:00 +0000)]
Added three new attributes and applied a patch to res_config_ldap.c

attributetype ( AstAccountSubscribeContext
        NAME 'AstAccountSubscribeContext'
        DESC 'Asterisk subscribe context'
        EQUALITY caseIgnoreMatch
        SUBSTR caseIgnoreSubstringsMatch
        SYNTAX 1.3.6.1.4.1.1466.115.121.1.15)

attributetype ( AstAccountIpAddr
        NAME 'AstAccountIpAddr'
        DESC 'Asterisk aaccount IP address'
        EQUALITY caseIgnoreMatch
        SUBSTR caseIgnoreSubstringsMatch
        SYNTAX 1.3.6.1.4.1.1466.115.121.1.15)

attributetype ( AstAccountUserAgent
        NAME 'AstAccountUserAgent'
        DESC 'Asterisk account user context'
        EQUALITY caseIgnoreMatch
        SUBSTR caseIgnoreSubstringsMatch
        SYNTAX 1.3.6.1.4.1.1466.115.121.1.15)

and patch fix_empty_attributes_1.6.1.4_v2.patch

(closes issue #13725)
Reported by: macogeek
Patches:
      fix_empty_attributes_1.6.1.4_v2.patch uploaded by xvisor (license 863)
Tested by: suretec

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211767 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAlways specify which RTP engine is desired for a new RTP instance.
Russell Bryant [Wed, 12 Aug 2009 10:11:36 +0000 (10:11 +0000)]
Always specify which RTP engine is desired for a new RTP instance.

This fixes a crash reported in #asterisk-dev where chan_mgcp unexpectedly
allocated an RTP instance from res_rtp_multicast, since by not specifying an
engine, you get the first one in the list of engines.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211732 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoEncapsulate testing for which signaling styles are used by sig_pri.
Richard Mudgett [Mon, 10 Aug 2009 23:21:57 +0000 (23:21 +0000)]
Encapsulate testing for which signaling styles are used by sig_pri.

Created the dahdi_sig_pri_lib_handles() function and
SIG_PRI_LIB_HANDLE_CASES macro to simplify testing for which signaling
styles are handled by sig_pri.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211675 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 211583 via svnmerge from
Tilghman Lesher [Mon, 10 Aug 2009 19:49:41 +0000 (19:49 +0000)]
Merged revisions 211583 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r211583 | tilghman | 2009-08-10 14:48:48 -0500 (Mon, 10 Aug 2009) | 1 line

  Conversion specifiers, not format specifiers
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211584 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAST-2009-005
Tilghman Lesher [Mon, 10 Aug 2009 19:20:57 +0000 (19:20 +0000)]
AST-2009-005

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211539 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoadd manager events when a skinny device registers/unregisters
Michiel van Baak [Mon, 10 Aug 2009 18:01:47 +0000 (18:01 +0000)]
add manager events when a skinny device registers/unregisters
like we have in chan_sip

(closes issue #15499)
Reported by: arifzaman
Patches:
      2009072600-skinnymanagerevents.diff.txt uploaded by mvanbaak (license 7)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211475 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix PRI/BRI channels when in alarm condition to only be marked for hangup if
Jeff Peeler [Mon, 10 Aug 2009 17:17:06 +0000 (17:17 +0000)]
Fix PRI/BRI channels when in alarm condition to only be marked for hangup if
T309 is not enabled.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211435 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRestoring some code to sig_pri. Not sure if it is really needed.
Richard Mudgett [Mon, 10 Aug 2009 15:53:23 +0000 (15:53 +0000)]
Restoring some code to sig_pri.  Not sure if it is really needed.

Putting some DSP code back into sig_pri that was removed by the
chan_dahdi/sig_pri reorganization.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211392 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix up some issues with getting a channel by "name".
Russell Bryant [Mon, 10 Aug 2009 15:46:39 +0000 (15:46 +0000)]
Fix up some issues with getting a channel by "name".

Even though the get_channel_by_name() API advertised that you could search by
name or uniqueid (just as the old API did), searching by uniqueid was not
actually implemented.  This patch fixes that problem.

The ast_channel_get_full() function now makes a second search attempt by
uniqueid if the parameter was a name.  The channel comparison function also
now knows how to compare by unqieueid.

Finally, a bug was fixed in passing where OBJ_POINTER was being passed in some
scenarios where it should not have been.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211390 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix retrieval of the port used for the video stream when adding SDP to a SIP message.
Joshua Colp [Mon, 10 Aug 2009 14:07:44 +0000 (14:07 +0000)]
Fix retrieval of the port used for the video stream when adding SDP to a SIP message.

(closes issue #15121)
Reported by: jsmith

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211347 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 211274 via svnmerge from
Tilghman Lesher [Sun, 9 Aug 2009 15:42:02 +0000 (15:42 +0000)]
Merged revisions 211274 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r211274 | tilghman | 2009-08-09 10:41:01 -0500 (Sun, 09 Aug 2009) | 2 lines

  Small oops.  Clear the flags which have been checked.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211275 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCheck for NULL frame, before dereferencing pointer.
Tilghman Lesher [Sun, 9 Aug 2009 07:11:22 +0000 (07:11 +0000)]
Check for NULL frame, before dereferencing pointer.
(closes issue #15617)
 Reported by: rain

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211232 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFixed some unsafe down cast pointer operations for sig_pri.
Richard Mudgett [Fri, 7 Aug 2009 23:30:32 +0000 (23:30 +0000)]
Fixed some unsafe down cast pointer operations for sig_pri.

You cannot cast the struct dahdi_pvt.sig_pvt pointer to a specific
signaling private pointer without first checking that it is in fact
pointing to the correct signaling private structure.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211197 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix static on line when PRI does overlap dialing.
Richard Mudgett [Fri, 7 Aug 2009 23:17:41 +0000 (23:17 +0000)]
Fix static on line when PRI does overlap dialing.

The wrong encoding law was used because = was used when it should
have been ==.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211191 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRecorded merge of revisions 211112 via svnmerge from
Russell Bryant [Fri, 7 Aug 2009 20:12:21 +0000 (20:12 +0000)]
Recorded merge of revisions 211112 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r211112 | russell | 2009-08-07 15:11:31 -0500 (Fri, 07 Aug 2009) | 4 lines

  Resolve a deadlock involving app_chanspy and masquerades.

  (ABE-1936)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211113 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 211038 via svnmerge from
Tilghman Lesher [Fri, 7 Aug 2009 18:17:41 +0000 (18:17 +0000)]
Merged revisions 211038 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r211038 | tilghman | 2009-08-07 13:16:28 -0500 (Fri, 07 Aug 2009) | 14 lines

  QUEUE_MEMBER_LIST _really_ wants the interface name, not the membername.

  This is a partial revert of revision 82590, which was an attempted cleanup,
  but in reality, it broke QUEUE_MEMBER_LIST, which has always been intended
  as a method by which component interfaces could be queried from the queue.
  Membername isn't useful here, because that field cannot be used to obtain
  further information about the member.  See the documentation on
  QUEUE_MEMBER_LIST, RemoveQueueMember, QUEUE_MEMBER_PENALTY, and the various
  AMI commands which take a member argument for further justification.
  (closes issue #15664)
   Reported by: rain
   Patches:
         app_queue-queue_member_list.diff uploaded by rain (license 327)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@211040 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoWorkaround broken T.38 endpoints that offer tiny MaxDatagram sizes.
Kevin P. Fleming [Fri, 7 Aug 2009 13:08:00 +0000 (13:08 +0000)]
Workaround broken T.38 endpoints that offer tiny MaxDatagram sizes.

Some T.38 endpoints treat T38FaxMaxDatagram as the maximum IFP size that should
be sent to them, rather than the maximum packet payload size. If such an
endpoint also requests UDPRedundancy as the error correction mode, we'll end
up calculating a tiny maximum IFP size, so small as to be unusable. This patch
sets a lower bound on what we'll consider the remote's maximum IFP size to be,
assuming that endpoints that do this really can accept larger packets than
they've offered to accept.

(closes issue #15649)
Reported by: dazza76

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210992 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 210913 via svnmerge from
Tilghman Lesher [Thu, 6 Aug 2009 21:46:01 +0000 (21:46 +0000)]
Merged revisions 210913 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r210913 | tilghman | 2009-08-06 16:45:01 -0500 (Thu, 06 Aug 2009) | 7 lines

  Because channel information can be accessed outside of the channel thread, we must lock the channel prior to modifying it.
  (closes issue #15397)
   Reported by: caspy
   Patches:
         20090714__issue15397.diff.txt uploaded by tilghman (license 14)
   Tested by: caspy
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210914 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAllow Gosub to recognize quote delimiters without consuming them.
Tilghman Lesher [Thu, 6 Aug 2009 21:29:26 +0000 (21:29 +0000)]
Allow Gosub to recognize quote delimiters without consuming them.
(closes issue #15557)
 Reported by: rain
 Patches:
       20090723__issue15557.diff.txt uploaded by tilghman (license 14)
 Tested by: rain

Review: https://reviewboard.asterisk.org/r/316/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210908 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMiscellaneous minor fixes to sig_analog.
Richard Mudgett [Thu, 6 Aug 2009 20:15:11 +0000 (20:15 +0000)]
Miscellaneous minor fixes to sig_analog.

*  Sanity adjustments to __analog_ss_thread for sig_analog environment.
*  Deleted some duplicated code.
*  Fixed analog_ss_thread_start passing the wrong pointer.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210869 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoSanity adjustments to pri_ss_thread for sig_pri environment.
Richard Mudgett [Thu, 6 Aug 2009 19:52:11 +0000 (19:52 +0000)]
Sanity adjustments to pri_ss_thread for sig_pri environment.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210866 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAccept additional T.38 reinvites after an initial one has been handled.
Joshua Colp [Thu, 6 Aug 2009 17:47:04 +0000 (17:47 +0000)]
Accept additional T.38 reinvites after an initial one has been handled.

Discussion of this subject has yielded that it is not actually acceptable to change
T.38 parameters after the initial reinvite but declining is harsh and can cause the
fax to fail when it may be possible to allow it to continue. This patch changes things
so that additional T.38 reinvites are accepted but parameter changes ignored. This gives
the fax a fighting chance.

(closes issue #15610)
Reported by: huangtx2009

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210817 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMinor improvements to app_fax.
Kevin P. Fleming [Thu, 6 Aug 2009 16:07:15 +0000 (16:07 +0000)]
Minor improvements to app_fax.

This patch makes some small changes to handle watchdog timeouts in a better way,
and also uses a 'cleaner' method of including the spandsp header files.

(closes issue #14769)
Reported by: andrew
Patches:
      app_fax-20090406.diff uploaded by andrew (license 240)
      v1-14769.patch uploaded by dimas (license 88)
Tested by: freh, deti, caspy, dimas, sgimeno, Dovid

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210777 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix potential deadlock issue with USERUSERINFO channel variable.
Richard Mudgett [Wed, 5 Aug 2009 23:44:39 +0000 (23:44 +0000)]
Fix potential deadlock issue with USERUSERINFO channel variable.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210732 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMore changes from chan_dahdi that did not make it into sig_pri.
Richard Mudgett [Wed, 5 Aug 2009 22:46:37 +0000 (22:46 +0000)]
More changes from chan_dahdi that did not make it into sig_pri.

*  Q.SIG channel mapping option.
*  discardremoteholdretrieval option.
*  libPRI debug defines.
*  pri_set_overlapdial() now set correctly.
*  pthread creation of pri_ss_thread now matches.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210696 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 210575 via svnmerge from
Richard Mudgett [Wed, 5 Aug 2009 19:40:03 +0000 (19:40 +0000)]
Merged revisions 210575 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r210575 | rmudgett | 2009-08-05 14:18:56 -0500 (Wed, 05 Aug 2009) | 14 lines

  Dialplan starts execution before the channel setup is complete.

  *  Issue 15655: For the case where dialing is complete for an incoming
  call, dahdi_new() was asked to start the PBX and then the code set more
  channel variables.  If the dialplan hungup before these channel variables
  got set, asterisk would likely crash.
  *  Fixed potential for overlap incoming call to erroneously set channel
  variables as global dialplan variables if the ast_channel structure failed
  to get allocated.
  *  Added missing set of CALLINGSUBADDR in the dialing is complete case.

  (closes issue #15655)
  Reported by: alecdavis
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210640 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 210563 via svnmerge from
Leif Madsen [Wed, 5 Aug 2009 18:49:58 +0000 (18:49 +0000)]
Merged revisions 210563 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r210563 | lmadsen | 2009-08-05 13:46:21 -0500 (Wed, 05 Aug 2009) | 11 lines

  Update imapstorage.txt documentation.
  Updated the imapstorage.txt documentation to reflect that issues with
  c-client versions older than 2007 seem to cause crashing issues that
  are not seen with more recent versions. Documentation has been updated
  to reflect this.

  (closes issue #14496)
  Reported by: vbcrlfuser
  Patches:
        __20090727-imap-documentation-patch.txt uploaded by lmadsen (license 10)
  Tested by: lmadsen, mmichelson, dbrooks
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210564 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRevert some silly code that snuck into trunk from my working copy. Sorry!
Russell Bryant [Wed, 5 Aug 2009 14:09:24 +0000 (14:09 +0000)]
Revert some silly code that snuck into trunk from my working copy.  Sorry!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210522 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoignore the .i files when compiling in 'DONT_OPTIMIZE' in the addons/mp3 directory
Michiel van Baak [Wed, 5 Aug 2009 08:03:36 +0000 (08:03 +0000)]
ignore the .i files when compiling in 'DONT_OPTIMIZE' in the addons/mp3 directory

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210478 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 210067 via svnmerge
David Brooks [Tue, 4 Aug 2009 18:59:36 +0000 (18:59 +0000)]
Blocked revisions 210067 via svnmerge

........
  r210067 | dbrooks | 2009-08-03 11:15:20 -0500 (Mon, 03 Aug 2009) | 11 lines

  Fixes dialplan wildcard extension taking precedence over call pickup code.

  Prior to this patch, a wildcard extension in the dialplan (for example, _*.) would take
  precedence over picking up a call in the channel's pickup group. This patch simply moves
  the block of code handling pickup group matching to above the extension matching code.

  (closes issue #14735)
  Reported by: stevedavies

  Review: https://reviewboard.asterisk.org/r/319/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210436 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix CALLERID() values for sig_pri on incoming calls.
Richard Mudgett [Tue, 4 Aug 2009 17:46:03 +0000 (17:46 +0000)]
Fix CALLERID() values for sig_pri on incoming calls.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210387 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoInitial minimum ast_party_caller support.
Richard Mudgett [Tue, 4 Aug 2009 16:36:41 +0000 (16:36 +0000)]
Initial minimum ast_party_caller support.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210354 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemoved some dead code.
Richard Mudgett [Tue, 4 Aug 2009 16:36:03 +0000 (16:36 +0000)]
Removed some dead code.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210353 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix broken call pickup
Jeff Peeler [Tue, 4 Aug 2009 15:35:49 +0000 (15:35 +0000)]
Fix broken call pickup

The find_channel_by_group callback was only looking at the channel that was
attempting to make the pickup instead of the other channels in the container.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210302 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 210237 via svnmerge from
Kevin P. Fleming [Tue, 4 Aug 2009 14:53:00 +0000 (14:53 +0000)]
Merged revisions 210237 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r210237 | kpfleming | 2009-08-04 09:51:39 -0500 (Tue, 04 Aug 2009) | 10 lines

  Eliminate spurious compiler warnings from system headers on *BSD platforms.

  Ensure that system headers located in /usr/local/include are actually treated
  as system headers by the compiler, and not as local headers which are subject
  to warnings from the -Wundef compiler option and others.

  (closes issue #15606)
  Reported by: mvanbaak
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210238 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRename 'canreinvite' option to 'directmedia', with backwards compatibility.
Kevin P. Fleming [Mon, 3 Aug 2009 20:48:48 +0000 (20:48 +0000)]
Rename 'canreinvite' option to 'directmedia', with backwards compatibility.

It is clear from multiple mailing list, forum, wiki and other sorts of posts
that users don't really understand the effects that the 'canreinvite' config
option actually has, and that in some cases they think that setting it to 'no'
will actually cause various other features (T.38, MOH, etc.) to not work properly,
when in fact this is not the case. This patch changes the proper name of the
option to what it should have been from the beginning ('directmedia'), but
preserves backwards compatibility for existing configurations.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210190 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoChanges from chan_dahdi that did not make it into sig_pri.
Richard Mudgett [Mon, 3 Aug 2009 18:05:46 +0000 (18:05 +0000)]
Changes from chan_dahdi that did not make it into sig_pri.

*  Moved SUPPORT_USERUSER to sig_pri.c
*  Fix PRI_DEADLOCK_AVOIDANCE parameter.
*  Whitespace changes.
*  Added missing unlock in pri_dchannel():PRI_EVENT_RING case.
*  Balanced curly braces.
*  ast_debug/ast_log changes from chan_dahdi.
*  sig_pri_indicate() should default to return -1 if the indication is not
handled.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210154 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoTrim trailing whitespace.
Richard Mudgett [Mon, 3 Aug 2009 16:24:13 +0000 (16:24 +0000)]
Trim trailing whitespace.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210094 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 210064-210066 via svnmerge
Tilghman Lesher [Mon, 3 Aug 2009 16:16:40 +0000 (16:16 +0000)]
Blocked revisions 210064-210066 via svnmerge

........
  r210064 | tilghman | 2009-08-03 10:39:41 -0500 (Mon, 03 Aug 2009) | 4 lines

  Apparently, some platforms don't have the index() function.
  (closes issue #15639)
   Reported by: nmav
........
  r210065 | tilghman | 2009-08-03 10:42:10 -0500 (Mon, 03 Aug 2009) | 3 lines

  Helps if we export the index() function.
  (Related to issue #15639)
........
  r210066 | tilghman | 2009-08-03 11:11:29 -0500 (Mon, 03 Aug 2009) | 3 lines

  Reverting index() fix, applying a different methodology, based upon developer discussions.
  (related to issue #15639)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210068 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix order and redundancy of channel rename manager events in ast_do_masquerade.
Mark Michelson [Mon, 3 Aug 2009 14:29:17 +0000 (14:29 +0000)]
Fix order and redundancy of channel rename manager events in ast_do_masquerade.

Patch contributed by Mark Spencer.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210027 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd an 'sms' option to mobile.conf to manually enable or disable SMS support.
Matthew Nicholson [Mon, 3 Aug 2009 14:01:39 +0000 (14:01 +0000)]
Add an 'sms' option to mobile.conf to manually enable or disable SMS support.

(closes issue #15071)
Reported by: ughnz
Patches:
      optional-sms1.diff uploaded by mnicholson (license 96)
Tested by: ughnz, mnicholson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209993 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoUpdate documentation in relation to UnixODBC
Bradley Latus [Sat, 1 Aug 2009 23:33:31 +0000 (23:33 +0000)]
Update documentation in relation to UnixODBC

(closes issue #15516)
Reported by: snuffy
Patches:
      bug_odbc_tex_update_v2.diff uploaded by snuffy (license 35)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209959 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years ago(closes issue #15515)
Bradley Latus [Sat, 1 Aug 2009 23:25:16 +0000 (23:25 +0000)]
(closes issue #15515)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209958 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 209879 via svnmerge from
Russell Bryant [Sat, 1 Aug 2009 11:29:25 +0000 (11:29 +0000)]
Merged revisions 209879 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r209879 | russell | 2009-08-01 06:27:25 -0500 (Sat, 01 Aug 2009) | 5 lines

  Resolve a valgrind warning about a read from uninitialized memory.

  (issue #15396)
  Reported by: aragon
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209887 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 209838 via svnmerge from
Russell Bryant [Sat, 1 Aug 2009 11:02:07 +0000 (11:02 +0000)]
Merged revisions 209838 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r209838 | russell | 2009-08-01 05:59:05 -0500 (Sat, 01 Aug 2009) | 13 lines

  Modify how Playtones() is used in Milliwatt() to resolve gain issue.

  When Milliwatt() was changed internally to use Playtones() so that the proper
  tone was used, it introduced a drop in gain in the output signal.  So, use
  the playtones API directly and specify a volume argument such that the output
  matches the gain of the original Milliwatt() code.

  (closes issue #15386)
  Reported by: rue_mohr
  Patches:
        issue_15386.rev2.diff uploaded by russell (license 2)
  Tested by: rue_mohr
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209839 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix ast_event_queue_and_cache() to actually do the cache() part.
Russell Bryant [Sat, 1 Aug 2009 10:43:40 +0000 (10:43 +0000)]
Fix ast_event_queue_and_cache() to actually do the cache() part.

(closes issue #15624)
Reported by: ffossard
Tested by: russell

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209835 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRevert accidental Makefile change.
Kevin P. Fleming [Sat, 1 Aug 2009 01:04:06 +0000 (01:04 +0000)]
Revert accidental Makefile change.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209761 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 209759 via svnmerge from
Kevin P. Fleming [Sat, 1 Aug 2009 01:03:07 +0000 (01:03 +0000)]
Merged revisions 209759 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r209759 | kpfleming | 2009-07-31 19:52:00 -0500 (Fri, 31 Jul 2009) | 7 lines

  Minor changes inspired by testing with latest GCC.

  The latest GCC (what will become 4.5.x) has a few new warnings, that in these
  cases found some either downright buggy code, or at least seriously poorly
  designed code that could be improved.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209760 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix some places where ast_event_type was used instead of ast_event_ie_type.
Russell Bryant [Fri, 31 Jul 2009 21:53:31 +0000 (21:53 +0000)]
Fix some places where ast_event_type was used instead of ast_event_ie_type.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209711 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd configuration sample code for previous commit.
Mark Michelson [Fri, 31 Jul 2009 17:57:00 +0000 (17:57 +0000)]
Add configuration sample code for previous commit.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209674 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoImprove chan_sip's ability to determine what methods should and should not be used...
Mark Michelson [Fri, 31 Jul 2009 17:55:44 +0000 (17:55 +0000)]
Improve chan_sip's ability to determine what methods should and should not be used in a dialog.

The previous effort here was to store what a peer is capable of receiving by parsing REGISTER
requests from the peer and keeping that information for as long as the registration was active.
The problem with this is that there are a great number of SIP devices which give no indication
of the methods allowed in their REGISTER requests, and it is unreasonable to try to guess what
the device may or may not support. In addition, some SIP devices have been found to claim support
for a specific method, but their handling the method is less than ideal, or they are actually
lying.

With this patch, we now determine what methods a device supports  by parsing the Allow header we
receive from them, and we do this with each new dialog. In addition, a configuration option has
been added so that an administrator can essentially blacklist certain methods from being used
with certain peers if the admin knows that support for a specific method is dodgy or nonexistent.

ABE-1822

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209673 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAllow passing 'noisy' to configure's --enable-dev-mode argument to turn on verbose...
Sean Bright [Thu, 30 Jul 2009 23:37:31 +0000 (23:37 +0000)]
Allow passing 'noisy' to configure's --enable-dev-mode argument to turn on verbose builds.

(closes issue #15607)
Reported by: mvanbaak
Patches:
      20090730_issue15607.patch uploaded by seanbright (license 71)
Tested by: seanbright

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209623 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoAdd missing ifdef-s for service maintenance message functionality
Jeff Peeler [Thu, 30 Jul 2009 23:31:41 +0000 (23:31 +0000)]
Add missing ifdef-s for service maintenance message functionality

(closes issue #15614)
Reported by: fabled

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209619 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFixes numerous spelling errors. Patch submitted by alecdavis.
David Brooks [Thu, 30 Jul 2009 16:07:05 +0000 (16:07 +0000)]
Fixes numerous spelling errors. Patch submitted by alecdavis.

(closes issue #15595)
Reported by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209554 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFix a crash that can result if text codecs are allowed but textsupport is disabled.
Mark Michelson [Thu, 30 Jul 2009 14:38:21 +0000 (14:38 +0000)]
Fix a crash that can result if text codecs are allowed but textsupport is disabled.

(closes issue #15596)
Reported by: fabled
Patches:
      sip-red.patch uploaded by fabled (license 448)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209516 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoThis patch adds the ability to send a CUSD command to a bluetooth device.
Matthew Nicholson [Wed, 29 Jul 2009 21:46:17 +0000 (21:46 +0000)]
This patch adds the ability to send a CUSD command to a bluetooth device.

(closes issue #15278)
Reported by: Artem
Patches:
      cusd5.patch uploaded by Artem (license 800)
Tested by: mnicholson, Artem

Review: https://reviewboard.asterisk.org/r/274/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209484 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFixed a comment for hfp_parse_clip
Matthew Nicholson [Wed, 29 Jul 2009 21:13:42 +0000 (21:13 +0000)]
Fixed a comment for hfp_parse_clip

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209453 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoDefine side-effect-safe MIN and MAX macros and remove duplicate definitions from...
Kevin P. Fleming [Tue, 28 Jul 2009 13:49:46 +0000 (13:49 +0000)]
Define side-effect-safe MIN and MAX macros and remove duplicate definitions from various files.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209400 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRegex FTL
Tilghman Lesher [Tue, 28 Jul 2009 00:20:26 +0000 (00:20 +0000)]
Regex FTL

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209331 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 209315 via svnmerge from
Tilghman Lesher [Tue, 28 Jul 2009 00:14:12 +0000 (00:14 +0000)]
Merged revisions 209315 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r209315 | tilghman | 2009-07-27 19:12:03 -0500 (Mon, 27 Jul 2009) | 2 lines

  Publish French extra sounds
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209317 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoCleanup T.38 negotiation changes.
Kevin P. Fleming [Mon, 27 Jul 2009 21:43:36 +0000 (21:43 +0000)]
Cleanup T.38 negotiation changes.

Convert LOG_NOTICE messages about T.38 negotiation in debug level 1 messages,
clean up some looping logic, and correct an improper use of ast_free() for
freeing an ast_frame.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209279 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMake T.38 switchover in ReceiveFAX synchronous.
Kevin P. Fleming [Mon, 27 Jul 2009 21:21:43 +0000 (21:21 +0000)]
Make T.38 switchover in ReceiveFAX synchronous.

In receive mode, if the channel that ReceiveFAX is running on supports T.38,
we should *always* attempt to switch T.38, rather than listening for an incoming
CNG tone and only triggering on that. The channel may be using a low-bitrate
codec that distorts the CNG tone, the sending FAX endpoint may not send CNG
at all, or there could be a variety of other reasons that we don't detect it,
but in all those cases if T.38 is available we certainly want to use it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209256 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoGracefully handle malformed RTP text packets.
Mark Michelson [Mon, 27 Jul 2009 20:54:54 +0000 (20:54 +0000)]
Gracefully handle malformed RTP text packets.

AST-2009-004

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209235 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoHonor channel's music class when using realtime music on hold.
Mark Michelson [Mon, 27 Jul 2009 20:11:42 +0000 (20:11 +0000)]
Honor channel's music class when using realtime music on hold.

(closes issue #15051)
Reported by: alexh
Patches:
      15051.patch uploaded by mmichelson (license 60)
Tested by: alexh

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209197 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 209131 via svnmerge from
Mark Michelson [Mon, 27 Jul 2009 17:50:04 +0000 (17:50 +0000)]
Merged revisions 209131 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r209131 | mmichelson | 2009-07-27 12:44:06 -0500 (Mon, 27 Jul 2009) | 18 lines

  Allow for UDPTL to use only even-numbered ports if desired.

  There are some VoIP providers out there that will not accept SDP
  offers with odd numbered UDPTL ports. While it is my personal opinion
  that these VoIP providers are misinterpreting RFC 2327, it really is
  not a big deal to play along with their silly little games. Of course,
  since restricting UDPTL ports to only even numbers reduces the range
  of available ports by half, so the option to use only even port numbers
  is off by default. A user can enable the behavior by setting
  use_even_ports=yes in udptl.conf.

  (closes issue #15182)
  Reported by: CGMChris
  Patches:
        15182.patch uploaded by mmichelson (license 60)
  Tested by: CGMChris
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209132 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoFixing typos. Replaces "recieved" with "received" and "initilize" with "initialize"
David Brooks [Mon, 27 Jul 2009 16:33:50 +0000 (16:33 +0000)]
Fixing typos. Replaces "recieved" with "received" and "initilize" with "initialize"

(closes issue #15571)
Reported by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209098 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRestore explicit export of ASTCFLAGS/ASTLDFLAGS and underscore-variants to sub-makes.
Kevin P. Fleming [Mon, 27 Jul 2009 15:38:59 +0000 (15:38 +0000)]
Restore explicit export of ASTCFLAGS/ASTLDFLAGS and underscore-variants to sub-makes.

During the recent Makefile improvements I made, it seemed the 'make' was
automatically carrying down the ASTCFLAGS/ASTLDFLAGS settings to sub-makes,
so I removed the explict export of them. However, there are some circumstances
where make does this, and some where it does not, so I've brought them back
to ensure they are always exported. I also removed an extraneous double setting
of _ASTLDFLAGS on *BSD platforms.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209056 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoBlocked revisions 208990 via svnmerge
Michiel van Baak [Mon, 27 Jul 2009 09:56:49 +0000 (09:56 +0000)]
Blocked revisions 208990 via svnmerge

........
  r208990 | mvanbaak | 2009-07-27 11:56:13 +0200 (Mon, 27 Jul 2009) | 5 lines

  backport rev 205532 from trunk:

  pthread_self returns a pthread_t which is not an unsigned int on all
  pthread implementations. Casting it to an unsigned int fixes compiler warnings.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@208991 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 208923 via svnmerge from
Jeff Peeler [Mon, 27 Jul 2009 01:20:37 +0000 (01:20 +0000)]
Merged revisions 208923 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r208923 | jpeeler | 2009-07-26 20:18:31 -0500 (Sun, 26 Jul 2009) | 2 lines

  Fix logic errors from 208746
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@208924 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoadd OpenBSD to the install_prereq script
Michiel van Baak [Sun, 26 Jul 2009 14:00:52 +0000 (14:00 +0000)]
add OpenBSD to the install_prereq script

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@208886 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agolibxml2-dev is needed as well by default.
Michiel van Baak [Sat, 25 Jul 2009 12:28:38 +0000 (12:28 +0000)]
libxml2-dev is needed as well by default.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@208848 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoadd default alias reload to run module reload.
Michiel van Baak [Sat, 25 Jul 2009 12:03:25 +0000 (12:03 +0000)]
add default alias reload to run module reload.

Requiring 'module reload' to reload everything, including
core etc makes russell very unhappy.

The default configuration already loads the 'friendly' aliases template.
Added 'reload=module reload' to that template.

Also removed the comment in main/cli.c that reload should come back.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@208813 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoMerged revisions 208746 via svnmerge from
Jeff Peeler [Sat, 25 Jul 2009 06:23:18 +0000 (06:23 +0000)]
Merged revisions 208746 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r208746 | jpeeler | 2009-07-25 01:19:50 -0500 (Sat, 25 Jul 2009) | 7 lines

  Fix compiling under dev-mode with gcc 4.4.0.

  Mostly trivial changes, but I did not know of any other way to fix the
  "dereferencing type-punned pointer will break strict-aliasing rules" error
  without creating a tmp variable in chan_skinny.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@208749 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoRemove trailing whitespace.
Russell Bryant [Fri, 24 Jul 2009 21:12:43 +0000 (21:12 +0000)]
Remove trailing whitespace.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@208709 65c4cc65-6c06-0410-ace0-fbb531ad65f3

10 years agoNote that "reload" needs to be added back.
Russell Bryant [Fri, 24 Jul 2009 20:54:37 +0000 (20:54 +0000)]
Note that "reload" needs to be added back.

I keep getting annoyed at having to type "module reload" to reload everything,
so I'm adding a note that we need to add "reload" back.  "module reload" doesn't
really make sense as the command to reload everything, including the core.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@208706 65c4cc65-6c06-0410-ace0-fbb531ad65f3