asterisk/asterisk.git
12 years agoChange the number of line keys per registration from 2 to 1
Doug Bailey [Fri, 11 Apr 2008 22:09:04 +0000 (22:09 +0000)]
Change the number of line keys per registration from 2 to 1

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114077 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoBlocked revisions 114072 via svnmerge
Jason Parker [Fri, 11 Apr 2008 21:39:44 +0000 (21:39 +0000)]
Blocked revisions 114072 via svnmerge

Already fixed here.

........
r114072 | qwell | 2008-04-11 16:35:16 -0500 (Fri, 11 Apr 2008) | 4 lines

It's possible that a channel can have an async goto on the successful execution of an application as well.

Closes issue #12172.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114073 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoFix the fact that global_variables 1) weren't being updated on reload (thanks for...
Terry Wilson [Fri, 11 Apr 2008 21:04:46 +0000 (21:04 +0000)]
Fix the fact that global_variables 1) weren't being updated on reload (thanks for the report, Doug), and 2) weren't actually being appended to the list of profile variables because build_profile was called before the list was populated. Also needed to free the contents returned by load_file().

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114067 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 114063 via svnmerge from
Mark Michelson [Fri, 11 Apr 2008 15:49:35 +0000 (15:49 +0000)]
Merged revisions 114063 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114063 | mmichelson | 2008-04-11 10:44:28 -0500 (Fri, 11 Apr 2008) | 11 lines

Fix a race condition that may happen between a sip hangup
and a "core show channel" command. This patch adds locking
to prevent the resulting crash.

(closes issue #12155)
Reported by: tsearle
Patches:
      show_channels_crash2.patch uploaded by tsearle (license 373)
Tested by: tsearle

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114064 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoErrors are all greater than 0
Tilghman Lesher [Fri, 11 Apr 2008 14:54:22 +0000 (14:54 +0000)]
Errors are all greater than 0
(closes issue #12422)
 Reported by: nito
 Patches:
       res_config_ldap_result_check_patch.diff uploaded by nito (license 340)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114061 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 114051 via svnmerge from
Mark Michelson [Thu, 10 Apr 2008 22:02:32 +0000 (22:02 +0000)]
Merged revisions 114051 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114051 | mmichelson | 2008-04-10 15:59:49 -0500 (Thu, 10 Apr 2008) | 3 lines

Fix 1.4 build when LOW_MEMORY is enabled.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114052 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoA 'b' option has been added which causes chan_local to return the actual channel...
Joshua Colp [Thu, 10 Apr 2008 20:28:40 +0000 (20:28 +0000)]
A 'b' option has been added which causes chan_local to return the actual channel that is behind it when queried. This is useful for transfer scenarios as the actual channel will be transferred, not the Local channel. If you have been using Local channels as queue members and having issues when the agent did a blind transfer this option may solve the issue.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114049 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 114045 via svnmerge from
Mark Michelson [Thu, 10 Apr 2008 19:58:36 +0000 (19:58 +0000)]
Merged revisions 114045 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114045 | mmichelson | 2008-04-10 14:55:33 -0500 (Thu, 10 Apr 2008) | 6 lines

Be sure that we're not about to set bridgepvt NULL prior to dereferencing it.

(closes issue #11775)
Reported by: fujin

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114046 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoThe hydra grows yet another head...
Tilghman Lesher [Thu, 10 Apr 2008 19:04:29 +0000 (19:04 +0000)]
The hydra grows yet another head...
(closes issue #12401)
 Reported by: davevg
 Patches:
       astcli.diff2 uploaded by davevg (license 209)
 Tested by: davevg, Corydon76

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114042 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 114035 via svnmerge from
Jason Parker [Thu, 10 Apr 2008 17:27:16 +0000 (17:27 +0000)]
Merged revisions 114035 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114035 | qwell | 2008-04-10 12:26:10 -0500 (Thu, 10 Apr 2008) | 10 lines

Only try to prefix language if we are not using an absolute path (suffix it otherwise).

en/var/lib/asterisk/sounds/blah.gsm is a very silly path.

(closes issue #12379)
Reported by: kuj
Patches:
      12379-absolutepath.diff uploaded by qwell (license 4)
Tested by: kuj, qwell

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114036 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoBlocked revisions 114032 via svnmerge
Joshua Colp [Thu, 10 Apr 2008 15:59:13 +0000 (15:59 +0000)]
Blocked revisions 114032 via svnmerge

........
r114032 | file | 2008-04-10 12:58:39 -0300 (Thu, 10 Apr 2008) | 6 lines

Forgot the 1.4 branch for russian language fix.
(closes issue #12404)
Reported by: IgorG
Patches:
      voicemail_ru_hardcoded-v1.patch uploaded by IgorG (license 20)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114033 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 114029 via svnmerge from
Joshua Colp [Thu, 10 Apr 2008 15:10:47 +0000 (15:10 +0000)]
Merged revisions 114029 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114029 | file | 2008-04-10 12:09:04 -0300 (Thu, 10 Apr 2008) | 6 lines

Create the directory where name recordings will go if it does not exist.
(closes issue #12311)
Reported by: rkeene
Patches:
      12311-mkdir.diff uploaded by qwell (license 4)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114030 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoDon't hardcode ru into the digits filename so that languageprefix can work.
Joshua Colp [Thu, 10 Apr 2008 14:53:19 +0000 (14:53 +0000)]
Don't hardcode ru into the digits filename so that languageprefix can work.
(closes issue #12404)
Reported by: IgorG
Patches:
      voicemail_ru_hardcoded-v1.patch uploaded by IgorG (license 20)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114027 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoFix spelling of existent in a few places.
Joshua Colp [Thu, 10 Apr 2008 13:45:45 +0000 (13:45 +0000)]
Fix spelling of existent in a few places.
(closes issue #12409)
Reported by: candlerb

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114024 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 114021 via svnmerge from
Joshua Colp [Thu, 10 Apr 2008 13:28:30 +0000 (13:28 +0000)]
Merged revisions 114021 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114021 | file | 2008-04-10 10:27:11 -0300 (Thu, 10 Apr 2008) | 6 lines

Don't add custom URI options if they don't exist OR they are empty.
(closes issue #12407)
Reported by: homesick
Patches:
      uri_options-1.4.diff uploaded by homesick (license 91)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114022 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoFix a crash that happened due to accessing free'd memory
Mark Michelson [Wed, 9 Apr 2008 22:32:32 +0000 (22:32 +0000)]
Fix a crash that happened due to accessing free'd memory

(closes issue #12396)
Reported by: tcalosi
Patches:
      12396.patch uploaded by putnopvut (license 60)
  Tested by: tcalosi

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113980 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 113927 via svnmerge from
Mark Michelson [Wed, 9 Apr 2008 20:56:14 +0000 (20:56 +0000)]
Merged revisions 113927 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113927 | mmichelson | 2008-04-09 15:54:31 -0500 (Wed, 09 Apr 2008) | 8 lines

We need to set the persistant_route [sic] parameter for the sip_pvt
during the initial INVITE, no matter if we're building the route set from
an INVITE request or response.

(closes issue #12391)
Reported by: benjaminbohlmann
Tested by: benjaminbohlmann

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113928 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 113874 via svnmerge from
Tilghman Lesher [Wed, 9 Apr 2008 19:00:40 +0000 (19:00 +0000)]
Merged revisions 113874 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113874 | tilghman | 2008-04-09 13:57:33 -0500 (Wed, 09 Apr 2008) | 4 lines

If the [csv] section does not exist in cdr.conf, then an unload/load sequence
is needed to correct the problem.  Track whether the load succeeded with a
variable, so we can fix this with a simple reload event, instead.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113875 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoEnable enough RTP bridging to allow P2P to work.
Joshua Colp [Wed, 9 Apr 2008 18:05:40 +0000 (18:05 +0000)]
Enable enough RTP bridging to allow P2P to work.
(closes issue #11901)
Reported by: pj

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113840 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoFix a small file handle "leak" pointed out by jjshoe on #asterisk.
Jason Parker [Wed, 9 Apr 2008 17:56:07 +0000 (17:56 +0000)]
Fix a small file handle "leak" pointed out by jjshoe on #asterisk.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113838 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoThere was a subtle logical difference between 1.4 and trunk with regards to how timeouts
Mark Michelson [Wed, 9 Apr 2008 17:48:33 +0000 (17:48 +0000)]
There was a subtle logical difference between 1.4 and trunk with regards to how timeouts
were handled. In 1.4, if the absolute timeout were reached on a call, no matter what
the return value of ast_spawn_extension was, the pbx would attempt to go to the 'T'
extension or hangup otherwise. The rearrangement of this function in trunk made this check
only happen in the case that ast_spawn_extension returned 0. If ast_spawn_extension returned
1, then the fact that the timeout expired resulted in a no-op, and would cause an infinite
loop to occur in __ast_pbx_run. This change fixes this problem. Now timeouts will
behave as they did in 1.4

(closes issue #11550)
Reported by: pj
Tested by: putnopvut

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113836 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMove all messages wrapped in skinnydebug from debug to verbose.
Jason Parker [Wed, 9 Apr 2008 17:41:09 +0000 (17:41 +0000)]
Move all messages wrapped in skinnydebug from debug to verbose.

(closes issue #12224)
Reported by: DEA
Patches:
      chan_skinny-debug-log.txt uploaded by DEA (license 3)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113834 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 113784 via svnmerge from
Joshua Colp [Wed, 9 Apr 2008 16:52:04 +0000 (16:52 +0000)]
Merged revisions 113784 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113784 | file | 2008-04-09 13:50:45 -0300 (Wed, 09 Apr 2008) | 4 lines

If we receive an AUTHREQ from the remote server and we are unable to reply (for example they have a secret configured, but we do not) then queue a hangup frame on the Asterisk channel. This will cause the channel to hangup and a HANGUP to be sent via IAX2 to the remote side which is the proper thing to do in this scenario.
(closes issue #12385)
Reported by: viraptor

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113785 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMark recent additions from #11954 and #12254
Tilghman Lesher [Wed, 9 Apr 2008 16:23:30 +0000 (16:23 +0000)]
Mark recent additions from #11954 and #12254

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113752 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoPermit message wrap-around during message retrieval.
Tilghman Lesher [Wed, 9 Apr 2008 16:16:44 +0000 (16:16 +0000)]
Permit message wrap-around during message retrieval.
(closes issue #12254)
 Reported by: andrew
 Patches:
       bug-12253.diff uploaded by snuffy (license 35)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113731 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 113681 via svnmerge from
Mark Michelson [Wed, 9 Apr 2008 14:41:58 +0000 (14:41 +0000)]
Merged revisions 113681 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113681 | mmichelson | 2008-04-09 09:40:05 -0500 (Wed, 09 Apr 2008) | 9 lines

If Asterisk receives a 488 on an INVITE (not a reinvite), then
we should not send a BYE.

(closes issue #12392)
Reported by: fnordian
Patches:
      chan_sip.patch uploaded by fnordian (license 110) with small modification from me

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113682 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoPermit callee to continue in the dialplan, after caller has hung up.
Tilghman Lesher [Wed, 9 Apr 2008 13:55:28 +0000 (13:55 +0000)]
Permit callee to continue in the dialplan, after caller has hung up.
(closes issue #11954)
 Reported by: johan
 Patches:
       app_dial_rev104031.patch uploaded by johan (license 334)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113649 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoAdditional enhancements
Tilghman Lesher [Wed, 9 Apr 2008 13:23:44 +0000 (13:23 +0000)]
Additional enhancements
(closes issue #12390)
 Reported by: tzafrir
 Patches:
       astcli_fixes.diff uploaded by tzafrir (license 46)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113647 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 113596 via svnmerge from
Terry Wilson [Wed, 9 Apr 2008 01:36:58 +0000 (01:36 +0000)]
Merged revisions 113596 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113596 | twilson | 2008-04-08 20:34:25 -0500 (Tue, 08 Apr 2008) | 2 lines

Initialize fr->cacheable to make valgrind happy

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113597 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoAdd commandline tool for doing CLI commands through AMI (instead of using asterisk...
Tilghman Lesher [Tue, 8 Apr 2008 21:33:11 +0000 (21:33 +0000)]
Add commandline tool for doing CLI commands through AMI (instead of using asterisk -rx)
(closes issue #12389)
 Reported by: davevg
 Patches:
       astcli uploaded by davevg (license 209)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113559 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoBlocked revisions 113507 via svnmerge
Mark Michelson [Tue, 8 Apr 2008 19:09:16 +0000 (19:09 +0000)]
Blocked revisions 113507 via svnmerge

........
r113507 | mmichelson | 2008-04-08 14:07:38 -0500 (Tue, 08 Apr 2008) | 8 lines

Fix potential buffer overflow that could happen if more than 100 announce files
were specified when calling ParkAndAnnounce. This overflow is not exploitable remotely
and so there is no need for a security advisory.

(closes issue #12386)
Reported by: davidw

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113508 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 113504 via svnmerge from
Jason Parker [Tue, 8 Apr 2008 18:49:21 +0000 (18:49 +0000)]
Merged revisions 113504 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113504 | qwell | 2008-04-08 13:48:55 -0500 (Tue, 08 Apr 2008) | 1 line

Add a little more that is required for previously added devices.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113505 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 113454 via svnmerge from
Jason Parker [Tue, 8 Apr 2008 18:08:35 +0000 (18:08 +0000)]
Merged revisions 113454 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113454 | qwell | 2008-04-08 13:07:49 -0500 (Tue, 08 Apr 2008) | 4 lines

Add support for several new(ish) devices - most notably, 7942/7945, 7962/7965, 7975.

Thanks to Greg Oliver for providing me the required information.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113455 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMove AST_FEATURE_FLAG_* and FEATURE_RETURN_* to features.h so that they can be used...
Jason Parker [Tue, 8 Apr 2008 17:32:42 +0000 (17:32 +0000)]
Move AST_FEATURE_FLAG_* and FEATURE_RETURN_* to features.h so that they can be used by modules.

(closes issue #12384)
Reported by: fnordian
Patches:
      features.patch uploaded by fnordian (license 110)

(patch modified by me, to give FEATURE_RETURN_* an AST_ prefix)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113452 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 113402 via svnmerge from
Jason Parker [Tue, 8 Apr 2008 17:00:55 +0000 (17:00 +0000)]
Merged revisions 113402 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113402 | qwell | 2008-04-08 11:56:52 -0500 (Tue, 08 Apr 2008) | 1 line

Work around some silliness caused by sys/capability.h - this should fix compile errors a number of users have been experiencing.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113403 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 113399 via svnmerge from
Tilghman Lesher [Tue, 8 Apr 2008 16:54:21 +0000 (16:54 +0000)]
Merged revisions 113399 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113399 | tilghman | 2008-04-08 11:51:28 -0500 (Tue, 08 Apr 2008) | 6 lines

Add security note on astgenkey's manpage.
(closes issue #12373)
 Reported by: lmamane
 Patches:
       20080406__bug12373.diff.txt uploaded by Corydon76 (license 14)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113400 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 113348 via svnmerge from
Tilghman Lesher [Tue, 8 Apr 2008 15:48:58 +0000 (15:48 +0000)]
Merged revisions 113348 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113348 | tilghman | 2008-04-08 10:39:16 -0500 (Tue, 08 Apr 2008) | 7 lines

Move check for still-bridged channels out a little further, to avoid possible
deadlocks.  (Closes issue #12252)
Reported by: callguy
 Patches:
       20080319__bug12252.diff.txt uploaded by Corydon76 (license 14)
 Tested by: callguy

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113349 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 113296 via svnmerge from
Joshua Colp [Tue, 8 Apr 2008 15:05:35 +0000 (15:05 +0000)]
Merged revisions 113296 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113296 | file | 2008-04-08 12:03:43 -0300 (Tue, 08 Apr 2008) | 4 lines

If audio suddenly gets fed into one side of a channel after a lapse of frames flush the other factory so that old audio does not remain in the factory causing the sync code to not execute.
(closes issue #12296)
Reported by: jvandal

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113297 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoAdditional note
Tilghman Lesher [Mon, 7 Apr 2008 22:16:46 +0000 (22:16 +0000)]
Additional note

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113245 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoDocument 'originate' permission in manager sample config.
Jason Parker [Mon, 7 Apr 2008 21:49:27 +0000 (21:49 +0000)]
Document 'originate' permission in manager sample config.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113243 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 113013 via svnmerge from
Jeff Peeler [Mon, 7 Apr 2008 21:35:48 +0000 (21:35 +0000)]
Merged revisions 113013 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r113013 | jpeeler | 2008-04-07 10:18:10 -0500 (Mon, 07 Apr 2008) | 15 lines

Merged revisions 113012 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113012 | jpeeler | 2008-04-07 10:16:44 -0500 (Mon, 07 Apr 2008) | 7 lines

(closes issue #12362)
(closes issue #12372)
Reported by: vinsik
Tested by: tecnoxarxa

This one line change makes an if inside a for loop (in realtime_peer) check all the ast_variables the loop was intending to test rather than just the first one.

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113241 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoThis is a "fix" for something that's been bugging the crap out of me for a while.
Mark Michelson [Mon, 7 Apr 2008 20:22:06 +0000 (20:22 +0000)]
This is a "fix" for something that's been bugging the crap out of me for a while.
The variable name "flag" to distinguish between whether a message is being forwarded or
is new is not a helpful name. The newly added doxygen documentation to app_voicemail is
tremendously helpful, but I still just...hate this variable name. I think is_new_message
is more indicative of what its purpose is.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113207 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 113117 via svnmerge from
Tilghman Lesher [Mon, 7 Apr 2008 19:06:46 +0000 (19:06 +0000)]
Merged revisions 113117 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113117 | tilghman | 2008-04-07 12:51:49 -0500 (Mon, 07 Apr 2008) | 3 lines

Force ast_mktime() to check for DST, since strptime(3) does not.
(Closes issue #12374)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113172 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoatoi(NULL) is bad
Terry Wilson [Mon, 7 Apr 2008 18:57:21 +0000 (18:57 +0000)]
atoi(NULL) is bad

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113170 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 113118 via svnmerge from
Jason Parker [Mon, 7 Apr 2008 18:02:51 +0000 (18:02 +0000)]
Merged revisions 113118 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113118 | qwell | 2008-04-07 13:00:09 -0500 (Mon, 07 Apr 2008) | 8 lines

Allow playback with noanswer (and add earlyrtp option).

(closes issue #9077)
Reported by: pj
Patches:
      earlyrtp.diff uploaded by wedhorn (license 30)
Tested by: pj, qwell, DEA, wedhorn

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113119 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 113065 via svnmerge from
Mark Michelson [Mon, 7 Apr 2008 16:12:30 +0000 (16:12 +0000)]
Merged revisions 113065 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113065 | mmichelson | 2008-04-07 11:08:45 -0500 (Mon, 07 Apr 2008) | 13 lines

This fix prevents a deadlock that was experienced in chan_local. There was
deadlock prevention in place in chan_local, but it would not work in a specific
case because the channel was recursively locked. By unlocking the channel prior
to calling the generator's generate callback in ast_read_generator_actions(), we
prevent the recursive locking, and therefore the deadlock.

(closes issue #12307)
Reported by: callguy
Patches:
      12307.patch uploaded by putnopvut (license 60)
Tested by: callguy

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113066 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 113012 via svnmerge from
Jeff Peeler [Mon, 7 Apr 2008 15:18:10 +0000 (15:18 +0000)]
Merged revisions 113012 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113012 | jpeeler | 2008-04-07 10:16:44 -0500 (Mon, 07 Apr 2008) | 7 lines

(closes issue #12362)
(closes issue #12372)
Reported by: vinsik
Tested by: tecnoxarxa

This one line change makes an if inside a for loop (in realtime_peer) check all the ast_variables the loop was intending to test rather than just the first one.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113013 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoPut my slinfactory changes back in.
Joshua Colp [Mon, 7 Apr 2008 14:54:42 +0000 (14:54 +0000)]
Put my slinfactory changes back in.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113009 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoAsyncAGI should not close the manager session on error.
Tilghman Lesher [Sat, 5 Apr 2008 13:24:12 +0000 (13:24 +0000)]
AsyncAGI should not close the manager session on error.
(closes issue #12370)
 Reported by: srt
 Patches:
       asterisk-12370.diff uploaded by srt (license 378)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112972 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoClean up some memory leak/ref counting issues
Terry Wilson [Sat, 5 Apr 2008 07:58:42 +0000 (07:58 +0000)]
Clean up some memory leak/ref counting issues

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112939 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMulti-line support for phoneprov
Terry Wilson [Sat, 5 Apr 2008 04:59:25 +0000 (04:59 +0000)]
Multi-line support for phoneprov

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112906 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoFound a little problem with the sip request handling that could lead to a quick crash...
Steve Murphy [Sat, 5 Apr 2008 01:33:13 +0000 (01:33 +0000)]
Found a little problem with the sip request handling that could lead to a quick crash of asterisk, and a road to a DOS attack if left unfixed.

Attaching to a running asterisk with "telnet hostname 5060", I would input "something", then hit return three times, and asterisk crashes.

I traced it to handle_request_do(), which zeroes out the data (an ast_str ptr) if the string is too short.
Instead of freeing the struct and nulling the pointer, it now just resets it, because this
ast_str is expected by the calling routine to still be there after handle_request_do() returns.

This appears to fix the crash. I assume that it was introduced with ast_str's being adopted.  It's a subtle and easy-to-miss sort of problem.

I also found all the places where the req.data is freed, and made sure the ptr is Nulled out as well;
no good leaving bad ptrs laying around-- I didn't need to do this, but it seemed a good thing to do...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112874 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 112820 via svnmerge from
Philippe Sultan [Fri, 4 Apr 2008 19:28:49 +0000 (19:28 +0000)]
Merged revisions 112820 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112820 | phsultan | 2008-04-04 21:26:15 +0200 (Fri, 04 Apr 2008) | 1 line

Free newly allocated channel before returning
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112821 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 112766 via svnmerge from
Philippe Sultan [Fri, 4 Apr 2008 17:32:46 +0000 (17:32 +0000)]
Merged revisions 112766 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112766 | phsultan | 2008-04-04 19:16:59 +0200 (Fri, 04 Apr 2008) | 7 lines

Prevent call connections when codecs don't match.

(closes issue #10604)
Reported by: keepitcool
Patches:
      branch-1.4-10604-2.diff uploaded by phsultan (license 73)
Tested by: phsultan
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112785 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agosleep long enough for the zaptel timer error message to display before exit
Dwayne M. Hubbard [Fri, 4 Apr 2008 00:57:33 +0000 (00:57 +0000)]
sleep long enough for the zaptel timer error message to display before exit

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112714 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 112711 via svnmerge from
Joshua Colp [Fri, 4 Apr 2008 00:53:19 +0000 (00:53 +0000)]
Merged revisions 112711 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112711 | file | 2008-04-03 21:52:36 -0300 (Thu, 03 Apr 2008) | 2 lines

Pass in the path to Zaptel for systems that install Zaptel headers in a separate location.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112712 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoBlocked revisions 112709 via svnmerge
Joshua Colp [Fri, 4 Apr 2008 00:49:01 +0000 (00:49 +0000)]
Blocked revisions 112709 via svnmerge

........
r112709 | file | 2008-04-03 21:48:01 -0300 (Thu, 03 Apr 2008) | 2 lines

One thing at a time... let's get 1.4 building.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112710 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoblocked for trunk....woot
Dwayne M. Hubbard [Fri, 4 Apr 2008 00:32:05 +0000 (00:32 +0000)]
blocked for trunk....woot

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112708 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agosatisfy buildbot
Dwayne M. Hubbard [Thu, 3 Apr 2008 22:19:43 +0000 (22:19 +0000)]
satisfy buildbot

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112656 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoadd a Zaptel timer check to verify the timer is responding when Zaptel support is...
Dwayne M. Hubbard [Thu, 3 Apr 2008 22:13:11 +0000 (22:13 +0000)]
add a Zaptel timer check to verify the timer is responding when Zaptel support is compiled into Asterisk and Zaptel drivers are loaded.  This will help people not waste their valuable time debugging side effects.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112653 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 112599 via svnmerge from
Mark Michelson [Thu, 3 Apr 2008 14:35:47 +0000 (14:35 +0000)]
Merged revisions 112599 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112599 | mmichelson | 2008-04-03 09:32:20 -0500 (Thu, 03 Apr 2008) | 9 lines

Fix the testing of the "res" variable so that it is more logically correct and
makes the correct warning and debug messages print.

(closes issue #12361)
Reported by: one47
Patches:
      chan_zap_deferred_digit.patch uploaded by one47 (license 23)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112600 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoUse a 32k file buffer on recordings, which increases the efficiency of file recording.
Tilghman Lesher [Thu, 3 Apr 2008 07:49:05 +0000 (07:49 +0000)]
Use a 32k file buffer on recordings, which increases the efficiency of file recording.
(closes issue #11962)
 Reported by: garlew
 Patches:
       recording.patch uploaded by garlew (license 376)
       bug-11962.diff uploaded by snuffy (license 35)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112564 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMake MISDN generate channel rename events when the name changes.
Tilghman Lesher [Wed, 2 Apr 2008 19:34:52 +0000 (19:34 +0000)]
Make MISDN generate channel rename events when the name changes.
(closes issue #11142)
 Reported by: julianjm
 Patches:
       chan_misdn_tmpchan_trunk_v1.diff uploaded by julianjm (license 99)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112520 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 112468 via svnmerge from
Mark Michelson [Wed, 2 Apr 2008 17:36:49 +0000 (17:36 +0000)]
Merged revisions 112468 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112468 | mmichelson | 2008-04-02 12:36:04 -0500 (Wed, 02 Apr 2008) | 13 lines

Fix a race condition in the manager. It is possible that a new manager event
could be appended during a brief time when the manager is not waiting for input.
If an event comes during this period, we need to set an indicator that there is an
event pending so that the manager doesn't attempt to wait forever for an event that
already happened.

(closes issue #12354)
Reported by: bamby
Patches:
      manager_race_condition.diff uploaded by bamby (license 430)
  (comments added by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112469 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoSince the SIP request structure gets reused multiple times with TCP handling we have...
Joshua Colp [Wed, 2 Apr 2008 15:26:51 +0000 (15:26 +0000)]
Since the SIP request structure gets reused multiple times with TCP handling we have to clear the debug state or else we will keep spitting out debug even after it has been turned off.
(closes issue #12169)
Reported by: pj
Patches:
      12169-debugoff-2.diff uploaded by qwell (license 4)
Tested by: pj

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112431 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoRe-add HTTP post support by moving to res_http_post.c
Terry Wilson [Wed, 2 Apr 2008 15:25:48 +0000 (15:25 +0000)]
Re-add HTTP post support by moving to res_http_post.c

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112426 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 112393 via svnmerge from
Mark Michelson [Wed, 2 Apr 2008 14:32:43 +0000 (14:32 +0000)]
Merged revisions 112393 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112393 | mmichelson | 2008-04-02 09:32:00 -0500 (Wed, 02 Apr 2008) | 6 lines

Ensure that there is no timeout if none is specified.

(closes issue #12349)
Reported by: johnlange

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112394 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoAdded dnsmgr status output for sip show registry.
Jeff Peeler [Tue, 1 Apr 2008 22:55:28 +0000 (22:55 +0000)]
Added dnsmgr status output for sip show registry.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112360 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoBumped across another test set for the new exten pattern matcher, which revealed...
Steve Murphy [Tue, 1 Apr 2008 22:45:10 +0000 (22:45 +0000)]
Bumped across another test set for the new exten pattern matcher, which revealed a problem with the CANMATCH/MATCHMORE modes. Direct matches were getting in the way. Fixed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112357 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoFix a typo that prevented configuration of non-dynamic peers.
Russell Bryant [Tue, 1 Apr 2008 22:25:45 +0000 (22:25 +0000)]
Fix a typo that prevented configuration of non-dynamic peers.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112351 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoExisting DNS manager lookups extended to check for SRV records.
Jeff Peeler [Tue, 1 Apr 2008 22:07:30 +0000 (22:07 +0000)]
Existing DNS manager lookups extended to check for SRV records.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112321 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years ago(closes issue #12298)
Steve Murphy [Tue, 1 Apr 2008 20:02:19 +0000 (20:02 +0000)]
(closes issue #12298)
Reported by: falves11
Patches:
      12298.patch1 uploaded by murf (license 17)
Tested by: murf

I have hopes that the changes made over the last few days will
finalize and solidify this code. While there are bound to be
small tweaks still needed, I feel that the job (at last) is
somewhat completed. Finally, I had a chance to comprehend how
the scoring of extension patterns was done in the previous
version, and I've come very close to using the exact same
criteria in the new pattern matching code. The left-right
sorting is now replicated in the trie structure itself, such
that the first match found will the 'best' match. Compared
the results against 1.4 for several extensions. Replicated
falves11's setup and it works. Used some devious patterns
provided by jsmith, supplemented with a few of my own.
Looks good.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112289 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMinor formatting cleanup.
Jason Parker [Tue, 1 Apr 2008 18:27:08 +0000 (18:27 +0000)]
Minor formatting cleanup.

(closes issue #12343)
Reported by: travishein
Patches:
      app_voicemail_code_convention.patch uploaded by travishein (license 385)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112252 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMore voicemail doxygen additions/cleanup.
Jason Parker [Tue, 1 Apr 2008 18:24:56 +0000 (18:24 +0000)]
More voicemail doxygen additions/cleanup.

(issue #12343)
Reported by: travishein
Patches:
      app_voicemail_code_documentation.patch uploaded by travishein (license 385)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112241 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoFix last commit
Tilghman Lesher [Tue, 1 Apr 2008 18:23:40 +0000 (18:23 +0000)]
Fix last commit

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112234 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 112209 via svnmerge from
Joshua Colp [Tue, 1 Apr 2008 18:06:13 +0000 (18:06 +0000)]
Merged revisions 112209 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112209 | file | 2008-04-01 15:02:43 -0300 (Tue, 01 Apr 2008) | 4 lines

Disable Packet2Packet bridging when we need to feed DTMF frames into the core. Some implementations do not like how we switch between things.
(closes issue #12212)
Reported by: bamby

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112210 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoThis adds DNS SRV record support to DNS manager. If there is a SRV record for a...
Jeff Peeler [Tue, 1 Apr 2008 17:53:08 +0000 (17:53 +0000)]
This adds DNS SRV record support to DNS manager.  If there is a SRV record for a given domain, the hostname and port listed in the SRV record will be used. If no SRV record exists or a SRV lookup is not attempted, the DNS lookup on the specified domain will be performed as normal. Chan_sip has been modified to take advantage of the new SRV support.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112207 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 112204 via svnmerge from
Joshua Colp [Tue, 1 Apr 2008 17:48:52 +0000 (17:48 +0000)]
Merged revisions 112204 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112204 | file | 2008-04-01 14:43:46 -0300 (Tue, 01 Apr 2008) | 4 lines

Do not pass audio until the remote side has indicated they are providing early media, or if the channel has been answered.
(closes issue #11823)
Reported by: SDamm

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112205 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoDemote a log message down to a warning.
Joshua Colp [Tue, 1 Apr 2008 17:24:45 +0000 (17:24 +0000)]
Demote a log message down to a warning.
(closes issue #12345)
Reported by: caio1982
Patches:
      limit_msg.diff uploaded by caio1982 (license 22)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112155 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 112138 via svnmerge from
Mark Michelson [Tue, 1 Apr 2008 17:23:19 +0000 (17:23 +0000)]
Merged revisions 112138 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112138 | mmichelson | 2008-04-01 12:21:21 -0500 (Tue, 01 Apr 2008) | 10 lines

Initialize the __res_state structure used for dns purposes
to all 0's prior to using it. This is due to valgrind's complaints
on issue #12284 as well as an excerpt found in "Description" portion
of the online man page found here:

http://www.iti.cs.tu-bs.de/cgi-bin/UNIXhelp/man-cgi?res_nquery+3RESOLV

(pertains to issue #12284 but does not necessarily close it)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112148 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 112125 via svnmerge from
Joshua Colp [Tue, 1 Apr 2008 16:50:37 +0000 (16:50 +0000)]
Merged revisions 112125 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112125 | file | 2008-04-01 13:45:14 -0300 (Tue, 01 Apr 2008) | 5 lines

Ensure that we do not exceed the hold's maximum size with a single frame.
(closes issue #12047)
Reported by: fabianoheringer
Tested by: fabianoheringer

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112126 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoNow that zaptel trunk has been removed, add the PSTN deprecation notice to chan_zap...
Russell Bryant [Tue, 1 Apr 2008 16:35:04 +0000 (16:35 +0000)]
Now that zaptel trunk has been removed, add the PSTN deprecation notice to chan_zap, as well.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112124 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoI missed a place when this define was changed.
Jason Parker [Mon, 31 Mar 2008 22:16:34 +0000 (22:16 +0000)]
I missed a place when this define was changed.

(closes issue #12334)
Reported by: ovi
Patches:
      12334-asterisk.patch uploaded by dimas (license 88)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112071 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 112068 via svnmerge from
Jason Parker [Mon, 31 Mar 2008 21:48:30 +0000 (21:48 +0000)]
Merged revisions 112068 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r112068 | qwell | 2008-03-31 16:48:05 -0500 (Mon, 31 Mar 2008) | 5 lines

Fix a silly infinite loop when choosing an invalid option.

(closes issue #12315)
Reported by: jmls

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112069 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoYeah, simplify that logic a bit...
Terry Wilson [Mon, 31 Mar 2008 21:01:59 +0000 (21:01 +0000)]
Yeah, simplify that logic a bit...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112035 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoHandle blank prefix= in http.conf
Terry Wilson [Mon, 31 Mar 2008 20:45:05 +0000 (20:45 +0000)]
Handle blank prefix= in http.conf

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112033 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoEnsure configure gets run on a clean checkout.
Russell Bryant [Mon, 31 Mar 2008 17:14:58 +0000 (17:14 +0000)]
Ensure configure gets run on a clean checkout.

(closes issue #12197)
Reported by: juggie
Patches:
      12197.diff uploaded by juggie (license 24)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111998 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoThis fixes a high fence violation that MALLOC_DEBUG reported to me.
Russell Bryant [Mon, 31 Mar 2008 16:37:13 +0000 (16:37 +0000)]
This fixes a high fence violation that MALLOC_DEBUG reported to me.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111996 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoInitialize all these here tmp pointers at declaration. They confused some compilers...
Joshua Colp [Mon, 31 Mar 2008 14:20:39 +0000 (14:20 +0000)]
Initialize all these here tmp pointers at declaration. They confused some compilers a wee bit.
(closes issue #12333)
Reported by: ovi

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111961 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMake some notes about common usage of pbx_builtin_getvar_helper() that is not
Russell Bryant [Fri, 28 Mar 2008 22:50:46 +0000 (22:50 +0000)]
Make some notes about common usage of pbx_builtin_getvar_helper() that is not
thread-safe.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111909 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoNote a minor race condition that I noticed while reviewing Jeff's changes
Russell Bryant [Fri, 28 Mar 2008 22:45:43 +0000 (22:45 +0000)]
Note a minor race condition that I noticed while reviewing Jeff's changes
to this code.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111908 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 111856 via svnmerge from
Jason Parker [Fri, 28 Mar 2008 21:46:02 +0000 (21:46 +0000)]
Merged revisions 111856 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111856 | qwell | 2008-03-28 16:45:35 -0500 (Fri, 28 Mar 2008) | 12 lines

Allow gsm to compile correctly on x86 with gcc4 optimizations.

(closes issue #11243)
Reported by: whiskerp
Patches:
      11243-maybe-asm.diff uploaded by qwell (license 4)
Tested by: Seggy (IRC)

Note: While I did write this patch, I would not have found this if fossil
 had not reported and fixed issue #12253.  A huge thanks to him for helping
 to (indirectly) find the problem here.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111857 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoThis time the fix is proper for issue 12284. I have tested it thoroughly and found
Mark Michelson [Fri, 28 Mar 2008 20:03:16 +0000 (20:03 +0000)]
This time the fix is proper for issue 12284. I have tested it thoroughly and found
that valgrind no longer complains and that calls do complete correctly.

The fix is along the same lines as before: Make sure the final null terminator gets copied
into the new sip_request's data pointer. Without it, parse_request will read and potentially
write past the end of the string, causing potential crashes.

(closes issue #12284...for real this time!)
reported by falves11

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111811 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoTemporary revert of 111662. It's causing lots of trouble and appears to not be
Mark Michelson [Fri, 28 Mar 2008 19:14:51 +0000 (19:14 +0000)]
Temporary revert of 111662. It's causing lots of trouble and appears to not be
the proper solution to the problem reported anyway.

(related to issue #12884)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111777 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoReplace magic number size from msgArray array with a define.
Jason Parker [Fri, 28 Mar 2008 19:08:35 +0000 (19:08 +0000)]
Replace magic number size from msgArray array with a define.

(same patch as before, I just split this part out)
(close issue #12326)
Reported by: travishein
Patches:
      app_voicemail_code_documentation.patch uploaded by travishein (license 385)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111774 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoAdd a bit of doxygen documentation for app_voicemail.
Jason Parker [Fri, 28 Mar 2008 19:06:54 +0000 (19:06 +0000)]
Add a bit of doxygen documentation for app_voicemail.

(issue #12326)
Reported by: travishein
Patches:
      app_voicemail_code_documentation.patch uploaded by travishein (license 385)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111773 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 111720 via svnmerge from
Jason Parker [Fri, 28 Mar 2008 17:57:12 +0000 (17:57 +0000)]
Merged revisions 111720 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111720 | qwell | 2008-03-28 12:55:05 -0500 (Fri, 28 Mar 2008) | 1 line

Remove unimplemented softkeys.  Prompted by issue #12325.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111721 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoThe copy_request function did not take into account the necessary null terminator
Mark Michelson [Fri, 28 Mar 2008 16:36:59 +0000 (16:36 +0000)]
The copy_request function did not take into account the necessary null terminator
for the string to be copied into. This resulted in parse_request reading invalid
memory beyond the end of the string, and in some cases led to crashes. Thanks
to falves11 for providing the valgrind output which led to the closure of this issue.

(closes issue #12284)
Reported by: falves11

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111662 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 111658 via svnmerge from
Jason Parker [Fri, 28 Mar 2008 16:20:59 +0000 (16:20 +0000)]
Merged revisions 111658 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111658 | qwell | 2008-03-28 11:19:56 -0500 (Fri, 28 Mar 2008) | 8 lines

The file size of WAV49 does not need to be an even number.

(closes issue #12128)
Reported by: mdu113
Patches:
      12128-noevenlength.diff uploaded by qwell (license 4)
Tested by: qwell, mdu113

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111659 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 111605 via svnmerge from
Tilghman Lesher [Fri, 28 Mar 2008 14:37:28 +0000 (14:37 +0000)]
Merged revisions 111605 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r111605 | tilghman | 2008-03-28 09:35:45 -0500 (Fri, 28 Mar 2008) | 3 lines

Update debugging text, since Valgrind eliminated the --log-file-exactly option.
(Closes issue #12320)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111606 65c4cc65-6c06-0410-ace0-fbb531ad65f3